Re: [libvirt] [RFC PATCH 02/12] conf: Add support for parsing and formatting max memory and slot count

2015-02-05 Thread Eric Blake
On 01/30/2015 06:20 AM, Peter Krempa wrote: Add a XML element that will allow to specify maximum supportable memory s/a XML/an XML/ and the count of memory slots to use with memory hotplug. Might be nice to demonstrate that XML here in the commit message, not just in formatdomain.html. To

Re: [libvirt] [PATCH] check fc_host and vport_ops capabilities in SCSI host nodedevs

2015-02-05 Thread Shivaprasad bhat
On Thu, Feb 5, 2015 at 6:13 PM, John Ferlan jfer...@redhat.com wrote: ...snip... Had a chance to try your patch. # cat testCaps.py import libvirt conn = libvirt.openReadOnly('qemu:///system') fc = conn.nodeDeviceLookupByName('scsi_host1') caps = fc.listCaps(); print The capabilities are,

Re: [libvirt] [PATCH] check fc_host and vport_ops capabilities in SCSI host nodedevs

2015-02-05 Thread Shivaprasad bhat
On Wed, Feb 4, 2015 at 8:39 PM, Shivaprasad bhat shivaprasadb...@gmail.com wrote: On Wed, Feb 4, 2015 at 7:25 PM, John Ferlan jfer...@redhat.com wrote: On 02/03/2015 03:59 PM, John Ferlan wrote: On 02/03/2015 06:55 AM, Shivaprasad G Bhat wrote: fc_host vport_ops devices are SCSI devices

Re: [libvirt] [PATCH] check fc_host and vport_ops capabilities in SCSI host nodedevs

2015-02-05 Thread John Ferlan
...snip... Had a chance to try your patch. # cat testCaps.py import libvirt conn = libvirt.openReadOnly('qemu:///system') fc = conn.nodeDeviceLookupByName('scsi_host1') caps = fc.listCaps(); print The capabilities are, caps nCaps = fc.numOfCaps(); print The number of Caps : , nCaps

Re: [libvirt] [PATCH v3] qemu: Pass file descriptor when using TPM passthrough

2015-02-05 Thread Stefan Berger
On 01/30/2015 07:17 PM, Eric Blake wrote: +} +i++; +} + +return -1; +} + /** * virCommandSetPidFile: * @cmd: the command to modify diff --git a/src/util/vircommand.h b/src/util/vircommand.h index bf65de4..198da2f 100644 --- a/src/util/vircommand.h +++

[libvirt] [PATCH 0/2] Interface backend attribute improvements

2015-02-05 Thread Ján Tomko
Both for https://bugzilla.redhat.com/show_bug.cgi?id=1147195 Ján Tomko (2): Only parse custom vhost path for virtio interfaces Error out when custom tap device path makes no sense src/conf/domain_conf.c | 6 +++- src/qemu/qemu_command.c

[libvirt] [PATCH 1/2] Only parse custom vhost path for virtio interfaces

2015-02-05 Thread Ján Tomko
It is not used for other network interface models. https://bugzilla.redhat.com/show_bug.cgi?id=1147195 --- src/conf/domain_conf.c | 6 +++- .../qemuxml2argv-tap-vhost-incorrect.xml | 39 ++ .../qemuxml2xmlout-tap-vhost-incorrect.xml

Re: [libvirt] [PATCH] check fc_host and vport_ops capabilitis in SCSI host nodedevs

2015-02-05 Thread John Ferlan
On 02/03/2015 06:52 AM, Shivaprasad G Bhat wrote: virNodeListDevices called by listDevices indirectly uses the virNodeDeviceHasCap() which is buggy. Earlier, virNodeListDevices was used in virsh nodedev-list as well. Though, the code was rewritten to use vshNodeDeviceListCollect instead.

[libvirt] [PATCH 2/2] Error out when custom tap device path makes no sense

2015-02-05 Thread Ján Tomko
It is only usable for NETWORK and BRIDGE type interfaces. Error out when trying to start a domain where the custom tap device path is specified for interfaces of other types, or when the daemon is not privileged. Note that this cannot be checked at definition time, because the comparison is

[libvirt] 答复: Re: [PATCH 0/3] Prevent removing a in-used static bridge and destroying a in-used virtual network

2015-02-05 Thread Lin Ma
Daniel P. Berrange berra...@redhat.com 2015-2-4 下午 23:10 On Wed, Feb 04, 2015 at 02:21:18AM -0500, Laine Stump wrote: On 02/03/2015 11:47 AM, Michal Privoznik wrote: On 02.02.2015 15:08, Lin Ma wrote: * Get the live state info of a virtual network through netcf in networkGetXMLDesc. *

Re: [libvirt] [libvirt-test-API][PATCH 0/2] Add API openGraphicsFD test case

2015-02-05 Thread jiahu
On 01/06/2015 02:50 PM, Jincheng Miao wrote: Add API openGraphicsFD test case to linux_domain.conf Jincheng Miao (2): domain: add open_graphicsfd Add open_graphicsFD to linux_domain.conf cases/linux_domain.conf | 14 ++ repos/domain/open_graphicsfd.py | 89

[libvirt] [PATCH 1/5] Also store features blocking migration as CPUx86Data in the cpu map

2015-02-05 Thread Ján Tomko
Allowing their use with x86Data* helpers for easier filtering. --- src/cpu/cpu_x86.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 45be262..f6e8eec 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@

[libvirt] [PATCH 2/5] Add VIR_CONNECT_BASELINE_CPU_MIGRATABLE flag

2015-02-05 Thread Ján Tomko
This flag for virConnectBaselineCPU will allow filtering out CPU features that block migration from the result. https://bugzilla.redhat.com/show_bug.cgi?id=1171484 --- include/libvirt/libvirt-host.h | 1 + src/libvirt-host.c | 3 +++ 2 files changed, 4 insertions(+) diff --git

[libvirt] 答复: Re: [PATCH 1/3] bridge_driver: Return the live state info of a given virtual network

2015-02-05 Thread Lin Ma
Daniel P. Berrange berra...@redhat.com 2015-2-4 下午 17:17 On Mon, Feb 02, 2015 at 10:08:21PM +0800, Lin Ma wrote: It constructs a temporary static config of the network, Obtains all of attached interfaces information through netcf, Then removes the config. Signed-off-by: Lin Ma ---

[libvirt] 答复: Re: [PATCH 0/3] Prevent removing a in-used static bridge and destroying a in-used virtual network

2015-02-05 Thread Lin Ma
Daniel P. Berrange berra...@redhat.com 2015-2-4 下午 23:10 On Wed, Feb 04, 2015 at 02:21:18AM -0500, Laine Stump wrote: On 02/03/2015 11:47 AM, Michal Privoznik wrote: On 02.02.2015 15:08, Lin Ma wrote: * Get the live state info of a virtual network through netcf in networkGetXMLDesc. *

Re: [libvirt] [PATCH 01/10] libxl: update dom-id in libxlDomainCreateWithFlags

2015-02-05 Thread Jim Fehlig
Marek Marczykowski-Górecki wrote: Otherwise domainCreateWithFlags via remote returns -1 as domid. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libxl/libxl_driver.c

Re: [libvirt] [PATCH 2/2] Error out when custom tap device path makes no sense

2015-02-05 Thread John Ferlan
On 02/05/2015 07:52 AM, Ján Tomko wrote: It is only usable for NETWORK and BRIDGE type interfaces. Error out when trying to start a domain where the custom tap device path is specified for interfaces of other types, or when the daemon is not privileged. Note that this cannot be checked at

Re: [libvirt] [PATCH] qemu: Properly report error when cookin uuid not match the ctxt uuid

2015-02-05 Thread Ján Tomko
On Thu, Feb 05, 2015 at 11:42:26AM +0800, Luyao Huang wrote: Add the missing jump to the error label when cookin uuid does not match the ctxt uuid. 'cookie uuid' and 'ctxt uuid' don't seem clear enough to me. I have reworded the commit message: Add the missing jump to the error label when the

[libvirt] [PATCH 0/5] Add VIR_CONNECT_BASELINE_CPU_MIGRATABLE flag

2015-02-05 Thread Ján Tomko
Add a flag to virConnectBaselineCPU to filter out features that block migration. Ján Tomko (5): Also store features blocking migration as CPUx86Data in the cpu map Add VIR_CONNECT_BASELINE_CPU_MIGRATABLE flag Implement VIR_CONNECT_BASELINE_CPU_MIGRATABLE in the x86 cpu driver Trivially

[libvirt] [PATCH 3/5] Implement VIR_CONNECT_BASELINE_CPU_MIGRATABLE in the x86 cpu driver

2015-02-05 Thread Ján Tomko
Subtract the migrate blocker data from the result if this flag was specified. --- src/bhyve/bhyve_driver.c| 3 +- src/cpu/cpu_x86.c | 9 +- src/qemu/qemu_driver.c | 3 +- tests/cputest.c

[libvirt] [PATCH 5/5] Add --migratable support to virsh cpu-baseline

2015-02-05 Thread Ján Tomko
Wire up VIR_CONNECT_BASELINE_CPU_MIGRATABLE to this command line option. --- tools/virsh-domain.c | 6 ++ tools/virsh.pod | 5 +++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index bab44fe..2b4f06d 100644 ---

Re: [libvirt] [PATCH 02/10] conf: support backend domain name in disk and network devices

2015-02-05 Thread Jim Fehlig
Marek Marczykowski-Górecki wrote: At least Xen supports backend drivers in another domain (aka driver domain). This patch introduces XML config option for such setting as 'domain' attribute of 'source' element. Verification its content is left for the driver. In the future same option will

Re: [libvirt] [PATCH 04/10] libxl: fill HVM SDL and VNC settings based on graphics/ entries

2015-02-05 Thread Jim Fehlig
Marek Marczykowski-Górecki wrote: Vfb entries in domain config are used only by PV drivers. Qemu parameters are build based on b_info struct. So fill it with the same data as vfb entries (actually the first one). This will additionally allow graphic-less domain, when no graphics/ entries are

Re: [libvirt] [PATCH 05/10] libxl: pass ipaddr to libxl toolstack

2015-02-05 Thread Jim Fehlig
Marek Marczykowski-Górecki wrote: Do not silently ignore its value. LibXL support only one address, so refuse multiple IPs. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_conf.c | 5 + src/libxl/libxl_domain.c | 11 +++ 2 files

Re: [libvirt] [RFC PATCH 01/12] qemu: caps: Add capability bit for the pc-dimm device

2015-02-05 Thread Eric Blake
On 01/30/2015 06:20 AM, Peter Krempa wrote: The pc-dimm device represents a RAM memory module. --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_2.1.1-1.caps | 1 + 3 files changed, 4 insertions(+)

Re: [libvirt] [PATCH 01/10] libxl: update dom-id in libxlDomainCreateWithFlags

2015-02-05 Thread Marek Marczykowski-Górecki
On Thu, Feb 05, 2015 at 02:25:41PM -0700, Jim Fehlig wrote: Marek Marczykowski-Górecki wrote: Otherwise domainCreateWithFlags via remote returns -1 as domid. Signed-off-by: Marek Marczykowski-Górecki marma...@invisiblethingslab.com --- src/libxl/libxl_driver.c | 3 +++ 1 file

Re: [libvirt] [PATCH] network: don't allow multiple portgroups with the same name in a network

2015-02-05 Thread Eric Blake
On 02/05/2015 12:29 PM, Laine Stump wrote: When defining and creating networks, we have been checking to make sure there is only a single default portgroup, but haven't verified that no two portgroups have the same name. We *do* check for multiple definitions when updating the portgroups in an

Re: [libvirt] [PATCHv3] Trivially support DomainHasManagedSaveImage

2015-02-05 Thread Eric Blake
On 02/05/2015 01:48 AM, Ján Tomko wrote: Return 0 instead of ERR_NO_SUPPORT in each driver where we don't support managed save or -1 if the domain does not exist. This avoids spamming daemon logs when 'virsh dominfo' is run. https://bugzilla.redhat.com/show_bug.cgi?id=1095637 --- ACK

Re: [libvirt] [PATCH 2/5] Add VIR_CONNECT_BASELINE_CPU_MIGRATABLE flag

2015-02-05 Thread Jiri Denemark
On Thu, Feb 05, 2015 at 15:47:53 +0100, Ján Tomko wrote: This flag for virConnectBaselineCPU will allow filtering out CPU features that block migration from the result. https://bugzilla.redhat.com/show_bug.cgi?id=1171484 --- include/libvirt/libvirt-host.h | 1 + src/libvirt-host.c

[libvirt] 答复: Re: [PATCH 3/3] virsh: prevent removing a in-used bridge for iface-unbridge

2015-02-05 Thread Lin Ma
Laine Stump la...@laine.org 2015-2-4 下午 17:12 On 02/03/2015 11:39 AM, Michal Privoznik wrote: On 02.02.2015 15:08, Lin Ma wrote: By checking transient interfaces, It obtains the live information of attached interfaces to see if the bridge is in use. Signed-off-by: Lin Ma ---

Re: [libvirt] [PATCH 5/5] Add --migratable support to virsh cpu-baseline

2015-02-05 Thread Jiri Denemark
On Thu, Feb 05, 2015 at 15:47:56 +0100, Ján Tomko wrote: Wire up VIR_CONNECT_BASELINE_CPU_MIGRATABLE to this command line option. --- tools/virsh-domain.c | 6 ++ tools/virsh.pod | 5 +++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c

Re: [libvirt] [PATCH] Fix reporting of i/o errors by iohelper process

2015-02-05 Thread Jason J. Herne
Hello Eric, it has been quite a while since we have looked at this :). I'm revisiting this problem and I find that it still exists. Here is an archive link of our previous discussions on this: https://www.redhat.com/archives/libvir-list/2014-July/thread.html#00809 Basically, when I do a

Re: [libvirt] [PATCH] qemu: Properly report error when cookin uuid not match the ctxt uuid

2015-02-05 Thread lhuang
On 02/05/2015 03:14 PM, Ján Tomko wrote: On Thu, Feb 05, 2015 at 11:42:26AM +0800, Luyao Huang wrote: Add the missing jump to the error label when cookin uuid does not match the ctxt uuid. 'cookie uuid' and 'ctxt uuid' don't seem clear enough to me. I have reworded the commit message: Add

[libvirt] [PATCHv3] Trivially support DomainHasManagedSaveImage

2015-02-05 Thread Ján Tomko
Return 0 instead of ERR_NO_SUPPORT in each driver where we don't support managed save or -1 if the domain does not exist. This avoids spamming daemon logs when 'virsh dominfo' is run. https://bugzilla.redhat.com/show_bug.cgi?id=1095637 --- src/bhyve/bhyve_driver.c | 25 +-

Re: [libvirt] [PATCH 1/2] Only parse custom vhost path for virtio interfaces

2015-02-05 Thread John Ferlan
On 02/05/2015 07:52 AM, Ján Tomko wrote: It is not used for other network interface models. A little light here... Something along the lines of only supporting backend vhost attribute for virtio adapters and quietly dropping it for any other definition...

[libvirt] [PATCH] network: don't allow multiple portgroups with the same name in a network

2015-02-05 Thread Laine Stump
When defining and creating networks, we have been checking to make sure there is only a single default portgroup, but haven't verified that no two portgroups have the same name. We *do* check for multiple definitions when updating the portgroups in an existing network though. This patch adds a