Re: [libvirt] [Xen-devel] [PATCH 0/2] libxl: fix handling of fd and timer registrations

2015-02-17 Thread Jim Fehlig
Jim Fehlig wrote: > Anthony PERARD wrote: > >> On Mon, Feb 02, 2015 at 05:00:34PM -0700, Jim Fehlig wrote: >> >> >>> This small series fixes some assertions we occasionally see in the >>> libxl driver when running libvirt-TCK. The assertions were due to >>> races between destroying per-

[libvirt] [PATCH 04/10] libxl: Move setup of child processing code to driver initialization

2015-02-17 Thread Jim Fehlig
Informing libxl how to handle its child proceses should be done once during driver initialization, not once for each domain-specific libxl_ctx object. The related libxl documentation in $xen-src/tools/libxl/libxl_event.h even mentions that "it is best to call this at initialisation". Signed-off-b

[libvirt] [PATCH 02/10] libxl: use libxl_ctx passed to libxlConsoleCallback

2015-02-17 Thread Jim Fehlig
Instead of using the libxl_ctx in the libxlDomainObjPrivatePtr, use the ctx passed to the callback. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index e186c53..9

[libvirt] [PATCH 00/10] libxl: switch driver to use a single libxl_ctx

2015-02-17 Thread Jim Fehlig
This series is a follow up to https://www.redhat.com/archives/libvir-list/2015-February/msg00024.html It goes a step further and changes the libxl driver to use one, driver-wide libxl_ctx. Currently the libxl driver has one driver-wide ctx for operations that are not domain-specific and a ctx fo

[libvirt] [PATCH 01/10] libxl: remove redundant calls to libxl_evdisable_domain_death

2015-02-17 Thread Jim Fehlig
Domain death watch is already disabled in libxlDomainCleanup. No need to disable it a second and third time. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 8 1 file changed, 8 deletions(-) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 21c41d7..e186c

[libvirt] [PATCH 09/10] libxl: remove per-domain libxl_ctx

2015-02-17 Thread Jim Fehlig
Although needed in the Xen 4.1 libxl days, there is no longer any benefit to having per-domain libxl_ctx. On the contrary, their use makes the code unecessarily complicated and prone to deadlocks under load. As suggested by the libxl maintainers, use a single libxl_ctx as a handle to libxl instea

[libvirt] [PATCH 10/10] libxl: change libxl log stream to ERROR log level

2015-02-17 Thread Jim Fehlig
The DEBUG log level is very verbose and can quickly fill a filesystem hosting /var/log/libvirt/libxl/ Signed-off-by: Jim Fehlig --- Ideally, the log level should match what is configured in libvirtd.conf. Are the logging knob settings available in the drivers? If not, this would be a good optio

[libvirt] [PATCH 07/10] libxl: remove unnecessary libxlDomainEventsRegister

2015-02-17 Thread Jim Fehlig
This function now only enables domain death events. Simply call libxl_evenable_domain_death() instead of an unnecessary wrapper. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 32 +++- src/libxl/libxl_domain.h | 5 - src/libxl/libxl_driver.c | 5 +++--

[libvirt] [PATCH 08/10] libxl: make libxlDomainFreeMem static

2015-02-17 Thread Jim Fehlig
libxlDomainFreeMem() is only used in libxl_domain.c and thus should be declared static. While at it, change the signature to take a libxl_ctx instead of libxlDomainObjPrivatePtr, since only the libxl_ctx is needed. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 16 sr

[libvirt] [PATCH 03/10] libxl: use driver-wide ctx in fd and timer event handling

2015-02-17 Thread Jim Fehlig
Long ago I incorrectly associated libxl fd and timer registrations with per-domain libxl_ctx objects. When creating a libxlDomainObjPrivate, a libxl_ctx is allocated, and libxl_osevent_register_hooks is called passing a pointer to the libxlDomainObjPrivate. When an fd or timer registration occurr

[libvirt] [PATCH 06/10] libxl: use global libxl_ctx in event handler

2015-02-17 Thread Jim Fehlig
Change the domain event handler code to use the driver-wide libxl_ctx instead of the domain-specific one. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 37 + 1 file changed, 25 insertions(+), 12 deletions(-) diff --git a/src/libxl/libxl_domain.c b/

[libvirt] [PATCH 05/10] libxl: move event registration to driver initialization

2015-02-17 Thread Jim Fehlig
Register a domain event handler with the driver-wide libxl_ctx during driver initialization. Signed-off-by: Jim Fehlig --- src/libxl/libxl_domain.c | 21 ++--- src/libxl/libxl_domain.h | 15 +++ src/libxl/libxl_driver.c | 9 + 3 files changed, 26 insertions(+

Re: [libvirt] [PATCH 3/3] virsh: prevent removing a in-used bridge for iface-unbridge

2015-02-17 Thread Jim Fehlig
Laine Stump wrote: > On 02/04/2015 10:57 AM, Jim Fehlig wrote: > >> Laine Stump wrote: >> >>> (BTW, I'm still curious about Suse's use of netcf, as there have been no >>> updates to the Suse driver in netcf since the initial port was imported >>> several years ago. Are there downstream chan

Re: [libvirt] libxl and non-absolute paths

2015-02-17 Thread Jim Fehlig
Stefan Bader wrote: > Just recently we moved to libvirt 1.2.12 for the next release. Which brought > up > a few problems when working with configs which we and Debian used to have. > > A mild complaint towards the xml validation: it would be really nice of that > would be a bit more specific about

Re: [libvirt] [PATCH v2 2/3] utilities for supporting midonet virtualports

2015-02-17 Thread YAMAMOTO Takashi
> + * Authors: > + * Antoni Segura Puimedon " ? -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2 3/3] Add midonet virtual port type support to qemu

2015-02-17 Thread Antoni Segura Puimedon
Use the utilities introduced in the previous patches so the qemu driver is able to create tap devices that are bound (and unbound on domain destroyal) to Midonet virtual ports. Signed-off-by: Antoni Segura Puimedon --- src/conf/domain_conf.h | 1 + src/conf/netdev_vport_profile_co

[libvirt] [PATCH v2 1/3] Schema and docs for the midonet virtualport type

2015-02-17 Thread Antoni Segura Puimedon
Midonet is an opensource virtual networking that over lays the IP network between hypervisors. Currently, such networks can be made with the openvswitch virtualport type. This patch, defines the schema and documentation that will serve as basis for the follow up patches that will add support to li

[libvirt] [PATCH v2 2/3] utilities for supporting midonet virtualports

2015-02-17 Thread Antoni Segura Puimedon
Adds the port type definitions and methods that will be used to bind interfaces to the Midonet virtual ports. virtnetdevmidonet.c adds the way to bind and unbind the ports by calling into the Midonet Host Agent control command line (installed with the midolman package). Signed-off-by: Antoni Segu

[libvirt] [PATCH v2] Add support for Midonet virtual ports

2015-02-17 Thread Antoni Segura Puimedon
Up until now, to plug VMs into the Midonet virtual networks it was necessary to use the 'last resort' 'ethernet' type. That implied having the domain tainted and having to deal witht the tap lifecycle outside of libvirt/VM lifecycle. With the patches I submit, a new virtualport type will be accept

[libvirt] [PATCH v3 1/9] Implement public API for virDomainGetIOThreadsInfo

2015-02-17 Thread John Ferlan
Add virDomainGetIOThreadsInfo in order to return a list of virDomainIOThreadsInfoPtr structures which list the IOThread ID, the CPU Affinity map, and associated resources for each IOThread for the domain. For an active domain, the live data will be returned, while for an inactive domain, the config

[libvirt] [PATCH v3 5/9] Implement public API for virDomainSetIOThreads

2015-02-17 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1135491 Add the libvirt API infrastructure to support setting IOThread data. For now this is the pinned CPU information, but eventually will also support hot plug add/del The API will support the LIVE, CONFIG, or CURRENT flags. If the VIR_DOMAIN_IOTHRE

[libvirt] [PATCH v3 6/9] remote: Implement remote plumbing for virDomainSetIOThreads

2015-02-17 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1135491 Add the remote plumbing to support SET_IOTHREADS. The code can be automagically generated since there's nothing special on the way in or way out. Signed-off-by: John Ferlan --- src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x

[libvirt] [PATCH v3 7/9] domain: Introduce virDomainIOThreadsPin{Add|Del}

2015-02-17 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1135491 More or less a virtual copy of the existing virDomainVcpuPin{Add|Del} API's. NB: The IOThreads implementation "reused" the virDomainVcpuPinDefPtr since it provided everything necessary - an "id" and a "map" for each thread id configured. Signed

[libvirt] [PATCH v3 3/9] qemu: Implement the qemu driver fetch for IOThreads

2015-02-17 Thread John Ferlan
Depending on the flags passed, either attempt to return the active/live IOThread data for the domain or the config data. The active/live path will call into the Monitor in order to get the IOThread data and then correlate the thread_id's returned from the monitor to the currently running system/th

[libvirt] [PATCH v3 8/9] qemu: Add qemuDomainSetIOThreads

2015-02-17 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1135491 Implement the qemuDomainSetIOThreads... For now it processes the VIR_DOMAIN_IOTHREADS_PIN and calls qemuDomainSetIOThreadsPin in order to process changing to using the new cpumap. The change can be made either LIVE or CONFIG, or both if both flag

[libvirt] [PATCH v3 9/9] virsh: Allow setting of the iothread pin

2015-02-17 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1135491 $ virsh iothreads --help NAME iothreads - view domain IOThreads SYNOPSIS iothreads [--iothread_id ] [--cpulist ] [--config] [--live] [--current] DESCRIPTION Returns basic information about the domain IOThreads. OPTIONS

[libvirt] [PATCH v3 2/9] remote: Implement the remote plumbing for virDomainGetIOThreadsInfo

2015-02-17 Thread John Ferlan
Implement the remote plumbing for virDomainGetIOThreadsInfo Signed-off-by: John Ferlan --- daemon/remote.c | 99 +++- src/remote/remote_driver.c | 93 - src/remote/remote_protocol.x | 32 +-

[libvirt] [PATCH v3 4/9] virsh: Add 'iothreads' command

2015-02-17 Thread John Ferlan
Add the 'iothreads' command to display IOThread Info data. Allow for [--live] or [--config] options in order to display live or config data for an active domain. An active domain may return: $ virsh iothreads $dom IOThread ID CPU AffinityResource(s) -

[libvirt] [PATCH v3 0/9] Introduce display of IOThreads Information

2015-02-17 Thread John Ferlan
v2 here: http://www.redhat.com/archives/libvir-list/2015-February/msg00562.html Changes over v2: Patches 1-4 * Add "resources" and "nresources" in order to return the resources that are using an IOThread * Fixed memory leak - neglected to free the qemuMonitorIOThreadsInfoPtr 'iothreads' in

Re: [libvirt] [PATCH v2 0/4] Introduce display of IOThreads Information

2015-02-17 Thread John Ferlan
On 02/16/2015 04:21 PM, John Ferlan wrote: > v1: http://www.redhat.com/archives/libvir-list/2015-February/msg00402.html > > Changes since v1: > * Remove 'thread_id' from public display > * Add --live, --config, --current flags >* Adjust patch 1 to accept/check the flags, modify comments >

[libvirt] [PATCH] qemu_cgroup: initialize mem_mask to NULL

2015-02-17 Thread Pavel Hrdina
If 'virNumaGetHostNodeset()' fails then the error path will try to free uninitialized pointer mem_mask. Introduced by commit af2a1f058. Signed-off-by: Pavel Hrdina --- Pushed under trivial rule. src/qemu/qemu_cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu

Re: [libvirt] [Patch 0/4] PowerPC fixes for libvirt

2015-02-17 Thread Ján Tomko
On Sun, Feb 15, 2015 at 09:45:25AM +0530, Prerna Saxena wrote: > This patch set addresses some miscellaneous fixes for libvirt on PowerPC. > > Details: > Patch 1/4 : This adds 'qemu-system-ppc64' as the default emulator for ppc64 & > ppc64le guests. > Patch 2/4 : Fixes a small error where not spe

Re: [libvirt] [PATCH 4/4] PowerPC : Do not allow floppy disks in domain XML.

2015-02-17 Thread Ján Tomko
On Sun, Feb 15, 2015 at 10:02:25AM +0530, Prerna Saxena wrote: > > Subject: [PATCH 4/4] PowerPC : Do not allow floppy disks in domain XML. > > PowerKVM does not support floppy disks. Ensure that libvirt honours this. > Fixes : https://bugzilla.redhat.com/show_bug.cgi?id=1180486 > > Signed-off-by

Re: [libvirt] [PATCH 1/4] PowerPC : Make 'qemu-system-ppc64' the default emulator on ppc64[le].

2015-02-17 Thread Ján Tomko
On Sun, Feb 15, 2015 at 09:48:00AM +0530, Prerna Saxena wrote: > PowerPC : Explicitly associate 'qemu-system-ppc64' as the > default emulator for all 64-bit PowerPC guests ( both Big & Little Endian ) > > Signed-off-by: Prerna Saxena > --- > src/qemu/qemu_capabilities.c | 7 ++- > 1 file ch

Re: [libvirt] [PATCH 3/4] PowerPC: Augment XML schema to include 'ppc64le' arch and pseries* machine types.

2015-02-17 Thread Ján Tomko
On Sun, Feb 15, 2015 at 09:56:03AM +0530, Prerna Saxena wrote: > > PowerPC: Augment XML schema to include 'ppc64le' arch and newer pseries-2.* >machine types. > > Signed-off-by: Prerna Saxena > --- > docs/schemas/basictypes.rng | 1 + > docs/schemas/domaincommon.rng | 7 +

Re: [libvirt] [PATCH 2/4] PowerPC : Forbid NULL CPU model with 'host-model' mode.

2015-02-17 Thread Ján Tomko
On Sun, Feb 15, 2015 at 09:54:15AM +0530, Prerna Saxena wrote: > > PowerPC : Forbid NULL CPU model with 'host-model' mode in qemu command line. > > This ensures that an XML such as following: > ... > > > > ... > > will not generate a '-cpu host,compat=(null)' command line with > qemu

Re: [libvirt] [PATCH] SRIOV NIC offload feature discovery

2015-02-17 Thread Ján Tomko
On Mon, Feb 16, 2015 at 10:18:32AM +, James Chapman wrote: > Adding functionality to libvirt that will allow it > query the ethtool interface for the availability > of certain NIC HW offload features > --- > src/conf/device_conf.h | 6 ++ > src/conf/node_device_conf.c|

[libvirt] [PATCH] Add support for the midonet virtualport type

2015-02-17 Thread Antoni Segura Puimedon
From: Antoni Segura Puimedon Midonet is an opensource virtual networking that over lays the IP network between hypervisors. Currently, such networks can be made with the openvswitch virtualport type. With this patch, one will be able to setup such configurations by binding vNICs to Midonet overla

Re: [libvirt] [PATCH] Add support for the midonet virtualport type

2015-02-17 Thread Antoni Segura Puimedon
On Tue, Feb 17, 2015 at 8:47 AM, Laine Stump wrote: > On 02/16/2015 08:46 PM, Antoni Segura Puimedon wrote: > > From: Antoni Segura Puimedon > > > > Midonet is an opensource virtual networking that over lays the IP > > network between hypervisors. Currently, such networks can be made > > with th

[libvirt] [PATCH] Add support for Midonet virtual ports

2015-02-17 Thread Antoni Segura Puimedon
Up until now, to plug VMs into the Midonet virtual networks it was necessary to use the 'last resort' 'ethernet' type. That implied having the domain tainted and having to deal witht the tap lifecycle outside of libvirt/VM lifecycle. With the patch I submit, a new virtualport type will be accepted

[libvirt] [PATCH 2/3] parallels: Use IS_CT() macro instead of STREQ("exe")

2015-02-17 Thread Mikhail Feoktistov
--- src/parallels/parallels_sdk.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c index 3bb2ce8..8660259 100644 --- a/src/parallels/parallels_sdk.c +++ b/src/parallels/parallels_sdk.c @@ -1865,8 +1865,8

[libvirt] [PATCH 3/3] parallels: Set the first HDD from XML as bootable

2015-02-17 Thread Mikhail Feoktistov
1. Delete all boot devices for VM instance 2. Find the first HDD from XML and set it as bootable Now we support only one boot device and it should be HDD --- src/parallels/parallels_sdk.c | 95 +++-- 1 files changed, 91 insertions(+), 4 deletions(-) diff --g

[libvirt] [PATCH 1/3] parallels: code aligment

2015-02-17 Thread Mikhail Feoktistov
--- src/parallels/parallels_sdk.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c index d0d2ce2..3bb2ce8 100644 --- a/src/parallels/parallels_sdk.c +++ b/src/parallels/parallels_sdk.c @@ -2804,23

Re: [libvirt] Fwd: libvirt 1.2.10 and latest EL6 qemu-kvm

2015-02-17 Thread Pavel Hrdina
On Tue, Feb 17, 2015 at 10:04:27AM +0100, Franky Van Liedekerke wrote: > On Sat, Feb 14, 2015 at 8:34 AM, Pavel Hrdina wrote: > > On Fri, Feb 13, 2015 at 05:32:36PM +0100, Franky Van Liedekerke wrote: > >> Since there was no reaction in the user list, I'm posting it in the > >> devel in the hope f

Re: [libvirt] [PATCH] qemu: fix vm deadlock when try to use numatune in session mode

2015-02-17 Thread Pavel Hrdina
On Tue, Feb 17, 2015 at 11:37:52AM +0800, Luyao Huang wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1126762 > > commit 43b67f introduce a deadlock issue when we use numatune s/commit/Commit/ s/introduce/introduced/ > to change numa settings to a vm in session mode. > > Jump to endjob ins

Re: [libvirt] Fwd: libvirt 1.2.10 and latest EL6 qemu-kvm

2015-02-17 Thread Franky Van Liedekerke
On Sat, Feb 14, 2015 at 8:34 AM, Pavel Hrdina wrote: > On Fri, Feb 13, 2015 at 05:32:36PM +0100, Franky Van Liedekerke wrote: >> Since there was no reaction in the user list, I'm posting it in the >> devel in the hope for some guidance to the problem mentioned below >> (sorry about this). >> >> Fr

Re: [libvirt] Getting Introduced to the Community

2015-02-17 Thread Cedric Bosdonnat
Hello Gaurav, First, thanks a lot for being interested in that idea! You said that you tried Daniel's proof of concept, but did you manage to get a disk image out of a docker image? I guess not... or you have some patches to send back ;) In this project I already see these steps: * Get Daniel'

Re: [libvirt] Enhancing block/disk migration in libvirt

2015-02-17 Thread Tony Breeds
On Tue, Feb 17, 2015 at 09:02:57AM +0100, Michal Privoznik wrote: > Oh, I forgot to paste the API name: virDomainMigrate3 That'll narrow the search! Thanks! Yours Tony. pgpEvToowOxiC.pgp Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mail

Re: [libvirt] Enhancing block/disk migration in libvirt

2015-02-17 Thread Michal Privoznik
On 17.02.2015 08:52, Tony Breeds wrote: > On Mon, Feb 16, 2015 at 11:34:51AM +0100, Michal Privoznik wrote: >> On 16.02.2015 11:16, Daniel P. Berrange wrote: >>> >>> This doesn't really belong in the XML. The XML configs are for controlling >>> the guest configuration, not functional behaviour of t