The coredump_with_format.py uses coreDumpWithFormat() to validate
new API virDomainCoreDumpWithFormat of libvirt.
---
repos/domain/coredump_with_format.py | 239 +++
1 file changed, 239 insertions(+)
create mode 100644 repos/domain/coredump_with_format.py
diff
On Thu, Feb 26, 2015 at 12:40:43PM -0500, Laine Stump wrote:
On 02/26/2015 11:39 AM, Ján Tomko wrote:
On Thu, Feb 26, 2015 at 04:29:53PM +0100, Martin Kletzander wrote:
On Thu, Feb 26, 2015 at 09:57:22AM -0500, Laine Stump wrote:
On 02/26/2015 08:53 AM, Ján Tomko wrote:
Commit 6992994
---
cases/linux_domain.conf | 44
1 file changed, 44 insertions(+)
diff --git a/cases/linux_domain.conf b/cases/linux_domain.conf
index a5ada35..490ee90 100644
--- a/cases/linux_domain.conf
+++ b/cases/linux_domain.conf
@@ -34,6 +34,50 @@ domain:start
The coredump_with_format.py uses coreDumpWithFormat() to validate
new API virDomainCoreDumpWithFormat of libvirt.
jiahu (2):
Add coredump_with_format test case
Add coredump_with_format test case to linux_domain conf
cases/linux_domain.conf | 44 +++
On Thu, Feb 26, 2015 at 05:42:10PM +0100, Erik Skultety wrote:
On 02/25/2015 08:10 AM, Martin Kletzander wrote:
On Tue, Feb 24, 2015 at 04:28:18PM +0100, Erik Skultety wrote:
We do parse and represent period collection as unsigned int in our
internal structures, however commit
In order to hide the object internals (and use just accessors
everywhere), lets store a pointer to the object, instead of object
itself.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/network/bridge_driver.c | 98 +++-
This patch turns both virNetworkObjFindByUUID() and
virNetworkObjFindByName() to return an referenced object so that
even if caller unlocks it, it's for sure that object won't
disappear meanwhile. Especially if the object (in general) is
locked and unlocked during the caller run.
Moreover, this
Silly this bug went unnoticed so long. At the beginning we try to
find the passed network in the list of network objects. If found,
it's locked and real work takes place. Then, in the end, the
network object is never unlocked.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
Hello,
I think it would be useful if libvirt will be able to prefix all
messages from emulator pipes with the date stamping, for example I am
trying to catch very rare and non-fatal race with
virtio-serial-bus: Guest failure in adding device virtio-serial0.0
which is specific to the Windows
- Original Message -
From: Laine Stump la...@laine.org
To: libvir-list@redhat.com
Cc: Francesco Romani from...@redhat.com, Ján Tomko jto...@redhat.com
Sent: Thursday, February 26, 2015 4:28:13 PM
Subject: Re: [libvirt] [PATCH] Ignore listen attribute of graphics for type
network
On Thu, Feb 26, 2015 at 04:29:53PM +0100, Martin Kletzander wrote:
On Thu, Feb 26, 2015 at 09:57:22AM -0500, Laine Stump wrote:
On 02/26/2015 08:53 AM, Ján Tomko wrote:
Commit 6992994 started filling the listen attribute
of the parent graphics elements from type='network' listens.
When
On 02/25/2015 08:10 AM, Martin Kletzander wrote:
On Tue, Feb 24, 2015 at 04:28:18PM +0100, Erik Skultety wrote:
We do parse and represent period collection as unsigned int in our
internal structures, however commit
d5c67e7f4523450023b89b69c16472582c85eeaf converts this to int, thus
wrapping
Well, the parallelsConnectOpen() joins several sub-driver openings
into one big if condition. If any of sub-driver fails to open, the
whole API finishes immediately. The problem is, sub-drivers may have
left some memory allocated. Fortunately, we have a free function for
that:
On Thu, Feb 26, 2015 at 11:10:06AM -0500, Francesco Romani wrote:
- Original Message -
From: Laine Stump la...@laine.org
To: libvir-list@redhat.com
Cc: Francesco Romani from...@redhat.com, Ján Tomko jto...@redhat.com
Sent: Thursday, February 26, 2015 4:28:13 PM
Subject: Re:
On 02/26/2015 08:53 AM, Ján Tomko wrote:
Commit 6992994 started filling the listen attribute
of the parent graphics elements from type='network' listens.
When this XML is passed to UpdateDevice, parsing fails:
XML error: graphics listen attribute 10.20.30.40 must match
address attribute of
On Thu, Feb 26, 2015 at 5:36 PM, Daniel P. Berrange berra...@redhat.com wrote:
On Thu, Feb 26, 2015 at 06:29:49PM +0400, Andrey Korolyov wrote:
Hello,
I think it would be useful if libvirt will be able to prefix all
messages from emulator pipes with the date stamping, for example I am
trying
On Thu, Feb 26, 2015 at 15:17:14 +0100, Michal Privoznik wrote:
This is probably a copy-paste error from virDomainObj*
counterpart. But when speaking of virNetworkObj we should use
variable @nets for an array of networks, rather than @doms. It's
just confusing.
Signed-off-by: Michal
On Thu, Feb 26, 2015 at 15:17:16 +0100, Michal Privoznik wrote:
Instead of copying the whole object onto stack when calling the
function, just pass the pointer to the object and save up some
space on the stack. Moreover, this prepares the code to hide the
virNetworkObjList structure into
On Thu, Feb 26, 2015 at 15:17:12 +0100, Michal Privoznik wrote:
Silly this bug went unnoticed so long. At the beginning we try to
find the passed network in the list of network objects. If found,
it's locked and real work takes place. Then, in the end, the
network object is never unlocked.
Hi,
- Original Message -
From: Laine Stump la...@laine.org
To: libvir-list@redhat.com
Cc: Ján Tomko jto...@redhat.com, from...@redhat.com
Sent: Thursday, February 26, 2015 3:57:22 PM
Subject: Re: [PATCH] Ignore listen attribute of graphics for type network
listens
On 02/26/2015
On Thu, Feb 26, 2015 at 15:17:11 +0100, Michal Privoznik wrote:
Okay, this is mainly for educational purposes, since is called
from single point only, with all the possible locks held. So
Drop the last two commas in the sentence.
there's no way for other thread to hop in and do something
On Thu, Feb 26, 2015 at 03:05:02PM +0100, Martin Kletzander wrote:
On Thu, Feb 26, 2015 at 12:09:57PM +0100, Pavel Hrdina wrote:
To prevent a confusion about missing chardev argument in qemu
command line add a note about that behavior into documentation.
Signed-off-by: Pavel Hrdina
On Thu, Feb 26, 2015 at 16:46:26 +0100, Peter Krempa wrote:
On Thu, Feb 26, 2015 at 15:17:17 +0100, Michal Privoznik wrote:
In order to hide the object internals (and use just accessors
everywhere), lets store a pointer to the object, instead of object
itself.
Signed-off-by: Michal
On Thu, Feb 26, 2015 at 15:17:13 +0100, Michal Privoznik wrote:
Moreover, there are two points within the function, where we're
missing 'goto cleanup'. Fix this too.
Control flow is okay even in that case, but this makes it more clear.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
On 02/26/2015 10:11 AM, Francesco Romani wrote:
Hi,
- Original Message -
From: Laine Stump la...@laine.org
To: libvir-list@redhat.com
Cc: Ján Tomko jto...@redhat.com, from...@redhat.com
Sent: Thursday, February 26, 2015 3:57:22 PM
Subject: Re: [PATCH] Ignore listen attribute of
On Thu, Feb 26, 2015 at 09:57:22AM -0500, Laine Stump wrote:
On 02/26/2015 08:53 AM, Ján Tomko wrote:
Commit 6992994 started filling the listen attribute
of the parent graphics elements from type='network' listens.
When this XML is passed to UpdateDevice, parsing fails:
XML error: graphics
On Thu, Feb 26, 2015 at 15:17:17 +0100, Michal Privoznik wrote:
In order to hide the object internals (and use just accessors
everywhere), lets store a pointer to the object, instead of object
itself.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/test/test_driver.c | 106
On Thu, Feb 26, 2015 at 15:17:19 +0100, Michal Privoznik wrote:
In order to hide the object internals (and use just accessors
everywhere), lets store a pointer to the object, instead of object
itself.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/network/bridge_driver.c
On Thu, Feb 26, 2015 at 06:40:11PM +0400, Andrey Korolyov wrote:
On Thu, Feb 26, 2015 at 5:36 PM, Daniel P. Berrange berra...@redhat.com
wrote:
On Thu, Feb 26, 2015 at 06:29:49PM +0400, Andrey Korolyov wrote:
Hello,
I think it would be useful if libvirt will be able to prefix all
On 26.02.2015 16:46, Peter Krempa wrote:
On Thu, Feb 26, 2015 at 15:17:17 +0100, Michal Privoznik wrote:
In order to hide the object internals (and use just accessors
everywhere), lets store a pointer to the object, instead of object
itself.
Signed-off-by: Michal Privoznik
On Thu, Feb 26, 2015 at 15:17:18 +0100, Michal Privoznik wrote:
In order to hide the object internals (and use just accessors
everywhere), lets store a pointer to the object, instead of object
itself.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/parallels/parallels_driver.c
On Mon, Feb 23, 2015 at 14:18:31 +0100, Matthias Gatto wrote:
On Tue, Feb 10, 2015 at 4:43 PM, Matthias Gatto
matthias.ga...@outscale.com wrote:
The purpose of these patches is to introduce quorum for libvirt
I've try to follow this proposal:
On Wed, Feb 25, 2015 at 11:22:04AM +0100, Peter Krempa wrote:
The memory sizes in qemu are aligned up to 1 MiB boundaries. There are
two places where this was done once for the total size and then for
individual NUMA cell sizes.
Add a function that will align the sizes in one place so that it's
This is practically copy of qemuDomObjEndAPI. The reason why is
it so widely available is to avoid code duplication, since the
function is going to be called from our bridge driver, test
driver and parallels driver too.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/parallels/parallels_network.c | 66 +++
1 file changed, 12 insertions(+), 54 deletions(-)
diff --git a/src/parallels/parallels_network.c
b/src/parallels/parallels_network.c
index 94e77cc..868e3f5
So far, this is pure code replacement. But once we introduce
reference counting to virNetworkObj this will be more handy as
there'll be only one function to change: virNetworkObjEndAPI().
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/parallels/parallels_network.c | 18
It's returning virNetworkObjPtr after all. And it matches the
pattern laid out by domain_conf.h.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/conf/network_conf.c | 8
src/conf/network_conf.h | 4 ++--
src/libvirt_private.syms | 2 +-
So far it's just a structure which happens to have 'Obj' in its
name, but otherwise it not related to virObject at all. No
reference counting, not virObjectLock(), nothing.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
cfg.mk| 2 -
src/conf/network_conf.c
An accessor following pattern laid out by virDomainObjList* APIs.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/conf/network_conf.c | 26 ++
src/conf/network_conf.h | 5 +
src/libvirt_private.syms | 1 +
3 files changed, 32 insertions(+)
diff --git
So far, this is pure code replacement. But once we introduce
reference counting to virNetworkObj this will be more handy as
there'll be only one function to change: virNetworkObjEndAPI().
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/test/test_driver.c | 42
On Thu, Feb 26, 2015 at 12:09:57PM +0100, Pavel Hrdina wrote:
To prevent a confusion about missing chardev argument in qemu
command line add a note about that behavior into documentation.
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
docs/formatdomain.html.in | 4
1 file changed, 4
On Thu, Feb 26, 2015 at 06:29:49PM +0400, Andrey Korolyov wrote:
Hello,
I think it would be useful if libvirt will be able to prefix all
messages from emulator pipes with the date stamping, for example I am
trying to catch very rare and non-fatal race with
virtio-serial-bus: Guest failure
This is probably a copy-paste error from virDomainObj*
counterpart. But when speaking of virNetworkObj we should use
variable @nets for an array of networks, rather than @doms. It's
just confusing.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/conf/network_conf.c | 34
The patchset starts slowly, with small patches, and small
changes, accelerating towards the end, with big changes.
I know that network driver is not used as intensely as domain
drivers, but hey, if we remove 100 lines (and substitute some
others) we get fine grained locking! And cleaner code, of
Okay, this is mainly for educational purposes, since is called
from single point only, with all the possible locks held. So
there's no way for other thread to hop in and do something wrong.
Nevertheless, we should not give bad example.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
It's returning virNetworkObjPtr after all. And it matches the
pattern laid out by domain_conf.h.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/conf/network_conf.c | 6 +++---
src/conf/network_conf.h | 4 ++--
src/libvirt_private.syms | 2 +-
Commit 6992994 started filling the listen attribute
of the parent graphics elements from type='network' listens.
When this XML is passed to UpdateDevice, parsing fails:
XML error: graphics listen attribute 10.20.30.40 must match
address attribute of first listen element (found none)
Ignore the
In order to hide the object internals (and use just accessors
everywhere), lets store a pointer to the object, instead of object
itself.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/parallels/parallels_driver.c | 5 +++-
src/parallels/parallels_network.c | 60
This API will be used in the future to call passed callback over
each network object in the list. It's slightly different to it
virDomainObjListForEach counterpart, because virDomainObjList
uses a hash table to store domain object, while virNetworkObjList
uses an array. Therefore, iterating over
Moreover, there are two points within the function, where we're
missing 'goto cleanup'. Fix this too.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/network/bridge_driver.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/network/bridge_driver.c
In order to hide the object internals (and use just accessors
everywhere), lets store a pointer to the object, instead of object
itself.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/test/test_driver.c | 106 -
1 file changed, 51
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/test/test_driver.c | 64 ++
1 file changed, 12 insertions(+), 52 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index ecb7bcd..0a68283 100644
---
On Wed, Feb 25, 2015 at 11:22:02AM +0100, Peter Krempa wrote:
As there are two possible approaches to define a domain's memory size -
one used with legacy, non-NUMA VMs configured in the memory element
and per-node based approach on NUMA machines - the user needs to make
sure that both are
On Wed, Feb 25, 2015 at 11:22:05AM +0100, Peter Krempa wrote:
The total NUMA memory consists of the sum of individual NUMA node memory
amounts.
---
Notes:
Version 2:
- Already ACKed but didn't make sense to push.
And ACK again...
pgpZm3kZAUEBa.pgp
Description: PGP signature
--
Later we can turn APIs to lock the object if needed instead of
relying on caller to mutually exclude itself (probably done by
locking a big lock anyway).
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/conf/network_conf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Now that all the code uses accessors, don't expose the structure
anyway.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/conf/network_conf.c | 7 +++
src/conf/network_conf.h | 6 --
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/conf/network_conf.c
Every API that touches internal structure of the object must lock
the object first. Not every API that has the object as an
argument needs to do that though. Some APIs just pass the object
to lower layers, which, however, must lock the object then. Look
at the code, you'll get my meaning soon.
While in previous commits there were some places that relied on
the big lock, in this file there's no such place and the big
driver lock can be dropped completely. Yay!
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/parallels/parallels_network.c | 33
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/network/bridge_driver.c | 333
1 file changed, 148 insertions(+), 185 deletions(-)
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index 268af49..1c73342 100644
---
Well, if 'everywhere' is defined as that part of the driver code
that serves virNetwork* APIs. Again, we lower layers already have
their locks, so there's no point doing big lock.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/test/test_driver.c | 56
On Thu, Feb 26, 2015 at 01:20:29PM +0100, Martin Kletzander wrote:
On Wed, Feb 25, 2015 at 11:21:58AM +0100, Peter Krempa wrote:
NUMA enabled guest configuration explicitly specifies memory sizes for
individual nodes. Allowing the virDomainSetMemoryFlags API (and friends)
to change the total
Now that we have fine grained locks, there's no need to lock the
whole driver. We can rely on self-locking APIs.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/network/bridge_driver.c | 45 +++--
1 file changed, 3 insertions(+), 42
Instead of copying the whole object onto stack when calling the
function, just pass the pointer to the object and save up some
space on the stack. Moreover, this prepares the code to hide the
virNetworkObjList structure into network_conf.c and use accessors
only.
Signed-off-by: Michal Privoznik
We have this function networkObjFromNetwork() which for given
virNetworkPtr tries to find corresponding virNetworkObjPtr. If no
object is found, a nice error message is printed out:
no network with matching uuid '$uuid' ($name)
Let's improve the error message produced by networkLookupByUUID to
So far, this is pure code replacement. But once we introduce
reference counting to virNetworkObj this will be more handy as
there'll be only one function to change: virNetworkObjEndAPI().
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/network/bridge_driver.c | 57
All of our vir*Free() functions should accept NULL, even though
that there's no way of actually passing NULL with current code.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/conf/network_conf.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/conf/network_conf.c
Well, one day this will be self-locking object, but not today.
But lets prepare the code for that! Moreover,
virNetworkObjListFree() is no longer needed, so turn it into
virNetworkObjListDispose().
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
cfg.mk| 1 -
An accessor following pattern laid out by virDomainObjList* APIs.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/conf/network_conf.c | 38 ++
src/conf/network_conf.h | 8
src/libvirt_private.syms | 1 +
3 files changed, 47
On Wed, Feb 25, 2015 at 11:22:06AM +0100, Peter Krempa wrote:
Use the NUMA total instead of the configured size both in XML and for
uses in the code once NUMA is enabled for a domain.
One test case change is necessary as the rounding of the individual cell
sizes was not matching the rounding of
From 7128e773058751e4d1024ef7d8e4ad286c93ba55 Mon Sep 17 00:00:00 2001
From: Prerna Saxena pre...@linux.vnet.ibm.com
Date: Thu, 26 Feb 2015 08:10:58 -0600
Subject: [PATCH 1/2] PowerPC: Augment XML schema to include 'ppc64le' arch and
newer pseries-2.* machine types.
Acked-by: Ján Tomko
Tests : Add test for 'ppc64le' architecture.
Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com
---
.../qemuxml2argv-pseries-cpu-le.args | 7 +
.../qemuxml2argv-pseries-cpu-le.xml| 17
tests/qemuxml2argvtest.c | 2 ++
From a28ef5a3e7b9cb023948cf97d9f472bb3a1e06d3 Mon Sep 17 00:00:00 2001
From: Prerna Saxena pre...@linux.vnet.ibm.com
Date: Thu, 26 Feb 2015 22:31:05 +0530
This series adds few miscellaneous fixes for PowerPC 64-bit Little
Endian Architecture.
Changelog :
==
v1 of Patch 1/2 already
On 02/26/2015 11:39 AM, Ján Tomko wrote:
On Thu, Feb 26, 2015 at 04:29:53PM +0100, Martin Kletzander wrote:
On Thu, Feb 26, 2015 at 09:57:22AM -0500, Laine Stump wrote:
On 02/26/2015 08:53 AM, Ján Tomko wrote:
Commit 6992994 started filling the listen attribute
of the parent graphics elements
s/ByUUID/ByName/g in subject
On Thu, Feb 26, 2015 at 15:17:21 +0100, Michal Privoznik wrote:
It's returning virNetworkObjPtr after all. And it matches the
pattern laid out by domain_conf.h.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/conf/network_conf.c | 8
On Thu, Feb 26, 2015 at 15:17:22 +0100, Michal Privoznik wrote:
This API will be used in the future to call passed callback over
each network object in the list. It's slightly different to it
s/to it/to it's/
virDomainObjListForEach counterpart, because virDomainObjList
uses a hash table to
On Thu, Feb 26, 2015 at 15:17:23 +0100, Michal Privoznik wrote:
An accessor following pattern laid out by virDomainObjList* APIs.
The domain object accessors are quite different in this case, but ...
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/conf/network_conf.c | 38
On Thu, Feb 26, 2015 at 15:17:24 +0100, Michal Privoznik wrote:
An accessor following pattern laid out by virDomainObjList* APIs.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/conf/network_conf.c | 26 ++
src/conf/network_conf.h | 5 +
On Thu, Feb 26, 2015 at 15:17:20 +0100, Michal Privoznik wrote:
It's returning virNetworkObjPtr after all. And it matches the
pattern laid out by domain_conf.h.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/conf/network_conf.c | 6 +++---
src/conf/network_conf.h
https://bugzilla.redhat.com/show_bug.cgi?id=921426
Add to the man page a more complete description of what exactly the
command expects on input and will return on output based on what is
currently supported.
Perhaps missing findPoolSources implementations are backends for
sheepdog and rbd. Also
The virStorageBackendISCSIFindPoolSources API only needs the 'host' name
in order to discover iSCSI pools, it returns the various device paths.
On input, it's also possible to further restrict a search by providing the
port attribute for the host element and the (undocumented) initiator element.
https://bugzilla.redhat.com/show_bug.cgi?id=921426
The first patch is just a change to the error message. As it turns out only
the host is necessary to find iSCSI targets. I have to assume over time
adjustments to the code made the need to provide the name obsolete, but
I did not research exactly
On 02/26/2015 03:56 PM, Ján Tomko wrote:
On Thu, Feb 26, 2015 at 02:14:20PM +0800, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1196503
We already check whether the host id is valid or not, add a jump
to forbid invalid host id.
Signed-off-by: Luyao Huang lhu...@redhat.com
On Thu, Feb 12, 2015 at 12:08:54PM +0800, Zhang Bo wrote:
The function virNetDevOpenvswitchGetMigrateData() uses the cmd ovs-vsctl to
get portdata. If no portdata is available, rather than failure in running
the cmd, we think we should just print a warning message here, rather than
taking it as
On Thu, Feb 26, 2015 at 10:25:45AM +0100, Martin Kletzander wrote:
On Thu, Feb 12, 2015 at 12:08:54PM +0800, Zhang Bo wrote:
The function virNetDevOpenvswitchGetMigrateData() uses the cmd ovs-vsctl to
get portdata. If no portdata is available, rather than failure in running
the cmd, we think we
On Thu, Feb 26, 2015 at 17:58:36 +0800, Zhu Guihua wrote:
On 02/25/2015 10:44 PM, Peter Krempa wrote:
Add support to start qemu instance with 'pc-dimm' device. Thanks to the
refactors we are able to reuse the existing function to determine the
parameters.
---
Notes:
Version
Peter Krempa (2):
util: storagefile: Don't crash on gluster URIs without path
util: storage: Fix error type in virStorageSourceParseBackingURI
src/util/virstoragefile.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
--
2.2.2
--
libvir-list mailing list
On 02/25/2015 10:44 PM, Peter Krempa wrote:
Add support to start qemu instance with 'pc-dimm' device. Thanks to the
refactors we are able to reuse the existing function to determine the
parameters.
---
Notes:
Version 2:
- dropped the ACPI naming
src/qemu/qemu_command.c
On Thu, Feb 26, 2015 at 10:50:56AM +0100, Peter Krempa wrote:
Peter Krempa (2):
util: storagefile: Don't crash on gluster URIs without path
util: storage: Fix error type in virStorageSourceParseBackingURI
src/util/virstoragefile.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
Similar to commit fdb80ed4f6563928b9942a0d1450e0c725aa6c06 libvirtd
would crash if a gluster URI without path would be used in the backing
chain of a volume. The crash happens in the gluster specific part of the
parser that extracts the gluster volume name from the path.
Fix the crash by checking
The gluster volume name extraction code was copied from the XML parser
without changing the VIR_ERR_XML_ERROR error code. Use
VIR_ERR_CONFIG_UNSUPPORTED instead.
---
src/util/virstoragefile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/virstoragefile.c
On 02/25/2015 11:55 PM, Laine Stump wrote:
On 02/25/2015 04:50 AM, lhuang wrote:
And i also thought about another issue after your reminding: An
interface can have more than one IPv6 address. But i still couldn't
find a good way until now to chose which IPv6 address if we find more
than one
On Thu, Feb 26, 2015 at 11:35:08 +0100, Martin Kletzander wrote:
On Thu, Feb 26, 2015 at 10:50:56AM +0100, Peter Krempa wrote:
Peter Krempa (2):
util: storagefile: Don't crash on gluster URIs without path
util: storage: Fix error type in virStorageSourceParseBackingURI
To prevent a confusion about missing chardev argument in qemu
command line add a note about that behavior into documentation.
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
docs/formatdomain.html.in | 4
1 file changed, 4 insertions(+)
diff --git a/docs/formatdomain.html.in
On Thu, Feb 26, 2015 at 02:14:20PM +0800, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1196503
We already check whether the host id is valid or not, add a jump
to forbid invalid host id.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/conf/network_conf.c | 1 +
1
In virNetworkDHCPHostDefParseXML an error is reported
when partialOkay == true, and none of ip, mac, name
were supplied.
Add the missing goto and error out in this case.
---
src/conf/network_conf.c | 1 +
1 file changed, 1 insertion(+)
Pushed as trivial.
diff --git a/src/conf/network_conf.c
On Wed, Feb 25, 2015 at 11:21:58AM +0100, Peter Krempa wrote:
NUMA enabled guest configuration explicitly specifies memory sizes for
individual nodes. Allowing the virDomainSetMemoryFlags API (and friends)
to change the total doesn't make sense as the individual node configs
are not updated in
On Wed, Feb 25, 2015 at 11:22:00AM +0100, Peter Krempa wrote:
Commit 60f7303c151cccdbe214b9f9ac59ecaf95cbf24b introduced the error
message but it's unclear whether the persistent config or the live
config tripped the message. Later the LXC driver copied the same code.
Separate the message which
On Wed, Feb 25, 2015 at 11:22:03AM +0100, Peter Krempa wrote:
The messages for currentMemory and memory were swapped.
---
Notes:
Version 2:
- new in series
src/phyp/phyp_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/phyp/phyp_driver.c
https://bugzilla.redhat.com/show_bug.cgi?id=1070695
Modify the virsh man page to more accurately describe which values are
set by the virsh setmem and displayed by the virsh memtune or dominfo
based on the setmem command results.
Signed-off-by: John Ferlan jfer...@redhat.com
---
tools/virsh.pod
A disk using a source pool is listed as having a source '-' in domblklist
because it doesn't check the right XML syntax to find the source.
Add a check for ./source/volume which is where the path (of sorts)
to the volume name is described.
Signed-off-by: John Ferlan jfer...@redhat.com
---
1 - 100 of 104 matches
Mail list logo
