On 26.02.2015 15:17, Michal Privoznik wrote:
snip/
BTW: I've done some testing locally and it helped me to find a bug in my
patches (I've just proposed the diff to be squashed in). Basically, my
test program defines 10 dummy networks, and spawns a thread over each
one of them. The thread does
Instead of checking defaultMode for every channel that has no mode
configured, test it only once outside of channel loop. This fixes a bug
that in case all possible channels are fore example set to insecure, but
defaultMode is set to secure, we wouldn't auto-generate TLS port. This
results in
Pavel Hrdina (2):
qemu: remove duplicated code for allocating spice ports
qemu: check defaultMode for spice graphics independently
src/qemu/qemu_driver.c | 45 ++
src/qemu/qemu_process.c | 73 -
On Fri, Feb 27, 2015 at 02:37:00PM +0100, Michal Privoznik wrote:
On 26.02.2015 15:17, Michal Privoznik wrote:
snip/
BTW: I've done some testing locally and it helped me to find a bug in my
patches (I've just proposed the diff to be squashed in). Basically, my
test program defines 10
On 26.02.2015 15:17, Michal Privoznik wrote:
Now that we have fine grained locks, there's no need to lock the
whole driver. We can rely on self-locking APIs.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/network/bridge_driver.c | 45
We have two different places that needs to be updated while touching
code for allocation spice ports. Add a bool option to
'qemuProcessSPICEAllocatePorts' function to switch between true and fake
allocation so we can use this function also in qemu_driver to generate
native domain definition.
If a user specify ehernet device create it via libvirt and run
script if it provided. After this commit user does not need to
run external script to create tap device or add root to qemu
process.
Signed-off-by: Vasiliy Tolstov v.tols...@selfip.ru
---
src/qemu/qemu_command.c | 135
Not just the DomainObj's private data.
---
src/qemu/qemu_domain.c | 4 +++-
src/qemu/qemu_domain.h | 2 +-
src/qemu/qemu_driver.c | 24
3 files changed, 16 insertions(+), 14 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index
Previously, only virDomainObjIsActive() was used to check domain liveness.
This includes states like 'VIR_DOMAIN_PMSUSPENDED', where QEMU is running,
but the guest is not.
Explicitly check the state against VIR_DOMAIN_RUNNING and refuse to
communicate with the agent if it does not match.
As reported on the libvirt-users list [1], there's new web
application called mist.io which uses libvirt as one of its
backends. Lets add it into our list of libivrt based
applications.
1: https://www.redhat.com/archives/libvirt-users/2015-February/msg00096.html
Signed-off-by: Michal Privoznik
If the domain is not running, the agent will not respond.
Do not even try.
https://bugzilla.redhat.com/show_bug.cgi?id=872424
---
src/qemu/qemu_domain.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index f3f3910..28bfbee 100644
---
This way checks requiring the job can be done in qemuDomainAgentAvailable.
---
src/qemu/qemu_driver.c | 33 +
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index e282464..d5b9d0d 100644
---
On Fri, 2015-02-27 at 11:51 -0700, Jim Fehlig wrote:
2015-02-23 20:13:15.845+: 2133: error :
virFirewallValidateBackend:193 : direct firewall backend requested,
but /sbin/ebtables is not available: No such file or directory
Odd, since ebtables was found when building
checking for
Ian Campbell wrote:
On Thu, 2015-02-26 at 20:14 +, xen.org wrote:
flight 35257 xen-unstable real [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/35257/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
To prevent a confusion about missing chardev argument in qemu
command line add a note about that behavior into documentation.
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
docs/formatdomain.html.in | 4
1 file changed, 4 insertions(+)
diff --git a/docs/formatdomain.html.in
On 02/19/2015 10:35 PM, Michal Privoznik wrote:
On 11.02.2015 16:57, Shanzhi Yu wrote:
When create internel system checkpoint snapshot with source file based
on rbd backend, libvirt miss to check if the format of source file
support internal snapshot.
Resolves:
Commit cf2d4c6 used a logical or instead of bitwise or,
effectively passing 1, that is VIR_DOMAIN_XML_INACTIVE.
Yep, that's right.
This was caught by a warning when building with clang.
https://bugzilla.redhat.com/show_bug.cgi?id=1183869
---
src/qemu/qemu_driver.c | 2 +-
1 file changed, 1
On 02/27/2015 08:30 AM, Ján Tomko wrote:
Previously, only virDomainObjIsActive() was used to check domain liveness.
This includes states like 'VIR_DOMAIN_PMSUSPENDED', where QEMU is running,
but the guest is not.
Explicitly check the state against VIR_DOMAIN_RUNNING and refuse to
On 02/25/2015 11:55 PM, Laine Stump wrote:
On 02/25/2015 04:50 AM, lhuang wrote:
And i also thought about another issue after your reminding: An
interface can have more than one IPv6 address. But i still couldn't
find a good way until now to chose which IPv6 address if we find more
than one
Oops, I started looking at this patch the moment you sent it but got
distracted and never finished the review. Sorry about this.
On Thu, Feb 19, 2015 at 16:22:38 +0100, Ján Tomko wrote:
Filter out non-migratable features if
VIR_CONNECT_BASELINE_CPU_MIGRATABLE was specified.
---
v2: use the
On 02/27/2015 08:13 AM, Michal Privoznik wrote:
As reported on the libvirt-users list [1], there's new web
application called mist.io which uses libvirt as one of its
backends. Lets add it into our list of libivrt based
applications.
1:
When compiling libvirt (and probably other packages) on Fedora rawhide
systems, I'm seeing a new warning message on every link line.
# rpm -q libtool gcc binutils
libtool-2.4.6-1.fc23.x86_64
gcc-5.0.0-0.16.fc23.x86_64
binutils-2.25-6.fc23.x86_64
For an example of the warning during a 'make V=1':
On Fri, Feb 27, 2015 at 12:07:40 +0100, Ján Tomko wrote:
Commit cf2d4c6 used a logical or instead of bitwise or,
effectively passing 1, that is VIR_DOMAIN_XML_INACTIVE.
Yep, that's right.
This was caught by a warning when building with clang.
On Fri, Feb 27, 2015 at 12:07:40PM +0100, Ján Tomko wrote:
Commit cf2d4c6 used a logical or instead of bitwise or,
effectively passing 1, that is VIR_DOMAIN_XML_INACTIVE.
Yep, that's right.
This was caught by a warning when building with clang.
Our documentation isn't 100% clear about hostdev 'managed' attribute usage,
because it only makes sense to use it with PCI devices, yet we format
this attribute to all hostdev devices. By adding a note into the docs,
we can possibly avoid confusion from customer's side and also avoid a solution
25 matches
Mail list logo
