Re: [libvirt] [PATCH 0/2] Disallow the usage of the same target dev value

2015-03-02 Thread John Ferlan
On 02/26/2015 04:59 PM, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1142631 Patch 1 was found when adjusting the bz to get the disk by the pool source instead of directly by file attribute. When using domblklist, the source wasn't displayed. Followed the model of the

Re: [libvirt] [PATCH] docs: add a mention for start a vm with rawio = 'yes'

2015-03-02 Thread lhuang
On 03/02/2015 06:43 PM, Daniel P. Berrange wrote: On Mon, Mar 02, 2015 at 06:04:44PM +0800, Luyao Huang wrote: When we start a vm which have rawio = 'yes' settings without any file caps settings for qemu, qemu process still cannot use this caps (CAP_SYS_RAWIO) and the /proc/pidofqemu/status

Re: [libvirt] [PATCH 2/2] virsh.pod: Update find-storage-pool-sources[-as] man page

2015-03-02 Thread John Ferlan
On 03/02/2015 09:52 AM, Martin Kletzander wrote: On Thu, Feb 26, 2015 at 04:43:54PM -0500, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=921426 Add to the man page a more complete description of what exactly the command expects on input and will return on output based on

Re: [libvirt] [PATCH v3 0/9] Introduce display of IOThreads Information

2015-03-02 Thread John Ferlan
On 02/24/2015 07:01 AM, John Ferlan wrote: On 02/17/2015 04:03 PM, John Ferlan wrote: v2 here: http://www.redhat.com/archives/libvir-list/2015-February/msg00562.html Changes over v2: Patches 1-4 * Add resources and nresources in order to return the resources that are using an

Re: [libvirt] [PATCH] docs: add a mention for start a vm with rawio = 'yes'

2015-03-02 Thread Daniel P. Berrange
On Mon, Mar 02, 2015 at 06:04:44PM +0800, Luyao Huang wrote: When we start a vm which have rawio = 'yes' settings without any file caps settings for qemu, qemu process still cannot use this caps (CAP_SYS_RAWIO) and the /proc/pidofqemu/status like this: CapInh: 0002 CapPrm:

Re: [libvirt] [PATCHv2 4/7] phyp: Fix error messages mentioning memory

2015-03-02 Thread Peter Krempa
On Thu, Feb 26, 2015 at 13:29:15 +0100, Martin Kletzander wrote: On Wed, Feb 25, 2015 at 11:22:03AM +0100, Peter Krempa wrote: The messages for currentMemory and memory were swapped. --- Notes: Version 2: - new in series src/phyp/phyp_driver.c | 4 ++-- 1 file changed, 2

Re: [libvirt] [PATCH] disk: Provide a default storage source format type.

2015-03-02 Thread Martin Kletzander
On Thu, Feb 26, 2015 at 07:43:33PM -0500, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1181062 According to the formatstorage.html description for source element and format attribute: All drivers are required to have a default value for this, so it is optional. As it turns

Re: [libvirt] [PATCH] virsh.pod: Add information regarding LXC for setmem, memtune, and dominfo

2015-03-02 Thread Martin Kletzander
On Thu, Feb 26, 2015 at 06:39:29PM -0500, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1070695 Modify the virsh man page to more accurately describe which values are set by the virsh setmem and displayed by the virsh memtune or dominfo based on the setmem command results.

Re: [libvirt] overlayfs support to lxc driver

2015-03-02 Thread Daniel P. Berrange
On Mon, Mar 02, 2015 at 05:38:11PM +0400, Vasiliy Tolstov wrote: Hello. I'm interesting in implementing overlayfs support to lxc libvirt driver. As i see i simply can utilize filesystem type='template' for this usage. The semantics of the 'template' type are that the virt driver unpacks a

Re: [libvirt] [PATCH 1/2] iscsi: Adjust error message for findStorageSources backend

2015-03-02 Thread Martin Kletzander
On Thu, Feb 26, 2015 at 04:43:53PM -0500, John Ferlan wrote: The virStorageBackendISCSIFindPoolSources API only needs the 'host' name in order to discover iSCSI pools, it returns the various device paths. On input, it's also possible to further restrict a search by providing the port attribute

Re: [libvirt] [PATCH 1/2] virsh: Adjust domblklist to understand disk volume syntax

2015-03-02 Thread Martin Kletzander
On Thu, Feb 26, 2015 at 04:59:02PM -0500, John Ferlan wrote: A disk using a source pool is listed as having a source '-' in domblklist because it doesn't check the right XML syntax to find the source. Add a check for ./source/volume which is where the path (of sorts) to the volume name is

Re: [libvirt] [PATCH 2/2] virsh.pod: Update find-storage-pool-sources[-as] man page

2015-03-02 Thread Martin Kletzander
On Thu, Feb 26, 2015 at 04:43:54PM -0500, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=921426 Add to the man page a more complete description of what exactly the command expects on input and will return on output based on what is currently supported. Perhaps missing

[libvirt] overlayfs support to lxc driver

2015-03-02 Thread Vasiliy Tolstov
Hello. I'm interesting in implementing overlayfs support to lxc libvirt driver. As i see i simply can utilize filesystem type='template' for this usage. In case os template fs i need to mount with lowerdir /var/lib/libvirt/filesystems/template to /var/lib/libvirt/filesystems/name But i have

Re: [libvirt] [PATCH] docs: add a note that attr 'managed' is only used by PCI devices

2015-03-02 Thread Martin Kletzander
On Fri, Feb 27, 2015 at 12:45:57PM +0100, Erik Skultety wrote: Our documentation isn't 100% clear about hostdev 'managed' attribute usage, because it only makes sense to use it with PCI devices, yet we format this attribute to all hostdev devices. By adding a note into the docs, we can possibly

[libvirt] Fwd: [PATCH 0/2] PowerPC : Miscellaneous fixes for 'ppc64le' architecture.

2015-03-02 Thread Prerna Saxena
Ping !` Can you pls let me know if this suffices ? Regards, Prerna Forwarded Message Subject:[libvirt] [PATCH 0/2] PowerPC : Miscellaneous fixes for 'ppc64le' architecture. Date: Thu, 26 Feb 2015 22:39:20 +0530 From: Prerna Saxena pre...@linux.vnet.ibm.com To:

[libvirt] [PATCH] qemu: fix not remove the pidfile when close a vm after restart libvirtd

2015-03-02 Thread Luyao Huang
https://bugzilla.redhat.com/show_bug.cgi?id=1197600 when create a happy vm and then restart libvirtd, we will loss priv-pidfile, because we don't check if it is there is a pidfile. However we only use this pidfile when we start the vm, and won't use it after it start, so this is not a big deal.

[libvirt] [PATCH] storage: sheepdog: Avoid skipping variable initialization

2015-03-02 Thread Peter Krempa
Commit 155ca616eb231181f6978efc9e3a1eb0eb60af8a added a error message that skips initialization of the 'cmd' variable. Fortunately it was not released. --- Pushed under the trivial build-breaker rule. src/storage/storage_backend_sheepdog.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [libvirt] [libvirt-test-API][PATCH 1/2] Add freepage test

2015-03-02 Thread jiahu
On 02/15/2015 03:01 PM, Jincheng Miao wrote: For system default pagesize, it's hard to calculate, and it changes all the time, so just skip it. For others, reading from sysfs to get free pages. Signed-off-by: Jincheng Miao jm...@redhat.com --- repos/virconn/free_pages.py | 97

[libvirt] [PATCH] docs: add a mention for start a vm with rawio = 'yes'

2015-03-02 Thread Luyao Huang
When we start a vm which have rawio = 'yes' settings without any file caps settings for qemu, qemu process still cannot use this caps (CAP_SYS_RAWIO) and the /proc/pidofqemu/status like this: CapInh: 0002 CapPrm: CapEff: CapBnd:

Re: [libvirt] [PATCH] docs: add a note that attr 'managed' is only used by PCI devices

2015-03-02 Thread Erik Skultety
On 03/02/2015 12:10 PM, Martin Kletzander wrote: On Fri, Feb 27, 2015 at 12:45:57PM +0100, Erik Skultety wrote: Our documentation isn't 100% clear about hostdev 'managed' attribute usage, because it only makes sense to use it with PCI devices, yet we format this attribute to all hostdev

Re: [libvirt] [PATCHv2 1/7] qemu: Forbid setting maximum memory size with the API with NUMA enabled

2015-03-02 Thread Peter Krempa
On Thu, Feb 26, 2015 at 15:15:27 +0100, Martin Kletzander wrote: On Thu, Feb 26, 2015 at 01:20:29PM +0100, Martin Kletzander wrote: On Wed, Feb 25, 2015 at 11:21:58AM +0100, Peter Krempa wrote: NUMA enabled guest configuration explicitly specifies memory sizes for individual nodes. Allowing

Re: [libvirt] [PATCH] Add ability to set rlimits at container boot

2015-03-02 Thread Ryan Cleere
Hi Richard, All I am suggesting is that someone may want to run a custom process as their init process that may or may not have the ability to set the rlimits. This would just allow them to start in a known state. You are absolutely right that without user namespaces the container could set them

[libvirt] [PATCH] qemu: Don't crash in qemuDomainOpenChannel()

2015-03-02 Thread Martin Kletzander
The problem here was that when opening a channel, we were checking whether the channel given is alias (can't be NULL for running domain) or it's name, which can be NULL (for example with spicevmc). In case of such domain qemuDomainOpenChannel() made the daemon crash. STREQ_NULLABLE() is safe to

Re: [libvirt] bug#19967: new warning from ar on rawhide systems

2015-03-02 Thread Bob Friesenhahn
On Fri, 27 Feb 2015, Eric Blake wrote: Is it worth teaching libtool to change ARFLAGS to be 'crD' instead of 'cru' when it is detected that ar is new enough to support deterministic libraries, in part to shut up the warning message being printed on every single libtool link line? (Note that I

Re: [libvirt] overlayfs support to lxc driver

2015-03-02 Thread Vasiliy Tolstov
2015-03-02 16:59 GMT+03:00 Daniel P. Berrange berra...@redhat.com: Conceptually creating a target for the overlay is easy, the difficult question is how do we expect apps to actually manage the overlays once created. In particular at which point do they get deleted. I don't think we would want

Re: [libvirt] overlayfs support to lxc driver

2015-03-02 Thread Vasiliy Tolstov
2015-03-02 18:22 GMT+03:00 Vasiliy Tolstov v.tols...@selfip.ru: So as i understand i need to add overlayfs like virStorageBackendFileSystem for example virStorageBackendOvlFileSystem but i don't understand how can this pool be used in case of many containers. May be i misunderstand something?

Re: [libvirt] [PATCHv2 6/7] conf: numa: Add helper to count total memory size configured in NUMA

2015-03-02 Thread Peter Krempa
On Thu, Feb 26, 2015 at 14:49:33 +0100, Martin Kletzander wrote: On Wed, Feb 25, 2015 at 11:22:05AM +0100, Peter Krempa wrote: The total NUMA memory consists of the sum of individual NUMA node memory amounts. --- Notes: Version 2: - Already ACKed but didn't make sense to push.

Re: [libvirt] [PATCH 1/2] qemu: remove duplicated code for allocating spice ports

2015-03-02 Thread Martin Kletzander
On Fri, Feb 27, 2015 at 03:35:26PM +0100, Pavel Hrdina wrote: We have two different places that needs to be updated while touching code for allocation spice ports. Add a bool option to 'qemuProcessSPICEAllocatePorts' function to switch between true and fake allocation so we can use this

Re: [libvirt] [PATCH 2/2] disk: Disallow duplicated target 'dev' values

2015-03-02 Thread Martin Kletzander
On Thu, Feb 26, 2015 at 04:59:03PM -0500, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1142631 This patch resolves a situation where the same target dev='$name'... can be used for multiple disks in the domain. While the $name is mostly advisory regarding the expected order

[libvirt] [PATCH] conf: De-duplicate scheduling policy enums

2015-03-02 Thread Martin Kletzander
Since adding the support for scheduler policy settings in commit 8680ea97, there are two enums with the same information. That was caused by rewriting the patch since first draft. Find out thanks to clang, but there was no impact whatsoever. Signed-off-by: Martin Kletzander mklet...@redhat.com

Re: [libvirt] [PATCH 2/2] qemu: check defaultMode for spice graphics independently

2015-03-02 Thread Martin Kletzander
On Fri, Feb 27, 2015 at 03:35:27PM +0100, Pavel Hrdina wrote: Instead of checking defaultMode for every channel that has no mode configured, test it only once outside of channel loop. This fixes a bug that in case all possible channels are fore example set to insecure, but defaultMode is set to

Re: [libvirt] [PATCH v1 17/31] test_driver: Adapt to new virNetworkObjList accessors

2015-03-02 Thread Peter Krempa
On Thu, Feb 26, 2015 at 15:17:26 +0100, Michal Privoznik wrote: Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/test/test_driver.c | 64 ++ 1 file changed, 12 insertions(+), 52 deletions(-) diff --git a/src/test/test_driver.c

Re: [libvirt] [PATCH v1 18/31] parallels_network: Adapt to new virNetworkObjList accessors

2015-03-02 Thread Peter Krempa
On Thu, Feb 26, 2015 at 15:17:27 +0100, Michal Privoznik wrote: Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/parallels/parallels_network.c | 66 +++ 1 file changed, 12 insertions(+), 54 deletions(-) ACK, Peter signature.asc Description:

Re: [libvirt] [PATCH] qemu: Don't crash in qemuDomainOpenChannel()

2015-03-02 Thread Pavel Hrdina
On Mon, Mar 02, 2015 at 05:22:10PM +0100, Martin Kletzander wrote: The problem here was that when opening a channel, we were checking whether the channel given is alias (can't be NULL for running domain) or it's name, which can be NULL (for example with spicevmc). In case of such domain

Re: [libvirt] [PATCH] conf: De-duplicate scheduling policy enums

2015-03-02 Thread Eric Blake
On 03/02/2015 09:17 AM, Martin Kletzander wrote: Since adding the support for scheduler policy settings in commit 8680ea97, there are two enums with the same information. That was caused by rewriting the patch since first draft. Find out thanks to clang, but there was no impact whatsoever.

Re: [libvirt] [PATCH] qemu: Don't crash in qemuDomainOpenChannel()

2015-03-02 Thread Eric Blake
On 03/02/2015 09:22 AM, Martin Kletzander wrote: The problem here was that when opening a channel, we were checking whether the channel given is alias (can't be NULL for running domain) or it's name, which can be NULL (for example with spicevmc). In case of such domain qemuDomainOpenChannel()

[libvirt] [PATCH] schema: Fix interface link state schema

2015-03-02 Thread Peter Krempa
In commit edd1295e1da6bfe8e4e257e5fbfad71ac0bf7c87 I've introduced an XML element that allows to configure state of the network interface link. Somehow the RNG schema hunk ended up in a weird place in the network schema definition. Move it to the right place and add a test case. Note that the

Re: [libvirt] [PATCH] schema: Fix interface link state schema

2015-03-02 Thread Eric Blake
On 03/02/2015 09:40 AM, Peter Krempa wrote: In commit edd1295e1da6bfe8e4e257e5fbfad71ac0bf7c87 I've introduced an XML element that allows to configure state of the network interface link. Somehow the RNG schema hunk ended up in a weird place in the network schema definition. Move it to the

[libvirt] QEMU, libvirt, and KVM are participating in Google Summer of Code 2015

2015-03-02 Thread Stefan Hajnoczi
I am delighted to announce that QEMU, libvirt, and KVM are participating in Google Summer of Code 2015. Thanks to Google's generous funding we are inviting students to apply for 12-week full-time work from May to August 2015. Here is our project ideas list page where students can select a