On 03.03.2015 11:47, Peter Krempa wrote:
On Thu, Feb 26, 2015 at 15:17:28 +0100, Michal Privoznik wrote:
Well, one day this will be self-locking object, but not today.
But lets prepare the code for that! Moreover,
virNetworkObjListFree() is no longer needed, so turn it into
On 03.03.2015 12:05, Peter Krempa wrote:
On Thu, Feb 26, 2015 at 15:17:30 +0100, Michal Privoznik wrote:
So far it's just a structure which happens to have 'Obj' in its
name, but otherwise it not related to virObject at all. No
reference counting, not virObjectLock(), nothing.
Signed-off-by:
On Tue, Mar 03, 2015 at 13:40:48 +0100, Michal Privoznik wrote:
On 03.03.2015 11:47, Peter Krempa wrote:
On Thu, Feb 26, 2015 at 15:17:28 +0100, Michal Privoznik wrote:
Well, one day this will be self-locking object, but not today.
But lets prepare the code for that! Moreover,
On Thu, Feb 26, 2015 at 15:17:37 +0100, Michal Privoznik wrote:
This patch turns both virNetworkObjFindByUUID() and
virNetworkObjFindByName() to return an referenced object so that
even if caller unlocks it, it's for sure that object won't
disappear meanwhile. Especially if the object (in
On Thu, Feb 26, 2015 at 15:17:36 +0100, Michal Privoznik wrote:
Every API that touches internal structure of the object must lock
the object first. Not every API that has the object as an
argument needs to do that though. Some APIs just pass the object
to lower layers, which, however, must
On Thu, Feb 26, 2015 at 15:17:38 +0100, Michal Privoznik wrote:
Now that we have fine grained locks, there's no need to lock the
whole driver. We can rely on self-locking APIs.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/network/bridge_driver.c | 45
On 03/02/2015 05:43 AM, Daniel P. Berrange wrote:
On Mon, Mar 02, 2015 at 06:04:44PM +0800, Luyao Huang wrote:
When we start a vm which have rawio = 'yes' settings without
any file caps settings for qemu, qemu process still cannot use
this caps (CAP_SYS_RAWIO) and the /proc/pidofqemu/status
On 02.03.2015 10:37, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1197600
when create a happy vm and then restart libvirtd, we will loss
priv-pidfile, because we don't check if it is there is a pidfile.
However we only use this pidfile when we start the vm, and won't use
On Thu, Feb 26, 2015 at 15:17:28 +0100, Michal Privoznik wrote:
Well, one day this will be self-locking object, but not today.
But lets prepare the code for that! Moreover,
virNetworkObjListFree() is no longer needed, so turn it into
virNetworkObjListDispose().
Signed-off-by: Michal
https://bugzilla.redhat.com/show_bug.cgi?id=1197600
So, libvirt uses pid file to track pid of started qemus. Whenever
a domain is started, its pid is put into corresponding pid file.
The pid file path is generated based on domain name and stored
into domain object internals. However, it's not
On Tuesday 03 March 2015 03:29 PM, Michal Privoznik wrote:
On 26.02.2015 18:09, Prerna Saxena wrote:
From a28ef5a3e7b9cb023948cf97d9f472bb3a1e06d3 Mon Sep 17 00:00:00 2001
From: Prerna Saxena pre...@linux.vnet.ibm.com
Date: Thu, 26 Feb 2015 22:31:05 +0530
This series adds few miscellaneous
On Tue, Mar 03, 2015 at 11:56:37 +0100, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1197600
So, libvirt uses pid file to track pid of started qemus. Whenever
a domain is started, its pid is put into corresponding pid file.
The pid file path is generated based on
On Thu, Feb 26, 2015 at 15:17:30 +0100, Michal Privoznik wrote:
So far it's just a structure which happens to have 'Obj' in its
name, but otherwise it not related to virObject at all. No
reference counting, not virObjectLock(), nothing.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
These cover 2 additional types of libvirt interfaces: usermode/SLIRP
networking and bridge.
---
libvirt-designer/libvirt-designer-domain.c | 70 +-
libvirt-designer/libvirt-designer-domain.h | 5 +++
libvirt-designer/libvirt-designer.sym | 2 +
3 files changed,
---
libvirt-designer/libvirt-designer-domain.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libvirt-designer/libvirt-designer-domain.c
b/libvirt-designer/libvirt-designer-domain.c
index 7387ab1..0321180 100644
--- a/libvirt-designer/libvirt-designer-domain.c
+++
Hey,
After seeing the libvirt-designer GSoC idea, I remembered about a bunch of
libvirt-designer patches I had never sent :) Here they are, a few leak
fixes/build cleanups, and addition of 2 new methods for completeness.
Christophe
--
libvir-list mailing list
libvir-list@redhat.com
A GVirConfigDomainDiskDriver is created in
gvir_designer_domain_add_disk_full but it's never unref'ed. This commit
fixes that, including when an error occurs.
---
libvirt-designer/libvirt-designer-domain.c | 4
1 file changed, 4 insertions(+)
diff --git
The latter is deprecated in favour of the former.
---
examples/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/Makefile.am b/examples/Makefile.am
index 1d8947f..65a5afe 100644
--- a/examples/Makefile.am
+++ b/examples/Makefile.am
@@ -1,4 +1,4 @@
-INCLUDES
This fixes gcc warning about -Wmudflap on fedora 21
---
m4/manywarnings.m4 | 213 ++---
1 file changed, 137 insertions(+), 76 deletions(-)
diff --git a/m4/manywarnings.m4 b/m4/manywarnings.m4
index fd0e372..3e6dd21 100644
--- a/m4/manywarnings.m4
When an unknown NIC type is passed to
gvir_designer_domain_add_interface_full(), 'ret' would be returned
uninitialized to the caller.
---
libvirt-designer/libvirt-designer-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt-designer/libvirt-designer-domain.c
The caller of gvir_designer_domain_add_interface_network() owns a reference
on the returned GVirConfigDomainInterface instance, so it needs to be
released when no longer needed.
---
examples/virt-designer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/examples/virt-designer.c
On Mon, Mar 02, 2015 at 10:37:06 -0700, Eric Blake wrote:
On 03/02/2015 09:40 AM, Peter Krempa wrote:
In commit edd1295e1da6bfe8e4e257e5fbfad71ac0bf7c87 I've introduced an
XML element that allows to configure state of the network interface
link. Somehow the RNG schema hunk ended up in a
On Tue, Mar 03, 2015 at 13:47:32 +0100, Michal Privoznik wrote:
On 03.03.2015 12:05, Peter Krempa wrote:
On Thu, Feb 26, 2015 at 15:17:30 +0100, Michal Privoznik wrote:
So far it's just a structure which happens to have 'Obj' in its
name, but otherwise it not related to virObject at all. No
On Thu, Feb 26, 2015 at 15:17:32 +0100, Michal Privoznik wrote:
This is practically copy of qemuDomObjEndAPI. The reason why is
it so widely available is to avoid code duplication, since the
function is going to be called from our bridge driver, test
driver and parallels driver too.
On Thu, Feb 26, 2015 at 15:17:33 +0100, Michal Privoznik wrote:
So far, this is pure code replacement. But once we introduce
reference counting to virNetworkObj this will be more handy as
there'll be only one function to change: virNetworkObjEndAPI().
Signed-off-by: Michal Privoznik
On Thu, Feb 26, 2015 at 15:17:31 +0100, Michal Privoznik wrote:
Later we can turn APIs to lock the object if needed instead of
relying on caller to mutually exclude itself (probably done by
locking a big lock anyway).
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
On 03/03/2015 08:57 AM, Erik Skultety wrote:
According to the POSIX standard, off_t (returned by lseek) is defined as
signed integral type no shorter than int. Because our offset variable is
defined
as unsigned long long, the original check was passed successfully if
UINT64_MAX had
been
From: Mikhail Feoktistov mfeoktis...@parallels.com
Otherwise exporting existing domain config and defining a new one like this:
virsh -c parallels:///system dumpxml instance01 my.xml
virsh -c parallels:///system define my.xml
leads to an error because PCS default x64 mode turns to x32.
Thus, we
Signed-off-by: Maxim Nestratov mnestra...@parallels.com
---
src/parallels/parallels_network.c |4 ++--
src/parallels/parallels_sdk.c |6 +++---
src/parallels/parallels_utils.h |8 +++-
3 files changed, 12 insertions(+), 6 deletions(-)
diff --git
Failures of parallelsStorageOpen occured because we incorrectly treated
path to VM' configuration file as a directory. Now initialization of
parallels VM domains home directory is fixed.
Signed-off-by: Maxim Nestratov mnestra...@parallels.com
---
src/parallels/parallels_sdk.c |8
1
In order to support 'bridge' network adapters in parallels
driver we need to plug our veth devices into corresponding
linux bridges.
We are going to do this by reusing our abstraction of
Virtual Networks in terms of PCS. On a domain creation, we
create a new Virtual Network naming it with the same
Signed-off-by: Maxim Nestratov mnestra...@parallels.com
---
src/parallels/parallels_driver.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c
index c9338b5..90b8b0a 100644
---
when a new network adapter device is added
Signed-off-by: Maxim Nestratov mnestra...@parallels.com
---
src/parallels/parallels_sdk.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c
index cf81540..d4e19e7
which is on by default when a new VM/CT is created.
We should do this because this feature can't be controlled
by libvirt now and it sets up some iptables rules. So it's
better to do this to avoid potential conflict of different
set of rules or to avoid unexpected behavior.
Signed-off-by: Maxim
Don't fail initialization of parallels driver if
parallelsLoadNetwork fails for optional networks.
This can happen when some of them are added manually
and configured incompletely. PCS requires only two networks
created automatically (named Host-Only and Bridged), others
are optional and their
indentation is fixed, unnecessary error message removed,
unnecessary job freeing removed
Signed-off-by: Maxim Nestratov mnestra...@parallels.com
---
src/parallels/parallels_sdk.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/src/parallels/parallels_sdk.c
Signed-off-by: Maxim Nestratov mnestra...@parallels.com
---
src/parallels/parallels_sdk.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c
index d4e19e7..ef513d7 100644
--- a/src/parallels/parallels_sdk.c
+++
Maxim Nestratov (9):
parallels: don't forget to unlock domain if unregister fails
parallels: fix home directory for VMs
parallels: minor cleanup
parallels: introduce and use string constants for network types and
names
parallels: fix parallelsLoadNetworks
parallels: better bridge
This series contains a few simple changes to the libxl driver.
Patches 1 and 2 were included in
https://www.redhat.com/archives/libvir-list/2015-February/msg00611.html
To make an upcoming V2 of that series easier to review, I removed the
mostly unrelated patches and include them here, along with
Domain death watch is already disabled in libxlDomainCleanup. No
need to disable it a second and third time.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_domain.c | 8
1 file changed, 8 deletions(-)
diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
In the old days of a global driver lock, it was necessary to unlock
the driver after a domain restore operation. When the global lock
was removed from the driver, some remnants were left behind in
libxlDomainRestoreFlags. Remove this unneeded (and incorrect) code.
Signed-off-by: Jim Fehlig
Instead of using the libxl_ctx in the libxlDomainObjPrivatePtr,
use the ctx passed to the callback.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
src/libxl/libxl_domain.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
---
V1 here:
https://www.redhat.com/archives/libvir-list/2015-February/msg00388.html
V2:
Add --if-exists option to ovs-vsctl cmd, making ovs-vsctl not raise error
if there's no portData
available. Suggested by Martin.
We Tested the patch, it works.
---
Introduced by f6a2f97e
On 03/03/2015 06:57 PM, Michal Privoznik wrote:
On 02.03.2015 10:37, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1197600
when create a happy vm and then restart libvirtd, we will loss
priv-pidfile, because we don't check if it is there is a pidfile.
However we only use this
On Thu, Feb 26, 2015 at 15:17:35 +0100, Michal Privoznik wrote:
So far, this is pure code replacement. But once we introduce
reference counting to virNetworkObj this will be more handy as
there'll be only one function to change: virNetworkObjEndAPI().
Signed-off-by: Michal Privoznik
On 03.03.2015 14:10, Peter Krempa wrote:
On Tue, Mar 03, 2015 at 13:47:32 +0100, Michal Privoznik wrote:
On 03.03.2015 12:05, Peter Krempa wrote:
On Thu, Feb 26, 2015 at 15:17:30 +0100, Michal Privoznik wrote:
So far it's just a structure which happens to have 'Obj' in its
name, but otherwise
On Thu, Feb 26, 2015 at 15:17:33 +0100, Michal Privoznik wrote:
So far, this is pure code replacement. But once we introduce
reference counting to virNetworkObj this will be more handy as
there'll be only one function to change: virNetworkObjEndAPI().
Signed-off-by: Michal Privoznik
On Thu, Feb 26, 2015 at 15:17:25 +0100, Michal Privoznik wrote:
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/network/bridge_driver.c | 333
1 file changed, 148 insertions(+), 185 deletions(-)
Some bikeshedding below ...
diff
On Thu, Feb 26, 2015 at 15:17:29 +0100, Michal Privoznik wrote:
Now that all the code uses accessors, don't expose the structure
anyway.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/conf/network_conf.c | 7 +++
src/conf/network_conf.h | 6 --
2 files changed, 7
On Tue, Mar 03, 2015 at 11:56:37AM +0100, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1197600
So, libvirt uses pid file to track pid of started qemus. Whenever
a domain is started, its pid is put into corresponding pid file.
The pid file path is generated based on
On Thu, Feb 26, 2015 at 5:04 PM, Peter Krempa pkre...@redhat.com wrote:
On Mon, Feb 23, 2015 at 14:18:31 +0100, Matthias Gatto wrote:
On Tue, Feb 10, 2015 at 4:43 PM, Matthias Gatto
matthias.ga...@outscale.com wrote:
The purpose of these patches is to introduce quorum for libvirt
I've try
On 26.02.2015 18:09, Prerna Saxena wrote:
From a28ef5a3e7b9cb023948cf97d9f472bb3a1e06d3 Mon Sep 17 00:00:00 2001
From: Prerna Saxena pre...@linux.vnet.ibm.com
Date: Thu, 26 Feb 2015 22:31:05 +0530
This series adds few miscellaneous fixes for PowerPC 64-bit Little
Endian Architecture.
Add a test to demonstrate the effect of this series.
---
.../qemuxml2argv-channel-virtio-autoassign.args| 20 +
.../qemuxml2argv-channel-virtio-autoassign.xml | 50 ++
tests/qemuxml2argvtest.c | 2 +
3 files changed, 72 insertions(+)
Instead of simply incrementing the port, respect
maximum port values and use multiple controllers.
Ján Tomko (5):
Add test for virtio serial port assignment
Add functions to track virtio-serial addresses
Allocate virtio-serial addresses when starting a domain
Expand the address set when
Store the available ports of a virtio-serial controller in a virBitmap.
The bitmaps are stored in a hash table - the controller index
formatted as a string.
Buses are not tracked, because they aren't supported by QEMU.
---
src/conf/domain_addr.c | 382
---
src/qemu/qemu_hotplug.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 08047ce..aec541a 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -435,6 +435,7 @@ int
---
src/qemu/qemu_hotplug.c | 21 +++--
tests/qemuhotplugtest.c | 2 +-
2 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index aec541a..66e052e 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@
Instead of always using controller 0 and incrementing port number,
respect the maximum port numbers of controllers and use all of them.
Ports for virtio consoles are quietly reserved, but not formatted
(neither in XML nor on QEMU command line).
Also rejects duplicate virtio-serial addresses.
Implement virCommandPassFDGetFDIndex to determine the index a given
file descriptor will have when passed to the child process.
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com
---
src/libvirt_private.syms | 1 +
src/util/vircommand.c| 24
On Thu, Feb 26, 2015 at 15:17:34 +0100, Michal Privoznik wrote:
So far, this is pure code replacement. But once we introduce
reference counting to virNetworkObj this will be more handy as
there'll be only one function to change: virNetworkObjEndAPI().
Signed-off-by: Michal Privoznik
Move the TPM command line build code into its own function.
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com
---
src/qemu/qemu_command.c | 37 +
1 file changed, 25 insertions(+), 12 deletions(-)
diff --git a/src/qemu/qemu_command.c
Pass the TPM file descriptor to QEMU via command line.
Instead of passing /dev/tpm0 we now pass /dev/fdset/10 and the additional
parameters -add-fd set=10,fd=20.
This addresses the use case when QEMU is started with non-root privileges
and QEMU cannot open /dev/tpm0 for example.
Signed-off-by:
On Thu, Feb 26, 2015 at 15:17:36 +0100, Michal Privoznik wrote:
Every API that touches internal structure of the object must lock
the object first. Not every API that has the object as an
argument needs to do that though. Some APIs just pass the object
to lower layers, which, however, must
63 matches
Mail list logo
