Re: [libvirt] [PATCHv2 4/4] qemu: fix a error coverd issue in 2 place

2015-03-08 Thread John Ferlan
On 02/28/2015 04:08 AM, Luyao Huang wrote: we already set a more clearly error in networkGetNetworkAddress, so this error will cover our error in networkGetNetworkAddress. Signed-off-by: Luyao Huang lhu...@redhat.com --- src/qemu/qemu_command.c | 14 -- 1 file changed, 4

Re: [libvirt] [PATCHv2 3/4] network: rework networkGetNetworkAddress to make it can get IPv6 address

2015-03-08 Thread lhuang
On 03/09/2015 07:50 AM, John Ferlan wrote: $SUBJ: network: Allow networkGetNetworkAddress to return IPv6 address On 02/28/2015 04:08 AM, Luyao Huang wrote: Export the required helpers and rework networkGetNetworkAddress to make it can get IPv6 address. Signed-off-by: Luyao Huang

Re: [libvirt] [PATCHv2 4/4] qemu: fix a error coverd issue in 2 place

2015-03-08 Thread lhuang
On 03/09/2015 07:51 AM, John Ferlan wrote: On 02/28/2015 04:08 AM, Luyao Huang wrote: we already set a more clearly error in networkGetNetworkAddress, so this error will cover our error in networkGetNetworkAddress. Signed-off-by: Luyao Huang lhu...@redhat.com --- src/qemu/qemu_command.c |

Re: [libvirt] [PATCHv2 1/4] util: introduce 2 new helpers for get interface IPv6 address

2015-03-08 Thread John Ferlan
On 02/28/2015 04:08 AM, Luyao Huang wrote: Introduce virNetDevGetIfaddrsAddress to help to get interface IPv6 and IPv4 address. Introduce virNetDevGetIPAddress to use virNetDevGetIfaddrsAddress and virNetDevGetIPv4Address to get IP address. Signed-off-by: Luyao Huang lhu...@redhat.com

[libvirt] [PATCH] libvirt-domain.h: changing some unsigned int parameters to the respective enum type.

2015-03-08 Thread Julio Faracco
Recently, some code were cleaned ups. Now, some parameters are being converted to its respective enum type. For example, there are many functions that are using int or unsigned int types instead enum types. So, this kind of cleaning up can be necessary. Signed-off-by: Julio Faracco

Re: [libvirt] [PATCH] libvirt-domain.h: changing some unsigned int parameters to the respective enum type.

2015-03-08 Thread Julio Faracco
Hi guys! I'm really don't know the reason of keeping 'unsigned int' instead 'enum' types. I asked it at IRC, but no response. =( Is it need a clean up or it is designed this way? Thanks! -- *Julio Cesar Faracco* -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCHv2 2/4] conf: introduce new family attribute in graphics listen for chose IP family

2015-03-08 Thread lhuang
On 03/09/2015 07:50 AM, John Ferlan wrote: On 02/28/2015 04:08 AM, Luyao Huang wrote: If a interface or network have both ipv6 and ipv4 address which can be used, we do not know use which be a listen address. So introduce a new attribute to help us chose this. graphics XML will like this

Re: [libvirt] [PATCHv2 3/4] network: rework networkGetNetworkAddress to make it can get IPv6 address

2015-03-08 Thread John Ferlan
$SUBJ: network: Allow networkGetNetworkAddress to return IPv6 address On 02/28/2015 04:08 AM, Luyao Huang wrote: Export the required helpers and rework networkGetNetworkAddress to make it can get IPv6 address. Signed-off-by: Luyao Huang lhu...@redhat.com --- v2: rework the code and make

Re: [libvirt] [PATCHv2 2/4] conf: introduce new family attribute in graphics listen for chose IP family

2015-03-08 Thread John Ferlan
On 02/28/2015 04:08 AM, Luyao Huang wrote: If a interface or network have both ipv6 and ipv4 address which can be used, we do not know use which be a listen address. So introduce a new attribute to help us chose this. graphics XML will like this after this commit: graphics

Re: [libvirt] [PATCH v3 4/4] migration: Expose 'cancelling' status to user

2015-03-08 Thread zhanghailiang
On 2015/3/7 0:24, Eric Blake wrote: On 03/04/2015 07:09 AM, zhanghailiang wrote: 'cancelling' status is introduced by commit 51cf4c1a, which is mainly avoid s/is introduced/was introduced/ s/which is mainly avoid/mainly to avoid a/ possible starting a new migration process while the

Re: [libvirt] [PATCH 5/6] qemu: Change qemuDomainGetVcpuPinInfo bitmap manipulation

2015-03-08 Thread Ján Tomko
On Fri, Mar 06, 2015 at 01:47:11PM -0500, John Ferlan wrote: Follow-up to the IOThread review on CPU affinity map manipulation: http://www.redhat.com/archives/libvir-list/2015-March/msg00294.html indicates that the GetVcpuPinInfo could use similar algorithm adjustments which is what this

Re: [libvirt] [PATCH 0/6] Follow-up patches for IOThread API/display

2015-03-08 Thread Ján Tomko
On Fri, Mar 06, 2015 at 01:47:06PM -0500, John Ferlan wrote: Based on jtomko's review of the IOThread series and my foray into the libvirt-perl bindings, these patches make the following adjustments: Patch 1 - Found while generating the virsh iothreadpin description, the vcpupin