The connection_security_model.py uses getSecurityModel() to validate new API
virNodeGetSecurityModel of libvirt.
---
cases/linux_domain.conf| 4 ++
repos/virconn/connection_security_model.py | 101 +
2 files changed, 105 insertions(+)
create mode
---
src/qemu/qemu_command.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index aa7a928..02105c3 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -1683,8 +1683,8 @@ qemuDomainPCIA
https://bugzilla.redhat.com/show_bug.cgi?id=1199182 documents that
after a series of disk snapshots into existing destination images,
followed by active commits of the top image, it is possible for
qemu 2.2 and earlier to end up tracking a different name for the
image than what it would have had wh
Daniel P. Berrange wrote:
> On Fri, Mar 13, 2015 at 06:38:24PM -0600, Jim Fehlig wrote:
>
>> Commit 4ab8cd77 added a check requiring input devices to have
>> a bus type of VIR_DOMAIN_INPUT_BUS_USB, failing to start the
>> domain otherwise. But virDomainDefParseXML adds implicit mouse
>> and key
On Fri, Mar 13, 2015 at 06:38:24PM -0600, Jim Fehlig wrote:
> Commit 4ab8cd77 added a check requiring input devices to have
> a bus type of VIR_DOMAIN_INPUT_BUS_USB, failing to start the
> domain otherwise. But virDomainDefParseXML adds implicit mouse
> and keyboard if a graphics device is configu
There's no need to lock the network driver, as network driver
initialization is done prior accepting any client. There's nobody
to hop in and do something over partially initialized driver. Nor
qemu driver is doing that.
==30532== Observed (incorrect) order is: acquisition of lock at 0x1439EF50
==
Lets not give a bad example and check for return values of
virNetwork* APIs called within the test. Even though it's
unlikely that any API will fail, it can happen. We're connected
to the test driver after all, and our API sequence is correct. So
test driver should fail only in case of bug or OOM.
This function does not make any sense now, that network driver is
(almost) dropped. I mean, previously, when threads were
serialized, this function was there to check, if no other network
with the same name or UUID exists. However, nowadays that threads
can run more in parallel, this function is us
I've noticed these while testing the code.
Michal Privoznik (3):
networkStateInitialize: Don't lock network driver
objecteventtest: Check for virNetwork* return values
network_conf: Drop virNetworkObjIsDuplicate
src/conf/network_conf.c | 171 ++
On Mon, Mar 16, 2015 at 10:09:22 -0600, Eric Blake wrote:
> On 03/16/2015 09:55 AM, Peter Krempa wrote:
> > Patch 51f9f03a4ca50b070c0fbfb29748d49f583e15e1 introduces a regression
> > where if a blockCommit operation fails the disk is still marked as being
> > part of a block job but can't be unmark
On Mon, Mar 16, 2015 at 02:09:39PM +0100, Erik Skultety wrote:
On 03/13/2015 05:17 PM, Martin Kletzander wrote:
In order not to leave old error messages set, this patch refactors the
code so the error is reported only when acted upon. The only such place
already rewrites any error, so cleanin
On 03/16/2015 09:55 AM, Peter Krempa wrote:
> Patch 51f9f03a4ca50b070c0fbfb29748d49f583e15e1 introduces a regression
> where if a blockCommit operation fails the disk is still marked as being
> part of a block job but can't be unmarked later.
> ---
> src/qemu/qemu_driver.c | 3 ++-
> 1 file change
On Fri, Mar 13, 2015 at 10:38:57 -0400, John Ferlan wrote:
>
>
> On 03/04/2015 11:24 AM, Peter Krempa wrote:
> > Make sure that libvirt has all vital information needed to reliably
> > represent configuration of guest's memory devices in case of a
> > migration.
> >
> > This patch forbids migrat
Commit 4f25146 (v1.2.8) managed to silence Coverity, but at the
cost of a memory leak detected by valgrind:
==24129== 40 bytes in 5 blocks are definitely lost in loss record 355 of 637
==24129==at 0x4A08B1C: realloc (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==24129==by 0x5
On 03/13/2015 11:11 PM, John Ferlan wrote:
> During the review process a few things were pointed at as perhaps
> needing some adjustments based on what was done for IOThreads.
> Specifically a memory leak in PinVcpuFlags since PinIOThreads was
> just a copy of the Vcpu code and secondarily since
Patch 51f9f03a4ca50b070c0fbfb29748d49f583e15e1 introduces a regression
where if a blockCommit operation fails the disk is still marked as being
part of a block job but can't be unmarked later.
---
src/qemu/qemu_driver.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/qemu
On Fri, Mar 13, 2015 at 10:39:05 -0400, John Ferlan wrote:
> On 03/04/2015 11:24 AM, Peter Krempa wrote:
> > Add a few helpers that allow to operate with memory device definitions
> > on the domain config and use them to implement memory device coldplug in
> > the qemu driver.
> > ---
> > src/conf
On Fri, Mar 13, 2015 at 20:48:39 -0400, John Ferlan wrote:
>
>
> On 03/04/2015 11:25 AM, Peter Krempa wrote:
> > Add code to hot-add memory devices to running qemu instances.
> > ---
> > src/qemu/qemu_command.c | 4 +--
> > src/qemu/qemu_command.h | 15 +
> > src/qemu/qemu_driver.c |
From: Nehal J Wani
examples/Makefile.am:
* Add new file domipaddrs.py
examples/README:
* Add documentation for the python example
libvirt-override-api.xml:
* Add new symbol for virDomainInterfacesAddresses
libvirt-override.c:
* Hand written python api
Example:
$ python examples/domi
On Mon, Mar 16, 2015 at 08:42:49AM -0400, John Ferlan wrote:
>
>
> On 03/11/2015 07:09 AM, Daniel P. Berrange wrote:
> > From: Nehal J Wani
> >
> > By querying the qemu guest agent with the QMP command
> > "guest-network-get-interfaces" and converting the received JSON
> > output to structured
On Mon, Mar 16, 2015 at 08:42:18AM -0400, John Ferlan wrote:
>
>
> On 03/11/2015 07:09 AM, Daniel P. Berrange wrote:
> > From: Nehal J Wani
> >
> > Define helper function virDomainInterfaceFree, which allows
> > the upper layer application to free the domain interface object
> > conveniently.
>
On Thu, Mar 12, 2015 at 10:07:04 -0400, John Ferlan wrote:
> On 03/06/2015 09:40 AM, Peter Krempa wrote:
> > Pavel's series changed few same places thus the previous version no longer
> > applies.
> >
> > Peter Krempa (4):
> > conf: Replace access to def->mem.max_balloon with accessor functions
On Mon, Mar 16, 2015 at 02:38:40PM +0100, Pavel Hrdina wrote:
> On Mon, Mar 16, 2015 at 12:46:04PM +, Daniel P. Berrange wrote:
> > On Mon, Mar 16, 2015 at 01:41:15PM +0100, Pavel Hrdina wrote:
> > > Wireshark supports pkg-config since 1.11.3. Right now we build
> > > wireshark-dissectior tool
On Mon, Mar 16, 2015 at 12:46:04PM +, Daniel P. Berrange wrote:
> On Mon, Mar 16, 2015 at 01:41:15PM +0100, Pavel Hrdina wrote:
> > Wireshark supports pkg-config since 1.11.3. Right now we build
> > wireshark-dissectior tool as default trough rpm build only on
> > fedora >= 21 and there is new
On 03/16/2015 01:38 PM, Peter Krempa wrote:
> On Mon, Mar 16, 2015 at 09:34:56 +0100, Erik Skultety wrote:
>
> The actual patch is missing :)
>
> Peter
>
>
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
Oops, sent a regular
---
AUTHORS.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/AUTHORS.in b/AUTHORS.in
index 329924f..6673b3f 100644
--- a/AUTHORS.in
+++ b/AUTHORS.in
@@ -16,6 +16,7 @@ Daniel Berrange
Daniel Veillard
Doug Goldstein
Eric Blake
+Erik Skultety
Gao Feng
Guido G??nther
J??n Tomko
--
On 03/16/2015 02:19 PM, Erik Skultety wrote:
> ---
> AUTHORS.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/AUTHORS.in b/AUTHORS.in
> index 329924f..6673b3f 100644
> --- a/AUTHORS.in
> +++ b/AUTHORS.in
> @@ -16,6 +16,7 @@ Daniel Berrange
> Daniel Veillard
> Doug Goldstein
> E
The following is a long winded way to say this patch is avoiding a
false positive.
Coverity complains that calling networkPlugBandwidth() could eventually
end up with a NULL dereference on iface->bandwidth because in the
networkAllocateActualDevice there's a check of 'iface->bandwidth'
before deci
On 03/13/2015 05:17 PM, Martin Kletzander wrote:
> We're parsing memballoon status period as unsigned int, but when we're
> trying to set it, both we and qemu use signed int. That means large
> values will get wrapped around to negative one resulting in error.
> Basically the same problem as com
On 03/13/2015 05:17 PM, Martin Kletzander wrote:
> In order not to leave old error messages set, this patch refactors the
> code so the error is reported only when acted upon. The only such place
> already rewrites any error, so cleaning up all the error reporting in
> qemuMonitorSetMemoryStatsP
On 03/13/2015 05:17 PM, Martin Kletzander wrote:
> All the devices we have format their address as its last sub-element, so
> let's change memballoon to follow suit. Also adjust RNG to allow any
> order of them so 'virsh edit' doesn't shout at us.
>
> Signed-off-by: Martin Kletzander
> ---
>
On 03/13/2015 05:17 PM, Martin Kletzander wrote:
> Change it so it really *always* eats the @toadd buffer.
>
> Signed-off-by: Martin Kletzander
> ---
> src/util/virbuffer.c | 14 +-
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/src/util/virbuffer.c b/src/util/
On Fri, Mar 13, 2015 at 11:11:52PM -0400, John Ferlan wrote:
> Make common between Vcpu and IOThreads
I feel like this sentence is missing something.
>
> Signed-off-by: John Ferlan
> ---
> src/conf/domain_conf.c | 24
> src/conf/domain_conf.h | 6 +++---
> src/lib
On Fri, Mar 13, 2015 at 11:11:44PM -0400, John Ferlan wrote:
> During the review process a few things were pointed at as perhaps
> needing some adjustments based on what was done for IOThreads.
> Specifically a memory leak in PinVcpuFlags since PinIOThreads was
> just a copy of the Vcpu code and se
On Mon, Mar 16, 2015 at 08:43:32AM -0400, John Ferlan wrote:
>
>
> On 03/11/2015 07:09 AM, Daniel P. Berrange wrote:
> > From: Nehal J Wani
> >
> > tools/virsh-domain-monitor.c
> >* Introduce new command : domifaddr
> > Usage: domifaddr [interface] [--full] [--source lease|agent]
> >
On Mon, Mar 16, 2015 at 01:41:15PM +0100, Pavel Hrdina wrote:
> Wireshark supports pkg-config since 1.11.3. Right now we build
> wireshark-dissectior tool as default trough rpm build only on
> fedora >= 21 and there is newer wireshark that supports pkg-config.
> If someone wants to build libvirt w
On 03/11/2015 07:09 AM, Daniel P. Berrange wrote:
> From: Nehal J Wani
>
> Define helper function virDomainInterfaceFree, which allows
> the upper layer application to free the domain interface object
> conveniently.
>
> The API is going to provide multiple methods by flags, e.g.
> * Query g
On 03/11/2015 07:09 AM, Daniel P. Berrange wrote:
> From: Nehal J Wani
>
> daemon/remote.c
>* Define remoteSerializeDomainInterface,
> remoteDispatchDomainInterfaceAddresses
>
> src/remote/remote_driver.c
>* Define remoteDomainInterfaceAddresses
>
> src/remote/remote_protocol.x
>
Wireshark supports pkg-config since 1.11.3. Right now we build
wireshark-dissectior tool as default trough rpm build only on
fedora >= 21 and there is newer wireshark that supports pkg-config.
If someone wants to build libvirt with wireshark-dissector against older
wireshark, they should specify t
On 03/11/2015 07:09 AM, Daniel P. Berrange wrote:
> From: Nehal J Wani
>
> tools/virsh-domain-monitor.c
>* Introduce new command : domifaddr
> Usage: domifaddr [interface] [--full] [--source lease|agent]
>
> Example outputs:
> virsh # domifaddr f20
> Name MAC add
On Mon, Mar 16, 2015 at 09:34:56 +0100, Erik Skultety wrote:
The actual patch is missing :)
Peter
signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 03/11/2015 07:09 AM, Daniel P. Berrange wrote:
> From: Nehal J Wani
>
> By querying the qemu guest agent with the QMP command
> "guest-network-get-interfaces" and converting the received JSON
> output to structured objects.
>
> Although "ifconfig" is deprecated, IP aliases created by "ifcon
On Tue, Mar 10, 2015 at 11:04:00AM -0400, John Ferlan wrote:
> Test results in the following output:
>
> $ perl examples/iothreadsinfo.pl
> Addr
> VMM type: QEMU
> ...
> Domain: {
> ID: 2 'f18iothr'
> UUID: fb9f7826-b5d7-4f74-b962-7181ef3fc9ec
> IOThread: {
> affinity: 0010
> number:
[PATCH] PowerPC : Do not allow an empty model spec for 'host-model'
On PowerPC, a guest VM having CPU mode as 'host-model'
represents a 'compat' mode VM. This cannot have a NULL
CPU model.
This commit forbids such a guest definition.
Signed-off-by: Prerna Saxena
---
src/cpu/cpu_powerpc.c | 2 +
On Fri, Mar 13, 2015 at 11:24:25 -0600, Eric Blake wrote:
> On 03/13/2015 10:25 AM, Peter Krempa wrote:
> > Block job handling violates our usage of domain jobs and changes disk source
> > definition behind our back.
> >
> > Peter Krempa (3):
> > qemu: process: Export qemuProcessFindDomainDiskBy
On Fri, Mar 13, 2015 at 04:09:57PM -0300, Eduardo Habkost wrote:
> With the Intel microcode update that removed HLE and RTM, there will be
> different kinds of Haswell and Broadwell CPUs out there: some that still
> have the HLE and RTM features, and some that don't have the HLE and RTM
> features.
On Fri, Mar 13, 2015 at 13:36:13 -0600, Eric Blake wrote:
> On 03/13/2015 10:25 AM, Peter Krempa wrote:
> > While qemu may be prepared to do this libvirt is not. Forbid the block
> > ops until we fix our code.
> > ---
> > src/conf/domain_conf.h | 1 +
> > src/qemu/qemu_domain.c | 23 +
On Fri, Mar 13, 2015 at 04:09:56PM -0300, Eduardo Habkost wrote:
> This reverts commit 13704e4c455770d500d6b87b117e32f0d01252c9.
>
> With the Intel microcode update that removed HLE and RTM, there will be
> different kinds of Haswell and Broadwell CPUs out there: some that still
> have the HLE and
On 02/20/2015 06:09 PM, Peter Krempa wrote:
> I think Erik's patch is actually fine in the context of the code.
>
> Peter
OK, now pushed, thanks.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
50 matches
Mail list logo
