Re: [libvirt] [PATCHv2 2/5] Add functions to track virtio-serial addresses

2015-03-24 Thread Ján Tomko
On Mon, Mar 23, 2015 at 05:46:19PM -0400, John Ferlan wrote: On 03/17/2015 07:41 AM, Ján Tomko wrote: Create a sorted array of virtio-serial controllers. Each of the elements contains the controller index and a bitmap of available ports. Buses are not tracked, because they aren't

Re: [libvirt] [PATCH 4/6] qemu: check if domain is really active when do setvcpus with --live

2015-03-24 Thread lhuang
On 03/24/2015 05:31 PM, Pavel Hrdina wrote: On Tue, Mar 24, 2015 at 02:27:42PM +0800, lhuang wrote: On 03/20/2015 10:39 PM, Pavel Hrdina wrote: From: Luyao Huang lhu...@redhat.com Commit e105dc9 fix setting vcpus for offline domain, but forget check if vm is active when pass

[libvirt] [libvirt-glib] build-sys: Fix libtoolize detection in autogen.sh

2015-03-24 Thread Christophe Fergeau
autogen.sh is currently checking for the libtool binary, but it's libtoolize which is needed by autoreconf, not libtool. These binaries are packaged separately on Debian/Ubuntu so this can cause actual issues on some systems. Bug reported by Frederic Peters --- autogen.sh | 2 +- 1 file

Re: [libvirt] [PATCH 2/7] conf: Add support for storage state directory

2015-03-24 Thread John Ferlan
On 03/24/2015 06:06 AM, Erik Skultety wrote: Before introducing necessary changes to storage_driver.c, first prepare our structures for storage state XML support. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1177733 --- src/conf/storage_conf.h | 1 +

Re: [libvirt] [PATCH] RFC: Add domain vmport attribute

2015-03-24 Thread Marc-André Lureau
Hi On Mon, Mar 23, 2015 at 11:42 PM, Daniel P. Berrange berra...@redhat.com wrote: I think we'd normally place this kind of attribute in the features/features block rather than here. eg see the toggle for turning on/off hyper-v emulation. Are you suggesting this: vmport state=on/off/? and if

Re: [libvirt] [libvirt-glib] build-sys: Fix libtoolize detection in autogen.sh

2015-03-24 Thread Michal Privoznik
On 24.03.2015 13:51, Christophe Fergeau wrote: autogen.sh is currently checking for the libtool binary, but it's libtoolize which is needed by autoreconf, not libtool. These binaries are packaged separately on Debian/Ubuntu so this can cause actual issues on some systems. Bug reported by

[libvirt] [PATCH 3/4] tests: xml2xml: Refactor the qemu xml 2 xml test

2015-03-24 Thread Peter Krempa
To allow adding more tests, refactor the XML-2-XML test so that the files are not reloaded always and clarify the control flow. Result of this changes is that the active and inactive portions of the XML are tested in separate steps rather than one test step. --- tests/qemuxml2xmltest.c | 214

[libvirt] [PATCH 2/4] util: buffer: Add support for adding text blocks with indentation

2015-03-24 Thread Peter Krempa
The current auto-indentation buffer code applies indentation only on complete strings. To allow adding a string containing newlines and having it properly indented this patch adds virBufferAddStr. --- src/libvirt_private.syms | 1 + src/util/virbuffer.c | 38

[libvirt] [PATCH 4/4] test: qemuxml2xml: Test status XML formatting and parsing

2015-03-24 Thread Peter Krempa
Recently we've fixed a bug where the status XML could not be parsed as the parser used absolute path XPath queries. This test enhancement tests all XML files used in the qemu-xml-2-xml test as a part of a status XML snippet to see whether they are parsed correctly. The status XML-2-XML is

Re: [libvirt] [libvirt-glib] build-sys: Fix libtoolize detection in autogen.sh

2015-03-24 Thread Christophe Fergeau
On Tue, Mar 24, 2015 at 02:22:13PM +0100, Michal Privoznik wrote: On 24.03.2015 13:51, Christophe Fergeau wrote: autogen.sh is currently checking for the libtool binary, but it's libtoolize which is needed by autoreconf, not libtool. These binaries are packaged separately on

[libvirt] [PATCH] qemu: Give hint about -noTSX CPU model

2015-03-24 Thread Jiri Denemark
Because of the microcode update to Haswell/Broadwell CPUs, existing domains using these CPUs may fail to start even though they used to run just fine. To help users solve this issue we try to suggest switching to -noTSX variant of the CPU model: virsh # start cd error: Failed to start

[libvirt] [PATCH 0/4] Test status XML formatting and parsing

2015-03-24 Thread Peter Krempa
A recent bug showed that the status XML parsing is not tested. Add test cases based on existing tests in the XML-2-XML test to excercise the parser. Additionally this series fixes also a memleak of the domain device alias list. Peter Krempa (4): qemu: domain: Don't leak device alias list

[libvirt] [PATCH 1/4] qemu: domain: Don't leak device alias list

2015-03-24 Thread Peter Krempa
While adding tests for status XML parsing and formatting I've noticed that the device alias list is leaked. ==763001== 81 (48 direct, 33 indirect) bytes in 1 blocks are definitely lost in loss record 414 of 514 ==763001==at 0x4C2B8F0: calloc (vg_replace_malloc.c:623) ==763001==by

Re: [libvirt] [Xen-devel] libvirt/libxl implemetation of get_online_cpu / virNodeGetCPUMap?

2015-03-24 Thread Manish Jaggi
On Tuesday 24 February 2015 08:30 PM, Anthony PERARD wrote: On Tue, Feb 24, 2015 at 01:22:19PM +, Daniel P. Berrange wrote: On Tue, Feb 24, 2015 at 01:15:57PM +, Anthony PERARD wrote: On Tue, Feb 24, 2015 at 12:46:44PM +, Daniel P. Berrange wrote: On Tue, Feb 24, 2015 at

[libvirt] [PATCH] cpu: Add {Haswell,Broadwell}-noTSX CPU models

2015-03-24 Thread Jiri Denemark
QEMU 2.3 adds these new models to cover Haswell and Broadwell CPUs with updated microcode. Luckily, they also reverted former the machine type specific changes to existing models. And since these changes were never released, we don't need to hack around them in libvirt. Signed-off-by: Jiri

Re: [libvirt] [PATCH] conf: fix running vm numa settings disappear after restart libvirtd

2015-03-24 Thread Peter Krempa
On Mon, Mar 23, 2015 at 20:11:19 +0800, Luyao Huang wrote: On 03/23/2015 06:10 PM, Peter Krempa wrote: On Thu, Mar 19, 2015 at 18:13:04 +0800, Luyao Huang wrote: 5bba61f introduce a issue : when start a vm with numa settings and restart libvirtd, numa settings will disappear. Because when

Re: [libvirt] [PATCH] hostdev: fix two bugs in virHostdevReAttachPCIDevices

2015-03-24 Thread John Ferlan
On 03/22/2015 09:59 AM, Huanle Han wrote: Bug 1: The the next element in the pcidevs is skipped after we virPCIDeviceListDel the previous element. Bug 2: virHostdevNetConfigRestore is called for store the hostdevs which may be used by other domain. Signed-off-by: Huanle Han

Re: [libvirt] [PATCHv2 3/5] Allocate virtio-serial addresses when starting a domain

2015-03-24 Thread John Ferlan
On 03/24/2015 07:41 AM, Ján Tomko wrote: On Mon, Mar 23, 2015 at 05:46:23PM -0400, John Ferlan wrote: ... Mostly for my edification... These examples previously although indicating they were auto-assign (of sorts) really weren't - they were more force-assign for each example.

[libvirt] [PATCH] qemu: fix can use setmaxmem to change the maximum memory biger than max memory

2015-03-24 Thread Luyao Huang
When call qemuDomainSetMemoryFlags() to change maximum memory size, we do not check if the maximum memory is biger than the max memory, this will make vm disappear after libvirtd restart if we set a big maximum memory. Add a check for this, also fix a typos issue. Signed-off-by: Luyao Huang

Re: [libvirt] [PATCH 4/6] qemu: check if domain is really active when do setvcpus with --live

2015-03-24 Thread Pavel Hrdina
On Tue, Mar 24, 2015 at 02:27:42PM +0800, lhuang wrote: On 03/20/2015 10:39 PM, Pavel Hrdina wrote: From: Luyao Huang lhu...@redhat.com Commit e105dc9 fix setting vcpus for offline domain, but forget check if vm is active when pass VIR_DOMAIN_AFFECT_LIVE flags. # virsh setvcpus

[libvirt] [PATCH v3 0/2] network_conf: check if bridge exists on host for user created bridges

2015-03-24 Thread Shivaprasad G Bhat
The patch fixes the below problem. == If the bridge name is not mentioned in the network xml, the bridge name is auto generated from virNetworkAllocateBridge(). If the default template named bridge is created manually by a user, the bridge start will fail with File

[libvirt] [PATCH v3 1/2] cleanup conf/device_conf.h inclusion from util/virnetdev.h

2015-03-24 Thread Shivaprasad G Bhat
Move the struct and enum definitions from device_conf.h to virnetdev.h thus avoiding the file inclusion. The wrong reference of conf files from util/ is allowed in Makefile.am for now. The reason being, The change in Makefile.am for libvirt_util_la_CFLAGS to remove conf from the utils would

Re: [libvirt] GSOC 2015: Libvirt Projects

2015-03-24 Thread Michal Privoznik
On 24.03.2015 10:27, Stefan Hajnoczi wrote: On Fri, Mar 13, 2015 at 12:03 AM, Richa Sehgal richasehgal2...@gmail.com wrote: I am currently pursuing Master's in University of Illinois at Urbana Champaign, USA and completed by B.Tech from Indian Institute of Technology - Delhi (IIT- Delhi). I

[libvirt] [PATCH] conf: refact virDomainHasDiskMirror and rename it to virDomainHasBlockjob

2015-03-24 Thread Shanzhi Yu
Create external snapshot or migrate a vm when there is a blockpull job running should be forbidden by libvirt, otherwise qemu try to create external snapshot and failed with error unable to execute QEMU command 'transaction': Device 'drive-virtio-disk0' is busy: block device is in use by block

[libvirt] [PATCH 0/7] Introduce storage pool status XML

2015-03-24 Thread Erik Skultety
All of the commits resolve BZ https://bugzilla.redhat.com/show_bug.cgi?id=1177733 Erik Skultety (7): storage: Remove unused attribute conn from 'checkPool' callback conf: Add support for storage state directory conf: Add/modify storage formatting functions storage: Modify stateInitialize

[libvirt] [PATCH 2/7] conf: Add support for storage state directory

2015-03-24 Thread Erik Skultety
Before introducing necessary changes to storage_driver.c, first prepare our structures for storage state XML support. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1177733 --- src/conf/storage_conf.h | 1 + src/storage/storage_driver.c | 1 + 2 files changed, 2 insertions(+) diff

[libvirt] [PATCH 1/7] storage: Remove unused attribute conn from 'checkPool' callback

2015-03-24 Thread Erik Skultety
The checkPool callback should be used when updating states of all pools during storageStateInitialize, not storageDriverAutostart, otherwise we can't start a domain which mounts a volume after daemons restarted. This is because qemuProcessReconnect is called earlier than storageDriverAutostart

Re: [libvirt] GSOC 2015: Libvirt Projects

2015-03-24 Thread Stefan Hajnoczi
On Fri, Mar 13, 2015 at 12:03 AM, Richa Sehgal richasehgal2...@gmail.com wrote: I am currently pursuing Master's in University of Illinois at Urbana Champaign, USA and completed by B.Tech from Indian Institute of Technology - Delhi (IIT- Delhi). I am interested in contributing to Libvirt

[libvirt] [PATCH 3/7] conf: Add/modify storage formatting functions

2015-03-24 Thread Erik Skultety
This patch introduces virStoragePoolSaveStatus to properly format the status XML. It also adds virStoragePoolDefFormatBuf function, which alike in the network driver, formats the whole storage pool definition into a buffer that might have been previously modified by virStoragePoolSaveStatus to

[libvirt] [PATCH 6/7] storage: Introduce storagePoolUpdateAllState function

2015-03-24 Thread Erik Skultety
The update was originally part of the storageDriverAutostart function, but the pools have to be checked earlier during initialization phase, so the 'checkPool' block has been moved to storagePoolUpdateAllState. Prior to this update virStoragePoolLoadAllConfigs and virStoragePoolLoadAllState

Re: [libvirt] [PATCHv2 3/5] Allocate virtio-serial addresses when starting a domain

2015-03-24 Thread Ján Tomko
On Mon, Mar 23, 2015 at 05:46:23PM -0400, John Ferlan wrote: On 03/17/2015 07:41 AM, Ján Tomko wrote: Instead of always using controller 0 and incrementing port number, respect the maximum port numbers of controllers and use all of them. Ports for virtio consoles are quietly

[libvirt] [PATCH v3 2/2] network_conf: check if bridge exists on host for user created bridges

2015-03-24 Thread Shivaprasad G Bhat
virNetworkBridgeInUse() doesn't check if the bridge is manually created outside of libvirt. Check if the bridge actually exist on host using the virNetDevExists(). Signed-off-by: Shivaprasad G Bhat sb...@linux.vnet.ibm.com --- src/conf/network_conf.c | 15 --- 1 file changed, 12

[libvirt] [PATCH 7/7] storage: Create/Delete pool status XML

2015-03-24 Thread Erik Skultety
Once we introduced virStoragePoolSaveStatus function, create a status XML every time a pool is created (virStoragePoolCreate, storageDriverAutostart) Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1177733 --- src/storage/storage_driver.c | 37

[libvirt] [PATCH 4/7] storage: Modify stateInitialize to support storage state XML

2015-03-24 Thread Erik Skultety
Storage state driver directories initialization needs to be modified to become more generic. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1177733 --- src/storage/storage_driver.c | 52 1 file changed, 29 insertions(+), 23 deletions(-) diff

[libvirt] [PATCH 5/7] conf: Introduce virStoragePoolLoadAllState virStoragePoolLoadState

2015-03-24 Thread Erik Skultety
These functions operate exactly the same as virStoragePoolLoadAllConfigs. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1177733 --- src/conf/storage_conf.c | 90 src/conf/storage_conf.h | 7 src/libvirt_private.syms | 1 +

Re: [libvirt] [PATCH 00/10] libxl: switch driver to use a single libxl_ctx

2015-03-24 Thread Jim Fehlig
Michal Privoznik wrote: On 18.02.2015 04:56, Jim Fehlig wrote: This series is a follow up to https://www.redhat.com/archives/libvir-list/2015-February/msg00024.html It goes a step further and changes the libxl driver to use one, driver-wide libxl_ctx. Currently the libxl driver has one

Re: [libvirt] [PATCH 1/4] util: netlink function to delete any network device

2015-03-24 Thread John Ferlan
On 03/23/2015 03:43 PM, Laine Stump wrote: libvirt has always used the netlink RTM_DELLINK message to delete macvtap/macvlan devices, but it can actually be used to delete other types of network devices, such as bonds and bridges. This patch makes virNetDevMacVLanDelete() available as a

Re: [libvirt] [PATCH 2/4] util: replace body of virNetDevMacVLanDelete() with virNetlinkDelLink()

2015-03-24 Thread John Ferlan
On 03/23/2015 03:43 PM, Laine Stump wrote: These two functions are identical, so no sense in having the duplication. I resisted the temptation to replace calls to virNetDevMacVLanDelete() with calls to virNetlinkDelLink() just in case some mythical future platform has macvtap devices that

Re: [libvirt] [PATCH 4/4] util: use netlink to create bridge devices

2015-03-24 Thread John Ferlan
On 03/23/2015 03:43 PM, Laine Stump wrote: Just as it is possible to delete a bridge device with the netlink RTM_DELLINK message, one can be created with the RTM_NEWLINK message. Because of differences in the format of the message, it's not as straightforward as with virNetlinkDelLink() to

Re: [libvirt] [PATCH 2/4] util: replace body of virNetDevMacVLanDelete() with virNetlinkDelLink()

2015-03-24 Thread John Ferlan
On 03/23/2015 03:43 PM, Laine Stump wrote: These two functions are identical, so no sense in having the duplication. I resisted the temptation to replace calls to virNetDevMacVLanDelete() with calls to virNetlinkDelLink() just in case some mythical future platform has macvtap devices that

Re: [libvirt] [PATCH 3/4] util: use netlink to delete bridge devices

2015-03-24 Thread John Ferlan
On 03/23/2015 03:43 PM, Laine Stump wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1125755 reported that a stray bridge device was left on the system when a libvirt network failed to start due to an illegal iptables rule caused by bad config. Apparently the reason this was happening

Re: [libvirt] [PATCH] qemucaps2xmltest: fix the test to correspond to new domain formatting

2015-03-24 Thread Peter Krempa
On Tue, Mar 24, 2015 at 15:31:09 +0100, Pavel Hrdina wrote: Commit 2360fe5d updated formating of domain element but forget to s/forget/forgot/ update qemucaps2xmldata xml files. In addition the test code was broken too. Update the xml files and return -1 if testCompareXMLToXML fails

Re: [libvirt] [PATCH 3/6] qemu: cleanup setvcpus

2015-03-24 Thread Peter Krempa
On Fri, Mar 20, 2015 at 15:39:01 +0100, Pavel Hrdina wrote: Remove unnecessary maximum variable and also exclusive flags check as they are now tested by upper layer for all drivers. The part about the exclusive flag check is not true. Signed-off-by: Pavel Hrdina phrd...@redhat.com ---

Re: [libvirt] [PATCH v3 2/2] network_conf: check if bridge exists on host for user created bridges

2015-03-24 Thread Laine Stump
On 03/24/2015 05:59 AM, Shivaprasad G Bhat wrote: virNetworkBridgeInUse() doesn't check if the bridge is manually created outside of libvirt. Check if the bridge actually exist on host using the virNetDevExists(). Signed-off-by: Shivaprasad G Bhat sb...@linux.vnet.ibm.com ---

Re: [libvirt] [PATCH 2/6] use new macro helpers to check exclusive flags

2015-03-24 Thread Peter Krempa
On Fri, Mar 20, 2015 at 15:39:00 +0100, Pavel Hrdina wrote: Signed-off-by: Pavel Hrdina phrd...@redhat.com --- src/libvirt-domain-snapshot.c | 45 ++ src/libvirt-domain.c | 288 +++-- src/qemu/qemu_driver.c | 9 +-

Re: [libvirt] [PATCH 2/7] conf: Add support for storage state directory

2015-03-24 Thread Peter Krempa
On Tue, Mar 24, 2015 at 10:16:25 -0400, John Ferlan wrote: On 03/24/2015 06:06 AM, Erik Skultety wrote: Before introducing necessary changes to storage_driver.c, first prepare our structures for storage state XML support. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1177733

[libvirt] [PATCH] qemu: change accidental VIR_WARNING back to VIR_DEBUG

2015-03-24 Thread Laine Stump
While debugging the support for responding to qemu RX_FILTER_CHANGED events, I had changed the ignoring this event log message from VIR_DEBUG to VIR_WARN, but forgot to change it back before pushing. Since many guest OSes make enough changes to multicast lists and/or promiscuous mode settings to

Re: [libvirt] [PATCH] qemucaps2xmltest: fix the test to correspond to new domain formatting

2015-03-24 Thread Pavel Hrdina
On Tue, Mar 24, 2015 at 04:36:09PM +0100, Peter Krempa wrote: On Tue, Mar 24, 2015 at 15:31:09 +0100, Pavel Hrdina wrote: Commit 2360fe5d updated formating of domain element but forget to s/forget/forgot/ update qemucaps2xmldata xml files. In addition the test code was broken too.

Re: [libvirt] [PATCH 1/6] internal: introduce macro helpers to reject exclusive flags

2015-03-24 Thread Peter Krempa
On Fri, Mar 20, 2015 at 15:38:59 +0100, Pavel Hrdina wrote: Inspired by commit 7e437ee7 that introduced similar macros for virsh commands so we don't have to repeat the same code all over. Signed-off-by: Pavel Hrdina phrd...@redhat.com --- src/internal.h | 80

[libvirt] [PATCH] qemucaps2xmltest: fix the test to correspond to new domain formatting

2015-03-24 Thread Pavel Hrdina
Commit 2360fe5d updated formating of domain element but forget to update qemucaps2xmldata xml files. In addition the test code was broken too. Update the xml files and return -1 if testCompareXMLToXML fails together with indentation fix. Signed-off-by: Pavel Hrdina phrd...@redhat.com ---

Re: [libvirt] [PATCH] qemu: change accidental VIR_WARNING back to VIR_DEBUG

2015-03-24 Thread John Ferlan
On 03/24/2015 10:49 AM, Laine Stump wrote: While debugging the support for responding to qemu RX_FILTER_CHANGED events, I had changed the ignoring this event log message from VIR_DEBUG to VIR_WARN, but forgot to change it back before pushing. Since many guest OSes make enough changes to

[libvirt] [PATCH 1/2] qemu: command: Report error when formatting network source with protocol _NONE

2015-03-24 Thread Peter Krempa
The function that formats the string for network drives would return error code but did not set the error message when called on storage source with VIR_STORAGE_NET_PROTOCOL_LAST or _NONE. Report an error in this case if it would ever be called in that way. --- src/qemu/qemu_command.c | 3 +++ 1

[libvirt] [PATCH 2/2] qemu: command: Check for empty network source when formatting drive cmd

2015-03-24 Thread Peter Krempa
Use the virStorageSourceIsEmpty helper to determine whether the drive source is empty rather than checking for src-path. This will fix start of VM with empty network cdrom that would not report any error. --- src/qemu/qemu_command.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-)

[libvirt] [PATCH 0/2] Fix unknown error when starting qemu VM with empty network cdrom

2015-03-24 Thread Peter Krempa
Peter Krempa (2): qemu: command: Report error when formatting network source with protocol _NONE qemu: command: Check for empty network source when formatting drive cmd src/qemu/qemu_command.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) -- 2.2.2 --

[libvirt] [PATCH 2/2] docs: route element must specify network address

2015-03-24 Thread Chen Fan
because network address is required by route, so here we should add one avoid user misunderstand. Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- docs/formatdomain.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in

[libvirt] [PATCH 1/2] docs: no 'via' attribute in route element

2015-03-24 Thread Chen Fan
via - gateway Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- docs/formatdomain.html.in | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 82aa14f..3b3d2d9 100644 --- a/docs/formatdomain.html.in +++

[libvirt] [PATCH 0/2] fix domain documentation error

2015-03-24 Thread Chen Fan
Chen Fan (2): docs: no 'via' attribute in route element docs: route element must specify network address docs/formatdomain.html.in | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- 1.9.3 -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [RFC PATCH v2 00/12] qemu: add support to hot-plug/unplug cpu device

2015-03-24 Thread Zhu Guihua
On 03/24/2015 04:30 PM, Zhi Yong Wu wrote: HI, Do you have plan to update this patchset based on the comments recently or have the latest one to post? The develop plan for cpu hotplug in qemu has been changed, it is to add socket-based device_add. So I think we could not continue this cpu

Re: [libvirt] [PATCH 4/6] qemu: check if domain is really active when do setvcpus with --live

2015-03-24 Thread Peter Krempa
On Fri, Mar 20, 2015 at 15:39:02 +0100, Pavel Hrdina wrote: From: Luyao Huang lhu...@redhat.com Commit e105dc9 fix setting vcpus for offline domain, but forget check if vm is active when pass VIR_DOMAIN_AFFECT_LIVE flags. # virsh setvcpus test3 4 --live error: Failed to create

[libvirt] [PATCHv3 6/6] Auto add virtio-serial controllers

2015-03-24 Thread Ján Tomko
In virDomainVirtioSerialAddrNext, add another controller if we've exhausted all ports of the existing controllers. https://bugzilla.redhat.com/show_bug.cgi?id=1076708 --- src/conf/domain_addr.c | 47 +++--- src/conf/domain_addr.h

[libvirt] [PATCHv3 5/6] Assign an address when hotplugging a virtio-serial device

2015-03-24 Thread Ján Tomko
--- src/qemu/qemu_hotplug.c | 21 +++-- tests/qemuhotplugtest.c | 2 +- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index ef2f9b0..560a164 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@

[libvirt] [PATCHv3 1/6] Add test for virtio serial port assignment

2015-03-24 Thread Ján Tomko
Add a test to demonstrate the effect of automatic virtio-serial address assignment. --- .../qemuxml2argv-channel-virtio-autoassign.args| 20 + .../qemuxml2argv-channel-virtio-autoassign.xml | 50 ++ tests/qemuxml2argvtest.c | 2 + 3

Re: [libvirt] [PATCH v3 1/2] cleanup conf/device_conf.h inclusion from util/virnetdev.h

2015-03-24 Thread Laine Stump
On 03/24/2015 05:57 AM, Shivaprasad G Bhat wrote: Move the struct and enum definitions from device_conf.h to virnetdev.h thus avoiding the file inclusion. The wrong reference of conf files from util/ is allowed in Makefile.am for now. The reason being, The change in Makefile.am for

Re: [libvirt] [Xen-devel] [PATCH] libxl: fix dom0 balloon logic

2015-03-24 Thread Stefano Stabellini
On Mon, 23 Mar 2015, Ian Campbell wrote: (just ccing the other tools maintainers, in particular Stefano who knows what this stuff is supposed to do...) On Fri, 2015-03-20 at 17:10 -0600, Jim Fehlig wrote: Recent testing on large memory systems revealed a bug in the Xen xl tool's freemem()

Re: [libvirt] [PATCH 7/6] qemu: move virDomainLiveConfigHelperMethod right after BeginJob

2015-03-24 Thread Pavel Hrdina
On Tue, Mar 24, 2015 at 05:13:07PM +0100, Peter Krempa wrote: On Fri, Mar 20, 2015 at 15:58:56 +0100, Pavel Hrdina wrote: We should call virDomainLiveConfigHelperMethod ASAP because this function transfers VIR_DOMAIN_AFFECT_CURRENT to VIR_DOMAIN_AFFECT_LIVE or VIR_DOMAIN_AFFECT_CONFIG. All

Re: [libvirt] [PATCH 5/6] tools: fix the wrong check when use virsh setvcpus --maximum

2015-03-24 Thread Pavel Hrdina
On Tue, Mar 24, 2015 at 05:34:31PM +0100, Peter Krempa wrote: On Fri, Mar 20, 2015 at 15:39:03 +0100, Pavel Hrdina wrote: From: Luyao Huang lhu...@redhat.com We will ignore --maximum option when only use setvcpus with this option, like this (this error is another issue): # virsh

Re: [libvirt] [PATCH 6/6] qemu: fix set vcpus on host without NUMA

2015-03-24 Thread Pavel Hrdina
On Tue, Mar 24, 2015 at 05:38:37PM +0100, Peter Krempa wrote: On Fri, Mar 20, 2015 at 15:39:04 +0100, Pavel Hrdina wrote: We don't have to modify cpuset.mems on hosts without NUMA. It also fixes an error message that you get instead of success if you trying update vcpus of a guest on a

Re: [libvirt] [PATCH] qemu: change accidental VIR_WARNING back to VIR_DEBUG

2015-03-24 Thread Laine Stump
On 03/24/2015 11:09 AM, John Ferlan wrote: On 03/24/2015 10:49 AM, Laine Stump wrote: While debugging the support for responding to qemu RX_FILTER_CHANGED events, I had changed the ignoring this event log message from VIR_DEBUG to VIR_WARN, but forgot to change it back before pushing. Since

Re: [libvirt] [PATCH 3/6] qemu: cleanup setvcpus

2015-03-24 Thread Pavel Hrdina
On Tue, Mar 24, 2015 at 05:01:09PM +0100, Peter Krempa wrote: On Fri, Mar 20, 2015 at 15:39:01 +0100, Pavel Hrdina wrote: Remove unnecessary maximum variable and also exclusive flags check as they are now tested by upper layer for all drivers. The part about the exclusive flag check is not

[libvirt] [PATCHv3 3/6] Allocate virtio-serial addresses when starting a domain

2015-03-24 Thread Ján Tomko
Instead of always using controller 0 and incrementing port number, respect the maximum port numbers of controllers and use all of them. Ports for virtio consoles are quietly reserved, but not formatted (neither in XML nor on QEMU command line). Also rejects duplicate virtio-serial addresses.

[libvirt] [PATCHv3 4/6] Expand the address set when attaching a virtio-serial controller

2015-03-24 Thread Ján Tomko
--- src/qemu/qemu_hotplug.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 9b8d11b..ef2f9b0 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -437,6 +437,7 @@ int

Re: [libvirt] [PATCH 5/6] tools: fix the wrong check when use virsh setvcpus --maximum

2015-03-24 Thread Peter Krempa
On Fri, Mar 20, 2015 at 15:39:03 +0100, Pavel Hrdina wrote: From: Luyao Huang lhu...@redhat.com We will ignore --maximum option when only use setvcpus with this option, like this (this error is another issue): # virsh setvcpus test3 --maximum 10 error: Failed to create controller cpu

Re: [libvirt] [PATCH 6/6] qemu: fix set vcpus on host without NUMA

2015-03-24 Thread Peter Krempa
On Fri, Mar 20, 2015 at 15:39:04 +0100, Pavel Hrdina wrote: We don't have to modify cpuset.mems on hosts without NUMA. It also fixes an error message that you get instead of success if you trying update vcpus of a guest on a host without NUMA. Could you add example of the error you are fixing

Re: [libvirt] [PATCH] Document behavior of compat when creating qcow2 volumes

2015-03-24 Thread Peter Krempa
On Tue, Mar 24, 2015 at 17:21:26 +0100, Ján Tomko wrote: Commit bab2eda changed the behavior for missing compat attribute, but failed to update the documentation. Before, the option was omitted from qemu-img command line and the qemu-img default was used. Now we always specify the compat

Re: [libvirt] [PATCH 2/2] qemu: add a max_core setting to qemu.conf for core dump size

2015-03-24 Thread Peter Krempa
On Tue, Mar 24, 2015 at 08:26:12 +0100, Ján Tomko wrote: On Mon, Mar 23, 2015 at 08:43:31PM -0400, John Ferlan wrote: On 03/18/2015 08:36 AM, Daniel P. Berrange wrote: Currently the QEMU processes inherit their core dump rlimit from libvirtd, which is really suboptimal. This change

Re: [libvirt] [PATCH 1/6] internal: introduce macro helpers to reject exclusive flags

2015-03-24 Thread Pavel Hrdina
On Tue, Mar 24, 2015 at 04:40:17PM +0100, Peter Krempa wrote: On Fri, Mar 20, 2015 at 15:38:59 +0100, Pavel Hrdina wrote: Inspired by commit 7e437ee7 that introduced similar macros for virsh commands so we don't have to repeat the same code all over. Signed-off-by: Pavel Hrdina

Re: [libvirt] [PATCH] Document behavior of compat when creating qcow2 volumes

2015-03-24 Thread Ján Tomko
On Tue, Mar 24, 2015 at 05:43:41PM +0100, Peter Krempa wrote: On Tue, Mar 24, 2015 at 17:21:26 +0100, Ján Tomko wrote: Commit bab2eda changed the behavior for missing compat attribute, but failed to update the documentation. Before, the option was omitted from qemu-img command line and

Re: [libvirt] [PATCH 7/6] qemu: move virDomainLiveConfigHelperMethod right after BeginJob

2015-03-24 Thread Peter Krempa
On Fri, Mar 20, 2015 at 15:58:56 +0100, Pavel Hrdina wrote: We should call virDomainLiveConfigHelperMethod ASAP because this function transfers VIR_DOMAIN_AFFECT_CURRENT to VIR_DOMAIN_AFFECT_LIVE or VIR_DOMAIN_AFFECT_CONFIG. All other additional checks for those two flags should consider that

[libvirt] [PATCH] Document behavior of compat when creating qcow2 volumes

2015-03-24 Thread Ján Tomko
Commit bab2eda changed the behavior for missing compat attribute, but failed to update the documentation. Before, the option was omitted from qemu-img command line and the qemu-img default was used. Now we always specify the compat value and the default is 0.10. Reported by Christophe Fergeau

Re: [libvirt] [PATCH 2/6] use new macro helpers to check exclusive flags

2015-03-24 Thread Peter Krempa
On Fri, Mar 20, 2015 at 15:39:00 +0100, Pavel Hrdina wrote: Signed-off-by: Pavel Hrdina phrd...@redhat.com --- src/libvirt-domain-snapshot.c | 45 ++ src/libvirt-domain.c | 288 +++-- src/qemu/qemu_driver.c | 9 +-

[libvirt] [PATCHv3 2/6] Add functions to track virtio-serial addresses

2015-03-24 Thread Ján Tomko
Create a sorted array of virtio-serial controllers. Each of the elements contains the controller index and a bitmap of available ports. Buses are not tracked, because they aren't supported by QEMU. --- src/conf/domain_addr.c | 398 +++

[libvirt] [PATCHv3 0/6] Allocate virtio-serial addresses

2015-03-24 Thread Ján Tomko
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1076708 https://bugzilla.redhat.com/show_bug.cgi?id=890606 New in v3: * preserve the behavior of honoring the controller if a partial address is specified: address type='virtio-serial' controller='2'/ * automatically add a controller if we're

Re: [libvirt] qemu_migration: Precreate missing storage breaks with network drives

2015-03-24 Thread Noel Burton-Krahn
In our case the network disk is available on the dest before we call migration. It's an openstack volume mounted via ceph. If we disable the copy-check in qemu_migration.c the migration works fine. On Mon, Mar 23, 2015 at 12:17 AM, Michal Privoznik mpriv...@redhat.com wrote: On 20.03.2015

Re: [libvirt] [PATCH 4/6] qemu: check if domain is really active when do setvcpus with --live

2015-03-24 Thread lhuang
On 03/20/2015 10:39 PM, Pavel Hrdina wrote: From: Luyao Huang lhu...@redhat.com Commit e105dc9 fix setting vcpus for offline domain, but forget check if vm is active when pass VIR_DOMAIN_AFFECT_LIVE flags. # virsh setvcpus test3 4 --live error: Failed to create controller cpu for group:

Re: [libvirt] [PATCH v3 2/2] network_conf: check if bridge exists on host for user created bridges

2015-03-24 Thread Laine Stump
On 03/24/2015 11:12 AM, Laine Stump wrote: On 03/24/2015 05:59 AM, Shivaprasad G Bhat wrote: virNetworkBridgeInUse() doesn't check if the bridge is manually created outside of libvirt. Check if the bridge actually exist on host using the virNetDevExists(). Signed-off-by: Shivaprasad G Bhat

Re: [libvirt] [Xen-devel] [PATCH] libxl: fix dom0 balloon logic

2015-03-24 Thread Jim Fehlig
Stefano Stabellini wrote: On Mon, 23 Mar 2015, Ian Campbell wrote: (just ccing the other tools maintainers, in particular Stefano who knows what this stuff is supposed to do...) On Fri, 2015-03-20 at 17:10 -0600, Jim Fehlig wrote: Recent testing on large memory systems revealed a

[libvirt] [PATCH V2] libxl: fix dom0 balloon logic

2015-03-24 Thread Jim Fehlig
Recent testing on large memory systems revealed a bug in the Xen xl tool's freemem() function. When autoballooning is enabled, freemem() is used to ensure enough memory is available to start a domain, ballooning dom0 if necessary. When ballooning large amounts of memory from dom0, freemem()

Re: [libvirt] [RFC PATCH v2 00/12] qemu: add support to hot-plug/unplug cpu device

2015-03-24 Thread Zhi Yong Wu
HI, Do you have plan to update this patchset based on the comments recently or have the latest one to post? I noticed that the patchset for memory hotplug had got merged, is there any plan to merge this patchset? On Fri, Feb 13, 2015 at 12:13 AM, Peter Krempa pkre...@redhat.com wrote: On Thu,

Re: [libvirt] [PATCH 0/8] Make debugging of cannot acquire state change lock easier

2015-03-24 Thread John Ferlan
On 03/23/2015 09:25 AM, Jiri Denemark wrote: https://bugzilla.redhat.com/show_bug.cgi?id=853839 Jiri Denemark (8): POTFILES.in: Sort Add support for tracking thread jobs Force usage of virThreadCreate virThread: Set thread job virThreadPool: Set thread worker name Set

Re: [libvirt] [PATCH 2/2] qemu: add a max_core setting to qemu.conf for core dump size

2015-03-24 Thread Ján Tomko
On Mon, Mar 23, 2015 at 08:43:31PM -0400, John Ferlan wrote: On 03/18/2015 08:36 AM, Daniel P. Berrange wrote: Currently the QEMU processes inherit their core dump rlimit from libvirtd, which is really suboptimal. This change allows their limit to be directly controller from qemu.conf

Re: [libvirt] [PATCH] Document that USB hostdevs do not need nodeDettach

2015-03-24 Thread John Ferlan
On 03/23/2015 01:16 PM, Ján Tomko wrote: The virNodeDeviceDettach API only works on PCI devices. Originally added by commit 10d3272e, but the API never supported USB devices. Reported by: Martin Polednik mpoled...@redhat.com --- docs/formatdomain.html.in | 19 +--

Re: [libvirt] [PATCH V2] libxl: fix dom0 balloon logic

2015-03-24 Thread Stefano Stabellini
On Tue, 24 Mar 2015, Jim Fehlig wrote: Recent testing on large memory systems revealed a bug in the Xen xl tool's freemem() function. When autoballooning is enabled, freemem() is used to ensure enough memory is available to start a domain, ballooning dom0 if necessary. When ballooning large