Re: [libvirt] macvtap - no incoming ipv6 traffic processed on kvm host unless i start tcpdump on interface

2015-04-09 Thread Stefan Bauer
Further investigation shows that it is working as expected on linux guests. Only my win10 guests trigger that problem. Will dig deeper... Stefan -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] configure: Check for libxl_utils.h instead of libxlutil.h

2015-04-09 Thread Michal Privoznik
The file provided by xen-devel package (or xen-tools in Gentoo) does not provide libxlutil.h. In fact the package provides libxl_utils.h instead which is the one we are looking for anyway. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- configure.ac | 2 +- 1 file changed, 1

Re: [libvirt] macvtap - no incoming ipv6 traffic processed on kvm host unless i start tcpdump on interface

2015-04-09 Thread Stefan Bauer
On Thu, 2015-04-09 at 10:47 +0200, Michal Privoznik wrote: Ah, so that's not the bug then. Have you perhaps changed the vNIC MAC inside the guest after it was started? Even though libvirt will nowadays adapt to such change, older version of libvirt haven't this implemented causing guest

[libvirt] [PATCH 0/2] Misc fixes

2015-04-09 Thread Cédric Bosdonnat
Hi all, Here are 2 small fixes: the first one just gets the apparmor right for SLES (and openSUSE). The second patch fixes a problem with lxc-enter-namespace on pretty recent kernels. They surely have nothing to do with each other ;) Cédric Bosdonnat (2): Apparmor qemu abstraction fixes for

[libvirt] [PATCH 2/2] Open /proc/PID/ns/* read-only to avoid getting permission denied

2015-04-09 Thread Cédric Bosdonnat
lxc-enter-namespace stopped working on recent kernels (at least 3.19+) due to /proc/PID/ns/* file descriptors being opened RW. From outside the namespace these can only be opened RO. --- src/util/virprocess.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [PATCHv3 0/7] Block job fixes and refactors

2015-04-09 Thread Peter Krempa
Peter Krempa (7): qemu: monitor: json: Refactor error code class checker qemu: monitor: Extract handling of JSON block job error codes qemu: blockjob: Split qemuDomainBlockJobSetSpeed from qemuDomainBlockJobImpl qemu: blockjob: Separate qemuDomainBlockJobAbort from

Re: [libvirt] [PATCH] domcaps: Check for architecture more wisely

2015-04-09 Thread Michal Privoznik
On 08.04.2015 17:25, Cole Robinson wrote: On 04/08/2015 11:12 AM, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1209948 So we have this bug. The virConnectGetDomainCapabilities() API performs a couple of checks before it produces any result. One of the checks is if the

Re: [libvirt] [PATCHv4 0/3] Support IPv6 addresses for graphics listening on networks

2015-04-09 Thread lhuang
On 04/08/2015 11:35 PM, Ján Tomko wrote: v1: https://www.redhat.com/archives/libvir-list/2015-February/msg00442.html v2: https://www.redhat.com/archives/libvir-list/2015-February/msg01228.html v3: https://www.redhat.com/archives/libvir-list/2015-March/msg00423.html changes in v4: * remove the

Re: [libvirt] macvtap - no incoming ipv6 traffic processed on kvm host unless i start tcpdump on interface

2015-04-09 Thread Stefan Bauer
On Thu, 2015-04-09 at 10:12 +0200, Michal Privoznik wrote: I mildly recalls seeing a bug like this. The problem was in intel's kernel driver. A NIC by defaul checks incoming packets whether they match NIC's MAC. So if a TAP device was created over a NIC, it had to be put into promisc mode

[libvirt] [PATCHv3 4/7] qemu: blockjob: Separate qemuDomainBlockJobAbort from qemuDomainBlockJobImpl

2015-04-09 Thread Peter Krempa
Sacrifice a few lines of code in favor of the code being more readable. --- Notes: Version 3: - no change, already ACKed src/qemu/qemu_driver.c | 213 +-- src/qemu/qemu_migration.c| 8 +- src/qemu/qemu_monitor.c | 18

[libvirt] [PATCHv3 5/7] qemu: blockPull: Refactor the rest of qemuDomainBlockJobImpl

2015-04-09 Thread Peter Krempa
Since it now handles only block pull code paths we can refactor it and remove tons of cruft. --- Notes: Version 3: - no change, ACKed and explained src/qemu/qemu_driver.c | 86 src/qemu/qemu_monitor.c | 30

Re: [libvirt] [PATCH 0/3] Fix some storage issues

2015-04-09 Thread John Ferlan
On 03/27/2015 12:07 PM, John Ferlan wrote: Patch 1 3 are bz based, while Patch 2 was determined while working on Patch 3. Details in each commit message John Ferlan (3): storage: Fix issues in storageVolResize storage: Need to update freeExtent at delete primary partition

Re: [libvirt] [PATCH 11/11] qemu: Refactor qemuDomainBlockJobAbort()

2015-04-09 Thread Michael Chapman
On Wed, 1 Apr 2015, Peter Krempa wrote: Change few variable names and refactor the code flow. As an additional bonus the function now fails if the event state is not as expected. --- src/qemu/qemu_driver.c | 108 - 1 file changed, 52 insertions(+),

Re: [libvirt] [PATCH 0/5] libxl: improve xl config parsing

2015-04-09 Thread Michal Privoznik
On 20.03.2015 18:07, Jim Fehlig wrote: This series was inspired by Marek's and Chunyan's patches to add support for kernel, initrd, and cmdline in Xen HVM domain config https://www.redhat.com/archives/libvir-list/2015-March/msg00328.html

Re: [libvirt] [PATCH 11/11] qemu: Refactor qemuDomainBlockJobAbort()

2015-04-09 Thread Peter Krempa
On Thu, Apr 09, 2015 at 20:22:43 +1000, Michael Chapman wrote: On Wed, 1 Apr 2015, Peter Krempa wrote: Change few variable names and refactor the code flow. As an additional bonus the function now fails if the event state is not as expected. --- src/qemu/qemu_driver.c | 108

[libvirt] [PATCH] qemu: Avoid shadow of 'sync' symbol

2015-04-09 Thread Peter Krempa
Old compilers whine that 'sync' is being shadowed in the function introduced in 1eccac1d2da7bbe97e1df25fd0ddac6e71b0794a. --- Pushed under the build-breaker rule. src/qemu/qemu_domain.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_domain.c

Re: [libvirt] [openstack-dev] [nova] The risk of hanging when shutdown instance.

2015-04-09 Thread Daniel P. Berrange
On Tue, Mar 31, 2015 at 11:37:04AM +0800, zhang bo wrote: On 2015/3/31 4:36, Eric Blake wrote: On 03/30/2015 06:08 AM, Michal Privoznik wrote: On 30.03.2015 11:28, zhang bo wrote: On 2015/3/28 18:06, Rui Chen wrote: snip/ The API virDomainShutdown's description is out of date,

[libvirt] [PATCH v5 1/3] Parallels: remove disk serial number check

2015-04-09 Thread Alexander Burluka
OpenStack needs disk serial number setup because nova boot --block-device-mapping command generates that param in libvirt xml. I took QEMU libvirt driver behavior as a base. QEMU driver skips inability to set serial and continues work. So Parallels driver will ignore this param too and let domain

Re: [libvirt] [PATCH v2 0/7] Cleanup flags checking and fix setvcpus

2015-04-09 Thread John Ferlan
On 03/27/2015 06:01 AM, Pavel Hrdina wrote: The first four patches only cleanup the flags checking in our APIs by introducing new macros to check exclusive flags and requirements. Patch 5/7 uses the new macros to do better flags checking for virDomainSetvcpusFlags API. Patch 6/7

[libvirt] possible bug regarding cpu flag 'pclmulqdq' in cpu_map.xml

2015-04-09 Thread Sven Kieske
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, laine on IRC was so kind to redirect me to this list, so I didn't file a BZ at: https://bugzilla.redhat.com/enter_bug.cgi?product=Virtualization%20Tools component=libvirt yet. Please keep me CC'ed as I'm not subscribed to the list. So here is

[libvirt] [PATCH 1/2] Apparmor qemu abstraction fixes for SLES

2015-04-09 Thread Cédric Bosdonnat
SLES 11 has legacy qemu-kvm package, /usr/bin/qemu-kvm and /usr/share/qemu-kvm need to be accessed by domains. --- examples/apparmor/libvirt-qemu | 9 + 1 file changed, 9 insertions(+) diff --git a/examples/apparmor/libvirt-qemu b/examples/apparmor/libvirt-qemu index 7aad391..a3043dd

Re: [libvirt] [PATCH 01/11] qemu: monitor: Extract handling of JSON block job error codes

2015-04-09 Thread Peter Krempa
On Thu, Apr 09, 2015 at 05:31:08 -0400, John Ferlan wrote: On 04/09/2015 05:26 AM, Peter Krempa wrote: Because you touched it - Coverity whines that 'error' is not checked for NULL: (8) Event returned_null: virJSONValueObjectGet returns null (checked 96 out of 99 times).

Re: [libvirt] [PATCH 0/3] Fix some storage issues

2015-04-09 Thread Michal Privoznik
On 27.03.2015 17:07, John Ferlan wrote: Patch 1 3 are bz based, while Patch 2 was determined while working on Patch 3. Details in each commit message John Ferlan (3): storage: Fix issues in storageVolResize storage: Need to update freeExtent at delete primary partition storage:

Re: [libvirt] macvtap - no incoming ipv6 traffic processed on kvm host unless i start tcpdump on interface

2015-04-09 Thread Michal Privoznik
On 09.04.2015 10:39, Stefan Bauer wrote: On Thu, 2015-04-09 at 10:12 +0200, Michal Privoznik wrote: I mildly recalls seeing a bug like this. The problem was in intel's kernel driver. A NIC by defaul checks incoming packets whether they match NIC's MAC. So if a TAP device was created over a

Re: [libvirt] [PATCH V3 1/3] libxl: Move job acquisition in libxlDomainStart to callers

2015-04-09 Thread Michal Privoznik
On 04.04.2015 00:49, Jim Fehlig wrote: Let callers of libxlDomainStart decide when it is appropriate to acquire a job on the associated virDomainObj. Signed-off-by: Jim Fehlig jfeh...@suse.com --- Job handling in the migration code is currently broken/incomplete, so fixing it is deferred

Re: [libvirt] [PATCH V3 0/3] libxl: domain destroy fixes

2015-04-09 Thread Michal Privoznik
On 04.04.2015 00:49, Jim Fehlig wrote: V3 of a small series to fix issues wrt domain destroy V1: https://www.redhat.com/archives/libvir-list/2015-March/msg01337.html V2: https://www.redhat.com/archives/libvir-list/2015-April/msg00072.html In this version, patch 3 is changed a bit to

[libvirt] [PATCHv3 7/7] qemu: Refactor qemuDomainBlockJobAbort()

2015-04-09 Thread Peter Krempa
Change few variable names and refactor the code flow. As an additional bonus the function now fails if the event state is not as expected. --- Notes: Version 3: - fixed error reporting code and success code propagation from pivot src/qemu/qemu_driver.c | 107

Re: [libvirt] macvtap - no incoming ipv6 traffic processed on kvm host unless i start tcpdump on interface

2015-04-09 Thread Michal Privoznik
On 09.04.2015 10:50, Stefan Bauer wrote: On Thu, 2015-04-09 at 10:47 +0200, Michal Privoznik wrote: Ah, so that's not the bug then. Have you perhaps changed the vNIC MAC inside the guest after it was started? Even though libvirt will nowadays adapt to such change, older version of libvirt

[libvirt] [PATCH v5 3/3] Parallels: implemented domainAttachDevice

2015-04-09 Thread Alexander Burluka
That function uses domainAttachDeviceFlags Signed-off-by: Alexander Burluka aburl...@parallels.com --- src/parallels/parallels_driver.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c index

Re: [libvirt] [PATCH 07/11] qemu: blockPivot: Don't pause the VM any more since we don't use drive-reopen

2015-04-09 Thread Peter Krempa
On Wed, Apr 08, 2015 at 11:31:18 -0400, John Ferlan wrote: On 04/01/2015 01:20 PM, Peter Krempa wrote: Support for drive-reopen was never present in the upstream code so we don't need to pause the VM when doing the block pivot. Kill all the code related to this semi-upstream artifact.

Re: [libvirt] [PATCH 01/11] qemu: monitor: Extract handling of JSON block job error codes

2015-04-09 Thread Peter Krempa
On Wed, Apr 08, 2015 at 10:25:36 -0400, John Ferlan wrote: On 04/01/2015 01:20 PM, Peter Krempa wrote: My intention is to split qemuMonitorJSONBlockJob() into simpler separate functions for every block job type. Since the error handling code is the same for all block jobs, this patch

[libvirt] [PATCH] conf: fix crash when parse a invalid vcpus in virDomainThreadSchedParse()

2015-04-09 Thread Luyao Huang
When we set a invalid vcpus in /domain/cputune/vcpusched, like this: vcpusched vcpus='0,^0' scheduler='fifo' priority='1'/ libvirtd will get segfault, because we will free bitmap (here is sp-ids) we passed in virBitmapParse() then return -1, then call virBitmapIsAllClear() with a null pointer

[libvirt] [PATCH v5 0/3] Parallels disk device attach

2015-04-09 Thread Alexander Burluka
This patchset implements disk device attachment and allows OpenStack to attach volumes to Parallels-driven instances. Parallels Cloud Server SDK supports live attachment of disk devices and virtual interfaces cards. Alexander Burluka (3): Parallels: remove disk serial number check Parallels:

[libvirt] [PATCH v5 2/3] Parallels: implement domainAttachDeviceFlags

2015-04-09 Thread Alexander Burluka
Parallels Cloud Server supports block devices and virtual NIC live attachment. I implemented that function for block devices so OpenStack volume attachment is now works. Signed-off-by: Alexander Burluka aburl...@parallels.com --- src/parallels/parallels_driver.c | 65

[libvirt] [PATCHv3 6/7] qemu: drivePivot: Fix assumption when 'block-job-complete' fails

2015-04-09 Thread Peter Krempa
QEMU does not abandon the mirror. The job carries on in the synchronised phase and it might be either pivoted again or cancelled. The commit hints that the described behavior was happening in a downstream version. If the command returns false there are two possible options: 1) qemu did not reach

Re: [libvirt] [PATCH 2/2] util: file: Don't carelessly sanitize URIs

2015-04-09 Thread Peter Krempa
On Wed, Apr 08, 2015 at 13:17:49 +0200, Ján Tomko wrote: On Wed, Apr 08, 2015 at 11:21:59AM +0200, Peter Krempa wrote: rfc3986 states that the separator in URI path is a single slash. Multiple slashes may potentially lead to different resources and thus we should not remove them. ---

Re: [libvirt] [PATCH 09/11] qemu: blockPull: Refactor the rest of qemuDomainBlockJobImpl

2015-04-09 Thread John Ferlan
On 04/09/2015 10:09 AM, Peter Krempa wrote: ... Just checking... This change is essentially the same as in qemuDomainBlockPullCommon where if (!modern) {} was added right? Yes. This one would be redundant. - -if (backingName mode != BLOCK_JOB_PULL) { -

[libvirt] [PATCHv3 1/7] qemu: monitor: json: Refactor error code class checker

2015-04-09 Thread Peter Krempa
Split out the function that checks the actual error class string into a separate helper as it will be useful later and refactor qemuMonitorJSONHasError to return bool type and remove few useless checks. Basically virJSONValueObjectHasKey are useless here since the next call to

Re: [libvirt] macvtap - no incoming ipv6 traffic processed on kvm host unless i start tcpdump on interface

2015-04-09 Thread Michal Privoznik
On 08.04.2015 14:13, Stefan Bauer wrote: Dear folks, I'm using for the first time macvtap interface for my virtual machines in bridged mode. VM - HOST - Router - INTERNET This works fine for ipv4 connectivity. For ipv6 my virtual machines receive appropriate v6 address from radvd

Re: [libvirt] macvtap - no incoming ipv6 traffic processed on kvm host unless i start tcpdump on interface

2015-04-09 Thread Stefan Bauer
v4 is using arp to broadcast address (ff:ff:ff:ff:ff:ff) - that works with macvtap without having card in promiscious mode (ip li is not showing PROMISC flag). v6 is using multicast to solicited node-address - that is NOT working without enabling manually promiscious mode. Stefan -- libvir-list

Re: [libvirt] [PATCH 3/3] qemuMigrationPrecreateDisk: Preserve sparse files

2015-04-09 Thread John Ferlan
On 04/02/2015 12:48 PM, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=817700 When pre-creating a disk on the destination, a volume XML is constructed. The XML is then passed to virStorageVolCreateXML() which does the work. But, since there's no allocation/ in the XML,

Re: [libvirt] [PATCH 0/2] Misc fixes

2015-04-09 Thread Michal Privoznik
On 09.04.2015 11:25, Cédric Bosdonnat wrote: Hi all, Here are 2 small fixes: the first one just gets the apparmor right for SLES (and openSUSE). The second patch fixes a problem with lxc-enter-namespace on pretty recent kernels. They surely have nothing to do with each other ;) Cédric

Re: [libvirt] [PATCH 01/11] qemu: monitor: Extract handling of JSON block job error codes

2015-04-09 Thread John Ferlan
On 04/09/2015 05:26 AM, Peter Krempa wrote: Because you touched it - Coverity whines that 'error' is not checked for NULL: (8) Event returned_null: virJSONValueObjectGet returns null (checked 96 out of 99 times). [details] (16) Event var_assigned: Assigning: error = null return

[libvirt] [PATCHv3 3/7] qemu: blockjob: Split qemuDomainBlockJobSetSpeed from qemuDomainBlockJobImpl

2015-04-09 Thread Peter Krempa
qemuDomainBlockJobImpl become an unmaintainable mess over the years of adding new stuff to it. This patch starts splitting up individual functions from it until it can be killed entirely. In bulk this will add lines of code rather than delete them but it will be traded for maintainability. ---

Re: [libvirt] macvtap - no incoming ipv6 traffic processed on kvm host unless i start tcpdump on interface

2015-04-09 Thread Stefan Bauer
On Thu, 2015-04-09 at 11:03 +0200, Michal Privoznik wrote: Maybe a firewall problem? Anything interesting in iptables/ebtables output? I have completely disabled v6 firewall for testing but enabling promiscious mode should not be able to bypass FW rules. Stefan -- libvir-list mailing list

Re: [libvirt] [PATCH] domcaps: Check for architecture more wisely

2015-04-09 Thread Cole Robinson
On 04/09/2015 04:00 AM, Michal Privoznik wrote: On 08.04.2015 17:25, Cole Robinson wrote: On 04/08/2015 11:12 AM, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1209948 So we have this bug. The virConnectGetDomainCapabilities() API performs a couple of checks before it

[libvirt] [PATCHv3 2/7] qemu: monitor: Extract handling of JSON block job error codes

2015-04-09 Thread Peter Krempa
My intention is to split qemuMonitorJSONBlockJob() into simpler separate functions for every block job type. Since the error handling code is the same for all block jobs, this patch extracts the code into a separate function that will later be reused in more places. With the new helper

Re: [libvirt] libnuma build failure [was: securityselinuxlabeltest test fails on v1.2.5]

2015-04-09 Thread Zhi Yong Wu
HI The issue still exists if the upstream src is built on RH 6.x. After numactl and numactl-devel is upgraded to 2.0.9, the issue gets fixed. On Tue, Jul 1, 2014 at 5:26 AM, Eric Blake ebl...@redhat.com wrote: On 06/30/2014 01:46 PM, Scott Sullivan wrote: I've tested the v1.2.6-rc2 git tag,

Re: [libvirt] [PATCH] doc: Add info (where necessary) that paths should be specified as absolute

2015-04-09 Thread Erik Skultety
On 04/07/2015 05:48 PM, Eric Blake wrote: On 04/07/2015 06:05 AM, Erik Skultety wrote: We documented this almost everywhere, but missed it on several places. https://bugzilla.redhat.com/show_bug.cgi?id=1208763 --- Hopefully I didn't miss any place where it should be fixed as well. I also

Re: [libvirt] [PATCHv2.5 00/10] Add support for memory hotplug

2015-04-09 Thread Peter Krempa
On Thu, Apr 02, 2015 at 16:35:20 +0530, Prerna Saxena wrote: Hi Peter, While playing around with memory hotplug implementation, I found that the guest XML isnt updated after a successful hotplug operation : [root@kop2 test-libvirt]# ./bin/virsh attach-device rhel71-be

Re: [libvirt] macvtap - no incoming ipv6 traffic processed on kvm host unless i start tcpdump on interface

2015-04-09 Thread Stefan Bauer
On Thu, 2015-04-09 at 10:12 +0200, Michal Privoznik wrote: I mildly recalls seeing a bug like this. The problem was in intel's kernel driver. A NIC by defaul checks incoming packets whether they match NIC's MAC. So if a TAP device was created over a NIC, it had to be put into promisc mode

Re: [libvirt] [PATCH v2] lxc: create the required directories upon driver start

2015-04-09 Thread Cedric Bosdonnat
Hi Lubomir, On Wed, 2015-04-08 at 19:16 +0200, Lubomir Rintel wrote: /var/run may reside on a tmpfs and we fail to create the PID file if /var/run/lxc does not exist. I would enhance the commit message with something like this: Since commit 0a8addc1, the lxc driver's state directory isn't

Re: [libvirt] [PATCH 09/11] qemu: blockPull: Refactor the rest of qemuDomainBlockJobImpl

2015-04-09 Thread Peter Krempa
On Wed, Apr 08, 2015 at 13:10:12 -0400, John Ferlan wrote: On 04/01/2015 01:20 PM, Peter Krempa wrote: Since it now handles only block pull code paths we can refactor it and remove tons of cruft. --- src/qemu/qemu_driver.c | 86