On 04/20/2015 10:39 PM, Michal Privoznik wrote:
On 02.04.2015 10:02, Luyao Huang wrote:
We introduce a check for numa cpu total count in 5f7b71,
But seems this check cannot work well. There are some scenarioes:
1. one of cpu id is out of maxvcpus, can set success(cpu count = 5 10):
vcpu
Hello
When compress libvirt-0.10.2-46.el6.src.rpm to support rbd, then failed;
Error log:
cc1: warnings being treated as errors
storage/storage_backend_rbd.c: In function 'virStorageBackendRBDRefreshPool':
storage/storage_backend_rbd.c:284: error: declaration of 'stat' shadows a
global
On Mon, Apr 20, 2015 at 12:50:07PM -0400, John Ferlan wrote:
...
+/* Check if the pool is using a stable target path. The call to
+ * virStorageBackendStablePath will fail if the pool target path
+ * isn't stable and just return the strdup'd 'devpath' anyway.
+ * This
On Mon, Apr 20, 2015 at 12:54:46PM -0400, John Ferlan wrote:
On 04/20/2015 12:23 PM, Eric Blake wrote:
On 04/19/2015 06:38 PM, John Ferlan wrote:
For virStorageBackendStablePath, in order to make decisions in other code
split out the checks regarding whether the pool's target is empty,
On Sun, Apr 19, 2015 at 08:38:36PM -0400, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1171933
Adjust the processLU error returns to be a bit more logical. Currently,
the calling code cannot determine the difference between a non disk/lun
volume and a processed/found
On 04/21/2015 09:45 AM, Peter Krempa wrote:
On Tue, Apr 14, 2015 at 21:18:25 -0400, John Ferlan wrote:
Add qemuDomainAddIOThread and qemuDomainDelIOThread in order to add or
remove an IOThread to/from the host either for live or config optoins
The implementation for the 'live' option will
...
This is the reason why I've requested in the previous review that the
pinning information would be merged into the iothread data structure.
You then would not have to synchronise two data structures.
Understood ... I started down that path, but then got bogged down in cputune
When running on FreeBSD, there's a bug in virCommandProcessIO
polling that is triggered by the commandtest.
A test that triggers EPIPE in commandtest (named test20) hungs
forever on FreeBSD.
Apparently, this happens because FreeBSD sets POLLHUP flag on revents
when stdin in closed. And as the
+goto cleanup;
+}
+
+iothrid-thread_id = new_iothreads[idx]-thread_id;
You are also not marking the thread structure as 'defined' and thus
wouldn't format it later ...
Changed to 'undefined' now, so this is unnecessary
(although perhaps 'autofill' is a better
On Mon, Apr 20, 2015 at 15:25:29 -0400, John Ferlan wrote:
As a hindsight from reviewing 6/7. This function should also be in
virsocketaddr.c
hmmm.. yes I see.. Guess I got hung up on virSocketAddr... and didn't
focus as closely on the implementation where virSocketAddrParse
On Mon, Apr 20, 2015 at 15:39:23 -0400, John Ferlan wrote:
On 04/20/2015 09:45 AM, Peter Krempa wrote:
On Sun, Apr 19, 2015 at 20:49:09 -0400, John Ferlan wrote:
Prior to attempting to open the gluster connection, let's make sure we
can resolve the source pool hostname.
On Mon, Apr 20, 2015 at 17:32:21 +0100, Richard W.M. Jones wrote:
Commit 70f446631f142ae92b4d4eb349fcf11408171556 (from 2008) introduced
some functions for testing whether xend was returning correct sound
models. Those functions have long gone, but the function prototypes
remain. This commit
Hey,
On Fri, Apr 17, 2015 at 09:45:13PM -0400, Cole Robinson wrote:
+VIR_ENUM_IMPL(virDomainOS, VIR_DOMAIN_OSTYPE_LAST,
+ hvm,
+ xen,
+ linux,
+ exe,
+ uml,
+ aix)
+
This is preexisting before your patch, but
On Mon, Apr 20, 2015 at 12:23:25PM -0400, John Ferlan wrote:
On 04/20/2015 11:11 AM, Ján Tomko wrote:
On Sun, Apr 19, 2015 at 08:49:12PM -0400, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1171984
Use the new virIsSameHostnameInfo API to determine whether the
On Mon, Apr 20, 2015 at 12:23:25 -0400, John Ferlan wrote:
On 04/20/2015 11:11 AM, Ján Tomko wrote:
On Sun, Apr 19, 2015 at 08:49:12PM -0400, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1171984
Use the new virIsSameHostnameInfo API to determine whether the proposed
When building without lxc support enabled, build fails with:
CLD vircapstest
vircapstest.o: In function `test_virCapsDomainDataLookupLXC':
vircapstest.c:(.text+0x9ef): undefined reference to `testLXCCapsInit'
Fix that by hiding LXC tests under appropriate #ifdef.
---
tests/vircapstest.c | 4
On Fri, Apr 17, 2015 at 03:36:20PM -0600, Jim Fehlig wrote:
Some hypervisors like Xen do not have PIDs associated with domains.
Relax the requirement for PID != 0 in the locking code so it can
be used by hypervisors that do not represent domains as a process
running on the host.
On Fri, Apr 17, 2015 at 03:36:22PM -0600, Jim Fehlig wrote:
Provide integration with libvirt's lock manager in the libxl driver.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
src/Makefile.am | 12 +
src/libxl/libvirtd_libxl.aug | 2 ++
}
+bool
+virStorageBackendPoolPathIsStable(const char *path)
+{
+if (path == NULL || STREQ(path, /dev) || STREQ(path, /dev/))
+return false;
+
+if (!STRPREFIX(path, /dev))
+return false;
I think you want /dev/ here as the prefix to be required; otherwise,
On Fri, Apr 17, 2015 at 03:36:21PM -0600, Jim Fehlig wrote:
Introduce libxl.conf configuration file, adding the 'autoballoon'
setting as the first knob for controlling the libxl driver.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
libvirt.spec.in | 8 +
On 04/21/2015 10:34 AM, Laine Stump wrote:
On 04/21/2015 09:48 AM, Michal Privoznik wrote:
On 16.04.2015 21:42, Cole Robinson wrote:
If libvirt-daemon-config-network is installed while libvirtd is already
running, the daemon needs to be restarted to pick up the change.
Instead let's trigger
On 21.04.2015 10:14, Roman Bogorodskiy wrote:
When building without lxc support enabled, build fails with:
CLD vircapstest
vircapstest.o: In function `test_virCapsDomainDataLookupLXC':
vircapstest.c:(.text+0x9ef): undefined reference to `testLXCCapsInit'
Fix that by hiding LXC tests
On Tue, Apr 14, 2015 at 21:18:21 -0400, John Ferlan wrote:
Adding a new XML element 'iothreadids' in order to allow defining
specific IOThread ID's rather than relying on the algorithm to assign
IOThread ID's starting at 1 and incrementing to iothreads count.
This will allow future patches
On 04/21/2015 10:13 AM, Michal Privoznik wrote:
On 16.04.2015 21:08, Cole Robinson wrote:
- Remove all qemu emulators
- Restart libvirtd
- Install qemu emulators
- Call 'virsh version' - errors
The only thing that will force the qemu driver to refresh it's cached
capablities info is an
On Tue, Apr 21, 2015 at 15:45:48 +0200, Peter Krempa wrote:
On Tue, Apr 14, 2015 at 21:18:25 -0400, John Ferlan wrote:
Add qemuDomainAddIOThread and qemuDomainDelIOThread in order to add or
remove an IOThread to/from the host either for live or config optoins
The implementation for the
On 04/21/2015 09:48 AM, Michal Privoznik wrote:
On 16.04.2015 21:42, Cole Robinson wrote:
If libvirt-daemon-config-network is installed while libvirtd is already
running, the daemon needs to be restarted to pick up the change.
Instead let's trigger a daemon reload when the package is first
On Tue, Apr 14, 2015 at 21:18:25 -0400, John Ferlan wrote:
Add qemuDomainAddIOThread and qemuDomainDelIOThread in order to add or
remove an IOThread to/from the host either for live or config optoins
The implementation for the 'live' option will use the iothreadpids list
in order to make
On 16.04.2015 21:42, Cole Robinson wrote:
If libvirt-daemon-config-network is installed while libvirtd is already
running, the daemon needs to be restarted to pick up the change.
Instead let's trigger a daemon reload when the package is first installed.
Then the default network is available
On 16.04.2015 21:08, Cole Robinson wrote:
- Remove all qemu emulators
- Restart libvirtd
- Install qemu emulators
- Call 'virsh version' - errors
The only thing that will force the qemu driver to refresh it's cached
capablities info is an explict API call to GetCapabilities.
However in
Check that the vmport feature is correctly used in qemu commande line.
---
.../qemuxml2argv-machine-vmport-opt.args | 6 +
.../qemuxml2argv-machine-vmport-opt.xml| 28 ++
tests/qemuxml2argvtest.c | 2 ++
3 files changed, 36
The vmport machine argument works with pc machine kind, not with xen for
example.
---
src/qemu/qemu_capabilities.c | 13 +
src/qemu/qemu_capabilities.h | 3 +++
src/qemu/qemu_command.c | 19 ---
src/qemu/qemu_domain.c | 19 +++
Fill qemu command line vmport argument as required.
---
src/qemu/qemu_command.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index f25a75f..7304d90 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@
---
src/conf/domain_conf.c | 5 -
src/conf/domain_conf.h | 1 +
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 479b4c2..1467cd3 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -140,7 +140,8 @@
Set the capability based on qmp query, or qemu version. The qmp query
includes vmport with 2.2, but no longer with 2.3. It lists only
non-machine specific capabilities, so check the qemu version too until a
machine-specific query is supported.
---
src/qemu/qemu_capabilities.c | 7 +++
Hi,
The QEMU machine vmport option allows to set the VMWare IO port
emulation. This emulation is useful for absolute pointer input when the
guest has vmware input drivers, and is enabled by default for kvm.
However it is unnecessary for Spice-enabled VM, since the agent already
handles absolute
A new feature that can be turned on or off.
The QEMU machine vmport option allows to set the VMWare IO port
emulation. This emulation is useful for absolute pointer input when the
guest has vmware input drivers, and is enabled by default for kvm.
However it is unnecessary for Spice-enabled VM,
On 21.04.2015 08:48, 饶俊明 wrote:
Hello
When compress libvirt-0.10.2-46.el6.src.rpm to support rbd, then failed;
Error log:
cc1: warnings being treated as errors
storage/storage_backend_rbd.c: In function 'virStorageBackendRBDRefreshPool':
storage/storage_backend_rbd.c:284: error:
Because packets going through the egress from a bridge (where our
bandwidth limiting takes place) have no information about which
interface they came from, the QoS rules that we create instead
use the source MAC address of the packets to make their decisions
about which QDisc the packet should be
In one of my previous patches (b68a56bcfe) I made class_id to
format more frequently. Well, now it's formatting way too
frequent - even for regular active XML. Users don't need to see
it, so lets format it only for the status XML where it's really
needed.
Signed-off-by: Michal Privoznik
Diff to v1:
- Laine's comments worked in
Michal Privoznik (2):
virDomainActualNetDefContentsFormat: Format class_id only for status
XML
processNicRxFilterChangedEvent: Take appropriate actions for
NET_TYPE_NETWORK too
src/conf/domain_conf.c | 3 ++-
src/qemu/qemu_driver.c | 12
Some storage protocols allow to have the @path field in struct
virStorageSource set to NULL. Add NULLSTR() wrappers to handle this
possibility until I finish the storage source error formatter.
---
src/util/virstoragefile.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff
On 04/21/2015 10:43 AM, Laine Stump wrote:
On 04/21/2015 10:34 AM, Laine Stump wrote:
On 04/21/2015 09:48 AM, Michal Privoznik wrote:
On 16.04.2015 21:42, Cole Robinson wrote:
If libvirt-daemon-config-network is installed while libvirtd is already
running, the daemon needs to be restarted to
When a user would specify a backing chain index that is above the start
point libvirt would report a rather unhelpful error:
invalid argument: could not find backing store 1 in chain for 'sub/link2'
This patch adds an explicit check that the index is below start point in
the backing store and
Improve error reporting when an index can't be found in the backing chain.
Peter Krempa (3):
util: storage: Fix possible crash when source path is NULL
util: storage: Add hint to error message that indexed access was used
util: storage: Improve error message when requesting image above
---
src/util/virstoragefile.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 46aff92..c9d3977 100644
--- a/src/util/virstoragefile.c
+++ b/src/util/virstoragefile.c
@@ -1390,7 +1390,8 @@
Some hypervisors like Xen do not have PIDs associated with domains.
Relax the requirement for PID != 0 in the locking code so it can
be used by hypervisors that do not represent domains as a process
running on the host.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
V2:
Change check for ownerPid
Provide integration with libvirt's lock manager in the libxl driver.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
ATM, no change from V1.
src/Makefile.am | 12 +
src/libxl/libvirtd_libxl.aug | 2 ++
src/libxl/libxl.conf | 10
Daniel P. Berrange wrote:
On Fri, Apr 17, 2015 at 03:36:22PM -0600, Jim Fehlig wrote:
Provide integration with libvirt's lock manager in the libxl driver.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
src/Makefile.am | 12 +
src/libxl/libvirtd_libxl.aug
On 04/21/2015 05:22 AM, Christophe Fergeau wrote:
Hey,
On Fri, Apr 17, 2015 at 09:45:13PM -0400, Cole Robinson wrote:
+VIR_ENUM_IMPL(virDomainOS, VIR_DOMAIN_OSTYPE_LAST,
+ hvm,
+ xen,
+ linux,
+ exe,
+ uml,
+
---
docs/schemas/capability.rng | 1 +
1 file changed, 1 insertion(+)
diff --git a/docs/schemas/capability.rng b/docs/schemas/capability.rng
index 5f3ec70..3868ee2 100644
--- a/docs/schemas/capability.rng
+++ b/docs/schemas/capability.rng
@@ -266,6 +266,7 @@
valuehvm/value !--
Daniel P. Berrange wrote:
On Fri, Apr 17, 2015 at 03:36:21PM -0600, Jim Fehlig wrote:
Introduce libxl.conf configuration file, adding the 'autoballoon'
setting as the first knob for controlling the libxl driver.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
libvirt.spec.in
On 04/21/2015 02:17 PM, Cole Robinson wrote:
---
docs/schemas/capability.rng | 1 +
1 file changed, 1 insertion(+)
diff --git a/docs/schemas/capability.rng b/docs/schemas/capability.rng
index 5f3ec70..3868ee2 100644
--- a/docs/schemas/capability.rng
+++ b/docs/schemas/capability.rng
@@
V2 of
https://www.redhat.com/archives/libvir-list/2015-April/msg00845.html
Patch 2 has been ACKed and pushed since it is independent of the
lock manager integration. Patch 1 has been changed to address
Daniel's comments. Patch 2 (was patch 3 in V1) is unchanged for
the time being.
Jim Fehlig
Hi Laine,
Thanks for your review for my patches.
and do you know that solarflare's patches have made some update version
since
https://www.redhat.com/archives/libvir-list/2012-November/msg01324.html
?
if not, I hope to go on to complete this work. ;)
Thanks,
Chen
On 04/20/2015 06:29 AM,
On 04/17/2015 02:53 AM, Chen Fan wrote:
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
qga/main.c | 13 +
1 file changed, 13 insertions(+)
I'm not sure that qga should be sending asynchronous messages (so far,
it only every replies synchronously). As it is, we already
Adding a new XML element 'iothreadids' in order to allow defining
specific IOThread ID's rather than relying on the algorithm to assign
IOThread ID's starting at 1 and incrementing to iothreads count.
This will allow future patches to be able to add new IOThreads by
a specific iothread_id and of
v3 here:
http://www.redhat.com/archives/libvir-list/2015-April/msg00621.html
Changes since v3
Patch 1:
* Add back in and use virDomainIOThreadIDDefFree
* Change _virDomainIOThreadIDDef 'undefined' to 'autofill'
* Adjust virDomainDefParseXML to only allocate what's defined
allowing
Add 'thread_id' to the virDomainIOThreadIDDef as a means to store the
'thread_id' as returned from the live qemu monitor data.
Remove the iothreadpids list from _qemuDomainObjPrivate and replace with
the new iothreadids 'thread_id' element.
Rather than use the default numbering scheme of
https://bugzilla.redhat.com/show_bug.cgi?id=1161617
Add command to allow adding and removing IOThreads from the domain including
the configuration and live domain.
$ virsh iothreadadd --help
NAME
iothreadadd - add an IOThread to the guest domain
SYNOPSIS
iothreadadd domain id
Add qemuDomainAddIOThread and qemuDomainDelIOThread in order to add or
remove an IOThread to/from the host either for live or config optoins
The implementation for the 'live' option will use the iothreadpids list
in order to make decision, while the 'config' option will use the
iothreadids list.
Add remote support for the add/delete IOThread API's
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/remote/remote_driver.c | 2 ++
src/remote/remote_protocol.x | 30 +-
src/remote_protocol-structs | 12
3 files changed, 43 insertions(+), 1
With iothreadid's allowing any 'id' value for an iothread_id, the
iothreadsched code needs a slight adjustment to allow for any
unsigned int value in order to create the bitmap of ids that will
have scheduler adjustments. Adjusted the doc description as well.
Signed-off-by: John Ferlan
Add libvirt API's to manage adding and deleting IOThreads to/from the
domain
Signed-off-by: John Ferlan jfer...@redhat.com
---
include/libvirt/libvirt-domain.h | 6 ++
src/driver-hypervisor.h | 12
src/libvirt-domain.c | 118 +++
Remove the iothreadspin array from cputune and replace with a cpumask
to be stored in the iothreadids list
Signed-off-by: John Ferlan jfer...@redhat.com
---
docs/formatdomain.html.in | 10 ++--
src/conf/domain_conf.c| 118 +-
Since it's only ever referenced in domain_conf.c, make the function
static, but also will need to move it to somewhere before it's referenced
rather than forward referencing it.
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/conf/domain_conf.c | 38 +++---
On 04/21/2015 03:13 AM, Ján Tomko wrote:
On Mon, Apr 20, 2015 at 12:50:07PM -0400, John Ferlan wrote:
...
+/* Check if the pool is using a stable target path. The call to
+ * virStorageBackendStablePath will fail if the pool target path
+ * isn't stable and just return the
On Tue, Apr 21, 2015 at 06:18:56AM -0400, John Ferlan wrote:
On 04/21/2015 03:13 AM, Ján Tomko wrote:
On Mon, Apr 20, 2015 at 12:50:07PM -0400, John Ferlan wrote:
...
+/* Check if the pool is using a stable target path. The call to
+ * virStorageBackendStablePath will fail
On 04/21/2015 08:22 AM, Michal Privoznik wrote:
In one of my previous patches (b68a56bcfe) I made class_id to
format more frequently. Well, now it's formatting way too
frequent - even for regular active XML. Users don't need to see
it, so lets format it only for the status XML where it's
On Tue, Apr 21, 2015 at 06:41:36PM +0200, Michal Privoznik wrote:
On 16.04.2015 16:46, Martin Kletzander wrote:
The first class in this file is going to be an abstract connection class
that holds a per-connection error inside. virConnect will be the first
child class inheriting from this one.
On 04/21/2015 08:22 AM, Michal Privoznik wrote:
Because packets going through the egress from a bridge (where our
bandwidth limiting takes place) have no information about which
interface they came from, the QoS rules that we create instead
use the source MAC address of the packets to make
On 04/21/2015 10:08 AM, Peter Krempa wrote:
On Tue, Apr 14, 2015 at 21:18:21 -0400, John Ferlan wrote:
Adding a new XML element 'iothreadids' in order to allow defining
specific IOThread ID's rather than relying on the algorithm to assign
IOThread ID's starting at 1 and incrementing to
On 16.04.2015 16:46, Martin Kletzander wrote:
The first class in this file is going to be an abstract connection class
that holds a per-connection error inside. virConnect will be the first
child class inheriting from this one.
This is a separate file because virerror.c is going to depend
72 matches
Mail list logo
