Re: [libvirt] [PATCH] bhyve: fix build with gcc48

2015-05-23 Thread Eric Blake
On 05/23/2015 02:45 PM, Martin Kletzander wrote: On Sat, May 23, 2015 at 08:05:23PM +0300, Roman Bogorodskiy wrote: Build with gcc 4.8 fails with: Arguably a bug in gcc; but since we can work around it without too much pain, we should. bhyve/bhyve_monitor.c: In function 'bhyveMonitorIO':

Re: [libvirt] [PATCH] zfs: fix storagepoolxml2xml test

2015-05-23 Thread Martin Kletzander
On Sat, May 23, 2015 at 10:49:09PM +0300, Roman Bogorodskiy wrote: Commit c4d27bd dropped output of owner/group -1. Update zfs tests accordingly. --- tests/storagepoolxml2xmlout/pool-zfs-sourcedev.xml | 2 -- tests/storagepoolxml2xmlout/pool-zfs.xml | 2 -- 2 files changed, 4

Re: [libvirt] [PATCH] libxl: load on FreeBSD

2015-05-23 Thread Martin Kletzander
On Sat, May 23, 2015 at 09:15:08PM +0300, Roman Bogorodskiy wrote: The libxl tries to check if it's running in dom0 by parsing /proc/xen/capabilities and if that fails it doesn't load. There's no procfs interface in Xen on FreeBSD, so this check always fails. Instead of using procfs, check if

Re: [libvirt] [PATCH 1/2] qemu: Force capabilities cache refresh if libvirtd date is different

2015-05-23 Thread Martin Kletzander
On Sat, May 23, 2015 at 10:33:30AM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1195882 Original commit id 'cbde3589' indicates that the cache file would be discarded if either the QEMU binary or libvirtd 'ctime' changes; however, the code only discarded if the QEMU

Re: [libvirt] [PATCHv2] netdev: fail when setting up an SRIOV VF if PF is offline

2015-05-23 Thread Martin Kletzander
On Fri, May 15, 2015 at 03:04:14PM -0400, Laine Stump wrote: If an SRIOV PF is offline, the kernel won't complain if you set the mac address and vlan tag for a VF via this PF, and it will even let you assign the VF to a guest using PCI device assignment or macvtap passthrough. But in this case

Re: [libvirt] [PATCH 07/13] Add libvirt-admin library

2015-05-23 Thread Martin Kletzander
On Fri, May 22, 2015 at 12:59:44PM +0100, Daniel P. Berrange wrote: On Thu, May 21, 2015 at 10:22:26PM -0700, Martin Kletzander wrote: On Thu, May 21, 2015 at 05:46:59PM +0200, Michal Privoznik wrote: On 20.05.2015 07:19, Martin Kletzander wrote: Initial scratch of the admin library. It has

Re: [libvirt] Plans for next release

2015-05-23 Thread Martin Kletzander
On Sat, May 23, 2015 at 09:22:00PM +0800, Daniel Veillard wrote: Hi everybody, if we want to get it by next month, we should probably freeze on Tuesday for an 1.2.16 on June 1st, we 'only' have 137 commits since 1.2.15 but sticking to the monthly release is important. I hope this works for

[libvirt] [PATCH] zfs: fix storagepoolxml2xml test

2015-05-23 Thread Roman Bogorodskiy
Commit c4d27bd dropped output of owner/group -1. Update zfs tests accordingly. --- tests/storagepoolxml2xmlout/pool-zfs-sourcedev.xml | 2 -- tests/storagepoolxml2xmlout/pool-zfs.xml | 2 -- 2 files changed, 4 deletions(-) diff --git

Re: [libvirt] [PATCH] bhyve: fix build with gcc48

2015-05-23 Thread Martin Kletzander
On Sat, May 23, 2015 at 08:05:23PM +0300, Roman Bogorodskiy wrote: Build with gcc 4.8 fails with: bhyve/bhyve_monitor.c: In function 'bhyveMonitorIO': bhyve/bhyve_monitor.c:51:18: error: missing initializer for field 'tv_sec' of 'const struct timespec' [-Werror=missing-field-initializers]

Re: [libvirt] [PATCH 2/2] qemu: Add libvirt version check to refresh capabilities algorithm

2015-05-23 Thread Martin Kletzander
On Sat, May 23, 2015 at 10:33:31AM -0400, John Ferlan wrote: Rather than an algorithm based solely on libvirtd ctime to refresh the capabilities add the element of the libvirt build version into the equation. Since that version wouldn't be there prior to this code being run - don't fail on

Re: [libvirt] [PATCH] Add missing XDR_FLAGS

2015-05-23 Thread Martin Kletzander
On Thu, May 21, 2015 at 07:02:22PM +0300, Pavel Fedin wrote: Fixes build problems on x86_64-cygwin host for aarch64 target: CC lxc/libvirt_driver_lxc_impl_la-lxc_monitor_protocol.lo In file included from lxc/lxc_monitor_protocol.c:7:0: lxc/lxc_monitor_protocol.h:9:21: fatal error:

Re: [libvirt] Plans for next release

2015-05-23 Thread Daniel Veillard
On Sat, May 23, 2015 at 03:42:47PM -0400, Martin Kletzander wrote: On Sat, May 23, 2015 at 09:22:00PM +0800, Daniel Veillard wrote: Hi everybody, if we want to get it by next month, we should probably freeze on Tuesday for an 1.2.16 on June 1st, we 'only' have 137 commits since 1.2.15 but

[libvirt] Plans for next release

2015-05-23 Thread Daniel Veillard
Hi everybody, if we want to get it by next month, we should probably freeze on Tuesday for an 1.2.16 on June 1st, we 'only' have 137 commits since 1.2.15 but sticking to the monthly release is important. I hope this works for everybody, thanks, Daniel -- Daniel Veillard | Open

[libvirt] Plans for next release

2015-05-23 Thread Daniel Veillard
if we want to get it by next month, we should probably freeze on Tuesday for an 1.2.16 on June 1st, we 'only' have 137 commits since 1.2.15 but sticking to the monthly release is important. I hope this works for everybody, thanks, Daniel -- Daniel Veillard | Open Source and

[libvirt] [PATCH] storage: Fix problem with disk backend pool allocation calculation

2015-05-23 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1224018 The disk pool recalculates the pool allocation, capacity, and available values each time through processing a newly created disk partition. However, there were two issues with doing so. The process generally is to read the partition table via

[libvirt] [PATCH 2/2] qemu: Add libvirt version check to refresh capabilities algorithm

2015-05-23 Thread John Ferlan
Rather than an algorithm based solely on libvirtd ctime to refresh the capabilities add the element of the libvirt build version into the equation. Since that version wouldn't be there prior to this code being run - don't fail on reading the capabilities if not found. In this case, the cache will

[libvirt] [PATCH 0/2] Adjust refresh capabilities cache algorithm

2015-05-23 Thread John Ferlan
Based on RFC posted and discussion therein: http://www.redhat.com/archives/libvir-list/2015-May/msg00655.html Threw away 1/2 from the RFC, but kept 2/2 since that seemed to be generally acceptible - even if it's still not clear the exact steps taken in order to create the problem. So 2/2 becomes

[libvirt] [PATCH 1/2] qemu: Force capabilities cache refresh if libvirtd date is different

2015-05-23 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1195882 Original commit id 'cbde3589' indicates that the cache file would be discarded if either the QEMU binary or libvirtd 'ctime' changes; however, the code only discarded if the QEMU binary time didn't match or if the new libvirtd ctime was later

[libvirt] [PATCH] bhyve: fix build with gcc48

2015-05-23 Thread Roman Bogorodskiy
Build with gcc 4.8 fails with: bhyve/bhyve_monitor.c: In function 'bhyveMonitorIO': bhyve/bhyve_monitor.c:51:18: error: missing initializer for field 'tv_sec' of 'const struct timespec' [-Werror=missing-field-initializers] const struct timespec zerowait = {}; Explicitly initialize zerowait

Re: [libvirt] Strange test build failure

2015-05-23 Thread Roman Bogorodskiy
Daniel P. Berrange wrote: On Fri, May 22, 2015 at 05:59:49PM +0200, Michal Privoznik wrote: On 22.05.2015 16:39, Dimitri John Ledkov wrote: On 22 May 2015 at 13:53, Michal Privoznik mpriv...@redhat.com wrote: On 22.05.2015 14:18, Daniel P. Berrange wrote: On Fri, May 22, 2015 at

Re: [libvirt] [PATCH 3/3] network: Resolve Coverity FORWARD_NULL

2015-05-23 Thread Laine Stump
On 05/13/2015 12:32 PM, John Ferlan wrote: To silence Coverity just add a 'p ' in front of the check in networkFindUnusedBridgeName after the strchr() call. Even though we know it's not possible to have strchr return NULL since the only way into the function is if there is a '%' in def-bridge

Re: [libvirt] [PATCH 2/3] conf: Resolve Coverity FORWARD_NULL

2015-05-23 Thread Laine Stump
On 05/13/2015 12:32 PM, John Ferlan wrote: Even though it's been pointed out they are false positives: http://www.redhat.com/archives/libvir-list/2015-May/msg00301.html and http://www.redhat.com/archives/libvir-list/2015-May/msg00302.html these still show up as Coverity issues. In order

[libvirt] [PATCH] libxl: load on FreeBSD

2015-05-23 Thread Roman Bogorodskiy
The libxl tries to check if it's running in dom0 by parsing /proc/xen/capabilities and if that fails it doesn't load. There's no procfs interface in Xen on FreeBSD, so this check always fails. Instead of using procfs, check if /dev/xen/xenstored, that's enough to check if we're running in dom0

Re: [libvirt] [PATCH 1/3] storage: Resolve Coverity FORWARD_NULL

2015-05-23 Thread Laine Stump
On 05/14/2015 08:35 AM, John Ferlan wrote: On 05/13/2015 02:43 PM, Jiri Denemark wrote: On Wed, May 13, 2015 at 12:32:20 -0400, John Ferlan wrote: Coverity points out it's possible for one of the virCommand{Output|Error}* API's to have not allocated 'output' and/or 'error' in which case the

[libvirt] [RFC PATCH] threshold: new API virDomainBlockSetWriteThreshold

2015-05-23 Thread Eric Blake
qemu 2.3 added a new QMP command block-set-write-threshold, which allows callers to get an interrupt when a file hits a write threshold, rather than the current approach of repeatedly polling for file allocation. This patch prepares the API for callers to register to receive the event, as well as