[libvirt] [PATCH] zfs: fix storagepoolxml2xml test

2015-05-25 Thread Roman Bogorodskiy
Commit 7c2d65d dropped setting default mode. Update zfs tests accordingly. --- tests/storagepoolxml2xmlout/pool-zfs-sourcedev.xml | 3 --- tests/storagepoolxml2xmlout/pool-zfs.xml | 3 --- 2 files changed, 6 deletions(-) diff --git a/tests/storagepoolxml2xmlout/pool-zfs-sourcedev.xml

Re: [libvirt] [PATCH] po: fix translation error for "caller" in zh_CN.po

2015-05-25 Thread zhang bo
On 2015/5/26 10:48, Eric Blake wrote: > On 05/25/2015 08:43 PM, Eric Blake wrote: >> On 05/25/2015 08:28 PM, zhang bo wrote: >>> IME-Version: 1.0 >>> Content-Type: text/plain; charset=UTF-8 >>> Content-Transfer-Encoding: 8bit >>> >>> caller should be translated to "璋冪敤绋嬪簭" rather than "璋冨害绋嬪簭", wh

Re: [libvirt] [PATCH] po: fix translation error for "caller" in zh_CN.po

2015-05-25 Thread Eric Blake
On 05/25/2015 08:43 PM, Eric Blake wrote: > On 05/25/2015 08:28 PM, zhang bo wrote: >> IME-Version: 1.0 >> Content-Type: text/plain; charset=UTF-8 >> Content-Transfer-Encoding: 8bit >> >> caller should be translated to "璋冪敤绋嬪簭" rather than "璋冨害绋嬪簭", which in fact >> refers to "scheduler" in English

Re: [libvirt] [PATCH] po: fix translation error for "caller" in zh_CN.po

2015-05-25 Thread Eric Blake
On 05/25/2015 08:28 PM, zhang bo wrote: > IME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > caller should be translated to "璋冪敤绋嬪簭" rather than "璋冨害绋嬪簭", which in fact > refers to "scheduler" in English. > --- > po/zh_CN.po | 8 > 1 file cha

Re: [libvirt] [PATCH] po: fix translation error for "caller" in zh_CN.po

2015-05-25 Thread zhang bo
I don't know why the codes in chinese become messy-code in this patch for me. I'm using thunderBird on *Windows*. The patch looked fine on my *Linux* machine. How does it appear at your side? If there's more work to do to make it look normal, please let me know. BTW: shall I change the headers

[libvirt] [PATCH] po: fix translation error for "caller" in zh_CN.po

2015-05-25 Thread zhang bo
IME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit caller should be translated to "璋冪敤绋嬪簭" rather than "璋冨害绋嬪簭", which in fact refers to "scheduler" in English. --- po/zh_CN.po | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/po/zh_

Re: [libvirt] [PATCH v3 2/4] storage: conf: Don't set any default in the XML

2015-05-25 Thread Cole Robinson
On 05/24/2015 07:37 AM, John Ferlan wrote: > > > On 05/21/2015 04:03 PM, Cole Robinson wrote: >> The XML parser sets a default if none is explicitly passed in. >> This is then used at pool/vol creation time, and unconditionally reported >> in the XML. >> >> The problem with this approach is that

Re: [libvirt] [PATCH v3 3/4] conf: storage: Don't emit empty block

2015-05-25 Thread Cole Robinson
On 05/24/2015 07:38 AM, John Ferlan wrote: > > > On 05/21/2015 04:03 PM, Cole Robinson wrote: >> --- >> v3: >> New patch >> >> src/conf/storage_conf.c| 42 >> +- >> tests/storagepoolxml2xmlout/pool-netfs-gluster.xml | 2 -- >> tests/storagevo

Re: [libvirt] [PATCH v3 1/4] docs: formatstorage: Update docs

2015-05-25 Thread Cole Robinson
On 05/24/2015 07:20 AM, John Ferlan wrote: > > > On 05/21/2015 04:03 PM, Cole Robinson wrote: >> - Don't redocument the permissions fields for backingstore, just point to >> the volume docs. >> - Clarify that owner/group are inherited from the parent directory at >> volume create/pool build t

Re: [libvirt] [PATCH] Allow PCI virtio on ARM "virt" machine

2015-05-25 Thread Cole Robinson
On 05/24/2015 09:38 AM, Pavel Fedin wrote: > Virt machine in qemu has PCI generic host controller, and can use PCI > devices. This > provides performance improvement as well as vhost-net with irqfd support for > virtio-net. > However libvirt still insists on virtio devices attached to Virt mach

Re: [libvirt] [PATCHv2 0/6] Selective block device migration implementation

2015-05-25 Thread Pavel Boldin
Thank you. I will go through your comments just in case I'm going to push any other changes. Sorry for the inconvenience from my patches :-/. Pavel On Mon, May 25, 2015 at 5:58 PM, Michal Privoznik wrote: > On 21.05.2015 13:07, Pavel Boldin wrote: > > The patchset represented in the mail thre

Re: [libvirt] [PATCH 0/8] parallels: add vz driver

2015-05-25 Thread Dmitry Guryanov
On 05/22/2015 09:18 PM, Maxim Nestratov wrote: This new driver 'vz' will be used as a substitution for parallels driver. New domains will be created with 'vz' domain type. Old 'parallels' domains remain supported. Connection to the driver can be made either way: vz:///system or parallels:///sys

Re: [libvirt] [PATCH 2/2] parallels: fix possible crash in case of errors in prlsdkLoadDomain

2015-05-25 Thread Dmitry Guryanov
On 05/21/2015 04:49 PM, Maxim Nestratov wrote: Cleanup code in prlsdkLoadDomain doesn't take into account the fact if private domain structure along with freeing function is assigned or not. In case it is, we shouldn't call it manually because virDomainObjListRemove calls it and frees pdom. Als

Re: [libvirt] [PATCH 1/2] parallels: move up updating parameter in prlsdkLoadDomain

2015-05-25 Thread Dmitry Guryanov
On 05/21/2015 04:49 PM, Maxim Nestratov wrote: It is better to get all necessary parameters and check them on newly created configuration before actually creating a domain with them or applying them to an existing domain. Signed-off-by: Maxim Nestratov Thanks, ACKED and pushed. --- src/

Re: [libvirt] [PATCH] qemu: Fix compilation error when enum variable size differs from 'int'

2015-05-25 Thread Michal Privoznik
On 25.05.2015 17:47, Peter Krempa wrote: > On Mon, May 25, 2015 at 17:35:19 +0200, Michal Privoznik wrote: >> On 25.05.2015 17:18, Peter Krempa wrote: >>> Since commit bcd9a564b631aa virDomainNumatuneGetMode returns the value >>> via a pointer rather than in the return value. The change triggered >

Re: [libvirt] [PATCH] qemu: Fix compilation error when enum variable size differs from 'int'

2015-05-25 Thread Martin Kletzander
On Mon, May 25, 2015 at 05:35:19PM +0200, Michal Privoznik wrote: On 25.05.2015 17:18, Peter Krempa wrote: Since commit bcd9a564b631aa virDomainNumatuneGetMode returns the value via a pointer rather than in the return value. The change triggered problems with platforms where the compiler decides

Re: [libvirt] [PATCH] qemu: Fix compilation error when enum variable size differs from 'int'

2015-05-25 Thread Peter Krempa
On Mon, May 25, 2015 at 17:35:19 +0200, Michal Privoznik wrote: > On 25.05.2015 17:18, Peter Krempa wrote: > > Since commit bcd9a564b631aa virDomainNumatuneGetMode returns the value > > via a pointer rather than in the return value. The change triggered > > problems with platforms where the compile

Re: [libvirt] [PATCH] qemu: Only issue the rtc-reset-reinjection QMP command on x86.

2015-05-25 Thread Martin Kletzander
On Mon, May 25, 2015 at 05:26:01PM +0200, Peter Krempa wrote: On Mon, May 25, 2015 at 16:59:08 +0200, Andrea Bolognani wrote: The command is only defined in QEMU for TARGET_I386, so issuing it on any other architecture can't possibly work. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1

Re: [libvirt] [PATCH] qemu: Fix compilation error when enum variable size differs from 'int'

2015-05-25 Thread Michal Privoznik
On 25.05.2015 17:18, Peter Krempa wrote: > Since commit bcd9a564b631aa virDomainNumatuneGetMode returns the value > via a pointer rather than in the return value. The change triggered > problems with platforms where the compiler decides to use a data type of > size different than integer at the poi

Re: [libvirt] [PATCH] qemu: Only issue the rtc-reset-reinjection QMP command on x86.

2015-05-25 Thread Peter Krempa
On Mon, May 25, 2015 at 16:59:08 +0200, Andrea Bolognani wrote: > The command is only defined in QEMU for TARGET_I386, so issuing it on > any other architecture can't possibly work. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1211938 > --- > src/qemu/qemu_driver.c | 20 +

[libvirt] [PATCH] qemu: Fix compilation error when enum variable size differs from 'int'

2015-05-25 Thread Peter Krempa
Since commit bcd9a564b631aa virDomainNumatuneGetMode returns the value via a pointer rather than in the return value. The change triggered problems with platforms where the compiler decides to use a data type of size different than integer at the point where we typecast it. Work around the issue b

Re: [libvirt] [PATCH] rpc: add testing of RPC JSON (de)serialization

2015-05-25 Thread Martin Kletzander
On Fri, May 22, 2015 at 01:36:14PM +0100, Daniel P. Berrange wrote: The virNetServer class has the ability to serialize its state to a JSON file, and then re-load that data after an in-place execve() call to re-connect to active file handles. This data format is critical ABI that must have compat

Re: [libvirt] [PATCH v2 1/6] util: multi-value virTypedParameter

2015-05-25 Thread Michal Privoznik
On 21.05.2015 13:07, Pavel Boldin wrote: > The `virTypedParamsValidate' function now can be instructed to allow > multiple entries for some of the keys. For this flag the type with > the `VIR_TYPED_PARAM_MULTIPLE' flag. > > Add unit tests for this new behaviour. > > Signed-off-by: Pavel Boldin >

Re: [libvirt] [PATCH v2 4/6] util: add virTypedParamsAddStringList

2015-05-25 Thread Michal Privoznik
On 21.05.2015 13:07, Pavel Boldin wrote: > The `virTypedParamsAddStringList' function provides interface to add a > NULL-terminated array of string values as a multi-value to the params. > > Signed-off-by: Pavel Boldin > --- > include/libvirt/libvirt-host.h | 6 ++ > src/libvirt_public.syms

[libvirt] [PATCH] qemu: Only issue the rtc-reset-reinjection QMP command on x86.

2015-05-25 Thread Andrea Bolognani
The command is only defined in QEMU for TARGET_I386, so issuing it on any other architecture can't possibly work. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1211938 --- src/qemu/qemu_driver.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/src/

Re: [libvirt] [PATCH v2 3/6] util: virTypedParams{Filter, PickStrings}

2015-05-25 Thread Michal Privoznik
On 21.05.2015 13:07, Pavel Boldin wrote: > Add multikey API: > > * virTypedParamsFilter that returns all the parameters with specified name. > * virTypedParamsPickStrings that returns a NULL-terminated `const char**' >list with all the values for specified name and string type. > > Signed-o

Re: [libvirt] [PATCHv2 0/6] Selective block device migration implementation

2015-05-25 Thread Michal Privoznik
On 21.05.2015 13:07, Pavel Boldin wrote: > The patchset represented in the mail thread implements the selective block > device migration for the QEMU driver. This closes the referenced bug [1]. > > First the supplementary API implemented allowing for multiple key-values pair > in the virTypedParam

Re: [libvirt] [PATCH v2 2/6] util: multi-value parameters in virTypedParamsAdd*

2015-05-25 Thread Michal Privoznik
On 21.05.2015 13:07, Pavel Boldin wrote: > Allow multi-value parameters to be build using virTypedParamsAdd* > functions by removing check for duplicates. > > Signed-off-by: Pavel Boldin > --- > src/util/virtypedparam.c | 16 > 1 file changed, 16 deletions(-) ACK Michal -- li

Re: [libvirt] [PATCH v2 5/6] qemu: migration: selective block device migration

2015-05-25 Thread Michal Privoznik
On 21.05.2015 13:07, Pavel Boldin wrote: > Implement a `migrate_disks' parameters for the QEMU driver. This multi- > value parameter can be used to explicitly specify what block devices > are to be migrated using the NBD server. Tunnelled migration using NBD > is to be done. > > Signed-off-by: Pav

Re: [libvirt] [PATCH v2 6/6] virsh: selective block device migration

2015-05-25 Thread Michal Privoznik
On 21.05.2015 13:07, Pavel Boldin wrote: > Add `virsh migrate' option `--migratedisks' that allows CLI user to > explicitly specify block devices to migrate. > > Signed-off-by: Pavel Boldin > --- > tools/virsh-domain.c | 23 +++ > tools/virsh.pod | 5 - > 2 files ch

Re: [libvirt] [PATCH 01/10] util: Introduce thread queues

2015-05-25 Thread Jiri Denemark
On Fri, May 22, 2015 at 14:28:05 +0200, Jiri Denemark wrote: > On Fri, May 22, 2015 at 13:09:17 +0100, Daniel P. Berrange wrote: > > On Fri, May 22, 2015 at 12:42:34AM +0200, Jiri Denemark wrote: > > > Our usage of pthread conditions does not allow a single thread to wait > > > for several events f

Re: [libvirt] [PATCH 4/3] conf: Resolve Coverity NEGATIVE_RETURNS

2015-05-25 Thread Laine Stump
On 05/18/2015 09:21 AM, John Ferlan wrote: > Commit id '73eda710' added virDomainKeyWrapDefParseXML which uses > virXPathNodeSet, but does not handle a -1 return thus causing a possible > loop condition exit problem later when the return value is used. > > Change the logic to return the value from

Re: [libvirt] [PATCH 5/3] qemu: Resolve Coverity RESOURCE_LEAK

2015-05-25 Thread Laine Stump
On 05/18/2015 09:21 AM, John Ferlan wrote: > Recent changes to the -M/--machine processing code in qemuParseCommandLine > caused Coverity to determine there was a possible resource leak with how > the 'list' is managed. Rather than try to add virStringFreeList calls > everywhere - just promote list

Re: [libvirt] [RFC PATCH] threshold: new API virDomainBlockSetWriteThreshold

2015-05-25 Thread Peter Krempa
On Sat, May 23, 2015 at 21:45:56 -0600, Eric Blake wrote: > qemu 2.3 added a new QMP command block-set-write-threshold, > which allows callers to get an interrupt when a file hits a > write threshold, rather than the current approach of repeatedly > polling for file allocation. This patch prepares

Re: [libvirt] [PATCH 01/10] util: Introduce thread queues

2015-05-25 Thread Jiri Denemark
On Fri, May 22, 2015 at 13:48:16 -0400, John Ferlan wrote: > > > On 05/22/2015 10:31 AM, Jiri Denemark wrote: > > On Fri, May 22, 2015 at 10:16:26 -0400, John Ferlan wrote: > >> > >> > >> On 05/21/2015 06:42 PM, Jiri Denemark wrote: > >>> Our usage of pthread conditions does not allow a single th

Re: [libvirt] [PATCH] virsh: reject negative values for scaled integer

2015-05-25 Thread Pavel Hrdina
On Fri, May 22, 2015 at 01:07:31PM -0600, Eric Blake wrote: > On 05/22/2015 08:01 AM, Pavel Hrdina wrote: > > Some virsh commands have a size parameter, which is handled as scaled > > integer. We don't have any *feature* that would allow to use '-1' as > > maximum size, so it's safe to reject any

Re: [libvirt] [PATCH v2] qemu: Deal with panic device on pSeries.

2015-05-25 Thread Andrea Bolognani
On Fri, 2015-05-15 at 11:35 +0200, Andrea Bolognani wrote: > The guest firmware provides the same functionality as the pvpanic > device, which is not available in QEMU on pSeries: make sure the > XML reflects this fact by automatically adding a element > when not already present. > > On the other