Re: [libvirt] [libvirt-glib] storage-pool: API to get/set autostart flag

2015-06-01 Thread Christophe Fergeau
On Fri, May 29, 2015 at 06:49:43PM +0100, Zeeshan Ali (Khattak) wrote: +} + +/** + * gvir_storage_pool_set_autostart: + * @pool: the storage pool + * @autostart: New value for autostart flag for the autostart flag ? Yeah, I couldn't think of better way to put it than libvirt

Re: [libvirt] [PATCH v2] libxl: load on FreeBSD

2015-06-01 Thread Roman Bogorodskiy
Roman Bogorodskiy wrote: Martin Kletzander wrote: On Thu, May 28, 2015 at 11:11:06AM +0400, Roman Bogorodskiy wrote: Jim Fehlig wrote: On 05/27/2015 09:06 AM, Martin Kletzander wrote: On Sun, May 24, 2015 at 06:45:02PM +0300, Roman Bogorodskiy wrote: The libxl tries to

[libvirt] [PATCH] network: add an option to make dns public

2015-06-01 Thread Cédric Bosdonnat
In some use cases we don't want the virtual network's DNS to only listen to the vnet interface. Adding a publiclyAccessible attribute to the dns element in the configuration allows the DNS to listen to all interfaces. It simply disables the bind-dynamic option of dnsmasq for the network. ---

[libvirt] [v2] storage-pool: API to get/set autostart flag

2015-06-01 Thread Zeeshan Ali (Khattak)
Add binding for virStoragePoolGetAutostart virStoragePoolSetAutostart. --- libvirt-gobject/libvirt-gobject-storage-pool.c | 51 ++ libvirt-gobject/libvirt-gobject-storage-pool.h | 5 +++ libvirt-gobject/libvirt-gobject.sym| 6 +++ 3 files changed, 62

Re: [libvirt] [PATCH v3 0/3] qemu: Deal with panic device on pSeries

2015-06-01 Thread Andrea Bolognani
On Mon, 2015-06-01 at 06:59 -0400, John Ferlan wrote: ACK series... I'll push soon. Thanks :) -- Andrea Bolognani Software Engineer - Virtualization Team $ python -c print('a'.join(['', 'bologn', '@redh', 't.com'])) -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 04/35] util: bitmap: Add virBitmapToDataBuf that does not allocate the buffer

2015-06-01 Thread Martin Kletzander
On Fri, May 29, 2015 at 03:33:25PM +0200, Peter Krempa wrote: Since some functions can be optimized by reusing the buffers that they already have instead of allocating and copying new ones, lets split virBitmapToData to two functions where one only converts the data and the second one is a

[libvirt] [libvirt-glib] gconfig: Don't try to return value from gvir_config_domain_set_memory

2015-06-01 Thread Christophe Fergeau
gvir_config_domain_set_memory() is a void function, so using g_return_val_if_fail() is not correct. This causes a warning/compilation failure on CentOS CI framework: https://ci.centos.org/view/libvirt-project/job/libvirt-glib-build/systems=libvirt-fedora-20/144/console --- Pushed under the build

[libvirt] virt-manager - applicability

2015-06-01 Thread poma
Applicability of the changes in configuration is broken, at least to some extent. e.g. Controller USB - USB2 to USB3 and vice versa, etc. $ rpm -q virt-manager virt-manager-1.2.0-1.fc22.noarch $ rpm -q virt-manager virt-manager-1.2.0-1.fc23.noarch However it is resolved upstream. Tested with

Re: [libvirt] [PATCH 03/35] conf: Move pinning information definition closer to the usage place

2015-06-01 Thread Martin Kletzander
On Fri, May 29, 2015 at 03:33:24PM +0200, Peter Krempa wrote: --- src/conf/domain_conf.h | 58 ++ 1 file changed, 30 insertions(+), 28 deletions(-) Makes sense, pinning-related stuff is closer together. ACK signature.asc Description: PGP

Re: [libvirt] [PATCH 06/35] qemu: Reuse virBitmapToDataBuf in qemuDomainGetEmulatorPinInfo

2015-06-01 Thread Martin Kletzander
On Fri, May 29, 2015 at 03:33:27PM +0200, Peter Krempa wrote: --- src/qemu/qemu_driver.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) ACK to this and the previous one [05/35]. signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH v2 0/2] lxc: properly clean up qemu-nbd

2015-06-01 Thread Cédric Bosdonnat
Hi all, Here is the very same patch, but split in two patches. Well, I also moved two comments around between v1 and v2. Cédric Bosdonnat (2): Add virProcessGetPids to get all tasks of a process lxc: properly clean up qemu-nbd src/libvirt_private.syms | 1 + src/lxc/lxc_controller.c | 56

[libvirt] [PATCH 1/2] fix domaincommon.rng to accept network name with quotes

2015-06-01 Thread Shivaprasad G Bhat
The network name is currently of type deviceName but it should be text as name is defined in the network.rng. Signed-off-by: Shivaprasad G Bhat sb...@linux.vnet.ibm.com --- docs/schemas/domaincommon.rng |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH] parallels: better support of volume based disks in containers

2015-06-01 Thread Maxim Nestratov
01.06.2015 12:25, Martin Kletzander пишет: On Fri, May 29, 2015 at 07:10:28PM +0300, Maxim Nestratov wrote: It is possible to attach volumes to containers but since they are added they are reported erroneously as filesystems. It is fixed in this patch. And as soon as bus type has no meaning for

[libvirt] [PATCH 0/2] Fix network names with quotes

2015-06-01 Thread Shivaprasad G Bhat
The following series implements... --- Shivaprasad G Bhat (2): fix domaincommon.rng to accept network name with quotes escape quotes for dsmasq conf contents docs/schemas/domaincommon.rng |2 +- src/util/virdnsmasq.c | 25

Re: [libvirt] [PATCH v3 0/3] qemu: Deal with panic device on pSeries

2015-06-01 Thread John Ferlan
On 05/28/2015 10:39 AM, Andrea Bolognani wrote: Currently, having the panic element in a domain XML prevents it from starting on pSeries. The error message in this case is not very accurate, and the first commit improves it. Since the guest firmware provides the same features as the

[libvirt] [PATCH python] Include tests in MANIFEST

2015-06-01 Thread Daniel P. Berrange
The unit tests were missing from the tar.gz archives due to not being listed in the MANIFEST.in file Signed-off-by: Daniel P. Berrange berra...@redhat.com --- MANIFEST.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MANIFEST.in b/MANIFEST.in index 230baea..b5ba783 100644 ---

Re: [libvirt] [PATCH 01/35] qemu: Fix possible crash in qemuProcessSetVcpuAffinities

2015-06-01 Thread Martin Kletzander
On Fri, May 29, 2015 at 03:33:22PM +0200, Peter Krempa wrote: In case when vcpu ... cpuset= is not specified, the vcpupin array is not guaranteed to be allocated to def-vcpus. This would cause a crash for TCG since it does not report thread IDs for vCPUs. --- src/qemu/qemu_process.c | 2 +- 1

[libvirt] [PATCH] Post-release version bump to 1.2.17

2015-06-01 Thread Daniel P. Berrange
--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Pushed under trivial rule. NB we might decide to switch to 1.3.0 before next release, so this is just placeholder for now. diff --git a/configure.ac b/configure.ac index 6122fa5..0da3ae8 100644 --- a/configure.ac +++

[libvirt] [libvirt-glib] gconfig: Add precondition checks to some public entry points

2015-06-01 Thread Christophe Fergeau
It's currently possible to trigger a crash by passing eg NULL to these functions. Better to return a prominent warning to the caller without crashing. --- libvirt-gconfig/libvirt-gconfig-domain.c | 28 1 file changed, 28 insertions(+) diff --git

Re: [libvirt] [PATCHv2] qemu: fix unsuitable error report when get memory stats

2015-06-01 Thread Peter Krempa
On Sat, May 30, 2015 at 10:28:05 +0800, Wang Yufei wrote: From: Zhang Bo oscar.zhan...@huawei.com when we run the command 'virsh dommemstat xxx', althrough memballoon's model is set 'none' in vm's XML, it still reports an error in libvirtd.log. error : qemuMonitorFindBalloonObjectPath:1042

[libvirt] [PATCH 2/2] escape quotes for dsmasq conf contents

2015-06-01 Thread Shivaprasad G Bhat
dnsmasq conf file contents needs to have quotes escaped for it to work. Because of this, the network-create/start for a network with quotes in the name fails. The patch escapes strings for the entries that go into the conf file. Signed-off-by: Shivaprasad G Bhat sb...@linux.vnet.ibm.com ---

Re: [libvirt] [PATCH] parallels: better support of volume based disks in containers

2015-06-01 Thread Martin Kletzander
On Fri, May 29, 2015 at 07:10:28PM +0300, Maxim Nestratov wrote: It is possible to attach volumes to containers but since they are added they are reported erroneously as filesystems. It is fixed in this patch. And as soon as bus type has no meaning for containers we always report SATA for such

Re: [libvirt] [PATCH 02/35] conf: Refactor emulatorpin handling

2015-06-01 Thread Martin Kletzander
On Fri, May 29, 2015 at 03:33:23PM +0200, Peter Krempa wrote: Store the emulator pinning cpu mask as a pure virBitmap rather than the virDomainPinDef since it stores only the bitmap and refactor qemuDomainPinEmulator to do the same operations in a much saner way. As a side effect

Re: [libvirt] [PATCH] qemu: fix unsuitable error report when get memory stats

2015-06-01 Thread Peter Krempa
On Sat, May 30, 2015 at 09:35:35 +0800, Wang Yufei wrote: On 2015/5/29 19:16, Peter Krempa wrote: On Fri, May 29, 2015 at 17:17:07 +0800, Wang Yufei wrote: From: Zhang Bo oscar.zhan...@huawei.com when we run the command 'virsh dommemstat xxx', althrough memballoon's model is set

Re: [libvirt] GITHUB readonly mirror site

2015-06-01 Thread Daniel P. Berrange
On Sun, May 31, 2015 at 07:40:37PM -0400, Chris Lalancette wrote: On Fri, May 22, 2015 at 7:48 PM, Chris Lalancette clalance...@gmail.com wrote: On Fri, May 22, 2015 at 4:13 PM, Daniel P. Berrange berra...@redhat.com wrote: And in ruby-libvirt.git remote: error: object

Re: [libvirt] [libvirt-glib] gconfig: Add precondition checks to some public entry points

2015-06-01 Thread Daniel P. Berrange
On Mon, Jun 01, 2015 at 11:34:36AM +0200, Christophe Fergeau wrote: It's currently possible to trigger a crash by passing eg NULL to these functions. Better to return a prominent warning to the caller without crashing. --- libvirt-gconfig/libvirt-gconfig-domain.c | 28

[libvirt] bulk stats for block and cpu

2015-06-01 Thread Vasiliy Tolstov
Hi. Is i remember sometimes ago someone implements bulk stats for libvirt (cpu, block, network..?) to able to get all needed info with one api call. But i can't find api in libvirt docs, does anybody helps me and send link to docs, ii want to get info about block stats for 100-200 domains. --

Re: [libvirt] [PATCH v2 1/2] storage: Don't update volume objs list before we successfully create one

2015-06-01 Thread Martin Kletzander
On Thu, May 28, 2015 at 05:29:54PM +0200, Erik Skultety wrote: We do update pool volume object list before we actually create any volume. If buildVol fails, we then try to delete the volume in the storage as well as remove it from our structures. The problem is, that any backend that supports

Re: [libvirt] virt-manager - applicability

2015-06-01 Thread Cole Robinson
On 06/01/2015 07:00 AM, poma wrote: Applicability of the changes in configuration is broken, at least to some extent. e.g. Controller USB - USB2 to USB3 and vice versa, etc. $ rpm -q virt-manager virt-manager-1.2.0-1.fc22.noarch $ rpm -q virt-manager

Re: [libvirt] virt-manager - applicability

2015-06-01 Thread poma
On 01.06.2015 15:47, Cole Robinson wrote: On 06/01/2015 07:00 AM, poma wrote: Applicability of the changes in configuration is broken, at least to some extent. e.g. Controller USB - USB2 to USB3 and vice versa, etc. $ rpm -q virt-manager virt-manager-1.2.0-1.fc22.noarch $ rpm -q

Re: [libvirt] [PATCH 2/2] lxc: move wireless PHYs to a network namespace

2015-06-01 Thread Lubomir Rintel
On Thu, 2015-04-16 at 17:23 +0200, Michal Privoznik wrote: On 14.04.2015 18:21, Lubomir Rintel wrote: The 802.11 interfaces can not be moved by themselves, their Phy has to move too. If there are other interfaces, they have to move too -- hopefully it's not too confusing. This is a

Re: [libvirt] [PATCH] spec: fixes for recently introduced libxl conf files

2015-06-01 Thread Jim Fehlig
Jim Fehlig wrote: On 05/29/2015 01:31 AM, Michal Privoznik wrote: On 01.05.2015 20:56, Jim Fehlig wrote: Commit 198cc1d3 introduced libxl-lockd and libxl-sanlock config files but forgot to add them to the spec file. Follow-up commit 62b18d98 added the files to daemon-driver-libxl, but missed

[libvirt] [PATCH] virnetdev: fix moving of 802.11 phys

2015-06-01 Thread Lubomir Rintel
There was a couple of problems with the style fixes applied to the original patch: 1.) virFileReadAllQuiet comparison was incorrectly parenthesized when moved into a condition, causing the len to be set to the result of comparison. This, together with the removed underflow check would underflow

Re: [libvirt] bulk stats for block and cpu

2015-06-01 Thread Jiri Denemark
On Mon, Jun 01, 2015 at 17:45:46 +0300, Vasiliy Tolstov wrote: Hi. Is i remember sometimes ago someone implements bulk stats for libvirt (cpu, block, network..?) to able to get all needed info with one api call. But i can't find api in libvirt docs, does anybody helps me and send link to docs,

[libvirt] [PATCH] virsh: Fix Ctrl-C behavior when watching a job

2015-06-01 Thread Jiri Denemark
When watching a job (save, managedsave, dump, migrate) virsh spawns a thread to call the appropriate API and waits for the result while watching for interruption signals (SIGINT, Ctrl-C on the terminal). Whenever such signal is caught, virsh calls virDomainAbortJob, stops waiting for the job, and

Re: [libvirt] [PATCH v3 0/9] Selective block device migration implementation

2015-06-01 Thread Kashyap Chamarthy
On Tue, May 26, 2015 at 03:01:42PM +0200, Michal Privoznik wrote: I've taken Pavel's patches, reworked them a bit, added something and sending v3. The original patches can be found here: https://www.redhat.com/archives/libvir-list/2015-May/msg00697.html Michal Privoznik (3):

[libvirt] [PATCH] test: fix IP address range failure test

2015-06-01 Thread Laine Stump
This was revealed when I made a cut-paste mistake in an upgrade to virSocketAddrGetRange(), leading to failure to check for the end address being outside of the defined network, but a negative test case that should have caught the error instead returned success. The problem was that testRange in

Re: [libvirt] [PATCH v3 0/9] Selective block device migration implementation

2015-06-01 Thread John Ferlan
On 06/01/2015 04:01 PM, Kashyap Chamarthy wrote: On Tue, May 26, 2015 at 03:01:42PM +0200, Michal Privoznik wrote: I've taken Pavel's patches, reworked them a bit, added something and sending v3. The original patches can be found here:

Re: [libvirt] [PATCH v3 0/9] Selective block device migration implementation

2015-06-01 Thread Kashyap Chamarthy
On Tue, May 26, 2015 at 03:01:42PM +0200, Michal Privoznik wrote: I've taken Pavel's patches, reworked them a bit, added something and sending v3. The original patches can be found here: https://www.redhat.com/archives/libvir-list/2015-May/msg00697.html Michal Privoznik (3):

Re: [libvirt] [PATCH] test: fix IP address range failure test

2015-06-01 Thread Eric Blake
On 06/01/2015 02:09 PM, Laine Stump wrote: This was revealed when I made a cut-paste mistake in an upgrade to virSocketAddrGetRange(), leading to failure to check for the end address being outside of the defined network, but a negative test case that should have caught the error instead

[libvirt] [PATCH v2] maint: update to latest gnulib

2015-06-01 Thread Eric Blake
Incorporates fixes for cross-compiling to mingw on rawhide, where gcc 5.1 changes detection of how to properly determine PRIdMAX. Also picks up some improvements for compilation on Mac OS X. * .gnulib: Update to latest, for at least mingw. Signed-off-by: Eric Blake ebl...@redhat.com --- I ended

Re: [libvirt] [libvirt-test-api][PATCH] fix imperfect cleanup cause the case will always fail

2015-06-01 Thread hongming
ACK and Pushed On 05/15/2015 09:59 AM, Luyao Huang wrote: Remove call undefined function. Signed-off-by: Luyao Huang lhu...@redhat.com --- repos/virconn/connection_getMemoryParameters.py | 4 1 file changed, 4 deletions(-) diff --git a/repos/virconn/connection_getMemoryParameters.py

Re: [libvirt] [libvirt-test-api][PATCH 3/3] Add a new case for getCPUStatus

2015-06-01 Thread hongming
ACK and pushed Don't forget to remove trailing whitespace next time. Thanks Hongming On 05/18/2015 09:28 AM, Luyao Huang wrote: Signed-off-by: Luyao Huang lhu...@redhat.com --- cases/linux_domain.conf| 6 +++ repos/domain/cpu_status.py | 113