when prefix present all stuff installed to /usr/usr/
Signed-off-by: Vasiliy Tolstov
---
src/Makefile.am | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index cab0456..8e6a800 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@
2015-06-22 15:04 GMT+03:00 Michal Privoznik :
> These are semantically two separate changes and should go into separate
> patches. Can you please rebase, split and resend?
Yes, thanks. I'm send two patches now.
--
Vasiliy Tolstov,
e-mail: v.tols...@selfip.ru
--
libvir-list mailing list
libvir-
add another missing libvirt command
Signed-off-by: Vasiliy Tolstov
---
configure.ac | 3 +++
src/Makefile.am | 5 +++--
src/libvirt-php.c | 28
src/libvirt-php.h | 2 ++
4 files changed, 36 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configur
https://bugzilla.redhat.com/show_bug.cgi?id=1235116
We do not format the priority if it is 0, but this will
be a broken settings in guest. Change the condition of
format priority element to always format priority if
scheduler is 'fifo' or 'rr'.
Signed-off-by: Luyao Huang
---
I haven't intorduce
On 06/23/2015 11:57 AM, Ján Tomko wrote:
> On Mon, Jun 22, 2015 at 02:44:05PM -0400, Laine Stump wrote:
>> The first 4 patches are bugfixes/reorganizations that have no controversy.
>>
>> The sets of 5-7, 8-10, and 11-13 each implement a new model of PCI
>> controller:
>>
>> 5-7 -
>> Thi
On 06/23/2015 03:07 PM, Alex Williamson wrote:
> I don't think there's anything special about slot 0 for either of those
> bridges, a quick test would verify. However, we're immediately into
> your case of changing the auto-assignment parameters. Have we always
> stored the resulting auto-assigne
On Tue, 2015-06-23 at 13:47 -0400, Laine Stump wrote:
> On 06/23/2015 11:23 AM, Alex Williamson wrote:
> > On Mon, 2015-06-22 at 14:44 -0400, Laine Stump wrote:
> >> diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c
> >> index 4b5e81e..59da745 100644
> >> --- a/src/conf/domain_addr.c
> >
Related to :
https://bugzilla.redhat.com/show_bug.cgi?id=1171933
Rather than ignore the return status from virStorageBackendSCSIFindLUs,
cause a failure to start the pool if a -1 is returned. Issue was noted
during testing of the bz for iscsi that 'scsi' and 'fc' pools don't fail.
Signed-off-by:
On 06/23/2015 11:35 AM, Alex Williamson wrote:
> On Mon, 2015-06-22 at 14:44 -0400, Laine Stump wrote:
>> This is backed by the qemu device xio3130-downstream. It can only be
>> connected to a pcie-switch-upstream-port (x3130-upstream) on the
>> upstream side.
>> ---
>> src/qemu/qemu_command.c
On Tue, Jun 23, 2015 at 15:01:06 +0200, Erik Skultety wrote:
>
>
> On 06/23/2015 02:28 PM, Peter Krempa wrote:
> > We require the scheduler name attribute in the schemas but the code
> > would actually be fine when it was omitted. Make it mandatory.
> >
> > Resolves: https://bugzilla.redhat.com/
On 06/23/2015 11:31 AM, Alex Williamson wrote:
> On Mon, 2015-06-22 at 14:44 -0400, Laine Stump wrote:
>> This is backed by the qemu device ioh3420.
>> ---
>> src/qemu/qemu_command.c | 20
>>
>> .../qemuxml2argv-pcie-root-port.args
On 06/23/2015 11:23 AM, Alex Williamson wrote:
> On Mon, 2015-06-22 at 14:44 -0400, Laine Stump wrote:
>> diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c
>> index 4b5e81e..59da745 100644
>> --- a/src/conf/domain_addr.c
>> +++ b/src/conf/domain_addr.c
>> @@ -57,6 +57,9 @@ virDomainPCIAd
---
src/qemu/qemu_monitor_json.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index 71e8f4b..11c45a1 100644
--- a/src/qemu/qemu_monitor_json.c
+++ b/src/qemu/qemu_monitor_json.c
@@ -1725,14 +1725,14
Now that qemuMonitorGetAllBlockStatsInfo collects also wr_highest_offset
the whole function can be killed.
---
src/qemu/qemu_monitor.c | 16 -
src/qemu/qemu_monitor.h | 3 -
src/qemu/qemu_monitor_json.c | 138 ---
src/qemu/qemu_monitor_json.
Change the code so that it queries the monitor when the VM is alive.
---
src/qemu/qemu_driver.c | 90 +-
1 file changed, 53 insertions(+), 37 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 004da7e..3da941e 100644
---
Instead of using qemuMonitorJSONDevGetBlockExtent (which I plan to
remove later) extract the data in place.
Additionally add a flag that will be set when the wr_highest_offset was
extracted correctly so that callers can act according to that.
The test case addition should help make sure that ever
There are other functions that can be used instead so avoid duplication.
Peter Krempa (5):
internal: Introduce virCheckNonEmptyStringArgGoto and reuse it
qemu: monitor: Fix indentation in qemuMonitorJSONGetOneBlockStatsInfo
qemu: monitor: Open-code retrieval of wr_highest_offset
qemu: Refa
The helper makes sure that strings passed to APIs are non-NULL and
non-empty. This allows to drop some inlined checks where it does not
make sense.
---
src/internal.h | 11 +++
src/libvirt-domain.c | 4 ++--
src/qemu/qemu_driver.c | 11 ---
src/util/virerror.h| 11 ++
On Mon, Jun 22, 2015 at 02:44:05PM -0400, Laine Stump wrote:
> The first 4 patches are bugfixes/reorganizations that have no controversy.
>
> The sets of 5-7, 8-10, and 11-13 each implement a new model of PCI
> controller:
>
> 5-7 -
> This is based on qemu's ioh3420.
>
> 8-10 -
>
On Mon, 2015-06-22 at 14:44 -0400, Laine Stump wrote:
> This is backed by the qemu device xio3130-downstream. It can only be
> connected to a pcie-switch-upstream-port (x3130-upstream) on the
> upstream side.
> ---
> src/qemu/qemu_command.c | 15
> +++
On 06/23/2015 04:40 AM, Martin Kletzander wrote:
> On Mon, Jun 22, 2015 at 02:44:05PM -0400, Laine Stump wrote:
>> The first 4 patches are bugfixes/reorganizations that have no
>> controversy.
>>
>> The sets of 5-7, 8-10, and 11-13 each implement a new model of PCI
>> controller:
>>
>> 5-7 -
>>
On Mon, 2015-06-22 at 14:44 -0400, Laine Stump wrote:
> This is backed by the qemu device ioh3420.
> ---
> src/qemu/qemu_command.c | 20
>
> .../qemuxml2argv-pcie-root-port.args | 10 ++
> tests/qemuxml2argvtest.c
On Mon, 2015-06-22 at 14:44 -0400, Laine Stump wrote:
> This controller can be connected to any PCIe port, but not to a
> standard PCI port, which is the reason for the new connect type
> VIR_PCI_CONNECT_TYPE_PCIE_ONLY. pcie-switch provides 31 ports (slot=1
> to slot=31), which can only have pci co
Instead of creating symlinks, bind mount the devices to
/dev/pts/XY.
Using bind mounts it is no longer needed to add pts devices
to files like /dev/securetty.
Signed-off-by: Richard Weinberger
---
src/lxc/lxc_container.c | 38 +-
1 file changed, 21 insertions(
On Mon, Jun 22, 2015 at 17:06:46 -0600, Eric Blake wrote:
> Time to wire up the new API to call into the QMP command for setting
> a write threshold.
>
> For now, the API only allows setting the threshold on the active
> layer. But I left TODOs in the series for places that need
> touching to fin
On Mon, Jun 22, 2015 at 17:06:45 -0600, Eric Blake wrote:
> With this patch, block write threshold events delivered by qemu
> are converted into libvirt events.
>
> This patch takes the easy road, and only reports events if
> the node name is still cached by libvirtd (true in the common
> case whe
On Mon, Jun 22, 2015 at 17:06:43 -0600, Eric Blake wrote:
> Set up functions to make it easy to map between libvirt disk
> names and qemu node names. Although we won't expose the
> information in XML, it is still nicer to cache the information
> than to have to grab a job lock, so that we are less
On Mon, Jun 22, 2015 at 17:06:44 -0600, Eric Blake wrote:
> Expose threshold information by collecting the information from
> QMP commands. qemu 2.3 has a way to get threshold information
> on all elements of a block chain, but only when node names are
> used - what's worse, the threshold informat
On 06/08/2015 08:25 AM, John Ferlan wrote:
> Validation of https://bugzilla.redhat.com/show_bug.cgi?id=1181062 raised
> a couple of questions about XML format and the defaults - these patches
> address those questions.
>
> John Ferlan (2):
> docs: Adjust Disk storage rng
> storage: Force set
On Wed, Jun 17, 2015 at 04:48:31PM +0200, Boris Fiuczynski wrote:
> This patche set provides support for the new watchdog model "diag288"
> including the new watchdog action "inject-nmi".
>
> Boris Fiuczynski (2):
> Support for the new watchdog action inject-nmi
> Support for the new watchdog
Just refactor existing code to use a child buf instead of
check all element before format and .
This will avoid the more and more bigger element check during
we introduce new elements in and in the
future.
Signed-off-by: Luyao Huang
---
src/conf/domain_conf.c | 168 +++
On Mon, Jun 08, 2015 at 08:25:22AM -0400, John Ferlan wrote:
> Commit id '832a9256' adjusted the code to recognize when the default
> type of "unknown" was provided as the format type and to use "dos" if
> found. Since the pool is built with "dos" and it could cause some
> confusion when formatting
Userspace does not expect that the initial console
is a controlling TTY. systemd can deal with that, others not.
On sysv init distros getty will fail to spawn a controlling on
/dev/console or /dev/tty1. Which will cause to whole container
to reboot upon ctrl-c.
This patch changes the behavior of l
Am 23.06.2015 um 14:18 schrieb Richard Weinberger:
> Am 22.06.2015 um 16:51 schrieb Daniel P. Berrange:
>> On Mon, Jun 22, 2015 at 04:40:37PM +0200, Richard Weinberger wrote:
>>> Hi!
>>>
>>> Why is libvirt-lxc issuing a setsid() in lxcContainerSetupFDs()?
>>> To me it seems like a hack to have a co
On Mon, Jun 22, 2015 at 17:06:42 -0600, Eric Blake wrote:
> Implement the QMP side of asking qemu what node name it assigned
> to an arbitrary top-level device node. Assumes that the caller
> will have already validated that the device is qcow2 backed by
> a block device, and that qemu auto-assign
On 06/16/2015 05:38 AM, Kothapally Madhu Pavan wrote:
> Currently we are parsing all the possible cpus to get the
> nodeinfo. This fix will perform a check for present cpus
> before parsing.
>
> Signed-off-by: Kothapally Madhu Pavan
> ---
> src/nodeinfo.c | 13 +
> 1 file changed
On Mon, Jun 08, 2015 at 08:25:21AM -0400, John Ferlan wrote:
> Currently the grammar uses "none" for a "valid" Disk Storage Pool
> format type; however, virStoragePoolFormatDisk uses "unknown" so
> virt-xml-validate will fail to validate when "unknown" is found
>
> Signed-off-by: John Ferlan
> --
On 06/23/2015 02:28 PM, Peter Krempa wrote:
> We require the scheduler name attribute in the schemas but the code
> would actually be fine when it was omitted. Make it mandatory.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1234729
> ---
> src/conf/domain_conf.c | 49 ++
On Mon, Jun 22, 2015 at 05:09:18PM +0530, Prerna Saxena wrote:
> From: Prerna Saxena
> Date: Mon, 22 Jun 2015 02:54:32 -0500
>
> When virsh vol-clone is attempted on a raw file where capacity > allocation,
> the resulting cloned volume has a size that matches the virtual-size of
> the parent; in
On Mon, Jun 22, 2015 at 05:07:26PM +0530, Prerna Saxena wrote:
> From: Prerna Saxena
> Date: Thu, 18 Jun 2015 05:05:09 -0500
>
> Libvirt periodically refreshes all volumes in a storage pool, including
> the volumes being cloned.
> While cloning a storage volume from parent, we drop pool locks. Su
On Tue, Jun 23, 2015 at 01:56:00PM +0200, Michal Privoznik wrote:
The acl.html file includes aclperms.htmlinc which is generated.
However, acl.html is generated too from acl.html.tmp. And in fact,
this is the place where the aclperms file is needed. Fix the
dependency in Makefile.
Signed-off-by:
We require the scheduler name attribute in the schemas but the code
would actually be fine when it was omitted. Make it mandatory.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1234729
---
src/conf/domain_conf.c | 49 ++---
1 file changed, 26 in
On Tue, Jun 23, 2015 at 02:20:54PM +0200, Richard Weinberger wrote:
> Am 22.06.2015 um 16:51 schrieb Daniel P. Berrange:
> > Also note systemd uses the device via /dev/console, not /dev/tty1
> > and with 'container_ttys' we've told it not to use /dev/tty1 for
> > gettys. So maybe it deals with /de
Am 22.06.2015 um 16:51 schrieb Daniel P. Berrange:
> On Mon, Jun 22, 2015 at 04:40:37PM +0200, Richard Weinberger wrote:
>> Hi!
>>
>> Why is libvirt-lxc issuing a setsid() in lxcContainerSetupFDs()?
>> To me it seems like a hack to have a controlling TTY if PID 1 is /bin/bash.
>
> I honestly can't
Am 22.06.2015 um 16:51 schrieb Daniel P. Berrange:
> Also note systemd uses the device via /dev/console, not /dev/tty1
> and with 'container_ttys' we've told it not to use /dev/tty1 for
> gettys. So maybe it deals with /dev/console in a different way
> than it would if it were /dev/tty1
BTW: Why
Hello.
Problem description:
When i start qemu via libvirt with vnc websocket defined, it is not
possible to live migrate to host where other qemu process is running
with the same display id.
migration error is:
error: internal error: early end of file from monitor: possible problem:
https://bugzilla.redhat.com/show_bug.cgi?id=1181539
Signed-off-by: Anton Khramov
---
src/network/bridge_driver.c | 5 +
src/util/virhook.c | 3 ++-
src/util/virhook.h | 1 +
3 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/network/bridge_driver.c b/src/netw
Hi,
On my own build linux system without systemd, I have following problem,
when I try to start a qemu VM, libvirtd.log says:
2015-06-23 08:29:25.498+: 889: error : virNetDevGetIndex:842 : Unable
to get index for interface vm0.0: No such device
2015-06-23 08:29:25.551+: 886: error :
I've added hook for network modification event
Anton Khramov (1):
Added hook for network modification event
src/network/bridge_driver.c | 5 +
src/util/virhook.c | 3 ++-
src/util/virhook.h | 1 +
3 files changed, 8 insertions(+), 1 deletion(-)
--
1.9.1
--
libvir-list
The acl.html file includes aclperms.htmlinc which is generated.
However, acl.html is generated too from acl.html.tmp. And in fact,
this is the place where the aclperms file is needed. Fix the
dependency in Makefile.
Signed-off-by: Michal Privoznik
---
diff to v1:
- Fix the origin of the error
The LXC driver uses virSetUIDGID() to become UID/GID 0.
It passes an empty groups list to virSetUIDGID()
to get rid of all supplementary groups from the host side.
But virSetUIDGID() calls setgroups() only if the supplied list
is larger than 0.
This leads to a container root with unrelated suppleme
On Mon, Jun 22, 2015 at 15:01:15 -0600, Eric Blake wrote:
> Since older yajl ignores trailing garbage, a client can cause
> problems by intentionally ending the wrapper array early. Since
> we already track nesting, it's not too much harder to reject
> invalid nesting pops.
>
> * src/util/virjson.
There are two macros used in the test: CAPSCOMP and CAPS_EXPECT_ERR.
Both run a test case and if a failure occurred, they set the @ret
variable to a value of -1 to indicate an error. Well, that's what they
should do. Due to a typo, they set the variable to a positive one
effectively masking any fai
On 23.06.2015 13:30, Martin Kletzander wrote:
> By trying to lead the way of clean includes, I sorted the lines
> alphabetically and that is a problem for mingw builds with gnulib.
> As 'configmake.h' defines DATADIR and 'datatypes.h' transitively
> includes 'winsock.h' that uses 'DATADIR' as a nam
On 06/15/2015 03:00 PM, John Ferlan wrote:
> Commit id '1feaccf0' attempted to handle an empty secrettype value; however,
> it made a mistake by processing the secretType as if it was the original
> secrettype string. The 'secretType' is actually whether 'usage' or 'uuid'
> was used.
>
> Thus a
On 06/08/2015 08:25 AM, John Ferlan wrote:
> Validation of https://bugzilla.redhat.com/show_bug.cgi?id=1181062 raised
> a couple of questions about XML format and the defaults - these patches
> address those questions.
>
> John Ferlan (2):
> docs: Adjust Disk storage rng
> storage: Force set
By trying to lead the way of clean includes, I sorted the lines
alphabetically and that is a problem for mingw builds with gnulib.
As 'configmake.h' defines DATADIR and 'datatypes.h' transitively
includes 'winsock.h' that uses 'DATADIR' as a name for a struct,
it's enough to reorder those.
Even th
On 22.06.2015 22:18, Eric Blake wrote:
> Fixes 'make check' on RHEL 6, which I recently broke, then adds
> further improvements to the JSON parser.
>
> I'm tempted to push patch 1/3 as a build-breaker, but since the
> other two need review, I'll hold off and we can do all three as
> a series.
>
>
Some guests lock the tray and QEMU eject command will simply fail to
eject the media. But the guest OS can handle this attempt to eject the
media and can unlock the tray and open it. In this case, we should try
again to actually eject the media.
If the first attempt fails we will wait for tray to
This patch allows to build libvirt natively under MinGW/MSYS using portablexdr
library.
An updated version of portablexdr with fixed bugs is available as part of MSYS2
project.
Signed-off-by: Pavel Fedin
---
configure.ac | 2 +-
src/lxc/lxc_monitor_protocol.x | 2 +-
src/rpc/
On 23.06.2015 11:28, Daniel P. Berrange wrote:
> On Fri, Jun 19, 2015 at 02:27:27PM +0200, Daniel Hansel wrote:
>> currently Michael Mueller (IBM) is working on an extension
>> of QEMU to support CPU models for s390x platform.
>> During the discussion on the QEMU mailing list the implementation
>
On Fri, Jun 19, 2015 at 02:27:27PM +0200, Daniel Hansel wrote:
> currently Michael Mueller (IBM) is working on an extension
> of QEMU to support CPU models for s390x platform.
> During the discussion on the QEMU mailing list the implementation
> was done in a more common way to provide support for
If the configuration of the instance has been modified, for example added disk
or network device, then hypervisor
sends event with prlIssuerType = PIE_DISPATCHER and EventType =
PET_DSP_EVT_VM_CONFIG_CHANGED
We should handle this event in prlsdkHandleVmEvent function to update
instance's XML con
Changes from v1
Rebase patch
Mikhail Feoktistov (1):
vz: Fix error messages in libvirt log caused by unhadled events
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 19.06.2015 14:27, Daniel Hansel wrote:
>
>
> On 18.06.2015 15:41, Daniel P. Berrange wrote:
>> On Wed, Jun 17, 2015 at 05:37:42PM +0200, Jiri Denemark wrote:
>>> Hi all (and sorry for the long email),
>>>
>>> The current way QEMU driver handles guest CPU configuration is not
>>> ideal. We de
On Mon, Jun 22, 2015 at 02:44:05PM -0400, Laine Stump wrote:
The first 4 patches are bugfixes/reorganizations that have no controversy.
The sets of 5-7, 8-10, and 11-13 each implement a new model of PCI
controller:
5-7 -
This is based on qemu's ioh3420.
8-10 -
Based on qemu's
On Mon, Jun 22, 2015 at 05:19:52PM +0200, Michal Privoznik wrote:
The acl.html file includes aclperms.htmlinc which is generated.
However, there's a typo in the Makefile which makes make fail to see
the dependencies correctly.
Signed-off-by: Michal Privoznik
---
docs/Makefile.am | 2 +-
1 file c
Hello!
> We can't apply this without unit test additions. We will at least need a test
> for qemu 2.3+ defaulting to PCI, and a test to ensure that manually specified
> virtio-mmio continues to do the correct thing. I'll take a stab at it this
> week
Thank you very much for your assistance. To
68 matches
Mail list logo
