[libvirt] [PATCH] Fix nodeinfo output on PPC64 KVM hosts

2015-06-25 Thread Shivaprasad G Bhat
The nodeinfo is reporting incorrect number of cpus and incorrect host topology on PPC64 KVM hosts. The KVM hypervisor on PPC64 needs only the primary thread in a core to be online, and the secondaries offlined. While scheduling a guest in, the kvm scheduler wakes up the secondaries to run in guest

Re: [libvirt] [PATCH] virt-xml-validate: Allow input to be read from stdin

2015-06-25 Thread Martin Kletzander
On Wed, Jun 24, 2015 at 06:17:35PM +0200, Johannes Holmberg wrote: - On 24 Jun, 2015, at 09:14, Martin Kletzander mklet...@redhat.com wrote: Why don't you just set XMLFILE=$TMPFILE ? That would get rid of lot of the code changes below and would be more readable. Other than that it looks

Re: [libvirt] [PATCH] Added hook for network modification event

2015-06-25 Thread Martin Kletzander
On Tue, Jun 23, 2015 at 09:01:58AM +0200, Anton Khramov wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1181539 Signed-off-by: Anton Khramov webmas...@ulzone.ru --- src/network/bridge_driver.c | 5 + src/util/virhook.c | 3 ++- src/util/virhook.h | 1 + 3 files changed, 8

Re: [libvirt] Plans for next release

2015-06-25 Thread Martin Kletzander
[adding Dan to Cc as he asked me about this right before I had to leave for an appointment] On Thu, Jun 25, 2015 at 10:08:10PM +0800, Daniel Veillard wrote: Sorry I nearly forgot, but we should enter freeze soon to try to hit the end of the month target. I see that Martin's APIs for admin

Re: [libvirt] [PATCH 00/13] PCIe fixes + new PCI controllers w/RFC

2015-06-25 Thread Martin Kletzander
On Thu, Jun 25, 2015 at 11:46:41AM +0200, Ján Tomko wrote: On Thu, Jun 25, 2015 at 08:44:17AM +0200, Martin Kletzander wrote: On Wed, Jun 24, 2015 at 12:04:33PM -0400, Laine Stump wrote: At this point you can see that it all comes down to what name we want to give the subelement; within that,

[libvirt] [PATCH v2 0/3] driver level connection close event

2015-06-25 Thread nshirokovskiy
Notify of connection close event from parallels driver (possibly) wrapped in the remote driver. Changes from v1: 1. fix comment style issues 2. remove spurious whitespaces 3. move rpc related part from vz patch to second(rpc) patch 4. remove unnecessary locks for immutable closeCallback in first

[libvirt] [PATCH v2 2/3] daemon: relay connection close event related functions

2015-06-25 Thread nshirokovskiy
From: Nikolay Shirokovskiy nshirokovs...@virtuozzo.com Add conneciton close subscription/unsubscription and event rpc. Now remote driver firing connection close event in 2 cases. 1. connection to daemon closed, as previously 2. as a relay of connection close event from wrapped driver As it

[libvirt] [PATCH v2 3/3] vz: implement connection close notification

2015-06-25 Thread nshirokovskiy
From: Nikolay Shirokovskiy nshirokovs...@virtuozzo.com Reuse virConnectCloseCallback to implement connection close event functions. This way we automatically meet multi-thread requirements on unregistering/notification. --- src/vz/vz_driver.c | 26 ++ src/vz/vz_sdk.c

[libvirt] [PATCH v2 1/3] remote: move connection close callback to driver level

2015-06-25 Thread nshirokovskiy
From: Nikolay Shirokovskiy nshirokovs...@virtuozzo.com 1. Introduce connect(Un)RegisterCloseCallback driver functions. 2. virConnect(Un)RegisterCloseCallback now works through driver. 3. virConnectCloseCallback is factored from virConnect but mostly stay the same. Notice however that virConnect

Re: [libvirt] [sandbox PATCH 03/10] Add disk parameter to virt-sandbox

2015-06-25 Thread Daniel P. Berrange
On Thu, Jun 25, 2015 at 03:49:04PM +0200, Cedric Bosdonnat wrote: On Thu, 2015-06-25 at 14:09 +0100, Daniel P. Berrange wrote: On Thu, Jun 25, 2015 at 01:27:23PM +0200, Eren Yagdiran wrote: Allow users to add disk images to their sandbox. Only disk images are supported so far, but the

Re: [libvirt] [PATCH 0/5] vz: Reformat

2015-06-25 Thread Maxim Nestratov
25.06.2015 12:19, Maxim Nestratov пишет: 25.06.2015 11:18, Michal Privoznik пишет: There shouldn't be any functional change. Only some formatting nits fixed. Michal Privoznik (5): vz_driver: Reformat vz_network: Reformat vz_sdk: Reformat vz_storage: Reformat vz_utils: Reformat

Re: [libvirt] [sandbox PATCH 03/10] Add disk parameter to virt-sandbox

2015-06-25 Thread Daniel P. Berrange
On Thu, Jun 25, 2015 at 01:27:23PM +0200, Eren Yagdiran wrote: Allow users to add disk images to their sandbox. Only disk images are supported so far, but the parameter is intentionally designed for future changes. --- bin/virt-sandbox.c | 37 + 1 file

Re: [libvirt] [PATCH] storage: add RBD support to disk source pool translation

2015-06-25 Thread Thibault VINCENT
On 09/06/2015 17:33, John Ferlan wrote: I still think I need a tweak on what I posted as an update - the libvirtd restart path is always a bit tricky. The 'pooltype' isn't filled in at XML processing time and virStorageTranslateDiskSourcePool is only called after XML processing (sigh), so

[libvirt] Gathering CPUID data for x86 CPUs

2015-06-25 Thread Jiri Denemark
Hi all, I'm working on improving our host CPU detection logic and I'd like to gather test data for various CPUs and include them in the libvirt's CPU unit test to make sure I don't introduce regressions. If you are willing to help me, please, send me the output of the following command:

[libvirt] [sandbox PATCH 08/10] Init-util : Common directory functions for init-common and init-qemu

2015-06-25 Thread Eren Yagdiran
Init-util provides common functions for creating directories for both Init-common and Init-qemu. Error handling needs to be done in calling function. --- libvirt-sandbox/Makefile.am | 4 +- libvirt-sandbox/libvirt-sandbox-init-qemu.c | 57 +---

[libvirt] [sandbox PATCH 03/10] Add disk parameter to virt-sandbox

2015-06-25 Thread Eren Yagdiran
Allow users to add disk images to their sandbox. Only disk images are supported so far, but the parameter is intentionally designed for future changes. --- bin/virt-sandbox.c | 37 + 1 file changed, 37 insertions(+) diff --git a/bin/virt-sandbox.c

[libvirt] [sandbox PATCH 00/10] Patches for Libvirt-sandbox

2015-06-25 Thread Eren Yagdiran
Hello, These patches provide disk support for libvirt-sandbox. Implemented '--disk' parameter will be useful when integrating Docker image support for libvirt-sandbox. --Main diffs compared to previous patches. Since many hypervisors, including kvm, will not even honour requested names for

[libvirt] [sandbox PATCH 10/10] Common-builder: /dev/disk/by-tag/thetag to /dev/vdN

2015-06-25 Thread Eren Yagdiran
Common builder counts the disks devices and populates disks.cfg according to that.Disk devices are always come first than host-based images.In builder-machine, mounts of the host-based images will be mounted later. --- libvirt-sandbox/libvirt-sandbox-builder-machine.c | 6 +-

[libvirt] [sandbox PATCH 05/10] Add disk support to machine builder

2015-06-25 Thread Eren Yagdiran
Use the new disk configuration in the container builder to provide disks in qemu sandboxes. The disks are virtio devices, but those shouldn't be known by the user. --- libvirt-sandbox/libvirt-sandbox-builder-machine.c | 38 --- 1 file changed, 34 insertions(+), 4 deletions(-)

[libvirt] [sandbox PATCH 04/10] Add disk support to the container builder

2015-06-25 Thread Eren Yagdiran
Use the new disk configuration in the container builder to provide disks in lxc containers sandboxes. --- .../libvirt-sandbox-builder-container.c| 37 +- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git

[libvirt] [sandbox PATCH 07/10] qemu: use devtmpfs rather than tmpfs to auto-populate /dev

2015-06-25 Thread Eren Yagdiran
From: Cédric Bosdonnat cbosdon...@suse.com When using devtmpfs we don't need to care about the device nodes creation: it's less risk to forget some. It also eases the creation of the devices in the init-qemu. --- libvirt-sandbox/libvirt-sandbox-init-qemu.c | 94 + 1

[libvirt] [sandbox PATCH 06/10] Add gvir_sandbox_config_has_disks function

2015-06-25 Thread Eren Yagdiran
From: Cédric Bosdonnat cbosdon...@suse.com Add helper function to check if a config contains disk devices. --- libvirt-sandbox/libvirt-sandbox-config.c | 7 +++ libvirt-sandbox/libvirt-sandbox-config.h | 1 + libvirt-sandbox/libvirt-sandbox.sym | 1 + 3 files changed, 9 insertions(+)

[libvirt] [sandbox PATCH 00/10] Patches for Libvirt-sandbox

2015-06-25 Thread Eren Yagdiran
Hello, These patches provide disk support for libvirt-sandbox. Implemented '--disk' parameter will be useful when integrating Docker image support for libvirt-sandbox. --Main diffs compared to previous patches. Since many hypervisors, including kvm, will not even honour requested names for

[libvirt] [sandbox PATCH 09/10] Common-init: Building symlink from disks.cfg

2015-06-25 Thread Eren Yagdiran
Similar to the existing mounts.cfg, the mapping between the device and the tag is passed by a new disks.cfg file. Common-init reads disks.cfg and maps the tags to corresponding devices --- libvirt-sandbox/libvirt-sandbox-init-common.c | 51 +-- 1 file changed, 49

[libvirt] [sandbox PATCH 01/10] Add an utility function for guessing filetype from file extension

2015-06-25 Thread Eren Yagdiran
Consider the file name extension as the image type, except for .img that are usually RAW images --- libvirt-sandbox/Makefile.am| 1 + libvirt-sandbox/libvirt-sandbox-util.c | 72 ++ libvirt-sandbox/libvirt-sandbox-util.h | 5 +++ po/POTFILES.in

Re: [libvirt] [PATCH 0/5] vz: Reformat

2015-06-25 Thread Maxim Nestratov
25.06.2015 16:21, Michal Privoznik пишет: On 25.06.2015 11:46, Maxim Nestratov wrote: 25.06.2015 12:19, Maxim Nestratov пишет: 25.06.2015 11:18, Michal Privoznik пишет: There shouldn't be any functional change. Only some formatting nits fixed. Michal Privoznik (5): vz_driver: Reformat

Re: [libvirt] [PATCH 0/5] vz: Reformat

2015-06-25 Thread Michal Privoznik
On 25.06.2015 11:46, Maxim Nestratov wrote: 25.06.2015 12:19, Maxim Nestratov пишет: 25.06.2015 11:18, Michal Privoznik пишет: There shouldn't be any functional change. Only some formatting nits fixed. Michal Privoznik (5): vz_driver: Reformat vz_network: Reformat vz_sdk:

Re: [libvirt] [sandbox PATCH 03/10] Add disk parameter to virt-sandbox

2015-06-25 Thread Cedric Bosdonnat
On Thu, 2015-06-25 at 14:09 +0100, Daniel P. Berrange wrote: On Thu, Jun 25, 2015 at 01:27:23PM +0200, Eren Yagdiran wrote: Allow users to add disk images to their sandbox. Only disk images are supported so far, but the parameter is intentionally designed for future changes. ---

[libvirt] [sandbox PATCH 02/10] Add configuration object for disk support

2015-06-25 Thread Eren Yagdiran
Add the config gobject, functions to store and load the new configuration fragments and test. This will allow creating sandboxes with attached disk with a parameter formatted like file:hda=/source/file.qcow2,format=qcow2 --- libvirt-sandbox/Makefile.am | 2 +

Re: [libvirt] [sandbox PATCH 00/10] Patches for Libvirt-sandbox

2015-06-25 Thread Daniel P. Berrange
On Thu, Jun 25, 2015 at 01:27:20PM +0200, Eren Yagdiran wrote: Hello, These patches provide disk support for libvirt-sandbox. Implemented '--disk' parameter will be useful when integrating Docker image support for libvirt-sandbox. --Main diffs compared to previous patches. Since many

Re: [libvirt] [PATCH 00/13] PCIe fixes + new PCI controllers w/RFC

2015-06-25 Thread Ján Tomko
On Thu, Jun 25, 2015 at 08:44:17AM +0200, Martin Kletzander wrote: On Wed, Jun 24, 2015 at 12:04:33PM -0400, Laine Stump wrote: At this point you can see that it all comes down to what name we want to give the subelement; within that, we give the exact name of the qemu device, and the exact

Re: [libvirt] [PATCH 1/2] Storage: Introduce shadow vol for refresh while the main vol builds.

2015-06-25 Thread Prerna Saxena
Hi Jan, Thanks for the review comments. On Tuesday 23 June 2015 06:21 PM, Ján Tomko wrote: On Mon, Jun 22, 2015 at 05:07:26PM +0530, Prerna Saxena wrote: From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Thu, 18 Jun 2015 05:05:09 -0500 Libvirt periodically refreshes all volumes in a storage

Re: [libvirt] [PATCH 2/2] Storage : Fix cloning of raw, sparse volumes

2015-06-25 Thread Prerna Saxena
On Tuesday 23 June 2015 06:29 PM, Ján Tomko wrote: On Mon, Jun 22, 2015 at 05:09:18PM +0530, Prerna Saxena wrote: From: Prerna Saxena pre...@linux.vnet.ibm.com Date: Mon, 22 Jun 2015 02:54:32 -0500 When virsh vol-clone is attempted on a raw file where capacity allocation, the resulting

Re: [libvirt] Bug: vnc + websocket = websocket autoport not working right at live migration

2015-06-25 Thread Martin Kletzander
On Tue, Jun 23, 2015 at 02:13:21PM +0200, Piotr Rybicki wrote: Hello. Problem description: When i start qemu via libvirt with vnc websocket defined, it is not possible to live migrate to host where other qemu process is running with the same display id. migration error is: error: internal

Re: [libvirt] [PATCH v2] docs: Properly mark acl.html dependencies

2015-06-25 Thread Martin Kletzander
On Wed, Jun 24, 2015 at 12:44:37PM +0200, Martin Kletzander wrote: On Wed, Jun 24, 2015 at 08:53:21AM +0200, Peter Krempa wrote: On Tue, Jun 23, 2015 at 14:46:36 +0200, Martin Kletzander wrote: On Tue, Jun 23, 2015 at 01:56:00PM +0200, Michal Privoznik wrote: The acl.html file includes

Re: [libvirt] [PATCH] conf: fix not format priority when it is zero

2015-06-25 Thread Martin Kletzander
On Wed, Jun 24, 2015 at 12:00:36PM +0800, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1235116 We do not format the priority if it is 0, but this will be a broken settings in guest. Change the condition of format priority element to always format priority if scheduler is

[libvirt] Plans for next release

2015-06-25 Thread Daniel Veillard
Sorry I nearly forgot, but we should enter freeze soon to try to hit the end of the month target. I see that Martin's APIs for admin support has been merged in so that would be libvirt-1.3.0. Plan is to enter freeze this w.e. and try to release by the end of the week, I hope this works for

Re: [libvirt] [PATCH 0/2] Handle isa-fdc removal from new q35 machine types

2015-06-25 Thread John Ferlan
On 06/22/2015 09:57 AM, Ján Tomko wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1227880 Ján Tomko (2): Separate isa-fdc options generation Explicitly format the isa-fdc controller for newer q35 machines src/qemu/qemu_command.c| 50

Re: [libvirt] [PATCH v2 1/3] vz: add net dev statistiscs

2015-06-25 Thread Dmitry Guryanov
On 06/18/2015 12:28 PM, Nikolay Shirokovskiy wrote: From: Nikolay Shirokovskiy nshirokovs...@parallels.com Populate counters SDK currenly supports: rx_bytes rx_packets tx_bytes tx_packets Comments. 1. Use vzDomObjFromDomainRef/virDomainObjEndAPI pair to get domain object as we use

Re: [libvirt] [PATCH v2 1/3] vz: add net dev statistiscs

2015-06-25 Thread Dmitry Guryanov
On 06/18/2015 12:28 PM, Nikolay Shirokovskiy wrote: From: Nikolay Shirokovskiy nshirokovs...@parallels.com Populate counters SDK currenly supports: rx_bytes rx_packets tx_bytes tx_packets Comments. 1. Use vzDomObjFromDomainRef/virDomainObjEndAPI pair to get domain object as we use

Re: [libvirt] [PATCH 1/5] internal: Introduce virCheckNonEmptyStringArgGoto and reuse it

2015-06-25 Thread John Ferlan
On 06/23/2015 01:15 PM, Peter Krempa wrote: The helper makes sure that strings passed to APIs are non-NULL and non-empty. This allows to drop some inlined checks where it does not make sense. --- src/internal.h | 11 +++ src/libvirt-domain.c | 4 ++--

[libvirt] [sandbox 00/10] Actually use host-image mounts on /

2015-06-25 Thread Cédric Bosdonnat
Hi all, In the virt-sandbox documentation we had examples with host-image mounts targetting /. However the / in the sandbox was still the host one. The main goal of this patch series is to fix that problem. This will also be needed to run docker container with libvirt-sandbox. I also added some

[libvirt] [sandbox 09/10] Don't add sandbox:root device if we have a mount targetting /

2015-06-25 Thread Cédric Bosdonnat
There is no need to expose the host file system if the user defined a mount targetting / --- libvirt-sandbox/libvirt-sandbox-builder-machine.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/libvirt-sandbox/libvirt-sandbox-builder-machine.c

[libvirt] [sandbox 10/10] container builder: don't expose host rootfs if unneeded

2015-06-25 Thread Cédric Bosdonnat
If the user defined a mount targeting / don't add the host / as mount to /. --- .../libvirt-sandbox-builder-container.c| 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/libvirt-sandbox/libvirt-sandbox-builder-container.c

[libvirt] [sandbox 03/10] Enable strcmp checks in libvirt-sandbox-init-qemu.c

2015-06-25 Thread Cédric Bosdonnat
--- cfg.mk | 2 +- libvirt-sandbox/libvirt-sandbox-init-qemu.c | 6 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/cfg.mk b/cfg.mk index 83ded15..e9c12f7 100644 --- a/cfg.mk +++ b/cfg.mk @@ -133,4 +133,4 @@

[libvirt] [sandbox 08/10] Add function to check if there is a mount with / target

2015-06-25 Thread Cédric Bosdonnat
gvir_sandbox_config_has_root_mount is a convenience function to check if there is a mount with target '/' --- libvirt-sandbox/libvirt-sandbox-config.c | 21 + libvirt-sandbox/libvirt-sandbox-config.h | 1 + libvirt-sandbox/libvirt-sandbox.sym | 1 + 3 files changed, 23

[libvirt] [sandbox 05/10] Remove init-common dependency on libvirt-sandbox.so

2015-06-25 Thread Cédric Bosdonnat
Removing this dependency avoids getting all libvirt.so dependencies loaded in our container. --- libvirt-sandbox/Makefile.am| 41 +++ libvirt-sandbox/libvirt-sandbox-config-all.h | 61 ++ .../libvirt-sandbox-config-interactive.c

Re: [libvirt] [PATCH v2 2/3] vz: add vcpu statistics

2015-06-25 Thread Dmitry Guryanov
On 06/18/2015 12:28 PM, Nikolay Shirokovskiy wrote: From: Nikolay Shirokovskiy nshirokovs...@parallels.com Comments. Replace vzDomObjFromDomain/virObjectUnlock pair to vzDomObjFromDomainRef/virDomainObjEndAPI as we use prlsdkGetStatsParam. See previous statistics comments. Looks good to me,

Re: [libvirt] [PATCH] qemu_hotplug: try harder to eject media

2015-06-25 Thread John Ferlan
On 06/23/2015 07:13 AM, Pavel Hrdina wrote: Some guests lock the tray and QEMU eject command will simply fail to eject the media. But the guest OS can handle this attempt to eject the media and can unlock the tray and open it. In this case, we should try again to actually eject the media.

Re: [libvirt] [sandbox PATCH 09/10] Common-init: Building symlink from disks.cfg

2015-06-25 Thread Daniel P. Berrange
On Thu, Jun 25, 2015 at 01:27:29PM +0200, Eren Yagdiran wrote: Similar to the existing mounts.cfg, the mapping between the device and the tag is passed by a new disks.cfg file. Common-init reads disks.cfg and maps the tags to corresponding devices ---

Re: [libvirt] [sandbox 01/10] Allow disabling build with lzma.

2015-06-25 Thread Daniel P. Berrange
On Thu, Jun 25, 2015 at 06:49:38PM +0200, Cédric Bosdonnat wrote: Some linux distributions don't package static lzma library. Allow disabling it. --- configure.ac| 14 +- libvirt-sandbox/libvirt-sandbox-init-qemu.c | 12 2 files

[libvirt] [sandbox 01/10] Allow disabling build with lzma.

2015-06-25 Thread Cédric Bosdonnat
Some linux distributions don't package static lzma library. Allow disabling it. --- configure.ac| 14 +- libvirt-sandbox/libvirt-sandbox-init-qemu.c | 12 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/configure.ac

Re: [libvirt] [sandbox 02/10] Allow disabling zlib support.

2015-06-25 Thread Daniel P. Berrange
On Thu, Jun 25, 2015 at 06:49:39PM +0200, Cédric Bosdonnat wrote: Some distributions may not have static zlib package. Allow disabling it at build time. --- configure.ac| 16 +++- libvirt-sandbox/libvirt-sandbox-init-qemu.c | 12 2

Re: [libvirt] [sandbox 03/10] Enable strcmp checks in libvirt-sandbox-init-qemu.c

2015-06-25 Thread Daniel P. Berrange
On Thu, Jun 25, 2015 at 06:49:40PM +0200, Cédric Bosdonnat wrote: --- cfg.mk | 2 +- libvirt-sandbox/libvirt-sandbox-init-qemu.c | 6 -- 2 files changed, 5 insertions(+), 3 deletions(-) ACK, but... diff --git a/cfg.mk b/cfg.mk index

Re: [libvirt] [sandbox PATCH 04/10] Add disk support to the container builder

2015-06-25 Thread Daniel P. Berrange
On Thu, Jun 25, 2015 at 01:27:24PM +0200, Eren Yagdiran wrote: Use the new disk configuration in the container builder to provide disks in lxc containers sandboxes. --- .../libvirt-sandbox-builder-container.c| 37 +- 1 file changed, 36 insertions(+), 1

Re: [libvirt] [sandbox PATCH 02/10] Add configuration object for disk support

2015-06-25 Thread Daniel P. Berrange
On Thu, Jun 25, 2015 at 01:27:22PM +0200, Eren Yagdiran wrote: Add the config gobject, functions to store and load the new configuration fragments and test. This will allow creating sandboxes with attached disk with a parameter formatted like file:hda=/source/file.qcow2,format=qcow2 ---

Re: [libvirt] [PATCH 3/5] qemu: monitor: Open-code retrieval of wr_highest_offset

2015-06-25 Thread John Ferlan
On 06/23/2015 01:15 PM, Peter Krempa wrote: Instead of using qemuMonitorJSONDevGetBlockExtent (which I plan to remove later) extract the data in place. Additionally add a flag that will be set when the wr_highest_offset was extracted correctly so that callers can act according to that.

Re: [libvirt] [PATCH 4/5] qemu: Refactor qemuDomainGetBlockInfo

2015-06-25 Thread John Ferlan
On 06/23/2015 01:15 PM, Peter Krempa wrote: Change the code so that it queries the monitor when the VM is alive. --- src/qemu/qemu_driver.c | 90 +- 1 file changed, 53 insertions(+), 37 deletions(-) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCH 1/2] qemuBuildMemoryBackendStr: Fix hugepages lookup process

2015-06-25 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1196644 So this function is called to construct the guest NUMA part of the qemu command line. At the beginning, the configured hugepages are searched to find the best match for given guest NUMA node. Configured hugepages can have a @nodeset attribute to

[libvirt] [PATCH 2/2] qemuBuildMemoryBackendStr: Honour passed @pagesize

2015-06-25 Thread Michal Privoznik
So far the argument has not much meaning and was practically ignored. This is not good since when doing memory hotplug, the size of desired hugepage backing is passed in that argument. Taking closer look at the tests I'm fixing reveals the bug. For instance, while the following is in the test:

[libvirt] [PATCH 0/2] qemuBuildMemoryBackendStr: Couple of fixes

2015-06-25 Thread Michal Privoznik
The first one fixes a bug we have for a long time. The second one is not that ancient but still worth fixing. Michal Privoznik (2): qemuBuildMemoryBackendStr: Fix hugepages lookup process qemuBuildMemoryBackendStr: Honour passed @pagesize src/qemu/qemu_command.c|

Re: [libvirt] [sandbox PATCH 07/10] qemu: use devtmpfs rather than tmpfs to auto-populate /dev

2015-06-25 Thread Daniel P. Berrange
On Thu, Jun 25, 2015 at 01:27:27PM +0200, Eren Yagdiran wrote: From: Cédric Bosdonnat cbosdon...@suse.com When using devtmpfs we don't need to care about the device nodes creation: it's less risk to forget some. It also eases the creation of the devices in the init-qemu. ---

Re: [libvirt] [PATCH 2/5] qemu: monitor: Fix indentation in qemuMonitorJSONGetOneBlockStatsInfo

2015-06-25 Thread John Ferlan
On 06/23/2015 01:15 PM, Peter Krempa wrote: --- src/qemu/qemu_monitor_json.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) ACK John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [sandbox PATCH 08/10] Init-util : Common directory functions for init-common and init-qemu

2015-06-25 Thread Daniel P. Berrange
On Thu, Jun 25, 2015 at 01:27:28PM +0200, Eren Yagdiran wrote: Init-util provides common functions for creating directories for both Init-common and Init-qemu. Error handling needs to be done in calling function. --- libvirt-sandbox/Makefile.am | 4 +-

Re: [libvirt] [PATCH v2 3/3] vz: add memory statistics

2015-06-25 Thread Dmitry Guryanov
On 06/18/2015 12:28 PM, Nikolay Shirokovskiy wrote: From: Nikolay Shirokovskiy nshirokovs...@parallels.com Implemented counters: VIR_DOMAIN_MEMORY_STAT_SWAP_IN VIR_DOMAIN_MEMORY_STAT_SWAP_OUT VIR_DOMAIN_MEMORY_STAT_MINOR_FAULT VIR_DOMAIN_MEMORY_STAT_MAJOR_FAULT

Re: [libvirt] [RFC] qemu: Redesigning guest CPU configuration

2015-06-25 Thread Michael Mueller
On Wed, 17 Jun 2015 17:37:42 +0200 Jiri Denemark jdene...@redhat.com wrote: Hi all (and sorry for the long email), The current way QEMU driver handles guest CPU configuration is not ideal. We detect host CPU capabilities only by querying the CPU and we don't check with QEMU what features it

[libvirt] [sandbox 02/10] Allow disabling zlib support.

2015-06-25 Thread Cédric Bosdonnat
Some distributions may not have static zlib package. Allow disabling it at build time. --- configure.ac| 16 +++- libvirt-sandbox/libvirt-sandbox-init-qemu.c | 12 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/configure.ac

[libvirt] [sandbox 06/10] init-qemu: extract the mounts.cfg entry mounting code

2015-06-25 Thread Cédric Bosdonnat
Create a mount_entry function from the code mounting the entries defined in mounts.cfg in order to be able to reuse that code. This will later be useful to mount a / from mounts.cfg. --- libvirt-sandbox/libvirt-sandbox-init-qemu.c | 68 + 1 file changed, 39

[libvirt] [sandbox 07/10] qemu: use mounts targeting / as root

2015-06-25 Thread Cédric Bosdonnat
So far a mount with / as target doesn't change anything: the host / is still the one mounted as /. libvirt-sandbox-init-qemu now detects the presence of a / target in mounts.cfg and mounts it instead of sandbox:root. --- libvirt-sandbox/libvirt-sandbox-init-qemu.c | 69

[libvirt] [sandbox 04/10] Copy init-common and all its deps to config subdir

2015-06-25 Thread Cédric Bosdonnat
In order to be able to mount a custom host-image as / we need to be able to access libvirt-sandbox-init-common and all its needed dependencies. They are now copied into SANDBOXCONFIGDIR /.libs. Hard linking is not possible since we may be working on separate partitions, and symlinks wouldn't help

Re: [libvirt] [PATCH 5/5] qemu: monitor: Remove qemuMonitorGetBlockExtent

2015-06-25 Thread John Ferlan
On 06/23/2015 01:15 PM, Peter Krempa wrote: Now that qemuMonitorGetAllBlockStatsInfo collects also wr_highest_offset the whole function can be killed. --- src/qemu/qemu_monitor.c | 16 - src/qemu/qemu_monitor.h | 3 - src/qemu/qemu_monitor_json.c | 138

Re: [libvirt] [PATCH 4/5] qemu: Refactor qemuDomainGetBlockInfo

2015-06-25 Thread Peter Krempa
On Thu, Jun 25, 2015 at 13:26:35 -0400, John Ferlan wrote: On 06/23/2015 01:15 PM, Peter Krempa wrote: Change the code so that it queries the monitor when the VM is alive. --- src/qemu/qemu_driver.c | 90 +- 1 file changed, 53

Re: [libvirt] [PATCH] qemu_hotplug: try harder to eject media

2015-06-25 Thread John Ferlan
On 06/25/2015 01:52 PM, Pavel Hrdina wrote: On Thu, Jun 25, 2015 at 12:06:49PM -0400, John Ferlan wrote: On 06/23/2015 07:13 AM, Pavel Hrdina wrote: Some guests lock the tray and QEMU eject command will simply fail to eject the media. But the guest OS can handle this attempt to eject the

Re: [libvirt] [PATCH] storage: add RBD support to disk source pool translation

2015-06-25 Thread John Ferlan
On 06/25/2015 06:21 AM, Thibault VINCENT wrote: On 09/06/2015 17:33, John Ferlan wrote: I still think I need a tweak on what I posted as an update - the libvirtd restart path is always a bit tricky. The 'pooltype' isn't filled in at XML processing time and virStorageTranslateDiskSourcePool

Re: [libvirt] [PATCH] qemu_hotplug: try harder to eject media

2015-06-25 Thread Pavel Hrdina
On Thu, Jun 25, 2015 at 12:06:49PM -0400, John Ferlan wrote: On 06/23/2015 07:13 AM, Pavel Hrdina wrote: Some guests lock the tray and QEMU eject command will simply fail to eject the media. But the guest OS can handle this attempt to eject the media and can unlock the tray and open

Re: [libvirt] [PATCH] conf: fix not format priority when it is zero

2015-06-25 Thread lhuang
On 06/26/2015 05:26 AM, Martin Kletzander wrote: On Wed, Jun 24, 2015 at 12:00:36PM +0800, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1235116 We do not format the priority if it is 0, but this will be a broken settings in guest. Change the condition of format priority

[libvirt] [PATCH] vz: Adapt to driver rename

2015-06-25 Thread Michal Privoznik
In the e6d180f07fb06 commit the parallels driver was renamed to vz. However, there was a commit merged later, which was sent to the list before the rename. The other commit is 6de12b026b73. Fix all the missing renames. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- Pushed under build

[libvirt] [PATCH 2/5] vz_network: Reformat

2015-06-25 Thread Michal Privoznik
Honour our formatting style. Adjust indentation so it matches the rest of our code. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/vz/vz_network.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/vz/vz_network.c

[libvirt] [PATCH 3/5] vz_sdk: Reformat

2015-06-25 Thread Michal Privoznik
Honour our formatting style. Adjust indentation so it matches the rest of our code. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/vz/vz_sdk.c | 209 1 file changed, 104 insertions(+), 105 deletions(-) diff --git

[libvirt] [PATCH 0/5] vz: Reformat

2015-06-25 Thread Michal Privoznik
There shouldn't be any functional change. Only some formatting nits fixed. Michal Privoznik (5): vz_driver: Reformat vz_network: Reformat vz_sdk: Reformat vz_storage: Reformat vz_utils: Reformat src/vz/vz_driver.c | 86 ++--- src/vz/vz_network.c | 26 +++

[libvirt] [PATCH 5/5] vz_utils: Reformat

2015-06-25 Thread Michal Privoznik
Honour our formatting style. Adjust indentation so it matches the rest of our code. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/vz/vz_utils.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/vz/vz_utils.h b/src/vz/vz_utils.h index

[libvirt] [PATCH 1/5] vz_driver: Reformat

2015-06-25 Thread Michal Privoznik
Honour our formatting style. Adjust indentation so it matches the rest of our code. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/vz/vz_driver.c | 86 +++--- 1 file changed, 43 insertions(+), 43 deletions(-) diff --git

[libvirt] [PATCH 4/5] vz_storage: Reformat

2015-06-25 Thread Michal Privoznik
Honour our formatting style. Adjust indentation so it matches the rest of our code. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- src/vz/vz_storage.c | 58 ++--- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git

Re: [libvirt] [PATCH] qemu: fix wrong remove guest cfg if migrate fail

2015-06-25 Thread Jiri Denemark
On Thu, Jun 25, 2015 at 09:38:57 +0800, Luyao Huang wrote: If we get fail in qemuMigrationPrepareAny, we forget check if the vm is persistent then always call qemuDomainRemoveInactive to clean the inactive settings. Add a check to avoid this. This issue was introduce in commit 540c339.

Re: [libvirt] [PATCH 00/13] PCIe fixes + new PCI controllers w/RFC

2015-06-25 Thread Martin Kletzander
On Wed, Jun 24, 2015 at 12:04:33PM -0400, Laine Stump wrote: I think the only votes were for option 1 and 4 (interesting how the only ones that were chosen were those that I *didn't* pick personally :-). See comments below. In the meantime the other issue Alex pointed out may cause this to take

Re: [libvirt] [PATCH v2 10/15] test: Finalize removal of locking from driver-eventState

2015-06-25 Thread Peter Krempa
On Wed, Jun 24, 2015 at 14:04:06 -0400, John Ferlan wrote: On 06/24/2015 10:11 AM, Peter Krempa wrote: Don't lock the driver when registering event callbacks. --- src/test/test_driver.c | 12 1 file changed, 12 deletions(-) diff --git a/src/test/test_driver.c

[libvirt] [PATCH] vz: fix SDK event dispatching

2015-06-25 Thread nshirokovskiy
From: Nikolay Shirokovskiy nshirokovs...@virtuozzo.com Current version of SDK event dispatcing is incorrect. For most VM events (add, delete etc) issuer type is PIE_DISPATCHER. Actually analyzing issuer type doesn't have any benifints so this patch get rid of it. All dispatching is done only on

Re: [libvirt] [PATCH] qemu: fix wrong remove guest cfg if migrate fail

2015-06-25 Thread lhuang
On 06/25/2015 04:25 PM, Jiri Denemark wrote: On Thu, Jun 25, 2015 at 09:38:57 +0800, Luyao Huang wrote: If we get fail in qemuMigrationPrepareAny, we forget check if the vm is persistent then always call qemuDomainRemoveInactive to clean the inactive settings. Add a check to avoid this. This

Re: [libvirt] [PATCH 0/5] vz: Reformat

2015-06-25 Thread Maxim Nestratov
25.06.2015 11:18, Michal Privoznik пишет: There shouldn't be any functional change. Only some formatting nits fixed. Michal Privoznik (5): vz_driver: Reformat vz_network: Reformat vz_sdk: Reformat vz_storage: Reformat vz_utils: Reformat src/vz/vz_driver.c | 86

Re: [libvirt] [PATCH v2 15/15] test: Refactor testNodeGetCPUMap

2015-06-25 Thread Peter Krempa
On Thu, Jun 25, 2015 at 10:57:18 +0200, Pavel Hrdina wrote: On Wed, Jun 24, 2015 at 04:11:57PM +0200, Peter Krempa wrote: Drop locking of the driver since it is not accessed and simplify the code flow. --- src/test/test_driver.c | 14 +++--- 1 file changed, 3 insertions(+), 11

Re: [libvirt] [PATCH] vz: Adapt to driver rename

2015-06-25 Thread Dmitry Guryanov
On 06/25/2015 11:14 AM, Michal Privoznik wrote: In the e6d180f07fb06 commit the parallels driver was renamed to vz. However, there was a commit merged later, which was sent to the list before the rename. The other commit is 6de12b026b73. Fix all the missing renames. Sorry, something is broken

Re: [libvirt] [PATCH v2 15/15] test: Refactor testNodeGetCPUMap

2015-06-25 Thread Pavel Hrdina
On Wed, Jun 24, 2015 at 04:11:57PM +0200, Peter Krempa wrote: Drop locking of the driver since it is not accessed and simplify the code flow. --- src/test/test_driver.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/test/test_driver.c

Re: [libvirt] [PATCH 00/13] PCIe fixes + new PCI controllers w/RFC

2015-06-25 Thread Daniel P. Berrange
On Thu, Jun 25, 2015 at 08:44:17AM +0200, Martin Kletzander wrote: To be honest, I kinds dislike all of them. Not that they would be chosen poorly, no, it's simply because the good sensible choice is unavailable due to another poor decision in the past (this may be another point for Michal's

Re: [libvirt] [PATCH 1/3] remote: move connection close callback to driver level

2015-06-25 Thread Martin Kletzander
On Wed, Jun 24, 2015 at 05:33:51PM +0300, Nikolay Shirokovskiy wrote: 1. Introduce connect(Un)RegisterCloseCallback driver functions. 2. virConnect(Un)RegisterCloseCallback now works through driver. 3. virConnectCloseCallback is factored from virConnect but mostly stay the same. Notice however

Re: [libvirt] [PATCH 0/5] vz: Reformat

2015-06-25 Thread Martin Kletzander
On Thu, Jun 25, 2015 at 10:18:13AM +0200, Michal Privoznik wrote: There shouldn't be any functional change. Only some formatting nits fixed. Michal Privoznik (5): vz_driver: Reformat vz_network: Reformat vz_sdk: Reformat vz_storage: Reformat vz_utils: Reformat src/vz/vz_driver.c | 86