[libvirt] [PATCH v2] qemu: process: Improve update of maximum baloon state at startup

In commit 641a145d73fdc3dd9350fd57b3d3247abf101c05 I've added code that resets the ballon memory value to full size prior to resuming the vCPUs since the size certainly was not reduced at that point. Since qemuProcess start is used also in code paths with already booted up guests (migration,

Re: [libvirt] [PATCH 2/2] qemu: Audit memory size with memory hotplug operations

On Tue, Jun 30, 2015 at 18:03:29 +0200, Martin Kletzander wrote: On Fri, Jun 26, 2015 at 05:16:48PM +0200, Peter Krempa wrote: The memory device hot(un)plug was missing calls to the auditing code. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1226234 --- src/qemu/qemu_hotplug.c |

[libvirt] sheepdog volume and number of copies

Hi libvirt devs! Sheepdog have ability to specify number of copies (full replica or erasure) for each vdi when it created, Now xml looks like: volume name{VDI_NAME}/name keysheep/{VDI_NAME}/key source/source allocation unit=G{VDI_SIZE}/allocation capacity unit=G{VDI_SIZE}/capacity

Re: [libvirt] [PATCH] conf: qemu: Taint VMs using custom device tree blob

On Fri, Jun 26, 2015 at 11:05:59 +0200, Peter Krempa wrote: Using a custom device tree image may cause unexpected behavior in architectures that use this approach to detect platform devices. Since usually the device tree is generated by qemu and thus it's not normally used let's taint VMs

Re: [libvirt] [sandbox] Cleanup the disks.cfg file

On Wed, Jul 01, 2015 at 10:20:02AM +0200, Cédric Bosdonnat wrote: The newly introduced disks.cfg file is still remaining in the configuration folder after the sandbox is stopped. Let's remove it like the other things there. --- libvirt-sandbox/libvirt-sandbox-builder.c | 6 ++ 1 file

Re: [libvirt] [PATCH sandbox] Ensure libvirt-sandbox-init-common uses correct ld-linux

On Tue, 2015-06-30 at 17:51 +0100, Daniel P. Berrange wrote: The libc.so library requires certainly functionality to be provided by the ld-linux.so library. The ld-linux.so is loaded by the kernel based on the PT_INTERP ELF section, and as such LD_LIBRARY_PATH has no effect. So, although

[libvirt] [PATCHv3] virt-aa-helper: Fix permissions for vhost-user socket files

QEMU working in vhost-user mode communicates with the other end (i.e. some virtual router application) via unix domain sockets. This requires that permissions for the socket files are correctly written into /etc/apparmor.d/libvirt/libvirt-UUID.files. Signed-off-by: Michal Dubiel m...@semihalf.com

[libvirt] [sandbox] Cleanup the disks.cfg file

The newly introduced disks.cfg file is still remaining in the configuration folder after the sandbox is stopped. Let's remove it like the other things there. --- libvirt-sandbox/libvirt-sandbox-builder.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [libvirt] [PATCHv2] virt-aa-helper: Fix permissions for vhost-user socket files

Hi Michal, I've sent v3 of the patch with the curly braces removed from one line 'if' blok. Sorry for that. Regards, Michal On 30 June 2015 at 16:41, Michal Privoznik mpriv...@redhat.com wrote: On 22.06.2015 12:47, Michal Dubiel wrote: QEMU working in vhost-user mode communicates with the

Re: [libvirt] [PATCH] qemu: fix not end the job after use OpenGraphics(FD) and get fail when exit monitor

On 07/01/2015 02:15 PM, Martin Kletzander wrote: On Tue, Jun 30, 2015 at 11:35:13AM +0800, Luyao Huang wrote: If guest unexpect exit(qemu process be killed) and get failed when exit the monitor, guest job still handled by old function, this will make guest cannot start later. Need call

Re: [libvirt] Which symbols can be used in file paths in libvirt's XMLs?

On Wed, Jul 01, 2015 at 07:22:33PM +0300, Dmitry Guryanov wrote: Hello, There is an absFilePatch type in docs/schemas/basictypes.rng rng schema: define name=absFilePath data type=string param name=pattern/[a-zA-Z0-9_\.\+\-\\amp;quot;apos;lt;gt;/%,:]+/param /data

Re: [libvirt] How to define QEMU/SMBIOS Attributes in virsh

On Wed, Jul 01, 2015 at 03:01:40PM +0200, Holger Schranz wrote: Hello, I have a request for Help please. Myself: I'm a native german language speaker and I' work with qemu/virsh since 6 months now. At the moment I try to define/configure qemu/smbios attributes in a virsh xml-file. My

[libvirt] [libvirt-glib PATCHv3 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

--- libvirt-gobject/libvirt-gobject-network.c | 54 +++ libvirt-gobject/libvirt-gobject-network.h | 4 +++ libvirt-gobject/libvirt-gobject.sym | 2 ++ 3 files changed, 60 insertions(+) diff --git a/libvirt-gobject/libvirt-gobject-network.c

[libvirt] [libvirt-glib PATCHv3 4/7] gobject: Add API to query connection interfaces

Add API to query network interfaces from a connection. --- libvirt-gobject/libvirt-gobject-connection.c | 263 +++ libvirt-gobject/libvirt-gobject-connection.h | 13 +- libvirt-gobject/libvirt-gobject.sym | 7 + 3 files changed, 281 insertions(+), 2

[libvirt] [libvirt-glib PATCHv3 1/7] gobject: Simplify gvir_connection_list*() implementations

Make use of virConnectListAll* functions to avoid making 4 calls and hence avoid race conditions and complicated code. --- libvirt-gobject/libvirt-gobject-connection.c | 203 --- 1 file changed, 28 insertions(+), 175 deletions(-) diff --git

[libvirt] [libvirt-glib PATCHv3 2/7] gobject: Plug 2 virConnect leaks

--- libvirt-gobject/libvirt-gobject-connection.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-connection.c b/libvirt-gobject/libvirt-gobject-connection.c index 1576906..dddbd3a 100644 --- a/libvirt-gobject/libvirt-gobject-connection.c

[libvirt] [libvirt-glib PATCHv3 6/7] gobject: Add wrapper for virNetworkDHCPLease

--- libvirt-gobject/Makefile.am| 5 +- .../libvirt-gobject-network-dhcp-lease-private.h | 34 +++ .../libvirt-gobject-network-dhcp-lease.c | 252 + .../libvirt-gobject-network-dhcp-lease.h | 85 +++

[libvirt] [libvirt-glib PATCHv3 5/7] gobject: Add API to query connection networks

Add API to query networks from a connection. --- libvirt-gobject/libvirt-gobject-connection.c | 255 +++ libvirt-gobject/libvirt-gobject-connection.h | 13 +- libvirt-gobject/libvirt-gobject.sym | 6 + 3 files changed, 272 insertions(+), 2 deletions(-) diff

[libvirt] [libvirt-glib PATCHv3 3/7] gobject: Port GVirConnection to GTask

GSimpleAsyncResult has been deprecated in favour of GTask and with latest glib headers, we get tons of warnings about use of deprecated API. This patch ports the GVirConnection class to GTask. --- libvirt-gobject/libvirt-gobject-connection.c | 236 --- 1 file changed, 100

Re: [libvirt] [PATCH] lxc / docker containers gives option to inherit the namespaces. Example lxc-start has option [ --share-[net|ipc|uts] name|pid ] where --share-net name|pid means Inherit a network

Dear Michal, Thanks a lot for reviewing the changes. I really appreciate your ability to spot very minute errors which have not been spotted by me or my local reviews. I have reworked almost all of the review comments you made. and Have sent a separate email with subject Inherit namespace

Re: [libvirt] How to define QEMU/SMBIOS Attributes in virsh

Hi Daniel, thanks a lot for this information. I think thepassthrough is usable as a work around meanwhile. How do I write a bug report (via the HP of libvirt)? Best regards Holger Am 01.07.2015 um 19:49 schrieb Daniel P. Berrange: On Wed, Jul 01, 2015 at 03:01:40PM +0200, Holger Schranz

[libvirt] [PATCH 0/2] some qemu_driver cleanups

Pavel Hrdina (2): qemu_driver: live/config checks cleanup qemu_driver: remove duplicate code src/qemu/qemu_driver.c | 85 ++ 1 file changed, 9 insertions(+), 76 deletions(-) -- 2.4.5 -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH 2/2] qemu_driver: remove duplicate code

The copy of persistent definition is already done in virDomainLiveConfigHelperMethod few lines above. Signed-off-by: Pavel Hrdina phrd...@redhat.com --- src/qemu/qemu_driver.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[libvirt] [PATCH 1/2] qemu_driver: live/config checks cleanup

Signed-off-by: Pavel Hrdina phrd...@redhat.com --- src/qemu/qemu_driver.c | 79 ++ 1 file changed, 9 insertions(+), 70 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 7a04e67..4cfae03 100644 ---

Re: [libvirt] [PATCH 1/2] qemu: fix address allocation on chardev attach

On 06/30/2015 10:26 AM, Ján Tomko wrote: From: Luyao Huang lhu...@redhat.com Also check the device type when deciding what type the address should be. Commit 9807c47 (aiming to fix another error in address allocation) only checked the target type, but its value is different for different

[libvirt] [sandbox] Get gvir_sandbox_util_guess_image_format search for the last '.'

gvir_sandbox_util_guess_image_format is failing to find the extension in paths like /tmp/tmp.mg0tQ1JLFl/mine.img --- libvirt-sandbox/libvirt-sandbox-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-sandbox/libvirt-sandbox-util.c

Re: [libvirt] [sandbox] Get gvir_sandbox_util_guess_image_format search for the last '.'

On Wed, Jul 01, 2015 at 02:46:14PM +0200, Cédric Bosdonnat wrote: gvir_sandbox_util_guess_image_format is failing to find the extension in paths like /tmp/tmp.mg0tQ1JLFl/mine.img --- libvirt-sandbox/libvirt-sandbox-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH] Fix nodeinfo output on PPC64 KVM hosts

Hi Andrea, I have posted the v2 as per your suggestions. Also added test case to test the nodeinfo. I moved the ioctl to a new function to help mocking it for testing. For everyone, the capabilities is reporting correctly with numactl-devel installed as confirmed by Andrea over IRC. Thanks and

Re: [libvirt] [PATCH 0/7] Address some Coverity found issues

On Wed, Jul 01, 2015 at 10:03:44 -0400, John Ferlan wrote: The following Coverity issues are flagged in Coverity 7.6.1 compared to not being seen in 7.5.1 - this series just addresses those issues before 7.6.1 is installed in our upstream Jenkins environment:

[libvirt] [PATCH v2 1/2] Fix nodeinfo output on PPC64 KVM hosts

The nodeinfo is reporting incorrect number of cpus and incorrect host topology on PPC64 KVM hosts. The KVM hypervisor on PPC64 needs only the primary thread in a core to be online, and the secondaries offlined. While scheduling a guest in, the kvm scheduler wakes up the secondaries to run in guest

[libvirt] [PATCH 6/7] util: Resolve Coverity FORWARD_NULL

Coverity believes that virDBusMessageIterDecode could find nstack = 0 in the first pass through the for (;;), thus break'ing out of the loop prior to any virDBusTypeStackPush being called thus having 'stack == NULL'. Rather than check for (!stack) prior to either the Encode or Decode path,

[libvirt] [PATCH 1/7] util: Resolve Coverity FORWARD_NULL

Convert virPCIFile to return the buffer allocated (or not) and make the appropriate check in the caller. Signed-off-by: John Ferlan jfer...@redhat.com --- src/util/virpci.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/src/util/virpci.c

[libvirt] [PATCH 0/7] Address some Coverity found issues

The following Coverity issues are flagged in Coverity 7.6.1 compared to not being seen in 7.5.1 - this series just addresses those issues before 7.6.1 is installed in our upstream Jenkins environment: http://jenkins-virt.usersys.redhat.com/job/libvirt-coverity/ It seems the bulk are essentially

Re: [libvirt] [PATCH 5/7] phyp: Resolve Coverity FORWARD_NULL

On Wed, Jul 01, 2015 at 10:03:49 -0400, John Ferlan wrote: Commit id 'cd490086' added a VIR_FORCE_CLOSE of the 'sock', but it was after the VIR_FREE() of phyp_driver, resulting in a possible/likely NULL dereference. Signed-off-by: John Ferlan jfer...@redhat.com --- src/phyp/phyp_driver.c

[libvirt] ANNOUNCE: libvirt-sandbox Dashti Margo release 0.6.0

I pleased to announce the a new public release of libvirt-sandbox, version 0.6.0, is now available for download ftp://libvirt.org/libvirt/sandbox/ The packages are GPG signed with Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) The libvirt-sandbox package

[libvirt] [PATCH 4/7] Avoid Coverity FORWARD_NULL prior to strtok_r calls

The 'strtok_r' function requires passing a NULL as the first parameter on subsequent calls in order to ensure the code picks up where it left off on a previous call. However, Coverity doesn't quite realize this and points out that if a NULL was passed in as the third argument it would result in a

Re: [libvirt] [PATCH 7/7] util: Avoid Coverity FORWARD_NULL

On Wed, Jul 01, 2015 at 10:03:51 -0400, John Ferlan wrote: Avoid a false positive since Coverity find a path in virResizeN which could return 0 prior to the allocation of memory and thus flags a possible NULL dereference. Instead use multiple loops to first count the number of matches, perform

[libvirt] [PATCH 7/7] util: Avoid Coverity FORWARD_NULL

Avoid a false positive since Coverity find a path in virResizeN which could return 0 prior to the allocation of memory and thus flags a possible NULL dereference. Instead use multiple loops to first count the number of matches, perform one allocation, and then again search for matches. It's a 'n'

[libvirt] [PATCH 3/7] util: Resolve Coverity FORWARD_NULL

Convert virPCIDriverDir to return the buffer allocated (or not) and make the appropriate check in the caller. Signed-off-by: John Ferlan jfer...@redhat.com --- src/util/virpci.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/util/virpci.c

[libvirt] [PATCH 2/7] util: Resolve Coverity FORWARD_NULL

Convert virPCIDriverFile to return the buffer allocated (or not) and make the appropriate check in the caller. Signed-off-by: John Ferlan jfer...@redhat.com --- src/util/virpci.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/src/util/virpci.c

[libvirt] [PATCH 5/7] phyp: Resolve Coverity FORWARD_NULL

Commit id 'cd490086' added a VIR_FORCE_CLOSE of the 'sock', but it was after the VIR_FREE() of phyp_driver, resulting in a possible/likely NULL dereference. Signed-off-by: John Ferlan jfer...@redhat.com --- src/phyp/phyp_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[libvirt] Release candidate 2 for libvirt-1.2.17

I have tagged in git and pushed signed rpms and tarballs to the usual place: ftp://libvirt.org/libvirt/ seems to work with my limited testing. Still have no idea why that would block on the debian side building documentation, everything seems correct here. I may postpone the final

[libvirt] add optional redundancy element to storage

some storages have ability to provide redundancy, for example sheepdog via full copies or erasure Signed-off-by: Vasiliy Tolstov v.tols...@selfip.ru --- docs/schemas/storagevol.rng | 24 1 file changed, 24 insertions(+) diff --git a/docs/schemas/storagevol.rng

Re: [libvirt] add optional redundancy element to storage

2015-07-01 12:30 GMT+03:00 Vasiliy Tolstov v.tols...@selfip.ru: some storages have ability to provide redundancy, for example sheepdog via full copies or erasure Does it look good in case of in the feature for example ceph or other storages have similar options ? -- Vasiliy Tolstov, e-mail:

Re: [libvirt] [PATCH] lxc: Bind mount container TTYs

On Tue, Jun 30, 2015 at 07:54:25PM +0200, Richard Weinberger wrote: Am 30.06.2015 um 19:12 schrieb Martin Kletzander: Hmm, very strange. What guest container are you using? I tried with a Debian jessi and had user namespace enabled. Sorry for the late reply. I used simple one. Only

Re: [libvirt] [PATCH 00/13] Move generic virsh data to a separate module vsh

This is rather big change. Do you perhaps have a public repo with all the patches applied? I've also noticed 03/13 is missing. Michal I do have it in my inbox (I always CC myself when sending patches), I've also sent another copy earlier today... still nothing. I have no idea, where

[libvirt] [PATCH] qemu: Resolve Coverity DEADCODE

Commit id 'f967e7a6' didn't place the closing parentheses quite right causing DEADCODE errors since the rc setting/comparison was wrong. Signed-off-by: John Ferlan jfer...@redhat.com --- src/qemu/qemu_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [PATCH 1/2] storage: allow zero capacity with non-backing file to be created

In commit fbcf7da95, a change was introduced that no longer allowed defining volumes via XML with a capacity of '0'. Because we check for info.size_arg to be non-zero, this use-case fails. This patch allows info.size_arg to be zero if no backing store is specified. Signed-off-by: Chris J Arges

[libvirt] [PATCH 2/2] tests: add vol-qcow2-zerocapacity test to storagevolxml2argvtest

Add a testcase for the previous change to ensure zero capacity volumes can be defined without a backing store. Signed-off-by: Chris J Arges chris.j.ar...@canonical.com --- tests/storagevolxml2argvdata/qcow2-zerocapacity.argv | 1 + tests/storagevolxml2argvtest.c | 3 +++

Re: [libvirt] [PATCH] storage: add RBD support to disk source pool translation

On 06/25/2015 09:16 PM, John Ferlan wrote: My assumption without doing too much thinking is that at some point the virStorageBackendRBDRefreshPool will reconnect for you in the storageDriverAutostart path... While not exactly the same, consider how the iSCSI pool handles uses the checkPool

Re: [libvirt] [PATCH] lxc: Bind mount container TTYs

On Wed, Jul 01, 2015 at 11:40:38AM +0200, Martin Kletzander wrote: On Tue, Jun 30, 2015 at 07:54:25PM +0200, Richard Weinberger wrote: Am 30.06.2015 um 19:12 schrieb Martin Kletzander: Hmm, very strange. What guest container are you using? I tried with a Debian jessi and had user namespace

Re: [libvirt] [PATCH] conf: qemu: Taint VMs using custom device tree blob

On Wed, Jul 01, 2015 at 10:48:41 +0200, Jiri Denemark wrote: On Fri, Jun 26, 2015 at 11:05:59 +0200, Peter Krempa wrote: Using a custom device tree image may cause unexpected behavior in architectures that use this approach to detect platform devices. Since usually the device tree is

Re: [libvirt] [PATCH] qemu: Resolve Coverity DEADCODE

On Wed, Jul 01, 2015 at 06:31:07AM -0400, John Ferlan wrote: Commit id 'f967e7a6' didn't place the closing parentheses quite right causing DEADCODE errors since the rc setting/comparison was wrong. Signed-off-by: John Ferlan jfer...@redhat.com --- src/qemu/qemu_hotplug.c | 2 +- 1 file

[libvirt] [PATCH] vz: assign static IPs and default gateways for network adapter

We support only one IPv4 and one IPv6 default gateway. If static IPs are not present in instance config, then we switch on DHCP for this adapter. PrlVmDevNet_SetAutoApply to makes necessary settings within guest OS In linux case it creates network startup scripts

Re: [libvirt] [PATCH 00/13] Move generic virsh data to a separate module vsh

This is rather big change. Do you perhaps have a public repo with all the patches applied? Michal I forked libvirt mirror repo on github and pushed as my local branch virt-shell https://github.com/eskultety/libvirt/tree/virt-shell. Erik -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] lxc: Bind mount container TTYs

Am 01.07.2015 um 11:40 schrieb Martin Kletzander: On Tue, Jun 30, 2015 at 07:54:25PM +0200, Richard Weinberger wrote: Am 30.06.2015 um 19:12 schrieb Martin Kletzander: Hmm, very strange. What guest container are you using? I tried with a Debian jessi and had user namespace enabled. Sorry

Re: [libvirt] [PATCH] lxc: Don't pass a local variable address randomly

On Wed, Jul 01, 2015 at 05:36:06PM +0200, Michal Privoznik wrote: So, recently I was testing the LXC driver. You know, startup some domains. But to my surprise, I was not able to start a single one: virsh # start --console test error: Reconnected to the hypervisor error: Failed to

Re: [libvirt] [PATCH 1/7] util: Resolve Coverity FORWARD_NULL

On Wed, Jul 01, 2015 at 10:03:45 -0400, John Ferlan wrote: Convert virPCIFile to return the buffer allocated (or not) and make the appropriate check in the caller. ACK, safe for freeze. I like the return-the-buffer semantic more. Peter signature.asc Description: Digital signature --

Re: [libvirt] [PATCH] lxc: Don't pass a local variable address randomly

On Wed, Jul 01, 2015 at 17:36:06 +0200, Michal Privoznik wrote: So, recently I was testing the LXC driver. You know, startup some domains. But to my surprise, I was not able to start a single one: virsh # start --console test error: Reconnected to the hypervisor error: Failed to start

Re: [libvirt] [PATCH 2/7] util: Resolve Coverity FORWARD_NULL

On Wed, Jul 01, 2015 at 10:03:46 -0400, John Ferlan wrote: Convert virPCIDriverFile to return the buffer allocated (or not) and make the appropriate check in the caller. Signed-off-by: John Ferlan jfer...@redhat.com --- src/util/virpci.c | 27 +++ 1 file changed,

Re: [libvirt] [PATCH 0/7] Address some Coverity found issues

On 07/01/2015 10:20 AM, Peter Krempa wrote: On Wed, Jul 01, 2015 at 10:03:44 -0400, John Ferlan wrote: The following Coverity issues are flagged in Coverity 7.6.1 compared to not being seen in 7.5.1 - this series just addresses those issues before 7.6.1 is installed in our upstream Jenkins

Re: [libvirt] [PATCH] Fix nodeinfo output on PPC64 KVM hosts

On Wed, 2015-07-01 at 19:26 +0530, Shivaprasad bhat wrote: I have posted the v2 as per your suggestions. Also added test case to test the nodeinfo. I moved the ioctl to a new function to help mocking it for testing. Only commit 1/2 seems to have made it to the list... Cheers. -- Andrea

[libvirt] [PATCH] lxc: Don't pass a local variable address randomly

So, recently I was testing the LXC driver. You know, startup some domains. But to my surprise, I was not able to start a single one: virsh # start --console test error: Reconnected to the hypervisor error: Failed to start domain test error: internal error: guest failed to start:

Re: [libvirt] [PATCH 3/7] util: Resolve Coverity FORWARD_NULL

On Wed, Jul 01, 2015 at 10:03:47 -0400, John Ferlan wrote: Convert virPCIDriverDir to return the buffer allocated (or not) and make the appropriate check in the caller. Signed-off-by: John Ferlan jfer...@redhat.com --- src/util/virpci.c | 15 +++ 1 file changed, 7

Re: [libvirt] [PATCH] virsh: report error if vcpu number exceed the guest maxvcpu number

On 06/28/2015 10:10 PM, Luyao Huang wrote: If usr pass a vcpu which exceed guest maxvcpu number, virsh client will only output an header like this: # virsh vcpupin test3 1000 VCPU: CPU Affinity -- After this patch: # virsh vcpupin test3 1000

[libvirt] [libvirt-glib PATCHv4 5/7] gobject: Add API to query connection networks

Add API to query networks from a connection. --- libvirt-gobject/libvirt-gobject-connection.c | 257 +++ libvirt-gobject/libvirt-gobject-connection.h | 13 +- libvirt-gobject/libvirt-gobject.sym | 6 + 3 files changed, 274 insertions(+), 2 deletions(-) diff

Re: [libvirt] [PATCH v2 2/4] virDomainObjSignal: drop this function

On 06/29/2015 11:17 AM, Pavel Hrdina wrote: There are multiple consumers for the domain condition and we should always wake them all. Signed-off-by: Pavel Hrdina phrd...@redhat.com --- src/conf/domain_conf.c | 7 --- src/conf/domain_conf.h | 1 - src/libvirt_private.syms | 1 -

[libvirt] [libvirt-glib PATCHv4 6/7] gobject: Add wrapper for virNetworkDHCPLease

--- libvirt-gobject/Makefile.am| 5 +- .../libvirt-gobject-network-dhcp-lease-private.h | 34 +++ .../libvirt-gobject-network-dhcp-lease.c | 252 + .../libvirt-gobject-network-dhcp-lease.h | 85 +++

[libvirt] [libvirt-glib PATCHv4 1/7] gobject: Simplify gvir_connection_list*() implementations

Make use of virConnectListAll* functions to avoid making 4 calls and hence avoid race conditions and complicated code. --- libvirt-gobject/libvirt-gobject-connection.c | 203 --- 1 file changed, 28 insertions(+), 175 deletions(-) diff --git

[libvirt] [libvirt-glib PATCHv4 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

--- libvirt-gobject/libvirt-gobject-network.c | 54 +++ libvirt-gobject/libvirt-gobject-network.h | 4 +++ libvirt-gobject/libvirt-gobject.sym | 2 ++ 3 files changed, 60 insertions(+) diff --git a/libvirt-gobject/libvirt-gobject-network.c

[libvirt] [libvirt-glib PATCHv4 4/7] gobject: Add API to query connection interfaces

Add API to query network interfaces from a connection. --- libvirt-gobject/libvirt-gobject-connection.c | 265 +++ libvirt-gobject/libvirt-gobject-connection.h | 13 +- libvirt-gobject/libvirt-gobject.sym | 7 + 3 files changed, 283 insertions(+), 2

[libvirt] [libvirt-glib PATCHv4 2/7] gobject: Plug 2 virConnect leaks

--- libvirt-gobject/libvirt-gobject-connection.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-connection.c b/libvirt-gobject/libvirt-gobject-connection.c index 1576906..dddbd3a 100644 --- a/libvirt-gobject/libvirt-gobject-connection.c

[libvirt] [libvirt-glib PATCHv4 3/7] gobject: Port GVirConnection to GTask

GSimpleAsyncResult has been deprecated in favour of GTask and with latest glib headers, we get tons of warnings about use of deprecated API. This patch ports the GVirConnection class to GTask. --- libvirt-gobject/libvirt-gobject-connection.c | 246 --- 1 file changed, 110

[libvirt] More coverage for networking API v4

I wasn't setting return values to GTask correctly in the v3. Fixed now. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 4/4] qemu_hotplug: try harder to eject media

On 06/29/2015 11:17 AM, Pavel Hrdina wrote: Some guests lock the tray and QEMU eject command will simply fail to eject the media. But the guest OS can handle this attempt to eject the media and can unlock the tray and open it. In this case, we should try again to actually eject the media.

[libvirt] Which symbols can be used in file paths in libvirt's XMLs?

Hello, There is an absFilePatch type in docs/schemas/basictypes.rng rng schema: define name=absFilePath data type=string param name=pattern/[a-zA-Z0-9_\.\+\-\\amp;quot;apos;lt;gt;/%,:]+/param /data /define There are quite few symbols in this set of the ones, which linux

Re: [libvirt] [PATCH 0/7] Address some Coverity found issues

On 07/01/2015 10:03 AM, John Ferlan wrote: ... John Ferlan (7): util: Resolve Coverity FORWARD_NULL util: Resolve Coverity FORWARD_NULL util: Resolve Coverity FORWARD_NULL Avoid Coverity FORWARD_NULL prior to strtok_r calls phyp: Resolve Coverity FORWARD_NULL util: Resolve

Re: [libvirt] [PATCH] lxc: Don't pass a local variable address randomly

On Wed, Jul 01, 2015 at 05:48:32PM +0200, Peter Krempa wrote: On Wed, Jul 01, 2015 at 17:36:06 +0200, Michal Privoznik wrote: So, recently I was testing the LXC driver. You know, startup some domains. But to my surprise, I was not able to start a single one: virsh # start --console

[libvirt] [PATCHv2 7/7 util: Avoid Coverity FORWARD_NULL

Avoid a false positive since Coverity find a path in virResizeN which could return 0 prior to the allocation of memory and thus flags a possible NULL dereference. Instead allocate the output buffer based on 'nparams' and only fill it partially if need be - shouldn't be too much a waste of space.

[libvirt] [PATCH] Inherit namespace feature

This patch adds feature for lxc containers to inherit namespaces. This is very similar to what lxc-tools or docker provides. Look for man lxc-start and you will find that you can pass command args as [ --share-[net|ipc|uts] name|pid ]. Or check out docker networking option in which you can

[libvirt] How to define QEMU/SMBIOS Attributes in virsh

Hello, I have a request for Help please. Myself: I'm a native german language speaker and I' work with qemu/virsh since 6 months now. At the moment I try to define/configure qemu/smbios attributes in a virsh xml-file. My current problem: I need to configure two on-board lan elements. Thanks to

Re: [libvirt] [[PATCH v5] autocreate tap device for VIR_DOMAIN_NET_TYPE_ETHERNET] autocreate tap device for VIR_DOMAIN_NET_TYPE_ETHERNET

On 01.07.2015 09:29, Vasiliy Tolstov wrote: 2015-06-18 15:27 GMT+03:00 Vasiliy Tolstov v.tols...@selfip.ru: This new version applies to master and have fix for setting mac address for tap device after creation. Any news? I have v6 applied locally. But before pushing there are some

Re: [libvirt] [[PATCH v5] autocreate tap device for VIR_DOMAIN_NET_TYPE_ETHERNET] autocreate tap device for VIR_DOMAIN_NET_TYPE_ETHERNET

2015-06-18 15:27 GMT+03:00 Vasiliy Tolstov v.tols...@selfip.ru: This new version applies to master and have fix for setting mac address for tap device after creation. Any news? -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] qemu: agent: Don't automatically disable CPU0 via guest agent

On Tue, Jun 30, 2015 at 18:51:02 +0200, Martin Kletzander wrote: On Fri, Jun 26, 2015 at 03:01:44PM +0200, Peter Krempa wrote: While CPU0 was made unpluggable in Linux a while ago it's not desirable to unplug it since some parts of the kernel (suspend-to-ram) still depend on it. This patch

Re: [libvirt] [PATCH] qemu: Avoid using .(null) in UNIX socket path

On Tue, Jun 30, 2015 at 16:04:23 +0200, Michal Privoznik wrote: On 30.06.2015 13:49, Jiri Denemark wrote: The code which generates paths for UNIX socket blindly used target name without checking if it was set. Thus for the following device XML channel type='unix' source

Re: [libvirt] [PATCHv2 7/7 util: Avoid Coverity FORWARD_NULL

On Wed, Jul 01, 2015 at 12:41:23 -0400, John Ferlan wrote: Avoid a false positive since Coverity find a path in virResizeN which could return 0 prior to the allocation of memory and thus flags a possible NULL dereference. Instead allocate the output buffer based on 'nparams' and only fill it

Re: [libvirt] [PATCH] virsh: report error if vcpu number exceed the guest maxvcpu number

On 07/02/2015 04:29 AM, John Ferlan wrote: On 06/28/2015 10:10 PM, Luyao Huang wrote: If usr pass a vcpu which exceed guest maxvcpu number, virsh client will only output an header like this: # virsh vcpupin test3 1000 VCPU: CPU Affinity -- After this

Re: [libvirt] [PATCH v2 2/2] Allow PCI virtio on ARM virt machine

On 06/30/2015 02:47 AM, Pavel Fedin wrote: Hello! Unfortunately thinking about this some more, the current patch approach might not be acceptable as is, since current distros as a guest don't support -M virt with PCI... for example Fedora 21 or 22. How can this be? If qemu version is

Re: [libvirt] [PATCH] Revert Introduce QEMU_CAPS_ARM_VIRT_PCI

On 06/30/2015 06:01 AM, Michal Privoznik wrote: On 29.06.2015 09:58, Peter Krempa wrote: The capability was not used up to the feature freeze. This reverts commit 7f3515b4bb677d0ead1887547efc844e4761268a. --- src/qemu/qemu_capabilities.c | 4 src/qemu/qemu_capabilities.h | 1 - 2

Re: [libvirt] [PATCH] qemu: fix not end the job after use OpenGraphics(FD) and get fail when exit monitor

On Tue, Jun 30, 2015 at 11:35:13AM +0800, Luyao Huang wrote: If guest unexpect exit(qemu process be killed) and get failed when exit the monitor, guest job still handled by old function, this will make guest cannot start later. Need call qemuDomainObjEndJob to release job status before unref vm.