[libvirt] [PATCH v3] qemu: Use heads parameter for QXL driver

2015-07-06 Thread Frediano Ziglio
Allows to specify maximum number of head to QXL driver. The patch to support the max_outputs in Qemu is still not merged but I got agreement on the name of the argument. Actually can be a compatiblity problem as heads in the XML configuration was set by default to '1'. Signed-off-by: Frediano

Re: [libvirt] [PATCH v2 2/2] Allow PCI virtio on ARM virt machine

2015-07-06 Thread Gerd Hoffmann
Hi, I am working on tests, and i have discovered some issues with my current implementation. Whether i concentrate my efforts on fixing them or just redo everything from scratch, depends on what you say no. So what is the final verdict? Should we: a) Change the default to PCI, for

Re: [libvirt] [PATCH v2 2/2] Allow PCI virtio on ARM virt machine

2015-07-06 Thread Pavel Fedin
Hi! Clearly (b). For the default it is important that it is backward compatible (to older libvirt versions) and works with as many guests as possible. One very last counter-argument... Actually, even if we change our default, we are still backwards-compatible, because older libvirt

Re: [libvirt] [PATCH 03/10] qemu: Refactor creation of shared memory device commandline

2015-07-06 Thread lhuang
On 07/06/2015 01:38 PM, Martin Kletzander wrote: On Mon, Jul 06, 2015 at 10:23:59AM +0800, lhuang wrote: On 07/03/2015 08:56 PM, Martin Kletzander wrote: On Wed, Jun 17, 2015 at 11:56:14AM +0800, Luyao Huang wrote: Rename qemuBuildShmemDevCmd to qemuBuildShmemDevStr and change the return

[libvirt] [PATCH RESEND] Added support for portable-rpcgen from portablexdr library

2015-07-06 Thread Pavel Fedin
This patch allows to build libvirt natively under MinGW/MSYS using portablexdr library. An updated version of portablexdr with fixed bugs is available as part of MSYS2 project. Signed-off-by: Pavel Fedin p.fe...@samsung.com --- configure.ac | 2 +-

Re: [libvirt] [PATCH v2 2/2] Allow PCI virtio on ARM virt machine

2015-07-06 Thread Pavel Fedin
Hello! I'm talking about the distro kernel as a guest. My understanding is that Fedora 21/22 AArch64 does _not_ work with virtio-pci, but it does work with virtio-mmio. But I've yet to confirm yet... arm64 has no generic pci host support yet (as of upstream kernel 4.1). arm has it for

Re: [libvirt] [PATCH v3 1/2] Fix nodeinfo output on PPC64 KVM hosts

2015-07-06 Thread Shivaprasad bhat
Thanks a lot Andrea. The cleanups are really nice. I had a chance to test the patch and it seems to work consistently in all sucores_per_core modes. Only two comments written inline . Thanks and Regards, Shiva On Fri, Jul 3, 2015 at 5:57 PM, Andrea Bolognani abolo...@redhat.com wrote: From:

[libvirt] [PATCH v3 3/3] Build correct command line for PCI NICs on ARM

2015-07-06 Thread Pavel Fedin
Legacy -net option works correctly only with embedded device models, which do not require any bus specification. Therefore, we should use -device for PCI hardware Signed-off-by: Pavel Fedin p.fe...@samsung.com --- src/qemu/qemu_command.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [libvirt] [PATCH v2] vz: fix building capabilities

2015-07-06 Thread Maxim Nestratov
03.07.2015 20:26, Dmitry Guryanov пишет: There should be at least one domain for each guest in cababilities. And in current code we don't add domain for this guest for example. if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_HVM,

[libvirt] [PATCH v3 0/3] Allow PCI virtio on ARM virt machine

2015-07-06 Thread Pavel Fedin
Virt machine in qemu since v2.3.0 has PCI generic host controller, and can use PCI devices. This provides performance improvement as well as vhost-net with irqfd support for virtio-net. However libvirt currently does not allow ARM virt machine to have PCI devices. This patchset adds the necessary

[libvirt] [PATCH v3 2/3] Add PCI-Express root to ARM virt machine

2015-07-06 Thread Pavel Fedin
Add PCI Express root complex if the corresponding capability is present Signed-off-by: Pavel Fedin p.fe...@samsung.com --- src/qemu/qemu_domain.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index

[libvirt] [PATCH v3 1/3] Introduce QEMU_CAPS_ARM_VIRT_PCI

2015-07-06 Thread Pavel Fedin
This capability specifies that virt machine on ARM has PCI controller. Enabled when qemu version is at least 2.3.0. Signed-off-by: Pavel Fedin p.fe...@samsung.com --- src/qemu/qemu_capabilities.c | 5 + src/qemu/qemu_capabilities.h | 1 + 2 files changed, 6 insertions(+) diff --git

Re: [libvirt] [PATCH v2] vz: fix building capabilities

2015-07-06 Thread Dmitry Guryanov
On 07/06/2015 03:45 PM, Maxim Nestratov wrote: 03.07.2015 20:26, Dmitry Guryanov пишет: There should be at least one domain for each guest in cababilities. And in current code we don't add domain for this guest for example. if ((guest = virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_HVM,

Re: [libvirt] [libvirt-glib PATCHv4 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

2015-07-06 Thread Christophe Fergeau
On Wed, Jul 01, 2015 at 09:40:51PM +0100, Zeeshan Ali (Khattak) wrote: --- libvirt-gobject/libvirt-gobject-network.c | 54 +++ libvirt-gobject/libvirt-gobject-network.h | 4 +++ libvirt-gobject/libvirt-gobject.sym | 2 ++ 3 files changed, 60

Re: [libvirt] [libvirt-glib PATCHv4 1/7] gobject: Simplify gvir_connection_list*() implementations

2015-07-06 Thread Christophe Fergeau
On Wed, Jul 01, 2015 at 09:40:45PM +0100, Zeeshan Ali (Khattak) wrote: Make use of virConnectListAll* functions to avoid making 4 calls and hence avoid race conditions and complicated code. Fwiw, I would have split this in 2, one for domains, and one for pools, but fine this way too, ACK.

Re: [libvirt] [libvirt-glib PATCHv4 2/7] gobject: Plug 2 virConnect leaks

2015-07-06 Thread Christophe Fergeau
Please be a bit more verbose in the commit log as to what the leak is. (a virConnect reference is leaked in error cases, the unref is moved after the label we jump to on errors to avoid the leak) Looks good otherwise, Christophe On Wed, Jul 01, 2015 at 09:40:46PM +0100, Zeeshan Ali (Khattak)

[libvirt] [PATCH v2 00/10] Restore code to allow unpriv_sgio for hostdev SCSI generic

2015-07-06 Thread John Ferlan
v1 here: http://www.redhat.com/archives/libvir-list/2015-June/msg00814.html Changes since v1: - Add doc patch 1 to indicate that this feature may only be supported by certain kernels - Adjust former patch 1 to add call to qemuIsSharedHostdev from qemuSetUnprivSGIO - Insert patches 7 8 which

[libvirt] [PATCH v2 01/10] docs: Clarify unprivileged sgio feature for host devices

2015-07-06 Thread John Ferlan
Not all kernels support SG_IO for host devices, so let's indicate so Signed-off-by: John Ferlan jfer...@redhat.com --- docs/formatdomain.html.in | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index ea2fff8..0fc5d85

[libvirt] [PATCH v2 09/10] qemu: Add ability to set sgio values for hostdev

2015-07-06 Thread John Ferlan
Add necessary checks in order to allow setting sgio values for a scsi host device Signed-off-by: John Ferlan jfer...@redhat.com --- src/qemu/qemu_conf.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index

[libvirt] [PATCH v2 07/10] qemu: Refactor qemuSetUnprivSGIO return values

2015-07-06 Thread John Ferlan
Set to ret = -1 and prove otherwise, like usual Signed-off-by: John Ferlan jfer...@redhat.com --- src/qemu/qemu_conf.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 80b8926..5ebf2cc 100644 ---

[libvirt] [PATCH v2 08/10] qemu: Fix integer/boolean logic in qemuSetUnprivSGIO

2015-07-06 Thread John Ferlan
Setting of 'val' is a boolean expression, so handle it that way and adjust the check/return logic to be clearer Signed-off-by: John Ferlan jfer...@redhat.com --- src/qemu/qemu_conf.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_conf.c

[libvirt] [PATCH v2 03/10] qemu: Introduce qemuGetHostdevPath

2015-07-06 Thread John Ferlan
Introduce a convenience function to handle formulating the hostdev path Signed-off-by: John Ferlan jfer...@redhat.com --- src/qemu/qemu_conf.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index

[libvirt] [PATCH v2 06/10] qemu: Extract qemuGetHostdevPath from qemuGetSharedHostdevKey

2015-07-06 Thread John Ferlan
The device path will be necessary for any future patch to allow sgio settings on a hostdev Signed-off-by: John Ferlan jfer...@redhat.com --- src/qemu/qemu_conf.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_conf.c

[libvirt] [PATCH v2 04/10] qemu: Refactor qemuCheckSharedDisk to create virCheckUnprivSGIO

2015-07-06 Thread John Ferlan
Split out the SGIO check for sharing with hostdev in future patches Signed-off-by: John Ferlan jfer...@redhat.com --- src/qemu/qemu_conf.c | 88 ++-- 1 file changed, 57 insertions(+), 31 deletions(-) diff --git a/src/qemu/qemu_conf.c

[libvirt] [PATCH v2 02/10] qemu: Introduce qemuIsSharedHostdev

2015-07-06 Thread John Ferlan
Add a single boolean function to handle whether the hostdev is shared or not. Use the new function for the qemu{Add|Remove}SharedHostdev calls as well as qemuSetUnprivSGIO. NB: This second usage fixes a possible bug where if this feature is enabled at some time in the future and the shareable

[libvirt] [PATCH v2 10/10] qemu: Add check for unpriv sgio for SCSI generic host device

2015-07-06 Thread John Ferlan
Check if the hostdev has set the sgio filtered/unfiltered and handle appropriately. This restores functionality removed by commit id 'ce346623' to remove sgio support for the SCSI generic host device. For most kernels the result of this operation is a no-op; however, for those that do support it

[libvirt] [PATCH v2 05/10] qemu: Refactor qemuAddSharedHostdev and qemuRemoveSharedHostdev

2015-07-06 Thread John Ferlan
Refactor the functions to follow logic from qemuAddSharedDisk and qemuRemoveSharedDisk with respect to locking driver. Signed-off-by: John Ferlan jfer...@redhat.com --- src/qemu/qemu_conf.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git

Re: [libvirt] [libvirt-glib PATCHv4 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

2015-07-06 Thread Zeeshan Ali (Khattak)
On Mon, Jul 6, 2015 at 6:05 PM, Christophe Fergeau cferg...@redhat.com wrote: On Wed, Jul 01, 2015 at 09:40:51PM +0100, Zeeshan Ali (Khattak) wrote: --- libvirt-gobject/libvirt-gobject-network.c | 54 +++ libvirt-gobject/libvirt-gobject-network.h | 4 +++

Re: [libvirt] [libvirt-glib PATCHv4 6/7] gobject: Add wrapper for virNetworkDHCPLease

2015-07-06 Thread Christophe Fergeau
On Wed, Jul 01, 2015 at 09:40:50PM +0100, Zeeshan Ali (Khattak) wrote: diff --git a/libvirt-gobject/libvirt-gobject.sym b/libvirt-gobject/libvirt-gobject.sym index 88ca271..d345813 100644 --- a/libvirt-gobject/libvirt-gobject.sym +++ b/libvirt-gobject/libvirt-gobject.sym @@ -287,6 +287,19

Re: [libvirt] [PATCH] vz: assign static IPs and default gateways for network adapter

2015-07-06 Thread Dmitry Guryanov
On 07/01/2015 01:15 PM, Mikhail Feoktistov wrote: We support only one IPv4 and one IPv6 default gateway. If static IPs are not present in instance config, then we switch on DHCP for this adapter. PrlVmDevNet_SetAutoApply to makes necessary settings within guest OS In linux case it creates

[libvirt] [PATCH] vz: use PRL_USE_VNET_NAME_FOR_BRIDGE_NAME

2015-07-06 Thread Maxim Nestratov
It is better not to assume that newly created network should be connected to a bridge with same name, but specify it explicitly by PRL_USE_VNET_NAME_FOR_BRIDGE_NAME flag. Signed-off-by: Maxim Nestratov mnestra...@virtuozzo.com --- src/vz/vz_sdk.c |4 +++- 1 files changed, 3 insertions(+), 1

[libvirt] [PATCH] libxl: support dom0

2015-07-06 Thread Jim Fehlig
In Xen, dom0 is really just another domain that supports ballooning, adding/removing devices, changing vcpu configuration, etc. This patch adds support to the libxl driver for managing dom0. Note that the legacy xend driver has long supported managing dom0. Operations that are not supported on

Re: [libvirt] [PATCH] libxl: support dom0

2015-07-06 Thread Jim Fehlig
On 07/06/2015 03:46 PM, Jim Fehlig wrote: In Xen, dom0 is really just another domain that supports ballooning, adding/removing devices, changing vcpu configuration, etc. This patch adds support to the libxl driver for managing dom0. Note that the legacy xend driver has long supported managing

Re: [libvirt] [PATCH v3] nodeinfo: fix to parse present cpus rather than possible cpus

2015-07-06 Thread John Ferlan
On 06/26/2015 06:27 PM, Kothapally Madhu Pavan wrote: Currently we are parsing all the possible cpus to get the nodeinfo. This fix will perform a check for present cpus before parsing. Signed-off-by: Kothapally Madhu Pavan k...@linux.vnet.ibm.com --- src/nodeinfo.c | 11

Re: [libvirt] [PATCH 2/3] Qemu: add CMT support

2015-07-06 Thread Prerna
On Sun, Jul 5, 2015 at 5:13 PM, Qiaowei Ren qiaowei@intel.com wrote: One RFC in https://www.redhat.com/archives/libvir-list/2015-June/msg01509.html CMT (Cache Monitoring Technology) can be used to measure the usage of cache by VM running on the host. This patch will extend the bulk