On Mon, Jul 13, 2015 at 03:47:29PM -0400, John Ferlan wrote:
On 07/09/2015 10:09 AM, Martin Kletzander wrote:
The comment above that function says: This function can be a lot more
exhaustive, ..., so let's be.
Check for collisions between routes in the system and static routes
being added
On Fri, Jul 10, 2015 at 04:28:46PM -0300, Marcelo Ricardo Leitner wrote:
Hi,
(I'm not subscribed to the list, please keep me on Cc)
I'm attempting to get a serial link between two guests, same hypervisor.
The only practical way I could find is to add a serial port using a pty
to a guest and
On Mon, Jul 13, 2015 at 06:16:25PM +0200, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1232663
In one of my previous ptaches (bcd9a564) I've tried to fix the problem
that we blindly assumed strict NUMA mode for guests. This led to
several problems like us pinning a domain
On Fri, Jul 10, 2015 at 7:21 PM, John Ferlan jfer...@redhat.com wrote:
On 07/10/2015 09:04 AM, Shivaprasad bhat wrote:
Hi John,
Thanks for the comments.
On Thu, Jul 9, 2015 at 9:16 PM, John Ferlan jfer...@redhat.com wrote:
On 07/07/2015 03:25 AM, Andrea Bolognani wrote:
Changes from v3
On Tue, 2015-07-14 at 14:56 +0530, Shivaprasad bhat wrote:
As you could see in the series I referenced - there are a number of
nodeinfo.c API's which don't process the sysfs properly, e.g. they
assume /sys/devices/system.
I haven't been fully convinced that the patch which ends up as
The first patch builds on the sysfs_prefix work by John,
while the the second one contains unrelated formatting
changes that increase internal consistency.
Neither introduces behavioral changes.
Andrea Bolognani (2):
nodeinfo: Make sysfs_prefix usage more consistent
nodeinfo: Formatting
Make sure sysfs_prefix, when present, is always the first argument
to a function; don't use a different name to refer to it; check
whether it is NULL, and hence SYSFS_SYSTEM_PATH should be used, only
when using it directly and not just passing it down to another
function; always pass down the same
---
src/nodeinfo.c | 36
1 file changed, 20 insertions(+), 16 deletions(-)
diff --git a/src/nodeinfo.c b/src/nodeinfo.c
index 60dfc8b..c874fa6 100644
--- a/src/nodeinfo.c
+++ b/src/nodeinfo.c
@@ -208,7 +208,7 @@ freebsdNodeGetCPUStats(int cpuNum,
static
We used to look at the librbd code version and depending on that
we would invoke rbd_create3() or rbd_create().
Since librbd version 0.67.9 we can however tell RBD that it should
create rbd format 2 images even if we invoke rbd_create().
The less options we pass to librbd, the more we can lean
On Sat, Jun 06, 2015 at 07:36:48PM +, Ossi Herrala wrote:
Use I/O vector (iovec) instead of one huge memory buffer as suggested
in https://bugzilla.redhat.com/show_bug.cgi?id=1026137#c7. This avoids
doing memmove() to big buffers and performance doesn't degrade if
source
Polite ping...
On 07/07/2015 05:30 PM, Boris Fiuczynski wrote:
Adding support and a test for virtio-9p-ccw.
Changing the default from virtio-9p-pci to virtio-9p-ccw for
s390-ccw-virtio machines.
Boris Fiuczynski (3):
qemu: Support for virtio-9p-ccw
qemu: Make virtio-9p-ccw the default
After upgrade to perl-5.22.0, it started complaining about one of our
scripts. The thing is that even though it works, it wants all curly
brackets escaped properly. The change is not functional, it merely gets
rid of the following error:
Unescaped left brace in regex is deprecated, passed
On Tue, Jul 14, 2015 at 13:50:24 +0200, Ján Tomko wrote:
s/baloon/balloon/ in the subject
On Wed, Jul 01, 2015 at 10:13:27AM +0200, Peter Krempa wrote:
In commit 641a145d73fdc3dd9350fd57b3d3247abf101c05 I've added code that
resets the ballon memory value to full size prior to resuming the
As there is a regression in use vcpupin get info, introduce a new function
to test the virsh client.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/test/test_driver.c | 55 ++
tests/vcpupin | 34 +++
2
On 07/10/2015 07:51 AM, Cédric Bosdonnat wrote:
The virLXCControllerAppendNBDPids function didn't properly initialize
pids and npids. In case of failure it was crashing when freeing those.
The nbd device pid file doesn't appear immediately after starting
qemu-nbd: adding a small loop to
I was so ashamed of writing a incorrect commit '848ab68' and didn't test with
it. Patch 1/2 fix the issue and Patch 2/2 introduce a test for it.
Luyao Huang (2):
virsh: really fix the error if vcpu number exceed the guest maxvcpu
number
test: introduce a function in test driver for check
Some background:
Looking @ the comments in
https://review.openstack.org/#/c/192736/8/nova/virt/libvirt/driver.py
we need a way to construct the fully qualified path for a 'network' type
disk
which can then be passed to qemu-img for the rebase cmd.
Checking with some folks offline and on IRC,
Commit '848ab68' left a issue: when we try to get a vcpupin info with no
no flags or --current flags, we still will get the wrong error. Because
VIR_DOMAIN_AFFECT_CURRENT is 0, so this check flags VIR_DOMAIN_AFFECT_CURRENT
will always get false.
Signed-off-by: Luyao Huang lhu...@redhat.com
s/baloon/balloon/ in the subject
On Wed, Jul 01, 2015 at 10:13:27AM +0200, Peter Krempa wrote:
In commit 641a145d73fdc3dd9350fd57b3d3247abf101c05 I've added code that
resets the ballon memory value to full size prior to resuming the vCPUs
s/ballon/balloon/
since the size certainly was not
Hi,
On Tue, Jul 14, 2015 at 09:52:12AM +0200, Martin Kletzander wrote:
On Fri, Jul 10, 2015 at 04:28:46PM -0300, Marcelo Ricardo Leitner wrote:
Hi,
(I'm not subscribed to the list, please keep me on Cc)
I'm attempting to get a serial link between two guests, same hypervisor.
The only
title:
s/baloon/balloon
On 07/01/2015 04:13 AM, Peter Krempa wrote:
In commit 641a145d73fdc3dd9350fd57b3d3247abf101c05 I've added code that
resets the ballon memory value to full size prior to resuming the vCPUs
s/ballon/balloon
ACK with all the incorrect spellings fixed (including one
The commit 7e72de4 didn't consider the hotplug scenarios. The patch addresses
the hotplug case whereby if atleast one of the pci function is owned by a
guest, the hotplug of other functions/devices in the same iommu group to the
same guest goes through successfully.
Signed-off-by: Shivaprasad G
On 07/10/2015 05:07 AM, Martin Kletzander wrote:
Commit ed8155eafbff5c5ca0bdfe84a8388f58b718c2f9 documented that
mhz field in virNodeInfo might be 0 if the frequency is unknown. Modify
virsh to know about that.
While 0 may be (or is) an invalid value would it perhaps be better to
document
On 06/18/2015 04:45 AM, Moshe Levi wrote:
Adding functionality to libvirt that will allow
it query the interface for the availability of RDMA and
tx-udp_tnl-segmentation Offloading NIC capabilities
Any chance for a shorter name? Eg txudptnl (
Here is an example of the feature XML
There's this condition:
flags VIR_DOMAIN_AFFECT_CURRENT virDomainIsActive(dom)
which can never be true since VIR_DOMAIN_AFFECT_CURRENT has hardcoded
value of zero. Therefore virDomainIsActive() is a dead code. However,
the condition could make sense if it is rewritten as the following:
*** BLURB HERE ***
Michal Privoznik (2):
qemuMigrationRun: Don't leak @fd
cmdVcpuPin: Remove dead code
src/qemu/qemu_migration.c | 2 +-
tools/virsh-domain.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.3.6
--
libvir-list mailing list
libvir-list@redhat.com
On 07/14/2015 10:37 AM, Michal Privoznik wrote:
There's this condition:
flags VIR_DOMAIN_AFFECT_CURRENT virDomainIsActive(dom)
which can never be true since VIR_DOMAIN_AFFECT_CURRENT has hardcoded
value of zero. Therefore virDomainIsActive() is a dead code. However,
the condition
On Mon, Jun 15, 2015 at 08:36:47PM -0600, Jim Fehlig wrote:
Similar to commit 540c339a for the QEMU driver, rework reference
counting in the libxl driver to make it more deterministic and
the code a bit cleaner.
Signed-off-by: Jim Fehlig jfeh...@suse.com
---
I've been testing this patch on and
Eric Blake ebl...@redhat.com writes:
On 07/03/2015 12:01 AM, sba...@catern.com wrote:
Has there been any thought given to supporting remote connections to
QEMU session instances in virt-manager?
(i.e. qemu+ssh://hostname/session?socket=path) Manually hacking in the
URI with dconf seems to
On Tue, Jul 14, 2015 at 08:25:27AM -0300, Marcelo Ricardo Leitner wrote:
Hi,
On Tue, Jul 14, 2015 at 09:52:12AM +0200, Martin Kletzander wrote:
On Fri, Jul 10, 2015 at 04:28:46PM -0300, Marcelo Ricardo Leitner wrote:
Hi,
(I'm not subscribed to the list, please keep me on Cc)
I'm attempting
On Tue, Jul 14, 2015 at 05:58:05PM +0200, Martin Kletzander wrote:
On Tue, Jul 14, 2015 at 08:25:27AM -0300, Marcelo Ricardo Leitner wrote:
Hi,
On Tue, Jul 14, 2015 at 09:52:12AM +0200, Martin Kletzander wrote:
On Fri, Jul 10, 2015 at 04:28:46PM -0300, Marcelo Ricardo Leitner wrote:
Hi,
If we are migrating to an UNIX socket, we accept() a connection
from qemu and use that FD to set up a tunnel. However, the FD is
not closed as often as it should be.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/qemu/qemu_migration.c | 2 +-
1 file changed, 1 insertion(+), 1
On 07/02/2015 04:30 AM, Michal Privoznik wrote:
Some drivers don't expose available huge page sizes in the
capabilities XML. For instance, LXC driver is one of those.
This has a downside that when virsh is trying to get
aggregated info on free pages per all NUMA nodes, it fails.
The problem
On 07/14/2015 04:15 AM, Wido den Hollander wrote:
We used to look at the librbd code version and depending on that
we would invoke rbd_create3() or rbd_create().
Since librbd version 0.67.9 we can however tell RBD that it should
create rbd format 2 images even if we invoke rbd_create().
On 07/14/2015 12:42 PM, John Ferlan wrote:
On 07/14/2015 04:15 AM, Wido den Hollander wrote:
We used to look at the librbd code version and depending on that
we would invoke rbd_create3() or rbd_create().
Since librbd version 0.67.9 we can however tell RBD that it should
create rbd format 2
On 07/14/2015 05:40 AM, Andrea Bolognani wrote:
The first patch builds on the sysfs_prefix work by John,
while the the second one contains unrelated formatting
changes that increase internal consistency.
Neither introduces behavioral changes.
Andrea Bolognani (2):
nodeinfo: Make
On 07/14/2015 09:10 AM, Luyao Huang wrote:
Commit '848ab68' left a issue: when we try to get a vcpupin info with no
no flags or --current flags, we still will get the wrong error. Because
VIR_DOMAIN_AFFECT_CURRENT is 0, so this check flags
VIR_DOMAIN_AFFECT_CURRENT
will always get false.
On 07/15/2015 05:21 AM, John Ferlan wrote:
On 07/14/2015 09:10 AM, Luyao Huang wrote:
Commit '848ab68' left a issue: when we try to get a vcpupin info with no
no flags or --current flags, we still will get the wrong error. Because
VIR_DOMAIN_AFFECT_CURRENT is 0, so this check flags
As of fedora polkit-0.113-2, polkit-devel only pulls in polkit-libs, not
full polkit, but we need the latter for pkcheck otherwise our configure
test fails.
---
libvirt.spec.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 0adf55e..40d2ccb 100644
39 matches
Mail list logo
