Re: [libvirt] [PATCH 4/5] conf: Refactor virDomainDiskDefParseXML to pass vmdef

2015-07-21 Thread Ján Tomko
On Thu, Jul 16, 2015 at 11:24:33AM -0400, John Ferlan wrote: On 07/16/2015 08:03 AM, Ján Tomko wrote: On Mon, Jun 22, 2015 at 05:05:06PM -0400, John Ferlan wrote: Rather than passing the def-seclabels and def-nseclabels, refactor the API to pass the entire domain definition. This will

[libvirt] ANNOUNCE: libguestfs 1.30 released

2015-07-21 Thread Richard W.M. Jones
I'm pleased to announce libguestfs 1.30, a library and set of tools for accessing and modifying virtual machine disk images. This release took 9 months of work by a considerable number of people, and has many new features (see release notes below). You can get libguestfs 1.30 here: Main

Re: [libvirt] [PATCH] cgroup: Drop resource partition from virSystemdMakeScopeName

2015-07-21 Thread Daniel P. Berrange
On Mon, Jul 20, 2015 at 11:10:18AM +0200, Peter Krempa wrote: On Fri, Jul 17, 2015 at 15:40:31 +0100, Daniel Berrange wrote: On Thu, Jul 16, 2015 at 04:18:08PM +0200, Peter Krempa wrote: The scope name, even according to our docs is machine-$DRIVER\x2d$VMNAME.scope virSystemdMakeScopeName

Re: [libvirt] [Spice-devel] [PATCH v4] qemu: Use heads parameter for QXL driver

2015-07-21 Thread Laine Stump
On 07/21/2015 09:41 AM, Daniel P. Berrange wrote: On Tue, Jul 21, 2015 at 03:35:50PM +0200, Martin Kletzander wrote: On Tue, Jul 21, 2015 at 01:50:22PM +0100, Daniel P. Berrange wrote: On Tue, Jul 21, 2015 at 11:44:27AM +0200, Martin Kletzander wrote: On Tue, Jul 21, 2015 at 09:36:55AM +0200,

Re: [libvirt] [PATCH glib] Remove dep on libvirt 1.2.6

2015-07-21 Thread Christophe Fergeau
On Tue, Jul 21, 2015 at 03:20:02PM +0100, Daniel P. Berrange wrote: Going back on what I said a few hours ago On closer inspection, I re-discovered that we have already taken the approach of conditionally compiling code in libvirt-gobject to avoid increasing the min libvirt. So given

Re: [libvirt] [PATCH glib] Make use of DHCP API conditionally compiled

2015-07-21 Thread Zeeshan Ali (Khattak)
On Tue, Jul 21, 2015 at 3:20 PM, Daniel P. Berrange berra...@redhat.com wrote: Previously the use of virDomainOpenGraphicsFD API from libvirt 1.2.8 was made to be conditionally compiled. Given this past practice, make use of the virNetworkGetDHCPLeases API conditional too, rather than

Re: [libvirt] [Spice-devel] [PATCH v4] qemu: Use heads parameter for QXL driver

2015-07-21 Thread Daniel P. Berrange
On Tue, Jul 21, 2015 at 11:34:08AM -0400, Laine Stump wrote: On 07/21/2015 09:41 AM, Daniel P. Berrange wrote: On Tue, Jul 21, 2015 at 03:35:50PM +0200, Martin Kletzander wrote: On Tue, Jul 21, 2015 at 01:50:22PM +0100, Daniel P. Berrange wrote: On Tue, Jul 21, 2015 at 11:44:27AM +0200,

Re: [libvirt] [PATCH glib] Make use of DHCP API conditionally compiled

2015-07-21 Thread Christophe Fergeau
Hi, On Tue, Jul 21, 2015 at 03:20:03PM +0100, Daniel P. Berrange wrote: Previously the use of virDomainOpenGraphicsFD API from libvirt 1.2.8 was made to be conditionally compiled. Given this past practice, make use of the virNetworkGetDHCPLeases API conditional too, rather than requiring

Re: [libvirt] [PATCH] spec: Fix polkit dep on F23

2015-07-21 Thread Cole Robinson
On 07/17/2015 10:15 AM, Daniel P. Berrange wrote: On Tue, Jul 14, 2015 at 02:44:59PM -0400, Cole Robinson wrote: As of fedora polkit-0.113-2, polkit-devel only pulls in polkit-libs, not full polkit, but we need the latter for pkcheck otherwise our configure test fails. --- libvirt.spec.in |

[libvirt] ANNOUNCE: libvirt-glib version 0.2.2 released

2015-07-21 Thread Daniel P. Berrange
I am pleased to announce that a new release of the libvirt-glib package, version 0.2.2, is now available from ftp://libvirt.org/libvirt/glib/ The packages are GPG signed with Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) Changes in this release: - Add API

Re: [libvirt] [PATCH 5/5] conf: Check for hostdev conflicts when assign default disk address

2015-07-21 Thread Ján Tomko
On Thu, Jul 16, 2015 at 11:57:52AM -0400, John Ferlan wrote: On 07/16/2015 08:23 AM, Ján Tomko wrote: On Mon, Jun 22, 2015 at 05:05:07PM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1210587 (completed) When generating the default drive address for a SCSI disk

Re: [libvirt] [PATCH glib] Make use of DHCP API conditionally compiled

2015-07-21 Thread Daniel P. Berrange
On Tue, Jul 21, 2015 at 04:55:15PM +0200, Christophe Fergeau wrote: Hi, On Tue, Jul 21, 2015 at 03:20:03PM +0100, Daniel P. Berrange wrote: Previously the use of virDomainOpenGraphicsFD API from libvirt 1.2.8 was made to be conditionally compiled. Given this past practice, make use of

Re: [libvirt] [PATCH glib] Make use of DHCP API conditionally compiled

2015-07-21 Thread Daniel P. Berrange
On Tue, Jul 21, 2015 at 03:56:54PM +0100, Zeeshan Ali (Khattak) wrote: On Tue, Jul 21, 2015 at 3:20 PM, Daniel P. Berrange berra...@redhat.com wrote: Previously the use of virDomainOpenGraphicsFD API from libvirt 1.2.8 was made to be conditionally compiled. Given this past practice, make

Re: [libvirt] [PATCH] spec: Fix polkit dep on F23

2015-07-21 Thread Daniel P. Berrange
On Tue, Jul 21, 2015 at 12:12:03PM -0400, Cole Robinson wrote: On 07/17/2015 10:15 AM, Daniel P. Berrange wrote: On Tue, Jul 14, 2015 at 02:44:59PM -0400, Cole Robinson wrote: As of fedora polkit-0.113-2, polkit-devel only pulls in polkit-libs, not full polkit, but we need the latter for

[libvirt] [PATCH] configure: clarify rationale for checking pkcheck

2015-07-21 Thread Daniel P. Berrange
We don't need pkcheck binary, but we must detect it in order to see if we're preferring polkit-1 over polkit-0 when both are installed. We should also check $with_dbus to see if we have dbus-devel available, as that's required to talk to polkit-1. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH] spec: Fix polkit dep on F23

2015-07-21 Thread Cole Robinson
On 07/21/2015 12:50 PM, Daniel P. Berrange wrote: On Tue, Jul 21, 2015 at 12:12:03PM -0400, Cole Robinson wrote: On 07/17/2015 10:15 AM, Daniel P. Berrange wrote: On Tue, Jul 14, 2015 at 02:44:59PM -0400, Cole Robinson wrote: As of fedora polkit-0.113-2, polkit-devel only pulls in polkit-libs,

Re: [libvirt] [PATCH] cgroup: Drop resource partition from virSystemdMakeScopeName

2015-07-21 Thread Peter Krempa
On Tue, Jul 21, 2015 at 16:12:09 +0100, Daniel Berrange wrote: On Mon, Jul 20, 2015 at 11:10:18AM +0200, Peter Krempa wrote: On Fri, Jul 17, 2015 at 15:40:31 +0100, Daniel Berrange wrote: On Thu, Jul 16, 2015 at 04:18:08PM +0200, Peter Krempa wrote: ... The patch as-is removes the

Re: [libvirt] [PATCH] configure: clarify rationale for checking pkcheck

2015-07-21 Thread Eric Blake
On 07/21/2015 10:53 AM, Daniel P. Berrange wrote: We don't need pkcheck binary, but we must detect it in order to see if we're preferring polkit-1 over polkit-0 when both are installed. We should also check $with_dbus to see if we have dbus-devel available, as that's required to talk to

Re: [libvirt] [PATCH 03/13] virsh: blockjob: Split out vshBlockJobSetSpeed from blockJobImpl

2015-07-21 Thread Peter Krempa
On Mon, Jul 20, 2015 at 16:47:38 -0400, John Ferlan wrote: On 07/15/2015 12:33 PM, Peter Krempa wrote: --- tools/virsh-domain.c | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index

Re: [libvirt] [Spice-devel] [PATCH v4] qemu: Use heads parameter for QXL driver

2015-07-21 Thread Christophe Fergeau
Hi, On Mon, Jul 20, 2015 at 11:25:52AM +0200, Martin Kletzander wrote: In the meantime, is the only thing this does limiting the maximum? Is it there just to save some memory or why? Because otherwise I can't see the use-case in that. I'm not saying there isn't one, just that I can't find

Re: [libvirt] [PATCH v2] network: add an option to make dns public

2015-07-21 Thread Peter Krempa
On Mon, Jul 20, 2015 at 17:42:05 +0200, Cedric Bosdonnat wrote: On Mon, 2015-07-20 at 16:25 +0200, Peter Krempa wrote: On Mon, Jul 20, 2015 at 11:29:15 +0200, Cédric Bosdonnat wrote: In some use cases we don't want the virtual network's DNS to only listen to the vnet interface. Adding a

Re: [libvirt] [PATCHv2] nodedev: add RDMA and tx-udp_tnl-segmentation NIC capabilities

2015-07-21 Thread Moshe Levi
-Original Message- From: John Ferlan [mailto:jfer...@redhat.com] Sent: Tuesday, July 21, 2015 1:06 AM To: Moshe Levi; libvir-list@redhat.com Subject: Re: [libvirt] [PATCHv2] nodedev: add RDMA and tx-udp_tnl- segmentation NIC capabilities On 07/19/2015 06:11 AM, Moshe Levi

Re: [libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

2015-07-21 Thread Zeeshan Ali (Khattak)
On Mon, Jul 20, 2015 at 6:32 PM, Christophe Fergeau cferg...@redhat.com wrote: On Mon, Jul 20, 2015 at 05:24:30PM +0100, Zeeshan Ali (Khattak) wrote: And all that data is completely irrelevant for the reason I mentioned again and again. Now that we have the data, and that it goes your way,

Re: [libvirt] [PATCHv2] nodedev: add RDMA and tx-udp_tnl-segmentation NIC capabilities

2015-07-21 Thread John Ferlan
On 07/19/2015 06:11 AM, Moshe Levi wrote: ... One more that just dawned on me while rereading... Because virNetDevGFeatureAvailable is only called when the conditional HAVE_DECL_ETHTOOL_GFEATURES is set, there should be a couple of other places to wrap... diff --git a/src/conf/device_conf.c

Re: [libvirt] [PATCH 02/13] virsh: cmdBlockJob: Switch to declarative flag interlocking

2015-07-21 Thread Peter Krempa
On Mon, Jul 20, 2015 at 15:23:15 -0600, Eric Blake wrote: On 07/15/2015 10:33 AM, Peter Krempa wrote: Use the VSH_EXCLUSIVE_OPTIONS_VAR to interlock incompatible options --- tools/virsh-domain.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-)

Re: [libvirt] [PATCH 00/13] Improve virsh block job handling

2015-07-21 Thread Peter Krempa
On Mon, Jul 20, 2015 at 15:49:46 -0600, Eric Blake wrote: On 07/20/2015 02:48 PM, John Ferlan wrote: On 07/15/2015 12:33 PM, Peter Krempa wrote: This series refactors the block job command code so that it is handled by separate functions rather than one mega-method. Additionally this

Re: [libvirt] [Spice-devel] [PATCH v4] qemu: Use heads parameter for QXL driver

2015-07-21 Thread Martin Kletzander
On Tue, Jul 21, 2015 at 09:36:55AM +0200, Christophe Fergeau wrote: On Mon, Jul 20, 2015 at 11:25:52AM +0200, Martin Kletzander wrote: I spend all morning fixing this to be installed properly in the system. Anyway, I finally managed to make this work and found out the guest I used for it is

Re: [libvirt] [Spice-devel] [PATCH v4] qemu: Use heads parameter for QXL driver

2015-07-21 Thread Christophe Fergeau
On Mon, Jul 20, 2015 at 11:25:52AM +0200, Martin Kletzander wrote: I spend all morning fixing this to be installed properly in the system. Anyway, I finally managed to make this work and found out the guest I used for it is not ready to have multiple monitors. Anyway, looking at everything

Re: [libvirt] [Spice-devel] [PATCH v4] qemu: Use heads parameter for QXL driver

2015-07-21 Thread Daniel P. Berrange
On Tue, Jul 21, 2015 at 03:35:50PM +0200, Martin Kletzander wrote: On Tue, Jul 21, 2015 at 01:50:22PM +0100, Daniel P. Berrange wrote: On Tue, Jul 21, 2015 at 11:44:27AM +0200, Martin Kletzander wrote: On Tue, Jul 21, 2015 at 09:36:55AM +0200, Christophe Fergeau wrote: On Mon, Jul 20, 2015 at

Re: [libvirt] [PATCH 2/3] Qemu: add CMT support

2015-07-21 Thread Ren, Qiaowei
On Jul 20, 2015 22:34, Daniel P. Berrange wrote: On Mon, Jul 20, 2015 at 01:50:54PM +, Ren, Qiaowei wrote: Daniel P. Berrange wrote on Jul 20, 2015 17:32: On Sun, Jul 05, 2015 at 07:43:43PM +0800, Qiaowei Ren wrote: One RFC in

Re: [libvirt] [Spice-devel] [PATCH v4] qemu: Use heads parameter for QXL driver

2015-07-21 Thread Martin Kletzander
On Tue, Jul 21, 2015 at 08:41:33AM -0400, Frediano Ziglio wrote: On Tue, Jul 21, 2015 at 09:36:55AM +0200, Christophe Fergeau wrote: On Mon, Jul 20, 2015 at 11:25:52AM +0200, Martin Kletzander wrote: I spend all morning fixing this to be installed properly in the system. Anyway, I finally

Re: [libvirt] [Spice-devel] [PATCH v4] qemu: Use heads parameter for QXL driver

2015-07-21 Thread Martin Kletzander
On Tue, Jul 21, 2015 at 01:50:22PM +0100, Daniel P. Berrange wrote: On Tue, Jul 21, 2015 at 11:44:27AM +0200, Martin Kletzander wrote: On Tue, Jul 21, 2015 at 09:36:55AM +0200, Christophe Fergeau wrote: On Mon, Jul 20, 2015 at 11:25:52AM +0200, Martin Kletzander wrote: I spend all morning

Re: [libvirt] [PATCH 00/13] Improve virsh block job handling

2015-07-21 Thread Peter Krempa
On Mon, Jul 20, 2015 at 16:48:01 -0400, John Ferlan wrote: On 07/15/2015 12:33 PM, Peter Krempa wrote: This series refactors the block job command code so that it is handled by separate functions rather than one mega-method. Additionally this series then fixes the routine for waiting

Re: [libvirt] [Spice-devel] [PATCH v4] qemu: Use heads parameter for QXL driver

2015-07-21 Thread Frediano Ziglio
On Tue, Jul 21, 2015 at 09:36:55AM +0200, Christophe Fergeau wrote: On Mon, Jul 20, 2015 at 11:25:52AM +0200, Martin Kletzander wrote: I spend all morning fixing this to be installed properly in the system. Anyway, I finally managed to make this work and found out the guest I used for

Re: [libvirt] [Spice-devel] [PATCH v4] qemu: Use heads parameter for QXL driver

2015-07-21 Thread Daniel P. Berrange
On Tue, Jul 21, 2015 at 11:44:27AM +0200, Martin Kletzander wrote: On Tue, Jul 21, 2015 at 09:36:55AM +0200, Christophe Fergeau wrote: On Mon, Jul 20, 2015 at 11:25:52AM +0200, Martin Kletzander wrote: I spend all morning fixing this to be installed properly in the system. Anyway, I finally

Re: [libvirt] [libvirt-glib PATCHv5 7/7] gobject: Add wrapper for virNetworkGetDHCPLeases

2015-07-21 Thread Daniel P. Berrange
On Thu, Jul 16, 2015 at 11:11:01AM +0200, Christophe Fergeau wrote: On Mon, Jul 13, 2015 at 02:45:21PM +0100, Zeeshan Ali (Khattak) wrote: On Fri, Jul 10, 2015 at 5:04 PM, Christophe Fergeau cferg...@redhat.com wrote: Patches of yours broke the build, you have a strong opinion on the

[libvirt] [PATCH glib] Remove dep on libvirt 1.2.6

2015-07-21 Thread Daniel P. Berrange
Going back on what I said a few hours ago On closer inspection, I re-discovered that we have already taken the approach of conditionally compiling code in libvirt-gobject to avoid increasing the min libvirt. So given this, I would like to avoid increasing the min required libvirt in the

[libvirt] [PATCH glib] Make use of DHCP API conditionally compiled

2015-07-21 Thread Daniel P. Berrange
Previously the use of virDomainOpenGraphicsFD API from libvirt 1.2.8 was made to be conditionally compiled. Given this past practice, make use of the virNetworkGetDHCPLeases API conditional too, rather than requiring newer libvirt. --- configure.ac | 6 ++-