Re: [libvirt] [PATCHv2 02/17] conf: pay attention to bus minSlot/maxSlot when autoassigning PCI addresses

2015-07-24 Thread Martin Kletzander
On Fri, Jul 17, 2015 at 02:43:29PM -0400, Laine Stump wrote: The function that auto-assigns PCI addresses was written with the hardcoded assumptions that any PCI bus would have slots available starting at 1 and ending at 31. This isn't true for many types of controller (some have a single

[libvirt] [PATCH v7] autocreate tap device for VIR_DOMAIN_NET_TYPE_ETHERNET

2015-07-24 Thread Vasiliy Tolstov
If a user specify ehernet device create it via libvirt and run script if it provided. After this commit user does not need to run external script to create tap device or add root to qemu process. Signed-off-by: Vasiliy Tolstov v.tols...@selfip.ru --- src/qemu/qemu_command.c | 143

[libvirt] [PATCH] fix typo in qemu_monitor

2015-07-24 Thread Cao jin
Signed-off-by: Cao jin caoj.f...@cn.fujitsu.com --- src/qemu/qemu_monitor.c | 2 +- src/qemu/qemu_monitor.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 15ba39b..beaf585 100644 --- a/src/qemu/qemu_monitor.c +++

[libvirt] [libvirt-glib] events: Mark 'eventlock' as static

2015-07-24 Thread Christophe Fergeau
It's not used outside of the libvirt-glib-event.c file, so there is no good reason for not having it static. As it was not listed in libvirt-glib.sym, this will make no change to the publicly exported symbols (ie this is not an ABI change). --- libvirt-glib/libvirt-glib-event.c | 2 +- 1 file

Re: [libvirt] [PATCH v7] autocreate tap device for VIR_DOMAIN_NET_TYPE_ETHERNET

2015-07-24 Thread Vasiliy Tolstov
2015-07-24 12:10 GMT+03:00 Vasiliy Tolstov v.tols...@selfip.ru: If a user specify ehernet device create it via libvirt and run script if it provided. After this commit user does not need to run external script to create tap device or add root to qemu process. Patch v7 provide fixes for

Re: [libvirt] [PATCH glib 2/2] configure.ac: update min required versions

2015-07-24 Thread Daniel P. Berrange
On Thu, Jul 23, 2015 at 10:00:14AM +0200, Christophe Fergeau wrote: On Wed, Jul 22, 2015 at 03:14:23PM +0100, Daniel P. Berrange wrote: Based on the distro target policy we have the following min versions in various distros libvirt glib2gobject-introspection

Re: [libvirt] [PATCH glib 1/2] README: formally document intended platform support targets

2015-07-24 Thread Daniel P. Berrange
On Thu, Jul 23, 2015 at 09:57:59AM +0200, Christophe Fergeau wrote: Hey, On Wed, Jul 22, 2015 at 03:14:22PM +0100, Daniel P. Berrange wrote: Give users an indication of what distro platforms the project intends to be buildable on. This policy will be used to decide when it is appropriate

Re: [libvirt] [PATCHv2 05/17] conf: add new model subelement with type attribute to controller

2015-07-24 Thread Martin Kletzander
On Fri, Jul 24, 2015 at 08:01:05AM -0400, Laine Stump wrote: On 07/24/2015 07:28 AM, Martin Kletzander wrote: On Thu, Jul 23, 2015 at 03:18:04PM +0200, Ján Tomko wrote: On Fri, Jul 17, 2015 at 02:43:32PM -0400, Laine Stump wrote: This new subelement is used in PCI controllers: the toplevel

Re: [libvirt] [PATCHv2 06/17] qemu: implement model subelement to controller

2015-07-24 Thread Martin Kletzander
On Fri, Jul 17, 2015 at 02:43:33PM -0400, Laine Stump wrote: This patch provides qemu support for the contents of model in controller for the two existing PCI controller types that need it (i.e. the two controller types that are backed by a device that must be specified on the qemu commandline):

Re: [libvirt] [PATCH v2 0/7] vz: add migration support

2015-07-24 Thread Dmitry Guryanov
On 07/17/2015 03:55 PM, nshirokovs...@virtuozzo.com wrote: NOTE that minimal command to migrate vz domain is like next: virsh -c vz:///system migrate 200 vz+ssh://shiny0/system -p2p --live --persistent --compressed Difference from v1: 1. Patch is quite different. First patchset implements

Re: [libvirt] [PATCH 1/2] storage: allow zero capacity with non-backing file to be created

2015-07-24 Thread Ján Tomko
On Thu, Jul 23, 2015 at 04:01:22PM -0400, John Ferlan wrote: On 06/30/2015 04:19 PM, Chris J Arges wrote: In commit fbcf7da95, a change was introduced that no longer allowed defining As John pointed out, it was commit 155ca616e that changed it. volumes via XML with a capacity of '0'.

Re: [libvirt] [PATCH 2/2] test: introduce a function in test driver to check get vcpupin info

2015-07-24 Thread John Ferlan
On 07/14/2015 09:10 AM, Luyao Huang wrote: As there is a regression in use vcpupin get info, introduce a new function to test the virsh client. Signed-off-by: Luyao Huang lhu...@redhat.com --- src/test/test_driver.c | 55 ++

Re: [libvirt] [PATCHv2 05/17] conf: add new model subelement with type attribute to controller

2015-07-24 Thread Martin Kletzander
On Thu, Jul 23, 2015 at 03:18:04PM +0200, Ján Tomko wrote: On Fri, Jul 17, 2015 at 02:43:32PM -0400, Laine Stump wrote: This new subelement is used in PCI controllers: the toplevel *attribute* model of a controller denotes what kind of PCI controller is being described, e.g. a

Re: [libvirt] Plan for next release

2015-07-24 Thread Andrea Bolognani
On Wed, 2015-07-22 at 23:50 +0800, Daniel Veillard wrote: We are getting close to the end of the month, so we may need to freeze next Monday or Tuesday. I guess a requirement for freeze, or at least for release, is deciding how we want to handle symlinks with long paths[1] so that we can,

Re: [libvirt] [PATCH] fix typo in qemu_monitor

2015-07-24 Thread Kashyap Chamarthy
On Fri, Jul 24, 2015 at 05:26:36PM +0800, Cao jin wrote: Signed-off-by: Cao jin caoj.f...@cn.fujitsu.com --- src/qemu/qemu_monitor.c | 2 +- src/qemu/qemu_monitor.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c

Re: [libvirt] [PATCHv2 04/17] conf: add virDomainControllerDefNew()

2015-07-24 Thread Laine Stump
On 07/22/2015 03:11 PM, John Ferlan wrote: On 07/17/2015 02:43 PM, Laine Stump wrote: There are some non-0 default values in virDomainControllerDef (and will soon be more) that are easier to not forget if the remembering is done by a single initializer function (rather than inline code after

Re: [libvirt] [PATCH 1/2] storage: allow zero capacity with non-backing file to be created

2015-07-24 Thread John Ferlan
On 07/24/2015 09:25 AM, Chris J Arges wrote: On 07/24/2015 06:10 AM, Ján Tomko wrote: On Thu, Jul 23, 2015 at 04:01:22PM -0400, John Ferlan wrote: On 06/30/2015 04:19 PM, Chris J Arges wrote: In commit fbcf7da95, a change was introduced that no longer allowed defining As John pointed

Re: [libvirt] [PATCHv2 10/17] conf: new pci controller model pcie-root-port

2015-07-24 Thread Martin Kletzander
On Fri, Jul 17, 2015 at 02:43:37PM -0400, Laine Stump wrote: This controller can be connected (at domain startup time only - not hotpluggable) only to a port on the pcie root complex (pcie-root in libvirt config), hence the new connect type VIR_PCI_CONNECT_TYPE_PCIE_ROOT. It provides a

Re: [libvirt] [PATCHv2 11/17] qemu: support new pci controller model pcie-root-port

2015-07-24 Thread Martin Kletzander
On Fri, Jul 17, 2015 at 02:43:38PM -0400, Laine Stump wrote: This is backed by the qemu device ioh3420. chassis and port from the model subelement are used to store/set the respective qemu device options for the ioh3420. Currently, chassis is set to be the index of the controller, and port is

Re: [libvirt] [PATCHv2 04/17] conf: add virDomainControllerDefNew()

2015-07-24 Thread Laine Stump
On 07/23/2015 08:35 AM, Ján Tomko wrote: [reducing the cc-list] On Fri, Jul 17, 2015 at 02:43:31PM -0400, Laine Stump wrote: There are some non-0 default values in virDomainControllerDef (and will soon be more) that are easier to not forget if the remembering is done by a single initializer

Re: [libvirt] [PATCHv2 10/17] conf: new pci controller model pcie-root-port

2015-07-24 Thread Laine Stump
On 07/24/2015 12:07 PM, Martin Kletzander wrote: On Fri, Jul 17, 2015 at 02:43:37PM -0400, Laine Stump wrote: This controller can be connected (at domain startup time only - not hotpluggable) only to a port on the pcie root complex (pcie-root in libvirt config), hence the new connect type

Re: [libvirt] [PATCHv2 10/17] conf: new pci controller model pcie-root-port

2015-07-24 Thread Laine Stump
On 07/22/2015 05:38 PM, John Ferlan wrote: On 07/17/2015 02:43 PM, Laine Stump wrote: This controller can be connected (at domain startup time only - not hotpluggable) only to a port on the pcie root complex (pcie-root in libvirt config), hence the new connect type

Re: [libvirt] [PATCHv2 11/17] qemu: support new pci controller model pcie-root-port

2015-07-24 Thread Laine Stump
On 07/24/2015 12:14 PM, Martin Kletzander wrote: On Fri, Jul 17, 2015 at 02:43:38PM -0400, Laine Stump wrote: This is backed by the qemu device ioh3420. chassis and port from the model subelement are used to store/set the respective qemu device options for the ioh3420. Currently, chassis is

Re: [libvirt] [PATCHv2 07/17] conf: add new target subelement with chassisNr attribute to controller

2015-07-24 Thread Laine Stump
On 07/22/2015 04:20 PM, John Ferlan wrote: On 07/17/2015 02:43 PM, Laine Stump wrote: There are some configuration options to some types of pci controllers that are currently automatically derived from other parts of the controller's configuration. For example, a pci-bridge controller has an

[libvirt] [PATCH 0/2] Disable floppy disk for PowerPC VMs

2015-07-24 Thread Kothapally Madhu Pavan
This is an attempt to fix: Libvirt BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1180486 Libvirt currently assumes ISA_based floppy disks to be available across all architectures and machine types. However, PowerPC Book 3S compatible ('ie pseries) virtual machines do not support Floppy disks.

[libvirt] [PATCH 2/2] Avoid starting a PowerPC VM with floppy disk

2015-07-24 Thread Kothapally Madhu Pavan
PowerPC pseries based VMs do not support a floppy disk controller. This prohibits libvirt from creating qemu command with floppy device. Signed-off-by: Kothapally Madhu Pavan k...@linux.vnet.ibm.com --- src/qemu/qemu_command.c | 47 +-- 1 file

[libvirt] [PATCH 1/2] Caps: Disable floppy disk for PowerPC VM

2015-07-24 Thread Kothapally Madhu Pavan
PowerPC pseries based VMs do not support a floppy disk controller. This prohibits libvirt from adding floppy disk for a PowerPC pseries VM. Signed-off-by: Kothapally Madhu Pavan k...@linux.vnet.ibm.com --- src/conf/domain_conf.c | 19 +++ src/qemu/qemu_capabilities.c |

Re: [libvirt] [PATCHv2 09/17] qemu: add capabilities bit for device ioh3420

2015-07-24 Thread Laine Stump
On 07/22/2015 05:10 PM, John Ferlan wrote: On 07/17/2015 02:43 PM, Laine Stump wrote: This is a PCIE root port. It connects only to a port of the integrated pcie.0 bus of a Q35 machine (can't be hotplugged), and provides a single PCIe port that can have PCI or PCIe devices hotplugged into

Re: [libvirt] [PATCHv2 16/17] conf: new pcie-controller model pcie-switch-downstream-port

2015-07-24 Thread Laine Stump
On 07/23/2015 10:47 AM, John Ferlan wrote: On 07/17/2015 02:43 PM, Laine Stump wrote: This controller can be connected only to a port on a pcie-switch-upstream-port. It provides a single hotpluggable port that will accept any PCI or PCIe device, as well as any device requiring a pcie-*-port

Re: [libvirt] [PATCHv2 05/17] conf: add new model subelement with type attribute to controller

2015-07-24 Thread Laine Stump
On 07/22/2015 03:30 PM, John Ferlan wrote: On 07/17/2015 02:43 PM, Laine Stump wrote: This new subelement is used in PCI controllers: the toplevel *attribute* model of a controller denotes what kind of PCI controller is being described, e.g. a dmi-to-pci-bridge, pci-bridge, or pci-root. But

Re: [libvirt] [PATCHv2 10/17] conf: new pci controller model pcie-root-port

2015-07-24 Thread John Ferlan
... @@ -18914,6 +18941,12 @@ virDomainControllerDefFormat(virBufferPtr buf, if (def-opts.pciopts.chassisNr != -1) virBufferAsprintf(buf, chassisNr='%d', def-opts.pciopts.chassisNr); +if (def-opts.pciopts.chassis !=

Re: [libvirt] Plan for next release

2015-07-24 Thread Laine Stump
On 07/24/2015 07:28 AM, Andrea Bolognani wrote: On Wed, 2015-07-22 at 23:50 +0800, Daniel Veillard wrote: We are getting close to the end of the month, so we may need to freeze next Monday or Tuesday. I guess a requirement for freeze, or at least for release, is deciding how we want to

Re: [libvirt] [PATCH glib 1/2] README: formally document intended platform support targets

2015-07-24 Thread Christophe Fergeau
On Fri, Jul 24, 2015 at 10:57:49AM +0100, Daniel P. Berrange wrote: On Thu, Jul 23, 2015 at 09:57:59AM +0200, Christophe Fergeau wrote: On Wed, Jul 22, 2015 at 03:14:22PM +0100, Daniel P. Berrange wrote: +As an example, as of July 1st 2015, this policy would aim to pick the +min versions

Re: [libvirt] [PATCH 1/2] storage: allow zero capacity with non-backing file to be created

2015-07-24 Thread Chris J Arges
On 07/24/2015 06:10 AM, Ján Tomko wrote: On Thu, Jul 23, 2015 at 04:01:22PM -0400, John Ferlan wrote: On 06/30/2015 04:19 PM, Chris J Arges wrote: In commit fbcf7da95, a change was introduced that no longer allowed defining As John pointed out, it was commit 155ca616e that changed it.

Re: [libvirt] [PATCHv2 05/17] conf: add new model subelement with type attribute to controller

2015-07-24 Thread Martin Kletzander
On Fri, Jul 24, 2015 at 08:01:05AM -0400, Laine Stump wrote: On 07/24/2015 07:28 AM, Martin Kletzander wrote: On Thu, Jul 23, 2015 at 03:18:04PM +0200, Ján Tomko wrote: On Fri, Jul 17, 2015 at 02:43:32PM -0400, Laine Stump wrote: This new subelement is used in PCI controllers: the toplevel

Re: [libvirt] Plan for next release

2015-07-24 Thread Andrea Bolognani
On Fri, 2015-07-24 at 09:35 -0400, Laine Stump wrote: On 07/24/2015 07:28 AM, Andrea Bolognani wrote: On Wed, 2015-07-22 at 23:50 +0800, Daniel Veillard wrote: We are getting close to the end of the month, so we may need to freeze next Monday or Tuesday. I guess a requirement

Re: [libvirt] [PATCHv2 05/17] conf: add new model subelement with type attribute to controller

2015-07-24 Thread Laine Stump
On 07/24/2015 07:28 AM, Martin Kletzander wrote: On Thu, Jul 23, 2015 at 03:18:04PM +0200, Ján Tomko wrote: On Fri, Jul 17, 2015 at 02:43:32PM -0400, Laine Stump wrote: This new subelement is used in PCI controllers: the toplevel *attribute* model of a controller denotes what kind of PCI

Re: [libvirt] [PATCH] qemu: fix the audit log is not correct after hot-plug memory success

2015-07-24 Thread John Ferlan
On 07/17/2015 04:52 AM, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1226234#c3 After hot-plug a memory device success, the audit log show that memory update failed: type=VIRT_RESOURCE ... old-mem=1024000 new-mem=1548288 \ exe=/usr/sbin/libvirtd hostname=? addr=?

Re: [libvirt] [PATCH v2] fix typo in qemu_monitor

2015-07-24 Thread Pavel Hrdina
On Fri, Jul 24, 2015 at 07:53:36PM +0800, Cao jin wrote: Signed-off-by: Cao jin caoj.f...@cn.fujitsu.com --- src/qemu/qemu_monitor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index 1e7b6bb..860e242 100644 ---

Re: [libvirt] [PATCH] fix typo in qemu_monitor

2015-07-24 Thread Peter Krempa
On Fri, Jul 24, 2015 at 17:26:36 +0800, Cao jin wrote: Signed-off-by: Cao jin caoj.f...@cn.fujitsu.com --- src/qemu/qemu_monitor.c | 2 +- src/qemu/qemu_monitor.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c

[libvirt] [PATCH v2] fix typo in qemu_monitor

2015-07-24 Thread Cao jin
Signed-off-by: Cao jin caoj.f...@cn.fujitsu.com --- src/qemu/qemu_monitor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index 1e7b6bb..860e242 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -259,7

Re: [libvirt] Plan for next release

2015-07-24 Thread Daniel Veillard
On Fri, Jul 24, 2015 at 01:28:51PM +0200, Andrea Bolognani wrote: On Wed, 2015-07-22 at 23:50 +0800, Daniel Veillard wrote: We are getting close to the end of the month, so we may need to freeze next Monday or Tuesday. I guess a requirement for freeze, or at least for release, is