Re: [libvirt] [PATCH 2/2] virt-aa-helper: allow access to /usr/share/ovmf/

2015-08-21 Thread Guido Günther
Hi, On Fri, Aug 21, 2015 at 11:44:11AM +0200, intrigeri wrote: Hi, this patchset breaks the test suite for me once applied on top of the debian/experimental branch (while the test suite passes fine without these patches there). Sorry, no time to look into it further today. I can reproduce

[libvirt] [PATCH v2 0/3] virt-aa-helper: allow to add R/O files in restricted dirs

2015-08-21 Thread Guido Günther
Hi, the purpose of these patches is to make it possible to put files in restricted_rw that are under a directory that is already in restricted. It was only possible to add the to overrides before so they ended up being rw. Sorry for the incomplete series this morning, hopefully this looks better.

[libvirt] Fwd: Guidelines for implementing a hypervisor driver

2015-08-21 Thread Christian Loehle
Hey, I couldn't find any documentation about how to implement a driver for an unsupported hypervisor, does something like that exist? Best regards, Christian Loehle -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] Guidelines for implementing a hypervisor driver

2015-08-21 Thread Christian Loehle
Hey, I couldn't find any documentation about how to implement a driver for a new hypervisor, does something like that exist? Best regards, Christian Loehle -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2 3/3] virt-aa-helper: allow access to /usr/share/ovmf/

2015-08-21 Thread Guido Günther
From: intrigeri intrig...@debian.org We forbid access to /usr/share/, but (at least on Debian-based systems) the Open Virtual Machine Firmware files needed for booting UEFI virtual machines in QEMU live in /usr/share/ovmf/. Therefore, we need to add that directory to the list of read only paths.

[libvirt] [PATCH v2 2/3] virt-aa-helper: Simplify restriction logic

2015-08-21 Thread Guido Günther
First check overrides, then read only files then restricted access itself. This allows us to mark files for read only access whose parents were already restricted for read write. Based on a proposal by Martin Kletzander --- src/security/virt-aa-helper.c | 29 ++--- 1

[libvirt] [PATCH v2 1/3] virt-aa-helper: document --probing and --dry-run

2015-08-21 Thread Guido Günther
--- src/security/virt-aa-helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 4ce1e7a..178569e 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -107,12 +107,14 @@ vah_usage(void)

[libvirt] Plans for next release

2015-08-21 Thread Daniel Veillard
Seems we should push 1.2.19 at the end of the month, we are right now at around 150 commits so not a big release. Thus I suggest to enter freeze Wed next week for a release around Sep 1st. I hope this works for everybody, Daniel -- Daniel Veillard | Open Source and Standards, Red Hat

Re: [libvirt] Fwd: Guidelines for implementing a hypervisor driver

2015-08-21 Thread Dmitry Guryanov
On 08/21/2015 05:28 PM, Christian Loehle wrote: Hey, I couldn't find any documentation about how to implement a driver for an unsupported hypervisor, does something like that exist? I think the best way to understand, how to implement a driver, is learning test driver code (src/test in

[libvirt] compressed stream support

2015-08-21 Thread Vasiliy Tolstov
I want to able to get VolumeUpload and VolumeUpload compressed on the fly (for example to minimize network load) Some times ago i ask this question in this list, and get some suggestions from developers. But as i see, May be not good to detect compressor from libvirt config, but create new stream

Re: [libvirt] [PATCH 1/4] cpu: Don't update host-model guest CPUs on ppc64

2015-08-21 Thread Jiri Denemark
On Tue, Aug 18, 2015 at 16:45:04 -0700, Andrea Bolognani wrote: If a guest CPU is defined using cpu mode='host-model'/ the model sub-element will contain the compatibility mode to use. That means we can't just copy the host CPU model on cpuUpdate(), otherwise we'll overwrite that

[libvirt] [PATCH v2 9/9] admin: Usage example of the new server listing API (not to be pushed)

2015-08-21 Thread Erik Skultety
Not to be actually pushed since majority of this example will be merged into virt-admin once it's ready, i.e. virsh splitting series is merged, but might be good to just see the API's working. --- .gitignore | 1 + Makefile.am | 2 +- configure.ac

[libvirt] [PATCH v2 6/9] admin: Move admin_server.{h, c} to admin.{h, c}

2015-08-21 Thread Erik Skultety
This change is merely because admin_server would contain all the code from dispatchers and helpers to the actual APIs. Admin should have similar structure to the daemon-side remote driver - dispatchers and helpers in a separate module, APIs in a separate module. Best viewed with -M. ---

[libvirt] [PATCH v2 7/9] admin: Introduce virAdmServer structure

2015-08-21 Thread Erik Skultety
This is the key structure of all management operations performed on the daemon/clients. An admin client needs to be able to identify another client (either admin or non-privileged client) to perform an action on it. This identification includes a server the client is connected to, thus a

[libvirt] [PATCH v2 1/9] test: Replace tabs with spaces in virnetdaemondata json files

2015-08-21 Thread Erik Skultety
JSON data that are used to initialize tests in virnetdaemontest should be in a consistent format, i.e. not using tabs for indentation, those should be replaced by spaces. --- .../virnetdaemondata/input-data-admin-nomdns.json | 244 ++--- .../input-data-no-keepalive-required.json

[libvirt] [PATCH v2 4/9] rpc: Introduce new elements 'id' and 'name' to virnetserver structure

2015-08-21 Thread Erik Skultety
By adding these elements, we'll be able to represent the servers on client side. This is merely because when listing clients or managing clients, it would be convenient to know which server they're connected to. Also reflect this change in virnetdaemontest as well. --- daemon/libvirtd.c |

[libvirt] [PATCH v2 3/9] locking: Remove redundant 'srv' element from virLockDaemon

2015-08-21 Thread Erik Skultety
Now that we have virNetDaemon object holding all the data and being capable of referencing multiple servers, having a duplicate reference to a single server stored in virLockDaemon isn't necessary anymore. This patch removes the above described element. --- src/locking/lock_daemon.c | 40

[libvirt] [PATCH v2 5/9] virnetdaemon: Add post exec restart support for multiple servers

2015-08-21 Thread Erik Skultety
Since the daemon can manage and add (at fresh start) multiple servers, we also should be able to add them from a JSON state file in case of a daemon restart. This patch introduces virNetDaemonAddServersPostExec method which harvests the data about servers from a JSON file supporting both old

[libvirt] [PATCH v2 8/9] admin: Introduce adminDaemonConnectListServers API

2015-08-21 Thread Erik Skultety
This is the first API to the admin interface. This particular API is a convenience API, i.e. when managing clients connected to daemon's servers, we should know (convenience) which server the specific client is connected to. This implies a client-side representation of a server along with a basic

[libvirt] [PATCH v2 0/9] admin API: Introduce server listing API

2015-08-21 Thread Erik Skultety
v2: - tab replacing patch now also includes files Martin added in his keepalive series (trivial, ready to be pushed) - admin_server now marked as renamed instead of deleted and formated with -M - introduction of virAdmServe structure split to a separate patch - resolved

[libvirt] [PATCH v2 2/9] test: s/{in, out}put-data-admin-nomdns/{in, out}put-data-admin-nomdns-nonames

2015-08-21 Thread Erik Skultety
This minor cosmetical change allows us to later add new test case data including named servers. --- ...nput-data-admin-nomdns.json = input-data-admin-nomdns-nonames.json} | 0 ...put-data-admin-nomdns.json = output-data-admin-nomdns-nonames.json} | 0 tests/virnetdaemontest.c

Re: [libvirt] Guidelines for implementing a hypervisor driver

2015-08-21 Thread Michal Privoznik
On 21.08.2015 15:17, Christian Loehle wrote: Hey, I couldn't find any documentation about how to implement a driver for a new hypervisor, does something like that exist? Besides Dmitry's valid piece of advice, there's been a driver added recently. Firstly it was named parallels, then it was

Re: [libvirt] [PATCH 4/4] tests: Add some compatibility-related cases to the CPU tests

2015-08-21 Thread Jiri Denemark
On Fri, Aug 21, 2015 at 14:59:19 -0700, Andrea Bolognani wrote: On Fri, 2015-08-21 at 14:37 -0700, Jiri Denemark wrote: --- a/tests/cputest.c +++ b/tests/cputest.c @@ -607,6 +607,10 @@ mymain(void) DO_TEST_COMPARE(ppc64, host, guest-legacy, VIR_CPU_COMPARE_IDENTICAL);

Re: [libvirt] [PATCH 4/4] tests: Add some compatibility-related cases to the CPU tests

2015-08-21 Thread Jiri Denemark
On Tue, Aug 18, 2015 at 16:45:07 -0700, Andrea Bolognani wrote: --- tests/cputest.c| 14 ++ tests/cputestdata/ppc64-guest-compat-incompatible.xml | 3 +++ tests/cputestdata/ppc64-guest-compat-invalid.xml | 3 +++

Re: [libvirt] [PATCH v2 5/9] virnetdaemon: Add post exec restart support for multiple servers

2015-08-21 Thread Martin Kletzander
On Fri, Aug 21, 2015 at 08:04:06PM +0200, Erik Skultety wrote: Since the daemon can manage and add (at fresh start) multiple servers, we also should be able to add them from a JSON state file in case of a daemon restart. This patch introduces virNetDaemonAddServersPostExec method which harvests

Re: [libvirt] [PATCH 3/4] cpu: Move check for NULL CPU model inside the driver

2015-08-21 Thread Jiri Denemark
On Tue, Aug 18, 2015 at 16:45:06 -0700, Andrea Bolognani wrote: While the check is appropriate for eg. the x86 and generic drivers, there are some valid ppc64 guest configurations where the CPU model is supposed to be NULL. Moving this check from the generic code to the drivers makes it

Re: [libvirt] [PATCH 2/4] cpu: Better support for ppc64 compatibility modes

2015-08-21 Thread Andrea Bolognani
On Fri, 2015-08-21 at 14:58 -0700, Jiri Denemark wrote: On Fri, Aug 21, 2015 at 14:55:02 -0700, Andrea Bolognani wrote: On Fri, 2015-08-21 at 14:27 -0700, Jiri Denemark wrote: +static virCPUCompareResult +ppc64CheckCompatibilityMode(const char *host_model, +

[libvirt] [PATCH 1/2] Parallels driver was renamed to Virtuozzo. Replace old name by new one on libvirt site

2015-08-21 Thread Sergey Bronnikov
--- docs/api.html.in | 2 +- docs/drivers.html.in | 2 +- docs/drvparallels.html.in | 24 docs/formatdomain.html.in | 6 +++--- docs/index.html.in| 2 +- docs/schemas/domaincommon.rng | 2 +- docs/sitemap.html.in |

[libvirt] [PATCH 2/2] Rename page about vz driver

2015-08-21 Thread Sergey Bronnikov
--- docs/{drvparallels.html.in = drvvirtuozzo.html.in} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename docs/{drvparallels.html.in = drvvirtuozzo.html.in} (100%) diff --git a/docs/drvparallels.html.in b/docs/drvvirtuozzo.html.in similarity index 100% rename from

Re: [libvirt] [PATCH 2/4] cpu: Better support for ppc64 compatibility modes

2015-08-21 Thread Andrea Bolognani
On Fri, 2015-08-21 at 14:27 -0700, Jiri Denemark wrote: +static virCPUCompareResult +ppc64CheckCompatibilityMode(const char *host_model, +const char *compat_mode) +{ +int host; +int compat; +char *tmp; +virCPUCompareResult ret =

Re: [libvirt] [PATCH 4/4] tests: Add some compatibility-related cases to the CPU tests

2015-08-21 Thread Andrea Bolognani
On Fri, 2015-08-21 at 14:37 -0700, Jiri Denemark wrote: --- a/tests/cputest.c +++ b/tests/cputest.c @@ -607,6 +607,10 @@ mymain(void) DO_TEST_COMPARE(ppc64, host, guest-legacy, VIR_CPU_COMPARE_IDENTICAL); DO_TEST_COMPARE(ppc64, host, guest-legacy-incompatible,

Re: [libvirt] [PATCH 2/4] cpu: Better support for ppc64 compatibility modes

2015-08-21 Thread Jiri Denemark
On Fri, Aug 21, 2015 at 14:55:02 -0700, Andrea Bolognani wrote: On Fri, 2015-08-21 at 14:27 -0700, Jiri Denemark wrote: +static virCPUCompareResult +ppc64CheckCompatibilityMode(const char *host_model, +const char *compat_mode) +{ +int host; +

Re: [libvirt] [PATCH v2 4/9] rpc: Introduce new elements 'id' and 'name' to virnetserver structure

2015-08-21 Thread Martin Kletzander
On Fri, Aug 21, 2015 at 08:04:05PM +0200, Erik Skultety wrote: By adding these elements, we'll be able to represent the servers on client side. This is merely because when listing clients or managing clients, it would be convenient to know which server they're connected to. Also reflect this

Re: [libvirt] [PATCH 2/4] cpu: Better support for ppc64 compatibility modes

2015-08-21 Thread Jiri Denemark
On Tue, Aug 18, 2015 at 16:45:05 -0700, Andrea Bolognani wrote: Not all combinations of host CPU models and compatibility modes are valid, so we need to make sure we don't try to do something that QEMU will reject. Moreover, we need to apply a different logic to guests using host-model and

Re: [libvirt] [PATCH v2 3/9] locking: Remove redundant 'srv' element from virLockDaemon

2015-08-21 Thread Martin Kletzander
On Fri, Aug 21, 2015 at 08:04:04PM +0200, Erik Skultety wrote: Now that we have virNetDaemon object holding all the data and being capable of referencing multiple servers, having a duplicate reference to a single server stored in virLockDaemon isn't necessary anymore. This patch removes the

Re: [libvirt] [PATCH v2 2/9] test: s/{in, out}put-data-admin-nomdns/{in, out}put-data-admin-nomdns-nonames

2015-08-21 Thread Martin Kletzander
On Fri, Aug 21, 2015 at 08:04:03PM +0200, Erik Skultety wrote: This minor cosmetical change allows us to later add new test case data including named servers. --- ...nput-data-admin-nomdns.json = input-data-admin-nomdns-nonames.json} | 0 ...put-data-admin-nomdns.json =

Re: [libvirt] [PATCH v2 0/3] virt-aa-helper: allow to add R/O files in restricted dirs

2015-08-21 Thread Martin Kletzander
On Fri, Aug 21, 2015 at 03:31:59PM +0200, Guido Günther wrote: Hi, the purpose of these patches is to make it possible to put files in restricted_rw that are under a directory that is already in restricted. It was only possible to add the to overrides before so they ended up being rw. Sorry for

Re: [libvirt] [PATCH v2 1/9] test: Replace tabs with spaces in virnetdaemondata json files

2015-08-21 Thread Martin Kletzander
On Fri, Aug 21, 2015 at 08:04:02PM +0200, Erik Skultety wrote: JSON data that are used to initialize tests in virnetdaemontest should be in a consistent format, i.e. not using tabs for indentation, those should be replaced by spaces. --- .../virnetdaemondata/input-data-admin-nomdns.json | 244

[libvirt] [PATCH 1/2] virt-aa-helper: Simplify restriction logic

2015-08-21 Thread Guido Günther
First check overrides, then read only files then restricted access itself. as proposed by Martin Kletzander --- src/security/virt-aa-helper.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c

[libvirt] [PATCH 2/2] virt-aa-helper: allow access to /usr/share/ovmf/

2015-08-21 Thread Guido Günther
From: intrigeri intrig...@debian.org We forbid access to /usr/share/, but (at least on Debian-based systems) the Open Virtual Machine Firmware files needed for booting UEFI virtual machines in QEMU live in /usr/share/ovmf/. Therefore, we need to add that directory to the list of read only paths.

Re: [libvirt] [PATCH 2/2] virt-aa-helper: allow access to /usr/share/ovmf/

2015-08-21 Thread intrigeri
Hi, this patchset breaks the test suite for me once applied on top of the debian/experimental branch (while the test suite passes fine without these patches there). Sorry, no time to look into it further today. Cheers, -- intrigeri -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] virt-aa-helper: add NVRAM store file for read/write

2015-08-21 Thread Guido Günther
Hi, On Thu, Aug 20, 2015 at 10:58:59AM -0700, Peter Kieser wrote: Some UEFI firmwares may want to use a non-volatile memory to store some variables. If AppArmor is enabled, and NVRAM store file is set currently virt-aa-helper does not add the NVRAM store file to the template. Add this file

Re: [libvirt] [PATCH] Add generated libvirt_admin.syms into .gitignore

2015-08-21 Thread Guido Günther
Hi, On Thu, Aug 20, 2015 at 11:19:48AM -0700, Martin Kletzander wrote: Commit a2c5d16a70a6161449c687be74db2813b362cf5e switched to generating libvirt_admin.syms, but forgot to add the generated file into .gitignore, hence causing tree pollution post-build. I've been building in a separte