Re: [libvirt] [PATCH 3/3] kvm-all: notice KVM of vcpu's TSC rate after migration

2015-09-28 Thread Haozhong Zhang
On Mon, Sep 28, 2015 at 01:37:34PM -0300, Eduardo Habkost wrote: > On Mon, Sep 28, 2015 at 01:38:31PM +0800, Haozhong Zhang wrote: > > When a vcpu is created in KVM, its TSC rate is initially identical to > > the host TSC rate. If its state is migrated to a vcpu on another > > machine (target

[libvirt] [libvirt-test-API] [PATCH] Add test cases for API defineXMLFlags

2015-09-28 Thread Shanzhi Yu
Signed-off-by: Shanzhi Yu --- cases/linux_domain.conf | 22 + repos/domain/definewithflags.py | 104 2 files changed, 126 insertions(+) create mode 100644 repos/domain/definewithflags.py diff --git

Re: [libvirt] [PATCH 0/2] Add support for gic-version machine option

2015-09-28 Thread Martin Kletzander
On Mon, Sep 28, 2015 at 08:26:22PM +0300, Pavel Fedin wrote: Hello! It's nice that QEMU complains itself, but in a case where it is that easy to check the supportability I think it's worth adding because then at least we won't prepare all the stuff and can error out early. Huh... I am

Re: [libvirt] [PATCH] qemu: Fix dynamic_ownership qemu.conf setting

2015-09-28 Thread Martin Kletzander
On Mon, Sep 28, 2015 at 07:53:42PM -0400, Cole Robinson wrote: Commit 307fb904 (Sep 10) added a 'privileged' variable when creating the DAC driver: @@ -153,6 +157,7 @@ virSecurityManagerNewDAC(const char *virtDriver, bool defaultConfined, bool

[libvirt] [libvirt-test-API] [PATCH] fix some typo

2015-09-28 Thread Shanzhi Yu
Signed-off-by: Shanzhi Yu --- repos/domain/fsinfo.py | 2 +- repos/domain/install_linux_check.py | 2 +- repos/domain/install_linux_net.py | 2 +- repos/interface/define.py | 2 +- repos/interface/undefine.py | 4 ++-- 5 files changed, 6

Re: [libvirt] [PATCH 3/3] kvm-all: notice KVM of vcpu's TSC rate after migration

2015-09-28 Thread Eduardo Habkost
On Mon, Sep 28, 2015 at 01:38:31PM +0800, Haozhong Zhang wrote: > When a vcpu is created in KVM, its TSC rate is initially identical to > the host TSC rate. If its state is migrated to a vcpu on another > machine (target machine) which may uses a different host TSC rate, QEMU > on the target

Re: [libvirt] [PATCH] virDomainDiskDef: Turn @device into enum

2015-09-28 Thread Laine Stump
On 09/17/2015 11:37 AM, Michal Privoznik wrote: It's used as enum everywhere, so why store its value in an int? There are a lot of these. I *think* the only reason this was done anywhere in the first place was because the size of an enum isn't guaranteed to be the same across different

Re: [libvirt] [PATCH 0/2] Add support for gic-version machine option

2015-09-28 Thread Pavel Fedin
Hello! > It's nice that QEMU complains itself, but in a case where it is that > easy to check the supportability I think it's worth adding because > then at least we won't prepare all the stuff and can error out early. Huh... I am looking at it now, but looks like there's no support for

Re: [libvirt] [PATCH] virDomainDiskDef: Turn @device into enum

2015-09-28 Thread Daniel P. Berrange
On Mon, Sep 28, 2015 at 12:35:31PM -0400, Laine Stump wrote: > On 09/17/2015 11:37 AM, Michal Privoznik wrote: > >It's used as enum everywhere, so why store its value in an int? > > There are a lot of these. I *think* the only reason this was done anywhere > in the first place was because the

Re: [libvirt] [PATCH v2] Close the source fd if the destination qemu exits during tunnelled migration

2015-09-28 Thread John Ferlan
On 09/28/2015 11:02 AM, Shivaprasad bhat wrote: > Hi Jon, > > Thanks a lot for attaching the patch. Replies inline. > > On Thu, Sep 24, 2015 at 1:52 AM, John Ferlan wrote: >> >> >> On 09/22/2015 07:21 AM, Shivaprasad bhat wrote: >>> On Mon, Sep 21, 2015 at 8:04 PM, John

Re: [libvirt] [PATCH] virDomainDiskDef: Turn @device into enum

2015-09-28 Thread John Ferlan
On 09/17/2015 11:37 AM, Michal Privoznik wrote: > It's used as enum everywhere, so why store its value in an int? > > Signed-off-by: Michal Privoznik > --- > src/conf/domain_conf.c | 9 +++-- > src/conf/domain_conf.h | 2 +- > src/qemu/qemu_command.c | 2 ++ >

Re: [libvirt] [PATCH v2] Close the source fd if the destination qemu exits during tunnelled migration

2015-09-28 Thread Shivaprasad bhat
Hi Jon, Thanks a lot for attaching the patch. Replies inline. On Thu, Sep 24, 2015 at 1:52 AM, John Ferlan wrote: > > > On 09/22/2015 07:21 AM, Shivaprasad bhat wrote: >> On Mon, Sep 21, 2015 at 8:04 PM, John Ferlan wrote: >>> >>> >>> On 09/21/2015

Re: [libvirt] [PATCH 0/4] improve virConnectListAllInterfaces()

2015-09-28 Thread Daniel P. Berrange
On Fri, Sep 25, 2015 at 01:48:41PM -0400, Laine Stump wrote: > On 09/25/2015 01:27 PM, Daniel P. Berrange wrote: > >On Fri, Sep 25, 2015 at 05:22:30PM +0100, Daniel P. Berrange wrote: > >>On Fri, Sep 25, 2015 at 11:13:52AM -0400, Laine Stump wrote: > >>>There's a bit of background about this here:

Re: [libvirt] Use of 'detach' flag with QMP command `migrate` in qemuMonitorJSONMigrate()

2015-09-28 Thread Daniel P. Berrange
On Sun, Sep 27, 2015 at 06:23:15PM +0200, Kashyap Chamarthy wrote: > The qmp-commands.hx file from QEMU says[1]: > > "The user Monitor's "detach" argument is invalid in QMP and should > not be used" That does not exactly reflect reality. The QMP parser permits "detach", but the

Re: [libvirt] Use of 'detach' flag with QMP command `migrate` in qemuMonitorJSONMigrate()

2015-09-28 Thread Kashyap Chamarthy
On Mon, Sep 28, 2015 at 10:02:48AM +0100, Daniel P. Berrange wrote: > On Sun, Sep 27, 2015 at 06:23:15PM +0200, Kashyap Chamarthy wrote: > > The qmp-commands.hx file from QEMU says[1]: > > > > "The user Monitor's "detach" argument is invalid in QMP and should > > not be used" > > That

[libvirt] [libvirt-test-API] [PATCH] Add two cases for API interfaceAddresses and make small changes to global.cfg

2015-09-28 Thread Shanzhi Yu
Signed-off-by: Shanzhi Yu --- cases/linux_domain.conf| 12 +++ global.cfg | 8 +++-- repos/domain/get_guest_network_info.py | 66 ++ 3 files changed, 84 insertions(+), 2 deletions(-) create mode

[libvirt] [libvirt-test-API] [PATCH] fix two error in script pin_iothread.py and connection_getAllDomainStats.py

2015-09-28 Thread Shanzhi Yu
Signed-off-by: Shanzhi Yu --- repos/domain/pin_iothread.py | 2 +- repos/virconn/connection_getAllDomainStats.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/repos/domain/pin_iothread.py b/repos/domain/pin_iothread.py index

[libvirt] [libvirt-test-API] [PATCH] change some cases order in conf file linux_domain.conf

2015-09-28 Thread Shanzhi Yu
Some cases need guest agent running in domain, change some cases order to avoid the failure. Signed-off-by: Shanzhi Yu --- cases/linux_domain.conf | 100 1 file changed, 50 insertions(+), 50 deletions(-) diff --git

[libvirt] [PATCH] qemu: Fix dynamic_ownership qemu.conf setting

2015-09-28 Thread Cole Robinson
Commit 307fb904 (Sep 10) added a 'privileged' variable when creating the DAC driver: @@ -153,6 +157,7 @@ virSecurityManagerNewDAC(const char *virtDriver, bool defaultConfined, bool requireConfined, bool