Re: [libvirt] [PATCH 2/2] qemu: emit 'defined' event after reverted to snapshot

On 12/15/2015 04:00 AM, Dmitry Andreev wrote: > > > On 14.12.2015 23:10, John Ferlan wrote: >> >> >> On 12/09/2015 03:29 AM, Dmitry Andreev wrote: >>> Config file is changed. VIR_DOMAIN_EVENT_DEFINED should be emitted >>> --- >>> src/qemu/qemu_driver.c | 5 + >>> 1 file changed, 5

Re: [libvirt] ARM KVM GICv3 Support

On 15 December 2015 at 16:57, Andre Przywara wrote: > Even that wouldn't help us, I guess, as you cannot easily check for > GICv3/GICv2 compatibility with a _script_. Having access to ioctl's make > this pretty easy though: Just try to call KVM_CREATE_DEVICE with the >

Re: [libvirt] ARM KVM GICv3 Support

On Tue, Dec 15, 2015 at 04:03:13PM +, Peter Maydell wrote: > On 15 December 2015 at 14:12, Martin Kletzander wrote: > > On Tue, Dec 15, 2015 at 09:41:02AM +, Peter Maydell wrote: > >> > >> On 15 December 2015 at 09:36, Martin Kletzander > >>

Re: [libvirt] ARM KVM GICv3 Support

On Tue, Dec 15, 2015 at 05:53:43PM +0100, Andrea Bolognani wrote: > On Tue, 2015-12-15 at 10:35 -0600, Andrew Jones wrote: > > On Tue, Dec 15, 2015 at 04:03:13PM +, Peter Maydell wrote: > > > On 15 December 2015 at 14:12, Martin Kletzander > > > wrote: > > > > On Tue,

Re: [libvirt] [PATCH v2] pci: Use virPCIDeviceAddress in virPCIDevice

On 12/15/2015 05:48 AM, Andrea Bolognani wrote: On Tue, 2015-12-15 at 10:05 +0100, Andrea Bolognani wrote: @@ -1661,25 +1661,14 @@ virPCIDeviceFree(virPCIDevicePtr dev) * @dev: device to get address from * * Take a PCI device on input and return its PCI address. The - * caller must

Re: [libvirt] ARM KVM GICv3 Support

On Tue, 2015-12-15 at 10:35 -0600, Andrew Jones wrote: > On Tue, Dec 15, 2015 at 04:03:13PM +, Peter Maydell wrote: > > On 15 December 2015 at 14:12, Martin Kletzander wrote: > > > On Tue, Dec 15, 2015 at 09:41:02AM +, Peter Maydell wrote: > > > > > > > > On 15

Re: [libvirt] ARM KVM GICv3 Support

On Tue, Dec 15, 2015 at 04:42:13PM +, Peter Maydell wrote: > On 15 December 2015 at 16:35, Andrew Jones wrote: > > This is probably good for guests that happy with both. Guests that > > need/want a specific choice will put their integer there, and then > > we need a way to

Re: [libvirt] ARM KVM GICv3 Support

On 15 December 2015 at 14:12, Martin Kletzander wrote: > On Tue, Dec 15, 2015 at 09:41:02AM +, Peter Maydell wrote: >> >> On 15 December 2015 at 09:36, Martin Kletzander >> wrote: >>> >>> We do pass some options, for example, you can restrict the GIC

Re: [libvirt] ARM KVM GICv3 Support

On 15 December 2015 at 16:53, Andrea Bolognani wrote: > The behaviour of the value '2' has been defined as "don't specify any > GIC version" though, and I'm afraid we'll be unable to change that > because it would affect existing guests. Martin can probably weigh in. QEMU

Re: [libvirt] ARM KVM GICv3 Support

On 12/15/2015 11:53 AM, Andrea Bolognani wrote: > On Tue, 2015-12-15 at 10:35 -0600, Andrew Jones wrote: >> On Tue, Dec 15, 2015 at 04:03:13PM +, Peter Maydell wrote: >>> On 15 December 2015 at 14:12, Martin Kletzander wrote: On Tue, Dec 15, 2015 at 09:41:02AM

Re: [libvirt] libvirt qcow2 internal snapshot without vm state

2015-12-15 10:21 GMT+03:00 Peter Krempa : > You could possibly do that with 'blockdev-snapshot-internal-sync', but > libvirt doesn't support that yet. Internal snapshots are always with > memory state if the VM is online at the time the snapshot is taken. Thanks! May be this

Re: [libvirt] ARM KVM GICv3 Support

On 15 December 2015 at 16:35, Andrew Jones wrote: > This is probably good for guests that happy with both. Guests that > need/want a specific choice will put their integer there, and then > we need a way to do a capabilities check before launching that guest > on an arbitrary

Re: [libvirt] [PATCH 0/5] Fix issues with activating pool with invalid source

On 12/07/2015 03:47 PM, John Ferlan wrote: > These patches resolve issues with 'FS', 'NFS', and 'LOGICAL' pools where > if the pool source device didn't match the reality what was running on > the host there were inconsistent results. > > For the file pools, a pool would be declared 'active'

Re: [libvirt] vf configuration cleanup when VM is delete

On 12/13/2015 10:51 AM, Moshe Levi wrote: Hi, I have a setup with libvirt 1.3.0 and OpenStack trunk. Before launched the VM ip link command show the following VF mac/vlan configuration [1] When I launch a VM with via openstack api (OpenStack direct port) I can see that the VF get the

Re: [libvirt] [PATCH v2] pci: Use virPCIDeviceAddress in virPCIDevice

On Tue, 2015-12-15 at 12:27 -0500, Laine Stump wrote: > On 12/15/2015 05:48 AM, Andrea Bolognani wrote: > > On Tue, 2015-12-15 at 10:05 +0100, Andrea Bolognani wrote: > > > @@ -1661,25 +1661,14 @@ virPCIDeviceFree(virPCIDevicePtr dev) > > > * @dev: device to get address from > > > * > > >  

[libvirt] [PATCH] qemu: Fix event generated for qemuDomainRevertToSnapshot (pause->run)

A closer review of the code shows that for the transition from paused to running which was supposed to emit the VIR_DOMAIN_EVENT_RESUMED - no event would be generated. Rather the event is generated when going from running to running. Following the 'was_running' boolean shows it is set when the

[libvirt] [PATCH v2] storage: Attempt to refresh volume after successful wipe volume

https://bugzilla.redhat.com/show_bug.cgi?id=1270709 When a volume wipe is successful, perform a volume refresh afterwards to update any volume data that may be used in future volume commands, such as volume resize. For a raw file volume, a wipe could truncate the file and a followup volume

Re: [libvirt] [PATCH v3] pci: Use virPCIDeviceAddress in virPCIDevice

On 12/15/2015 01:23 PM, Andrea Bolognani wrote: Instead of replicating the information (domain, bus, slot, function) inside the virPCIDevice structure, use the already-existing virPCIDeviceAddress structure. For users of the module, this means that the object returned by

[libvirt] [PATCH v3] pci: Use virPCIDeviceAddress in virPCIDevice

Instead of replicating the information (domain, bus, slot, function) inside the virPCIDevice structure, use the already-existing virPCIDeviceAddress structure. For users of the module, this means that the object returned by virPCIDeviceGetAddress() can no longer be NULL and must no longer be

Re: [libvirt] vf configuration cleanup when VM is delete

On 12/15/2015 01:34 PM, Laine Stump wrote: On 12/13/2015 10:51 AM, Moshe Levi wrote: Hi, I have a setup with libvirt 1.3.0 and OpenStack trunk. Before launched the VM ip link command show the following VF mac/vlan configuration [1] When I launch a VM with via openstack api (OpenStack

Re: [libvirt] ARM KVM GICv3 Support

Hi, On 15/12/15 16:42, Peter Maydell wrote: > On 15 December 2015 at 16:35, Andrew Jones wrote: >> This is probably good for guests that happy with both. Guests that >> need/want a specific choice will put their integer there, and then >> we need a way to do a capabilities

Re: [libvirt] [PATCHv2 1/4] conf: Add helpers to insert/remove/find shmem devices in domain def

On 12/10/2015 08:50 AM, John Ferlan wrote: On 11/26/2015 04:06 AM, Luyao Huang wrote: The helpers will be useful when implementing hotplug and coldplug of shared memory devices. Signed-off-by: Luyao Huang --- src/conf/domain_conf.c | 66

[libvirt] [PATCH v2] pci: Use virPCIDeviceAddress in virPCIDevice

Instead of replicating the information (domain, bus, slot, function) inside the virPCIDevice structure, use the already-existing virPCIDeviceAddress structure. Outside of the module, the only visible change is that the return value of virPCIDeviceGetAddress() must no longer be freed by the

[libvirt] [PATCH] qemuMonitorJSONEjectMedia: Don't leak stringified reply

The return value of virJSONValueToString() should be freed when no longer needed. This is not the case after 256496e1. ==26902== 138 bytes in 2 blocks are definitely lost in loss record 1,051 of 1,239 ==26902==at 0x4C29F80: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)

Re: [libvirt] ARM KVM GICv3 Support

On 15 December 2015 at 09:36, Martin Kletzander wrote: > We do pass some options, for example, you can restrict the GIC to v2: > https://libvirt.org/formatdomain.html#elementsFeatures > > That could be modified to work for your purpose IIUC, right? What does that option do

Re: [libvirt] [PATCH] pci: Use 'addr' instead of 'dev' for virPCIDeviceAddressPtr

On Tue, Dec 15, 2015 at 10:01:23AM +0100, Andrea Bolognani wrote: The name 'dev' is more appropriate for virPCIDevicePtr. --- src/util/virpci.c | 7 --- src/util/virpci.h | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) ACK, trivial. You could also fix the

Re: [libvirt] [PATCHv2 3/4] qemu: Implement share memory device hot-plug

On 12/10/2015 09:23 AM, John Ferlan wrote: $SUBJ s/share/shared thanks for pointing out this On 11/26/2015 04:06 AM, Luyao Huang wrote: Signed-off-by: Luyao Huang --- src/qemu/qemu_driver.c | 10 - src/qemu/qemu_hotplug.c | 58

Re: [libvirt] [PATCHv2 4/4] qemu: Implement shared memory device hot-unplug

On 12/10/2015 09:43 AM, John Ferlan wrote: On 11/26/2015 04:07 AM, Luyao Huang wrote: Signed-off-by: Luyao Huang --- src/qemu/qemu_driver.c | 4 ++- src/qemu/qemu_hotplug.c | 94 - src/qemu/qemu_hotplug.h | 3 ++ 3

[libvirt] [PATCH] qemuMonitorJSONEjectMedia: don't stringify the replay at all

Commit 256496e1 introduced a detection if "is locked" in error replay from qemu monitor. Commit c4073657 fixed a memory leak, but it was pointed out by Peter, that this could be done cleaner without stringifing the replay. Signed-off-by: Pavel Hrdina ---

Re: [libvirt] Exclusive VM lock

On Mon, Dec 14, 2015 at 06:50:56PM +0300, Dmitry Andreev wrote: On 14.12.2015 18:10, Peter Krempa wrote: On Mon, Dec 14, 2015 at 17:18:22 +0300, Dmitry Andreev wrote: Hi, I'm looking for a mechanism to do a sequence of API calls as atomic operation. Is there any way for libvirt's API client

Re: [libvirt] [PATCHv2 2/4] qemu: Implement shared memory device cold (un)plug

On 12/10/2015 08:53 AM, John Ferlan wrote: On 11/26/2015 04:06 AM, Luyao Huang wrote: Add support for using the attach/detach device APIs on the inactive configuration to add/del shared memory devices. Signed-off-by: Luyao Huang --- src/libvirt_private.syms | 1 +

Re: [libvirt] [PATCH 2/2] qemu: emit 'defined' event after reverted to snapshot

On 14.12.2015 23:10, John Ferlan wrote: On 12/09/2015 03:29 AM, Dmitry Andreev wrote: Config file is changed. VIR_DOMAIN_EVENT_DEFINED should be emitted --- src/qemu/qemu_driver.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c

[libvirt] [PATCH] pci: Use 'addr' instead of 'dev' for virPCIDeviceAddressPtr

The name 'dev' is more appropriate for virPCIDevicePtr. --- src/util/virpci.c | 7 --- src/util/virpci.h | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/util/virpci.c b/src/util/virpci.c index bb874ac..9cc4613 100644 --- a/src/util/virpci.c +++ b/src/util/virpci.c

Re: [libvirt] [PATCH] qemuMonitorJSONEjectMedia: Don't leak stringified reply

On Tue, Dec 15, 2015 at 10:17:23AM +0100, Michal Privoznik wrote: > The return value of virJSONValueToString() should be freed when > no longer needed. This is not the case after 256496e1. > > ==26902== 138 bytes in 2 blocks are definitely lost in loss record 1,051 of > 1,239 > ==26902==at

Re: [libvirt] [PATCH] pci: Use virPCIDeviceAddress in virPCIDevice

On Mon, 2015-12-14 at 14:46 -0500, Laine Stump wrote: > On 12/14/2015 09:42 AM, Andrea Bolognani wrote: > > Instead of replicating the information (domain, bus, slot, function) > > inside the virPCIDevice structure, use the already-existing > > virPCIDeviceAddress structure. > > You use

Re: [libvirt] [PATCH] qemuMonitorJSONEjectMedia: Don't leak stringified reply

On Tue, Dec 15, 2015 at 10:17:23AM +0100, Michal Privoznik wrote: > The return value of virJSONValueToString() should be freed when > no longer needed. This is not the case after 256496e1. > > ==26902== 138 bytes in 2 blocks are definitely lost in loss record 1,051 of > 1,239 > ==26902==at

Re: [libvirt] ARM KVM GICv3 Support

On Mon, Dec 14, 2015 at 10:47:26AM -0600, Andrew Jones wrote: On Mon, Dec 14, 2015 at 12:31:59PM +0100, Christoffer Dall wrote: Hi all, I'm trying to figure out what the correct solution for libvirt support for ARM KVM guests with GICv3 is. The challenge is that QEMU's virt machine model

[libvirt] [PATCH 1/3 v2] vz: allow to create container based on template

We shouldn't delete disk from default config if we create container based on template, because we don't have the new disk from XML, only template name. And don't add template section from XML as new filesystem, we use PrlVmCfg_SetOsTemplate function to set template name. Do not set

[libvirt] [PATCH 0/3] vz: allow to create CT from template and boot VM from cdrom

Mikhail Feoktistov (3): vz: allow to create container based on template vz: allow to boot VM from cdrom vz: implementation of boot device order src/vz/vz_sdk.c | 174 1 file changed, 125 insertions(+), 49 deletions(-) -- 1.8.3.1

[libvirt] [PATCH 2/3 v2] vz: allow to boot VM from cdrom

If user creates virtual machine via virt-manager and select "boot from ISO" then in libvirt we can see the following devices section These devices don't have disk->format parameter, so we should allow to add disks with format = VIR_STORAGE_FILE_NONE.

Re: [libvirt] [PATCH] qemuMonitorJSONEjectMedia: don't stringify the replay at all

On 15.12.2015 11:08, Pavel Hrdina wrote: > Commit 256496e1 introduced a detection if "is locked" in error replay > from qemu monitor. Commit c4073657 fixed a memory leak, but it was > pointed out by Peter, that this could be done cleaner without > stringifing the replay. > > Signed-off-by: Pavel

Re: [libvirt] [PATCH] pci: Use 'addr' instead of 'dev' for virPCIDeviceAddressPtr

On Tue, 2015-12-15 at 10:41 +0100, Martin Kletzander wrote: > On Tue, Dec 15, 2015 at 10:01:23AM +0100, Andrea Bolognani wrote: > > The name 'dev' is more appropriate for virPCIDevicePtr. > > --- > > src/util/virpci.c | 7 --- > > src/util/virpci.h | 4 ++-- > > 2 files changed, 6 insertions(+),

Re: [libvirt] ARM KVM GICv3 Support

Hello! Nobody ever CCed me, so i saw this topic only occasionally... Sorry for the late reply. > The challenge is that QEMU's virt machine model defaults to GICv2 unless > you specify an additional "-machine gic-version=host" parameter to QEMU, > in which case your VM gets the same GIC

Re: [libvirt] [PATCH] qemu: Warn when using vhost-user without shared memory

On 12/08/2015 10:24 AM, Martin Kletzander wrote: > When user configures vhost-user interface and forgets to also configure > any shared memory, the search for the root cause of non-operational > interface might take unpleasantly long time. Let's enhance user > experience by emitting a warning

[libvirt] [PATCH 1/3 v3] vz: allow to create container based on template

We shouldn't delete disk from default config if we create container based on template, because we don't have the new disk from XML, only template name. And don't add template section from XML as new filesystem, we use PrlVmCfg_SetOsTemplate function to set template name. Do not set

[libvirt] [PATCH 3/3 v2] vz: implementation of boot device order

This patch implements functionality of boot device order based on boot element from os section in XML. Now we support boot from CDROM and HDD. If we have several devices of the same type (for example hdd0 and hdd1), than we mark the first one as bootable. --- diff from v1: Move this commit to

Re: [libvirt] ARM KVM GICv3 Support

On Tue, Dec 15, 2015 at 10:36:32AM +0100, Martin Kletzander wrote: > On Mon, Dec 14, 2015 at 10:47:26AM -0600, Andrew Jones wrote: > >On Mon, Dec 14, 2015 at 12:31:59PM +0100, Christoffer Dall wrote: > >>Hi all, > >> > >>I'm trying to figure out what the correct solution for libvirt support >

Re: [libvirt] qemu logging/tracing option in domain xml

On Mon, Dec 14, 2015 at 04:52:43PM +0300, Dmitry Andreev wrote: > Hi all, > > QEMU has the '-d' command line option to configure logs/traces. > As I can see, is the only way to set it in domain xml. > > makes a configuration tainted and doesn't allow to update > tracing/logging configuration

Re: [libvirt] [PATCH] qemuMonitorJSONEjectMedia: don't stringify the replay at all

On Tue, Dec 15, 2015 at 11:22:41AM +0100, Michal Privoznik wrote: > On 15.12.2015 11:08, Pavel Hrdina wrote: > > Commit 256496e1 introduced a detection if "is locked" in error replay > > from qemu monitor. Commit c4073657 fixed a memory leak, but it was > > pointed out by Peter, that this could be

[libvirt] [PATCH 3/3 v2] vz: implementation of boot device order

This patch implements functionality of boot device order based on boot element from os section in XML. Now we support boot from CDROM and HDD. If we have several devices of the same type (for example hdd0 and hdd1), than we mark the first one as bootable. --- diff from v1: Move this commit to

Re: [libvirt] ARM KVM GICv3 Support

On Mon, Dec 14, 2015 at 10:47:26AM -0600, Andrew Jones wrote: > On Mon, Dec 14, 2015 at 12:31:59PM +0100, Christoffer Dall wrote: > > Hi all, > > > > I'm trying to figure out what the correct solution for libvirt support > > for ARM KVM guests with GICv3 is. > > > > The challenge is that QEMU's

Re: [libvirt] [PATCH v2] pci: Use virPCIDeviceAddress in virPCIDevice

On Tue, 2015-12-15 at 10:05 +0100, Andrea Bolognani wrote: > @@ -1661,25 +1661,14 @@ virPCIDeviceFree(virPCIDevicePtr dev) >   * @dev: device to get address from >   * >   * Take a PCI device on input and return its PCI address. The > - * caller must free the returned value when no longer needed.

Re: [libvirt] ARM KVM GICv3 Support

On Tue, 2015-12-15 at 11:11 +0100, Christoffer Dall wrote: > On Tue, Dec 15, 2015 at 10:36:32AM +0100, Martin Kletzander wrote: > > On Mon, Dec 14, 2015 at 10:47:26AM -0600, Andrew Jones wrote: > > > On Mon, Dec 14, 2015 at 12:31:59PM +0100, Christoffer Dall wrote: > > > > Hi all, > > > > > > > >

Re: [libvirt] [PATCH] Revert "admin: Rename virAdmConnect to virAdmDaemon"

On Tue, Dec 15, 2015 at 08:30:41AM +0100, Martin Kletzander wrote: > On Mon, Dec 14, 2015 at 09:31:33AM +0100, Erik Skultety wrote: > >On 10/12/15 15:54, Daniel P. Berrange wrote: > >>On Thu, Dec 10, 2015 at 03:46:45PM +0100, Erik Skultety wrote: > >>>Commmit df8192aa introduced admin related

[libvirt] [PATCH 2/3 v2] vz: allow to boot VM from cdrom

If user creates virtual machine via virt-manager and select "boot from ISO" then in libvirt we can see the following devices section These devices don't have disk->format parameter, so we should allow to add disks with format = VIR_STORAGE_FILE_NONE.

[libvirt] [PATCH 0/3] vz: allow to create CT from template and boot VM from cdrom

Mikhail Feoktistov (3): vz: allow to create container based on template vz: allow to boot VM from cdrom vz: implementation of boot device order src/vz/vz_sdk.c | 174 1 file changed, 125 insertions(+), 49 deletions(-) -- 1.8.3.1

Re: [libvirt] [PATCH v7 06/13] virstoragefile: Add virStorageSourceIsRAID

On 12/03/2015 09:35 AM, Matthias Gatto wrote: > Add a new function which return true if a virStorageSourcePtr is > a RAID. > > For now, quorum is the only RAID we have. > > This function is usefull, because, a lot of code access directly > to a virStorageSource internal member (like path) with

Re: [libvirt] [PATCH v7 05/13] virstoragefile: change backingStore to backingStores.

On 12/03/2015 09:35 AM, Matthias Gatto wrote: > The backingStore field was a virStorageSourcePtr. > Because a quorum can contain more that one backingStore at the same level, > it's now an array of 'virStorageSourcePtr'. > > This patch rename src->backingStore to src->backingStores, > Made the

[libvirt] [PATCH 01/16] Xen: tests: remove old xm config tests

Remove xm config tests for old xend 3.0.2 config format. Signed-off-by: Jim Fehlig --- tests/xmconfigdata/test-fullvirt-old-cdrom.cfg | 26 tests/xmconfigdata/test-fullvirt-old-cdrom.xml | 49 --

[libvirt] [PATCH 12/16] Xen: xenconfig: remove use of XEND_CONFIG_VERSION in xen_sxpr

Remove use of XEND_CONFIG_VERSION_* in s-expression parser/formatter. Signed-off-by: Jim Fehlig --- src/xenconfig/xen_sxpr.c | 285 ++- 1 file changed, 107 insertions(+), 178 deletions(-) diff --git a/src/xenconfig/xen_sxpr.c

[libvirt] [PATCH 13/16] Xen: xen_driver: remove use of XEND_CONFIG_VERSION

Remove use of XEND_CONFIG_VERSION_* in the Xen unified driver. Signed-off-by: Jim Fehlig --- src/xen/xen_driver.c | 284 +++ 1 file changed, 61 insertions(+), 223 deletions(-) diff --git a/src/xen/xen_driver.c

[libvirt] [PATCH 02/16] Xen: tests: remove net-ioemu xm config test

Remove the fullvirt-net-ioemu test since explicitly specifying 'type=ioemu' has not been needed in xm/xend for a long time. It is not used at all in xl/libxl. Signed-off-by: Jim Fehlig --- tests/xmconfigdata/test-fullvirt-net-ioemu.cfg | 25 -

[libvirt] [PATCH 03/16] Xen: tests: remove old sexpr2xml tests

Remove s-expression to XML conversion tests for old xend 3.0.2 config format. Signed-off-by: Jim Fehlig --- tests/sexpr2xmldata/sexpr2xml-fv-net-ioemu.sexpr | 9 - tests/sexpr2xmldata/sexpr2xml-fv-net-ioemu.xml | 48

[libvirt] [PATCH 10/16] Xen: xenconfig: remove disks from '(image)' sexpr

It has been quite some time since xend required specifying cdroms and fds in '(image (hvm ...))'. Remove the code from the parsing and formatting functions and fixup the associated tests. Signed-off-by: Jim Fehlig --- src/xenconfig/xen_sxpr.c | 94

[libvirt] [PATCH 11/16] Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests

Change all xml2sexpr tests to use the latest XEND_CONFIG_VERSION (XEND_CONFIG_VERSION_3_1_0 = 4). Fix tests that do not conform to the latest version. Signed-off-by: Jim Fehlig --- tests/xml2sexprdata/xml2sexpr-boot-grub.sexpr | 4 +-

[libvirt] [PATCH 15/16] Xen: xenconfig: remove xendConfigVersion from public sexpr functions

Remove use of xendConfigVersion in the s-expresion config formatter/parser in src/xenconfig/. Adjust callers in the xen and libxl drivers accordingly. Signed-off-by: Jim Fehlig --- src/libxl/libxl_driver.c | 1 - src/xen/xen_driver.c | 6 +++---

[libvirt] [PATCH 09/16] Xen: tests: use latest XEND_CONFIG_VERSION in sexpr2xml tests

Change all sexpr2xml tests to use the latest XEND_CONFIG_VERSION (XEND_CONFIG_VERSION_3_1_0 = 4). Fix tests that do not conform to the latest version. Signed-off-by: Jim Fehlig --- tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml | 2 +-

[libvirt] [PATCH 14/16] Xen: xend: remove use of XEND_CONFIG_VERSION

Remove use of XEND_CONFIG_VERSION_* in xend_internal.c Signed-off-by: Jim Fehlig --- src/xen/xend_internal.c | 167 1 file changed, 27 insertions(+), 140 deletions(-) diff --git a/src/xen/xend_internal.c

[libvirt] [PATCH 07/16] Xen: xenconfig: remove use of XEND_CONFIG_VERSION in xen_xm

Remove use of XEND_CONFIG_VERSION_* in xm parser/formatter. Signed-off-by: Jim Fehlig --- src/xenconfig/xen_xm.c | 40 1 file changed, 4 insertions(+), 36 deletions(-) diff --git a/src/xenconfig/xen_xm.c b/src/xenconfig/xen_xm.c index

[libvirt] [PATCH 08/16] Xen: xenconfig: remove xendConfigVersion from public functions

Remove use of xendConfigVersion in the xm and xl config formatter/parsers in src/xenconfig/. Adjust callers in the xen and libxl drivers accordingly. Signed-off-by: Jim Fehlig --- src/libxl/libxl_driver.c | 8 +++- src/xen/xen_driver.c | 5 ++---

[libvirt] [PATCH 16/16] Xen: remove xendConfigVersion from driver private struct

xendConfigVersion is no longer used, so remove it from the xenUnifiedPrivate struct. Signed-off-by: Jim Fehlig --- src/xen/xen_driver.c| 1 - src/xen/xen_driver.h| 2 -- src/xen/xend_internal.c | 37 - 3 files changed, 4

[libvirt] [PATCH 05/16] Xen: tests: use latest XEND_CONFIG_VERSION in xm/xl tests

Change all tests to use the latest XEND_CONFIG_VERSION (XEND_CONFIG_VERSION_3_1_0 = 4). Fix tests that do not conform to the latest version. Signed-off-by: Jim Fehlig --- .../test-fullvirt-direct-kernel-boot.cfg | 3 +- .../test-fullvirt-direct-kernel-boot.xml

[libvirt] [PATCH 00/16] Xen: remove xend config version

Hi All, Ian Campbell recently attempted [1] to fix and issue around MAX_VIRT_VPUS on ARM that required adding a new XEND_CONFIG_VERSION. After some discussion [2] we decided to drop support for all of the old xend config versions and go with the version supported in Xen 4.0, since the xl syntax

[libvirt] [PATCH 04/16] Xen: tests: remove old xml2sexpr tests

Remove XML to s-expression converstion tests for old xend 3.0.2 config format. Signed-off-by: Jim Fehlig --- tests/xml2sexprdata/xml2sexpr-fv-net-ioemu.sexpr | 9 --- tests/xml2sexprdata/xml2sexpr-fv-net-ioemu.xml | 31

[libvirt] [PATCH 06/16] Xen: xenconfig: remove XEND_CONFIG_VERSION in common code

Remove use of XEND_CONFIG_VERSION_* from xenconfig/xen_common.c Signed-off-by: Jim Fehlig --- src/xenconfig/xen_common.c | 209 +++-- 1 file changed, 71 insertions(+), 138 deletions(-) diff --git a/src/xenconfig/xen_common.c

[libvirt] [PATCH V2] Xen: support maxvcpus in xm and xl config

From: Ian Campbell xend prior to 4.0 understands vcpus as maxvcpus and vcpu_avail as a bit map of which cpus are online (default is all). xend from 4.0 onwards understands maxvcpus as maxvcpus and vcpus as the number which are online (from 0..N-1). The upstream commit

Re: [libvirt] [PATCH v3 8/8] libxl: implement virDomainGetJobStats

On 12/03/2015 12:29 PM, Joao Martins wrote: > > On 12/03/2015 06:48 PM, Jim Fehlig wrote: >> Joao Martins wrote: >>> Introduces support for domainGetJobStats which has the same >>> info as domainGetJobInfo but in a slightly different format. >>> Another difference is that virDomainGetJobStats can

Re: [libvirt] [PATCH v7 04/13] virstoragefile: Always use virStorageSourceSetBackingStore to set backing store

On 12/03/2015 09:35 AM, Matthias Gatto wrote: > Replace the parts of the code where a backing store is set manually > with virStorageSourceSetBackingStore > > Signed-off-by: Matthias Gatto > Signed-off-by: John Ferlan > --- >

Re: [libvirt] vf configuration cleanup when VM is delete

On 12/15/2015 04:12 PM, Vlad Yasevich wrote: On 12/15/2015 02:45 PM, Laine Stump wrote: On 12/15/2015 01:34 PM, Laine Stump wrote: On 12/13/2015 10:51 AM, Moshe Levi wrote: Hi, I have a setup with libvirt 1.3.0 and OpenStack trunk. Before launched the VM ip link command show the following

[libvirt] [PATCH v8 2/5] virstoragefile: Add helper to set storage source backingStore

From: Matthias Gatto Add a new helper - virStorageSourceSetBackingStore - to set the storage source backingStore pointer in order to make it easier to change the future format of the data. A future patch will adjust the backingStore pointer to become a table or

[libvirt] [PATCH v8 5/5] virstoragefile: Convert storage source backingStore into backingStores

From: Matthias Gatto Convert the storage source backingStore pointer into an array of virStorageSourcePtr. This patch will rename src->backingStore to src->backingStores, add an nbackingStores, and adjust the code Get and Set functions to handle the the array.

[libvirt] [PATCH v8 0/5] Partial posting of updates to Add quorum to libvirt

I took a few cycles to reformat the initial 5 patches of the add quorum support posted as a v7 here: http://www.redhat.com/archives/libvir-list/2015-December/msg00119.html These patches are easily separable from the rest of the series. Rather than see things linger for months on end, trying to

[libvirt] [PATCH v8 1/5] virstoragefile: Add helper to get storage source backingStore

From: Matthias Gatto Add a new helper - virStorageSourceGetBackingStore - to fetch the storage source backingStore pointer in order to make it easier to change the future format of the data. A future patch will adjust the backingStore pointer to become a table or

Re: [libvirt] [Xen-devel] [PATCH LIBVIRT] libxl: Use libxentoollog in preference to libxenctrl if available.

On 12/14/2015 04:37 AM, Ian Campbell wrote: > On Mon, 2015-12-14 at 11:15 +, Daniel P. Berrange wrote: >> On Thu, Dec 10, 2015 at 11:38:36AM +, Ian Campbell wrote: >>> Upstream Xen is in the process of splitting the (stable API) xtl_* >>> interfaces out from the (unstable API) libxenctrl

[libvirt] [PATCH v8 3/5] virstoragefile: Use helper to get storage source backing store

From: Matthias Gatto Convert all ->backingStore fetches into a virStorageSourceGetBackingStore call using 0 as the pos in order to fetch. Signed-off-by: Matthias Gatto Signed-off-by: John Ferlan ---

[libvirt] [PATCH v8 4/5] virstoragefile: Use helper to set storage source backing store

From: Matthias Gatto Convert all ->backingStore stores into a virStorageSourceSetBackingStore call using 0 as the pos in order to store. Signed-off-by: Matthias Gatto Signed-off-by: John Ferlan ---

Re: [libvirt] [PATCH 4/5] storage: Create helper for virStorageBackendLogicalFindPoolSources

On 07.12.2015 21:47, John Ferlan wrote: > Rework virStorageBackendLogicalFindPoolSources a bit to create a > helper virStorageBackendLogicalGetPoolSources that will make the > pvs call in order to generate a list of associated pv_name and vg_name's. > > A future patch will make use of this for

Re: [libvirt] [PATCH 2/5] storage: Refactor virStorageBackendFileSystemGetPoolSource

On 07.12.2015 21:47, John Ferlan wrote: > Refactor code to use standard return functioning with respect to setting > a ret value and going to cleanup. > > Signed-off-by: John Ferlan > --- > src/storage/storage_backend_fs.c | 12 > 1 file changed, 8

Re: [libvirt] [PATCH 1/5] storage: Create helper to generate FS pool source value

On 07.12.2015 21:47, John Ferlan wrote: > Refactor the code that builds the pool source string during the FS > storage pool mount to be a separate helper. > > A future patch will use the helper in order to validate the mounted > FS matches the pool's expectation during poolCheck processing > >

Re: [libvirt] [PATCH 5/5] storage: Add helper to compare logical pool def against pvs output

On 07.12.2015 21:47, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1025230 > > Add a new helper virStorageBackendLogicalMatchPoolSource to compare the > pool's source name against the output from a 'pvs' command to list all > volume group physical volume data on the host. In

Re: [libvirt] [PATCH 3/5] storage: Check FS pool source during virStorageBackendFileSystemIsMounted

On 07.12.2015 21:47, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1025230 > > When determining whether a FS pool is mounted, rather than assuming that > the FS pool is mounted just because the target.path is in the mount list, > let's make sure that the FS pool source matches

Re: [libvirt] Exclusive VM lock

On 15.12.2015 11:47, Martin Kletzander wrote: On Mon, Dec 14, 2015 at 06:50:56PM +0300, Dmitry Andreev wrote: On 14.12.2015 18:10, Peter Krempa wrote: On Mon, Dec 14, 2015 at 17:18:22 +0300, Dmitry Andreev wrote: Hi, I'm looking for a mechanism to do a sequence of API calls as atomic

Re: [libvirt] [PATCH v2 0/2] Add support for zero-write detection

On 12/14/2015 09:57 AM, Martin Kletzander wrote: > QEMU supports detect-zeroes option since version 2.1, but we never > added support for it in libvirt. If was requested by Vasiliy Tolstov > in the list, so I just added it. > > There are two discussions to be had, optionally. One is to decide

Re: [libvirt] [PATCHv2 4/4] qemu: Implement shared memory device hot-unplug

[...] >>> +if (rc < 0) >>> +return -1; >>> + >> I know this is a copy of the RemoveRNGDevice; however, this code doesn't >> remove an 'obj'. In fact, if !shmem->server.enabled, then we don't enter >> the monitor at all. >> >> Thus the following event probably won't happen... > > I am

Re: [libvirt] [PATCH v7 03/13] virstoragefile: Add virStorageSourceSetBackingStore

On 12/03/2015 09:35 AM, Matthias Gatto wrote: > As explained for virStorageSourceGetBackingStore, quorum allows > multiple backing store, this make the operation to set bs complex > because we have to check if the backingStore is used as an array > or a pointer, and set it differently in both

Re: [libvirt] vf configuration cleanup when VM is delete

On 12/15/2015 02:45 PM, Laine Stump wrote: > On 12/15/2015 01:34 PM, Laine Stump wrote: >> On 12/13/2015 10:51 AM, Moshe Levi wrote: >>> >>> Hi, >>> >>> I have a setup with libvirt 1.3.0 and OpenStack trunk. >>> >>> Before launched the VM ip link command show the following VF mac/vlan >>>

Re: [libvirt] [PATCH] qemu: Warn when using vhost-user without shared memory

On Tue, Dec 15, 2015 at 06:44:25AM -0500, John Ferlan wrote: On 12/08/2015 10:24 AM, Martin Kletzander wrote: When user configures vhost-user interface and forgets to also configure any shared memory, the search for the root cause of non-operational interface might take unpleasantly long

Re: [libvirt] volume download/upload but for snapshots

2015-12-15 17:14 GMT+03:00 Michal Privoznik : > Defining a volume would be just to workaround the problem. I think it > deserves a separate API. Whether someone from libvirt dev can help with this ?=) -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru -- libvir-list mailing

Re: [libvirt] ARM KVM GICv3 Support

On Tue, Dec 15, 2015 at 09:41:02AM +, Peter Maydell wrote: On 15 December 2015 at 09:36, Martin Kletzander wrote: We do pass some options, for example, you can restrict the GIC to v2: https://libvirt.org/formatdomain.html#elementsFeatures That could be modified to

Re: [libvirt] Exclusive VM lock

On Tue, Dec 15, 2015 at 03:26:44PM +0300, Dmitry Andreev wrote: On 15.12.2015 11:47, Martin Kletzander wrote: On Mon, Dec 14, 2015 at 06:50:56PM +0300, Dmitry Andreev wrote: On 14.12.2015 18:10, Peter Krempa wrote: On Mon, Dec 14, 2015 at 17:18:22 +0300, Dmitry Andreev wrote: Hi, I'm

  1   2   >