[libvirt] [PATCH 0/4] conf: snapshot: refactor and fix autogenerated duplicate snapshot targets

Peter Krempa (4): conf: snapshot: Rename disksorter to virDomainSnapshotCompareDiskIndex snapshot: conf: Extract code to generate default external file names conf: snapshot: Refactor virDomainSnapshotDefAssignExternalNames conf: snapshot: Avoid autogenerating duplicate snapshot names

[libvirt] [PATCH 2/4] snapshot: conf: Extract code to generate default external file names

--- src/conf/snapshot_conf.c | 131 --- 1 file changed, 77 insertions(+), 54 deletions(-) diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c index 65a78d6..da6fec5 100644 --- a/src/conf/snapshot_conf.c +++ b/src/conf/snapshot_conf.c @@

[libvirt] [PATCH 3/4] conf: snapshot: Refactor virDomainSnapshotDefAssignExternalNames

Get rid of one indentation level by negating condition and remove ugly pointer arithmetic at the cost of one extra allocation. --- src/conf/snapshot_conf.c | 94 +++- 1 file changed, 44 insertions(+), 50 deletions(-) diff --git

[libvirt] [PATCH 1/4] conf: snapshot: Rename disksorter to virDomainSnapshotCompareDiskIndex

Stick to the naming pattern. --- src/conf/snapshot_conf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c index 1eda7c2..65a78d6 100644 --- a/src/conf/snapshot_conf.c +++ b/src/conf/snapshot_conf.c @@ -430,7 +430,7 @@

[libvirt] [PATCH 4/4] conf: snapshot: Avoid autogenerating duplicate snapshot names

The snapshot name generator truncates the original file name after a '.' and replaces the suffix with the snapshot name. If two disks source images differ only in the suffix portion, the generated name will be duplicate. Since this is a corner case just error out stating that a duplicate name was

Re: [libvirt] [PATCH] Revert "tests: Don't link mock libraries against libvirt and gnulib"

On Thu, Feb 11, 2016 at 09:54:45AM +0100, Andrea Bolognani wrote: > On Wed, 2016-02-10 at 18:09 +, Daniel P. Berrange wrote: > > On Wed, Feb 10, 2016 at 06:33:21PM +0100, Andrea Bolognani wrote: > > > This reverts commit 6aa90452aa63cb1e1ffa84ff5f93f5873bf810a0. > > >  > > > Turns out that not

Re: [libvirt] [PATCH] Revert "tests: Don't link mock libraries against libvirt and gnulib"

On Wed, 2016-02-10 at 18:09 +, Daniel P. Berrange wrote: > On Wed, Feb 10, 2016 at 06:33:21PM +0100, Andrea Bolognani wrote: > > This reverts commit 6aa90452aa63cb1e1ffa84ff5f93f5873bf810a0. > >  > > Turns out that not linking against libvirt and gnulib is okay for > > regular Linux (and

Re: [libvirt] [PATCH] Prohibit verbose strcat

On Thu, 2016-02-11 at 07:43 +0100, Ján Tomko wrote: > > > + halt='Use strcat(a, b) instead of strncat(a, b, strlen())' \ > > > > s/strlen()/strlen(b)/ > > That would make it match itself, so I limited the check to C files > in_vc_files='\.[ch]$$' Which is a good idea anyway, I guess :) Cheers.

Re: [libvirt] [PATCH 3/3] virsh: Add support for text based polkit authentication

On Wed, Feb 10, 2016 at 02:46:36PM -0500, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=872166 > > When the login session doesn't have an ssh -X type display agent in > order for libvirtd to run the polkit session authentication, attempts > to run 'virsh -c qemu:///system list'

Re: [libvirt] [PATCH] dbus: Don't unref NULL messages

On Thu, Feb 11, 2016 at 11:25:05AM +0100, Michal Privoznik wrote: > Apparently we are not the only ones with dumb free functions > because dbus_message_unref() does not accept NULL either. But if > I were to vote, this one is even more evil. Instead of returning > an error just like we do it

[libvirt] [PATCH 1/2] tests: Use plain close() in mock code

The virportallocatortest.c file is compiled both as a test case and as a mock library; in the latter case, it can't use VIR_FORCE_CLOSE() because mock libraries are not linked against libvirt. Replace VIR_FORCE_CLOSE() with plain close() to solve the issue. --- tests/virportallocatortest.c | 2

Re: [libvirt] [PATCH 0/2] tests: Fix mock libraries linking

On Thu, 2016-02-11 at 11:17 +, Daniel P. Berrange wrote: > On Thu, Feb 11, 2016 at 12:15:39PM +0100, Andrea Bolognani wrote: > > This patches make sure mock libraries do not link against either > > too many or too few libraries. > > > > Cheers. > > > > Andrea Bolognani (2): > >   tests: Use

Re: [libvirt] [PATCH 4/4] conf: snapshot: Avoid autogenerating duplicate snapshot names

On Thu, Feb 11, 2016 at 15:24:42 +0100, Erik Skultety wrote: > On 11/02/16 10:20, Peter Krempa wrote: > > The snapshot name generator truncates the original file name after a '.' > > and replaces the suffix with the snapshot name. If two disks source > > images differ only in the suffix portion,

Re: [libvirt] [PATCH 0/4] tests: Fix syntax-check failure, plus extras

On Thu, Feb 11, 2016 at 02:36:27PM +0100, Andrea Bolognani wrote: > Commit a03cbfe0fb introduced a syntax-check failure: patch > 1/4 prepares for 2/4, where the failure is actually fixed. > > Patches 3/4 and 4/4 improve the naming consistency for mock > libraries by shuffling files around a bit.

Re: [libvirt] [PATCH 1/4] tests: Split off the mock part of the port allocator test

On Thu, Feb 11, 2016 at 02:36:28PM +0100, Andrea Bolognani wrote: > Instead of compiling either the mock or the non-mock part of the > file based on a compiler flag, split the mock part off to its > own file. > --- > tests/Makefile.am| 4 +- > tests/virportallocatormock.c | 108

Re: [libvirt] Found mem leak in libvirtd, need help to debug

I still think these are libgfapi leaks; All the definitely lost bytes come from the library. ==6532== 3,064 (96 direct, 2,968 indirect) bytes in 1 blocks are definitely lost in loss record 1,106 of 1,142 ==6532==at 0x4C2C0D0: calloc (vg_replace_malloc.c:711) ==6532==by 0x10701279:

Re: [libvirt] [RFC] vhost-user + shared memory + NUMA

Hello! > > Ok, then would it be a good compromise if we require , and > > only implicitly > add "shared" if we have vhost-user > > devices? This way we would not change the way the guest memory is allocated. > > Adding shared implicitly *will* change the way guest memory is allocated, > as it

[libvirt] [PATCH] Error out on missing machine type in machine configs

Commit f1a89a8 allowed parsing configs from /etc/libvirt without validating the emulator capabilities. Check for the presence of os->type.machine even if the VIR_DOMAIN_DEF_PARSE_SKIP_OSTYPE_CHECKS flag is set, otherwise the daemon can crash on carelessly crafted input in the config directory.

Re: [libvirt] [PATCH 0/3] Add capability for text based polkit authentication for virsh

On Wed, Feb 10, 2016 at 02:46:33PM -0500, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=872166 > > As an alternative to commit id 'e94979e90' which allows polkit > authentication by adding users to the 'libvirt' group, add the > ability to start and utilize a text based

[libvirt] [PATCH] syntax-check: Allow plain close in virportallocatortest

After a03cbfe0fb9 we switched to a plain close() instead of VIR_FORCE_CLOSE(). This makes sense because it's a mocking library and thus should not require anything from libvirt. However, we forgot add an exemption to our 'forbid close' rule. Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH] syntax-check: Allow plain close in virportallocatortest

On Thu, 2016-02-11 at 13:18 +0100, Michal Privoznik wrote: > After a03cbfe0fb9 we switched to a plain close() instead of > VIR_FORCE_CLOSE(). This makes sense because it's a mocking > library and thus should not require anything from libvirt. > However, we forgot add an exemption to our 'forbid

[libvirt] [PATCH] dbus: Don't unref NULL messages

Apparently we are not the only ones with dumb free functions because dbus_message_unref() does not accept NULL either. But if I were to vote, this one is even more evil. Instead of returning an error just like we do it immediately dereference any pointer passed and thus crash you app. Well done

[libvirt] [PATCH 0/2] tests: Fix mock libraries linking

This patches make sure mock libraries do not link against either too many or too few libraries. Cheers. Andrea Bolognani (2): tests: Use plain close() in mock code tests: Link mock libraries against gnulib and gnulib only tests/Makefile.am| 21 +++--

[libvirt] [PATCH 2/2] tests: Link mock libraries against gnulib and gnulib only

Mock libraries should not be linked against libvirt, but some of them did - fix that. On the other hand, not linking against gnulib can cause build failures on mingw, so define a new $(MOCKLIBS_LIBS) variable and use it everywhere. --- tests/Makefile.am | 21 +++-- 1 file

[libvirt] VMware driver: SessionIsActive API / Sessions.ValidateSession permission

The VMware driver currently calls the SessionIsActive API, which requires the vCenter Sessions.ValidateSession permission. https://libvirt.org/git/?p=libvirt.git;a=blob;f=src/esx/esx_vi.c;h=af822b14cfc5ba93c9c2ab4dfa2cb72a23a74a1a;hb=HEAD#l2068 This causes a problem that you have to give this

Re: [libvirt] [PATCH 1/3] polkit: Adjust message when action-id isn't found

On Wed, Feb 10, 2016 at 02:46:34PM -0500, John Ferlan wrote: > When there isn't a ssh -X type session running and a user has not > been added to the libvirt group, attempts to run 'virsh -c qemu:///system' > commands from an otherwise unprivileged user will fail with rather > generic or opaque

Re: [libvirt] [PATCH 2/3] util: Introduce API's for Polkit text authentication

On Wed, Feb 10, 2016 at 02:46:35PM -0500, John Ferlan wrote: > Introduce virPolkitAgentCreate, virPolkitAgentCheck, and virPolkitAgentDestroy > > virPolkitAgentCreate will run the polkit pkttyagent image as an asynchronous > command in order to handle the local agent authentication via

[libvirt] [RFC] vhost-user + shared memory + NUMA

Hello! vhost-user has a small limitation: guest memory must be shared. However, this simple requirement is satisfied by Libvirt only in very complicated case: 1. We have to specify NUMA configuration, because we can have "shared" attribute only for node descriptors inside "NUMA" section. 2.

Re: [libvirt] [RFC] vhost-user + shared memory + NUMA

On Thu, Feb 11, 2016 at 01:28:47PM +0300, Pavel Fedin wrote: > Hello! > > vhost-user has a small limitation: guest memory must be shared. However, > this simple requirement is satisfied by Libvirt only in > very complicated case: > 1. We have to specify NUMA configuration, because we can have

[libvirt] [PATCH] qemu: add support for LSI SAS1068 (aka MPT Fusion) SCSI controller

This does nothing more than adding the new device and capability. The device is present since QEMU 2.6.0. Signed-off-by: Paolo Bonzini --- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 +

Re: [libvirt] [PATCH 0/2] tests: Fix mock libraries linking

On Thu, Feb 11, 2016 at 12:15:39PM +0100, Andrea Bolognani wrote: > This patches make sure mock libraries do not link against either > too many or too few libraries. > > Cheers. > > Andrea Bolognani (2): > tests: Use plain close() in mock code > tests: Link mock libraries against gnulib and

Re: [libvirt] [PATCH 4/4] conf: snapshot: Avoid autogenerating duplicate snapshot names

On 11/02/16 10:20, Peter Krempa wrote: > The snapshot name generator truncates the original file name after a '.' > and replaces the suffix with the snapshot name. If two disks source > images differ only in the suffix portion, the generated name will be > duplicate. > > Since this is a corner

Re: [libvirt] [PATCH] migration: add option to set target ndb server port

29.01.2016 18:18, Maxim Nestratov пишет: 13.01.2016 14:01, Nikolay Shirokovskiy пишет: Current libvirt + qemu pair lacks secure migrations in case of VMs with non-shared disks. The only option to migrate securely natively is to use tunneled mode and some kind of secure destination URI. But

Re: [libvirt] [PATCH v7 00/13] qemu: Add quorum support to libvirt

On Wed, Feb 10, 2016 at 17:01:22 +0200, Alberto Garcia wrote: > On Tue, Jan 26, 2016 at 05:36:36PM +0100, Peter Krempa wrote: [...] > > Whoah. Data corruption accross network? I'm not quite sure whether > > I'd use this to cover up a problem with the storage technology or > > network rather than

Re: [libvirt] [PATCHv3 0/2] notify about reverting to a snapshot

On Tue, Jan 05, 2016 at 17:19:19 -0500, John Ferlan wrote: > On 12/23/2015 09:25 AM, Dmitry Andreev wrote: > > Reverting to snapshot may change domain configuration but > > there will be no events about that. I'm afraid there will be more places like this ... > > > > Lack of the event become a

Re: [libvirt] [PATCH 2/4] snapshot: conf: Extract code to generate default external file names

On 11/02/16 10:20, Peter Krempa wrote: > --- > src/conf/snapshot_conf.c | 131 > --- > 1 file changed, 77 insertions(+), 54 deletions(-) > > diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c > index 65a78d6..da6fec5 100644 > ---

Re: [libvirt] [RFC] vhost-user + shared memory + NUMA

On Thu, Feb 11, 2016 at 01:54:49PM +0300, Pavel Fedin wrote: > Hello! > > > Historically QEMU had a pointless check on the path passed in, to enforce > > that it was only hugetlbfs, so could not just pass in a regular tmpfs > > file. I think we removed that in QEMU 2.5. I think it is a valid

Re: [libvirt] [PATCH 3/4] conf: snapshot: Refactor virDomainSnapshotDefAssignExternalNames

On 11/02/16 10:20, Peter Krempa wrote: > Get rid of one indentation level by negating condition and remove ugly > pointer arithmetic at the cost of one extra allocation. > --- > src/conf/snapshot_conf.c | 94 > +++- > 1 file changed, 44 insertions(+),

[libvirt] [PATCH 1/4] tests: Split off the mock part of the port allocator test

Instead of compiling either the mock or the non-mock part of the file based on a compiler flag, split the mock part off to its own file. --- tests/Makefile.am| 4 +- tests/virportallocatormock.c | 108 ++ tests/virportallocatortest.c | 110

[libvirt] [PATCH 2/4] tests: Allow use of close() in mock libraries

As mock libraries are not to be linked against libvirt, the sc_prohibit_close syntax-check rule does not apply. This fixes a syntax-check failure introduced by commit a03cbfe0fb. --- cfg.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cfg.mk b/cfg.mk index 3f78842..5b864af

[libvirt] [PATCH 0/4] tests: Fix syntax-check failure, plus extras

Commit a03cbfe0fb introduced a syntax-check failure: patch 1/4 prepares for 2/4, where the failure is actually fixed. Patches 3/4 and 4/4 improve the naming consistency for mock libraries by shuffling files around a bit. Cheers. Andrea Bolognani (4): tests: Split off the mock part of the

[libvirt] [PATCH 3/4] tests: Don't use "lib" prefix for mock libraries

virportallocatormock was the only one using it, and has been changed accordingly. --- tests/Makefile.am| 10 +- tests/virportallocatortest.c | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 1fe7d6b..359610f

[libvirt] [PATCH 4/4] tests: Rename virmockdbus -> virdbusmock for consistency

All mock libraries were called vir*mock except for this one; now the naming is consistent across the board. --- tests/Makefile.am | 14 +++--- tests/{virmockdbus.c => virdbusmock.c} | 2 +- tests/virfirewalltest.c| 2 +- tests/virpolkittest.c

Re: [libvirt] [PATCH 1/4] conf: snapshot: Rename disksorter to virDomainSnapshotCompareDiskIndex

On 11/02/16 10:20, Peter Krempa wrote: > Stick to the naming pattern. > --- > src/conf/snapshot_conf.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c > index 1eda7c2..65a78d6 100644 > ---

[libvirt] [PATCH 1/3] rbd: Add volStorageBackendRBDGetFeatures() for internal calls

As more and more features are added to RBD volumes we will need to call this method more often. By moving it into a internal function we can re-use code inside the storage backend. Signed-off-by: Wido den Hollander --- src/storage/storage_backend_rbd.c | 23

[libvirt] [PATCH 2/3] rbd: rbd_diff_iterate2() is available in librbd since 266

In commit 0b15f920 there is a #ifdef which requires LIBRBD_VERSION_CODE 266 or newer for rbd_diff_iterate2() rbd_diff_iterate2() is available since 266, so this if-statement should require anything newer than 265. Signed-off-by: Wido den Hollander ---

[libvirt] Improvements to the RBD storage backend

Hi, After review by John Ferlan I'm sending a revised version of my earlier patch which adds the fast-diff feature for RBD volumes. Before the patch there is one small improvement which is later used by the fast-diff feature. The other is a bugfix where the #ifdef in the code wasn't requiring

[libvirt] [PATCH 3/3] rbd: Use RBD fast-diff for querying actual volume allocation

Since Ceph version Infernalis (9.2.0) the new fast-diff mechanism of RBD allows for querying actual volume usage. Prior to this version there was no easy and fast way to query how much allocation a RBD volume had inside a Ceph cluster. To use the fast-diff feature it needs to be enabled per RBD

[libvirt] [PATCH 1/3] network: consolidate connection count updates for device pool

networkReleaseActualDevice() and networkNotifyActualDevice() both were updating the individual devices' connections count in two separate places (unlike networkAllocateActualDevice() which does it in a single unified place after success:). The code is correct, but prone to confusion / later

Re: [libvirt] [PATCH 2/3] util: Introduce API's for Polkit text authentication

On 02/11/2016 05:02 AM, Daniel P. Berrange wrote: > On Wed, Feb 10, 2016 at 02:46:35PM -0500, John Ferlan wrote: >> Introduce virPolkitAgentCreate, virPolkitAgentCheck, and >> virPolkitAgentDestroy >> >> virPolkitAgentCreate will run the polkit pkttyagent image as an asynchronous >> command in

[libvirt] [PATCH v2 0/3] Add capability for text based polkit authentication for virsh

v1: http://www.redhat.com/archives/libvir-list/2016-February/msg00545.html Differences to v1: - Patch 1, adjust error message slightly - Patch 2, remove the unnecessary virPolkitAgentCheck and the sleep - Patch 3, remove the --pkauth parameter adjust the logic to attempt the

[libvirt] [PATCH v2 2/3] util: Introduce API's for Polkit text authentication

Introduce virPolkitAgentCreate and virPolkitAgentDestroy virPolkitAgentCreate will run the polkit pkttyagent image as an asynchronous command in order to handle the local agent authentication via stdin/stdout. virPolkitAgentDestroy will close the command effectively reaping our child process

[libvirt] [PATCH v2 1/3] polkit: Adjust message when action-id isn't found

When there isn't a ssh -X type session running and a user has not been added to the libvirt group, attempts to run 'virsh -c qemu:///system' commands from an otherwise unprivileged user will fail with rather generic or opaque error message: "error: authentication failed: no agent is available

[libvirt] [PATCH v2 3/3] virsh: Add support for text based polkit authentication

https://bugzilla.redhat.com/show_bug.cgi?id=872166 When the login session doesn't have an ssh -X type display agent in order for libvirtd to run the polkit session authentication, attempts to run 'virsh -c qemu:///system list' from an unauthorized user (or one that isn't part of the libvirt

[libvirt] [PATCH 2/3] network: consolidated info log for all network allocate/free operations

There are three functions that deal with allocating and freeing devices from a networks netdev/pci device pool: network(Allocate|Notify|Release)ActualDevice(). These functions also maintain a counter of the number of domains currently using a network (regardless of whether or not that network uses

[libvirt] [PATCH 3/3] util: clean up and expand 802.1QbX negotiation logging

The existing log messages for this have several problems; there are two lines of log when one will suffice, they duplicate the function name in log message (when it's already included by VIR_DEBUG), they're missing some useful bits, they get logged even when the call is a NOP. This patch cleans

[libvirt] [PATCH 0/3] networking logging improvements

1/3 was originally part of 2/3, but I decided I should split it out since it changes something other than logging (although it should still be a NOP). 2/3 changes what's logged when a domain interface is connected to / disconnected from a network, and 3/3 changes what is logged during 802.1QbX

Re: [libvirt] [PATCH 0/3] Add capability for text based polkit authentication for virsh

On 02/11/2016 12:45 PM, Daniel P. Berrange wrote: > On Thu, Feb 11, 2016 at 12:22:12PM -0500, John Ferlan wrote: >> >> >> On 02/11/2016 05:11 AM, Daniel P. Berrange wrote: >>> On Wed, Feb 10, 2016 at 02:46:33PM -0500, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=872166

Re: [libvirt] [PATCH] Revert "tests: Don't link mock libraries against libvirt and gnulib"

On Thu, 2016-02-11 at 09:49 +, Daniel P. Berrange wrote: > On Thu, Feb 11, 2016 at 09:54:45AM +0100, Andrea Bolognani wrote: > > On Wed, 2016-02-10 at 18:09 +, Daniel P. Berrange wrote: > > > On Wed, Feb 10, 2016 at 06:33:21PM +0100, Andrea Bolognani wrote: > > > > This reverts commit

Re: [libvirt] [RFC] vhost-user + shared memory + NUMA

Hello! > Historically QEMU had a pointless check on the path passed in, to enforce > that it was only hugetlbfs, so could not just pass in a regular tmpfs > file. I think we removed that in QEMU 2.5. I think it is a valid enhance > to allow specification of "shared" memory backing which > would

Re: [libvirt] [PATCH 0/3] Add capability for text based polkit authentication for virsh

On Thu, Feb 11, 2016 at 12:22:12PM -0500, John Ferlan wrote: > > > On 02/11/2016 05:11 AM, Daniel P. Berrange wrote: > > On Wed, Feb 10, 2016 at 02:46:33PM -0500, John Ferlan wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=872166 > >> > >> As an alternative to commit id 'e94979e90' which

Re: [libvirt] [PATCH 0/3] Add capability for text based polkit authentication for virsh

On 02/11/2016 05:11 AM, Daniel P. Berrange wrote: > On Wed, Feb 10, 2016 at 02:46:33PM -0500, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=872166 >> >> As an alternative to commit id 'e94979e90' which allows polkit >> authentication by adding users to the 'libvirt' group,

Re: [libvirt] [PATCH 1/4] tests: Split off the mock part of the port allocator test

On Thu, 2016-02-11 at 15:45 +0100, Ján Tomko wrote: > On Thu, Feb 11, 2016 at 02:36:28PM +0100, Andrea Bolognani wrote: > > Instead of compiling either the mock or the non-mock part of the > > file based on a compiler flag, split the mock part off to its > > own file. > > --- > >  

Re: [libvirt] [PATCH 0/2] tests: Fix mock libraries linking

On Thu, 2016-02-11 at 12:34 +0100, Andrea Bolognani wrote: > On Thu, 2016-02-11 at 11:17 +, Daniel P. Berrange wrote: > > On Thu, Feb 11, 2016 at 12:15:39PM +0100, Andrea Bolognani wrote: > > > This patches make sure mock libraries do not link against either > > > too many or too few