Re: [libvirt] Availability of libvirt-1.3.3-rc2

2016-04-01 Thread Laine Stump
On 04/01/2016 11:39 AM, Martin Kletzander wrote: On Fri, Apr 01, 2016 at 11:54:30AM +0800, Daniel Veillard wrote: I pushed the rc2 tag in git head and signed tarball and rpms to the usual place: ftp://libvrt.org/libvirt/ I didn't really had time to test it TBH, seems we don't have too muc

[libvirt] [PATCH 0/3] fix regression wrt

2016-04-01 Thread Laine Stump
The full description of the problem fixed by these patches is in patch 3/3. Basically, a recent patch changed the ordering of things during startup such that hostdev interfaces are given an alias named "netN" rather than the expected "hostdevN". That caused a problem when subsequently trying to hot

[libvirt] [PATCH 2/3] qemu: change args to qemuAssignDeviceHostdevAlias()

2016-04-01 Thread Laine Stump
In certain cases, we need to assign a hostdevN-style alias in a case when we don't have a virDomainHostdevDefPtr (instead we have a virDomainNetDefPtr). Since qemuAssignDeviceHostdevAlias() doesn't use anything in the virDomainHostdevDef except the alias string itself anyway, this patch just change

[libvirt] [PATCH 1/3] network: new function networkGetActualType

2016-04-01 Thread Laine Stump
There are times when it's necessary to learn the actual type of a network connection before any resources have been allocated (e.g. during qemuProcessPrepareDomain()), but in the past it was necessary to call networkAllocateActualDevice() in order to have the actual type filled in. This new functi

[libvirt] [PATCH 3/3] qemu: fix alias name for

2016-04-01 Thread Laine Stump
Starting with commit f8e712fe, if you start a domain that has an where the network is a pool of devices for hostdev assignment), when you later try to add *another* interface (of any kind) with hotplug, the function qemuAssignDeviceNetAlias() fails as soon as it sees a "hostdevN" alias in the list

Re: [libvirt] 答复: [libxl] shutdown a domain before it finishes starting

2016-04-01 Thread Jim Fehlig
On 04/01/2016 02:44 AM, Zhangbo (Oscar) wrote: >>> Hi all: >>> Suppose we have a guest domain which is pvops, for example, rhel6.4. >>> >>> Steps to produce the problem: >>> 1 start the guest by virDomainCreate() >>> 2 the API returns before the guest domain fully available, which m

Re: [libvirt] Availability of libvirt-1.3.3-rc2

2016-04-01 Thread Martin Kletzander
On Fri, Apr 01, 2016 at 11:54:30AM +0800, Daniel Veillard wrote: I pushed the rc2 tag in git head and signed tarball and rpms to the usual place: ftp://libvrt.org/libvirt/ I didn't really had time to test it TBH, seems we don't have too much red in the CI https://ci.centos.org/view/libvirt-

Re: [libvirt] [PATCH v2 06/10] util: Add more getters to threadpool parameters

2016-04-01 Thread Michal Privoznik
On 29.03.2016 09:51, Erik Skultety wrote: > In order for the client to see all thread counts and limits, current total > and free worker count getters need to be introduced. Client might also be > interested in the job queue length, so provide a getter for that too. > --- > src/libvirt_private.sym

Re: [libvirt] [PATCH v2 08/10] admin: Introduce virAdmServerGethreadPoolParameters

2016-04-01 Thread Michal Privoznik
On 29.03.2016 09:51, Erik Skultety wrote: > New API to retrieve current server workerpool specs. Since it uses typed > parameters, more specs to retrieve can be further included in the pool of > supported ones. > --- > daemon/admin.c | 59 +++ > dae

Re: [libvirt] [PATCH v2 07/10] admin: Prepare admin protocol for future worker related procedures

2016-04-01 Thread Michal Privoznik
On 29.03.2016 09:51, Erik Skultety wrote: > Before any getter or setter methods can be introduced, first specify a set of > public attributes/flags that these methods will be compatible with. > --- > include/libvirt/libvirt-admin.h | 60 > + > src/admin/adm

Re: [libvirt] [PATCH v2 09/10] admin: Introduce virAdmServerSetThreadPoolParameters

2016-04-01 Thread Michal Privoznik
On 29.03.2016 09:51, Erik Skultety wrote: > Since threadpool increments the current number of threads according to current > load, i.e. how many jobs are waiting in the queue. The count however, is > constrained by max and min limits of workers. The logic of this new API works > like this: > 1)

Re: [libvirt] [PATCH v2 00/10] Introduce worker tuning APIs

2016-04-01 Thread Michal Privoznik
On 29.03.2016 09:51, Erik Skultety wrote: > NOTE: patch 2/10 moves typed params definition from libvirt-host.h to > libvirt-common.h.in to enable it for admin as well -> therefore > libvirt-common.h must be regenerated with config.status > > - also I'd like to open a discussion about virt-admin co

Re: [libvirt] [PATCH] Revert "hostdev: Use actual device when reattaching"

2016-04-01 Thread Andrea Bolognani
On Fri, 2016-04-01 at 10:59 -0400, Laine Stump wrote: > On 04/01/2016 09:38 AM, Andrea Bolognani wrote: > > > > This reverts commit ee4cfb56436b50345b072c706b87aff82e06d760. > > > > Since we're still not persisting our bookkeeping lists across > > daemon restarts, we might have lost some informat

Re: [libvirt] [PATCH] Revert "hostdev: Use actual device when reattaching"

2016-04-01 Thread Laine Stump
On 04/01/2016 09:38 AM, Andrea Bolognani wrote: This reverts commit ee4cfb56436b50345b072c706b87aff82e06d760. Since we're still not persisting our bookkeeping lists across daemon restarts, we might have lost some information virPCIDeviceReattach() relies on, for example whether the device needs

Re: [libvirt] [PATCH 4/4] xkcd: generate secure rememberable qcow2 passwords

2016-04-01 Thread Nikolay Shirokovskiy
On 01.04.2016 14:30, Daniel P. Berrange wrote: > Currently the QCow2 encryption password generator just uses > a set of random bytes. This is not very easy for users to > remember, which encourages them to write down their passwords. > Instead of this, allow for using 4 random words which gives >

Re: [libvirt] [PATCH] apparmor: QEMU monitor socket moved

2016-04-01 Thread Martin Kletzander
On Fri, Apr 01, 2016 at 03:30:37PM +0200, Guido Günther wrote: Hi Martin, On Fri, Apr 01, 2016 at 01:11:21PM +0200, Martin Kletzander wrote: On Thu, Mar 31, 2016 at 05:00:09PM +0200, Guido Günther wrote: >The directory name changed in a89f05ba8df095875f5ec8a9065a585af63a010b. >--- >src/security/

Re: [libvirt] [PATCH] docs: Remove useless p:first-line CSS rule

2016-04-01 Thread Andrea Bolognani
On Fri, 2016-04-01 at 14:46 +0200, Martin Kletzander wrote: > > So consider the commit message fixed: the change itself is > > still desiderable :) >  > Well, ACK with that, then ;)  And I believe it's safe as this is docs/ change Pushed, thanks! -- Andrea Bolognani Software Engineer - Virtualiz

Re: [libvirt] [PATCH 06/11] vz: make vzConn structure be a new lockable object and use it

2016-04-01 Thread Nikolay Shirokovskiy
On 29.03.2016 15:45, Maxim Nestratov wrote: > This patch introduces a new 'vzConn' lockable object and provides > helper functions to allocate/destroy it. > Now we store domain related objects such as domain list, capabitilies > etc. within a single vz_driver vzConn structure, which is shared by

[libvirt] [PATCH] Revert "hostdev: Use actual device when reattaching"

2016-04-01 Thread Andrea Bolognani
This reverts commit ee4cfb56436b50345b072c706b87aff82e06d760. Since we're still not persisting our bookkeeping lists across daemon restarts, we might have lost some information virPCIDeviceReattach() relies on, for example whether the device needs to be unbound from the stub driver. As a result,

Re: [libvirt] [PATCH] apparmor: QEMU monitor socket moved

2016-04-01 Thread Guido Günther
Hi Martin, On Fri, Apr 01, 2016 at 01:11:21PM +0200, Martin Kletzander wrote: > On Thu, Mar 31, 2016 at 05:00:09PM +0200, Guido Günther wrote: > >The directory name changed in a89f05ba8df095875f5ec8a9065a585af63a010b. > >--- > >src/security/virt-aa-helper.c | 2 ++ > >1 file changed, 2 insertions(+)

[libvirt] [PATCH perl] Add APIS & constants for new perf event support

2016-04-01 Thread Daniel P. Berrange
Add binding for virDomainGetPerfEvents, virDomainSetPerfEvents, VIR_DOMAIN_STATS_PERF, VIR_PERF_PARAM_CMT, and VIR_FROM_PERF Signed-off-by: Daniel P. Berrange --- Changes| 1 + Virt.xs| 43 +++ lib/Sys/Virt/Domain.pm | 34 +

Re: [libvirt] [PATCH 2/4] xkcd: enable more efficient random number generator

2016-04-01 Thread Martin Kletzander
On Fri, Apr 01, 2016 at 02:06:36PM +0200, Andrea Bolognani wrote: Sorry, but we don't have any proof that the value '4' was actually obtained with a fair dice roll. If you can provide video footage of either yourself or Randall Munroe rolling a dice and getting a four, then it's an ACK from me.

Re: [libvirt] [PATCH] docs: Remove useless p:first-line CSS rule

2016-04-01 Thread Martin Kletzander
On Fri, Apr 01, 2016 at 01:27:02PM +0200, Andrea Bolognani wrote: On Fri, 2016-04-01 at 13:04 +0200, Martin Kletzander wrote: On Fri, Apr 01, 2016 at 11:35:09AM +0200, Andrea Bolognani wrote: >  > According to MDN[1], the 'margin-left' CSS property cannot be   ... left ...   > applied to the '::

Re: [libvirt] [PATCH 2/4] xkcd: enable more efficient random number generator

2016-04-01 Thread Andrea Bolognani
On Fri, 2016-04-01 at 12:30 +0100, Daniel P. Berrange wrote: > XKCD comic 221 provides a very efficient algorithm for > a random number generator, which we can utilize in > libvirt. This is enabled simply > >    LIBVIRT_XKCD=221 /usr/sbin/libvirt > > The effect can be seen when defining new guest

Re: [libvirt] [PATCH 0/4] Add support for an XKCD mode

2016-04-01 Thread Roman Bogorodskiy
Jiri Denemark wrote: > On Fri, Apr 01, 2016 at 12:30:26 +0100, Daniel P. Berrange wrote: > > The XKCD website primarily publishes comics, but many of them > > are in fact design blueprints showing best practice for software > > developers. A number of these designs are applicable to libvirt > >

Re: [libvirt] [PATCH 0/4] Add support for an XKCD mode

2016-04-01 Thread Jiri Denemark
On Fri, Apr 01, 2016 at 12:30:26 +0100, Daniel P. Berrange wrote: > The XKCD website primarily publishes comics, but many of them > are in fact design blueprints showing best practice for software > developers. A number of these designs are applicable to libvirt > and will provide valuable features

[libvirt] [PATCH 0/4] Add support for an XKCD mode

2016-04-01 Thread Daniel P. Berrange
The XKCD website primarily publishes comics, but many of them are in fact design blueprints showing best practice for software developers. A number of these designs are applicable to libvirt and will provide valuable features to our users. This series introduces a new framework for enabling these e

[libvirt] [PATCH 3/4] xkcd: enabling pre-processing of XML with perl

2016-04-01 Thread Daniel P. Berrange
As told in comic 224, God mostly hacked together the universe using perl. If it is good enough for God, it is good enough for libvirt. So this extends the XML parser so that it feeds all XML through a perl script allowing arbitrary modifications. For example, if you think your guest domain names a

[libvirt] [PATCH 2/4] xkcd: enable more efficient random number generator

2016-04-01 Thread Daniel P. Berrange
XKCD comic 221 provides a very efficient algorithm for a random number generator, which we can utilize in libvirt. This is enabled simply LIBVIRT_XKCD=221 /usr/sbin/libvirt The effect can be seen when defining new guests without a MAC address # virsh define demo.xml # virsh dumpxml demo |

[libvirt] [PATCH 4/4] xkcd: generate secure rememberable qcow2 passwords

2016-04-01 Thread Daniel P. Berrange
Currently the QCow2 encryption password generator just uses a set of random bytes. This is not very easy for users to remember, which encourages them to write down their passwords. Instead of this, allow for using 4 random words which gives a rememberable password, while still having high entropy.

[libvirt] [PATCH 1/4] xkcd: add initial framework to enabling XKCD mode

2016-04-01 Thread Daniel P. Berrange
This adds support for new APIs to enable XKCD mode in other libvirt subsystems. It works by looking for the LIBVIRT_XKCD environment variable which contains a list of comic IDs, optionally followed by a data blob. eg LIBVIRT_XKCD=224:/path/to/some/script enables support for XKCD comic 224, us

Re: [libvirt] [PATCH] docs: Remove unused CSS rule

2016-04-01 Thread Andrea Bolognani
On Fri, 2016-04-01 at 07:04 -0400, John Ferlan wrote: > > On 04/01/2016 04:59 AM, Andrea Bolognani wrote: > > > > Commit e14c5069c512 dropped the only user of the #sponsor CSS > > rule, so we can drop it from the stylesheet as well. > > --- > >  docs/libvirt.css | 6 -- > >  1 file changed, 6

Re: [libvirt] [PATCH] docs: Remove useless p:first-line CSS rule

2016-04-01 Thread Andrea Bolognani
On Fri, 2016-04-01 at 13:04 +0200, Martin Kletzander wrote: > On Fri, Apr 01, 2016 at 11:35:09AM +0200, Andrea Bolognani wrote: > >  > > According to MDN[1], the 'margin-left' CSS property cannot be >  > ... left ... >  > > applied to the '::first-line' pseudo-element, so this rule > > will never h

Re: [libvirt] [PATCH] apparmor: QEMU monitor socket moved

2016-04-01 Thread Martin Kletzander
On Thu, Mar 31, 2016 at 05:00:09PM +0200, Guido Günther wrote: The directory name changed in a89f05ba8df095875f5ec8a9065a585af63a010b. --- src/security/virt-aa-helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index a2d7226

Re: [libvirt] [PATCH] docs: Remove useless p:first-line CSS rule

2016-04-01 Thread Martin Kletzander
On Fri, Apr 01, 2016 at 11:35:09AM +0200, Andrea Bolognani wrote: According to MDN[1], the 'margin-left' CSS property cannot be ... left ... applied to the '::first-line' pseudo-element, so this rule will never have any effect and can be safely removed. [1] https://developer.mozilla.org/en/d

Re: [libvirt] [PATCH] docs: Remove unused CSS rule

2016-04-01 Thread John Ferlan
On 04/01/2016 04:59 AM, Andrea Bolognani wrote: > Commit e14c5069c512 dropped the only user of the #sponsor CSS > rule, so we can drop it from the stylesheet as well. > --- > docs/libvirt.css | 6 -- > 1 file changed, 6 deletions(-) > ACK, safe. John -- libvir-list mailing list libvir-li

Re: [libvirt] [PATCH 05/11] vz: pass vzConnPtr to prlsdkXxx functions instead of virConnectPtr

2016-04-01 Thread Nikolay Shirokovskiy
On 29.03.2016 15:45, Maxim Nestratov wrote: > Signed-off-by: Maxim Nestratov > --- > src/vz/vz_driver.c | 6 +++--- > src/vz/vz_sdk.c| 25 +++-- > src/vz/vz_sdk.h| 6 +++--- > 3 files changed, 17 insertions(+), 20 deletions(-) ACK -- libvir-list mailing list libv

Re: [libvirt] [PATCH 04/11] vz: build driver as module and don't register it on client's side

2016-04-01 Thread Nikolay Shirokovskiy
On 29.03.2016 15:45, Maxim Nestratov wrote: > Make it possible to build vz driver as a module and don't link it with > libvirt.so statically. > Remove registering it on client's side as far as we start relying on daemon > > Signed-off-by: Maxim Nestratov > --- > daemon/Makefile.am | 4 >

[libvirt] 答复: [libxl] shutdown a domain before it finishes starting

2016-04-01 Thread Zhangbo (Oscar)
>> Hi all: >> Suppose we have a guest domain which is pvops, for example, rhel6.4. >> >> Steps to produce the problem: >> 1 start the guest by virDomainCreate() >> 2 the API returns before the guest domain fully available, which means, >the disks, network interfaces and some import

Re: [libvirt] [PATCH] Pass the correct cpu count when calling virDomainGetCPUStats.

2016-04-01 Thread Ján Tomko
On Fri, Apr 01, 2016 at 02:05:04AM -0400, Nitesh Konkar wrote: > When using the --start option, the show_count should not be set to > max_id as the --start means we dont need those many inital cpu > stats. Hence, show_count should be adjusted accordingly. > There is a public bug filed for this:

[libvirt] [PATCH] docs: Remove useless p:first-line CSS rule

2016-04-01 Thread Andrea Bolognani
According to MDN[1], the 'margin-left' CSS property cannot be applied to the '::first-line' pseudo-element, so this rule will never have any effect and can be safely removed. [1] https://developer.mozilla.org/en/docs/Web/CSS/::first-line --- docs/generic.css | 4 1 file changed, 4 deletions(

[libvirt] [PATCH] docs: Remove unused div.body CSS rule

2016-04-01 Thread Andrea Bolognani
The 'body' CSS class is not used anywhere in the HTML files, so we can get rid of the definition as well. --- docs/generic.css | 5 - 1 file changed, 5 deletions(-) diff --git a/docs/generic.css b/docs/generic.css index c0c6215..4f98b26 100644 --- a/docs/generic.css +++ b/docs/generic.css @@

Re: [libvirt] [PATCH v2] migration: convert speed from Mb/sec to bytes/sec in drive-mirror jobs

2016-04-01 Thread Ján Tomko
On Fri, Apr 01, 2016 at 10:16:53AM +0800, Rudy Zhang wrote: > Commit id '7b7600b3' added qemuMigrationDriveMirror to handle NBD > mirroring, but passed the migrate_speed listed in MiB/s to be used for > the mirror_speed which expects a bytes/s value. > Misleading, qemuMonitorDriveMirror expected

Re: [libvirt] [PATCH 29/38] virlog: Introduce an API mutex that serializes all setters

2016-04-01 Thread Erik Skultety
On 31/03/16 20:13, Daniel P. Berrange wrote: > On Thu, Mar 31, 2016 at 07:49:02PM +0200, Erik Skultety wrote: >> If the API isn't closed, a situation with 2 setters where one is about to >> define a set of outputs and the other is already defining a new one, may >> occur. >> By resetting all outpu

[libvirt] [PATCH] docs: Remove unused CSS rule

2016-04-01 Thread Andrea Bolognani
Commit e14c5069c512 dropped the only user of the #sponsor CSS rule, so we can drop it from the stylesheet as well. --- docs/libvirt.css | 6 -- 1 file changed, 6 deletions(-) diff --git a/docs/libvirt.css b/docs/libvirt.css index c6f6d0d..2310b20 100644 --- a/docs/libvirt.css +++ b/docs/libvi

Re: [libvirt] [PATCH 0/5] Make all crashes non CVEs

2016-04-01 Thread Martin Kletzander
On Fri, Apr 01, 2016 at 09:44:50AM +0200, Jiri Denemark wrote: On Fri, Apr 01, 2016 at 09:08:05 +0200, Michal Privoznik wrote: Currently, whenever a crash occurs it may be very serious. It may even get its own CVE. This patch set tries to resolve the problem. Nice, but I think you could have i

Re: [libvirt] [PATCH 02/11] vz: change the order of capabilities reported

2016-04-01 Thread Nikolay Shirokovskiy
On 29.03.2016 15:45, Maxim Nestratov wrote: > 'vz' goes first now to make clients like virt-manager choose 'vz' > instead of 'parallels' > > Signed-off-by: Maxim Nestratov > --- > src/vz/vz_driver.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) ACK -- libvir-list mailing list

Re: [libvirt] [PATCH 01/11] virsh: report when vz driver is compiled

2016-04-01 Thread Nikolay Shirokovskiy
On 29.03.2016 15:45, Maxim Nestratov wrote: > Signed-off-by: Maxim Nestratov > --- > tools/virsh.c | 3 +++ > 1 file changed, 3 insertions(+) > ACK -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v5 5/5] virsh: add compression options for migration

2016-04-01 Thread Nikolay Shirokovskiy
From: ShaoHe Feng Signed-off-by: Nikolay Shirokovskiy --- tools/virsh-domain.c | 76 tools/virsh.pod | 18 ++--- 2 files changed, 91 insertions(+), 3 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index cd

[libvirt] [PATCH v5 0/5] migration: add multithread compression

2016-04-01 Thread Nikolay Shirokovskiy
Add means to turn multithread compression on during migration. Add means to pass compression parameters in migration command. WARNING! This should be pushed only after https://www.redhat.com/archives/libvir-list/2016-March/msg01506.html or virsh domain will break. Changes from v4 ==

[libvirt] [PATCH v5 4/5] qemu: migration: support setting compession parameters

2016-04-01 Thread Nikolay Shirokovskiy
Signed-off-by: Nikolay Shirokovskiy --- include/libvirt/libvirt-domain.h | 33 +++ src/qemu/qemu_migration.c| 91 +++- src/qemu/qemu_migration.h| 9 3 files changed, 132 insertions(+), 1 deletion(-) diff --git a/include/libvir

[libvirt] [PATCH v5 2/5] qemu: monitor: add migration parameters accessors

2016-04-01 Thread Nikolay Shirokovskiy
From: ShaoHe Feng Signed-off-by: ShaoHe Feng Signed-off-by: Nikolay Shirokovskiy --- src/qemu/qemu_monitor.c | 22 + src/qemu/qemu_monitor.h | 17 +++ src/qemu/qemu_monitor_json.c | 110 +++ src/qemu/qemu_monitor_json.h | 5 ++

[libvirt] [PATCH v5 3/5] qemumonitorjsontest: add test for getting multithread compress params

2016-04-01 Thread Nikolay Shirokovskiy
From: Eli Qiao Signed-off-by: Eli Qiao Signed-off-by: ShaoHe Feng Signed-off-by: Nikolay Shirokovskiy --- tests/qemumonitorjsontest.c | 61 + 1 file changed, 61 insertions(+) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c in

[libvirt] [PATCH v5 1/5] migration: qemu: add option to select compression methods

2016-04-01 Thread Nikolay Shirokovskiy
Signed-off-by: Nikolay Shirokovskiy --- include/libvirt/libvirt-domain.h | 9 ++ src/qemu/qemu_driver.c | 40 +++-- src/qemu/qemu_migration.c| 173 +-- src/qemu/qemu_migration.h| 27 ++ src/qemu/qemu_monitor.c |

Re: [libvirt] [PATCH 31/38] admin: Introduce virAdmConnectGetLoggingLevel

2016-04-01 Thread Erik Skultety
On 31/03/16 20:16, Daniel P. Berrange wrote: > On Thu, Mar 31, 2016 at 07:49:04PM +0200, Erik Skultety wrote: >> Enable libvirt users to query for the current logging level setting. > > I'm not really convinced we need to expose this via the API, > as the 'log_level' flag has really long ago cease

Re: [libvirt] [PATCH] qemu: perf: Tweak flags before using them

2016-04-01 Thread Peter Krempa
On Fri, Apr 01, 2016 at 09:11:25 +0200, Michal Privoznik wrote: > On 31.03.2016 16:48, Peter Krempa wrote: > > @flags have a valid modification impact only after calling > > virDomainObjUpdateModificationImpact. virDomainObjGetOneDef calls it but > > doesn't update them in the caller. > > --- ...

Re: [libvirt] [PATCH 0/5] Make all crashes non CVEs

2016-04-01 Thread Jiri Denemark
On Fri, Apr 01, 2016 at 09:08:05 +0200, Michal Privoznik wrote: > Currently, whenever a crash occurs it may be very serious. It may > even get its own CVE. This patch set tries to resolve the problem. Nice, but I think you could have integrated some interesting ideas from the previous attempt: htt

Re: [libvirt] [PATCH] qemu: perf: Tweak flags before using them

2016-04-01 Thread Michal Privoznik
On 31.03.2016 16:48, Peter Krempa wrote: > @flags have a valid modification impact only after calling > virDomainObjUpdateModificationImpact. virDomainObjGetOneDef calls it but > doesn't update them in the caller. > --- > CC: mpriv...@redhat.com > > src/qemu/qemu_driver.c | 3 +++ > 1 file change

[libvirt] [PATCH 3/5] remote: Implement virConnectCrash

2016-04-01 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- daemon/remote.c | 30 ++ src/remote/remote_driver.c | 32 src/remote/remote_protocol.x | 14 +- src/remote_protocol-structs | 5 + 4 files changed, 80 insertions(+), 1

[libvirt] [PATCH 5/5] virsh: Implement virConnectCrash

2016-04-01 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- tools/virsh-host.c | 75 ++ tools/virsh.pod| 9 +++ 2 files changed, 84 insertions(+) diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 80ac4bd..8635386 100644 --- a/tools/virsh-host.c +++ b

[libvirt] [PATCH 2/5] virutil: Introduce virCrash

2016-04-01 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 1 + src/util/virutil.c | 32 src/util/virutil.h | 2 ++ 3 files changed, 35 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 684f06c..afd7832 100644

[libvirt] [PATCH 1/5] Introduce virConnectCrash

2016-04-01 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- cfg.mk | 2 ++ include/libvirt/libvirt-host.h | 15 ++ src/driver-hypervisor.h| 7 +++ src/libvirt-host.c | 45 ++ src/libvirt_public.syms| 1 + 5 fil

[libvirt] [PATCH 4/5] qemu: Implement virConnectCrash

2016-04-01 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- src/qemu/qemu_driver.c | 29 + 1 file changed, 29 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 4aa1625..4b394db 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -20131,6 +20131,

[libvirt] [PATCH 0/5] Make all crashes non CVEs

2016-04-01 Thread Michal Privoznik
Currently, whenever a crash occurs it may be very serious. It may even get its own CVE. This patch set tries to resolve the problem. Michal Privoznik (5): Introduce virConnectCrash virutil: Introduce virCrash remote: Implement virConnectCrash qemu: Implement virConnectCrash virsh: Implem