Re: [libvirt] [PATCH 2/2] qemu: Regenerate VNC socket paths

On Tue, Apr 26, 2016 at 04:34:12PM +0200, Martin Kletzander wrote: > Similarly to what commit 714080791778 did with some internal paths, > clear vnc socket paths that were generated by us. Having such path in > the definition can cause trouble when restoring the domain. The path is > generated

[libvirt] Entering freeze for libvirt-1.3.4

We are in freeze ! I tagged the release candidate 1 in git and pushed signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ that looks fine with my very limited testing, but that's likely not indicative of the actual stability :)

Re: [libvirt] [PATCH 07/17] nodeinfo: move host memory APIs out into virhostcpu file

$SUJB: "...virhostmem file" On 04/14/2016 11:22 AM, Daniel P. Berrange wrote: > --- > po/POTFILES.in | 1 + > src/Makefile.am| 1 + > src/lxc/lxc_driver.c | 1 + > src/nodeinfo.c | 812 +- > src/nodeinfo.h

Re: [libvirt] [PATCH 06/17] nodeinfo: move host CPU APIs out into virhostcpu.c file

On 04/14/2016 11:30 AM, Daniel P. Berrange wrote: > Move all APIs with a virHostCPU name prefix out into new > util/virhostcpu.h & util/virhostcpu.c files looks like nodeinfopriv. turns into virhostcpupriv.h > > Signed-off-by: Daniel P. Berrange > --- > cfg.mk

Re: [libvirt] interface "peer address" patches are broken

On 04/26/2016 12:55 PM, Vasiliy Tolstov wrote: 2016-04-26 18:42 GMT+03:00 Laine Stump : The simplest fix would be to just swap peer and address in the set-address call for QEMU, but the fact that the problem didn't leap out at anyone indicates that the current name "peer" may

Re: [libvirt] RFC backup API

08.04.2016 23:47, Maxim Nestratov пишет: Hello all, Here is the first more detailed view on the list of the backup API functions that look reasonable to have. Though they are presented with parameters and short description all these are the subject to discuss and I kindly ask you to take a

[libvirt] [PATCHv2] conf: log error when incorrect PCI root controller is added to domain

libvirt may automatically add a pci-root or pcie-root controller to a domain, depending on the arch/machinetype, and it hopefully always makes the right decision about which to add (since in all cases these controllers are an implicit part of the virtual machine). But it's always possible that

Re: [libvirt] [PATCH 0/3] conf: reject '/' in object names

On 04/26/2016 04:26 PM, Laine Stump wrote: > On 04/26/2016 03:21 PM, Cole Robinson wrote: >> An embedded '/' in object names doesn't really work for any >> of our stateful drivers, so let's explicitly reject it. >> >> https://bugzilla.redhat.com/show_bug.cgi?id=639923 >>

Re: [libvirt] [PATCH 0/3] conf: reject '/' in object names

On 04/26/2016 03:21 PM, Cole Robinson wrote: An embedded '/' in object names doesn't really work for any of our stateful drivers, so let's explicitly reject it. https://bugzilla.redhat.com/show_bug.cgi?id=639923 https://bugzilla.redhat.com/show_bug.cgi?id=787604 Was there any discussion I may

Re: [libvirt] [PATCH 1/2] qemu: Unref cfg in qemuDomainDefPostParse

On Tue, Apr 26, 2016 at 04:34:11PM +0200, Martin Kletzander wrote: > Introduced by commit 15ad2ecf114d. > > Signed-off-by: Martin Kletzander > --- ACK -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 2/3] conf: network: reject name containing '/'

Trying to define a network name containing an embedded '/' will immediately fail when trying to write the XML to disk. This patch explicitly rejects names containing a '/' Besides the network bridge driver, the only other network implementation is a very thin one for virtualbox, which seems to

[libvirt] [PATCH 0/3] conf: reject '/' in object names

An embedded '/' in object names doesn't really work for any of our stateful drivers, so let's explicitly reject it. https://bugzilla.redhat.com/show_bug.cgi?id=639923 https://bugzilla.redhat.com/show_bug.cgi?id=787604 Cole Robinson (3): conf: domain: reject name containing '/' conf: network:

[libvirt] [PATCH 1/3] conf: domain: reject name containing '/'

Trying to define a domain name containing an embedded '/' will immediately fail when trying to write the XML to disk for our stateful drivers. This patch explicitly rejects names containing a '/', and provides an xmlopt feature for drivers to avoid this validation check, which is enabled in every

[libvirt] [PATCH 3/3] conf: storage: pool: reject name containing '/'

Trying to define a pool name containing an embedded '/' will immediately fail when trying to write the XML to disk. This patch explicitly rejects names containing a '/' Besides our stateful driver, there are two other storage impls: esx and phyp. esx doesn't support pool creation, so this should

Re: [libvirt] [PATCH 05/17] nodeinfo: rename all CPU APIs to have a virHostCPU prefix

On 04/14/2016 11:22 AM, Daniel P. Berrange wrote: > In preparation for moving all the CPU related APIs out of > the nodeinfo file, give them a virHostCPU name prefix. > > Signed-off-by: Daniel P. Berrange > --- > src/libvirt_linux.syms | 6 +- >

Re: [libvirt] [PATCH 04/17] nodeinfo: rename all memory APIs to have a virHostMem prefix

On 04/14/2016 11:22 AM, Daniel P. Berrange wrote: > In preparation for moving all the memory related APIs out of > the nodeinfo file, give them a virHostMem name prefix. > > Signed-off-by: Daniel P. Berrange > --- > src/libvirt_private.syms | 14 >

Re: [libvirt] [PATCH 03/17] nodeinfo: split CPU info retrieval out of nodeGetInfo

On 04/14/2016 11:22 AM, Daniel P. Berrange wrote: > Instead of having platform specific code in nodeGetInfo to > fetch CPU topology, split it all out into a new method > nodeGetCPUInfo. > > Signed-off-by: Daniel P. Berrange > --- > src/nodeinfo.c | 172 >

Re: [libvirt] [PATCH 02/17] nodeinfo: make nodeGetInfo() call nodeGetMemory for memory size

On 04/14/2016 11:22 AM, Daniel P. Berrange wrote: > The nodeGetInfo() method currently has its own code for getting > memory size in KB, that basically just re-invents what nodeGetMemory > already does. Remove it and just call nodeGetMemory, converting its > result from bytes to KB, allowing

Re: [libvirt] [Qemu-devel] KVM Forum 2016: Call For Participation

On 10 March 2016 at 18:09, Paolo Bonzini wrote: > = > KVM Forum 2016: Call For Participation > August 24-26, 2016 - Westin Harbor Castle - Toronto, Canada > > (All submissions must be received before midnight May

Re: [libvirt] [PATCH 01/17] nodeinfo: remove sysfs_prefix from all methods

On 04/14/2016 11:22 AM, Daniel P. Berrange wrote: > Nearly all the methods in the nodeinfo file are given a > 'const char *sysfs_prefix' parameter to override the > default sysfs path (/sys/devices/system). Every single > caller passes in NULL for this, except one use in the > unit tests.

Re: [libvirt] [PATCH 8/9] virnetclientstream: Process stream messages later

On 04/21/2016 10:28 AM, Michal Privoznik wrote: > On 20.04.2016 15:57, John Ferlan wrote: >> >> >> On 04/15/2016 09:51 AM, Michal Privoznik wrote: >>> Currently we have two separate functions for handling read from >>> a stream. One is supposed to be low level and reads data in this >>> self

Re: [libvirt] interface "peer address" patches are broken

2016-04-26 18:42 GMT+03:00 Laine Stump : > The simplest fix would be to just swap peer and address in the set-address > call for QEMU, but the fact that the problem didn't leap out at anyone > indicates that the current name "peer" may not be the best choice (even > though that's

Re: [libvirt] [RFC] live migration of VMs with internal snapshots

26.04.2016 18:38, Eric Blake пишет: On 04/26/2016 07:54 AM, Dmitry Mishin wrote: Hmm. Interesting. But what I'm talking about doesn't involve qemu much. We create an external temporarily delta for images with internal snapshots on libvirt side, then merge it on libvirt side thus, qemu

Re: [libvirt] [PATCH v4 4/6] Add GVirConfigDomainHostdevPci

On Thu, Apr 21, 2016 at 3:12 PM, Christophe Fergeau wrote: > On Fri, Apr 15, 2016 at 02:38:22PM +0100, Zeeshan Ali (Khattak) wrote: >> Add API to read and write PCI hostdev nodes. >> --- >> libvirt-gconfig/Makefile.am| 2 + >>

Re: [libvirt] [PATCH v4 6/6] Add test for GVirConfigDomainHostdevPci API

On Tue, Apr 26, 2016 at 04:47:58PM +0100, Zeeshan Ali (Khattak) wrote: > On Thu, Apr 21, 2016 at 3:14 PM, Christophe Fergeau > wrote: > > And one more. > > Yours? AFAIK it's mine. Yes, you're right, sorry, I was too eager to get to the end of that series ;) Acked-by:

Re: [libvirt] [PATCH v4 1/6] gconfig: Add gvir_config_object_has_child

On Thu, Apr 21, 2016 at 2:55 PM, Christophe Fergeau wrote: > On Fri, Apr 15, 2016 at 02:38:19PM +0100, Zeeshan Ali (Khattak) wrote: >> From: Christophe Fergeau > > This patch is mine, hopefully someone else will review it ;) Sure, ACK. :) > Christophe

Re: [libvirt] [PATCH v4 6/6] Add test for GVirConfigDomainHostdevPci API

On Thu, Apr 21, 2016 at 3:14 PM, Christophe Fergeau wrote: > And one more. Yours? AFAIK it's mine. > On Fri, Apr 15, 2016 at 02:38:24PM +0100, Zeeshan Ali (Khattak) wrote: >> --- >> tests/test-gconfig.c| 43 >> + >>

Re: [libvirt] [PATCH] conf: Drop restrictions on rng backend path

On 04/26/2016 11:07 AM, Daniel P. Berrange wrote: > On Wed, Apr 20, 2016 at 06:19:25PM -0400, Cole Robinson wrote: >> Currently we only allow /dev/random and /dev/hwrng as host input >> for device. This was added after >> various upstream discussions in commit 4932ef45 >> >> However this

Re: [libvirt] [PATCH v4 5/6] gconfig: Add GVirConfigDomainAddressPci getters

On Thu, Apr 21, 2016 at 3:14 PM, Christophe Fergeau wrote: > Another patch that I wrote... ACK. > Christophe > > On Fri, Apr 15, 2016 at 02:38:23PM +0100, Zeeshan Ali (Khattak) wrote: >> From: Christophe Fergeau >> >> They will be useful to do more

Re: [libvirt] [PATCH 00/13] qemu: Kill some very ugly legacy code

On 04/26/2016 10:21 AM, Pavel Hrdina wrote: > On Tue, Apr 26, 2016 at 03:37:33PM +0200, Peter Krempa wrote: >> Noticed while doing a depth-first search for a different refactor. > > ACK series > > We should drop QEMU_CAPS_DEVICE from all of libvirt code since this capability > will be always

Re: [libvirt] interface "peer address" patches are broken

On 04/26/2016 06:55 AM, Vasiliy Tolstov wrote: Yes,I see that peer disappeared in XML,but works on first start... Also I agree that address more for guest side and not host,do you have some suggestions for me how to fix that before release? The simplest fix would be to just swap peer and

Re: [libvirt] [PATCH] spec: Use proper indentation

On 04/26/2016 11:39 AM, Andrea Bolognani wrote: > Commit 1d4400082a02 added some code that was not indented properly > and broke syntax-check. Fix it. > --- > Pushed as trivial. Sorry, I always forget about syntax-check on non-C files - Cole -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] spec: Use proper indentation

Commit 1d4400082a02 added some code that was not indented properly and broke syntax-check. Fix it. --- Pushed as trivial. libvirt.spec.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 4eff5ae..970ac32 100644 ---

Re: [libvirt] [RFC] live migration of VMs with internal snapshots

On 04/26/2016 07:54 AM, Dmitry Mishin wrote: >> Hmm. Interesting. But what I'm talking about doesn't involve qemu much. >> We create >> an external temporarily delta for images with internal snapshots on >> libvirt side, >> then merge it on libvirt side thus, qemu shouldn't be affected at all as

Re: [libvirt] ideas for custom iptables rules for libvirt networks.

On Tue, Apr 26, 2016 at 11:06:23AM -0400, Laine Stump wrote: > On 04/26/2016 04:15 AM, Daniel P. Berrange wrote: > > On Mon, Apr 25, 2016 at 01:48:49PM -0400, Laine Stump wrote: > >> We still periodically get requests to allow custom iptables rules for > >> libvirt virtual networks (or, more

Re: [libvirt] [PATCH] conf: Drop restrictions on rng backend path

On Wed, Apr 20, 2016 at 06:19:25PM -0400, Cole Robinson wrote: > Currently we only allow /dev/random and /dev/hwrng as host input > for device. This was added after > various upstream discussions in commit 4932ef45 > > However this restriction has generated quite a few complaints over > the

Re: [libvirt] [PATCH] remote: Don't reject remote polkit if client lacks support

On Thu, Apr 14, 2016 at 03:41:22PM -0400, Cole Robinson wrote: > If you compile a client --without-polkit, and connect to a URI that needs > polkit auth, the connection will fail with: > > $ ./tools/virsh --connect qemu+ssh://crobinso@machine/system > error: failed to connect to the hypervisor >

Re: [libvirt] ideas for custom iptables rules for libvirt networks.

On Tue, Apr 26, 2016 at 11:06:23AM -0400, Laine Stump wrote: > On 04/26/2016 04:15 AM, Daniel P. Berrange wrote: > >On Mon, Apr 25, 2016 at 01:48:49PM -0400, Laine Stump wrote: > >>We still periodically get requests to allow custom iptables rules for > >>libvirt virtual networks (or, more

Re: [libvirt] ideas for custom iptables rules for libvirt networks.

On 04/26/2016 04:15 AM, Daniel P. Berrange wrote: On Mon, Apr 25, 2016 at 01:48:49PM -0400, Laine Stump wrote: We still periodically get requests to allow custom iptables rules for libvirt virtual networks (or, more commonly, a mode where libvirt simply leaves iptables alone, not adding or

Re: [libvirt] [PATCH v3] schema: Allow space character in disk vendor/product

On 04/26/2016 10:36 AM, Daniel P. Berrange wrote: > On Tue, Apr 26, 2016 at 10:30:41AM -0400, Cole Robinson wrote: >> The hex range already tried to allow for it, but it wasn't using >> the correct XML hex syntax. Fix it, and test it >> --- >> v3: use proper XML hex syntax (thanks danpb) >> >>

Re: [libvirt] [PATCH v3] schema: Allow space character in disk vendor/product

On Tue, Apr 26, 2016 at 10:30:41AM -0400, Cole Robinson wrote: > The hex range already tried to allow for it, but it wasn't using > the correct XML hex syntax. Fix it, and test it > --- > v3: use proper XML hex syntax (thanks danpb) > > docs/schemas/domaincommon.rng

[libvirt] [PATCH 2/2] qemu: Regenerate VNC socket paths

Similarly to what commit 714080791778 did with some internal paths, clear vnc socket paths that were generated by us. Having such path in the definition can cause trouble when restoring the domain. The path is generated to the per-domain directory that contains the domain ID. However, that ID

[libvirt] [PATCH 1/2] qemu: Unref cfg in qemuDomainDefPostParse

Introduced by commit 15ad2ecf114d. Signed-off-by: Martin Kletzander --- src/qemu/qemu_domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 3b152893a23a..a2f981043915 100644 --- a/src/qemu/qemu_domain.c +++

[libvirt] [PATCH 0/2] Fix migrations with automatic vnc sockets

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1326270 Martin Kletzander (2): qemu: Unref cfg in qemuDomainDefPostParse qemu: Regenerate VNC socket paths src/qemu/qemu_domain.c | 22 +++- .../qemuxml2argv-graphics-vnc-autosocket.args | 22

Re: [libvirt] [PATCH v2] schema: Allow space character in disk vendor/product

On 04/26/2016 10:23 AM, Daniel P. Berrange wrote: > On Tue, Apr 26, 2016 at 10:11:41AM -0400, Cole Robinson wrote: >> The hex range already tried to allow for it, but it doesn't work >> for reasons I can't figure out. Use a plain character range instead, >> and test it >> --- >> v2: send the fully

[libvirt] [PATCH v3] schema: Allow space character in disk vendor/product

The hex range already tried to allow for it, but it wasn't using the correct XML hex syntax. Fix it, and test it --- v3: use proper XML hex syntax (thanks danpb) docs/schemas/domaincommon.rng | 6 -- tests/qemuxml2argvdata/qemuxml2argv-disk-scsi-disk-vpd.args

Re: [libvirt] [PATCH v2] schema: Allow space character in disk vendor/product

On Tue, Apr 26, 2016 at 10:11:41AM -0400, Cole Robinson wrote: > The hex range already tried to allow for it, but it doesn't work > for reasons I can't figure out. Use a plain character range instead, > and test it > --- > v2: send the fully squashed patch > > docs/schemas/domaincommon.rng

Re: [libvirt] [PATCH v2] spec: If installing default network, restart libvirtd

On 04/26/2016 10:16 AM, Cole Robinson wrote: If libvirt-daemon-config-network is installed while libvirtd is already running, the daemon doesn't notice the network. Users then have to manually restart libvirtd (or reboot) to pick up the network. Instead let's trigger a daemon restart when the

[libvirt] [PATCH v2] spec: If installing default network, restart libvirtd

If libvirt-daemon-config-network is installed while libvirtd is already running, the daemon doesn't notice the network. Users then have to manually restart libvirtd (or reboot) to pick up the network. Instead let's trigger a daemon restart when the package is first installed. Then the default

Re: [libvirt] [PATCH] send default USB controller in xml to destination during migration on PPC64

Ping... Can someone review this simple patch ? Thanks, Shiva On Wed, Mar 2, 2016 at 8:39 PM, Shivaprasad G Bhat < shivaprasadb...@gmail.com> wrote: > The default USB controller is not sent to destination as the older versions > of libvirt(0.9.4 or earlier as I see in commit log of 409b5f54)

Re: [libvirt] [PATCH 00/13] qemu: Kill some very ugly legacy code

On Tue, Apr 26, 2016 at 03:37:33PM +0200, Peter Krempa wrote: > Noticed while doing a depth-first search for a different refactor. ACK series We should drop QEMU_CAPS_DEVICE from all of libvirt code since this capability will be always set. Maybe also add a syntax-check to forbit to use

Re: [libvirt] [PATCH] schema: Allow space character in disk vendor/product

On 04/26/2016 10:13 AM, Daniel P. Berrange wrote: > On Tue, Apr 26, 2016 at 10:01:17AM -0400, Cole Robinson wrote: >> The hex range already tried to allow for it, but it doesn't work >> for reasons I can't figure out. Use a plain character range instead, >> and test it >> --- >>

Re: [libvirt] [PATCH] spec: If installing default network, restart libvirtd

On 04/26/2016 10:12 AM, Laine Stump wrote: > On 04/25/2016 05:13 PM, Cole Robinson wrote: >> If libvirt-daemon-config-network is installed while libvirtd is already >> running, the daemon doesn't notice the network. Users then have to >> manually restart libvirtd (or reboot) to pick up the

Re: [libvirt] [PATCH] schema: Allow space character in disk vendor/product

On Tue, Apr 26, 2016 at 10:01:17AM -0400, Cole Robinson wrote: > The hex range already tried to allow for it, but it doesn't work > for reasons I can't figure out. Use a plain character range instead, > and test it > --- > docs/schemas/domaincommon.rng | 2 ++ >

Re: [libvirt] [PATCH] spec: If installing default network, restart libvirtd

On 04/25/2016 05:13 PM, Cole Robinson wrote: If libvirt-daemon-config-network is installed while libvirtd is already running, the daemon doesn't notice the network. Users then have to manually restart libvirtd (or reboot) to pick up the network. Instead let's trigger a daemon restart when the

[libvirt] [PATCH v2] schema: Allow space character in disk vendor/product

The hex range already tried to allow for it, but it doesn't work for reasons I can't figure out. Use a plain character range instead, and test it --- v2: send the fully squashed patch docs/schemas/domaincommon.rng | 6 --

Re: [libvirt] [PATCH] schema: Allow space character in disk vendor/product

On 04/26/2016 10:09 AM, Ján Tomko wrote: > On Tue, Apr 26, 2016 at 10:01:17AM -0400, Cole Robinson wrote: >> The hex range already tried to allow for it, but it doesn't work >> for reasons I can't figure out. Use a plain character range instead, >> and test it >> --- >>

[libvirt] [PATCH] schema: Allow space character in disk vendor/product

The hex range already tried to allow for it, but it doesn't work for reasons I can't figure out. Use a plain character range instead, and test it --- docs/schemas/domaincommon.rng | 2 ++ tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-scsi-disk-vpd.xml | 4 ++-- 2

Re: [libvirt] [PATCH] schema: Allow space character in disk vendor/product

On Tue, Apr 26, 2016 at 10:01:17AM -0400, Cole Robinson wrote: > The hex range already tried to allow for it, but it doesn't work > for reasons I can't figure out. Use a plain character range instead, > and test it > --- > docs/schemas/domaincommon.rng | 2 ++ >

Re: [libvirt] [RFC] live migration of VMs with internal snapshots

On 26/04/16 16:34, "Maxim Nestratov" wrote: >26.04.2016 13:00, Kashyap Chamarthy пишет: > >> On Tue, Apr 26, 2016 at 06:26:59AM +0300, Maxim Nestratov wrote: >>> Hi, >>> >>> As far as I understand, currently there is no way to live migrate qemu >>> VMs that have

Re: [libvirt] [RFC] live migration of VMs with internal snapshots

26.04.2016 13:00, Kashyap Chamarthy пишет: On Tue, Apr 26, 2016 at 06:26:59AM +0300, Maxim Nestratov wrote: Hi, As far as I understand, currently there is no way to live migrate qemu VMs that have internal snapshots, because live migration works via qemu drive mirroring, which in turns

Re: [libvirt] [PATCH v2 00/12] Add IV Secret Object support

On 04/16/2016 10:17 AM, John Ferlan wrote: > v1: http://www.redhat.com/archives/libvir-list/2016-April/msg00596.html > > Differences since v1: > > - Add qemuBuildiSCSICommandLine (and BuildDiskiSCSI && BuildHostdeviSCSI) >These will do the magic necessary in order to support IV secret

Re: [libvirt] [PATCH v2] configure: Remove build time checks for (ip|ip6|eb)tables

On Sat, 2016-04-23 at 15:39 -0400, Cole Robinson wrote: > And the 'ip' tool. There isn't much benefit to checking this at > configure time when we have infrastructure nowadays for looking up > binaries in the PATH > --- > v2: > Keep the virFileIsExecutable check >  >  >  configure.ac   

[libvirt] [PATCH 06/13] qemu: hotplug: Assume QEMU_CAPS_DEVICE in qemuDomainAttachNetDevice

--- src/qemu/qemu_hotplug.c | 53 + 1 file changed, 14 insertions(+), 39 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 4e667fe..b56936d 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -799,7

[libvirt] [PATCH 05/13] qemu: hotplug: Assume QEMU_CAPS_DEVICE in qemuDomainAttachVirtioDiskDevice

After killing one of the conditionals it's now guaranteed to have @drivealias populated when calling the monitor, so the code attempting to cleanup can be simplified. --- src/qemu/qemu_hotplug.c | 73 - 1 file changed, 29 insertions(+), 44

[libvirt] [PATCH 10/13] qemu: hotplug: Assume QEMU_CAPS_DEVICE in qemuDomainDetachHostPCIDevice

--- src/qemu/qemu_hotplug.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index b8d8def..0f9cfd1 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -3651,11 +3651,7 @@

[libvirt] [PATCH 04/13] qemu: monitor: Kill legacy USB monitor code

Code was obsoleted by using -device. --- src/qemu/qemu_monitor.c | 47 - src/qemu/qemu_monitor.h | 14 --- src/qemu/qemu_monitor_json.c | 29 - src/qemu/qemu_monitor_json.h | 11 - src/qemu/qemu_monitor_text.c | 99

[libvirt] [PATCH 01/13] qemu: remove default case from few typecasted enums

Commit 98c5c53d69b partially reverted the effort to use typecasted enums for compiler notification. Turn it back. --- src/qemu/qemu_command.c | 4 +++- src/qemu/qemu_hotplug.c | 11 ++- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c

[libvirt] [PATCH 08/13] qemu: hotplug: Assume QEMU_CAPS_DEVICE in qemuDomainDetachVirtioDiskDevice

--- src/qemu/qemu_hotplug.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index acad666..2888164 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -3382,8 +3382,7 @@

[libvirt] [PATCH 13/13] qemu: monitor: Kill legacy PCI hotplug code

--- src/qemu/qemu_monitor.c | 83 - src/qemu/qemu_monitor.h | 23 src/qemu/qemu_monitor_json.c | 50 src/qemu/qemu_monitor_text.c | 278 --- src/qemu/qemu_monitor_text.h | 20 5 files changed, 454 deletions(-)

[libvirt] [PATCH 02/13] qemu: hotplug: Assume QEMU_CAPS_DEVICE in qemuDomainAttachUSBMassStorageDevice

--- src/qemu/qemu_hotplug.c | 34 ++ 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 4ff10b4..8755f68 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -650,32 +650,26 @@

[libvirt] [PATCH 09/13] qemu: hotplug: Assume QEMU_CAPS_DEVICE in qemuDomainDetachControllerDevice

--- src/qemu/qemu_hotplug.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 2888164..b8d8def 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -3601,8 +3601,7 @@ int

[libvirt] [PATCH 11/13] qemu: hotplug: Assume QEMU_CAPS_DEVICE in qemuDomainDetachNetDevice

--- src/qemu/qemu_hotplug.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 0f9cfd1..b0e1e4d 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -3881,8 +3881,7 @@

[libvirt] [PATCH 03/13] qemu: hotplug: Assume QEMU_CAPS_DEVICE in qemuDomainAttachHostUSBDevice

--- src/qemu/qemu_hotplug.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 8755f68..627d28a 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1869,23 +1869,16 @@

[libvirt] [PATCH 07/13] qemu: hotplug: Assume QEMU_CAPS_DEVICE in qemuDomainAttachHostPCIDevice

--- src/qemu/qemu_hotplug.c | 72 ++--- 1 file changed, 26 insertions(+), 46 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index b56936d..acad666 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@

[libvirt] [PATCH 12/13] qemu: hotplug: Assume QEMU_CAPS_DEVICE in qemuDomainAttachControllerDevice

--- src/qemu/qemu_hotplug.c | 56 + 1 file changed, 24 insertions(+), 32 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index b0e1e4d..ca7cd84 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@

[libvirt] [PATCH 00/13] qemu: Kill some very ugly legacy code

Noticed while doing a depth-first search for a different refactor. Peter Krempa (13): qemu: remove default case from few typecasted enums qemu: hotplug: Assume QEMU_CAPS_DEVICE in qemuDomainAttachUSBMassStorageDevice qemu: hotplug: Assume QEMU_CAPS_DEVICE in

Re: [libvirt] [PATCH] virsh: Document change-media --live --config confusion

On 04/26/2016 08:49 AM, Cole Robinson wrote: > If 'virsh change-media --live --config ...' is requested, the > inactive XML is used as the template for the media change/eject. > If the runtime XML has diverged from the inactive XML, say via > other update operations, those changes may be undone

Re: [libvirt] [PATCH v4] Use-correct-pci-addresses-during-interface-detach

Hi Nitesh, The subject is weird, how about: virsh: properly handle detach-interface --live --config On 04/07/2016 05:13 AM, Nitesh Konkar wrote: > The virsh attach virsh detach interface command fails when both live and > config > are set and when the interface gets attached to different

[libvirt] [PATCH] virsh: Document change-media --live --config confusion

If 'virsh change-media --live --config ...' is requested, the inactive XML is used as the template for the media change/eject. If the runtime XML has diverged from the inactive XML, say via other update operations, those changes may be undone since the command will sync all non-path XML with the

[libvirt] [PATCH 0/2] qemu: Be able to auto dump core of a domain with long name

Yet another fix for https://bugzilla.redhat.com/show_bug.cgi?id=1289363 Martin Kletzander (2): Unify domain name shortening Shorten domain name for automatic coredump src/conf/domain_conf.c | 20 src/conf/domain_conf.h | 2 ++ src/libvirt_private.syms | 1 +

[libvirt] [PATCH 2/2] Shorten domain name for automatic coredump

If the domain name is long enough, the timestamp can prolong the filename for automatic coredump to more than the filesystem's limit. Simply shorten it like we do in other places. The timestamp helps with the unification, but having the ID in the name won't hurt. Resolves:

[libvirt] [PATCH 1/2] Unify domain name shortening

Add virDomainObjGetShortName() and use it. For now that's used in one place, but we should expose it so that future patches can use it. Signed-off-by: Martin Kletzander --- src/conf/domain_conf.c | 20 src/conf/domain_conf.h | 2 ++

Re: [libvirt] interface "peer address" patches are broken

Yes,I see that peer disappeared in XML,but works on first start... Also I agree that address more for guest side and not host,do you have some suggestions for me how to fix that before release? 25 Апр 2016 г. 8:57 PM пользователь "Laine Stump" написал: > I haven't had the time

[libvirt] Request for an account to update wiki content(NPIV_in_libvirt).

Hello All, I would like to get some feedback on the update I would like to make to this page. http://wiki.libvirt.org/page/NPIV_in_libvirt Original Content : *NOTE:* You can also create a scsi pool with source adapter type "fc_host" for a HBA, and in that case the attribute "parent" is not

Re: [libvirt] [RFC] live migration of VMs with internal snapshots

On Tue, Apr 26, 2016 at 06:26:59AM +0300, Maxim Nestratov wrote: > Hi, > > As far as I understand, currently there is no way to live migrate qemu > VMs that have internal snapshots, because live migration works via > qemu drive mirroring, which in turns mirrors only shallow block layer, >

Re: [libvirt] [RFC] live migration of VMs with internal snapshots

On Tue, Apr 26, 2016 at 09:19:44AM +0100, Daniel P. Berrange wrote: > On Tue, Apr 26, 2016 at 06:26:59AM +0300, Maxim Nestratov wrote: > > Hi, > > > > As far as I understand, currently there is no way to live migrate qemu VMs > > that > > have internal snapshots, because live migration works via

Re: [libvirt] [RFC] live migration of VMs with internal snapshots

On Tue, Apr 26, 2016 at 06:26:59AM +0300, Maxim Nestratov wrote: > Hi, > > As far as I understand, currently there is no way to live migrate qemu VMs > that > have internal snapshots, because live migration works via qemu drive > mirroring, > which in turns mirrors only shallow block layer,

Re: [libvirt] ideas for custom iptables rules for libvirt networks.

On Mon, Apr 25, 2016 at 01:48:49PM -0400, Laine Stump wrote: > We still periodically get requests to allow custom iptables rules for > libvirt virtual networks (or, more commonly, a mode where libvirt simply > leaves iptables alone, not adding or removing anything), and it's been a > nagging item

Re: [libvirt] A difference between libvirt and execution in bash shell

On Tue, 2016-04-26 at 09:36 +0800, zhukaijie wrote: > Once I type my qemu command line in bash shell and execute it. > Then I use ps -aux to list the qemu process, results > indicates the user of the qemu vm is "root" (Of course I logged > with root). However, if I use libvirt to start a qemu >

Re: [libvirt] [PATCH] daemon: add option to read host uuid from /etc/machine-id

On 25.04.2016 23:24, Cole Robinson wrote: > On 04/25/2016 10:38 AM, Nikolay Shirokovskiy wrote: >> Daemon config parameter switch between reading host uuid >> either from smbios or machine-id: >> >> host_uuid_source = "smbios|machine-id" >> >> Signed-off-by: Nikolay Shirokovskiy

Re: [libvirt] [PATCH 0/4] apibuild: Fix several issues

On Mon, 2016-04-25 at 15:40 -0400, Cole Robinson wrote: >  > > This series fixes both the build issue (1/4) and the failure > > to report build issues properly (2/4), plus some more of the > > latter that I noticed while working on the code (3/4, 4/4). > > > > Last but not least: I'm not a

Re: [libvirt] [PATCH] maint: Ignore all intermediate and generated man pages

On Mon, 2016-04-25 at 15:42 -0400, Cole Robinson wrote: > On 04/25/2016 11:52 AM, Andrea Bolognani wrote: > > > > Since commit 9b77ce63f1d7 we create a .in file while building all > > man pages, including those in the tools/ directory; update the > > ignore patterns to take this change into