Re: [libvirt] [PATCH] vz: fix build for virNetDev* changes

On 06/27/2016 02:23 PM, Olga Krishtal wrote: Patch fixes vz build after changes in IP-related netdev functions(cf0568b0, fbc1843d). Sorry about that. I *thought* I had searched in the drivers I couldn't build. (BTW, I tried downloading and installing the parallels-sdk on my Fedora system,

Re: [libvirt] [PATCH] qemuDomainDeviceDefValidate: Drop unused qemuCaps

On 06/27/2016 11:50 AM, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_domain.c | 4 > 1 file changed, 4 deletions(-) > ACK - I'd think this is safe too John -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] virt-admin: Call virInitialize to fix startup crash

Similar to what virsh and virt-login-shell do https://bugzilla.redhat.com/show_bug.cgi?id=1350315 --- I can't actually reproduce the bug, the backtrace is similar to 97973ebb7 which added the same fix for virt-login-shell, and that commit also mentions the randomness of reproducing...

[libvirt] [PATCH 0/1] vz: fix build for virNetDev* changes

Although this changes have been reverted, it useful to have patch, that makes this changes in vz driver. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] vz: fix build for virNetDev* changes

Patch fixes vz build after changes in IP-related netdev functions(cf0568b0, fbc1843d). Signed-off-by: Olga Krishtal --- src/vz/vz_sdk.c | 49 + 1 file changed, 25 insertions(+), 24 deletions(-) diff --git

Re: [libvirt] [PATCH RFC 11/48] Introduce virStreamSparseSendAll

On Wed, Jun 22, 2016 at 04:43:28PM +0200, Michal Privoznik wrote: > This is just a wrapper over new function that have been just > introduced: virStreamSkip() . It's very similar to > virStreamSendAll() except it handles sparse streams well. > > Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH RFC 10/48] Introduce virStreamSparseRecvAll

On Wed, Jun 22, 2016 at 04:43:27PM +0200, Michal Privoznik wrote: > This is just a wrapper over new functions that have been just > introduced: virStreamRecvFlags(), virStreamHoleSize(). It's very > similar to virStreamRecvAll() except it handles sparse streams > well. > > Signed-off-by: Michal

Re: [libvirt] [PATCH RFC 09/48] Introduce VIR_STREAM_RECV_STOP_AT_HOLE flag

On Wed, Jun 22, 2016 at 04:43:26PM +0200, Michal Privoznik wrote: > This flag is for virStreamRecvFlags API. Its purpose is to stop > reading from the stream if a hole occurred as holes are to be > threated separately. > > Signed-off-by: Michal Privoznik > --- >

Re: [libvirt] [PATCH RFC 08/48] Introduce virStreamHoleSize

On Wed, Jun 22, 2016 at 04:43:25PM +0200, Michal Privoznik wrote: > This function is basically a counterpart for virStreamSkip. If > one side of a stream called virStreamSkip() the other should call > virStreamHoleSize() to get the size of the hole. > > Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH RFC 07/48] Introduce virStreamSkip

On Wed, Jun 22, 2016 at 04:43:24PM +0200, Michal Privoznik wrote: > This API can be used to tell the other side of the stream to skip > some bytes in the stream. This can be used to create a sparse > file on the receiving side of a stream. > > It takes just one argument @length, which says how

Re: [libvirt] [PATCH RFC 06/48] Implement virStreamRecvFlags to some drivers

On Wed, Jun 22, 2016 at 04:43:23PM +0200, Michal Privoznik wrote: > We have three virStreamDriver-s currently in our tree. > virFDStream, remote driver and ESX driver.f or now, support for > remote driver and ESX driver is sufficient, because > implementation for virFDStream is going to be

Re: [libvirt] [PATCH RFC 05/48] Introduce virStreamRecvFlags

On Wed, Jun 22, 2016 at 04:43:22PM +0200, Michal Privoznik wrote: > Although we already have virStreamRecv, just like some other > older APIs it is missing @flags argument. This means, the > function is not that flexible and therefore we need > virStreamRecvFlags. The latter is going to be needed

Re: [libvirt] [PATCH RFC 04/48] virFDStreamData: Turn into virObjectLockable

On Wed, Jun 22, 2016 at 04:43:21PM +0200, Michal Privoznik wrote: > While this is no functional change, it makes the code look a bit > nicer. Moreover, it prepares ground for future work. > > Signed-off-by: Michal Privoznik > --- > src/fdstream.c | 97 >

Re: [libvirt] [PATCH RFC 03/48] fdstream: s/struct virFDStreamData */virFDStreamDataPtr/

On Wed, Jun 22, 2016 at 04:43:20PM +0200, Michal Privoznik wrote: > There is really no reason why we should have to have 'struct' > everywhere. > > Signed-off-by: Michal Privoznik > --- > src/fdstream.c | 24 +--- > 1 file changed, 13 insertions(+), 11

Re: [libvirt] [PATCH RFC 02/48] src: Move iohelper out from utils/ to a separate dir

On Wed, Jun 22, 2016 at 04:43:19PM +0200, Michal Privoznik wrote: > This helper binary will grow in the future (e.g. it will gain > a so library which will be shared with daemon too) therefore its > sources should live somewhere else than utils/. I've chosen > src/iohelper. > > Signed-off-by:

Re: [libvirt] [PATCH RFC 01/48] util: Introduce virFileInData

On Wed, Jun 22, 2016 at 04:43:18PM +0200, Michal Privoznik wrote: > This function takes a FD and determines whether the current > position is in data section or in a hole. In addition to that, > it also determines how much bytes are there remaining till the > current section ends. > >

Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?

Jim Fehlig writes ("Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?"): > On 06/27/2016 10:12 AM, Ian Jackson wrote: > > Does libvirt have stable release branches ? One approach would be to > > have osstest track a suitable libvirt stable

Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?

On 06/27/2016 10:12 AM, Ian Jackson wrote: Daniel P. Berrange writes ("Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?"): On Mon, Jun 27, 2016 at 04:54:35PM +0100, Ian Jackson wrote: Created the following branch refs on xenbits in the

Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?

On Mon, Jun 27, 2016 at 05:12:52PM +0100, Ian Jackson wrote: > Daniel P. Berrange writes ("Re: [libvirt] [Xen-devel] Fixing libvirt's libxl > driver breakage -- where to define LIBXL_API_VERSION?"): > > On Mon, Jun 27, 2016 at 04:54:35PM +0100, Ian Jackson wrote: > > > Created the following

Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?

Daniel P. Berrange writes ("Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?"): > On Mon, Jun 27, 2016 at 04:54:35PM +0100, Ian Jackson wrote: > > Created the following branch refs on xenbits in the toplevel > > libvirt.git: > > > >

Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?

On Mon, Jun 27, 2016 at 04:54:35PM +0100, Ian Jackson wrote: > (Adding Jan Beulich) > > Ian Jackson writes ("Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver > breakage -- where to define LIBXL_API_VERSION?"): > > It seems that the libvirt LIBXL_API_VERSION is now rather higher, at > >

Re: [libvirt] [PATCH] Drop virStorageBackendLogicalMatchPoolSource

On Mon, Jun 27, 2016 at 01:56:58PM +0200, Peter Krempa wrote: On Fri, Jun 24, 2016 at 18:09:01 +0200, Ján Tomko wrote: On Wed, Jun 22, 2016 at 07:03:46AM -0400, John Ferlan wrote: >On 06/17/2016 11:16 AM, Ján Tomko wrote: >> On Thu, Jun 16, 2016 at 07:44:05AM -0400, John Ferlan wrote: >>> On

Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?

(Adding Jan Beulich) Ian Jackson writes ("Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?"): > It seems that the libvirt LIBXL_API_VERSION is now rather higher, at > 0x040400, since libvirt#fccf27253ced > libxl: switch to using

[libvirt] [PATCH] qemuDomainDeviceDefValidate: Drop unused qemuCaps

Signed-off-by: Jiri Denemark --- src/qemu/qemu_domain.c | 4 1 file changed, 4 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 0c107aa..fd25669 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -2196,12 +2196,9 @@

[libvirt] [PATCH v2] storage: dir: adapts .wipeVol for ploop volumes

The modification of .volWipe callback wipes ploop volume using one of given wiping algorithm: dod, nnsa, etc. However, in case of ploop volume we need to reinitialize root.hds and DiskDescriptor.xml. v2: - added check on ploop tools presens - virCommandAddArgFormat changed to virCommandAddArg

Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?

Jim Fehlig writes ("Re: [libvirt] [Xen-devel] Fixing libvirt's libxl driver breakage -- where to define LIBXL_API_VERSION?"): > I think that is a good idea too. I've sent a patch setting > LIBXL_API_VERSION to 0x040200 > > https://www.redhat.com/archives/libvir-list/2016-April/msg00771.html It

Re: [libvirt] [PATCH] logging: fixing log level initialization from cmdline

On Fri, Jun 24, 2016 at 02:29:57PM +0100, Daniel P. Berrange wrote: > On Fri, Jun 24, 2016 at 02:25:27PM +0200, Jaroslav Suchanek wrote: > > Reorder code for setting default log level from cmdline prior > > initialization of log outputs. Thus the --verbose option is reflected. > > > > This

Re: [libvirt] [PATCH 2/2] domaincapstest: Don't read data from host

On Mon, 2016-06-27 at 16:53 +0200, Jiri Denemark wrote: > On Mon, Jun 27, 2016 at 16:41:08 +0200, Andrea Bolognani wrote: > > On Mon, 2016-06-27 at 15:50 +0200, Jiri Denemark wrote: > > > virQEMUCapsFillDomainCaps would use virHostCPUGetKVMMaxVCPUs for KVM > > > domains. > > >   > > > diff --git

Re: [libvirt] [PATCH 2/2] domaincapstest: Don't read data from host

On Mon, Jun 27, 2016 at 16:41:08 +0200, Andrea Bolognani wrote: > On Mon, 2016-06-27 at 15:50 +0200, Jiri Denemark wrote: > > virQEMUCapsFillDomainCaps would use virHostCPUGetKVMMaxVCPUs for KVM > > domains. > >  > > diff --git a/tests/domaincapsmock.c b/tests/domaincapsmock.c > > new file mode

[libvirt] [PATCH 1/3] qemu: hot-plug: Fix broken SCSI disk hot-plug

The commit "qemu: hot-plug: Assume support for -device in qemuDomainAttachSCSIDisk" dropped the code for the automatic SCSI controller creation used in SCSI disk hot-plugging. If we are hot-plugging a SCSI disk to a domain and there is no proper SCSI controller defined, it results in an "error:

[libvirt] [PATCH 2/3] qemu: SCSI hostdev hot-plug: Fix automatic creation of SCSI controllers

Ensure that the given controller and all controllers with a smaller index exist; there must not be any missing index in between. Reviewed-by: Boris Fiuczynski Reviewed-by: Bjoern Walk Signed-off-by: Marc Hartmayer

[libvirt] [PATCH 3/3] tests: Add test cases for SCSI disk hot-plug with QEMU

Verify that SCSI controllers get created automatically when a SCSI disk is hot-plugged to a domain that doesn't have a matching SCSI controller defined already. Reviewed-by: Boris Fiuczynski Signed-off-by: Marc Hartmayer ---

[libvirt] [PATCH 0/3] qemu: Fix auto-generation of SCSI controllers for hot-plugged SCSI disks and add tests

This patch series fixes the auto-generation of SCSI controllers for hot-plugged SCSI disks and hot-plugged SCSI hostdevs. Additionally this patch series adds test cases for the auto-generation of SCSI controllers to the test suite. Marc Hartmayer (3): qemu: hot-plug: Fix broken SCSI disk

Re: [libvirt] [PATCH 2/2] domaincapstest: Don't read data from host

On Mon, Jun 27, 2016 at 15:50:44 +0200, Jiri Denemark wrote: > virQEMUCapsFillDomainCaps would use virHostCPUGetKVMMaxVCPUs for KVM > domains. > diff --git a/tests/domaincapsmock.c b/tests/domaincapsmock.c > new file mode 100644 > index 000..5266b73 > --- /dev/null > +++

Re: [libvirt] [PATCH 1/2] qemu: Remove redundant parameter in virQEMUCapsFillDomainCaps

On Mon, 2016-06-27 at 15:50 +0200, Jiri Denemark wrote: > virttype is already included in domCaps, no need to pass it separately. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_capabilities.c | 5 ++--- > src/qemu/qemu_capabilities.h | 3 +-- >

Re: [libvirt] [PATCH 2/2] domaincapstest: Don't read data from host

On Mon, 2016-06-27 at 15:50 +0200, Jiri Denemark wrote: > virQEMUCapsFillDomainCaps would use virHostCPUGetKVMMaxVCPUs for KVM > domains. >  > Signed-off-by: Jiri Denemark > --- >  tests/Makefile.am  |  7 +++ >  tests/domaincapsmock.c | 26 ++ > 

Re: [libvirt] [PATCH 0/2] Fix FreeBSD build

On Mon, 2016-06-27 at 16:12 +0200, Martin Kletzander wrote: > On Mon, Jun 27, 2016 at 12:43:47PM +0200, Andrea Bolognani wrote: > > Pushed under the build-breaker rule. > > > > Andrea Bolognani (2): > > util: netdevip: Include vircommand.h > > I don't understand how it can work on other

Re: [libvirt] [PATCH 0/2] Fix FreeBSD build

On Mon, Jun 27, 2016 at 04:12:22PM +0200, Martin Kletzander wrote: On Mon, Jun 27, 2016 at 12:43:47PM +0200, Andrea Bolognani wrote: Pushed under the build-breaker rule. Andrea Bolognani (2): util: netdevip: Include vircommand.h I don't understand how it can work on other platforms without

Re: [libvirt] [PATCH 0/2] Fix FreeBSD build

On Mon, Jun 27, 2016 at 12:43:47PM +0200, Andrea Bolognani wrote: Pushed under the build-breaker rule. Andrea Bolognani (2): util: netdevip: Include vircommand.h I don't understand how it can work on other platforms without this patch anyways, but ACK series and safe for freeze Clean up

Re: [libvirt] [Bug] make check fails when LIBVIRT_DEBUG is defined

On Mon, Jun 27, 2016 at 01:23:46PM +0200, Michal Privoznik wrote: On 27.06.2016 10:05, Daniel P. Berrange wrote: On Sat, Jun 25, 2016 at 04:32:21PM -0600, Eric Blake wrote: [moderator note: the mail server balked at 1.3 megabytes of attachments, so I've stripped them in my reply] On

[libvirt] [PATCH v2 0/3] Small cleanups and improvements

Remove some obsolete code, and improve the behavior of the 'virsh domcapabilities --virttype kvm' command when running on non-Linux platform. Andrea Bolognani (3): util: hostcpu: Add virHostCPUGetKVMMaxVCPUs() stub util: hostcpu: Drop obsolete compatibility code qemu: capabilities: Make

[libvirt] [PATCH v2 1/3] util: hostcpu: Add virHostCPUGetKVMMaxVCPUs() stub

If we don't HAVE_LINUX_KVM_H, we can't query /dev/kvm to discover the limits on the number of vCPUs, so we report an error and return a negative value instead. --- src/util/virhostcpu.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/util/virhostcpu.c

Re: [libvirt] [Bug] make check fails when LIBVIRT_DEBUG is defined

On Mon, Jun 27, 2016 at 01:23:46PM +0200, Michal Privoznik wrote: > On 27.06.2016 10:05, Daniel P. Berrange wrote: > > On Sat, Jun 25, 2016 at 04:32:21PM -0600, Eric Blake wrote: > >> [moderator note: the mail server balked at 1.3 megabytes of attachments, > >> so I've stripped them in my reply] >

[libvirt] [PATCH v2 3/3] qemu: capabilities: Make virHostCPUGetKVMMaxVCPUs() errors fatal

An error in virHostCPUGetKVMMaxVCPUs() means we've been unable to access /dev/kvm, or we're running on a platform that doesn't support KVM in the first place. If that's the case, we shouldn't ignore the error and report domcapabilities even though we know the user won't be able to start any KVM

[libvirt] [PATCH 2/2] domaincapstest: Don't read data from host

virQEMUCapsFillDomainCaps would use virHostCPUGetKVMMaxVCPUs for KVM domains. Signed-off-by: Jiri Denemark --- tests/Makefile.am | 7 +++ tests/domaincapsmock.c | 26 ++ tests/domaincapstest.c | 2 +- 3 files changed, 34 insertions(+), 1

[libvirt] [PATCH 1/2] qemu: Remove redundant parameter in virQEMUCapsFillDomainCaps

virttype is already included in domCaps, no need to pass it separately. Signed-off-by: Jiri Denemark --- src/qemu/qemu_capabilities.c | 5 ++--- src/qemu/qemu_capabilities.h | 3 +-- src/qemu/qemu_driver.c | 2 +- tests/domaincapstest.c | 3 +-- 4 files changed,

[libvirt] [PATCH 0/2] virQEMUCapsFillDomainCaps: Drop redundant parameter

Jiri Denemark (2): qemu: Remove redundant parameter in virQEMUCapsFillDomainCaps domaincapstest: Don't read data from host src/qemu/qemu_capabilities.c | 5 ++--- src/qemu/qemu_capabilities.h | 3 +-- src/qemu/qemu_driver.c | 2 +- tests/Makefile.am| 7 +++

Re: [libvirt] [PATCH 2/2] util: Only define /dev/kvm path once

On Mon, 2016-06-27 at 15:17 +0200, Ján Tomko wrote: > > > > Remove the local kvmpath variable from > > > > virHostCPUGetThreadsPerSubcore() and use the global KVM_DEVICE > > > > define instead. > > > > --- > > > > src/util/virhostcpu.c | 7 +++ > > > > 1 file changed, 3 insertions(+), 4

[libvirt] [PATCH v2 2/3] util: hostcpu: Drop obsolete compatibility code

All Linux releases we support (RHEL6 era) include these definitions. --- src/util/virhostcpu.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c index a33932f..8a8bda8 100644 --- a/src/util/virhostcpu.c +++ b/src/util/virhostcpu.c @@

Re: [libvirt] [PATCH 2/2] util: Only define /dev/kvm path once

On Mon, Jun 27, 2016 at 01:15:56PM +0200, Andrea Bolognani wrote: On Sat, 2016-06-25 at 10:19 +0200, Ján Tomko wrote: On Fri, Jun 24, 2016 at 07:34:38PM +0200, Andrea Bolognani wrote: > Remove the local kvmpath variable from > virHostCPUGetThreadsPerSubcore() and use the global KVM_DEVICE >

Re: [libvirt] [PATCH 0/6] Revert: 'IP peer address and host-side address config support'

On Mon, Jun 27, 2016 at 08:22:30AM -0400, Laine Stump wrote: On 06/27/2016 07:01 AM, Ján Tomko wrote: This series was accidentally pushed in the feature freeze. Revert the last six commits adding the new functionality. The rest are either bugfixes or preparation for the bugfixes. Sigh.

Re: [libvirt] [PATCH v2 08/15] encryption: Add luks parsing for storageencryption

On Fri, Jun 24, 2016 at 11:32:43 -0400, John Ferlan wrote: > > > On 06/24/2016 09:45 AM, Peter Krempa wrote: > > On Thu, Jun 23, 2016 at 13:29:04 -0400, John Ferlan wrote: > >> Add parse and format of the luks/passphrase secret including tests for > >> volume XML parsing. > >> > >>

Re: [libvirt] [PATCH 0/6] Revert: 'IP peer address and host-side address config support'

On 06/27/2016 07:01 AM, Ján Tomko wrote: This series was accidentally pushed in the feature freeze. Revert the last six commits adding the new functionality. The rest are either bugfixes or preparation for the bugfixes. Sigh. Sorry about pushing these after the freeze. I was watching for the

Re: [libvirt] [PATCH] Drop virStorageBackendLogicalMatchPoolSource

On Fri, Jun 24, 2016 at 18:09:01 +0200, Ján Tomko wrote: > On Wed, Jun 22, 2016 at 07:03:46AM -0400, John Ferlan wrote: > >On 06/17/2016 11:16 AM, Ján Tomko wrote: > >> On Thu, Jun 16, 2016 at 07:44:05AM -0400, John Ferlan wrote: > >>> On 06/16/2016 06:03 AM, Ján Tomko wrote: > On Wed, Jun

Re: [libvirt] [PATCH 1/2] util: Drop obsolete compatibility code

On Sat, 2016-06-25 at 10:19 +0200, Ján Tomko wrote: > On Fri, Jun 24, 2016 at 07:34:37PM +0200, Andrea Bolognani wrote: > > All operating system releases we support include these > > definitions. >  > Do we have a list of supported OSes somewhere? :) RHEL6 and OSs released around that time. I

Re: [libvirt] [Bug] make check fails when LIBVIRT_DEBUG is defined

On 27.06.2016 10:05, Daniel P. Berrange wrote: > On Sat, Jun 25, 2016 at 04:32:21PM -0600, Eric Blake wrote: >> [moderator note: the mail server balked at 1.3 megabytes of attachments, >> so I've stripped them in my reply] >> >> On 12/31/1969 05:00 PM, wrote: >>> Hello everybody, >>> >>> I set up

Re: [libvirt] [PATCH 2/2] util: Only define /dev/kvm path once

On Sat, 2016-06-25 at 10:19 +0200, Ján Tomko wrote: > On Fri, Jun 24, 2016 at 07:34:38PM +0200, Andrea Bolognani wrote: > > Remove the local kvmpath variable from > > virHostCPUGetThreadsPerSubcore() and use the global KVM_DEVICE > > define instead. > > --- > > src/util/virhostcpu.c | 7 +++ >

Re: [libvirt] [PATCHv3 07/10] Reserve existing USB addresses

On 23/06/16 09:45, Ján Tomko wrote: > Check if they fit on the USB controllers the domain has, > and error out if two devices try to use the same address. > --- > src/conf/domain_addr.c | 39 > ++ > src/conf/domain_addr.h

Re: [libvirt] [PATCH] Reject USB address without a port

On 25/06/16 18:11, Ján Tomko wrote: > We would happily accept a usb address with a missing port attribute, > then format it back as port='(null)', so the persistent domain > would not be able to start (due to the XML sightseeing tour in > virDomainObjSetDefTransient) or survive daemon restart. >

[libvirt] [PATCH 4/6] Revert "conf: support host-side IP/route information in "

This reverts commit fe6a77898a38f491403a70cc49925a584101daee. This feature was accidentally pushed in the feature freeze. --- docs/formatdomain.html.in| 26 --- docs/schemas/domaincommon.rng| 3 +- src/conf/domain_conf.c | 101

[libvirt] [PATCH 5/6] Revert "conf: allow setting peer address in element of "

This reverts commit 93135abf1454d8a1c8542e8c951ed615305ffa24. This feature was accidentally pushed in the feature freeze. --- docs/formatdomain.html.in | 40 +++- docs/schemas/domaincommon.rng | 5 - src/conf/domain_conf.c| 16 +---

[libvirt] [PATCH 6/6] Revert "util: new function virNetDevIPInfoAddToDev"

This reverts commit f1e0d0da11c473905470c28a6488bf57d9d0ae6e. This feature was accidentally pushed in the feature freeze. --- src/libvirt_private.syms | 1 - src/lxc/lxc_container.c | 47 - src/util/virnetdevip.c | 60

[libvirt] [PATCH 1/6] Revert "qemu: support setting host-side IP addresses/routes"

This reverts commit 0b4645a7e061abc8a4be71fe89865cf248ce6e56. This feature was accidentally pushed in the feature freeze. --- src/qemu/qemu_interface.c | 6 +-- .../qemuxml2argv-net-eth-hostip.args | 23 --- .../qemuxml2argv-net-eth-hostip.xml

[libvirt] [PATCH 2/6] Revert "lxc: support setting host-side IP addresses/routes"

This reverts commit cd5c9f21ded4f8e6216eba02b8795f70503ab404. This feature was accidentally pushed in the feature freeze. --- src/lxc/lxc_process.c | 8 1 file changed, 8 deletions(-) diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index 28313f0..07eb22a 100644 ---

[libvirt] [PATCH 3/6] Revert "util: support setting peer for virNetDevIPInfo addresses"

This reverts commit cb20f989df393ec97ba65afb06089d0ab87af484. This feature was accidentally pushed in the feature freeze. --- src/util/virnetdevip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnetdevip.c b/src/util/virnetdevip.c index f8b04e4..cae566a 100644

[libvirt] [PATCH 0/6] Revert: 'IP peer address and host-side address config support'

This series was accidentally pushed in the feature freeze. Revert the last six commits adding the new functionality. The rest are either bugfixes or preparation for the bugfixes. Ján Tomko (6): Revert "qemu: support setting host-side IP addresses/routes" Revert "lxc: support setting

[libvirt] [PATCH 2/2] Clean up after virNetDevIP creation

Commit cf0568b0af4e moved a bunch of functions from virNetDev to the more specific virNetDevIP; however, not all of the existing uses were moved properly, causing build failures on FreeBSD. Complete the transition to the new names and drop the obsolete declarations from the header file while at

[libvirt] [PATCH 0/2] Fix FreeBSD build

Pushed under the build-breaker rule. Andrea Bolognani (2): util: netdevip: Include vircommand.h Clean up after virNetDevIP creation src/util/virnetdev.h | 21 - src/util/virnetdevip.c | 5 +++-- tests/qemuxml2argvmock.c | 9 + 3 files changed, 8

[libvirt] [PATCH 1/2] util: netdevip: Include vircommand.h

Not including the header causes util/virnetdevip.c:520:5: error: unknown type name 'virCommandPtr'; did you mean 'virCondPtr'? virCommandPtr cmd = NULL; ^ and plenty more similar failures when compiling on FreeBSD. --- src/util/virnetdevip.c | 1 + 1 file changed, 1

Re: [libvirt] [PATCH] qemu: match controller index for LIVE+CONFIG when doing hotplug

On Sat, Jun 25, 2016 at 03:42:38PM +0200, Tomasz Flendrich wrote: On 24 Jun 2016, at 13:25, Martin Kletzander wrote: And what about the current bad behavior when you do this? virsh attach interface f24 --type network --source default --live virsh attach interface f24

Re: [libvirt] [PATCH] libvirtd.conf: Fix invalid default of max_anonymous_clients

On 27/06/16 10:26, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1343442 > > When a client connects, it is placed into a queue. As soon as it > authenticate, it is taken out of that queue and placed into a > different one. Now, we have a setting in the daemon config file >

Re: [libvirt] 答复: how to make syntax-check on tar-tall released-version

On Sat, 2016-06-25 at 00:49 +, Zhangbo (Oscar) wrote: > Here's my situation: I want to use libvirt v1.3.4 as my own git base, the > steps are: > 1 Download libvirt v1.3.4 from http://libvirt.org/sources > 2 add .gitignore inside the code tree > 3 run "git init" to generate my own git tree > 4

[libvirt] [PATCH] libvirtd.conf: Fix invalid default of max_anonymous_clients

https://bugzilla.redhat.com/show_bug.cgi?id=1343442 When a client connects, it is placed into a queue. As soon as it authenticate, it is taken out of that queue and placed into a different one. Now, we have a setting in the daemon config file that allows users to control the length of the queue

Re: [libvirt] [Bug] make check fails when LIBVIRT_DEBUG is defined

On Sat, Jun 25, 2016 at 04:32:21PM -0600, Eric Blake wrote: > [moderator note: the mail server balked at 1.3 megabytes of attachments, > so I've stripped them in my reply] > > On 12/31/1969 05:00 PM, wrote: > > Hello everybody, > > > > I set up a clean libvirt repo with: > > git clone > >

Re: [libvirt] 答复: how to make syntax-check on tar-tall released-version

On Sat, Jun 25, 2016 at 12:49:41AM +, Zhangbo (Oscar) wrote: > >> Hi all: > >> I downloaded libvirt v1.3.4 from http://libvirt.org/sources, and try to > >make syntax-check inside the code tree. > >> But I encounted with many problems, first, I need to have file > >> .gitignore > >and

Re: [libvirt] [PATCH v2 1/1] perf: add more perf events support

Hi Peter, According to your comment, I updated the XML documentation and post new version here. Do you have any more comments? Thanks, Qiaowei > -Original Message- > From: Ren, Qiaowei > Sent: Tuesday, June 21, 2016 3:41 PM > To: libvir-list@redhat.com > Cc: Daniel P. Berrange

Re: [libvirt] [PATCH 1/2] util: new function virXMLNodeSanitizeNamespaces()

On Fri, Jun 24, 2016 at 11:33:50 -0400, Laine Stump wrote: > This is a generic version of virDomainDefMetadataSanitize() - the same > functionality is now needed for network metadata. > --- > src/libvirt_private.syms | 1 + > src/util/virxml.c| 52 >

Re: [libvirt] [PATCH 2/2] qemu: use virXMLNodeSanitizeNamespaces()

On Fri, Jun 24, 2016 at 11:33:51 -0400, Laine Stump wrote: > Replace the virDomainDef-specific virDomainDefMetadataSanitize() with > virXMLNodeSanitizeNamespaces(). > --- > src/conf/domain_conf.c | 56 > ++ > 1 file changed, 2 insertions(+), 54

Re: [libvirt] [PATCH] Allow custom metadata in network configuration XML

On Fri, Jun 24, 2016 at 12:26:22 -0400, Laine Stump wrote: > On 06/24/2016 07:01 AM, Peter Krempa wrote: > > On Wed, Jun 22, 2016 at 16:05:50 -0600, Brnadon Bennett wrote: > >> From: Brandon Bennett > >> > >> This replicates the metadata field found in the domain