Re: [libvirt] [PATCH 2/6] gnulib: add getopt module

Fabian Freyer wrote: > Unconditionally use gnulib's getopt module. This is needed by the bhyve driver > to provide a reentrant interface for getopt. > --- > bootstrap.conf | 1 + > m4/virt-driver-bhyve.m4 | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/bootstrap.conf

Re: [libvirt] [PATCH 1/6] config-post.h: define __GNUC_PREREQ if not defined

Fabian Freyer wrote: > (resent due to mail client line mangling) > > Several gnulib headers rely on features.h being included by ctype.h to provide > __GNUC_PREREQ, but on systems without glibc, this is not provided. In these > cases __GNUC_PREREQ gets redefined to 0, which causes build errors

Re: [libvirt] [PATCH 3/6] bhyve: implement virConnectDomainXMLFromNative

Fabian Freyer wrote: > First, remove escaped newlines and split up the string into an argv-list for > the bhyve and loader commands, respectively. This is done by iterating over > the > string splitting it by newlines, and then re-iterating over each line, > splitting it by spaces. > > Since

Re: [libvirt] [libvirt-perl PATCH] Add support for VIR_SECRET_USAGE_TYPE_PASSPHRASE

On Mon, Jul 04, 2016 at 04:22:32PM +0100, Daniel P. Berrange wrote: On Mon, Jul 04, 2016 at 04:49:56PM +0200, Martin Kletzander wrote: On Mon, Jul 04, 2016 at 03:41:16PM +0100, Daniel P. Berrange wrote: > On Mon, Jul 04, 2016 at 04:37:27PM +0200, Martin Kletzander wrote: > > Signed-off-by:

Re: [libvirt] [libvirt-perl PATCH] Add support for VIR_SECRET_USAGE_TYPE_PASSPHRASE

On Mon, Jul 04, 2016 at 04:49:56PM +0200, Martin Kletzander wrote: > On Mon, Jul 04, 2016 at 03:41:16PM +0100, Daniel P. Berrange wrote: > > On Mon, Jul 04, 2016 at 04:37:27PM +0200, Martin Kletzander wrote: > > > Signed-off-by: Martin Kletzander > > > --- > > > This fixes a

Re: [libvirt] [PATCH REPOST 19/38] virlog: Make virLogReset methods use of virLog(Output|Filter)ListFree

On 10/05/16 03:02, Cole Robinson wrote: > On 05/04/2016 10:30 AM, Erik Skultety wrote: >> Now that methods to free logging related lists were introduced, put them to a >> use. >> --- >> src/util/virlog.c | 15 --- >> 1 file changed, 4 insertions(+), 11 deletions(-) >> >> diff --git

Re: [libvirt] [PATCH REPOST 16/38] virlog: Introduce virLogOutputListFree

On 10/05/16 03:05, Cole Robinson wrote: > On 05/04/2016 10:30 AM, Erik Skultety wrote: >> This is just a convenience method for discarding a list of outputs instead of >> using a 'for' loop everywhere. It is safe to pass -1 as the number of >> elements >> in the list as well as passing NULL as

Re: [libvirt] [PATCH REPOST 04/38] virlog: Export virLogOutputPtr through header

On 10/05/16 12:29, Erik Skultety wrote: > On 10/05/16 02:08, Cole Robinson wrote: >> On 05/04/2016 10:30 AM, Erik Skultety wrote: >>> It needs to be exported, since some caller might (for some reason) want to >>> create a logging output without calling the parser which does this. Also, >>> some

Re: [libvirt] [PATCH REPOST 01/38] virlog: Return void instead of int in virLogReset methods

On 10/05/16 01:47, Cole Robinson wrote: > On 05/04/2016 10:30 AM, Erik Skultety wrote: >> In this particular case, reset is meant as clearing the whole list of >> outputs/filters, not resetting it to a predefined default setting. Looking at >> it from that perspective, returning the number of

Re: [libvirt] [PATCH REPOST 00/38] Introduce APIs to change daemon's logging settings

On 04/05/16 16:30, Erik Skultety wrote: > Basically the same series as > https://www.redhat.com/archives/libvir-list/2016-March/msg01534.html, just > rebased onto the current HEAD. > > Daniel pointed out in 31/38 maybe we do not want to expose an API to set > logging level. Despite the truth

Re: [libvirt] [libvirt-perl PATCH] Add support for VIR_SECRET_USAGE_TYPE_PASSPHRASE

On Mon, Jul 04, 2016 at 03:41:16PM +0100, Daniel P. Berrange wrote: On Mon, Jul 04, 2016 at 04:37:27PM +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- This fixes a build for me with upstream libvirt. NACK, per my reply to John's original patch, I

Re: [libvirt] [libvirt-perl PATCH] Add support for VIR_SECRET_USAGE_TYPE_PASSPHRASE

On Mon, Jul 04, 2016 at 04:37:27PM +0200, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > This fixes a build for me with upstream libvirt. NACK, per my reply to John's original patch, I think this should not have been added to libvirt API in the first

[libvirt] [libvirt-perl PATCH] Add support for VIR_SECRET_USAGE_TYPE_PASSPHRASE

Signed-off-by: Martin Kletzander --- This fixes a build for me with upstream libvirt. Virt.xs| 1 + lib/Sys/Virt/Secret.pm | 5 + 2 files changed, 6 insertions(+) diff --git a/Virt.xs b/Virt.xs index cf4e5bc5337c..4c9f86b972f3 100644 --- a/Virt.xs +++

[libvirt] Status of gnulib/local/m4/ssize_t.m4.diff ?

Way back in 2012, we added the ssize_t.m4.diff file because we didn't want to risk pulling in a gnulib update at time of release. ommit 1012dc2933378640ac0ab1025a4fec2fc8c6f84c Author: Eric Blake Date: Fri Mar 30 10:28:03 2012 -0600 build: fix mingw ssize_t, syntax

Re: [libvirt] [PATCH 2/2] spec: Move virt-admin into its own package

On Mon, Jul 04, 2016 at 02:33:33PM +0200, Andrea Bolognani wrote: > On Fri, 2016-07-01 at 12:04 +0200, Michal Privoznik wrote: > > The new package for the virt-admin binary is libvirt-admin. > >  > > Signed-off-by: Michal Privoznik > > --- > >  libvirt.spec.in | 16

Re: [libvirt] [PATCH 2/2] spec: Move virt-admin into its own package

On Mon, 2016-07-04 at 15:53 +0200, Erik Skultety wrote: > > By the way, should mingw-libvirt.spec.in updated to ship > > the virsh and virt-admin binaries in separate -client and > > -admin packages? > >  > > Does shipping a mingw version virt-admin even make sense, > > given that AFAIK it doesn't

Re: [libvirt] [PATCH 2/2] spec: Move virt-admin into its own package

On 04/07/16 14:33, Andrea Bolognani wrote: > On Fri, 2016-07-01 at 12:04 +0200, Michal Privoznik wrote: >> The new package for the virt-admin binary is libvirt-admin. >> >> Signed-off-by: Michal Privoznik >> --- >> libvirt.spec.in | 16 ++-- >> 1 file

Re: [libvirt] [PATCH v3 02/10] conf: Add new secret type "passphrase"

On Fri, Jun 24, 2016 at 04:53:31PM -0400, John Ferlan wrote: > Add a new secret type known as "passphrase" - it will handle adding the > secret objects that need a passphrase without a specific username. > > The format is: > > > ... > ... > >mumblyfratz > >

Re: [libvirt] [PATCH] qemu: Memory locking is only required for KVM guests on ppc64

On Mon, 2016-07-04 at 13:32 +0200, Martin Kletzander wrote: > On Mon, Jul 04, 2016 at 01:25:45PM +0200, Andrea Bolognani wrote: > > On Mon, 2016-07-04 at 13:18 +0200, Martin Kletzander wrote: > > > On Mon, Jul 04, 2016 at 10:57:59AM +0200, Andrea Bolognani wrote: > > > > Due to the way the

Re: [libvirt] [PATCH 2/2] spec: Move virt-admin into its own package

On Fri, 2016-07-01 at 12:04 +0200, Michal Privoznik wrote: > The new package for the virt-admin binary is libvirt-admin. >  > Signed-off-by: Michal Privoznik > --- >  libvirt.spec.in | 16 ++-- >  1 file changed, 14 insertions(+), 2 deletions(-) >  > diff --git

Re: [libvirt] [PATCH 1/2] spec: Split libvirt-client

On Fri, 2016-07-01 at 12:04 +0200, Michal Privoznik wrote: > Currently, we have libvirt-client library which serves as a > collection point for all the libraries and client binaries we > have. Therefore we have couple of silly dependencies, for > instance libvirt-daemon depends on libvirt-client.

Re: [libvirt] [PATCH 0/6] Almost finish extermination of virDomainLiveConfigHelperMethod

On 01.07.2016 16:34, Peter Krempa wrote: > Few patches are not ideal, so ideas are welcome. > > Peter Krempa (6): > qemu: driver: Make name of QEMU_SET_MEM_PARAMETER more universal > lxc: Synchronize implementation of qemuDomainSetMemoryParameters > openvz: Remove use of

Re: [libvirt] [PATCH v2 2/2] virsh: enable --table with --name or --uuid

At 2016-06-29 05:36:30, "John Ferlan" wrote: > > >On 06/24/2016 12:44 PM, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> remove restrictions of --table with --name or --uid. > >I think what you're trying to do is allow --uuid to be printed in the

Re: [libvirt] [PATCH v2 1/2] virsh: allow both --uuid and --name at same cmd

At 2016-06-29 05:36:25, "John Ferlan" wrote: > > >On 06/24/2016 12:44 PM, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> virsh # list --uuid --name >> c749c765a0-25e7-40d0-964f-dac99724b32c >> f23 918f1dd6-b19f-412b-ba17-d113bad89af8 >> >

Re: [libvirt] [libvirt-php PATCH 0/4] Add more API bindings.

On 29.06.2016 18:29, Dawid Zamirski wrote: > This patch series adds more libvirt API bindings to libvirt-php. The > first patch in the series is a repost of: > > https://www.redhat.com/archives/libvir-list/2014-May/msg00021.html > > Dawid Zamirski (4): > implement libvirt_node_get_free_memory

Re: [libvirt] [libvirt-php PATCH 1/4] implement libvirt_node_get_free_memory

On 29.06.2016 18:29, Dawid Zamirski wrote: > From: Dawid Zamirski > > This patch adds support for virNodeGetFreeMemory which is available in > libvirt since v0.3.3. While the php bindings alredy provide > libvirt_node_get_mem_stats from which such info could be

Re: [libvirt] [PATCH] qemu: Memory locking is only required for KVM guests on ppc64

On Mon, Jul 04, 2016 at 01:25:45PM +0200, Andrea Bolognani wrote: On Mon, 2016-07-04 at 13:18 +0200, Martin Kletzander wrote: On Mon, Jul 04, 2016 at 10:57:59AM +0200, Andrea Bolognani wrote: > Due to the way the hardware works, KVM on ppc64 always requires > memory locking; however, that is

Re: [libvirt] [PATCH] qemu: Memory locking is only required for KVM guests on ppc64

On Mon, 2016-07-04 at 13:18 +0200, Martin Kletzander wrote: > On Mon, Jul 04, 2016 at 10:57:59AM +0200, Andrea Bolognani wrote: > > Due to the way the hardware works, KVM on ppc64 always requires > > memory locking; however, that is not the case for non-KVM ppc64 > > guests, eg. ppc64 guests that

Re: [libvirt] [PATCH] qemu: Memory locking is only required for KVM guests on ppc64

On Mon, Jul 04, 2016 at 10:57:59AM +0200, Andrea Bolognani wrote: Due to the way the hardware works, KVM on ppc64 always requires memory locking; however, that is not the case for non-KVM ppc64 guests, eg. ppc64 guests that are running on x86_64 with TCG. Only require memory locking for ppc64

Re: [libvirt] Designing NVDIMM & memory-backend-file

On Mon, Jul 04, 2016 at 11:21:20AM +0200, Michal Privoznik wrote: > On 01.07.2016 17:06, Daniel P. Berrange wrote: > > On Fri, Jul 01, 2016 at 04:35:18PM +0200, Michal Privoznik wrote: > >> Dear list, > >> > >> I'd like to fix the following bug [1]. Long story short, the only way > >> how to have

Re: [libvirt] Designing NVDIMM & memory-backend-file

On 01.07.2016 17:06, Daniel P. Berrange wrote: > On Fri, Jul 01, 2016 at 04:35:18PM +0200, Michal Privoznik wrote: >> Dear list, >> >> I'd like to fix the following bug [1]. Long story short, the only way >> how to have a domain use memory-backend-file object is to configure >> hugepages. Either

Re: [libvirt] [PATCH] virtlogd: increase max file size to 2 MB

On 01.07.2016 18:43, Daniel P. Berrange wrote: > People debugging guest OS boot processes and reported that > the default 128 KB size is too small to capture an entire > boot up sequence. Increase the default size to 2 MB which > should allow capturing a full boot up even with verbose > debugging.

[libvirt] [PATCH] qemu: Memory locking is only required for KVM guests on ppc64

Due to the way the hardware works, KVM on ppc64 always requires memory locking; however, that is not the case for non-KVM ppc64 guests, eg. ppc64 guests that are running on x86_64 with TCG. Only require memory locking for ppc64 guests if they are using KVM or, as it's the case for all

Re: [libvirt] [PATCH] virtlogd: make max file size & number of backups configurable

On 01.07.2016 18:43, Daniel P. Berrange wrote: > Currently virtlogd has a hardcoded max file size of 128kb > and max of 3 backups. This adds two new config parameters > to /etc/libvirt/virtlogd.conf to let these be customized. > > Signed-off-by: Daniel P. Berrange > --- >

[libvirt] [PATCH] maint: update to latest gnulib

Fix mingw build regarding rpl_{printf,scanf} symbols. Signed-off-by: Martin Kletzander --- Pushed under gnulib maintenance (just guessing what that means) and build-breaker rules. .gnulib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gnulib b/.gnulib

Re: [libvirt] [PATCH v2] qemu: neglect cur_balloon in supplied xml

ping On 09.06.2016 17:32, Nikolay Shirokovskiy wrote: > cur_balloon value can change in between preparing external config and > using it in operations like save and migrate. As a resutl operation will > fail for ABI inconsistency. cur_balloon changes can not be predicted > generally and thus