[libvirt] [PATCH 08/13] Move and rename qemuDomainAddressFindNewBusNr et al

qemuDomainAddressFindNewBusNr is renamed to virDomainAddressFindNewBusNr qemuDomainPCIAddressSetCreate is renamed to virDomainPCIAddressSetCreate qemuDomainPCIBusFullyReserved is renamed to virDomainPCIBusFullyReserved qemuDomainAssignDevicePCISlots is renamed to virDomainAssignDevicePCISlots All

[libvirt] [PATCH 11/13] Move and rename qemuDomainPCIAddrSetCreateFromDomain

qemuDomainPCIAddrSetCreateFromDomain is renamed to virDomainPCIAddrSetCreateFromDomain and moved from qemu_domain_address.c to domain_addr.c All these functions are being moved because they don't depend on qemu, so they have the potential to be reused for more hypervisors. ---

[libvirt] [PATCH 05/13] Move and rename qemuDomainValidateDevicePCISlotsPIIX3

qemuDomainValidateDevicePCISlotsPIIX3 is renamed to virDomainValidateDevicePCISlotsPIIX3 and moved from qemu_domain_addr.c to domain_addr.c All these functions are being moved because they don't depend on qemu, so they have the potential to be reused for more hypervisors. ---

[libvirt] [PATCH 00/13] Move functions from qemu_domain_address.c to domain_addr.c

This series depends on another one: https://www.redhat.com/archives/libvir-list/2016-July/msg00696.html Because the address sets are no longer cached, it's possible to move functions that don't depend on qemu anymore from qemu_domain_address.c to domain_addr.c. I did that with virtioSerial and

[libvirt] [PATCH 13/13] Make functions in qemu_domain_address static

The process of moving functions from qemu_domain_address.c to domain_addr.c is finished, so some of these functions can be declared static if they aren't used anywhere outside. --- src/conf/domain_addr.c | 20 +- src/conf/domain_addr.h | 53

[libvirt] [PATCH 12/13] Move and rename qemuDomainAssignPCIAddresses et al

qemuDomainPCIControllerSetDefaultModelName is renamed to qemuDomainAssignPCIAddresses is renamed to virDomainAssignPCIAddresses Both are moved from qemu_domain_addr.c to domain_addr.c All these functions are being moved because they don't depend on qemu, so they have the potential to be reused

[libvirt] [PATCH 02/13] make pci address handling functions qemu-agnostic

Change functions in qemu_domain_address.c to accept boolean parameters instead of qemuCaps. Thanks to this, they can be moved to domain_addr.c and have the potential to be reused for more hypervisors in the future. --- src/qemu/qemu_domain_address.c | 80 --

[libvirt] [PATCH 04/13] Move and rename qemuDomainMachineIsQ35 et al

qemuDomainMachineIsQ35 is renamed to virDomainMachineIsQ35, qemuDomainMachineIsI440FX is renamed to virDomainMachineIsI440FX, both are moved from qemu_domain_address.c to domain_addr.c All these functions are being moved because they don't depend on qemu, so they have the potential to be reused

[libvirt] [PATCH 03/13] Move and rename qemuDomainCollectPCIAddress

qemuDomainCollectPCIAddress is renamed to virDomainCollectPCIAddress and moved from qemu_domain_address.c to domain_addr.c All these functions are being moved because they don't depend on qemu, so they have the potential to be reused for more hypervisors. --- src/conf/domain_addr.c | 141

[libvirt] [PATCH 09/13] Move and rename qemuDomainMachineIsVirt

qemuDomainMachineIsVirt is renamed to virDomainMachineIsVirt and moved from qemu_domain_addr.c to domain_addr.c All these functions are being moved because they don't depend on qemu, so they have the potential to be reused for more hypervisors. --- src/conf/domain_addr.c | 15

[libvirt] [PATCH 07/13] Move and rename qemuDomainValidateDevicePCISlotsChipsets

qemuDomainValidateDevicePCISlotsChipsets is renamed to virDomainValidateDevicePCISlotsChipsets and moved from qemu_domain_addr.c to domain_addr.c All these functions are being moved because they don't depend on qemu, so they have the potential to be reused for more hypervisors. ---

[libvirt] [PATCH 06/13] Move and rename qemuDomainValidateDevicePCISlotsQ35

qemuDomainValidateDevicePCISlotsQ35 is renamed to virDomainValidateDevicePCISlotsQ35 and moved from qemu_domain_addr.c to domain_addr.c All these functions are being moved because they don't depend on qemu, so they have the potential to be reused for more hypervisors. --- src/conf/domain_addr.c

[libvirt] [PATCH 10/13] Move and rename qemuDomainSupportsPCI

qemuDomainSupportsPCI is renamed to virDomainSupportsPCI and moved from qemu_domain_address.c to domain_addr.c All these functions are being moved because they don't depend on qemu, so they have the potential to be reused for more hypervisors. --- src/conf/domain_addr.c | 18

[libvirt] [PATCH 01/13] Move and rename qemuDomainAssignVirtioSerialAddresses

qemuDomainAssignVirtioSerialAddresses is renamed to virDomainAssignVirtioSerialAddresses and moved from qemu_domain_address.c to domain_addr.c All these functions are being moved because they don't depend on qemu, so they have the potential to be reused for more hypervisors. ---

Re: [libvirt] [PATCH 3/3] vz: make vz driver more responsive

17-Jun-16 13:46, Nikolay Shirokovskiy пишет: On 17.06.2016 12:43, Nikolay Shirokovskiy wrote: On 16.06.2016 14:59, Nikolay Shirokovskiy wrote: Current vz driver implementation is not usable when it comes to long runnig operations. Migration or saving a domain blocks all other operations

Re: [libvirt] [PATCH v2] vz: handle gracefully races on undefining domain

21-Jun-16 11:35, Nikolay Shirokovskiy пишет: This patch is not critical but nice to have. The original motivation was error message in logs on undefining domain thru vz driver. Undefine procedure drops domain lock while waiting for detaching disks vz sdk call. Meanwhile vz sdk event

Re: [libvirt] [PATCH 2/3] vz: remove redundant variable in prlsdkHandleVmAddedEvent

16-Jun-16 14:59, Nikolay Shirokovskiy пишет: Signed-off-by: Nikolay Shirokovskiy --- src/vz/vz_sdk.c | 2 -- 1 file changed, 2 deletions(-) ACK -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/3] vz: use state variable sdkdom in prlsdkApplyConfig

16-Jun-16 14:59, Nikolay Shirokovskiy пишет: sdk domain handle is unique per connection so there is no sense to query it again if we have it in vzDomObjPtr. Side effect of prlsdkSdkDomainLookupByUUID is refreshing domain config is of no use too as PrlVm_BeginEdit do it too. Signed-off-by:

[libvirt] [PATCH 3/3] storage: Add extra failure condition for luks volume creation

Commit id '5e46d7d6' did not take into account that usage of a luks volume will require usage of the master key encrypted passphrase for a QEMU environment. So rather than allow creation of something that won't be usable, just fail the creation. Signed-off-by: John Ferlan

[libvirt] [PATCH 1/3] storage: Fix error path

virStorageBackendCreateQemuImgCheckEncryption didn't return -1 if there were no secrets. Signed-off-by: John Ferlan --- src/storage/storage_backend.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c index

[libvirt] [PATCH 2/3] qemu: Disallow usage of luks encryption if aes secret not possible

Resolves a CI test integration failure with a RHEL6/Centos6 environment. In order to use a LUKS encrypted device, the design decision was to generate an encrypted secret based on the master key. However, commit id 'da86c6c' missed checking for that specifically. When qemuDomainSecretSetup was

[libvirt] [PATCH 0/3] Resolve CI build integration test failure

Details in patches... The first patch was seen by inspection. The second patch will fix the test failure. The third patch is the lipstick on the pig. John Ferlan (3): storage: Fix error path qemu: Disallow usage of luks encryption if aes secret not possible storage: Add extra failure

Re: [libvirt] [Libvirt-ci] Build failed in Jenkins: libvirt-daemon-check » libvirt-centos-6 #1473

On 07/19/2016 11:08 AM, Daniel P. Berrange wrote: > Hi John, > > On Tue, Jul 19, 2016 at 02:58:06PM +, c...@centos.org wrote: >> See >> > > This failure points to the LUKS patches. > > > 372) QEMU XML-2-ARGV

Re: [libvirt] Minor compile failure on OSX for libvirt 2.0.0

On 19 Jul 2016, at 17:58, Andrea Bolognani wrote: > On Tue, 2016-07-19 at 16:30 +0100, Justin Clift wrote: >> On 19 Jul 2016, at 15:03, Andrea Bolognani wrote: >> >>> It's outside the #endif for __VIR_SYSTEMD_H___ though, so I'm kind of

Re: [libvirt] [PATCH] qemu: Use legacy USB on ppc64

On Tue, 2016-07-19 at 16:17 +0200, Andrea Bolognani wrote: > Commit 8156493d8db9 changed libvirt so that '-device pci-ohci' > would be used instead of '-usb' on ppc64 when no specific USB > controller model had been specified in the guest configuration. >  > While the device that ends up being

Re: [libvirt] Minor compile failure on OSX for libvirt 2.0.0

On Tue, 2016-07-19 at 16:30 +0100, Justin Clift wrote: > On 19 Jul 2016, at 15:03, Andrea Bolognani wrote: > > >  > > >  > > > It's outside the #endif for __VIR_SYSTEMD_H___ though, so I'm kind of > > > thinking it would need to be move inside the guard (which also compiles

[libvirt] [PATCHv2 2/3] hvsupport: construct the group regex upfront

The %groups hash contains all the driver types (e.g. virHypervisorDriver or virSecretDriver). When searching for all the APIs that are implemented by a driver of that specific driver type, we keep iterating over the %groups hash on every line we look at, then matching against the driver type.

[libvirt] [PATCHv2 0/3] Speed up hvsupport.pl

This reduces the script execution time from 14.7s to 60 ms. Since this was by far the longest taking target from the docs/ directory and make does not parallelize across Makefiles, the savings are similar for a complete build from a fresh git checkout. The second patch shaves off 8.2s, the third

[libvirt] [PATCHv2 3/3] hvsupport: skip non-matching lines early

Most of the lines we look at are not going to match one of the driver types contained in $groups_regex. Move on to the next line if it does not contain any of them early. This speeds up the script execution by 50%, since this simple regex does not have any capture groups. --- docs/hvsupport.pl |

[libvirt] [PATCHv2 1/3] hvsupport: use a regex instead of XML::XPath

When generating the hvsupport.html.in file, we parse the -api.xml files generated by apibuild.py to know in which HTML file the API function is. Doing an XPath query for every single 'function' element in the file is inefficient. Since the XML file is generated by another of our build scripts

Re: [libvirt] Minor compile failure on OSX for libvirt 2.0.0

On 19 Jul 2016, at 15:03, Andrea Bolognani wrote: >> It's outside the #endif for __VIR_SYSTEMD_H___ though, so I'm kind of >> thinking it would need to be move inside the guard (which also compiles >> ok), or is there a better place/file for it instead? :) > > I have posted

Re: [libvirt] [Libvirt-ci] Build failed in Jenkins: libvirt-daemon-check » libvirt-centos-6 #1473

Hi John, On Tue, Jul 19, 2016 at 02:58:06PM +, c...@centos.org wrote: > See > This failure points to the LUKS patches. 372) QEMU XML-2-ARGV luks-disks... In

Re: [libvirt] [PATCH] configure: Check for MSG_NOSIGNAL availability

On Tue, 2016-07-19 at 16:23 +0200, Ján Tomko wrote: > On Tue, Jul 19, 2016 at 04:00:25PM +0200, Andrea Bolognani wrote: > >  > > The symbol being missing has been reported as causing build > > failures on OS X. Check for its availability before using it. > > --- > > See

[libvirt] [PATCH 1/2] qemu: Move setting of obj bools for qemuDomainAttachVirtioDiskDevice

A post push realization that the setting of the boolean needed to be inside the if condition. Signed-off-by: John Ferlan --- src/qemu/qemu_hotplug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c

[libvirt] [PATCH 0/2] Need to set booleans in right place for hotplug cleanup

After pushing and working on the next set of changes, I realized that the setting of some booleans needed to be inside an if condition . John Ferlan (2): qemu: Move setting of obj bools for qemuDomainAttachVirtioDiskDevice qemu: Move setting of encobjAdded for qemuDomainAttachSCSIDisk

[libvirt] [PATCH 2/2] qemu: Move setting of encobjAdded for qemuDomainAttachSCSIDisk

A post push realization that the boolean should be set inside the condition Signed-off-by: John Ferlan --- src/qemu/qemu_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index aee62bb..cdad7ef

Re: [libvirt] [RFC PATCH 0/2] nodeinfo: PPC64: Fix topology and siblings info on capabilities and nodeinfo

On Thu, May 05, 2016 at 08:48:05PM +0200, Andrea Bolognani wrote: > On Fri, 2016-01-29 at 01:32 -0500, Shivaprasad G Bhat wrote: > > The nodeinfo output was fixed earlier to reflect the actual cpus available > > in > > KVM mode on PPC64. The earlier fixes covered the aspect of not making a host >

Re: [libvirt] [PATCH] configure: Check for MSG_NOSIGNAL availability

On Tue, Jul 19, 2016 at 04:00:25PM +0200, Andrea Bolognani wrote: The symbol being missing has been reported as causing build failures on OS X. Check for its availability before using it. --- See https://www.redhat.com/archives/libvir-list/2016-July/msg00613.html configure.ac | 4

Re: [libvirt] [PATCH] lxc: errors after the handshake won't be reported

On Tue, Jul 19, 2016 at 04:25:34PM +0200, Cédric Bosdonnat wrote: > Any error happening after the hand shake in the lxc controller > will not result in a failure as errors are checked during the handshake. > Move the handshake after the last possible error. > --- > src/lxc/lxc_controller.c | 6

[libvirt] [PATCH] lxc: errors after the handshake won't be reported

Any error happening after the hand shake in the lxc controller will not result in a failure as errors are checked during the handshake. Move the handshake after the last possible error. --- src/lxc/lxc_controller.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[libvirt] [PATCH v2 0/9] Various hotplug cleanups

v1: http://www.redhat.com/archives/libvir-list/2016-June/msg02207.html Changes since v1... - Use the bz noted by Cole from the v1 series - Merged in recent hotplug cleanup changes - Patches 6 - 9 are new Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1336225 and probably:

[libvirt] [PATCH v2 7/9] qemu: Introduce qemuAssignSCSIHostDeviceDriveAlias

Introduce a common API to generate the alias for a SCSI Host device Signed-off-by: John Ferlan --- src/qemu/qemu_alias.c | 18 ++ src/qemu/qemu_alias.h | 2 ++ 2 files changed, 20 insertions(+) diff --git a/src/qemu/qemu_alias.c b/src/qemu/qemu_alias.c

[libvirt] [PATCH v2 6/9] qemu: Add attempt to call qemuMonitorDriveDel for AttachSCSI failure path

Completion of fix for: https://bugzilla.redhat.com/show_bug.cgi?id=1336225 Similar to the other disk types, add the qemuMonitorDriveDel in the failure to add/hotplug a SCSI disk. Signed-off-by: John Ferlan --- src/qemu/qemu_hotplug.c | 17 ++--- 1 file

[libvirt] [PATCH v2 1/9] qemu: Reorder qemuDomainAttachUSBMassStorageDevice failure path

Modify the error/exit path to match what was done for Virtio and SCSI. If nothing else it'll have a consistent look'n'feel Signed-off-by: John Ferlan --- src/qemu/qemu_hotplug.c | 38 ++ 1 file changed, 22 insertions(+), 16 deletions(-)

[libvirt] [PATCH v2 2/9] qemu: Move drive alias processing to qemu_alias

Move qemuDeviceDriveHostAlias from qemu_command and rename to qemuAssignDeviceDiskDriveAlias in qemu_alias. Also change the parameter to just be the disk->info.alias (e.g. srcalias) Includes some innocent bystanders that seem to need QEMU_DRIVE_HOST_PREFIX which requires include qemu_alias.h

[libvirt] [PATCH v2 9/9] qemu: Use the hostdev alias in qemuDomainAttachHostSCSIDevice error path

Rather than pass the whole drive string (which contained the alias), pass only the alias for the qemuMonitorDriveDel call in the error path when adding a host device in the monitor fails. Signed-off-by: John Ferlan --- src/qemu/qemu_hotplug.c | 7 ++- 1 file changed, 6

[libvirt] [PATCH v2 3/9] qemu: Use qemuAssignDeviceDiskDriveAlias

Rather than open code build the drive alias command in multiple places, use the helper to ensure consistency. Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 12 ++-- src/qemu/qemu_driver.c | 3 +-- src/qemu/qemu_hotplug.c | 3 +--

[libvirt] [PATCH v2 8/9] qemu: Use qemuAssignSCSIHostDeviceDriveAlias

When building the command line alias and for SCSI Host Device deletion, use the common API to build the alias Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 12 +++- src/qemu/qemu_hotplug.c | 12 2 files changed, 11 insertions(+), 13

[libvirt] [PATCH v2 4/9] qemu: Make QEMU_DRIVE_HOST_PREFIX more private

Move QEMU_DRIVE_HOST_PREFIX into the qemu_alias.c to disuade future callers from using it. Create qemuAliasDeviceDiskDriveSkipPrefix in order to handle the current consumers that desire to check if an alias has the drive- prefix and "get beyond it" in order to get the disk alias. Signed-off-by:

[libvirt] [PATCH v2 5/9] qemu: Add attempt to call qemuMonitorDriveDel for USB failure path

Partial fix for: https://bugzilla.redhat.com/show_bug.cgi?id=1336225 Similar to the other disk types, add the qemuMonitorDriveDel in the failure to add/hotplug a USB. Added a couple of other formatting changes just to have a less cluttered look Signed-off-by: John Ferlan

[libvirt] [PATCH] qemu: Use legacy USB on ppc64

Commit 8156493d8db9 changed libvirt so that '-device pci-ohci' would be used instead of '-usb' on ppc64 when no specific USB controller model had been specified in the guest configuration. While the device that ends up being presented by the guest is exactly the same, '-usb' causes it to be

Re: [libvirt] [PATCH v4 0/7] Add support for LUKS encrypted devices

On 07/11/2016 02:07 PM, John Ferlan wrote: > According to Dan's post commit response: > > http://www.redhat.com/archives/libvir-list/2016-July/msg00088.html > > to the v3 series: > > http://www.redhat.com/archives/libvir-list/2016-June/msg01935.html > > using a 'passphrase' usage is not

Re: [libvirt] Minor compile failure on OSX for libvirt 2.0.0

On Sat, 2016-07-16 at 11:16 +0100, Justin Clift wrote: > Hi all, >  > There's a minor compile failure on OSX with libvirt 2.0.0: >  > CC   util/libvirt_util_la-virtime.lo > CC   util/libvirt_util_la-virtpm.lo >   util/virsystemd.c:524:26: error: use of undeclared identifier

[libvirt] [PATCH] configure: Check for MSG_NOSIGNAL availability

The symbol being missing has been reported as causing build failures on OS X. Check for its availability before using it. --- See https://www.redhat.com/archives/libvir-list/2016-July/msg00613.html configure.ac | 4 src/util/virsystemd.c | 4 ++-- 2 files changed, 6 insertions(+),

Re: [libvirt] [PATCH] Debug: Record the VM PID in per-VM logs.

On Sun, Jul 17, 2016 at 11:17:01PM -0700, Prerna Saxena wrote: For certain situations such as Out-of-memory scenarios, it is helpful to record the QEMU PID in the per-VM logs, so that correlation with kernel-reported events is easier. While this is already recorded in libvirt daemon logs as a

Re: [libvirt] [PATCH 0/7] Error path cleanup for hotplug and one function move/rename

On 07/19/2016 06:40 AM, Ján Tomko wrote: > On Fri, Jul 15, 2016 at 07:50:20AM -0400, John Ferlan wrote: >> During review of the LUKS series: >> >> http://www.redhat.com/archives/libvir-list/2016-July/msg00488.html >> >> it was noted that the error paths should use bools rather than goto >>

Re: [libvirt] [PATCH] virt-admin: Output srv-threadpool-info data as unsigned int rather than signed

On Mon, Jul 18, 2016 at 12:54:06PM +0200, Erik Skultety wrote: Internally, all the data are represented as unsigned int, it is also documented in the header file that users should use our exported constants that also indicate that the data should be unsigned int. However, when polling for the

Re: [libvirt] [PATCH 5/9] vsh: Properly initialize res

On Mon, Jul 18, 2016 at 03:06:56PM -0400, John Ferlan wrote: The 'res' variable was only being initialized to NULL in the if (!state) path; however, that path never used res and evenutally res is assigned one of two results based on a pair of if then else if conditions. If for some reason

Re: [libvirt] [PATCH 7/9] conf: Add ignore_value to virDomainDeviceInfoIterate calls for Clear helpers

On Mon, Jul 18, 2016 at 03:06:58PM -0400, John Ferlan wrote: Since we don't necessarily care about the status return, just add an ignore_value to the calls for virDomainDefClear* calls Found by Coverity Signed-off-by: John Ferlan --- src/conf/domain_conf.c | 6 +++--- 1

Re: [libvirt] [PATCH 0/7] Error path cleanup for hotplug and one function move/rename

On Fri, Jul 15, 2016 at 07:50:20AM -0400, John Ferlan wrote: During review of the LUKS series: http://www.redhat.com/archives/libvir-list/2016-July/msg00488.html it was noted that the error paths should use bools rather than goto failxxx type labels. So this series does that for a few of the

Re: [libvirt] [PATCH 5/7] qemu: Alter error path cleanup for qemuDomainAttachRNGDevice

On Fri, Jul 15, 2016 at 07:50:25AM -0400, John Ferlan wrote: Based on recent review comment - rather than have a spate of goto fail, change to a boolean based model. Ensures that the original error can be preserved and cleanup is a bit more orderly if more objects are added. Signed-off-by:

Re: [libvirt] [PATCH 4/7] qemu: Alter error path cleanup for qemuDomainAttachChrDevice

On Fri, Jul 15, 2016 at 07:50:24AM -0400, John Ferlan wrote: Based on recent review comment - rather than have a spate of goto fail, change to a boolean based model. Ensures that the original error can be preserved and cleanup is a bit more orderly if more objects are added. Signed-off-by:

Re: [libvirt] [PATCH 3/7] qemu: Alter error path cleanup for qemuDomainAttachSCSIDisk

On Fri, Jul 15, 2016 at 07:50:23AM -0400, John Ferlan wrote: Based on recent review comment - rather than have a spate of goto fail, change to a boolean based model. Ensures that the original error can be preserved and cleanup is a bit more orderly if more objects are added. Signed-off-by:

Re: [libvirt] [PATCH 1/7] qemu: Alter error path cleanup for qemuDomainAttachHostSCSIDevice

On Fri, Jul 15, 2016 at 07:50:21AM -0400, John Ferlan wrote: Based on recent review comment - rather than have a spate of goto fail, change to a boolean based model. Ensures that the original error can be preserved and cleanup is a bit more orderly if more objects are added. Signed-off-by:

Re: [libvirt] [PATCH] virt-admin: Output srv-threadpool-info data as unsigned int rather than signed

On Mon, Jul 18, 2016 at 12:54:06PM +0200, Erik Skultety wrote: Internally, all the data are represented as unsigned int, it is also documented in the header file that users should use our exported constants that also indicate that the data should be unsigned int. However, when polling for the

[libvirt] [PATCH] qemu: Reset error if we're not going to error label

Signed-off-by: Martin Kletzander --- src/qemu/qemu_conf.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index fa9d65e91967..2a889381090f 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@

Re: [libvirt] Adding ips and routes to type="ethernet" devices

Hi Cedric, On Tue, Jul 19, 2016 at 10:28 AM, Cedric Bosdonnat wrote: > Hi Ruben, > > On Mon, 2016-07-18 at 19:48 +0200, Ruben Kerkhof wrote: > [...] > >> I am a bit stuck though. I've created the vm with a tap device: >> >> >> >> >>

Re: [libvirt] [PATCH] Changes to support Veritas HyperScale (VxHS) block device protocol with qemu-kvm.

On Tue, Jul 19, 2016 at 12:28:45AM +, Ashish Mittal wrote: > From 9036f749f12d3bf4bf08e7e55b6d98109dd5e5c0 Mon Sep 17 00:00:00 2001 > From: Ashish Mittal > Date: Mon, 18 Jul 2016 16:21:37 -0700 > Subject: [PATCH] Changes to support Veritas HyperScale (VxHS) block

Re: [libvirt] Adding ips and routes to type="ethernet" devices

Hi Ruben, On Mon, 2016-07-18 at 19:48 +0200, Ruben Kerkhof wrote: [...] > I am a bit stuck though. I've created the vm with a tap device: > > > > > > > peer='192.168.42.42' prefix='32'/> > prefix='24'

[libvirt] [PATCH] fs: Fix '<' comparison of value produced by logical not '!'

Commit da665fbd introduced the following condition to virLXCProcessEnsureRootFS and openvzReadFSConf: if (!( = virDomainFSDefNew()) < 0) which broke the build on fedora with GCC 5.3.1: "logical not is only applied to the left hand side of comparison". Signed-off-by: Erik Skultety

Re: [libvirt] [PATCH] security: compilation error due to wrong parameter for vah_add_path().

On Mon, Jul 18, 2016 at 22:09:20 -0300, Julio Faracco wrote: > The commit da665fbd introduced virStorageSourcePtr inside the structure > _virDomainFSDef. This is causing an error when libvirt is being compiled. > > make[3]: Entering directory `/media/julio/8d65c59c-6ade-4740-9cdc-38016a4cb8ae >