[libvirt] [PATCH v4] libxl: implement virDomainBlockStats

Introduce initial support for domainBlockStats API call that allow us to query block device statistics. openstack nova uses this API call to query block statistics, alongside virDomainMemoryStats and virDomainInterfaceStats. Note that this patch only introduces it for VBD for starters. QDisk

Re: [libvirt] [PATCHv5 0/8] Assign addresses to USB devices

On 07/18/2016 12:15 PM, Ján Tomko wrote: > Patches 1-2 from v4 are pushed already. > > Patch 5/8 is new, adding new tests. > Patches 6/8 and 8/8 have not been ACKed in the previous version. > > > Ján Tomko (8): > Introduce virDomainUSBAddressSet > Add functions for adding USB controllers

Re: [libvirt] [PATCH v2 0/5] vz: make vz driver more responsive

20-Jul-16 18:00, Nikolay Shirokovskiy пишет: diff from original: 1. include patch to check domain status on acquiring job condition 2. add patch to fix domain objects naming (update device patch series which was created before convention was enstablished sneak

[libvirt] [PATCH v1 0/4] libxl: host cpu element in capabilities

Hey, This small series implements host cpu description in caps, by getting topology and xen hwcaps parsing done, followed by having cpu-{compare,baseline} APIs implemented. Last thing missing I think it would be to libxl_cpuid_set the features to enable/disable whichever format we choose plus the

[libvirt] [PATCH v1 4/4] libxl: implement virConnectBaselineCPU

Akin to previous commit but for "virsh cpu-baseline" which computes a baseline CPU for a set of host cpu elements. Signed-off-by: Joao Martins --- src/libxl/libxl_driver.c | 22 ++ 1 file changed, 22 insertions(+) diff --git

[libvirt] [PATCH v1 1/4] libxl: describe host topology in capabilities

Add support for describing cpu topology in host cpu element. In doing so, refactor hwcaps part to its own helper namely libxlCapsInitCPU to handle all host cpu related operations, including topology. Signed-off-by: Joao Martins --- src/libxl/libxl_capabilities.c | 46

[libvirt] [PATCH v1 2/4] libxl: describe host cpu features based on hwcaps

Parse libxl_hwcap accounting for versions since Xen 4.4 - Xen 4.7. libxl_hwcaps is a set of cpuid leaves output that is described in [0] or [1] in Xen 4.7. This is a collection of CPUID leaves that we version in libvirt whenever feature words are reordered or added. Thus we keep the common ones in

[libvirt] [PATCH v1 3/4] libxl: implement virConnectCompareCPU

Implement support for "virsh cpu-compare" so that we can calculate common cpu element between a pool of hosts, which had a requirement of providing host cpu description. Signed-off-by: Joao Martins --- src/libxl/libxl_driver.c | 38

[libvirt] [PATCH v2 4/5] vz: make vz driver more responsive

Current vz driver implementation is not usable when it comes to long runnig operations. Migration or saving a domain blocks all other operations even query ones which are expecteted to be available. This patch address this problem. All vz driver API calls fall into next 3 groups: 1. only

[libvirt] [PATCH v2 1/5] vz: use state variable sdkdom in prlsdkApplyConfig

sdk domain handle is unique per connection so there is no sense to query it again if we have it in vzDomObjPtr. Side effect of prlsdkSdkDomainLookupByUUID is refreshing domain config is of no use too as PrlVm_BeginEdit do it too. --- src/vz/vz_sdk.c | 14 -- 1 file changed, 4

[libvirt] [PATCH v2 5/5] vz: handle gracefully races on undefining domain

This patch is not critical but nice to have. The original motivation was error message in logs on undefining domain thru vz driver. Undefine procedure drops domain lock while waiting for detaching disks vz sdk call. Meanwhile vz sdk event domain-config-changed arrives, its handler finds domain

[libvirt] [PATCH v2 2/5] vz: remove redundant variable in prlsdkHandleVmAddedEvent

--- src/vz/vz_sdk.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index 6b5adbf..5390ead 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -2036,7 +2036,6 @@ prlsdkHandleVmAddedEvent(vzDriverPtr driver, unsigned char *uuid) {

[libvirt] [PATCH v2 3/5] vz: keep naming convention for domain objects

see 4385b868 --- src/vz/vz_driver.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index c12832c..2ad3d94 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -1208,38 +1208,38 @@

[libvirt] [PATCH v2 0/5] vz: make vz driver more responsive

diff from original: 1. include patch to check domain status on acquiring job condition 2. add patch to fix domain objects naming (update device patch series which was created before convention was enstablished sneak in) 3. squash in all quickfixes 4. rename

[libvirt] wireshark compilation warning

I'm seeing this compilation warning on Fedora 24, with wireshark-devel-2.1.0-3.fc24.x86_64 which has the header file fix that was previously breaking compilation: CC wireshark/src/wireshark_src_libvirt_la-packet-libvirt.lo CC wireshark/src/wireshark_src_libvirt_la-plugin.lo CCLD

Re: [libvirt] [PATCH v3] util: systemd: Define MSG_NOSIGNAL if needed

On 20 Jul 2016, at 14:46, Andrea Bolognani wrote: > The symbol being missing has been reported as causing build > failures on OS X. If it's not already defined, define it to > zero so that it won't have any effect. > --- > Changes from v2: > > * define MSG_NOSIGNAL to zero

Re: [libvirt] [PATCH] qemu: Use legacy USB on ppc64

On Wed, 2016-07-20 at 14:17 +0100, Daniel P. Berrange wrote: > On Tue, Jul 19, 2016 at 07:04:36PM +0200, Andrea Bolognani wrote: > >  > > On Tue, 2016-07-19 at 16:17 +0200, Andrea Bolognani wrote: > > >  > > > Commit 8156493d8db9 changed libvirt so that '-device pci-ohci' > > > would be used

Re: [libvirt] [PATCH v2] configure: Check for MSG_NOSIGNAL availability

On Wed, 2016-07-20 at 14:49 +0100, Justin Clift wrote: > > v3 coming right up! >  > Trivial side thought... since this isn't a "configure" patch any more, should > the title for the patch be adjusted? ;) Definitely! Luckily, I realized that on my own before sending out v3 and making a fool of

[libvirt] [PATCH 5/9] remote: implement node device lifecycle event APIs

--- daemon/libvirtd.h| 2 + daemon/remote.c | 206 +++ src/remote/remote_driver.c | 139 + src/remote/remote_protocol.x | 43 - src/remote_protocol-structs | 19 5 files changed, 408

[libvirt] [PATCH 8/9] event-test: support node device lifecycle event APIs

--- examples/object-events/event-test.c | 68 + 1 file changed, 68 insertions(+) diff --git a/examples/object-events/event-test.c b/examples/object-events/event-test.c index f2f71cc..2f9756a 100644 --- a/examples/object-events/event-test.c +++

[libvirt] [PATCH 7/9] node_device: Implement event queue in udev

--- src/node_device/node_device_udev.c | 24 1 file changed, 24 insertions(+) diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c index 76c60ea..a4748ef 100644 --- a/src/node_device/node_device_udev.c +++

[libvirt] [PATCH 6/9] node_device: implement node device lifecycle event APIs

--- src/conf/node_device_conf.h | 4 src/node_device/node_device_driver.c | 42 src/node_device/node_device_driver.h | 10 + 3 files changed, 56 insertions(+) diff --git a/src/conf/node_device_conf.h b/src/conf/node_device_conf.h index

[libvirt] [PATCH 9/9] virsh: Introduce nodedev-event command

Add nodedev-event support for node device lifecycle events --- tools/virsh-nodedev.c | 211 ++ tools/virsh-nodedev.h | 10 +++ tools/virsh.pod | 18 + 3 files changed, 239 insertions(+) diff --git a/tools/virsh-nodedev.c

[libvirt] [PATCH 3/9] conf: events: don't crash on NULL uuid

nodedev events don't have a uuid value and will pass in NULL --- src/conf/object_event.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/conf/object_event.c b/src/conf/object_event.c index cb984ff..bbef7f6 100644 --- a/src/conf/object_event.c +++

[libvirt] [PATCH 0/9] Introducing node device lifecycle event APIs

Introducing implementation of node device event APIs. Code changes follow network/storage pool event APIs. Implemented functions: virNodeDeviceEventRegisterAny(), virNodeDeviceEventDeregisterAny(), virNodeDeviceLifeCycleEventNew(), introduced CREATED and DELETED. There are also test as well as

[libvirt] [PATCH 2/9] conf: add node_device_event handling

Add node device event handling infrastructure to node_device_event.[ch] --- src/Makefile.am | 5 + src/conf/node_device_event.c | 234 +++ src/conf/node_device_event.h | 59 +++ src/libvirt_private.syms | 5 + 4 files changed,

[libvirt] [PATCH 1/9] Introduce node device lifecycle event APIs

Node device lifecycle event API entry points for registering and deregistering node deivce events, as well as types of events associated with node devices. These entry points will be used for implementing asynchronous lifecycle events. Node device API: virConnectNodeDeviceEventRegisterAny

[libvirt] [PATCH 4/9] test: implement node device lifecycle event APIs

Also includes unittests for node device lifecycle events API --- src/test/test_driver.c | 49 + tests/objecteventtest.c | 72 + 2 files changed, 121 insertions(+) diff --git a/src/test/test_driver.c

Re: [libvirt] [PATCH v2] configure: Check for MSG_NOSIGNAL availability

On 20 Jul 2016, at 14:38, Andrea Bolognani wrote: > On Wed, 2016-07-20 at 14:19 +0100, Daniel P. Berrange wrote: >> On Wed, Jul 20, 2016 at 03:16:35PM +0200, Andrea Bolognani wrote: >>> >>> The symbol being missing has been reported as causing build >>> failures on OS X.

[libvirt] [PATCH v3] util: systemd: Define MSG_NOSIGNAL if needed

The symbol being missing has been reported as causing build failures on OS X. If it's not already defined, define it to zero so that it won't have any effect. --- Changes from v2: * define MSG_NOSIGNAL to zero if not already defined instead of conditionally compiling the code depending

Re: [libvirt] [PATCH v2] configure: Check for MSG_NOSIGNAL availability

On Wed, 2016-07-20 at 14:19 +0100, Daniel P. Berrange wrote: > On Wed, Jul 20, 2016 at 03:16:35PM +0200, Andrea Bolognani wrote: > >  > > The symbol being missing has been reported as causing build > > failures on OS X. Check for its availability before using it. > > --- > > Changes from v1: > > 

Re: [libvirt] [PATCH v2] configure: Check for MSG_NOSIGNAL availability

On Wed, Jul 20, 2016 at 03:16:35PM +0200, Andrea Bolognani wrote: > The symbol being missing has been reported as causing build > failures on OS X. Check for its availability before using it. > --- > Changes from v1: > > * don't unnecessarily check for availability at configure > time

Re: [libvirt] [PATCH] qemu: Use legacy USB on ppc64

On Tue, Jul 19, 2016 at 07:04:36PM +0200, Andrea Bolognani wrote: > On Tue, 2016-07-19 at 16:17 +0200, Andrea Bolognani wrote: > > Commit 8156493d8db9 changed libvirt so that '-device pci-ohci' > > would be used instead of '-usb' on ppc64 when no specific USB > > controller model had been

Re: [libvirt] [PATCH] configure: Check for MSG_NOSIGNAL availability

On 19 Jul 2016, at 15:48, Andrea Bolognani wrote: > On Tue, 2016-07-19 at 16:23 +0200, Ján Tomko wrote: >> On Tue, Jul 19, 2016 at 04:00:25PM +0200, Andrea Bolognani wrote: >>> >>> The symbol being missing has been reported as causing build >>> failures on OS X. Check for

[libvirt] [PATCH v2] configure: Check for MSG_NOSIGNAL availability

The symbol being missing has been reported as causing build failures on OS X. Check for its availability before using it. --- Changes from v1: * don't unnecessarily check for availability at configure time (thanks J??n) src/util/virsystemd.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [libvirt] Minor compile failure on OSX for libvirt 2.0.0

On 20 Jul 2016, at 13:57, Justin Clift wrote: On 20 Jul 2016, at 13:43, Andrea Bolognani wrote: >> If you post the error message you're getting we'll of course >> try to help you out to the best of our possibilities :) > > Sure. Lets see if my 2nd

Re: [libvirt] Minor compile failure on OSX for libvirt 2.0.0

On 20 Jul 2016, at 13:43, Andrea Bolognani wrote: > On Wed, 2016-07-20 at 13:28 +0100, Justin Clift wrote: >> I'll put more time into investigating why the patch barfed for me. I >> think it'll just be something simple like forgetting to set the time/date >> stamp of the

[libvirt] [PATCH] lxc: Don't crash by forgetting to ref transient domains

So commit 306b3a8504 tried mimicking behaviour of commit 540c339a25, but added a virObjectRef(vm) only after virDomainObjListAdd() in lxcDomainDefineXMLFlags() and not in lxcDomainCreateXMLWithFiles(). That way undefining a domain that was started with different XML than defined will leave the

Re: [libvirt] [RFC PATCH 0/2] nodeinfo: PPC64: Fix topology and siblings info on capabilities and nodeinfo

On Wed, Jul 20, 2016 at 02:33:33PM +0200, Andrea Bolognani wrote: > On Tue, 2016-07-19 at 15:35 +0100, Daniel P. Berrange wrote: > > On Thu, May 05, 2016 at 08:48:05PM +0200, Andrea Bolognani wrote: > > >  > > > On Fri, 2016-01-29 at 01:32 -0500, Shivaprasad G Bhat wrote: > > > >  > > > > The

Re: [libvirt] Minor compile failure on OSX for libvirt 2.0.0

On Wed, 2016-07-20 at 13:28 +0100, Justin Clift wrote: > I'll put more time into investigating why the patch barfed for me.  I > think it'll just be something simple like forgetting to set the time/date > stamp of the patched file so make doesn't try to regenerate ./configure > again.  Will find

[libvirt] [PATCH 1/2] schema: add missed alias element to memory device

--- docs/schemas/domaincommon.rng | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 741f268..eb78187 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -4681,6 +4681,9 @@

[libvirt] [PATCH 0/2] a couple of schema fixes

Nikolay Shirokovskiy (2): schema: add missed alias element to memory device schema: fix resolved interfaces of network type docs/schemas/domaincommon.rng | 43 +- docs/schemas/network.rng | 5 + docs/schemas/networkcommon.rng | 6 ++ 3

[libvirt] [PATCH 2/2] schema: fix resolved interfaces of network type

This patch reflects cases when element and its subelement for network type are formated based on actual type resolved from referenced network instead of original one. networkAllocateActualDevice and virDomainActualNetDefContentsFormat are taken as reference. --- docs/schemas/domaincommon.rng

Re: [libvirt] [RFC PATCH 0/2] nodeinfo: PPC64: Fix topology and siblings info on capabilities and nodeinfo

On Tue, 2016-07-19 at 15:35 +0100, Daniel P. Berrange wrote: > On Thu, May 05, 2016 at 08:48:05PM +0200, Andrea Bolognani wrote: > >  > > On Fri, 2016-01-29 at 01:32 -0500, Shivaprasad G Bhat wrote: > > >  > > > The nodeinfo output was fixed earlier to reflect the actual cpus > > > available in >

Re: [libvirt] Minor compile failure on OSX for libvirt 2.0.0

On 20 Jul 2016, at 12:21, Martin Kletzander wrote: > On Tue, Jul 19, 2016 at 06:30:47PM +0100, Justin Clift wrote: >> On 19 Jul 2016, at 17:58, Andrea Bolognani wrote: >>> Did you manage to build and run libvirt succesfully with the >>> patch I posted?

Re: [libvirt] [PATCH] qemu: Reset error if we're not going to error label

On Wed, Jul 20, 2016 at 10:17:35AM +0200, Andrea Bolognani wrote: On Tue, 2016-07-19 at 11:00 +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander ---   src/qemu/qemu_conf.c | 7 +--   1 file changed, 5 insertions(+), 2 deletions(-)   diff --git

Re: [libvirt] Minor compile failure on OSX for libvirt 2.0.0

On Tue, Jul 19, 2016 at 06:30:47PM +0100, Justin Clift wrote: On 19 Jul 2016, at 17:58, Andrea Bolognani wrote: On Tue, 2016-07-19 at 16:30 +0100, Justin Clift wrote: On 19 Jul 2016, at 15:03, Andrea Bolognani wrote: It's outside the #endif for

[libvirt] [PATCH 2/2] Remove unnecessary virDomainDefClearDeviceAliases

Nothing in the code path after the removed call has needs/uses the alias anyway (as would be the case for command line building or talking to monitor). The alias is VIR_FREE'd in virDomainDeviceInfoClear which is called for any device that needs/uses an alias via virDomainDeviceDefFree or

[libvirt] [PATCH 0/2] Remove calls that just clear alias

Based off review of : http://www.redhat.com/archives/libvir-list/2016-July/msg00672.html Rather than add the ignore_value, just remove the unused / unnecessary code Patch 1 has no callers any more and from inspection patch 2 is essentially redone again as each device is handled during domain def

[libvirt] [PATCH 1/2] conf: Remove CCW,PCI clear address helpers

Since commit id 'fb06350' these are no longer called, so remove them Signed-off-by: John Ferlan --- src/conf/domain_conf.c | 35 --- src/conf/domain_conf.h | 2 -- src/libvirt_private.syms | 2 -- 3 files changed, 39 deletions(-) diff

[libvirt] [PATCH 2/5] rpc: virnetserver: Move virNetServerCheckLimits which is static up in the file

Since virNetServerAddClient checks for the limits in order to temporarily suspend the services, thus not accepting any more clients, there is no reason why virNetServerCheckLimits, which is only responsible for re-enabling previously disabled services according to the limits, could not do both. To

[libvirt] [PATCH 4/5] admin: rpc: virnetserver: Fix updating of the client limits

Commit 2737aaaf changed our policy for accepting new clients in a way, that instead of accepting new clients only to disconnect them immediately because that would overcommit the limit we temporarily disable polling for the dedicated file descriptor, so any new connection will queue on the socket.

[libvirt] [PATCH 3/5] rpc: virnetserver: Add code to CheckLimits to handle suspending of services

So far, virNetServerCheckLimits was only used to possibly re-enable accepting new clients that might have previously by disabled due to client limits violation (max_clients, max_anonymous_clients). This patch refactors virNetServerAddClient which is currently the only place where the services get

[libvirt] [PATCH 1/5] rpc: virnetserver: Rename ClientSetProcessingControls to ClientSetLimits

The original naming was just a leftover that should have been fixed in commit 8b1f0469. Signed-off-by: Erik Skultety --- daemon/admin_server.c | 4 ++-- src/rpc/virnetserver.c | 6 +++--- src/rpc/virnetserver.h | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-)

[libvirt] [PATCH 0/5] admin: Fix updating of the client limits

This series slightly refactors the code in virnetserver.c in order to resolve https://bugzilla.redhat.com/show_bug.cgi?id=1357776. The problem resides in updating of the client limits which even though updated, thus "permitting" new connections to be established, do not re-enable polling for the

[libvirt] [PATCH 5/5] rpc: virnetserver: Remove dead code checking the client limits

Prior to commit 2737aaaf, we allowed every client to connect successfully, however, if accepting the client would eventually lead to an overcommit of the limits, we would disconnect it immediately with "Too many active clients, dropping connection from...". Commits 4d693241 and e34fbb9e refactored

Re: [libvirt] [PATCH 0/2] Need to set booleans in right place for hotplug cleanup

On Tue, Jul 19, 2016 at 10:54:48AM -0400, John Ferlan wrote: After pushing and working on the next set of changes, I realized that the setting of some booleans needed to be inside an if condition . John Ferlan (2): qemu: Move setting of obj bools for qemuDomainAttachVirtioDiskDevice qemu:

Re: [libvirt] [PATCH 1/3] storage: Fix error path

On Tue, Jul 19, 2016 at 02:27:40PM -0400, John Ferlan wrote: > virStorageBackendCreateQemuImgCheckEncryption didn't return -1 if there > were no secrets. > > Signed-off-by: John Ferlan > --- > src/storage/storage_backend.c | 1 + > 1 file changed, 1 insertion(+) ACK

Re: [libvirt] [PATCH 3/3] storage: Add extra failure condition for luks volume creation

On Tue, Jul 19, 2016 at 02:27:42PM -0400, John Ferlan wrote: > Commit id '5e46d7d6' did not take into account that usage of a luks > volume will require usage of the master key encrypted passphrase for > a QEMU environment. So rather than allow creation of something that > won't be usable, just

Re: [libvirt] [PATCH 2/3] qemu: Disallow usage of luks encryption if aes secret not possible

On Tue, Jul 19, 2016 at 02:27:41PM -0400, John Ferlan wrote: > Resolves a CI test integration failure with a RHEL6/Centos6 environment. > > In order to use a LUKS encrypted device, the design decision was to > generate an encrypted secret based on the master key. However, commit > id 'da86c6c'

Re: [libvirt] [PATCH] qemu: Reset error if we're not going to error label

On Tue, 2016-07-19 at 11:00 +0200, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- >  src/qemu/qemu_conf.c | 7 +-- >  1 file changed, 5 insertions(+), 2 deletions(-) >  > diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c > index

Re: [libvirt] [PATCHv2 3/3] hvsupport: skip non-matching lines early

On Tue, Jul 19, 2016 at 18:55:54 +0200, Ján Tomko wrote: > Most of the lines we look at are not going to match one of the > driver types contained in $groups_regex. > > Move on to the next line if it does not contain any of them early. > This speeds up the script execution by 50%, since this

Re: [libvirt] [PATCHv2 2/3] hvsupport: construct the group regex upfront

On Tue, Jul 19, 2016 at 18:55:53 +0200, Ján Tomko wrote: > The %groups hash contains all the driver types (e.g. > virHypervisorDriver or virSecretDriver). > > When searching for all the APIs that are implemented by a driver > of that specific driver type, we keep iterating over the %groups > hash

Re: [libvirt] [PATCH] qemu: Reset error if we're not going to error label

On Tue, Jul 19, 2016 at 11:00:56AM +0200, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/qemu/qemu_conf.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index

Re: [libvirt] [PATCHv2 1/3] hvsupport: use a regex instead of XML::XPath

On Tue, Jul 19, 2016 at 18:55:52 +0200, Ján Tomko wrote: > When generating the hvsupport.html.in file, we parse the -api.xml > files generated by apibuild.py to know in which HTML file the API > function is. > > Doing an XPath query for every single 'function' element in the > file is

Re: [libvirt] [PATCH] qemu: Fix backwards compatibility of S390 guests

On Wed, Jul 20, 2016 at 09:13:54 +0200, Boris Fiuczynski wrote: > This patch reverts commit 73e4e10e62e4b1aea64b317be96af5e5488007d7 > and thereby disabling the panic device autogeneration for S390 guests. > In addition tests are patched as well. > > The reverted commit breaks backwards

[libvirt] [PATCH] qemu: Fix backwards compatibility of S390 guests

This patch reverts commit 73e4e10e62e4b1aea64b317be96af5e5488007d7 and thereby disabling the panic device autogeneration for S390 guests. In addition tests are patched as well. The reverted commit breaks backwards compatibility of S390 guests. As an example: A domain xml without a panic device