Re: [libvirt] [PATCH] device_conf: Let compiler decide on inlining functions

On Mon, Aug 01, 2016 at 06:21:49PM +0200, Michal Privoznik wrote: There's no point in forcing some functions to be both 'static' and 'inline' at the same time at the header file level. This leads to a situation where just linking the file defines those function (potentially needlessly). Instead,

Re: [libvirt] [PATCH 2/2] virpci: support driver_override sysfs interface

On 07/29/2016 11:43 AM, Laine Stump wrote: > On 07/11/2016 02:23 PM, Jim Fehlig wrote: >> Currently, libvirt uses the new_id PCI sysfs interface to bind a PCI >> stub driver to a PCI device. The new_id interface is known to be >> buggy and racey, hence a more deterministic interface was introduced

Re: [libvirt] [PATCH 1/2] virpci: simplify virPCIDeviceBindToStub

On 07/28/2016 06:01 PM, Laine Stump wrote: > On 07/11/2016 02:23 PM, Jim Fehlig wrote: >> Early in virPCIDeviceBindToStub, there is a check to see if the >> stub is already bound to the device, returning success with no >> further actions if that is the case. >> >> The same condition is

[libvirt] [PATCH V2] virpci: support driver_override sysfs interface

libvirt uses the new_id PCI sysfs interface to bind a PCI stub driver to a PCI device. The new_id interface is known to be buggy and racey, hence a more deterministic interface was introduced in the 3.12 kernel: driver_override. For more details see

[libvirt] [PATCH] qemu: fix libvirtd crash in migration after vm shutdown

[PATCH] qemu: fix libvirtd crash in migration after vm shutdown If we shutdown a guest, then migrate it without the arg XML, libvirtd will get crashed. The reason is that: 1 during shutdown callback, qemuProcessStop() , it points vm->def to vm->newDef 2 during migration, it frees

Re: [libvirt] [PATCH 0/3] qemu: Don't error out on missing optional disk

On 08/01/2016 12:05 PM, Martin Kletzander wrote: > More info in PATCH 3/3. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1168453 > > > Martin Kletzander (3): > qemu: Make qemuDomainCheckDiskStartupPolicy self-contained > qemu: Remove unnecessary label and its only reference >

[libvirt] [gconfig v2 1/4] Introduce libvirt-domain-graphics-listen

From: Visarion Alexandru Abstract class which represents a listen child node of the graphics device. --- libvirt-gconfig/Makefile.am| 2 + .../libvirt-gconfig-domain-graphics-listen.c | 48

[libvirt] [gconfig v2 3/4] config: Add vnc host setter

From: Visarion Alexandru Learn to set the address that vnc is listening on. We first remove the 'listen' attribute to avoid inconsistencies checks between the 'listen' attribute and the 'address' attribute of the 'listen' node. ---

[libvirt] [gconfig v2 4/4] config: Add spice host setter

From: Visarion Alexandru Learn to set the address that spice is listening on. We first remove the 'listen' attribute to avoid inconsistencies checks between the 'listen' attribute and the 'address' attribute of the 'listen' node. ---

[libvirt] [gconfig v2 0/4] Add support for changing listen address

From: Visarion Alexandru libvirt-domain-graphics-listen defines an abstract class used to represent one listen node. libvirt-domain-graphics-liste-address defines a class that represents a listen node of type 'address', for the graphics device. We have to first

[libvirt] [gconfig v2 2/4] Introduce libvirt-gconfig-domain-graphics-listen-address

From: Visarion Alexandru This is needed to be able to change the address a graphics device is listening on. --- libvirt-gconfig/Makefile.am| 2 + ...ibvirt-gconfig-domain-graphics-listen-address.c | 79 ++

Re: [libvirt] [PATCH 2/5] Introduce SMM feature

On 08/01/16 19:05, Gerd Hoffmann wrote: > Hi, > >> If it does, then the host kernel should be 4.4 or later. (If we want to >> capture version numbers, then for each minor release, the latest patch >> level should be required: 4.4.16, 4.5.7, 4.6.5, 4.7.0, because there >> have been a number of

Re: [libvirt] [PATCH v2 8/9] qemu: Use qemuAssignSCSIHostDeviceDriveAlias

On 07/19/2016 10:30 AM, John Ferlan wrote: > When building the command line alias and for SCSI Host Device deletion, > use the common API to build the alias > > Signed-off-by: John Ferlan > --- > src/qemu/qemu_command.c | 12 +++- > src/qemu/qemu_hotplug.c | 12

Re: [libvirt] [PATCH 2/5] Introduce SMM feature

Hi, > If it does, then the host kernel should be 4.4 or later. (If we want to > capture version numbers, then for each minor release, the latest patch > level should be required: 4.4.16, 4.5.7, 4.6.5, 4.7.0, because there > have been a number of KVM tweaks and stable backports for SMM support.)

Re: [libvirt] [PATCH v2] storage: Document wiping formatted volume types

On 08/01/2016 12:16 PM, Martin Kletzander wrote: > When wiping a volume we just rewrite all the data of the volume, not > only the content. Since format gets overridden, we need to recreate the > volume. However we can't do that for every possible format out there. > Since it was only coded

Re: [libvirt] Question about LSN-2016-0001

On 08/01/2016 10:14 AM, Daniel P. Berrange wrote: > On Mon, Aug 01, 2016 at 10:00:05AM -0600, Jim Fehlig wrote: >> On 08/01/2016 03:13 AM, Daniel P. Berrange wrote: >>> On Fri, Jul 29, 2016 at 02:16:16PM -0600, Jim Fehlig wrote: I've noticed the behavior described by this LSN with

[libvirt] [PATCH] device_conf: Let compiler decide on inlining functions

There's no point in forcing some functions to be both 'static' and 'inline' at the same time at the header file level. This leads to a situation where just linking the file defines those function (potentially needlessly). Instead, we should let the compiler (linker) decide whether the function are

[libvirt] [PATCH v2] storage: Document wiping formatted volume types

When wiping a volume we just rewrite all the data of the volume, not only the content. Since format gets overridden, we need to recreate the volume. However we can't do that for every possible format out there. Since it was only coded for the ploop volume type, let's document what might be the

Re: [libvirt] Question about LSN-2016-0001

On Mon, Aug 01, 2016 at 10:00:05AM -0600, Jim Fehlig wrote: > On 08/01/2016 03:13 AM, Daniel P. Berrange wrote: > > On Fri, Jul 29, 2016 at 02:16:16PM -0600, Jim Fehlig wrote: > >> I've noticed the behavior described by this LSN with libvirt+Xen. Config > >> containing allows any client to > >>

Re: [libvirt] [PATCH] storage: Document wiping formatted volume types

On Mon, Aug 01, 2016 at 11:40:11AM -0400, John Ferlan wrote: On 08/01/2016 09:13 AM, Martin Kletzander wrote: When wiping a volume we just rewrite all the data of the volume, not only the content. Since format gets overriden, we need to recreate the overridden volume. However we can't

Re: [libvirt] [PATCH 3/3] storage: Clean up volume wiping

On Mon, Aug 01, 2016 at 11:10:19AM -0400, John Ferlan wrote: On 08/01/2016 09:12 AM, Martin Kletzander wrote: Let's cleanly differentiate what wiping a volume does for ploop and other volumes so it's more readable what is done for each one instead of branching out multiple times in different

[libvirt] [PATCH 1/3] qemu: Make qemuDomainCheckDiskStartupPolicy self-contained

There is an error reset following the function and check for startupPolicy before that. Let's reflect those things inside that function so that future code doesn't have to be that complex. Signed-off-by: Martin Kletzander --- src/qemu/qemu_domain.c | 10 +++--- 1 file

[libvirt] [PATCH 3/3] qemu: Fix support for startupPolicy with volume/pool disks

Until now we simply errored out when the translation from pool+volume failed. However, we should instead check whether that disk is needed or not since there is an option for that. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1168453 Signed-off-by: Martin Kletzander

[libvirt] [PATCH 2/3] qemu: Remove unnecessary label and its only reference

Signed-off-by: Martin Kletzander --- src/qemu/qemu_domain.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index adbc63fdaa7f..939db02fe353 100644 --- a/src/qemu/qemu_domain.c +++

[libvirt] [PATCH 0/3] qemu: Don't error out on missing optional disk

More info in PATCH 3/3. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1168453 Martin Kletzander (3): qemu: Make qemuDomainCheckDiskStartupPolicy self-contained qemu: Remove unnecessary label and its only reference qemu: Fix support for startupPolicy with volume/pool disks

Re: [libvirt] Question about LSN-2016-0001

On 08/01/2016 03:13 AM, Daniel P. Berrange wrote: > On Fri, Jul 29, 2016 at 02:16:16PM -0600, Jim Fehlig wrote: >> I've noticed the behavior described by this LSN with libvirt+Xen. Config >> containing allows any client to >> connect with no authentication check. I asked about this on the Xen

Re: [libvirt] [PATCH 0/2] admin: sasl: Save the SASL username to client's identity

On 29.07.2016 09:54, Erik Skultety wrote: > Erik Skultety (2): > admin: Retrieve the SASL context for both local and remote connection > daemon: sasl: Don't forget to save SASL username to client's identity > > daemon/admin_server.c | 14 +++--- > daemon/remote.c | 6 ++ >

Re: [libvirt] [PATCH] storage: Document wiping formatted volume types

On 08/01/2016 09:13 AM, Martin Kletzander wrote: > When wiping a volume we just rewrite all the data of the volume, not > only the content. Since format gets overriden, we need to recreate the overridden > volume. However we can't do that for every possible format there. And s/ there.

Re: [libvirt] [PATCH 0/3] storage: Clean up some volume wiping code

On 08/01/2016 09:11 AM, Martin Kletzander wrote: > Just a cleanup so that some functionality is more readable (about > what's being done for ploop volumes when wiping them) and extensible > in the future. Feel free to NACK if I'm the only one that finds this > more readable. > > > Martin

[libvirt] [PATCH 4/5] conf: Introduce memAccess to

Now that NVDIMM has found its way into libvirt, users might want to fine tune some settings for each module separately. One such setting is 'share=on|off' for the memory-backend-file object. This setting - just like its name suggest already - enables sharing the nvdimm module with other

[libvirt] [PATCH 3/5] qemu: Implement NVDIMM

So, majority of the code is just ready as-is. Well, with one slight change: differentiate between dimm and nvdimm in places like device alias generation, generating the command line and so on. Speaking of the command line, we also need to append 'nvdimm=on' to the '-machine' argument so that the

[libvirt] [PATCH 1/5] Introduce NVDIMM memory model

NVDIMM is new type of memory introduced in qemu. The idea is that we have a DIMM module that keeps the data persistent across domain reboots. At the domain XML level, we already have some representation of 'dimm' modules. Long story short, we have element that lives under . Now, the element even

Re: [libvirt] [PATCH 3/3] storage: Clean up volume wiping

On 08/01/2016 09:12 AM, Martin Kletzander wrote: > Let's cleanly differentiate what wiping a volume does for ploop and > other volumes so it's more readable what is done for each one instead of > branching out multiple times in different parts of the same function. > > Signed-off-by: Martin

[libvirt] [PATCH 5/5] qemu: Implement memAccess for banks

Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c| 11 +++-- src/qemu/qemu_command.h| 1 + src/qemu/qemu_hotplug.c| 3 ++- ...muxml2argv-memory-hotplug-nvdimm-memAccess.args |

[libvirt] [PATCH 2/5] qemu: Introduce QEMU_CAPS_DEVICE_NVDIMM

Introduce a qemu capability for -device nvdimm. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + 3 files changed, 4

[libvirt] [PATCH 0/5] Introduce NVDIMM support

NVDIMM was introduced to qemu in v2.6.0-rc0~248^2~25. So it's been a while since then. It's not the next big thing, but it is very interesting feature enabling higher performance as reading/writing to the module (and subsequently to the file on the host) does not require a VMEXIT. It can be used

Re: [libvirt] [PATCH 2/5] Introduce SMM feature

On 08/01/16 14:28, Gerd Hoffmann wrote: > Hi, > >> ... Gerd's above metadata change is dated 2016-03-21, at which point >> both QEMU v2.4.0 and v2.5.0 had been tagged (on 2015-08-11 and on >> 2015-12-16, respectively). I guess Gerd may have mis-remembered the >> exact QEMU release which

Re: [libvirt] [PATCH] wireshark dissector compile fix

On Mon, 1 Aug 2016 10:25:48 +0200 Michal Privoznik wrote: > Ah, you're right. Looks like the only glib function that the dissector > actually uses is g_sprintf(), which in this case provides no added value > to plain sprintf(). I've posted the patch here: > >

Re: [libvirt] [PATCH RFC 0/8] qemu: allow disabling certain virtio revisions

On 07/29/2016 09:37 AM, Ján Tomko wrote: For https://bugzilla.redhat.com/show_bug.cgi?id=1227354 some users might want to adjust the QEMU defaults and disable either virtio 0.9 or virtio 1.0 (spelled out as disable-legacy and disable-modern on qemu command line). This series uses a separate

Re: [libvirt] [PATCH v2 7/9] qemu: Introduce qemuAssignSCSIHostDeviceDriveAlias

On 07/19/2016 10:30 AM, John Ferlan wrote: > Introduce a common API to generate the alias for a SCSI Host device > > Signed-off-by: John Ferlan > --- > src/qemu/qemu_alias.c | 18 ++ > src/qemu/qemu_alias.h | 2 ++ > 2 files changed, 20 insertions(+) >

[libvirt] [PATCH] storage: Document wiping formatted volume types

When wiping a volume we just rewrite all the data of the volume, not only the content. Since format gets overriden, we need to recreate the volume. However we can't do that for every possible format there. And since it was only coded for the ploop volume type, let's document what might be the

[libvirt] [PATCH 3/3] storage: Clean up volume wiping

Let's cleanly differentiate what wiping a volume does for ploop and other volumes so it's more readable what is done for each one instead of branching out multiple times in different parts of the same function. Signed-off-by: Martin Kletzander ---

[libvirt] [PATCH 0/3] storage: Clean up some volume wiping code

Just a cleanup so that some functionality is more readable (about what's being done for ploop volumes when wiping them) and extensible in the future. Feel free to NACK if I'm the only one that finds this more readable. Martin Kletzander (3): storage: Move functions around storage: Use path

[libvirt] [PATCH 1/3] storage: Move functions around

This is done in order to call them in next patches from each other and definitions would be missing otherwise. Signed-off-by: Martin Kletzander --- src/storage/storage_backend.c | 100 ++ 1 file changed, 53 insertions(+), 47

[libvirt] [PATCH 2/3] storage: Use path instead of volume as an argument

Some functions use volume specification merely to use the target path from it. Let's change it to pass the path only so that it can be used for other files than just volumes. Signed-off-by: Martin Kletzander --- src/storage/storage_backend.c | 21 ++--- 1

[libvirt] [PATCHv3 2c/9] qemu: Use qemuAliasFromDisk instead of qemuDeviceDriveHostAlias

Since we already have a function that will generate the drivestr from the alias, let's use it and remove the qemuDeviceDriveHostAlias. Move the QEMU_DRIVE_HOST_PREFIX definition into qemu_alias.h. Also alter qemuAliasFromDisk to use the QEMU_DRIVE_HOST_PREFIX instead of "drive-%s".

Re: [libvirt] [java binding] Retrieve VM IP address

On 31.07.2016 20:58, Fabien DUMINY wrote: > After reading https://github.com/fog/fog-libvirt/pull/11, I realize it > should possible to get ip address of a domain from java binding ? > > How can I use that new feature from java? I wouldn't be surprised if libvirt-java is still missing the

[libvirt] [PATCHv3 2b/9] qemu: Use qemuAliasFromDisk to generate drive alias

The qemuDomainSnapshotCreateSingleDiskActive open coded generating the disk drive alias. Let's use the common function. Signed-off-by: John Ferlan --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c

Re: [libvirt] [PATCH 2/5] Introduce SMM feature

Hi, > ... Gerd's above metadata change is dated 2016-03-21, at which point > both QEMU v2.4.0 and v2.5.0 had been tagged (on 2015-08-11 and on > 2015-12-16, respectively). I guess Gerd may have mis-remembered the > exact QEMU release which included SMM support? Either that, or because some of

[libvirt] [PATCHv3 2a/9] qemu: Remove generation of drive alias from qcow passphrase backends

Rather than pass the disks[i]->info.alias to qemuMonitorSetDrivePassphrase and then generate the "drive-%s" alias from that, let's use qemuAliasFromDisk prior to the call to generate the drive alias and then pass that along thus removing the need to generate the alias from the monitor code.

Re: [libvirt] [PATCH python 2/2] event-test: Add node device lifecycle event tests

On Thu, Jul 28, 2016 at 02:14 PM +0200, Jovanka Gulicoska wrote: > --- > examples/event-test.py | 16 > 1 file changed, 16 insertions(+) > > diff --git a/examples/event-test.py b/examples/event-test.py > index 1bcea07..e06ebc6 100755 > ---

[libvirt] [java binding] Retrieve VM IP address

After reading https://github.com/fog/fog-libvirt/pull/11, I realize it should possible to get ip address of a domain from java binding ? How can I use that new feature from java? Thanks. Regards, Fabien. -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH v2] qemu: remove panic dev models s390 and pseries when migrating

On 08/01/2016 11:57 AM, Ján Tomko wrote: On Thu, Jul 28, 2016 at 03:15:49PM +0200, Boris Fiuczynski wrote: The panic devices with models s390 and pseries are autogenerated. For backwards compatibility reasons the devices are to be removed when migrating. Signed-off-by: Boris Fiuczynski

Re: [libvirt] [PATCH v1 00/19] Implementation of QEMU vhost-scsi

On 08/01/2016 04:08 AM, Michal Privoznik wrote: On 25.07.2016 22:48, Eric Farman wrote: This patch series provides a libvirt implementation of the vhost-scsi interface in QEMU. As near as I can see, this was discussed upstream in July 2014[1], and ended in a desire to replace a vhost-scsi

Re: [libvirt] [PATCH v2 2/9] qemu: Move drive alias processing to qemu_alias

On 08/01/2016 04:39 AM, Ján Tomko wrote: > On Tue, Jul 19, 2016 at 10:30:45AM -0400, John Ferlan wrote: >> Move qemuDeviceDriveHostAlias from qemu_command and rename to >> qemuAssignDeviceDiskDriveAlias in qemu_alias. Also change the parameter >> to just be the disk->info.alias (e.g. srcalias)

Re: [libvirt] [PATCH v2 0/3] libxl hooks

On 07/28/2016 10:57 AM, Cédric Bosdonnat wrote: > Hey there! > > Diffs to v1: > * move the ret = 0 to the proper patch > * fix typos as pointed by Joao > * use ignore_value where needed > > Cédric Bosdonnat (3): > libxl: add a flag to mark guests as tainted by a hook > libxl: fix

[libvirt] [PATCH v2 2/3] virsh: qemu-monitor-command: Don't print extra newline with --pretty

The prettified JSON string already contains a newline so don't print another one. This allows to pipe the json output (in conjunction with the --quiet option) to files without having to truncate them afterwards. --- tools/virsh-domain.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [libvirt] [PATCH 2/3] virsh: qemu-monitor-command: Don't print extra newline with --pretty

On Mon, Aug 01, 2016 at 13:19:40 +0200, Peter Krempa wrote: > On Mon, Aug 01, 2016 at 12:40:31 +0200, Ján Tomko wrote: > > On Mon, Aug 01, 2016 at 06:30:07AM +0200, Peter Krempa wrote: > > >The prettified JSON string already contains a newline so don't print > > >another one. This allows to pipe

Re: [libvirt] [PATCH 2/3] virsh: qemu-monitor-command: Don't print extra newline with --pretty

On Mon, Aug 01, 2016 at 12:40:31 +0200, Ján Tomko wrote: > On Mon, Aug 01, 2016 at 06:30:07AM +0200, Peter Krempa wrote: > >The prettified JSON string already contains a newline so don't print > >another one. This allows to pipe the json output (in conjunction with > >the --quiet option) to files

Re: [libvirt] [PATCH 3/3] virsh: qemu-monitor-command: Simplify control flow

On Mon, Aug 01, 2016 at 06:30:08AM +0200, Peter Krempa wrote: Construct the query string by using virBufferTrim rather than having to remember to add a space and simplify cleanup path. --- tools/virsh-domain.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) ACK Jan

Re: [libvirt] [PATCH 2/3] virsh: qemu-monitor-command: Don't print extra newline with --pretty

On Mon, Aug 01, 2016 at 06:30:07AM +0200, Peter Krempa wrote: The prettified JSON string already contains a newline so don't print another one. This allows to pipe the json output (in conjunction with the --quiet option) to files without having to truncate them afterwards. ---

Re: [libvirt] [PATCH 1/3] virsh: qemu-monitor-command: Use macro for exclusive options

On Mon, Aug 01, 2016 at 06:30:06AM +0200, Peter Krempa wrote: --- tools/virsh-domain.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) ACK Jan -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-glib][PATCH 1/2] configure: Detect python in compatible fashion

On Mon, Aug 01, 2016 at 11:47:42AM +0200, Michal Privoznik wrote: > In the configure script we try to detect what version of python > is there currently installed on the system. We use `python -c > "some cmd"` to find out. However, the syntax we use for "some > cmd" is plainly just for 2.x and

Re: [libvirt] [libvirt-glib][PATCH 2/2] python: Introduce support for python3

On Mon, Aug 01, 2016 at 11:47:43AM +0200, Michal Privoznik wrote: Just like libvirt itself is able to work with both major version of python, libvirt-glib should do the same. Even the code I'm introducing here is copied from there (and changed slightly to reflect project name). Signed-off-by:

Re: [libvirt] [PATCH 0/2] a couple of schema fixes

On Wed, Jul 20, 2016 at 03:11:44PM +0300, Nikolay Shirokovskiy wrote: Nikolay Shirokovskiy (2): schema: add missed alias element to memory device schema: fix resolved interfaces of network type docs/schemas/domaincommon.rng | 43 +-

Re: [libvirt] [PATCH v2] qemu: remove panic dev models s390 and pseries when migrating

On Thu, Jul 28, 2016 at 03:15:49PM +0200, Boris Fiuczynski wrote: The panic devices with models s390 and pseries are autogenerated. For backwards compatibility reasons the devices are to be removed when migrating. Signed-off-by: Boris Fiuczynski ---

[libvirt] [libvirt-glib][PATCH 1/2] configure: Detect python in compatible fashion

In the configure script we try to detect what version of python is there currently installed on the system. We use `python -c "some cmd"` to find out. However, the syntax we use for "some cmd" is plainly just for 2.x and throws an error for 3.x. Signed-off-by: Michal Privoznik

[libvirt] [libvirt-glib][PATCH 2/2] python: Introduce support for python3

Just like libvirt itself is able to work with both major version of python, libvirt-glib should do the same. Even the code I'm introducing here is copied from there (and changed slightly to reflect project name). Signed-off-by: Michal Privoznik --- python/libvirt-glib.c |

[libvirt] [libvirt-glib][PATCH 0/2] Support python3

/usr/bin/python defaults to python3 on my system. While trying to build libvirt-glib I've noticed some errors in configure (first patch), and some missing implementation (second patch). Michal Privoznik (2): configure: Detect python in compatible fashion python: Introduce support for python3

Re: [libvirt] [PATCH v2] qemu: fix domain id after domainCreateWithFlags()

On Wed, Jul 27, 2016 at 04:05:20PM +0200, Sascha Silbe wrote: Ever since virDomainCreateWithFlags() was introduced by de3aadaa [drivers: add virDomainCreateWithFlags if virDomainCreate exists], the domain ID retrieved with virDomainGetID() was incorrect for several drivers after

Re: [libvirt] [PATCH] admin: Fix the default uri for session daemon to libvirtd:///session

On Fri, Jul 29, 2016 at 03:40:28PM +0200, Michal Privoznik wrote: On 29.07.2016 14:08, Daniel P. Berrange wrote: On Fri, Jul 29, 2016 at 02:06:00PM +0200, Erik Skultety wrote: Just like we decide on which URI we go with based on EUID for qemu in remote driver, do a similar thing for admin

Re: [libvirt] [PATCH v2 4/9] qemu: Make QEMU_DRIVE_HOST_PREFIX more private

On Tue, Jul 19, 2016 at 10:30:47AM -0400, John Ferlan wrote: Move QEMU_DRIVE_HOST_PREFIX into the qemu_alias.c to disuade future s/disuade/dissuade/ disuade is the Spanish spelling. I know that because I had to look it up in the dictionary anyway. callers from using it. Create

Re: [libvirt] [PATCH] wireshark: Drop glib dependency

On Mon, Aug 01, 2016 at 10:25:09AM +0200, Michal Privoznik wrote: > The only function that we currently use from glib is g_sprintf(). > That's a very big gun for such small target. Not only that, but > we've silently relied on wireshark dragging in the glib. Replace > the g_sprintf() with plain

Re: [libvirt] Question about LSN-2016-0001

On Fri, Jul 29, 2016 at 02:16:16PM -0600, Jim Fehlig wrote: > I've noticed the behavior described by this LSN with libvirt+Xen. Config > containing allows any client to > connect with no authentication check. I asked about this on the Xen security > list and was told that "libxl interprets an

Re: [libvirt] [PATCH v2 0/9] Various hotplug cleanups

On Tue, Jul 19, 2016 at 10:30:43AM -0400, John Ferlan wrote: v1: http://www.redhat.com/archives/libvir-list/2016-June/msg02207.html Changes since v1... - Use the bz noted by Cole from the v1 series - Merged in recent hotplug cleanup changes - Patches 6 - 9 are new Resolves:

Re: [libvirt] [PATCH v2 3/9] qemu: Use qemuAssignDeviceDiskDriveAlias

On Tue, Jul 19, 2016 at 10:30:46AM -0400, John Ferlan wrote: Rather than open code build the drive alias command in multiple places, use the helper to ensure consistency. Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 12 ++-- src/qemu/qemu_driver.c

Re: [libvirt] [PATCH v2 6/9] qemu: Add attempt to call qemuMonitorDriveDel for AttachSCSI failure path

On Tue, Jul 19, 2016 at 10:30:49AM -0400, John Ferlan wrote: Completion of fix for: https://bugzilla.redhat.com/show_bug.cgi?id=1336225 Similar to the other disk types, add the qemuMonitorDriveDel in the failure to add/hotplug a SCSI disk. Signed-off-by: John Ferlan ---

Re: [libvirt] [PATCH v2 2/9] qemu: Move drive alias processing to qemu_alias

On Tue, Jul 19, 2016 at 10:30:45AM -0400, John Ferlan wrote: Move qemuDeviceDriveHostAlias from qemu_command and rename to qemuAssignDeviceDiskDriveAlias in qemu_alias. Also change the parameter to just be the disk->info.alias (e.g. srcalias) Includes some innocent bystanders that seem to need

Re: [libvirt] [PATCH] tests: qemu: Don't leak security manager object

On 01.08.2016 06:46, Peter Krempa wrote: > ==2064442== 200 (88 direct, 112 indirect) bytes in 1 blocks are definitely > lost in loss record 54 of 73 > ==2064442==at 0x4C2E0F0: calloc (vg_replace_malloc.c:711) > ==2064442==by 0x18E75B80: virAllocVar (viralloc.c:560) > ==2064442==by

Re: [libvirt] [PATCH] wireshark dissector compile fix

On 29.07.2016 18:28, Benedikt Spranger wrote: > Am Fri, 29 Jul 2016 12:27:16 +0100 > schrieb "Daniel P. Berrange" : > >> On Fri, Jul 29, 2016 at 12:43:41PM +0200, Benedikt Spranger wrote: >>> Compiling libvirt wireshark dissector on a debian based system >>> failed: CC >>>

[libvirt] [PATCH] wireshark: Drop glib dependency

The only function that we currently use from glib is g_sprintf(). That's a very big gun for such small target. Not only that, but we've silently relied on wireshark dragging in the glib. Replace the g_sprintf() with plain sprinf() so that we can drop the glib dependency. Signed-off-by: Michal

Re: [libvirt] [PATCH v1 00/19] Implementation of QEMU vhost-scsi

On 25.07.2016 22:48, Eric Farman wrote: > This patch series provides a libvirt implementation of the vhost-scsi > interface in QEMU. As near as I can see, this was discussed upstream in > July 2014[1], and ended in a desire to replace a vhost-scsi controller > in favor of a hostdev element

Re: [libvirt] [PATCH] spec: Require perl-XML-XPath during build

On 25.07.2016 13:14, Martin Kletzander wrote: > Some time ago I went through the trouble to make support for perl module > requirements in our bootstrap. Even though we require it in the > bootstrap, it was not listed as a build requirement in the specfile. > > Signed-off-by: Martin Kletzander

Re: [libvirt] [PATCH 0/2] qemu: caps: Sanitize storage of machine type related data

On Fri, Jul 29, 2016 at 10:17:19AM +0200, Peter Krempa wrote: Peter Krempa (2): qemu: capabilities: Drop unused function virQEMUCapsGetMachineTypes qemu: caps: Sanitize storage of machine type related data src/qemu/qemu_capabilities.c | 125 ---

Re: [libvirt] [PATCH 3/2] qemu: cap: Refactor access to array in virQEMUCapsProbeQMPMachineTypes

On Fri, Jul 29, 2016 at 10:40:57AM +0200, Peter Krempa wrote: Use a temporary pointer rather than always recalculating the index in a very verbose way. --- src/qemu/qemu_capabilities.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git

Re: [libvirt] [PATCH] virsh: Report error when explicit connection fails

On Fri, Jul 29, 2016 at 08:17:42AM +0200, Martin Kletzander wrote: Commit 0c56d9431839 forgot to return false in the cmdConnect command after the clean up made there. Before (assuming you don't have uri alias for 'asdf'): $ virsh connect asdf error: failed to connect to the hypervisor $