Re: [libvirt] [Qemu-devel] [PATCH v4 01/11] tests: Add test case for x86 feature parsing compatibility

On 30/09/2016 20:33, Eduardo Habkost wrote: > On Fri, Sep 30, 2016 at 09:55:33AM +0200, Paolo Bonzini wrote: >> >> >> On 29/09/2016 23:14, Eduardo Habkost wrote: >>> + * "-foo" overrides "+foo" >>> + * "[+-]foo" overrides "foo=..." >> >> Is this something that people are actually using?

Re: [libvirt] [PATCH v5 04/12] target-i386: Register aliases for feature names with underscores

On Fri, Sep 30, 2016 at 02:56:42PM -0500, Eric Blake wrote: > On 09/30/2016 01:49 PM, Eduardo Habkost wrote: > > Registering the actual names containing underscores as aliases > > will allow management software to be aware that the old > > compatibility names are suported, and will make

Re: [libvirt] [PATCH v5 04/12] target-i386: Register aliases for feature names with underscores

On 09/30/2016 01:49 PM, Eduardo Habkost wrote: > Registering the actual names containing underscores as aliases > will allow management software to be aware that the old > compatibility names are suported, and will make feat2prop() calls s/suported/supported/ > unnecessary when using feature

[libvirt] [PATCH v5 09/12] target-i386: Move warning code outside x86_cpu_filter_features()

x86_cpu_filter_features() will be reused by code that shouldn't print any warning. Move the warning code to a new x86_cpu_report_filtered_features() function, and call it from x86_cpu_realizefn(). Signed-off-by: Eduardo Habkost --- Changes v3 -> v4: * Made

[libvirt] [PATCH v5 04/12] target-i386: Register aliases for feature names with underscores

Registering the actual names containing underscores as aliases will allow management software to be aware that the old compatibility names are suported, and will make feat2prop() calls unnecessary when using feature names. Also, this will help us avoid making the code support underscores on

[libvirt] [PATCH v5 05/12] target-i386: Make plus_features/minus_features QOM-based

Instead of using custom feature name lookup code for plus_features/minus_features, save the property names used in "[+-]feature" and use object_property_set_bool() to set them. We don't need a feat2prop() call because we now have alias properties for the old names containing underscores.

[libvirt] [PATCH v5 11/12] qmp: Add runnability information to query-cpu-definitions

Add a new optional field to query-cpu-definitions schema: "unavailable-features". It will contain a list of QOM properties that prevent the CPU model from running in the current host. Cc: David Hildenbrand Cc: Michael Mueller Cc: Christian

[libvirt] [PATCH v5 08/12] target-i386: xsave: Add FP and SSE bits to x86_ext_save_areas

Instead of treating the FP and SSE bits as special cases, add them to the x86_ext_save_areas array. This will simplify the code that calculates the supported xsave components and the size of the xsave area. Signed-off-by: Eduardo Habkost --- Changes series v3 -> v4: * New

[libvirt] [PATCH v5 07/12] target-i386: Register properties for feature aliases manually

Instead of keeping the aliases inside the feature name arrays and require parsing the strings, just register alias properties manually. This simplifies the code for property registration and lookup. Signed-off-by: Eduardo Habkost --- Changes v4 -> v5: * Refresh after the

[libvirt] [PATCH v5 03/12] target-i386: Disable VME by default with TCG

VME is already disabled automatically when using TCG. So, instead of pretending it is there when reporting CPU model data on query-cpu-* QMP commands (making every CPU model to be reported as not runnable), we can disable it by default on all CPU models when using TCG. Do that by adding a

[libvirt] [PATCH v5 10/12] target-i386: x86_cpu_load_features() function

When probing for CPU model information, we need to reuse the code that initializes CPUID fields, but not the remaining side-effects of x86_cpu_realizefn(). Move that code to a separate function that can be reused later. Signed-off-by: Eduardo Habkost --- Changes v4 -> v5: *

[libvirt] [PATCH v5 12/12] target-i386: Return runnability information on query-cpu-definitions

Fill the "unavailable-features" field on the x86 implementation of query-cpu-definitions. Cc: Jiri Denemark Cc: libvir-list@redhat.com Signed-off-by: Eduardo Habkost --- Changes v3 -> v4: * Handle missing XSAVE components cleanly, but looking up the

[libvirt] [PATCH v5 02/12] target-i386: List CPU models using subclass list

Instead of using the builtin_x86_defs array, use the QOM subclass list to list CPU models on "-cpu ?" and "query-cpu-definitions". Signed-off-by: Andreas Färber [ehabkost: copied code from a patch by Andreas: "target-i386: QOM'ify CPU", from March 2012] Signed-off-by: Eduardo

[libvirt] [PATCH v5 00/12] Add runnability info to query-cpu-definitions

This series extends query-cpu-definitions to include an extra field: "unavailable-features". The new field can be used to find out reasons that prevent the CPU model from running in the current host. This will return information based on the current machine and accelerator only. In the future we

[libvirt] [PATCH v5 06/12] target-i386: Remove underscores from feat_names arrays

Instead of translating the feature name entries when adding property names, store the actual property names in the feature name array. For reference, here is the full list of functions that use FeatureWordInfo::feat_names: * x86_cpu_get_migratable_flags(): not affected, as it just check for

[libvirt] [PATCH v5 01/12] tests: Add test case for x86 feature parsing compatibility

Add a new test case to ensure the existing behavior of the feature parsing code will be kept. Signed-off-by: Eduardo Habkost --- Changes series v4 -> v5: * Fix typo on commit message Reported-by: Jonathan Neuschäfer * Add comment noting that the

[libvirt] [PATCH v2 08.5/12] qemu: Create a set of macros to handle setting block iotune values

Rework the code to create a couple of macros to hide all the comparisons for each of the 6 "types" of data fields to collect. Each macro will check the base name, then the base name + "_max", and base name + "_max_length". Signed-off-by: John Ferlan --- "Formalized" patch

[libvirt] [PATCH v2 4/5] qemu: Split out filling of JSONDiskNameLookup data

Create a helper function which will do the primary work required to find the specific device and get the disk name. Done in preparation for some more code reuse. Add new elements to _qemuMonitorJSONQueryBlockArgs in order to handle the lookup of just one specific device from the query-block code.

[libvirt] [PATCH v2 5/5] qemu: Combine the various ways to call query-block

Now that each of the 3 callers to "query-block" has relatively the same flow, combine the remaining flow into qemuMonitorJSONQueryBlock and of course rework the function comments to describe the expectations. The qemuMonitorJSONQueryBlock will now take multiple parameters and call the helper that

[libvirt] [PATCH v2 3/5] qemu: Split out filling of JSONBlockStats data

Create a helper function which will read the device data and fill in a hash table entry with that data. In preparation for some more code reuse. Add the backingChain argument to the args structure. Signed-off-by: John Ferlan --- src/qemu/qemu_monitor_json.c | 40

[libvirt] [PATCH v2 1/5] qemu: Create common code for JSON "query-block" call

Reduce some cut-n-paste code by creating common helper NB: This also adds error checking to qemuMonitorJSONDiskNameLookup Signed-off-by: John Ferlan --- src/qemu/qemu_monitor_json.c | 63 1 file changed, 34 insertions(+), 29

[libvirt] [PATCH v2 0/5] Combine various query-block json call paths

v1: http://www.redhat.com/archives/libvir-list/2016-September/msg01446.html NOTE: Patch 1 already ACK'd Patches 2-4 adjusted slightly to not create/use qemuMonitorJSONQueryBlockArgs instead opting to pass all the args (also shortened helper names slightly). Patch 5 adjusted to receive all args

[libvirt] [PATCH v2 2/5] qemu: Split out filling of JSONGetBlockInfo data

Create a helper function which will read the device data and fill in a hash table entry with that data. In preparation for some more code reuse. The helper function will take as an argument a new local static structure in order to define the arguments. This will make it possible to combine more

Re: [libvirt] [Qemu-devel] [PATCH v4 01/11] tests: Add test case for x86 feature parsing compatibility

On Fri, Sep 30, 2016 at 09:55:33AM +0200, Paolo Bonzini wrote: > > > On 29/09/2016 23:14, Eduardo Habkost wrote: > > + * "-foo" overrides "+foo" > > + * "[+-]foo" overrides "foo=..." > > Is this something that people are actually using? Can we detect it and > deprecate it in 2.8, and

[libvirt] [PATCH 06/11] qemu_capabilities: rename QEMU_CAPS_VIRTIO_GPU_VIRGL

We usually uses QEMU_CASP_DEVICE_$NAME to probe for existence of some device and QEMU_CAPS_$NAME_$PROP to probe for existence of some property of that device. This also remove wrong assumption for QEMU_CAPS_DEVICE_VIRTIO_GPU that it's also 'virtio-vga' which isn't true. Signed-off-by: Pavel

[libvirt] [PATCH 10/11] qemu_command: properly detect which model to use for video device

This improves commit 706b5b6277 in a way that we instead use qemu capabilities to detect whether we can use virto-vga or not. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_command.c| 4 +-- src/qemu/qemu_domain.c | 12

[libvirt] [PATCH 04/11] qemu_domain: move video validation out of qemu_command

All definition validation that don't depend on qemu capabilities and was allowed previously as valid definition should be placed into qemuDomainDefValidate. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_command.c| 58 --

[libvirt] [PATCH 02/11] qemu_capabilities: join capabilities for qxl and qxl-vga devices

This patch simplifies QEMU capabilities for QXL video device. QEMU exposes this device as *qxl-vga* and *qxl* and they are both the same device with the same set of parameters, the only difference is that *qxl-vga* includes VGA compatibility. Based on QEMU code they are tied together so it's

[libvirt] [PATCH 11/11] qemu_command: add support to use virtio as secondary video device

Signed-off-by: Pavel Hrdina --- docs/formatdomain.html.in | 3 +- src/qemu/qemu_command.c| 32 --- src/qemu/qemu_domain.c | 3 +- .../qemuxml2argv-video-virtio-gpu-sec.args

[libvirt] [PATCH 00/11] cleanups and improvements for video device code

Pavel Hrdina (11): tests: fix some QXL capability combinations that doesn't make sense qemu_capabilities: join capabilities for qxl and qxl-vga devices qemu_capabilities: mark QEMU_CAPS_VGA_QXL capability as deprecated qemu_domain: move video validation out of qemu_command qemu_process:

[libvirt] [PATCH 07/11] qemu_command: separate code for video device via -vga attribute

Signed-off-by: Pavel Hrdina --- src/qemu/qemu_command.c | 140 ++-- 1 file changed, 76 insertions(+), 64 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index d283c67..aef8c79 100644 ---

[libvirt] [PATCH 09/11] qemu_capabilities: check for existence of virtio-vga

Commit 21373feb added support for primary virtio-vga device but it was checking for virtio-gpu. Let's check for existence of virtio-vga if we want to use it. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_capabilities.c | 2 ++

[libvirt] [PATCH 08/11] qemu_command: cleanup qemuBuildVideoCommandLine

Signed-off-by: Pavel Hrdina --- src/qemu/qemu_command.c | 69 - 1 file changed, 40 insertions(+), 29 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index aef8c79..15bb381 100644 ---

[libvirt] [PATCH 05/11] qemu_process: move video validation out of qemu_command

Runtime validation that depend on qemu capabilities should be moved into qemuProcessStartValidateXML. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_command.c | 33 +--- src/qemu/qemu_process.c | 50 ++- tests/qemuxml2argvtest.c |

[libvirt] [PATCH 03/11] qemu_capabilities: mark QEMU_CAPS_VGA_QXL capability as deprecated

If QEMU in question supports QMP, this capability is set if QEMU_CAPS_DEVICE_QXL was set based on existence of "-device qxl". If libvirt needs to parse *help*, because there is no QMP support, it checks for existence of "-vga qxl", but it also parses output of "-device ?" and sets

[libvirt] [PATCH 01/11] tests: fix some QXL capability combinations that doesn't make sense

If one of QEMU_CAPS_DEVICE_QXL_VGA or QEMU_CAPS_DEVICE_QXL is set the other one will always be set as well because both devices are tied together in QEMU. The change of args files is caused by the presence of capability QEMU_CAPS_DEVICE_VIDEO_PRIMARY which means it's safe to use "-device qxl-vga"

[libvirt] [PATCH v2 1/2] NSS: Add explicit check to not report expired lease

The NSS module shouldn't rely on custom leases database to not have entries for leases which have expired. Change-Id: Ic3e043003d33ded0da74696a1d27ed4967ddbfb8 --- tools/nss/libvirt_nss.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/tools/nss/libvirt_nss.c

[libvirt] [PATCH v2 2/2] Don't drop expired lease while reading custom leases file

Libvirt, on its own, shouldn't decide whether an expired lease should stay in the custom leases database or not. It should rather rely on the 'DEL' event from dnsmasq. --- src/util/virlease.c | 8 1 file changed, 8 deletions(-) diff --git a/src/util/virlease.c b/src/util/virlease.c

Re: [libvirt] Malicious guests and entropy pool access risks

On 29.09.2016 22:43, ban...@openmailbox.org wrote: > Hello. While I've been enabling virtio-rng since it became available I > recently understood that without restrictions a malicious guest can > potentially starve other VMs' entropy by overusing /dev/random so I set > the rate limit. > > Another

Re: [libvirt] [PATCH 0/5] Combine various query-block json call paths

On 09/30/2016 09:25 AM, Peter Krempa wrote: > On Fri, Sep 30, 2016 at 08:53:49 -0400, John Ferlan wrote: >> Based off a recent review and discussion regarding adding a new field >> to qemuDomainDiskInfo: >> >> http://www.redhat.com/archives/libvir-list/2016-September/msg00193.html >> >> I

Re: [libvirt] [PATCH v5 0/2] qemu/gluster: add option for tuning debug logging level

On Thu, Sep 29, 2016 at 7:49 PM, Peter Krempa wrote: > > On Thu, Sep 22, 2016 at 01:04:17 +0530, Prasanna Kumar Kalever wrote: > > This series run basic sanity and other tests: > > 1. make syntax-check > > 2. make check > > 3. VIR_TEST_VERBOSE=1 ./tests/qemuargv2xmltest > > 4.

Re: [libvirt] [PATCH 3/3] introduce pull backup

On 30.09.2016 14:35, Kashyap Chamarthy wrote: > On Thu, Sep 29, 2016 at 06:02:08PM -0400, John Ferlan wrote: > > [...] > Because it's also dependent upon an x-blockdev-del, it cannot be pushed upstream to libvirt. I know qemu work continues w/r/t blockdev-add and backups, but I

Re: [libvirt] [PATCH 3/3] introduce pull backup

On 30.09.2016 01:02, John Ferlan wrote: > > > [...] > >>> >>> Because it's also dependent upon an x-blockdev-del, it cannot be pushed >>> upstream to libvirt. I know qemu work continues w/r/t blockdev-add and >>> backups, but I don't follow it in detail (not enough time in the day!). >> >>

Re: [libvirt] ruby-libvirt latest release doesn't work with fog-libvirt

On 19 September 2016 at 15:06, Chris Lalancette wrote: > Eek. I just haven't had time to do it. I'll see if I can get a release > out this week. Sorry about that. > > Chris Lalancette > No worries, I figured it was a case that someone forgot to follow up with a

Re: [libvirt] Cpu Modeling

On Fri, Sep 30, 2016 at 09:00:15AM +0200, Jiri Denemark wrote: > On Thu, Sep 29, 2016 at 15:51:58 -0300, Eduardo Habkost wrote: > > On Thu, Sep 29, 2016 at 04:21:07PM +0200, Jiri Denemark wrote: > > [...] > > > > > Slightly related, I don't think we have a way to list CPU features > > > > >

Re: [libvirt] [PATCH 2/3] qemu: special error code in case of no job on cancel block job

On 30.09.2016 00:11, John Ferlan wrote: > > > On 09/27/2016 05:06 AM, Nikolay Shirokovskiy wrote: >> >> >> On 26.09.2016 23:07, John Ferlan wrote: >>> >>> >>> On 09/07/2016 05:24 AM, Nikolay Shirokovskiy wrote: Special error code helps gracefully handle race conditions on blockjob

Re: [libvirt] [PATCH v4 05/11] target-i386: Remove underscores from property names

On Fri, Sep 30, 2016 at 09:29:58AM +0200, Jiri Denemark wrote: > On Thu, Sep 29, 2016 at 18:14:53 -0300, Eduardo Habkost wrote: > > Instead of translating the feature name entries when adding > > property names, store the actual property names in the feature > > name array. > > > > Signed-off-by:

Re: [libvirt] [PATCH v4 11/11] target-i386: Return runnability information on query-cpu-definitions

On Fri, Sep 30, 2016 at 10:02:49AM +0200, Paolo Bonzini wrote: > On 29/09/2016 23:14, Eduardo Habkost wrote: > > +/* Return the feature property name for a feature flag bit */ > > +static const char *x86_cpu_feature_name(FeatureWord w, int bitnr) > > +{ > > +/* XSAVE components are

Re: [libvirt] [PATCH 1/3] qemu: store guest visible disk size from qemu monitor block info

On 29.09.2016 23:51, John Ferlan wrote: > >> >>> a lot of exposure to that code. I do know there's still upstream qemu >>> work taking place. We really should be very careful about adding >>> anything to libvirt before the upstream work is done. In particular any >>> x-* command support. >>> >>

Re: [libvirt] Entering freeze for libvirt-2.3.0

On Fri, Sep 30, 2016 at 11:37:08AM +0200, Guido Günther wrote: > On Tue, Sep 27, 2016 at 10:14:36PM +0200, Daniel Veillard wrote: > > Since nobody complained about my earlier message with the release plan, > > I tagged libvirt-2.3.0 candidate release 1 in git and pushed signed tarball > > and

Re: [libvirt] [PATCH 1/5] qemu: Create common code for JSON "query-block" call

On Fri, Sep 30, 2016 at 08:53:50 -0400, John Ferlan wrote: > Reduce some cut-n-paste code by creating common helper > > NB: This also adds error checking to qemuMonitorJSONDiskNameLookup > Signed-off-by: John Ferlan > --- > src/qemu/qemu_monitor_json.c | 63 >

Re: [libvirt] [PATCH 0/5] Combine various query-block json call paths

On Fri, Sep 30, 2016 at 08:53:49 -0400, John Ferlan wrote: > Based off a recent review and discussion regarding adding a new field > to qemuDomainDiskInfo: > > http://www.redhat.com/archives/libvir-list/2016-September/msg00193.html > > I decided to take the plunge and rework the query-block code

Re: [libvirt] [PATCH] Don't drop expired lease while reading custom leases file

On 30.09.2016 14:22, Nehal J Wani wrote: > On Fri, Sep 30, 2016 at 5:47 PM, Michal Privoznik wrote: >> On 28.09.2016 21:39, Nehal J Wani wrote: >>> Libvirt, on its own, shouldn't decide whether an expired lease should >>> stay in the custom leases database or not. It should

Re: [libvirt] [PATCH] NSS: Add explicit check to not report expired lease

On 28.09.2016 21:38, Nehal J Wani wrote: > The NSS module shouldn't rely on custom leases database to not have > entries for leases which have expired. > --- > tools/nss/libvirt_nss.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/tools/nss/libvirt_nss.c

[libvirt] [PATCH 2/5] qemu: Split out filling of JSONGetBlockInfo data

Create a helper function which will read the device data and fill in a hash table entry with that data. In preparation for some more code reuse. The helper function will take as an argument a new local static structure in order to define the arguments. This will make it possible to combine more

[libvirt] [PATCH 4/5] qemu: Split out filling of JSONDiskNameLookup data

Create a helper function which will do the primary work required to find the specific device and get the disk name. Done in preparation for some more code reuse. Add new elements to _qemuMonitorJSONQueryBlockArgs in order to handle the lookup of just one specific device from the query-block code.

[libvirt] [PATCH 1/5] qemu: Create common code for JSON "query-block" call

Reduce some cut-n-paste code by creating common helper NB: This also adds error checking to qemuMonitorJSONDiskNameLookup Signed-off-by: John Ferlan --- src/qemu/qemu_monitor_json.c | 63 1 file changed, 34 insertions(+), 29

[libvirt] [PATCH 0/5] Combine various query-block json call paths

Based off a recent review and discussion regarding adding a new field to qemuDomainDiskInfo: http://www.redhat.com/archives/libvir-list/2016-September/msg00193.html I decided to take the plunge and rework the query-block code in order to combine the various ways callers return the data and well

[libvirt] [PATCH 5/5] qemu: Combine the various ways to call query-block

Now that each of the 3 callers to "query-block" has relatively the same flow, combine the remaining flow into qemuMonitorJSONQueryBlock and of course rework the function comments to describe the expectations. The qemuMonitorJSONQueryBlock will now take multiple parameters, "blindly" building up

[libvirt] [PATCH 3/5] qemu: Split out filling of JSONBlockStats data

Create a helper function which will read the device data and fill in a hash table entry with that data. In preparation for some more code reuse. Add the backingChain argument to the args structure. Signed-off-by: John Ferlan --- src/qemu/qemu_monitor_json.c | 47

Re: [libvirt] [PATCH] Don't drop expired lease while reading custom leases file

On Fri, Sep 30, 2016 at 5:47 PM, Michal Privoznik wrote: > On 28.09.2016 21:39, Nehal J Wani wrote: >> Libvirt, on its own, shouldn't decide whether an expired lease should >> stay in the custom leases database or not. It should rather rely on >> the 'DEL' event from dnsmasq.

Re: [libvirt] [PATCH] Don't drop expired lease while reading custom leases file

On 28.09.2016 21:39, Nehal J Wani wrote: > Libvirt, on its own, shouldn't decide whether an expired lease should > stay in the custom leases database or not. It should rather rely on > the 'DEL' event from dnsmasq. > --- > src/util/virlease.c | 8 > 1 file changed, 8 deletions(-) > >

Re: [libvirt] [PATCH v2]Pre-assign memory modules slot number and assign alias.

On Thu, Sep 29, 2016 at 22:52:46 +0530, Nitesh Konkar wrote: > Find the smallest missing slot number and > pre-assign slot numbers and assign aliases > of memory modules. This keeps the slot number > consistent with the alias. > > Signed-off-by: Nitesh Konkar > --- >

Re: [libvirt] [PATCH 08.5/12] qemu: Create a set of macros to handle setting block iotune values

On 09/30/2016 07:08 AM, Erik Skultety wrote: > On 30/09/16 12:57, John Ferlan wrote: >> >> >> On 09/30/2016 04:43 AM, Erik Skultety wrote: >>> On 28/09/16 22:27, John Ferlan wrote: Rework the code in a set of 3 macros that will use the "base" of 'bytes' or 'iops' and build up the

Re: [libvirt] [PATCH 3/3] introduce pull backup

On Thu, Sep 29, 2016 at 06:02:08PM -0400, John Ferlan wrote: [...] > >> Because it's also dependent upon an x-blockdev-del, it cannot be pushed > >> upstream to libvirt. I know qemu work continues w/r/t blockdev-add and > >> backups, but I don't follow it in detail (not enough time in the day!).

Re: [libvirt] [PATCH] Fix Typo.

I think I will group all such fixes in 1 patch and send it. Thanks! On Fri, Sep 30, 2016 at 2:18 AM, Nitesh Konkar < niteshkonkar.libv...@gmail.com> wrote: > Signed-off-by: Nitesh Konkar > --- > src/libvirt-nodedev.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [libvirt] [PATCH 08.5/12] qemu: Create a set of macros to handle setting block iotune values

On 30/09/16 12:57, John Ferlan wrote: > > > On 09/30/2016 04:43 AM, Erik Skultety wrote: >> On 28/09/16 22:27, John Ferlan wrote: >>> Rework the code in a set of 3 macros that will use the "base" of >>> 'bytes' or 'iops' and build up the prefixes of 'total_', 'read_', >>> and 'write_' before

Re: [libvirt] [PATCH 08.5/12] qemu: Create a set of macros to handle setting block iotune values

On 09/30/2016 04:43 AM, Erik Skultety wrote: > On 28/09/16 22:27, John Ferlan wrote: >> Rework the code in a set of 3 macros that will use the "base" of >> 'bytes' or 'iops' and build up the prefixes of 'total_', 'read_', >> and 'write_' before adding the postfixes of '_sec', '_sec_max', >> and

Re: [libvirt] Entering freeze for libvirt-2.3.0

On Tue, Sep 27, 2016 at 10:14:36PM +0200, Daniel Veillard wrote: > Since nobody complained about my earlier message with the release plan, > I tagged libvirt-2.3.0 candidate release 1 in git and pushed signed tarball > and rpms to the usual place: > >ftp://libvirt.org/libvirt/ > > As

Re: [libvirt] [PATCH 08.5/12] qemu: Create a set of macros to handle setting block iotune values

On 28/09/16 22:27, John Ferlan wrote: > Rework the code in a set of 3 macros that will use the "base" of > 'bytes' or 'iops' and build up the prefixes of 'total_', 'read_', > and 'write_' before adding the postfixes of '_sec', '_sec_max', > and '_sec_max_length' and making the param->field

Re: [libvirt] [PATCH 7/7] qemu: Allow making vcpus hotpluggable with virDomainSetVcpusFlags

On Wed, Sep 21, 2016 at 01:49:59PM +0200, Peter Krempa wrote: > Implement support for VIR_DOMAIN_VCPU_HOTPLUGGABLE so that users can > choose to make vcpus added by the API removable. > --- ACK Pavel signature.asc Description: Digital signature -- libvir-list mailing list

Re: [libvirt] [PATCH 6/7] lib: Introduce VIR_DOMAIN_VCPU_HOTPLUGGABLE for virDomainSetVcpusFlags

On Wed, Sep 21, 2016 at 01:49:58PM +0200, Peter Krempa wrote: > For compatibility reasons virDomainSetVcpus needs to add vcpus as non > hotpluggable which means that the users whill not be able to unplug it s/whill/will/ > after the VM has started. Add a flag that will allow to tell the API >

Re: [libvirt] [PATCH v4 01/11] tests: Add test case for x86 feature parsing compatibility

On Fri, Sep 30, 2016 at 09:55:33 +0200, Paolo Bonzini wrote: > > > On 29/09/2016 23:14, Eduardo Habkost wrote: > > + * "-foo" overrides "+foo" > > + * "[+-]foo" overrides "foo=..." > > Is this something that people are actually using? Can we detect it and > deprecate it in 2.8, and

Re: [libvirt] [PATCH v4 11/11] target-i386: Return runnability information on query-cpu-definitions

On 29/09/2016 23:14, Eduardo Habkost wrote: > +/* Return the feature property name for a feature flag bit */ > +static const char *x86_cpu_feature_name(FeatureWord w, int bitnr) > +{ > +/* XSAVE components are automatically enabled by other features, > + * so return the original feature

Re: [libvirt] [PATCH v4 09/11] target-i386: x86_cpu_load_features() function

On 29/09/2016 23:14, Eduardo Habkost wrote: > +/* Load CPUID data based on configureured features > + */ Typo ("configureured") and also unnecessarily breaking the comment on two lines. Paolo > +static void x86_cpu_load_features(X86CPU *cpu, Error **errp) -- libvir-list mailing list

Re: [libvirt] [PATCH 4/7] qemu: Fix coldplug of vcpus

On Fri, Sep 30, 2016 at 09:52:08 +0200, Pavel Hrdina wrote: > On Wed, Sep 21, 2016 at 01:49:56PM +0200, Peter Krempa wrote: > > virDomainDefSetVcpus was not designed to handle coldplug of vcpus now > > that we can set state of vcpus individually. > > > > Introduce qemuDomainSetVcpusConfig that

Re: [libvirt] [PATCH 5/7] qemu: vcpu: Clear vcpu order information rather than making it invalid

On Wed, Sep 21, 2016 at 01:49:57PM +0200, Peter Krempa wrote: > Certain operations may make the vcpu order information invalid. Since > the order is primarily used to ensure migration compatibility and has > basically no other user benefits, clear the order prior to certain > operations and

Re: [libvirt] [PATCH v4 01/11] tests: Add test case for x86 feature parsing compatibility

On 29/09/2016 23:14, Eduardo Habkost wrote: > + * "-foo" overrides "+foo" > + * "[+-]foo" overrides "foo=..." Is this something that people are actually using? Can we detect it and deprecate it in 2.8, and drop it in 2.9? Paolo > + * "foo_bar" should be translated to "foo-bar"

Re: [libvirt] [PATCH 4/7] qemu: Fix coldplug of vcpus

On Wed, Sep 21, 2016 at 01:49:56PM +0200, Peter Krempa wrote: > virDomainDefSetVcpus was not designed to handle coldplug of vcpus now > that we can set state of vcpus individually. > > Introduce qemuDomainSetVcpusConfig that properly handles state changes > of vcpus when coldplugging so that

Re: [libvirt] [PATCH v4 05/11] target-i386: Remove underscores from property names

On Thu, Sep 29, 2016 at 18:14:53 -0300, Eduardo Habkost wrote: > Instead of translating the feature name entries when adding > property names, store the actual property names in the feature > name array. > > Signed-off-by: Eduardo Habkost > --- > Changes series v3 -> v4: > *

Re: [libvirt] [PATCH V2 0/4]] qemu: report actual vcpu state in virVcpuInfo

On 29.09.2016 21:44, John Ferlan wrote: > > > On 09/29/2016 11:04 AM, Peter Krempa wrote: >> On Thu, Sep 29, 2016 at 10:30:07 -0400, John Ferlan wrote: >>> >>> >>> On 09/20/2016 04:10 AM, Viktor Mihajlovski wrote: [...] >>> >>> So, I have a question based on a little bit of testing I did with

Re: [libvirt] Cpu Modeling

On Thu, Sep 29, 2016 at 15:51:58 -0300, Eduardo Habkost wrote: > On Thu, Sep 29, 2016 at 04:21:07PM +0200, Jiri Denemark wrote: > [...] > > > > Slightly related, I don't think we have a way to list CPU features > > > > supported by QEMU over QMP, do we? "-cpu ?" will show them all, but I > > > >