[libvirt] [PATCH 07/15] util: Move/rename virStoragePoolGetVhbaSCSIHostParent to virvhba

Move the function and rename to simply virVHBAGetParent Since I'm changing related code, rather than have a Vhba named function in storage_backend_scsi rename it to simply checkParent as it's already within the scope of checking VHBA related features. Signed-off-by: John Ferlan

[libvirt] [PATCH 11/15] nodedev: Keep the node device lock longer in nodeDeviceDestroy

While perhaps improbable, it could be possible that after finding our object that another thread running essentially in parallel could attempt to delete the same vHBA. So rather than dropping the lock right after finding the object, keep the lock around while we drop the object lock and work on

[libvirt] [PATCH 06/15] util: Create a new virvhba module and move/rename API's

Rather than have them mixed in with the virutil apis, create a separate virvhba.c module and move the vHBA related calls into there. Soon there will be more added. Also modify the names of the functions and some arguments to be more indicative of what is really happening. Adjust the callers

[libvirt] [PATCH 15/15] tests: Add createVHBAByNodeDevice-parent-fabric-wwn to fchosttest

Add a test that allows providing the parent fabric_wwn in the input XML in order to create the vHBA. This also fixes a mixed setting of the fabric_wwn field from the read test driver XML strings. Signed-off-by: John Ferlan --- src/conf/node_device_conf.c | 8

[libvirt] [PATCH 14/15] tests: Add createVHBAByNodeDevice-parent-wwn to fchosttest

Add a test that allows providing the parent wwnn/wwpn in the input XML in order to create the vHBA. Signed-off-by: John Ferlan --- tests/fchosttest.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tests/fchosttest.c b/tests/fchosttest.c index

[libvirt] [PATCH 12/15] nodedev: Rework virNodeDeviceGetParentHost

Rework the code to perform the various searches by parent, parent_wwnn/ parent_wwpn, parent_fabric_wwn, or vport capable in order to return the 'parent_host' number that is vHBA capable. The former virNodeDeviceGetParentHost is renamed to add the ByParent on it fixes an issue where if no parent

[libvirt] [PATCH 05/15] test: Fix fchosttest resource leak

Commit id '666bee3' made fabric_name optional; however, if fabric name was present, then a leak would occur. Signed-off-by: John Ferlan --- tests/fchosttest.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/fchosttest.c b/tests/fchosttest.c

[libvirt] [PATCH 01/15] tests: Alter test_driver HBA name/data to be closer to reality

Alter "test-scsi-host-vport" to be "scsi_host1" to match the real environment. This is the vport capable HBA - IOW the NPIV device. Add more fields to scsi_host1 as well. Alter the XML being used by the objecttest to create a vHBA in order to match the scsi_host1 parent name and to use

[libvirt] [PATCH 10/15] tests: Add new fchosttest tests for management of a vHBA

Add a test that will mimic creation and destruction of a vHBA by using node device XML. The design will allow for testing the multiple mechanisms. The first test uses just in the node device XML. This is somewhat similar to the existing objecteventtest, except that this test will not provide

[libvirt] [PATCH 03/15] test: Add helper to create vHBA for testNodeDeviceCreateXML

Rather than inline the dummy creation of a vHBA to add to the node devices - create a helper to do that work. Also just tidy up a couple of things while at it... Signed-off-by: John Ferlan --- src/test/test_driver.c | 82 -- 1

[libvirt] [PATCH 04/15] tests: Create a more realistic vHBA

Modify the code to react more like a real HBA -> vHBA creation. Currently the code would just modify the input XML definition to set the name to a wwpn and then modify the scsi_host capability entry for the defintion to change the scsi_host# and unique_id before adding that into the node device.

[libvirt] [PATCH 09/15] util: Move scsi_host specific functions from virutil

Create a virscsihost.c and place the functions there. That removes the last #ifdef __linux__ from virutil.c. Take the opporunity to also change the function names and in one case the parameters slightly Signed-off-by: John Ferlan --- po/POTFILES.in

[libvirt] [PATCH 08/15] util: Reduce complexity of virVHBAGetParent

Rather that getting the XML, parsing it, and grabbing the parent name field, just call the virNodeDeviceGetParent which is far more efficient. Signed-off-by: John Ferlan --- src/util/virvhba.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git

[libvirt] [PATCH 13/15] tests: Add createVHBAByNodeDevice-no-parent to fchosttest

Add a test that allows not providing a parent in the input XML, but still being able to create finding a VPORT capable NPIV HBA. Signed-off-by: John Ferlan --- tests/fchosttest.c | 12 1 file changed, 12 insertions(+) diff --git a/tests/fchosttest.c

[libvirt] [PATCH 02/15] test: Add new NPIV capable HBA and a vHBA

Predefine a second NPIV capable HBA as well as a vHBA using the first NPIV capable HBA. This will allow for a mechanism to perform more realistic create vHBA testing. Signed-off-by: John Ferlan --- src/test/test_driver.c | 30 ++ 1 file changed,

[libvirt] [PATCH 00/15] Add more vHBA related tests and module-arize the code

Don't be scared off by the quantity of patches... There's quite a bit of code motion and function renaming going on before being able to more easily add tests that will ensure that from a nodedev perspective creation and deletion of the vHBA will work properly and it's possible to test the

[libvirt] [PATCH] domain_conf: vnc: preserve autoport value if no port was specified

The issue is that if this graphics definition is provided: it's parsed as: but if the resulting XML is parsed again the output is: and this should not happen. The XML have to always remain the same after it was already parsed by libvirt. Resolves:

[libvirt] Refactoring of storage pool

Hi everyone! Half a year ago we started discussion about filesystem pools: https://www.redhat.com/archives/libvir-list/2016-April/msg01941.html https://www.redhat.com/archives/libvir-list/2016-May/msg00208.html https://www.redhat.com/archives/libvir-list/2016-September/msg00463.html At the end

Re: [libvirt] [PATCHv2 1/3] util: unlock closeCallbacks if get callbacks for connect fail

On 01/18/2017 06:34 PM, John Ferlan wrote: > > > On 01/10/2017 01:23 AM, Wang King wrote: >> Avoid return with the closeCallbacks locked when get callbacks list for >> connect fail. >> >> Signed-off-by: Wang King >> --- >> src/util/virclosecallbacks.c | 4 +++- >> 1

Re: [libvirt] [PATCH 0/7] perf: add CACHE_L1D perf event support

On Wed, Jan 25, 2017 at 9:55 PM, John Ferlan wrote: > > > On 01/18/2017 11:58 PM, Nitesh Konkar wrote: > > This patch series adds support and documentation for > > a generalized hardware cache event called CACHE_L1D > > perf event. This perf event is split into cache_l1dra, >

[libvirt] [PATCH] util: Fix domain object leaks on closecallbacks

Originally/discovered proposed by "Wang King " When the virCloseCallbacksSet is first called, it increments the refcnt on the domain object to ensure it doesn't get deleted before the callback is called. The refcnt would be decremented in virCloseCallbacksUnset once the

Re: [libvirt] [PATCH v1 0/4] bhyve: rework SATA address allocation

On Thu, 2017-01-05 at 18:46 +0400, Roman Bogorodskiy wrote: > This series reworks SATA address allocation in the bhyve driver. > > While commit messages provide enough details (I hope), there > are some general important notes: > > - currently, sata devices get PCI addresses and this no >

Re: [libvirt] [PATCH 0/7] perf: add CACHE_L1D perf event support

On 01/18/2017 11:58 PM, Nitesh Konkar wrote: > This patch series adds support and documentation for > a generalized hardware cache event called CACHE_L1D > perf event. This perf event is split into cache_l1dra, > cache_l1drm, cache_l1dwa, cache_l1dwm, cache_l1dpa and > cache_l1dpm perf events

Re: [libvirt] non-standard types in remote XDR definitions

On Wed, Jan 25, 2017 at 11:12:33AM -0500, Matt Broadstone wrote: > On Wed, Jan 25, 2017 at 10:59 AM, Daniel P. Berrange > wrote: > > On Wed, Jan 25, 2017 at 10:55:37AM -0500, Matt Broadstone wrote: > >> Hello, > >> > >> I have been experimenting with the remote protocol

Re: [libvirt] non-standard types in remote XDR definitions

On Wed, Jan 25, 2017 at 10:59 AM, Daniel P. Berrange wrote: > On Wed, Jan 25, 2017 at 10:55:37AM -0500, Matt Broadstone wrote: >> Hello, >> >> I have been experimenting with the remote protocol defined in the >> `src/remote/remote_protocol.x` >>

[libvirt] non-standard types in remote XDR definitions

Hello, I have been experimenting with the remote protocol defined in the `src/remote/remote_protocol.x` (https://libvirt.org/git/?p=libvirt.git;a=blob_plain;f=src/remote/remote_protocol.x;hb=HEAD), and noticed that there a number of types used that are not defined in the XDR RFC, specifically:

Re: [libvirt] [PATCH 0/4] Support setting MTU on domain interfaces

On 01/24/2017 10:40 AM, Michal Privoznik wrote: > After Laine merges his patches [1] the only missing piece is setting MTU on a > domain . Well, up until now :-) > > 1: https://www.redhat.com/archives/libvir-list/2017-January/msg00946.html > > Michal Privoznik (4): > formatnetwork.html.in:

Re: [libvirt] [PATCH v3] Add support for Veritas HyperScale (VxHS) block device protocol

On 01/19/2017 09:21 PM, Ashish Mittal wrote: > Sample XML for a vxhs vdisk is as follows: > > > > > > > > > eb90327c-8302-4725-9e1b-4e85ed4dc251 > >function='0x0'/> > It's still not really clear how someone knows to use the name string. IOW: How would someone

Re: [libvirt] non-standard types in remote XDR definitions

On Wed, Jan 25, 2017 at 10:55:37AM -0500, Matt Broadstone wrote: > Hello, > > I have been experimenting with the remote protocol defined in the > `src/remote/remote_protocol.x` > (https://libvirt.org/git/?p=libvirt.git;a=blob_plain;f=src/remote/remote_protocol.x;hb=HEAD), > and noticed that there

Re: [libvirt] [PATCH v1 4/4] bhyve: add tests for SATA address allocation

On 01/05/2017 09:46 AM, Roman Bogorodskiy wrote: --- ...bhyvexml2argv-addr-more-than-32-sata-disks.args | 21 ++ ...yvexml2argv-addr-more-than-32-sata-disks.ldargs | 3 + .../bhyvexml2argv-addr-more-than-32-sata-disks.xml | 196

Re: [libvirt] [PATCH v1 3/4] bhyve: fix SATA address allocation

On 01/05/2017 09:46 AM, Roman Bogorodskiy wrote: As bhyve for a long time didn't have a notion of the explicit SATA controller and created a controller for each drive, the bhyve driver in libvirt acted in a similar way and didn't care about the SATA controllers and assigned PCI addresses to

Re: [libvirt] [PATCH 4/4] qemu: Implement mtu on interface

On 01/24/2017 10:40 AM, Michal Privoznik wrote: Not only we should set the MTU on the host end of the device but also let qemu know what MTU did we set. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 +

[libvirt] [PATCH v2] qemu: Don't lose group_name

Due to our APIs not copying various pointers, we need to carry it around on the side and just supply it every time it is needed. Otherwise it will not work with both --live and --config options. Signed-off-by: Martin Kletzander --- src/qemu/qemu_driver.c | 12 +---

Re: [libvirt] [PATCH 3/4] domain_conf: Introduce to

On 01/24/2017 10:40 AM, Michal Privoznik wrote: So far we allow to set MTU for libvirt networks. However, not all domain interfaces have to be plugged into a libvirt network and even if they are, they might want to have a different MTU (e.g. for testing purposes). ... although setting an MTU

Re: [libvirt] [PATCH 5/5] qemu: Add better message for some invalid block I/O settings

On 01/25/2017 09:07 AM, Martin Kletzander wrote: > On Wed, Jan 25, 2017 at 07:38:26AM -0500, John Ferlan wrote: >> >> >> On 01/25/2017 04:16 AM, Martin Kletzander wrote: >>> For example when both total_bytes_sec and total_bytes_sec_max are set, >>> but the former gets cleaned due to new call

Re: [libvirt] [PATCH 1/5] qemu: Only set group_name when actually requested

On 01/25/2017 08:55 AM, Martin Kletzander wrote: > On Wed, Jan 25, 2017 at 06:43:39AM -0500, John Ferlan wrote: >> >> >> On 01/25/2017 04:16 AM, Martin Kletzander wrote: >>> We were setting it based on whether it was supported and that lead to >>> setting it to NULL, which our JSON code caught.

Re: [libvirt] [PATCH 5/5] qemu: Add better message for some invalid block I/O settings

On Wed, Jan 25, 2017 at 07:38:26AM -0500, John Ferlan wrote: On 01/25/2017 04:16 AM, Martin Kletzander wrote: For example when both total_bytes_sec and total_bytes_sec_max are set, but the former gets cleaned due to new call setting, let's say, read_bytes_sec, we end up with this weird

Re: [libvirt] [PATCH] perf: introduce option --reset

On Mon, Jan 23, 2017 at 7:34 PM, Daniel P. Berrange wrote: > On Mon, Jan 23, 2017 at 07:26:58PM +0530, Nitesh Konkar wrote: > > Hi Daniel, > > > > > > On Mon, Jan 23, 2017 at 4:08 PM, Daniel P. Berrange > > > wrote: > > > > > On Mon, Jan 23, 2017 at

Re: [libvirt] [PATCH 1/5] qemu: Only set group_name when actually requested

On Wed, Jan 25, 2017 at 02:32:13PM +0100, Michal Privoznik wrote: On 01/25/2017 10:16 AM, Martin Kletzander wrote: We were setting it based on whether it was supported and that lead to setting it to NULL, which our JSON code caught. However it ended up producing the following results: $

Re: [libvirt] [PATCH 1/5] qemu: Only set group_name when actually requested

On Wed, Jan 25, 2017 at 06:43:39AM -0500, John Ferlan wrote: On 01/25/2017 04:16 AM, Martin Kletzander wrote: We were setting it based on whether it was supported and that lead to setting it to NULL, which our JSON code caught. However it ended up producing the following results: $ virsh

Re: [libvirt] [PATCH 1/5] qemu: Only set group_name when actually requested

On 01/25/2017 10:16 AM, Martin Kletzander wrote: > We were setting it based on whether it was supported and that lead to > setting it to NULL, which our JSON code caught. However it ended up > producing the following results: > > $ virsh blkdeviotune fedora vda --total-bytes-sec-max 2000 >

Re: [libvirt] [PATCH 3/5] virsh: Actually make blkdeviotune --group_name work

On 01/25/2017 10:16 AM, Martin Kletzander wrote: > Function vshCommandOptStringReq() returns -1 on error and 0 on > success. The code, however, used the 'group_name' variable only if it > returned 1 (never). > > Signed-off-by: Martin Kletzander > --- > tools/virsh-domain.c

Re: [libvirt] [PATCH 5/5] qemu: Add better message for some invalid block I/O settings

On 01/25/2017 10:16 AM, Martin Kletzander wrote: > For example when both total_bytes_sec and total_bytes_sec_max are set, > but the former gets cleaned due to new call setting, let's say, > read_bytes_sec, we end up with this weird message for the command: > > $ virsh blkdeviotune fedora vda

Re: [libvirt] [PATCH 2/5] qemu: Don't lose group_name

On 01/25/2017 10:16 AM, Martin Kletzander wrote: > Due to our APIs not copying various pointers, we need to carry it > around on the side and just supply it every time it is needed. > Otherwise it will not work with both --live and --config options. > > Signed-off-by: Martin Kletzander

Re: [libvirt] [PATCH 4/5] virsh: Use consistent naming for blkdeviotune options

On 01/25/2017 10:16 AM, Martin Kletzander wrote: > All options started with underscores, but we switched them to dashes > later on, making the style consistent. The latest addition, however, > did not respect that, so let's change that as well. It is tempting to > just change the name instead of

Re: [libvirt] [PATCH 1/2] Resctrl: Add some utils functions

Hi Eli Qiao, On Wed, Jan 18, 2017 at 03:26:19PM +0800, Eli Qiao wrote: > This patch adds some utils struct and functions to expose resctrl > information. > > virResCtrlAvailable: If resctrl interface exist on host > virResCtrlGet: get specify type resource contral information > virResCtrlInit:

Re: [libvirt] [PATCH 5/5] qemu: Add better message for some invalid block I/O settings

On 01/25/2017 04:16 AM, Martin Kletzander wrote: > For example when both total_bytes_sec and total_bytes_sec_max are set, > but the former gets cleaned due to new call setting, let's say, > read_bytes_sec, we end up with this weird message for the command: > > $ virsh blkdeviotune fedora vda

Re: [libvirt] [PATCH 4/5] virsh: Use consistent naming for blkdeviotune options

On 01/25/2017 04:16 AM, Martin Kletzander wrote: > All options started with underscores, but we switched them to dashes > later on, making the style consistent. The latest addition, however, > did not respect that, so let's change that as well. It is tempting to > just change the name instead

Re: [libvirt] [PATCH 3/5] virsh: Actually make blkdeviotune --group_name work

On 01/25/2017 04:16 AM, Martin Kletzander wrote: > Function vshCommandOptStringReq() returns -1 on error and 0 on > success. The code, however, used the 'group_name' variable only if it > returned 1 (never). > > Signed-off-by: Martin Kletzander > --- >

Re: [libvirt] [PATCH 2/5] qemu: Don't lose group_name

On 01/25/2017 04:16 AM, Martin Kletzander wrote: > Due to our APIs not copying various pointers, we need to carry it > around on the side and just supply it every time it is needed. > Otherwise it will not work with both --live and --config options. > > Signed-off-by: Martin Kletzander

Re: [libvirt] [PATCH 1/5] qemu: Only set group_name when actually requested

On 01/25/2017 04:16 AM, Martin Kletzander wrote: > We were setting it based on whether it was supported and that lead to > setting it to NULL, which our JSON code caught. However it ended up > producing the following results: > > $ virsh blkdeviotune fedora vda --total-bytes-sec-max 2000 >

[libvirt] [PATCH] doc: improve VNC/SPICE password documentation

If the passwd attribute is set to empty string it disables VNC/SPICE access to the guest. Signed-off-by: Pavel Hrdina --- docs/formatdomain.html.in | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/docs/formatdomain.html.in

[libvirt] [PATCH 5/5] qemu: Add better message for some invalid block I/O settings

For example when both total_bytes_sec and total_bytes_sec_max are set, but the former gets cleaned due to new call setting, let's say, read_bytes_sec, we end up with this weird message for the command: $ virsh blkdeviotune fedora vda --read-bytes-sec 3000 error: Unable to change block I/O

[libvirt] [PATCH 4/5] virsh: Use consistent naming for blkdeviotune options

All options started with underscores, but we switched them to dashes later on, making the style consistent. The latest addition, however, did not respect that, so let's change that as well. It is tempting to just change the name instead of adding alias, especially since nobody ever used it,

[libvirt] [PATCH 3/5] virsh: Actually make blkdeviotune --group_name work

Function vshCommandOptStringReq() returns -1 on error and 0 on success. The code, however, used the 'group_name' variable only if it returned 1 (never). Signed-off-by: Martin Kletzander --- tools/virsh-domain.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

[libvirt] [PATCH 2/5] qemu: Don't lose group_name

Due to our APIs not copying various pointers, we need to carry it around on the side and just supply it every time it is needed. Otherwise it will not work with both --live and --config options. Signed-off-by: Martin Kletzander --- src/qemu/qemu_driver.c | 16

[libvirt] [PATCH 1/5] qemu: Only set group_name when actually requested

We were setting it based on whether it was supported and that lead to setting it to NULL, which our JSON code caught. However it ended up producing the following results: $ virsh blkdeviotune fedora vda --total-bytes-sec-max 2000 error: Unable to change block I/O throttle error: internal

[libvirt] [PATCH 0/5] Various blkdeviotune fixes (but mostly group_name, well, almost exclusively)

So I wanted to fix the last thing in Bug 1344897 [1], just two error messages. But I couldn't test it out because recent addition of group_name broke setting blkdeviotune on new enough QEMU. Yes, that means 3.0.0 doesn't work with new enough QEMU. Or namespaces. Still not totally a brown-bag

[libvirt] [PATCH] virnettlssessiontest.c: fix grammar

Signed-off-by: Nitesh Konkar --- tests/virnettlssessiontest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/virnettlssessiontest.c b/tests/virnettlssessiontest.c index 0d2e106..24de212 100644 --- a/tests/virnettlssessiontest.c +++

Re: [libvirt] [PATCH] configure: fix indentation in TLS priority result

On 01/25/2017 09:22 AM, Pavel Hrdina wrote: On Tue, Jan 24, 2017 at 04:53:41PM +0100, Boris Fiuczynski wrote: Signed-off-by: Boris Fiuczynski --- m4/virt-tls-priority.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/virt-tls-priority.m4

Re: [libvirt] [PATCH v2] network: make openvswitch call timeout compile time configurable

On 01/25/2017 09:05 AM, Boris Fiuczynski wrote: > On 01/25/2017 04:16 AM, Laine Stump wrote: >> On 01/24/2017 10:53 AM, Boris Fiuczynski wrote: >>> Since a successful completion of the calls to openvswitch is expected >>> a long timeout should be chosen to account for heavily loaded systems. >>>

Re: [libvirt] [PATCH] configure: fix indentation in TLS priority result

On Tue, Jan 24, 2017 at 04:53:41PM +0100, Boris Fiuczynski wrote: > Signed-off-by: Boris Fiuczynski > --- > m4/virt-tls-priority.m4 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/m4/virt-tls-priority.m4 b/m4/virt-tls-priority.m4 > index

Re: [libvirt] [PATCH] THREADS.txt: fix typos

On 01/25/2017 07:35 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > s/wakup/wakeup > > Signed-off-by: Chen Hanxiao > --- > daemon/THREADS.txt | 2 +- > src/util/vireventpoll.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >

Re: [libvirt] [PATCH v2] network: make openvswitch call timeout compile time configurable

On 01/25/2017 04:16 AM, Laine Stump wrote: On 01/24/2017 10:53 AM, Boris Fiuczynski wrote: Since a successful completion of the calls to openvswitch is expected a long timeout should be chosen to account for heavily loaded systems. Therefore this patch increases the timeout value from 5 to 120