Re: [libvirt] 答复: Re: 答复: Re: [PATCH] qemu: change the name of tap device for a tapand bridge network

(Please don't top-post replies. ALso, I added libvir-list back to the To:) On 05/03/2017 08:46 PM, lu.zhip...@zte.com.cn wrote: > > Some other scenarios such as migration. > > Can we guarantee that the network card driver has been > closed before killing QEMU ? During a migration, before we

[libvirt] 答复: Re: [PATCH] qemu: change the name of tap device for a tapand bridge network

I'm worried that the network packet loss rate will increase after reversing the order. 为了让您的VPlat虚拟化故障得到高效的处理，请上报故障到: $VPlat技术支持。 芦志朋 luzhipeng IT开发工程师 IT Development Engineer 操作系统产品部/中心研究院/系统产品 OS Product Dept./Central R＆D Institute/System Product

Re: [libvirt] [PATCH v2 08/38] util: Introduce virFileInData

On 04/30/2017 02:43 AM, Michal Privoznik wrote: > On 04/29/2017 06:46 PM, John Ferlan wrote: >> >> >> On 04/20/2017 06:01 AM, Michal Privoznik wrote: >>> This function takes a FD and determines whether the current >>> position is in data section or in a hole. In addition to that, >>> it also

Re: [libvirt] [PATCH v1] libxl: report numa sibling distances on host capabilities

Wim Ten Have wrote: > From: Wim ten Have > > When running on a NUMA machine, populate the sibling node > and distance information using data supplied by Xen. > > With locality distances information, under Xen, new host > capabilities would like: > > > >

Re: [libvirt] [PATCH 3/2] news: Add even more v3.3.0 entries

On Wed, May 03, 2017 at 06:03:23PM +0200, Andrea Bolognani wrote: --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 8f6b768..593cc52 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -176,6 +176,16 @@ qemu: Do not crash

Re: [libvirt] [PATCH 2/2] news: Add more v3.3.0 entries

On Wed, 2017-05-03 at 17:25 +0200, Ján Tomko wrote: > > > Rather than this I'd mention the bug in the padding of data passed to > > > qemu: 71890992daf37ec78b00b4ce873369421dc99731 > >  > > Why not both? :) > >  > > However, I'm unable to find that commit in either libvirt's > > or QEMU's git

[libvirt] [PATCH 3/2] news: Add even more v3.3.0 entries

--- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 8f6b768..593cc52 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -176,6 +176,16 @@ qemu: Do not crash on USB address with no port and invalid bus +

Re: [libvirt] [PATCH 1/2] util: mdev: Use a local variable instead of an invalid pointer reference

On Wed, May 03, 2017 at 05:35:47PM +0200, Pavel Hrdina wrote: > On Fri, Apr 28, 2017 at 09:46:32AM +0200, Erik Skultety wrote: > > virMediatedDeviceListAdd calls VIR_APPEND_ELEMENT which normally clears > > the element to be added, thus the pointer must not be used afterwards, > > but because the

Re: [libvirt] [PATCH 1/2] util: mdev: Use a local variable instead of an invalid pointer reference

On Fri, Apr 28, 2017 at 09:46:32AM +0200, Erik Skultety wrote: > virMediatedDeviceListAdd calls VIR_APPEND_ELEMENT which normally clears > the element to be added, thus the pointer must not be used afterwards, > but because the pointer here is passed by value, what gets cleared is > a copy of the

Re: [libvirt] [PATCH 1/2] util: mdev: Use a local variable instead of an invalid pointer reference

On 04/28/2017 03:46 AM, Erik Skultety wrote: > virMediatedDeviceListAdd calls VIR_APPEND_ELEMENT which normally clears > the element to be added, thus the pointer must not be used afterwards, > but because the pointer here is passed by value, what gets cleared is > a copy of the original pointer

Re: [libvirt] [PATCH 2/2] mdev: Fix daemon crash on domain shutdown after reconnect

On 04/28/2017 03:46 AM, Erik Skultety wrote: > The problem resides in virHostdevUpdateActiveMediatedDevices which gets > called during qemuProcessReconnect. The issue here is that > virMediatedDeviceListAdd takes a pointer to the item to be added to the > list to which VIR_APPEND_ELEMENT is used,

Re: [libvirt] [PATCH 2/2] news: Add more v3.3.0 entries

On Wed, May 03, 2017 at 05:11:29PM +0200, Andrea Bolognani wrote: On Wed, 2017-05-03 at 09:19 +0200, Peter Krempa wrote: > + > +  storage: Fix capacity value for LUKS encrypted volumes > + > + > +  The 'capacity' value (e.g. guest logical size) for a LUKS

Re: [libvirt] [PATCH 2/2] news: Add more v3.3.0 entries

On Wed, 2017-05-03 at 09:19 +0200, Peter Krempa wrote: > > + > > +  storage: Fix capacity value for LUKS encrypted volumes > > + > > + > > +  The 'capacity' value (e.g. guest logical size) for a LUKS volume > > is > > +  smaller than the 'physical'

[libvirt] Availability of Candidate Release 2 of libvirt-3.3.0

Due to some Red Hat Summit event, I got severely distracted yesterday and forgot to tag RC2, this is now done, there is signed tarball and rpms at the usual place: ftp://libvirt.org/libvirt/ Things seems to look fine, there is relatively few changes from RC1, but so far I didn;t heard

Re: [libvirt] [PATCH 1/1] vz: minor cleanup in prlsdkDomainSetUserPassword

On 03.05.2017 13:44, Konstantin Neumoin wrote: > No need begin job for asynchronous operation. > > Signed-off-by: Konstantin Neumoin > --- > src/vz/vz_sdk.c | 16 ++-- > 1 file changed, 2 insertions(+), 14 deletions(-) > > diff --git a/src/vz/vz_sdk.c

Re: [libvirt] [PATCH 1/1] vz: fix raise in vzDomainBlock

On 05/03/2017 05:10 PM, Nikolay Shirokovskiy wrote: On 03.05.2017 13:44, Konstantin Neumoin wrote: Need begin job before lookup disk in config, because it can be edited at this moment. I would slightly change commit message to something like: OK -- libvir-list mailing list

Re: [libvirt] [PATCH 1/1] vz: fix raise in vzDomainBlock

On 03.05.2017 13:44, Konstantin Neumoin wrote: > Need begin job before lookup disk in config, > because it can be edited at this moment. I would slightly change commit message to something like: Put domain access after acquiring job condition, otherwise another job can change it meanwhile.

[libvirt] [PATCHv4 6/6] qemu: format caching-mode on iommu command line

Format the caching-mode option for the intel-iommu device, based on its attribute value. https://bugzilla.redhat.com/show_bug.cgi?id=1427005 --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c

[libvirt] [PATCHv4 2/6] qemu: format kernel_irqchip on the command line

Add kernel_irqchip=split/on to the QEMU command line and a capability that looks for it in query-command-line-options output. For the 'split' option, use a version check since it cannot be reasonably probed. https://bugzilla.redhat.com/show_bug.cgi?id=1427005 --- src/qemu/qemu_capabilities.c

[libvirt] [PATCHv4 5/6] conf: add caching_mode attribute to iommu device

Add a new attribute to control the caching mode. https://bugzilla.redhat.com/show_bug.cgi?id=1427005 --- docs/formatdomain.html.in | 9 docs/schemas/domaincommon.rng | 5 +++ src/conf/domain_conf.c | 24 +--

[libvirt] [PATCHv4 3/6] conf: add to

Add a new attribute to control interrupt remapping. https://bugzilla.redhat.com/show_bug.cgi?id=1427005 --- docs/formatdomain.html.in | 24 +- docs/schemas/domaincommon.rng | 9 + src/conf/domain_conf.c |

[libvirt] [PATCHv4 0/6] Support more options for intel-iommu

https://bugzilla.redhat.com/show_bug.cgi?id=1427005 v1: https://www.redhat.com/archives/libvir-list/2017-March/msg01072.html v2: https://www.redhat.com/archives/libvir-list/2017-April/msg00932.html v3: https://www.redhat.com/archives/libvir-list/2017-April/msg01248.html new in v4: * mention

[libvirt] [PATCHv4 4/6] qemu: format intel-iommu, intremap on the command line

https://bugzilla.redhat.com/show_bug.cgi?id=1427005 --- src/qemu/qemu_capabilities.c | 8 src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c| 18 .../qemucapabilitiesdata/caps_2.4.0.x86_64.replies |

[libvirt] [PATCHv4 1/6] conf: add to

Add a new element with a driver attribute. Possible values are qemu and kvm. With 'qemu', the I/O APIC can be put in the userspace even for KVM domains. https://bugzilla.redhat.com/show_bug.cgi?id=1427005 --- docs/formatdomain.html.in | 8 ++

Re: [libvirt] [PATCH 1/1] vz: unlock dom until resize operation

On 03.05.2017 14:23, Konstantin Neumoin wrote: > We have to use waitDomainJob instead of waitJob, because of it > unlock the domain until job has finished, so domain will be available > for other clients. > > Signed-off-by: Konstantin Neumoin > --- > src/vz/vz_sdk.c |

Re: [libvirt] [PATCH 4/5] qemuDomainAttachDeviceMknodRecursive: Don't try to create devices under preserved mount points

On Fri, 2017-04-28 at 13:22 +0200, Michal Privoznik wrote: > Just like in previous commit, this fixes the same issue for > hotplug. > > Signed-off-by: Michal Privoznik > --- >  src/qemu/qemu_domain.c | 112 > ++--- >  1 file

Re: [libvirt] [PATCH 5/5] qemuDomainDetachDeviceUnlink: Don't unlink files we haven't created

On Fri, 2017-04-28 at 13:22 +0200, Michal Privoznik wrote: > Even though there are several checks before calling this function > and for some scenarios we don't call it at all (e.g. on disk hot > unplug), it may be possible to sneak in some weird files (e.g. if > domain would have RNG with

Re: [libvirt] [PATCH 3/5] qemuDomainCreateDeviceRecursive: Don't try to create devices under preserved mount points

On Fri, 2017-04-28 at 13:22 +0200, Michal Privoznik wrote: > While the code allows devices to already be there (by some > miracle), we shouldn't try to create devices that don't belong to > us. For instance, we shouldn't try to create /dev/shm/file > because /dev/shm is a mount point that is

Re: [libvirt] [PATCH] client: Report proper close reason

On Tue, May 02, 2017 at 16:55:59 +0200, Jiri Denemark wrote: > When we get a POLLHUP or VIR_EVENT_HANDLE_HANGUP event for a client, we > still want to read from the socket to process any accumulated data. But > doing so inevitably results in an error and a call to > virNetClientMarkClose before we

Re: [libvirt] [PATCH 2/5] qemuDomainCreateDeviceRecursive: pass a structure instead of bare path

On Fri, 2017-04-28 at 13:22 +0200, Michal Privoznik wrote: > Currently, all we need to do in qemuDomainCreateDeviceRecursive() is to > take given @device, get all kinds of info on it (major & minor numbers, > owner, seclabels) and create its copy at a temporary location @path > (usually

Re: [libvirt] [PATCH 1/5] qemuDomainBuildNamespace: Move /dev/* mountpoints later

On Fri, 2017-04-28 at 13:22 +0200, Michal Privoznik wrote: > When setting up mount namespace for a qemu domain the following > steps are executed: > > 1) get list of mountpoints under /dev/ > 2) move them to /var/run/libvirt/qemu/$domName.ext > 3) start constructing new device tree under

[libvirt] RFE: virsh list improvement (--description and --details)

Hello, 1. Please add —description parameter to virsh list command. It should be similar to —title. It will be very helpful for administrators who like to leave the order and documentation after their work. 2. Please add new columns to virsh list (for —details): a) CPUs b) MaxMem c) Flags:

[libvirt] [PATCH 1/1] vz: unlock dom until resize operation

We have to use waitDomainJob instead of waitJob, because of it unlock the domain until job has finished, so domain will be available for other clients. Signed-off-by: Konstantin Neumoin --- src/vz/vz_sdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [PATCH 1/1] vz: fix raise in vzDomainBlock

Need begin job before lookup disk in config, because it can be edited at this moment. Signed-off-by: Konstantin Neumoin --- src/vz/vz_driver.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index

[libvirt] [PATCH 1/1] vz: minor cleanup in prlsdkDomainSetUserPassword

No need begin job for asynchronous operation. Signed-off-by: Konstantin Neumoin --- src/vz/vz_sdk.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index 138aea3..bc1a9eb 100644 --- a/src/vz/vz_sdk.c

Re: [libvirt] Libvirt CAT support plan

On Wednesday, 3 May 2017 at 4:34 PM, Daniel P. Berrange wrote: > On Wed, May 03, 2017 at 08:30:31AM +0800, Eli Qiao wrote: > > hi all, > > > > Thanks for helping reviewing for CAT support in the past days. > > > > I writing this email to ask for the plan in libvirt support. > > > > I

Re: [libvirt] Libvirt CAT support plan

On Wed, May 03, 2017 at 08:30:31AM +0800, Eli Qiao wrote: > hi all, > > Thanks for helping reviewing for CAT support in the past days. > > I writing this email to ask for the plan in libvirt support. > > I think we’v discussed this early this year, and I’v proposed a patch set [1]. > But don’t

Re: [libvirt] [PATCH 2/2] news: Add more v3.3.0 entries

On Tue, May 02, 2017 at 18:23:08 +0200, Andrea Bolognani wrote: > These entries cover a number of features, improvements and > bug fixes that had not been documented during the development > cycle. > --- > docs/news.xml | 115 > ++ > 1 file

Re: [libvirt] [PATCH 1/2] news: Tweak existing v3.3.0 entries

On Tue, May 02, 2017 at 18:22:44 +0200, Andrea Bolognani wrote: > Some of the content was not following the (loosely established) > style, and some of the XML was not aligned properly. > --- > docs/news.xml | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) ACK signature.asc