Re: [libvirt] [PATCH v2] libxl: report numa sibling distances on host capabilities

2017-05-10 Thread Jim Fehlig
On 05/10/2017 05:38 AM, Joao Martins wrote: On 05/09/2017 07:06 PM, Wim Ten Have wrote: From: Wim ten Have When running on a NUMA machine, populate the sibling node and distance information using data supplied by Xen. With locality distances information, under Xen,

Re: [libvirt] [libvirt-php PATCH 0/2] implement a few network API bindings

2017-05-10 Thread Neal Gompa
On Mon, May 8, 2017 at 11:43 AM, Dawid Zamirski wrote: > Hello, > > The followinig two patches add a few useful API bindings for dealing > with libvirt networks: > > * virConnectListAllNetworks - allows for better control when filtering > and returns array of handles to

[libvirt] [PATCH] Add missing deps on virfilewrapper.h

2017-05-10 Thread Daniel P. Berrange
The test programs depend on virfilewrapper.h as well as the virfilewrapper.c. Adding the dep ensures that virfilewrapper.h gets included in the dist tarball. Signed-off-by: Daniel P. Berrange --- Pushed as a build fix, since RPM build / distcheck is broken without this

Re: [libvirt] [PATCH] nodedev_udev: Fix missing events when kernel report lots of udev events within a short time

2017-05-10 Thread Erik Skultety
On Wed, May 10, 2017 at 12:44:22PM +0100, Daniel P. Berrange wrote: > On Wed, May 10, 2017 at 01:38:00PM +0200, Erik Skultety wrote: > > On Tue, May 09, 2017 at 10:09:07AM +0800, ZhiPeng Lu wrote: > > > From: "ning.bo" > > > > > > When create Virtual Function for Inter XL710

Re: [libvirt] [PATCH v2 30/38] virNetClientStream: Wire up VIR_NET_STREAM_SKIP

2017-05-10 Thread John Ferlan
On 05/09/2017 04:17 AM, Michal Privoznik wrote: > On 05/05/2017 05:43 PM, John Ferlan wrote: >> >> >> On 04/20/2017 06:01 AM, Michal Privoznik wrote: >>> Whenever server sends a client stream packet (either regular with >>> actual data or stream skip one) it is queued on @st->rx. So the >>> list

Re: [libvirt] [PATCH] Add support for VNC autoport feature for bhyve hypervisor.

2017-05-10 Thread Roman Bogorodskiy
Alexander Nusov wrote: > This patch adds support for automatic VNC port assignment for bhyve guests. > > --- > src/bhyve/bhyve_command.c | 9 + > src/bhyve/bhyve_driver.c | 5 + > src/bhyve/bhyve_utils.h | 3 +++ > 3 files changed, 17 insertions(+) Hi Alexander, Thanks for

Re: [libvirt] [PATCH v2 22/38] daemon: Introduce virNetServerProgramSendStreamSkip

2017-05-10 Thread John Ferlan
On 05/10/2017 07:53 AM, Michal Privoznik wrote: > On 05/05/2017 05:26 PM, John Ferlan wrote: >> >> >> On 04/20/2017 06:01 AM, Michal Privoznik wrote: >>> This is just a helper function that takes in a length value, >>> encodes it into XDR and sends to client. >> >> would be adjusted w/ @flags

[libvirt] [PATCH] virsh: Add --tls description for the virsh man page

2017-05-10 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1448806 Commit id '6a8d898d' neglected to update the man page. Signed-off-by: John Ferlan --- tools/virsh.pod | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index

Re: [libvirt] [PATCH 2/2] qemu: driver: Fix usage of qemuOpenFile

2017-05-10 Thread Ján Tomko
On Wed, May 10, 2017 at 02:18:33PM +0200, Peter Krempa wrote: The function returns -errno on failure, not only -1. This broken usage was introduced by commit 732af77cce. Actually, that was commit b4a40dd92dc7e6f110b13f2353cb5343d1147227 I am unsure why this function should return -errno since

[libvirt] [PATCH 2/2] qemu: driver: Fix usage of qemuOpenFile

2017-05-10 Thread Peter Krempa
The function returns -errno on failure, not only -1. This broken usage was introduced by commit 732af77cce. --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 92ef983ae..b238181f3 100644 ---

[libvirt] [PATCH 1/2] qemu: driver: Document qemuOpenFile

2017-05-10 Thread Peter Krempa
The function is nontrivial to follow and has non-standard return values. Recent usage was buggy. --- src/qemu/qemu_driver.c | 27 +++ 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a5c664e65..92ef983ae

[libvirt] [PATCH 0/2] qemu: driver: Document and fix usage of qemuOpenFile

2017-05-10 Thread Peter Krempa
Peter Krempa (2): qemu: driver: Document qemuOpenFile qemu: driver: Fix usage of qemuOpenFile src/qemu/qemu_driver.c | 29 - 1 file changed, 24 insertions(+), 5 deletions(-) -- 2.12.2 -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH v2 22/38] daemon: Introduce virNetServerProgramSendStreamSkip

2017-05-10 Thread Michal Privoznik
On 05/05/2017 05:26 PM, John Ferlan wrote: > > > On 04/20/2017 06:01 AM, Michal Privoznik wrote: >> This is just a helper function that takes in a length value, >> encodes it into XDR and sends to client. > > would be adjusted w/ @flags arg > >> >> Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH] nodedev_udev: Fix missing events when kernel report lots of udev events within a short time

2017-05-10 Thread Daniel P. Berrange
On Wed, May 10, 2017 at 01:38:00PM +0200, Erik Skultety wrote: > On Tue, May 09, 2017 at 10:09:07AM +0800, ZhiPeng Lu wrote: > > From: "ning.bo" > > > > When create Virtual Function for Inter XL710 use below commands: > > for i in `seq 0 1`; do > > echo 63 > > >

Re: [libvirt] [PATCH v2] libxl: report numa sibling distances on host capabilities

2017-05-10 Thread Joao Martins
On 05/09/2017 07:06 PM, Wim Ten Have wrote: > From: Wim ten Have > > When running on a NUMA machine, populate the sibling node > and distance information using data supplied by Xen. > > With locality distances information, under Xen, new host > capabilities would like:

Re: [libvirt] [PATCH] nodedev_udev: Fix missing events when kernel report lots of udev events within a short time

2017-05-10 Thread Erik Skultety
On Tue, May 09, 2017 at 10:09:07AM +0800, ZhiPeng Lu wrote: > From: "ning.bo" > > When create Virtual Function for Inter XL710 use below commands: > for i in `seq 0 1`; do > echo 63 > > /sys/devices/pci:00/:00:03.2/:07:00.$i/sriov_numvfs > done > for i in

[libvirt] src/remote_protocol-structs file

2017-05-10 Thread Vasiliy Tolstov
Hi. While i'm writing go binding for libvirt rpc api i'm parse src/remote/remote_protocol.x and generate needed code for go, but as i see libvirt have src/remote_protocol-structs file. That contains all needed data in mo simple syntax. But i don't see such files for qemu_protocol.x and

Re: [libvirt] [PATCH] Don't inline virStringTrimOptionalNewline

2017-05-10 Thread Martin Kletzander
On Wed, May 10, 2017 at 09:26:18AM +0100, Daniel P. Berrange wrote: GCC complains that inlining virStringTrimOptionalNewline is not likely on some platforms: cc1: warnings being treated as errors ../../src/util/virfile.c: In function 'virFileReadValueBitmap': ../../src/util/virstring.h:292:

Re: [libvirt] [PATCH v2 15/38] Introduce virStreamSparseSendAll

2017-05-10 Thread Michal Privoznik
On 05/04/2017 11:35 PM, John Ferlan wrote: > > > On 04/20/2017 06:01 AM, Michal Privoznik wrote: >> This is just a wrapper over new function that have been just >> introduced: virStreamSkip() . It's very similar to >> virStreamSendAll() except it handles sparse streams well. > > You could have

Re: [libvirt] [PATCH] Don't inline virStringTrimOptionalNewline

2017-05-10 Thread Daniel P. Berrange
On Wed, May 10, 2017 at 11:12:00AM +0200, Martin Kletzander wrote: > On Wed, May 10, 2017 at 09:26:18AM +0100, Daniel P. Berrange wrote: > > GCC complains that inlining virStringTrimOptionalNewline is not > > likely on some platforms: > > > > cc1: warnings being treated as errors > >

[libvirt] set link state for ethernet network devices

2017-05-10 Thread Vasiliy Tolstov
Hi! Sometimes ago i'm write patch for setting link state of network interface for ethernet type (tap). Now i'm try libvirt 3.3.0 and see, that tap interfaces is up but in xml i'm try to specify also i'm try Nothing changed. Laine says, that link state is only for internal representation, and to

[libvirt] [PATCH] Don't inline virStringTrimOptionalNewline

2017-05-10 Thread Daniel P. Berrange
GCC complains that inlining virStringTrimOptionalNewline is not likely on some platforms: cc1: warnings being treated as errors ../../src/util/virfile.c: In function 'virFileReadValueBitmap': ../../src/util/virstring.h:292: error: inlining failed in call to 'virStringTrimOptionalNewline':

Re: [libvirt] [RFC PATCH REBASE 00/10] introduce push backups

2017-05-10 Thread Nikolay Shirokovskiy
On 10.05.2017 11:11, Daniel P. Berrange wrote: > On Fri, May 05, 2017 at 09:22:21AM +0300, Nikolay Shirokovskiy wrote: >> Push backup is a backup when hypervisor itself copy backup data to >> destination >> in contrast to pull backup when hypervisor exports backup data thru some >> interface

Re: [libvirt] [RFC PATCH REBASE 00/10] introduce push backups

2017-05-10 Thread Daniel P. Berrange
On Fri, May 05, 2017 at 09:22:21AM +0300, Nikolay Shirokovskiy wrote: > Push backup is a backup when hypervisor itself copy backup data to destination > in contrast to pull backup when hypervisor exports backup data thru some > interface and mgmt itself make a copy. > > This patch series

Re: [libvirt] [RFC PATCH REBASE 10/10] virsh: backup: add backup-create command

2017-05-10 Thread Daniel P. Berrange
On Fri, May 05, 2017 at 09:22:31AM +0300, Nikolay Shirokovskiy wrote: > --- > po/POTFILES.in | 1 + > tools/Makefile.am| 1 + > tools/virsh-backup.c | 100 > +++ > tools/virsh-backup.h | 29 +++ > tools/virsh-util.c |

Re: [libvirt] [RFC PATCH REBASE 06/10] conf: backup: add backup xml definition

2017-05-10 Thread Daniel P. Berrange
On Fri, May 05, 2017 at 09:22:27AM +0300, Nikolay Shirokovskiy wrote: > Backup xml description is like this: > > > backup name > > > > > > - element is optional. > > - disk @type attribute is optional, default to 'file'. Valid > values are 'file', 'block', 'dir', 'network',

Re: [libvirt] [PATCH v2 0/5] Prevent losing IPv6 routes due to forwarding

2017-05-10 Thread Yalan Zhang
I have no RA route set. I will try, Thank you very much! Best Regards, Yalan Zhang IRC: yalzhang Internal phone: 8389413 On Wed, May 10, 2017 at 3:34 PM, Cedric Bosdonnat wrote: > On Wed, 2017-05-10 at 13:30 +0800, Yalan Zhang wrote: > > I'm sorry that I missed the mail. >

Re: [libvirt] [PATCH v2 0/5] Prevent losing IPv6 routes due to forwarding

2017-05-10 Thread Cedric Bosdonnat
On Wed, 2017-05-10 at 13:30 +0800, Yalan Zhang wrote: > I'm sorry that I missed the mail.  没关系 > But currently I can not reproduce it.  > For the error by net-create, it is executed when I set accept_ra to 1. That sounds more normal. net-create and net-start are triggering the same code in the