Re: [libvirt] [PATCH v2] qemu: Adding 'downscript' feature for QEMU network interfaces.

2017-05-15 Thread Julio Faracco
Ping. Any feedback? 2017-05-05 11:25 GMT-03:00 Julio Faracco : > V1 patch did not have the docs/formatdomain.html.in commit. > > 2017-05-05 11:22 GMT-03:00 Julio Faracco : >> This commit adds the support for 'downscript' feature: >> - For QEMU command

[libvirt] [PATCH] qemu: allow to control host side link status of network device

2017-05-15 Thread Vasiliy Tolstov
Signed-off-by: Vasiliy Tolstov --- docs/formatdomain.html.in | 21 + docs/schemas/domaincommon.rng | 11 +++ src/conf/domain_conf.c| 28 src/conf/domain_conf.h| 1 + src/qemu/qemu_hotplug.c |

[libvirt] [PATCH] allow to control host side link status of ethernet network device

2017-05-15 Thread Vasiliy Tolstov
Back to old thread with Laine Stump with message title: "qemu: remove unnecessary setting of tap device online state" I'm not tested ip and route assign in case of up/down link and device update on the fly. But host side link status tested and worked fine. Vasiliy Tolstov (1): qemu: allow to

[libvirt] limit pps via bandwidth

2017-05-15 Thread Vasiliy Tolstov
Hi. I have a problem that some vps generate very big pps (50). I want to limit it for some reasonable value. iptables does not support by default limit by pps more that 1, i can use nft... but Why not use tc for this ? http://www.lartc.org/manpages/tc-pbfifo.html

Re: [libvirt] [PATCH 09/10] appmor, virt-aa-helper: Add 9p support

2017-05-15 Thread Guido Günther
On Mon, May 15, 2017 at 03:23:18PM +0200, Stefan Bader wrote: > From: Serge Hallyn > > Add fowner and fsetid to libvirt-qemu profile and add link > to 9p file options in virt-aa-helper. > > Bug-Ubuntu: https://bugs.launchpad.net/bugs/1378434 > > Signed-off-by:

Re: [libvirt] [PATCH 01/10] virt-aa-helper: Ask for no deny rule for readonly disk elements

2017-05-15 Thread Stefan Bader
On 15.05.2017 17:48, Guido Günther wrote: > On Mon, May 15, 2017 at 03:23:10PM +0200, Stefan Bader wrote: >> From: Serge Hallyn >> >> Just because a disk element only requests read access doesn't mean >> there may not be another readwrite request. >> >> Bug-Ubuntu:

Re: [libvirt] [PATCH 06/10] apparmor, virt-aa-helper: Additional explicit denies for host devices

2017-05-15 Thread Stefan Bader
On 15.05.2017 17:56, Guido Günther wrote: > On Mon, May 15, 2017 at 03:23:15PM +0200, Stefan Bader wrote: >> From: Christian Ehrhardt >> >> This adds further explicit denies for host devices to silence >> (acceptable) denial warnings. >> >> Signed-off-by:

Re: [libvirt] [libvirt-python PATCH v2] spec: Install egg-info with rpm package

2017-05-15 Thread Daniel P. Berrange
On Mon, May 15, 2017 at 05:58:47PM +0200, Martin Kletzander wrote: > This was being done due to now deprecated policy and that file should > be installed so that pip can recognize that the packages is already > installed in the system. > > Signed-off-by: Martin Kletzander >

[libvirt] [PATCH] remove hack for debian etch limits.h

2017-05-15 Thread Daniel P. Berrange
The debian etch distro was end-of-life a long time ago so we no longer need the ULLONG_MAX hack. In any case gnulib now provides an equivalent fix by default, and so our definition now triggers syntax-check rule failure src/internal.h:#define ULLONG_MAX ULONG_LONG_MAX maint.mk: define the

Re: [libvirt] [PATCH 03/10] apparmor, virt-aa-helper: Allow aarch64 UEFI.

2017-05-15 Thread Guido Günther
On Mon, May 15, 2017 at 03:23:12PM +0200, Stefan Bader wrote: > From: William Grant > > Allow access to aarch64 UEFI images. > > Signed-off-by: Christian Ehrhardt > Signed-off-by: Stefan Bader > --- >

Re: [libvirt] [PATCH 08/10] apparmor: provide local override templates

2017-05-15 Thread Guido Günther
On Mon, May 15, 2017 at 03:23:17PM +0200, Stefan Bader wrote: > Local overrides is a feature Debian/Ubuntu libvirt provided for a while. > This allows the user to have a non-conffile that he can use to extend the > package delivered rules with extra content matching his special case. > > This

[libvirt] [libvirt-python PATCH v2] spec: Install egg-info with rpm package

2017-05-15 Thread Martin Kletzander
This was being done due to now deprecated policy and that file should be installed so that pip can recognize that the packages is already installed in the system. Signed-off-by: Martin Kletzander --- v2: - Put each egg-info ito its respective RPM package

Re: [libvirt] [libvirt-python PATCH] spec: Install egg-info with rpm package

2017-05-15 Thread Martin Kletzander
On Mon, May 15, 2017 at 04:30:17PM +0100, Daniel P. Berrange wrote: On Mon, May 15, 2017 at 05:26:39PM +0200, Martin Kletzander wrote: This was being done due to now deprecated policy and that file should be installed so that pip can recognize that the packages is already installed in the

Re: [libvirt] [PATCH 02/10] apparmor, virt-aa-helper: allow /usr/share/OVMF/ too

2017-05-15 Thread Guido Günther
On Mon, May 15, 2017 at 03:23:11PM +0200, Stefan Bader wrote: > From: Simon McVittie > > The split firmware and variables files introduced by > https://bugs.debian.org/764918 are in a different directory for some reason. > Let the virtual machine read both. > > Extended by

Re: [libvirt] [PATCH 06/10] apparmor, virt-aa-helper: Additional explicit denies for host devices

2017-05-15 Thread Guido Günther
On Mon, May 15, 2017 at 03:23:15PM +0200, Stefan Bader wrote: > From: Christian Ehrhardt > > This adds further explicit denies for host devices to silence > (acceptable) denial warnings. > > Signed-off-by: Christian Ehrhardt >

Re: [libvirt] [PATCH 01/10] virt-aa-helper: Ask for no deny rule for readonly disk elements

2017-05-15 Thread Guido Günther
On Mon, May 15, 2017 at 03:23:10PM +0200, Stefan Bader wrote: > From: Serge Hallyn > > Just because a disk element only requests read access doesn't mean > there may not be another readwrite request. > > Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/bugs/1554031 The

Re: [libvirt] [PATCH 04/10] apparmor, virt-aa-helper: Allow access to libnl-3 config files

2017-05-15 Thread Guido Günther
On Mon, May 15, 2017 at 03:23:13PM +0200, Stefan Bader wrote: > From: Felix Geyer > > Allow access to libnl-3 config files > > Signed-off-by: Christian Ehrhardt > Signed-off-by: Stefan Bader > --- >

Re: [libvirt] [PATCH 05/10] apparmor, virt-aa-helper: Explicit denies for host devices

2017-05-15 Thread Guido Günther
On Mon, May 15, 2017 at 03:23:14PM +0200, Stefan Bader wrote: > From: Felix Geyer > > Add explicit denies for disk devices to avoid cluttering dmesg with > (acceptable) denials. > > Signed-off-by: Christian Ehrhardt > Signed-off-by: Stefan

Re: [libvirt] [libvirt-python PATCH] spec: Install egg-info with rpm package

2017-05-15 Thread Daniel P. Berrange
On Mon, May 15, 2017 at 05:26:39PM +0200, Martin Kletzander wrote: > This was being done due to now deprecated policy and that file should > be installed so that pip can recognize that the packages is already > installed in the system. > > Signed-off-by: Martin Kletzander >

[libvirt] [libvirt-python PATCH] spec: Install egg-info with rpm package

2017-05-15 Thread Martin Kletzander
This was being done due to now deprecated policy and that file should be installed so that pip can recognize that the packages is already installed in the system. Signed-off-by: Martin Kletzander --- libvirt-python.spec.in | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [libvirt] [PATCH] maint: update to latest gnulib

2017-05-15 Thread Andrea Bolognani
On Mon, 2017-05-15 at 10:08 +0100, Daniel P. Berrange wrote: > This pulls in the fixes for poll() on Win32 which finally > makes the remote driver work again. > > Signed-off-by: Daniel P. Berrange > --- > .gnulib | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[libvirt] [PATCH v2 0/5] qemu: Unbreak aarch64/virt TCG guests

2017-05-15 Thread Andrea Bolognani
Changes from v1: * address review comments in 3/5; * all other patches are unchanged. Andrea Bolognani (5): qemu: Use qemuDomainMachineIsVirt() more tests: Check default GIC version for aarch64/virt TCG guests qemu: Use GICv2 for aarch64/virt TCG guests gic: Remove

[libvirt] [PATCH v2 3/5] qemu: Use GICv2 for aarch64/virt TCG guests

2017-05-15 Thread Andrea Bolognani
There are currently some limitations in the emulated GICv3 that make it unsuitable as a default. Use GICv2 instead. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1450433 Signed-off-by: Andrea Bolognani --- src/qemu/qemu_domain.c | 23

[libvirt] [PATCH v2 4/5] gic: Remove VIR_GIC_VERSION_DEFAULT

2017-05-15 Thread Andrea Bolognani
The QEMU default is GICv2, and some of the code in libvirt relies on the exact value. Stop pretending that's not the case and use GICv2 explicitly where needed. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_command.c | 6 +++--- src/qemu/qemu_domain.c | 7 +++

[libvirt] [PATCH v2 5/5] news: Update for GIC version on TCG changes

2017-05-15 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- docs/news.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 2f01449..4cf14b0 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -37,6 +37,17 @@ + + +

[libvirt] [PATCH v2 2/5] tests: Check default GIC version for aarch64/virt TCG guests

2017-05-15 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- .../qemuxml2argv-aarch64-gic-none-tcg.args | 19 .../qemuxml2argv-aarch64-gic-none-tcg.xml | 17 +++ tests/qemuxml2argvtest.c | 3 +++

[libvirt] [PATCH v2 1/5] qemu: Use qemuDomainMachineIsVirt() more

2017-05-15 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- src/qemu/qemu_capabilities.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 71951e6..cf4dc74 100644 --- a/src/qemu/qemu_capabilities.c +++

Re: [libvirt] [PATCH 07/10] apparmor: include local apparmor profiles

2017-05-15 Thread Stefan Bader
On 15.05.2017 16:30, Jamie Strandboge wrote: > On Mon, 2017-05-15 at 09:28 -0500, Jamie Strandboge wrote: >> On Mon, 2017-05-15 at 15:23 +0200, Stefan Bader wrote: >>> From: Felix Geyer >>> >>> Local overrides is a feature Debian/Ubuntu libvirt provided for a while. >>> This

Re: [libvirt] [PATCH 07/10] apparmor: include local apparmor profiles

2017-05-15 Thread Jamie Strandboge
On Mon, 2017-05-15 at 09:28 -0500, Jamie Strandboge wrote: > On Mon, 2017-05-15 at 15:23 +0200, Stefan Bader wrote: > > From: Felix Geyer > > > > Local overrides is a feature Debian/Ubuntu libvirt provided for a while. > > This allows the user to have a non-conffile that he

[libvirt] [PATCH 2/2] qemu: don't relabel chardev source file if virtlogd is used

2017-05-15 Thread Pavel Hrdina
If libvirt uses virtlogd instead of passing the file path directly to QEMU we shouldn't relabel the chardev source file, otherwise virtlogd will get a permission denied while reloading. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=143098 Signed-off-by: Pavel Hrdina

Re: [libvirt] [PATCH 07/10] apparmor: include local apparmor profiles

2017-05-15 Thread Jamie Strandboge
On Mon, 2017-05-15 at 15:23 +0200, Stefan Bader wrote: > From: Felix Geyer > > Local overrides is a feature Debian/Ubuntu libvirt provided for a while. > This allows the user to have a non-conffile that he can use to extend the > package delivered rules with extra content

[libvirt] [PATCH 0/2] fix labeling for chardev source path

2017-05-15 Thread Pavel Hrdina
Pavel Hrdina (2): conf: don't iterate over backcompat console in virDomainChrDefForeach qemu: don't relabel chardev source file if virtlogd is used src/conf/domain_conf.c | 46 - src/conf/domain_conf.h | 1 + src/qemu/qemu_command.c

[libvirt] [PATCH 1/2] conf: don't iterate over backcompat console in virDomainChrDefForeach

2017-05-15 Thread Pavel Hrdina
If the first console is just a copy of the first serial device we don't need to iterate over the same device twice in order to perform actions like security labeling, cgroup configuring, etc. Currently only security SELinux manager was aware of this fact. Signed-off-by: Pavel Hrdina

[libvirt] [PATCH] vz: support virDomainGetBlockInfo in driver

2017-05-15 Thread Nikolay Shirokovskiy
Actually physical size is not available in vz sdk right now so let's set it to allocation as an estimation in non sparse case. --- src/vz/vz_driver.c | 50 ++ src/vz/vz_sdk.c| 23 +++ src/vz/vz_sdk.h| 1 + 3 files

Re: [libvirt] [PATCH 3/5] qemu: Use GICv2 for aarch64/virt TCG guests

2017-05-15 Thread Andrea Bolognani
On Mon, 2017-05-15 at 12:53 +0200, Peter Krempa wrote: > > +/* We want to use the highest available GIC version for guests; > > + * however, the emulated GICv3 is currently lacking a MSI > > controller, > > + * making it unsuitable for the pure PCIe topology we aim for. >

Re: [libvirt] [PATCH] Add support for VNC autoport feature for bhyve hypervisor.

2017-05-15 Thread Roman Bogorodskiy
Alexander Nusov wrote: > On Wed, 10 May 2017 17:58:05 +0300 Roman Bogorodskiy > bogorods...@gmail.com wrote > > > > Alexander Nusov wrote: > > > > This patch adds support for automatic VNC port assignment for bhyve > guests. > > > > --- > > src/bhyve/bhyve_command.c

[libvirt] [PATCH 10/10] apparmor, libvirt-qemu: Add ppc related changes

2017-05-15 Thread Stefan Bader
From: Serge Hallyn Updates profile to allow running on ppc64el. Bug-Ubuntu: https://bugs.launchpad.net/bugs/1374554 Signed-off-by: Christian Ehrhardt Signed-off-by: Stefan Bader ---

[libvirt] [PATCH 02/10] apparmor, virt-aa-helper: allow /usr/share/OVMF/ too

2017-05-15 Thread Stefan Bader
From: Simon McVittie The split firmware and variables files introduced by https://bugs.debian.org/764918 are in a different directory for some reason. Let the virtual machine read both. Extended by Christian Ehrhardt to generalize FW test (simplifies additional testing on

[libvirt] [PATCH 08/10] apparmor: provide local override templates

2017-05-15 Thread Stefan Bader
Local overrides is a feature Debian/Ubuntu libvirt provided for a while. This allows the user to have a non-conffile that he can use to extend the package delivered rules with extra content matching his special case. This change provides override templates which the user can extend and modifies

[libvirt] [PATCH 03/10] apparmor, virt-aa-helper: Allow aarch64 UEFI.

2017-05-15 Thread Stefan Bader
From: William Grant Allow access to aarch64 UEFI images. Signed-off-by: Christian Ehrhardt Signed-off-by: Stefan Bader --- examples/apparmor/libvirt-qemu | 2 ++ src/security/virt-aa-helper.c | 4 +++-

[libvirt] [PATCH 09/10] appmor, virt-aa-helper: Add 9p support

2017-05-15 Thread Stefan Bader
From: Serge Hallyn Add fowner and fsetid to libvirt-qemu profile and add link to 9p file options in virt-aa-helper. Bug-Ubuntu: https://bugs.launchpad.net/bugs/1378434 Signed-off-by: Christian Ehrhardt Signed-off-by: Stefan Bader

[libvirt] [PATCH 04/10] apparmor, virt-aa-helper: Allow access to libnl-3 config files

2017-05-15 Thread Stefan Bader
From: Felix Geyer Allow access to libnl-3 config files Signed-off-by: Christian Ehrhardt Signed-off-by: Stefan Bader --- examples/apparmor/usr.lib.libvirt.virt-aa-helper | 2 ++ 1 file changed, 2 insertions(+)

[libvirt] [PATCH 06/10] apparmor, virt-aa-helper: Additional explicit denies for host devices

2017-05-15 Thread Stefan Bader
From: Christian Ehrhardt This adds further explicit denies for host devices to silence (acceptable) denial warnings. Signed-off-by: Christian Ehrhardt Signed-off-by: Stefan Bader ---

[libvirt] [PATCH 07/10] apparmor: include local apparmor profiles

2017-05-15 Thread Stefan Bader
From: Felix Geyer Local overrides is a feature Debian/Ubuntu libvirt provided for a while. This allows the user to have a non-conffile that he can use to extend the package delivered rules with extra content matching his special case. This change adds the include directives

[libvirt] [PATCH 01/10] virt-aa-helper: Ask for no deny rule for readonly disk elements

2017-05-15 Thread Stefan Bader
From: Serge Hallyn Just because a disk element only requests read access doesn't mean there may not be another readwrite request. Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/bugs/1554031 Signed-off-by: Christian Ehrhardt

[libvirt] [PATCH 05/10] apparmor, virt-aa-helper: Explicit denies for host devices

2017-05-15 Thread Stefan Bader
From: Felix Geyer Add explicit denies for disk devices to avoid cluttering dmesg with (acceptable) denials. Signed-off-by: Christian Ehrhardt Signed-off-by: Stefan Bader ---

[libvirt] Various apparmor related changes (part 1)

2017-05-15 Thread Stefan Bader
Over the years there have been a bunch of changes to the apparmor profiles and/or virt-aa-helper which have been carried in Debian/Ubuntu but never made it upstream. In an attempt to clean this up and generally improve the apparmor based environments, we (Christian and I) went over the changes,

Re: [libvirt] [PATCHv4 8/6] conf: add ABI stability checks for IOMMU options

2017-05-15 Thread Peter Krempa
On Fri, May 12, 2017 at 17:08:50 +0200, Ján Tomko wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1427005 > --- > src/conf/domain_conf.c | 26 ++ > 1 file changed, 26 insertions(+) ACK signature.asc Description: PGP signature -- libvir-list mailing list

Re: [libvirt] [PATCHv4 7/6] conf: split out virDomainIOMMUDefCheckABIStability

2017-05-15 Thread Peter Krempa
On Fri, May 12, 2017 at 17:08:33 +0200, Ján Tomko wrote: > --- > src/conf/domain_conf.c | 24 +--- > 1 file changed, 17 insertions(+), 7 deletions(-) ACK signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] libvirt-python RPM installation not recognized by pip

2017-05-15 Thread Daniel P. Berrange
On Mon, May 15, 2017 at 02:52:07PM +0200, Martin Kletzander wrote: > On Mon, May 15, 2017 at 07:35:30AM -0400, Cleber Rosa wrote: > > Hello, > > > > When using the standard "requirements.txt" files for installation > > package dependencies, I noticed that "libvirt-python" would attempt to > > be

Re: [libvirt] libvirt-python RPM installation not recognized by pip

2017-05-15 Thread Martin Kletzander
On Mon, May 15, 2017 at 07:35:30AM -0400, Cleber Rosa wrote: Hello, When using the standard "requirements.txt" files for installation package dependencies, I noticed that "libvirt-python" would attempt to be installed by "pip" even when the equivalent RPM package is already installed. For

[libvirt] [PATCH] docs: Update pointer to networking information

2017-05-15 Thread Andrea Bolognani
Commit 6fb5dd4fd804 removed docs/archnetwork.html.in, but left behind a pointer to it in docs/formatnetwork.html.in. Update it so that it points to the wiki, which contains more detailed and recent information anyway. --- docs/formatnetwork.html.in | 6 +++--- 1 file changed, 3 insertions(+), 3

[libvirt] [PATCH v4 6/6] docs: Document the mediated devices within the nodedev driver

2017-05-15 Thread Erik Skultety
Signed-off-by: Erik Skultety --- docs/drvnodedev.html.in | 168 +++- tools/virsh.pod | 7 +- 2 files changed, 171 insertions(+), 4 deletions(-) diff --git a/docs/drvnodedev.html.in b/docs/drvnodedev.html.in index

[libvirt] [PATCH v4 1/6] mdev: Pass a uuidstr rather than an mdev object to some util functions

2017-05-15 Thread Erik Skultety
Namely, this patch is about virMediatedDeviceGetIOMMUGroup{Dev,Num} functions. There's no compelling reason why these functions should take an object, on the contrary, having to create an object every time one needs to query the IOMMU group number, discarding the object afterwards, seems odd.

[libvirt] [PATCH v4 5/6] nodedev: Introduce mdev capability for mediated devices

2017-05-15 Thread Erik Skultety
Start discovering the mediated devices on the host system and format the attributes for the mediated device into the XML. Compared to the parent device which reports generic information about the abstract mediated devices types, a child device only reports the type name it has been instantiated

[libvirt] [PATCH v4 3/6] nodedev: Introduce new mdev_types and mdev nodedev capabilities

2017-05-15 Thread Erik Skultety
The reason for introducing two capabilities, one for the device itself (cap 'mdev') and one for the parent device listing the available types ('mdev_types'), is that we should be able to do 'virsh nodedev-list --cap' not only for existing mdev devices but also for devices that support creation of

[libvirt] [PATCH v4 4/6] nodedev: Introduce the mdev capability to a PCI parent device

2017-05-15 Thread Erik Skultety
The parent device needs to report the generic stuff about the supported mediated devices types, like device API, available instances, type name, etc. Therefore this patch introduces a new nested capability element of type 'mdev_types' with the resulting XML of the following format: ...

[libvirt] [PATCH v4 0/6] Add mdev reporting capability to the nodedev driver

2017-05-15 Thread Erik Skultety
since v1: - dropped the element from the parent device nested capability - added missing RNG schema and tests - updated the documentation to describe the MDEV elements in both the parent and the child since v2: - I further split our PCI sub-capability parser into more blocks as suggested -

[libvirt] [PATCH v4 2/6] nodedev: conf: Split PCI sub-capability parsing to separate methods

2017-05-15 Thread Erik Skultety
Since there's at least SRIOV and MDEV sub-capabilities to be parsed, let's make the code more readable by splitting it to several logical blocks. Signed-off-by: Erik Skultety --- src/conf/node_device_conf.c | 142 ++-- 1 file changed,

[libvirt] libvirt-python RPM installation not recognized by pip

2017-05-15 Thread Cleber Rosa
Hello, When using the standard "requirements.txt" files for installation package dependencies, I noticed that "libvirt-python" would attempt to be installed by "pip" even when the equivalent RPM package is already installed. For instance, on a Fedora 25 system: $ rpm -q libvirt-python

Re: [libvirt] [PATCH v2] storage: use 0711 as the default perms for dirs

2017-05-15 Thread Christian Ehrhardt
On Mon, May 15, 2017 at 1:10 PM, Daniel P. Berrange wrote: > BTW, for libvir-list we recommend to send v2/v3/etc followup patches as > top level threads, not in-reply-to the previous versions. > I need a mapper which project prefers what :-), no really - thank you a lot!

Re: [libvirt] [PATCHv4 1/6] conf: add to

2017-05-15 Thread Andrea Bolognani
On Fri, 2017-05-12 at 16:42 +0200, Ján Tomko wrote: > Re: x86-only: would squashing this in do? Yup, looks reasonable enough :) -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2] storage: use 0711 as the default perms for dirs

2017-05-15 Thread Daniel P. Berrange
On Mon, May 15, 2017 at 01:05:31PM +0200, Christian Ehrhardt wrote: > From: Serge Hallyn > > There should be no need to make dir based pools world/group readable. > So use 0711, not 0755, as the default perms for storage dirs. > > Updates in v2: > - adapt commit

[libvirt] [PATCH v2] storage: use 0711 as the default perms for dirs

2017-05-15 Thread Christian Ehrhardt
From: Serge Hallyn There should be no need to make dir based pools world/group readable. So use 0711, not 0755, as the default perms for storage dirs. Updates in v2: - adapt commit wording to mention dropping group readable as well Signed-off-by: Christian Ehrhardt

Re: [libvirt] [PATCH] storage: use 0711 as the default perms for dirs

2017-05-15 Thread Christian Ehrhardt
On Fri, May 12, 2017 at 12:36 AM, John Ferlan wrote: > Also your commit message notes "world readable", but by going from 755 > to 711, you're also changing to "group readable" too ;-) > Good catch John, the other feedback seems good, so for now I'm just rewording in regard

Re: [libvirt] [PATCH] storage: use 0711 as the default perms for dirs

2017-05-15 Thread Christian Ehrhardt
On Mon, May 15, 2017 at 10:27 AM, Daniel P. Berrange wrote: > > Kinda surprised this didn't generate some immediate discussion... I > > would also think that if you had a desire to change defaults you'd also > > have a libvirt.spec.in adjustment... > > Actually no it

Re: [libvirt] [PATCH 5/5] news: Update for GIC version on TCG changes

2017-05-15 Thread Peter Krempa
On Fri, May 12, 2017 at 16:14:47 +0200, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > docs/news.xml | 11 +++ > 1 file changed, 11 insertions(+) ACK signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] storage: use 0711 as the default perms for dirs

2017-05-15 Thread Martin Kletzander
On Mon, May 15, 2017 at 09:27:38AM +0100, Daniel P. Berrange wrote: On Thu, May 11, 2017 at 06:36:22PM -0400, John Ferlan wrote: On 05/11/2017 04:31 AM, Christian Ehrhardt wrote: > From: Serge Hallyn > > There should be no need to make dir based pools world readable.

Re: [libvirt] [PATCH 4/5] gic: Remove VIR_GIC_VERSION_DEFAULT

2017-05-15 Thread Peter Krempa
On Fri, May 12, 2017 at 16:14:46 +0200, Andrea Bolognani wrote: > The QEMU default is GICv2, and some of the code in libvirt > relies on the exact value. Stop pretending that's not the > case and use GICv2 explicitly where needed. > > Signed-off-by: Andrea Bolognani > --- >

Re: [libvirt] [PATCH 3/5] qemu: Use GICv2 for aarch64/virt TCG guests

2017-05-15 Thread Peter Krempa
On Fri, May 12, 2017 at 16:14:45 +0200, Andrea Bolognani wrote: > There are currently some limitations in the emulated GICv3 > that make it unsuitable as a default. Use GICv2 instead. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1450433 > > Signed-off-by: Andrea Bolognani

Re: [libvirt] [PATCH 2/5] tests: Check default GIC version for aarch64/virt TCG guests

2017-05-15 Thread Peter Krempa
On Fri, May 12, 2017 at 16:14:44 +0200, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > .../qemuxml2argv-aarch64-gic-none-tcg.args | 19 > .../qemuxml2argv-aarch64-gic-none-tcg.xml | 17 +++ >

Re: [libvirt] [PATCH 1/5] qemu: Use qemuDomainMachineIsVirt() more

2017-05-15 Thread Peter Krempa
On Fri, May 12, 2017 at 16:14:43 +0200, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > src/qemu/qemu_capabilities.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) ACK signature.asc Description: PGP signature -- libvir-list mailing list

Re: [libvirt] [PATCH v2 3/3] qemu: improve detection of UNIX path generated by libvirt

2017-05-15 Thread Martin Kletzander
On Fri, May 12, 2017 at 04:45:11PM +0200, Pavel Hrdina wrote: On Fri, May 12, 2017 at 04:26:35PM +0200, Martin Kletzander wrote: On Fri, May 12, 2017 at 02:57:56PM +0200, Pavel Hrdina wrote: >Currently we consider all UNIX paths with specific prefix as generated >by libvirt, but that's a wrong

[libvirt] [PATCH] maint: update to latest gnulib

2017-05-15 Thread Daniel P. Berrange
This pulls in the fixes for poll() on Win32 which finally makes the remote driver work again. Signed-off-by: Daniel P. Berrange --- .gnulib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gnulib b/.gnulib index 94386a1..da830b5 16 --- a/.gnulib +++

Re: [libvirt] [PATCH v2 11/38] Introduce virStreamSkip

2017-05-15 Thread Michal Privoznik
On 05/15/2017 10:56 AM, Daniel P. Berrange wrote: > On Mon, May 15, 2017 at 10:54:03AM +0200, Michal Privoznik wrote: > >> Now, question is whether we want signed or unsigned long long. I don't >> have an opinion about that. On one hand, off_t is signed, but that's >> because lseek() can seek

Re: [libvirt] [PATCH v2 11/38] Introduce virStreamSkip

2017-05-15 Thread Daniel P. Berrange
On Mon, May 15, 2017 at 10:54:03AM +0200, Michal Privoznik wrote: > On 05/15/2017 10:25 AM, Daniel P. Berrange wrote: > > On Fri, May 12, 2017 at 09:29:27AM +0200, Michal Privoznik wrote: > >> On 05/05/2017 04:48 PM, Daniel P. Berrange wrote: > >>> On Fri, May 05, 2017 at 01:25:34PM +0200, Michal

Re: [libvirt] [PATCH v2 11/38] Introduce virStreamSkip

2017-05-15 Thread Michal Privoznik
On 05/15/2017 10:25 AM, Daniel P. Berrange wrote: > On Fri, May 12, 2017 at 09:29:27AM +0200, Michal Privoznik wrote: >> On 05/05/2017 04:48 PM, Daniel P. Berrange wrote: >>> On Fri, May 05, 2017 at 01:25:34PM +0200, Michal Privoznik wrote: On 05/04/2017 11:29 PM, John Ferlan wrote: >

Re: [libvirt] [PATCH] RFE: virsh: add domxml-to-native [--domain DOMAIN] option

2017-05-15 Thread Dan
On Mon, Apr 24, 2017 at 09:17:12AM +0200, Peter Krempa wrote: > On Sun, Apr 23, 2017 at 20:54:47 -0400, Dan wrote: > > Please use your full name for patch submissions. > I just did a new send-email patch submission to the list. Hopefully it corrected my previous mistakes. > > Bug 835476 RFE:

[libvirt] [PATCH] virsh: add --domain option for domain-to-native

2017-05-15 Thread Daniel Liu
Fix bug 835476[1]. virsh: add [--domain DOMAIN] option to domxml-to-native DOMAIN COMMAND Add support for the following syntax: domxml-to-native { [--domain DOMAIN] | [XML] }, i.e., it supports either designating domain (domain id, uuid, or name), or path to XML domain configuration file. E.g.:

Re: [libvirt] [PATCH] storage: use 0711 as the default perms for dirs

2017-05-15 Thread Daniel P. Berrange
On Thu, May 11, 2017 at 06:36:22PM -0400, John Ferlan wrote: > > > On 05/11/2017 04:31 AM, Christian Ehrhardt wrote: > > From: Serge Hallyn > > > > There should be no need to make dir based pools world readable. > > So use 0711, not 0755, as the default perms for

Re: [libvirt] [PATCH v2 11/38] Introduce virStreamSkip

2017-05-15 Thread Daniel P. Berrange
On Fri, May 12, 2017 at 09:29:27AM +0200, Michal Privoznik wrote: > On 05/05/2017 04:48 PM, Daniel P. Berrange wrote: > > On Fri, May 05, 2017 at 01:25:34PM +0200, Michal Privoznik wrote: > >> On 05/04/2017 11:29 PM, John Ferlan wrote: > >>> > >>> > >>> On 04/20/2017 06:01 AM, Michal Privoznik

Re: [libvirt] [PATCH] util: conf: Don't log when adding commented out lines

2017-05-15 Thread Peter Krempa
On Fri, May 12, 2017 at 16:43:05 +0200, Martin Kletzander wrote: > On Fri, May 12, 2017 at 04:33:29PM +0200, Peter Krempa wrote: > > virConfAddEntry spams debug logs even for fully commented out lines. > > Skip such messages to avoid: > > > > 2017-05-12 12:35:38.867+: 10820: debug :