Re: [libvirt] libvirt binding for Rust

On Tue, Jun 06, 2017 at 12:19:21PM +0200, Sahid Orentino Ferdjaoui wrote: > Hello, > > I started a work on a libvirt binding for Rust [0]. Not all of the API > is implemeted but I think it's now in a usable state. > > https://docs.rs/crate/virt > https://github.com/sahid/libvirt-rs > > The

Re: [libvirt] More CI options

On Tue, Jun 06, 2017 at 10:09:00PM +0200, Martin Kletzander wrote: > Since the addition of Travis CI builds, there is some more progress > towards more testing. I was just wondering if anyone was thinking about > (or is already working on) some settings for other CI environments as > well. For

Re: [libvirt] Remotable Libvirt

On Tue, Jun 06, 2017 at 01:25:08PM -0400, Stef Walter wrote: > On 06.06.2017 12:13, Daniel P. Berrange wrote: > > On Tue, Jun 06, 2017 at 06:07:21PM +0200, Stef Walter wrote: > >> So to summarize what I'm hearing here: > >> > >> * There is no libvirt remotable API today. > > > > Libvirt drivers

[libvirt] More CI options

Since the addition of Travis CI builds, there is some more progress towards more testing. I was just wondering if anyone was thinking about (or is already working on) some settings for other CI environments as well. For example if configured AppVeyor, we could have MSVC builds as well. And

Re: [libvirt] [PATCH] qemu: Starting a domain with custom model andallowed-fallback failed when host lacks some CPU features

On Wed, Jun 07, 2017 at 02:52:05 +0800, wang.y...@zte.com.cn wrote: > But in the condition I described, libvirt has no chance to translate > into a different model It doesn't need to translate the CPU model because QEMU supports core2duo CPU model. It's hard to imagine with such an ancient CPU

Re: [libvirt] [PATCH] qemu: Starting a domain with custom model andallowed-fallback failed when host lacks some CPU features

Hi Jirka,Thanks for your reviewing. But in the condition I described, libvirt has no chance to translate into a different model, because it has failed in the virCPUCompare before translate and the start of the domain will report the error, it that correct? For example, a host lacks "monitor"

Re: [libvirt] [PATCH] qemu: Starting a domain with custom model and allowed-fallback failed when host lacks some CPU features

On Tue, Jun 06, 2017 at 12:23:01 -0400, Yi Wang wrote: > An attemp to start a domain requesting a custom CPU model, core2duo, for > example, will fail if some feature that the model needs doesn't exist in that > host, even though fallback attibute is set allow: > "error: the CPU is incompatible

Re: [libvirt] [PATCH 11/15] qemu: Remember CPU def from domain start

On Mon, Jun 05, 2017 at 11:26:59AM +0200, Jiri Denemark wrote: > When starting a domain we update the guest CPU definition to match what > QEMU actually provided (since it is allowed to add or removed some > features unless check='full' is specified). Let's store the original CPU > in domain

[libvirt] [PATCH] qemu: Starting a domain with custom model and allowed-fallback failed when host lacks some CPU features

An attemp to start a domain requesting a custom CPU model, core2duo, for example, will fail if some feature that the model needs doesn't exist in that host, even though fallback attibute is set allow: "error: the CPU is incompatible with host CPU: Host CPU does not provide required features:

[libvirt] [PATCH 2/2] virsh: Add support for VIR_DOMAIN_BLOCK_COPY_TRANSIENT_JOB

Allow using the new flag with virsh. --- tools/virsh-domain.c | 10 +- tools/virsh.pod | 4 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index ccb514ef9..f39589c20 100644 --- a/tools/virsh-domain.c +++

Re: [libvirt] [PATCH 10/15] qemu: Store save cookie in save images and snapshots

On Mon, Jun 05, 2017 at 11:26:58AM +0200, Jiri Denemark wrote: > The following patches will add an actual content in the cookie and use > the data when restoring a domain. > > Signed-off-by: Jiri Denemark > --- > docs/formatsnapshot.html.in | 6 +++ >

[libvirt] [PATCH 1/2] util: share code between virExec and virCommandExec

virCommand is a version of virExec that doesn't fork, however it is just calling execve and doesn't honors setting uid/gid and pwd. This commit extrac those pieces from virExec() to a virExecCommon() function that is called from both virExec() and virCommandExec(). --- src/util/vircommand.c | 69

Re: [libvirt] [PATCH 09/15] qemu: Implement virSaveCookie object and callbacks

On Mon, Jun 05, 2017 at 11:26:57AM +0200, Jiri Denemark wrote: > This patch implements a new save cookie object and callbacks for qemu > driver. The actual useful content will be added in the object later. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_conf.c | 2

Re: [libvirt] [PATCH 08/15] conf: Add save cookie callbacks to xmlopt

On Mon, Jun 05, 2017 at 11:26:56AM +0200, Jiri Denemark wrote: > virDomainXMLOption gains driver specific callbacks for parsing and > formatting save cookies. > > Signed-off-by: Jiri Denemark > --- > src/bhyve/bhyve_domain.c | 2 +- > src/conf/domain_conf.c|

[libvirt] [PATCHv2 14/15] qemuxml2argvtest: add virtio-options test case

Add a test case to demonstrate the addition of new command line options https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- .../qemuxml2argv-virtio-options.args | 47 ++ tests/qemuxml2argvtest.c | 9 + 2 files changed, 56

Re: [libvirt] [PATCH 07/15] conf: Introduce virSaveCookie

On Mon, Jun 05, 2017 at 11:26:55AM +0200, Jiri Denemark wrote: > The code will be used by snapshots and domain save/restore code to store > additional data for a saved running domain. It is analogous to migration > cookies, but simple and one way only. > > Signed-off-by: Jiri Denemark

[libvirt] [PATCHv2 11/15] Add virtio-related options to rng devices

https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- docs/formatdomain.html.in| 11 +++ docs/schemas/domaincommon.rng| 5 + src/conf/domain_conf.c | 16

[libvirt] [PATCH] virNetClientStreamQueuePacket: Set st->incomingEOF on the end of stream

While reworking client side of streams, I had to postpone payload decoding so that stream holes and stream data can be distinguished in virNetClientStreamRecvPacket. That's merely what 18944b7aea46d does. However, I accidentally removed one important bit: when server sends us an empty STREAM

[libvirt] [PATCHv2 05/15] qemuxml2xmltest: add virtio-options test

Add a test case with all the virtio devices we know to demonstrate the addition of new options. https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- .../qemuxml2argv-virtio-options.xml| 92 ++ .../qemuxml2xmlout-virtio-options.xml | 92

[libvirt] [PATCHv2 00/15] Allow virtio devices to use vIOMMU

https://bugzilla.redhat.com/show_bug.cgi?id=1283251 Ján Tomko (15): conf: eliminate monster condition in virDomainControllerDefFormat virDomainControllerDefFormat: do not mix attributes and subelements conf: add device_iotlb attribute to iommu qemu: format device-iotlb on intel-iommu

[libvirt] libvirt binding for Rust

Hello, I started a work on a libvirt binding for Rust [0]. Not all of the API is implemeted but I think it's now in a usable state. https://docs.rs/crate/virt https://github.com/sahid/libvirt-rs The code is licensed under LGPL-2.1, it's tested by a CI running libvirt 1.2.0, 2.5.0, 3.3.0.

[libvirt] [PATCH] qemu: Allow memAccess for hugepages again

https://bugzilla.redhat.com/show_bug.cgi?id=1458638 Historically, we've always supported memAccess for domains backed by hugepages. However, somewhere along the way we've regressed and stopped allowing such configuration. Fix it. Signed-off-by: Michal Privoznik ---

Re: [libvirt] libvirt builds failing on fedora-rawhide

On Mon, Jun 05, 2017 at 04:22:41PM -0400, Yash Mankad wrote: Hi, The libvirt-master-build on ci.c.o seems to be failing on the fedora-rawhide slave since Friday. This seems to be the commit/build that is causing it to fail. Looks like gnulib+glibc issue with header names and macros:

[libvirt] [PATCH go-xml] 1,rename DomainInterfaceBoot to DomainDeviceBoot; 2,support disk boot order

--- domain.go | 5 +++-- domain_test.go | 6 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/domain.go b/domain.go index 1d91dc3..7d8f6d6 100644 --- a/domain.go +++ b/domain.go @@ -98,6 +98,7 @@ type DomainDisk struct { ReadOnly *DomainDiskReadOnly

Re: [libvirt] [PATCH] lxc: allow defining environment variables

On Mon, 2017-06-05 at 15:23 +0100, Daniel P. Berrange wrote: > On Tue, May 30, 2017 at 09:32:43PM +0200, Cédric Bosdonnat wrote: > > When running an application container, setting environment variables > > could be important. > > > > The newly introduced tag in domain configuration will allow >

Re: [libvirt] [PATCH 02/15] conf: Refactor virCPUDefParseXML

On Mon, Jun 05, 2017 at 11:26:50AM +0200, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > src/conf/cpu_conf.c| 105 > +++-- > src/conf/cpu_conf.h| 9 +++-- > src/conf/domain_conf.c | 12 +- >

Re: [libvirt] libvirt builds failing on fedora-rawhide

On 06/05/2017 04:22 PM, Yash Mankad wrote: > Hi, > > The libvirt-master-build on ci.c.o seems to be failing on > the fedora-rawhide slave since Friday. > > This seems to be the commit/build that is causing it to fail. > > Commit ed914284ba74afb7dd16dcb623073bb1a1d5cd21 by pkrempa >

Re: [libvirt] Remotable Libvirt

On 06.06.2017 12:13, Daniel P. Berrange wrote: > On Tue, Jun 06, 2017 at 06:07:21PM +0200, Stef Walter wrote: >> On 06.06.2017 17:17, Daniel P. Berrange wrote: >>> On Tue, Jun 06, 2017 at 05:11:55PM +0200, Peter Krempa wrote: On Tue, Jun 06, 2017 at 07:45:10 -0700, Peter wrote: > On

Re: [libvirt] [PATCH v4 2/3] interface: Consume @def in virInterfaceObjNew

On Sat, Jun 03, 2017 at 06:53:22AM -0400, John Ferlan wrote: > Move the consumption of @def in virInterfaceObjNew and then handle that > in the error path of virInterfaceObjListAssignDef since it's caller expects > to need to free @def when NULL is returned and so would virInterfaceObjFree. > >

Re: [libvirt] [PATCH v2 5/8] util: Introduce virObjectPoolableHashElement

On Mon, Jun 05, 2017 at 09:10:00 -0400, John Ferlan wrote: > On 06/05/2017 08:25 AM, Peter Krempa wrote: > > On Fri, Jun 02, 2017 at 06:17:19 -0400, John Ferlan wrote: > >> Add a new virObjectLockable child which will be used to more generically > >> describe driver objects. Eventually these

Re: [libvirt] [PATCH] virFDStreamThread: Make sure we won't exceed @length

On 06/05/2017 06:53 AM, Michal Privoznik wrote: There's a problem with current streams after I switched them from iohelper to thread implementation. Previously, iohelper made sure not to exceed specified @length resulting in the pipe EOF appearing at the exact right moment (the pipe was used to

[libvirt] [PATCH] qemu: Set operation on completed migration job

Without this patch libvirt would just report the operation of a completed job as "unknown" instead of "incoming migration". https://bugzilla.redhat.com/show_bug.cgi?id=1457052 Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration_cookie.c | 4 1 file changed, 4

Re: [libvirt] [PATCH] Reset the whole stack in testutils

On Mon, Jun 05, 2017 at 10:02:17AM +0100, Daniel P. Berrange wrote: On Mon, Jun 05, 2017 at 10:01:10AM +0200, Martin Kletzander wrote: The memset() was resetting only 30 bytes in the array (size of the array), but it is array of pointers. Since it is a static array, let's just reset it by its

Re: [libvirt] [PATCH v2 7/8] util: Introduce virObjectPoolableDef

On Fri, Jun 02, 2017 at 06:17:21 -0400, John Ferlan wrote: > Add a new virObjectPoolableHashElement child which will be used to provide > the basis for driver def/newDef elements. > > Each virObjectPoolableDef has: > > 1. A required @primaryKey to be used to uniquely identity the object >

Re: [libvirt] [PATCH v2 5/8] util: Introduce virObjectPoolableHashElement

On Fri, Jun 02, 2017 at 06:17:19 -0400, John Ferlan wrote: > Add a new virObjectLockable child which will be used to more generically > describe driver objects. Eventually these objects will be placed into a > more generic hash table object which will take care of object mgmt functions. > > Each

Re: [libvirt] [PATCH go-xml] add emulator supported

On Sat, Jun 03, 2017 at 09:30:00AM +0800, zhenwei.pi wrote: > --- > domain.go | 1 + > domain_test.go | 6 ++ > 2 files changed, 7 insertions(+) > > diff --git a/domain.go b/domain.go > index dcb8f65..723e761 100644 > --- a/domain.go > +++ b/domain.go > @@ -307,6 +307,7 @@ type

Re: [libvirt] [PATCH v2 4/8] util: Add safety net of checks to ensure valid object

On 06/05/2017 03:35 AM, Peter Krempa wrote: > On Fri, Jun 02, 2017 at 06:17:18 -0400, John Ferlan wrote: >> The virObject logic "assumes" that whatever is passed to its API's >> would be some sort of virObjectPtr; however, if it is not then some >> really bad things can happen. >> >> So far

[libvirt] [PATCH 12/15] qemu: Report the original CPU in migratable xml

The destination host may not be able to start a domain using the live updated CPU definition because either libvirt or QEMU may not be new enough. Thus we need to send the original guest CPU definition. Signed-off-by: Jiri Denemark --- src/qemu/qemu_domain.c| 61

[libvirt] [PATCH] bhyveargv2xmltest: Fix call of virDomainDefCheckABIStability

In 4f0aeed I've expanded the list of arguments for virDomainDefCheckABIStability() but I forgot to fix bhyveargv2xmltest. Signed-off-by: Michal Privoznik --- Pushed under trivial and build-breaker rules. tests/bhyveargv2xmltest.c | 2 +- 1 file changed, 1 insertion(+), 1

[libvirt] [PATCH 11/15] qemu: Remember CPU def from domain start

When starting a domain we update the guest CPU definition to match what QEMU actually provided (since it is allowed to add or removed some features unless check='full' is specified). Let's store the original CPU in domain private data so that we can use it to provide a backward compatible domain

[libvirt] [PATCH 02/15] conf: Refactor virCPUDefParseXML

Signed-off-by: Jiri Denemark --- src/conf/cpu_conf.c| 105 +++-- src/conf/cpu_conf.h| 9 +++-- src/conf/domain_conf.c | 12 +- src/cpu/cpu.c | 5 +-- tests/cputest.c| 5 +-- 5 files changed, 68

[libvirt] [PATCH 08/15] conf: Add save cookie callbacks to xmlopt

virDomainXMLOption gains driver specific callbacks for parsing and formatting save cookies. Signed-off-by: Jiri Denemark --- src/bhyve/bhyve_domain.c | 2 +- src/conf/domain_conf.c| 16 +++- src/conf/domain_conf.h| 7 ++-

[libvirt] [PATCH 03/15] conf: Make virDomainSnapshotDefFormat easier to read

Signed-off-by: Jiri Denemark --- src/conf/snapshot_conf.c | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c index b6cba5ac3..7daa9b22a 100644 --- a/src/conf/snapshot_conf.c

[libvirt] [PATCH 04/15] conf: Pass xmlopt to virDomainSnapshotDefFormat

Signed-off-by: Jiri Denemark --- Notes: I know the line in vbox_common.c is too long, but I don't really want to touch that horrible piece of code more than making it compile. src/conf/snapshot_conf.c | 1 + src/conf/snapshot_conf.h | 1 +

[libvirt] [PATCH 10/15] qemu: Store save cookie in save images and snapshots

The following patches will add an actual content in the cookie and use the data when restoring a domain. Signed-off-by: Jiri Denemark --- docs/formatsnapshot.html.in | 6 +++ docs/schemas/domainsnapshot.rng | 7 src/qemu/qemu_driver.c | 90

[libvirt] [PATCH 00/15] Fix regression caused by recent CPU driver changes

https://bugzilla.redhat.com/show_bug.cgi?id=1441662 when I was enhancing libvirt's guest CPU configuration code to be able to really ensure stable guest CPU ABI, I added a new attribute //cpu/@check which is nicely backward compatible... an old libvirt will just ignore it. However, even if

Re: [libvirt] [PATCH 2/3] remote: Consolidate remoteStream{Abort, Finish} functions

On 06/01/2017 02:08 PM, Martin Kletzander wrote: > They do the same thing with only one difference. Let's put them > together (like we already do with virFDStreamCloseInt) so that future > changes don't miss one of the implementations. Also to clean up the > code. > > Signed-off-by: Martin

[libvirt] [PATCH v3 3/6] virStream*All: Call virStreamAbort() more frequently

Our documentation to all four virStreamRecvAll, virStreamSendAll, virStreamSparseRecvAll, virStreamSparseSendAll says that if these functions fail, virStreamAbort() is called. But that is not necessarily true. For instance all of these functions allocate a buffer to work with. If the allocation

[libvirt] [PATCH v3 5/6] virFileInData: preserve errno in cleanup path

Callers might be interested in the original value of errno. Let's not overwrite it with lseek() done in cleanup path. Signed-off-by: Michal Privoznik --- src/util/virfile.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/util/virfile.c

Re: [libvirt] [V4 RESEND PATCH] Expose resource control capabilites on cache bank

> > > > This could be wrong on new platform in Intel’s SKX CPU after check with > > platform guys. > > > > The cbm_mask is “7ff” (11 bits) on SKX. I will refine this by counting the > > bits. > > > > We can virFileReadValueString() then convert it to unsigned int, then count > > the bits

Re: [libvirt] [PATCH v2 4/8] util: Add safety net of checks to ensure valid object

On Fri, Jun 02, 2017 at 06:17:18 -0400, John Ferlan wrote: > The virObject logic "assumes" that whatever is passed to its API's > would be some sort of virObjectPtr; however, if it is not then some > really bad things can happen. > > So far there's been only virObject{Ref|Unref},

Re: [libvirt] [PATCH v2 1/8] util: Formatting cleanups to virobject API

On Fri, Jun 02, 2017 at 06:17:15 -0400, John Ferlan wrote: > Alter to use more recent formatting guidelines > > Signed-off-by: John Ferlan > --- > src/util/virobject.c | 64 > ++-- > src/util/virobject.h | 59

Re: [libvirt] [PATCH] docs: correct improper information about domain states in virsh manpage

On Tue, 2017-06-06 at 12:12 -0400, Laine Stump wrote: > Commit 24d4a0a1f removed the non-existent "dying" state from the list > of possible domain states given in the virsh manpage, but didn't > correct the count of states from 8 down to 7. This patch fixes that > mismatch, while wording the

Re: [libvirt] Remotable Libvirt

On Tue, Jun 06, 2017 at 06:07:21PM +0200, Stef Walter wrote: > On 06.06.2017 17:17, Daniel P. Berrange wrote: > > On Tue, Jun 06, 2017 at 05:11:55PM +0200, Peter Krempa wrote: > >> On Tue, Jun 06, 2017 at 07:45:10 -0700, Peter wrote: > >>> On 05/26/2017 02:11 AM, Martin Kletzander wrote: > On

[libvirt] [PATCH] docs: correct improper information about domain states in virsh manpage

Commit 24d4a0a1f removed the non-existent "dying" state from the list of possible domain states given in the virsh manpage, but didn't correct the count of states from 8 down to 7. This patch fixes that mismatch, while wording the sentence in a more readable/truthful manner. --- tools/virsh.pod |

Re: [libvirt] Remotable Libvirt

On 06.06.2017 17:17, Daniel P. Berrange wrote: > On Tue, Jun 06, 2017 at 05:11:55PM +0200, Peter Krempa wrote: >> On Tue, Jun 06, 2017 at 07:45:10 -0700, Peter wrote: >>> On 05/26/2017 02:11 AM, Martin Kletzander wrote: On Thu, May 25, 2017 at 10:16:26AM -0700, Peter Volpe wrote: >> >> [...]

Re: [libvirt] Remotable Libvirt

On Tue, Jun 06, 2017 at 05:11:55PM +0200, Peter Krempa wrote: > On Tue, Jun 06, 2017 at 07:45:10 -0700, Peter wrote: > > On 05/26/2017 02:11 AM, Martin Kletzander wrote: > > > On Thu, May 25, 2017 at 10:16:26AM -0700, Peter Volpe wrote: > > [...] > > > > If we standardize even the smallest part

Re: [libvirt] Remotable Libvirt

On 06/06/2017 08:11 AM, Peter Krempa wrote: On Tue, Jun 06, 2017 at 07:45:10 -0700, Peter wrote: On 05/26/2017 02:11 AM, Martin Kletzander wrote: On Thu, May 25, 2017 at 10:16:26AM -0700, Peter Volpe wrote: [...] If we standardize even the smallest part of the RPC, then it might screw us

Re: [libvirt] Remotable Libvirt

On Tue, Jun 06, 2017 at 07:45:10 -0700, Peter wrote: > On 05/26/2017 02:11 AM, Martin Kletzander wrote: > > On Thu, May 25, 2017 at 10:16:26AM -0700, Peter Volpe wrote: [...] > > If we standardize even the smallest part of the RPC, then it might screw > > us immediately. We are keeping it

Re: [libvirt] [libvirt-php PATCH] add API bindings for get/set network autostart

On 06/05/2017 09:57 PM, Dawid Zamirski wrote: > Aside from that: > * fix arginfo_libvirt_conn_flags - it has 2 args not 1 > * get rid arginfo_libvirt_domain_set_autostart and use > arginfo_libvirt_conn_flags instead as it's the same. > --- > src/libvirt-php.c | 54

[libvirt] [PATCH 1/2] qemu: Conditionally allow block-copy for persistent domains

Allow starting the block-copy job for a persistent domain if a user declares by using a flag that the job will not be recovered if the VM is switched off while the job is active. This allows to use the block-copy job with persistent VMs under the same conditions as would apply to transient

[libvirt] [PATCH 0/2] qemu: Allow block-copy for persistent VMs under same conditions as for transient

Peter Krempa (2): qemu: Conditionally allow block-copy for persistent domains virsh: Add support for VIR_DOMAIN_BLOCK_COPY_TRANSIENT_JOB include/libvirt/libvirt-domain.h | 3 +++ src/libvirt-domain.c | 3 +++ src/qemu/qemu_driver.c | 9 ++--- tools/virsh-domain.c

Re: [libvirt] Remotable Libvirt

On 05/26/2017 02:11 AM, Martin Kletzander wrote: On Thu, May 25, 2017 at 10:16:26AM -0700, Peter Volpe wrote: Hi Everyone, We are working towards building on the virtualization management functionality in cockpit (http://cockpit-project.org/) and wanted to get some feedback on the best way to

[libvirt] [PATCH] lxc: add possibility to define init uid/gid

Users may want to run the init command of a container as a special user / group. Allow doing it using and elements. --- docs/formatdomain.html.in | 6 ++ docs/schemas/domaincommon.rng | 12 src/conf/domain_conf.c| 19 +++

[libvirt] [PATCH 2/2] lxc: allow user to specify command working directory

Some containers may want the application to run in a special directory. Add element in the domain configuration to handle this case and use it in the lxc driver. --- docs/formatdomain.html.in| 5 + docs/schemas/domaincommon.rng| 5 + src/conf/domain_conf.c

[libvirt] [PATCH 0/2] Set lxc container working directory

Hi all, Here is a resubmit with: * virExec() call orders preserved while still sharing code with virCommandExec() * Cleanup in the last patch Cédric Bosdonnat (2): util: share code between virExec and virCommandExec lxc: allow user to specify command working directory

Re: [libvirt] [PATCH v2 5/8] util: Introduce virObjectPoolableHashElement

On 06/05/2017 10:46 AM, Peter Krempa wrote: > On Mon, Jun 05, 2017 at 09:10:00 -0400, John Ferlan wrote: >> On 06/05/2017 08:25 AM, Peter Krempa wrote: >>> On Fri, Jun 02, 2017 at 06:17:19 -0400, John Ferlan wrote: Add a new virObjectLockable child which will be used to more generically

Re: [libvirt] [PATCH 06/15] qemu: Refactor save image header

On Mon, Jun 05, 2017 at 11:26:54AM +0200, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark Some commit message would be nice for such large refactor. It would be nice to split the patch into two patches, one that moves the code around and second one that actually

[libvirt] [PATCHv2 13/15] Add virtio-related options to input devices

https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- docs/formatdomain.html.in | 13 + docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c| 15 +++

[libvirt] [PATCHv2 10/15] Add virtio-related options to filesystems

https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- docs/formatdomain.html.in | 5 + docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 8 src/conf/domain_conf.h

[libvirt] [PATCHv2 09/15] Add virtio-related options to controllers

https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- docs/formatdomain.html.in | 6 ++ docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 8 src/conf/domain_conf.h

[libvirt] [PATCHv2 15/15] qemu: format virtio-related options on the command line

Format iommu_platform= and ats= for virtio devices. https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- src/qemu/qemu_capabilities.c | 12 - src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c| 58

[libvirt] [PATCHv2 08/15] Add virtio-related options to disks

https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- docs/formatdomain.html.in | 5 + docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 9 + src/conf/domain_conf.h

[libvirt] [PATCHv2 03/15] conf: add device_iotlb attribute to iommu

Add a new device_iotlb attribute to the iommu device to control the device IOTLB support for intel-iommu. https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- docs/formatdomain.html.in | 9 +++ docs/schemas/domaincommon.rng | 5

[libvirt] [PATCHv2 12/15] Add virtio-related options to video

https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- docs/formatdomain.html.in | 12 +++ docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 24 -- src/conf/domain_conf.h

[libvirt] [PATCHv2 07/15] add virtio-related options to memballoon

https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- docs/formatdomain.html.in | 7 +++ docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 21 + src/conf/domain_conf.h

[libvirt] [PATCHv2 02/15] virDomainControllerDefFormat: do not mix attributes and subelements

Move out the PCI controller's subelements formatting out of the switch handling attributes. This removes the need for a few bool variables. --- src/conf/domain_conf.c | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/src/conf/domain_conf.c

[libvirt] [PATCHv2 06/15] Add virtio-related options to interfaces

https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- docs/formatdomain.html.in | 19 +++ docs/schemas/domaincommon.rng | 12 + src/conf/domain_conf.c | 63 ++

[libvirt] [PATCHv2 01/15] conf: eliminate monster condition in virDomainControllerDefFormat

Move most of the subelement formatting out of the giant if. --- src/conf/domain_conf.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 958a5b7..02b2e49 100644 --- a/src/conf/domain_conf.c +++

[libvirt] [PATCHv2 04/15] qemu: format device-iotlb on intel-iommu command line

Format the device-iotlb attribute. https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h | 3 +++ src/qemu/qemu_command.c | 11 +++

Re: [libvirt] [PATCH] qemu: process: Save vcpu ordering information on reconnect

On Tue, Jun 06, 2017 at 07:50:16AM +0200, Peter Krempa wrote: vCPU ordering information would not be updated if a vCPU emerged or disappeared during the time libvirtd is not running. This allowed to create invalid configuration like: [...] Call the function that records the

Re: [libvirt] [PATCH 05/15] qemu: Rename xml_len in virQEMUSaveHeader as data_len

On Mon, Jun 05, 2017 at 11:26:53AM +0200, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_driver.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) Some commit message that explain the change would be nice.

Re: [libvirt] libvirt builds failing on fedora-rawhide

On Mon, Jun 05, 2017 at 04:22:41PM -0400, Yash Mankad wrote: > Hi, > > The libvirt-master-build on ci.c.o seems to be failing on > the fedora-rawhide slave since Friday. > > This seems to be the commit/build that is causing it to fail. Nope, it is a gnulib/glibc incompatibility

Re: [libvirt] [libvirt-php PATCH] add API bindings for get/set network autostart

2017-06-05 22:57 GMT+03:00 Dawid Zamirski : > Aside from that: > * fix arginfo_libvirt_conn_flags - it has 2 args not 1 > * get rid arginfo_libvirt_domain_set_autostart and use > arginfo_libvirt_conn_flags instead as it's the same. Looks good to me -- Vasiliy Tolstov,

Re: [libvirt] [PATCH] bhyve: add support for video device configuration

Roman Bogorodskiy wrote: > Sorry for the strange splitting of this (supposed-to-be) series, > apparently I have something weird happening on my system so > git-send-email authenticates only when sending the first patch :-( > > Roman Bogorodskiy ping? As the series was unintentionally broken

Re: [libvirt] [PATCH 04/15] conf: Pass xmlopt to virDomainSnapshotDefFormat

On Mon, Jun 05, 2017 at 11:26:52AM +0200, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > > Notes: > I know the line in vbox_common.c is too long, but I don't really want > to touch that horrible piece of code more than making it compile. > >

Re: [libvirt] [PATCH] Report more correct information for cache control

On Tue, Jun 06, 2017 at 11:58:49AM +0800, Eli Qiao wrote: hi Martin The code looks good to me, I have 1 comment for the granularity’s comment, and another one for the test data. Otherwise, looks perfect, good to learn how to deal with hex I just copied that from virhostcpu.c [...]

Re: [libvirt] [PATCH 03/15] conf: Make virDomainSnapshotDefFormat easier to read

On Mon, Jun 05, 2017 at 11:26:51AM +0200, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > src/conf/snapshot_conf.c | 30 +- > 1 file changed, 21 insertions(+), 9 deletions(-) Reviewed-by: Pavel Hrdina

Re: [libvirt] [PATCH 2/2] lxc: allow user to specify command working directory

On Mon, 2017-06-05 at 15:27 +0100, Daniel P. Berrange wrote: > On Thu, Jun 01, 2017 at 02:26:17PM +0200, Cédric Bosdonnat wrote: > > Some containers may want the application to run in a special directory. > > Add element in the domain configuration to handle this case > > and use it in the lxc

Re: [libvirt] [PATCH 01/15] conf: Make error reporting in virCPUDefIsEqual optional

On Mon, Jun 05, 2017 at 11:26:49AM +0200, Jiri Denemark wrote: > The function will be used in paths where mismatching CPU defs are not an > error. > > Signed-off-by: Jiri Denemark > --- > src/conf/cpu_conf.c| 119 > ++--- >