Re: [libvirt] [PATCH] cpu_ppc64: Add support for host-model on POWER9

On Wed, Jun 07, 2017 at 03:05:53PM +0200, Andrea Bolognani wrote: > On Thu, 2017-05-18 at 14:40 +0200, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > > --- > >  src/cpu/cpu_ppc64.c|  8 > >  .../qemuxml2argv-pseries-cpu-compat-power9.args| 24

[libvirt] [PATCH] qemu: Support chardevs with ARM virt machines

The function to check if -chardev is supported by QEMU was written a long time ago, where adding chardevs did not make sense on the fixed ARM platforms. Since then, we now have a general purpose virt platform, which should support plugging in any device over PCIe which is supported in a similar fa

[libvirt] [PATCH go-xml] Add support for Node Device with basic testing.

--- node_device.go | 310 +++ node_device_test.go | 337 2 files changed, 647 insertions(+) create mode 100644 node_device.go create mode 100644 node_device_test.go diff --git a/node_device.go

[libvirt] [PATCHv3 13/14] qemuxml2argvtest: add virtio-options test case

Add a test case to demonstrate the addition of new command line options https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- .../qemuxml2argv-virtio-options.args | 41 ++ tests/qemuxml2argvtest.c | 9 + 2 files changed, 50 insert

[libvirt] [PATCHv3 14/14] qemu: format virtio-related options on the command line

Format iommu_platform= and ats= for virtio devices. https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- src/qemu/qemu_capabilities.c | 12 - src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c| 58 +++

[libvirt] [PATCHv3 04/14] conf: use a leading space in virDomainVirtioNetDriverFormat

Instead of formatting a space after every option. --- src/conf/domain_conf.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 625449a..710048c 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf

[libvirt] [PATCHv3 11/14] Add virtio-related options to video

https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- docs/formatdomain.html.in | 12 ++ docs/schemas/domaincommon.rng | 5 src/conf/domain_conf.c | 27 -- src/conf/domain_conf.h

[libvirt] [PATCHv3 07/14] Add virtio-related options to disks

https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- docs/formatdomain.html.in | 5 + docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 15 +++ src/conf/domain_conf.h

[libvirt] [PATCHv3 02/14] qemu: format device-iotlb on intel-iommu command line

Format the device-iotlb attribute. https://bugzilla.redhat.com/show_bug.cgi?id=1283251 Reviewed-by: Pavel Hrdina --- src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h | 3 +++ src/qemu/qemu_command.c

[libvirt] [PATCHv3 10/14] Add virtio-related options to rng devices

https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- docs/formatdomain.html.in | 11 +++ docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c| 19 +++ src/conf/domain_conf.h

[libvirt] [PATCHv3 12/14] Add virtio-related options to input devices

https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- docs/formatdomain.html.in | 7 +++ docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 18 ++ src/conf/domain_conf.h

[libvirt] [PATCHv3 06/14] add virtio-related options to memballoon

https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- docs/formatdomain.html.in | 7 +++ docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 24 ++ src/conf/domain_conf.h

[libvirt] [PATCHv3 03/14] qemuxml2xmltest: add virtio-options test

Add a test case with all the virtio devices we know to demonstrate the addition of new options. https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- .../qemuxml2argv-virtio-options.xml| 81 ++ .../qemuxml2xmlout-virtio-options.xml | 1 + tests/

[libvirt] [PATCHv3 05/14] Add virtio-related options to interfaces

https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- docs/formatdomain.html.in | 19 docs/schemas/domaincommon.rng | 12 ++ src/conf/domain_conf.c | 121 + src/conf/domain_conf.h

[libvirt] [PATCHv3 08/14] Add virtio-related options to controllers

https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- docs/formatdomain.html.in | 6 ++ docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 10 ++ src/conf/domain_conf.h

[libvirt] [PATCHv3 09/14] Add virtio-related options to filesystems

https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- docs/formatdomain.html.in | 5 + docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 10 ++ src/conf/domain_conf.h

[libvirt] [PATCHv3 01/14] conf: add iotlb attribute to iommu

Add a new iotlb attribute to the iommu device to control the device IOTLB support for intel-iommu. https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- docs/formatdomain.html.in | 10 +++ docs/schemas/domaincommon.rng | 5 src/conf/domain

[libvirt] [PATCHv3 00/14] Allow virtio devices to use vIOMMU

https://bugzilla.redhat.com/show_bug.cgi?id=1283251 new in v3: * eliminated multi-word attribute names * eliminated extra virBufferTrims * added ABI stability checks * post-parse checks for non-virtio disks and nets * removed duplicate devices from the test file Ján Tomko (14): conf: add iotlb

Re: [libvirt] [PATCH] qemu: Add AAVMF32 to the list of known UEFIs

Hi Dann, there is currently some apparmor upstreaming going on [1]. You'd want to add a similar line for your new paths as well I think. [1]: https://www.redhat.com/archives/libvir-list/2017-May/msg00474.html On Wed, Jun 7, 2017 at 12:06 PM, dann frazier wrote: > Add a path for UEFI VMs for A

[libvirt] [PATCH] qemu: Add AAVMF32 to the list of known UEFIs

Add a path for UEFI VMs for AArch32 VMs. This is the path Debian is currently using in experimental. libvirt is the de facto canonical location for where distros should place these firmware images, so let's define this path here to try and minimize distro fragmentation. --- src/qemu/qemu_conf.c |

Re: [libvirt] [PATCH 07/10] apparmor, libvirt-qemu: Allow access to ceph config

On Wed, Jun 07, 2017 at 10:44:59AM -0600, Christian Ehrhardt wrote: > On Fri, Jun 2, 2017 at 12:57 PM, Guido Günther wrote: > > > Shouldn't this only be added when ceph is in use? > > Cheers, > > -- Guido > > > > Yeah it is part of a category of rules where in a perfect world we would > wirte v

Re: [libvirt] [PATCH 08/10] apparmor, libvirt-qemu: Allow macvtap access

On Fri, Jun 2, 2017 at 12:55 PM, Guido Günther wrote: > Shouldn't this only be added when macvtap is in use? > Cheers, > -- Guido > Right again - as the ceph change this is part of a category of rules where in a perfect world we would write virt-aa-helper code for each of them. In this particu

Re: [libvirt] [PATCH 07/10] apparmor, libvirt-qemu: Allow access to ceph config

On Fri, Jun 2, 2017 at 12:57 PM, Guido Günther wrote: > Shouldn't this only be added when ceph is in use? > Cheers, > -- Guido > Yeah it is part of a category of rules where in a perfect world we would wirte virt-aa-helper code for each of them. In this particular case I think the existance of

Re: [libvirt] [PATCH] virFDStreamThread: Make sure we won't exceed @length

On 06/07/2017 12:55 AM, Michal Privoznik wrote: On 06/06/2017 07:24 PM, Jim Fehlig wrote: On 06/05/2017 06:53 AM, Michal Privoznik wrote: There's a problem with current streams after I switched them from iohelper to thread implementation. Previously, iohelper made sure not to exceed specified @

Re: [libvirt] [PATCH] virNetClientStreamQueuePacket: Set st->incomingEOF on the end of stream

On 06/07/2017 05:51 PM, Jim Fehlig wrote: > On 06/06/2017 06:53 AM, Michal Privoznik wrote: >> While reworking client side of streams, I had to postpone payload >> decoding so that stream holes and stream data can be >> distinguished in virNetClientStreamRecvPacket. That's merely what >> 18944b7aea

[libvirt] [PATCH] virDomainNetDefParseXML: Fix typo

In 9cb891141c we've introduced some logic to clearing suggested macvtap/macvlan ifnames. The logic consists of comparing ifname string with strings that libvirt would generate. However, due to a typo only VIR_NET_GENERATED_MACVTAP_PREFIX was compared. Twice. Signed-off-by: Michal Privoznik --- P

[libvirt] [PATCH 1/2] qemuProcessBuildDestroyHugepagesPath: create path more frequently

https://bugzilla.redhat.com/show_bug.cgi?id=1455819 Currently, the per-domain path for huge pages mmap() for qemu is created iff domain has memoryBacking and hugepages in it configured. However, this alone is not enough because there can be a DIMM module with hugepages configured too. Signed-off-

Re: [libvirt] [PATCH] virNetClientStreamQueuePacket: Set st->incomingEOF on the end of stream

On 06/06/2017 06:53 AM, Michal Privoznik wrote: While reworking client side of streams, I had to postpone payload decoding so that stream holes and stream data can be distinguished in virNetClientStreamRecvPacket. That's merely what 18944b7aea46d does. However, I accidentally removed one importan

[libvirt] [PATCH 0/2] Two simple hugepage fixes

Ideally, we would have the security driver relabelling the paths qemu is going to touch. And this indeed is how I approached this problem firstly. But there are couple of problems: a) we generate the paths, add them onto the cmd line and forget them. You won't find them in virDomainDef. The secdri

[libvirt] [PATCH 2/2] qemuDomainAttachMemory: Crate hugepage dir if needed

https://bugzilla.redhat.com/show_bug.cgi?id=1455819 It may happen that a domain is started without any huge pages. However, user might try to attach a DIMM module later. DIMM backed by huge pages (why would somebody want to mix regular and huge pages is beyond me). Therefore we have to create the

[libvirt] [PATCH 2/2] qemu: Query for vhostuser iface names at runtime

https://bugzilla.redhat.com/show_bug.cgi?id=1459091 Currently, we are querying for vhostuser interface name in post parse callback. It doesn't hurt much, but at that time interface might not yet exist. However, it has to exist when starting domain. Therefore it makes more sense to query its name a

[libvirt] [PATCH 1/2] virsh: Accept iface alias for domifstats too

https://bugzilla.redhat.com/show_bug.cgi?id=1459091 Not every interface has a name (for instance, vhostuser interfaces might not have one). However, all interfaces have aliases. We can accept those to uniquely identify interfaces. Signed-off-by: Michal Privoznik --- src/qemu/qemu_driver.c

[libvirt] [PATCH 0/2] Two vhostuser improvements

*** BLURB HERE *** Michal Privoznik (2): virsh: Accept iface alias for domifstats too qemu: Query for vhostuser iface names at runtime src/qemu/qemu_command.c| 4 +++ src/qemu/qemu_domain.c | 20 - src/qemu/qemu_driver.c

Re: [libvirt] [PATCHv2 15/15] qemu: format virtio-related options on the command line

On Tue, Jun 06, 2017 at 01:36:29PM +0200, Ján Tomko wrote: > Format iommu_platform= and ats= for virtio devices. > > https://bugzilla.redhat.com/show_bug.cgi?id=1283251 > --- > src/qemu/qemu_capabilities.c | 12 - > src/qemu/qemu_capabilities.h | 2

Re: [libvirt] Remotable Libvirt

On 06/06/2017 05:17 PM, Peter wrote: > On 06/06/2017 08:11 AM, Peter Krempa wrote: >> On Tue, Jun 06, 2017 at 07:45:10 -0700, Peter wrote: >>> On 05/26/2017 02:11 AM, Martin Kletzander wrote: On Thu, May 25, 2017 at 10:16:26AM -0700, Peter Volpe wrote: >> >> [...] >> If we standardize eve

Re: [libvirt] [PATCHv2 14/15] qemuxml2argvtest: add virtio-options test case

On Tue, Jun 06, 2017 at 01:36:28PM +0200, Ján Tomko wrote: > Add a test case to demonstrate the addition of new command line options > > https://bugzilla.redhat.com/show_bug.cgi?id=1283251 > --- > .../qemuxml2argv-virtio-options.args | 47 > ++ > tests/qemuxml2a

Re: [libvirt] [PATCHv2 13/15] Add virtio-related options to input devices

On Tue, Jun 06, 2017 at 01:36:27PM +0200, Ján Tomko wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1283251 > --- > docs/formatdomain.html.in | 13 + > docs/schemas/domaincommon.rng | 5 + > src/conf/domain_conf.c

Re: [libvirt] [PATCHv2 12/15] Add virtio-related options to video

On Tue, Jun 06, 2017 at 01:36:26PM +0200, Ján Tomko wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1283251 > --- > docs/formatdomain.html.in | 12 +++ > docs/schemas/domaincommon.rng | 5 + > src/conf/domain_conf.c

Re: [libvirt] [PATCHv2 11/15] Add virtio-related options to rng devices

On Tue, Jun 06, 2017 at 01:36:25PM +0200, Ján Tomko wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1283251 > --- > docs/formatdomain.html.in| 11 +++ > docs/schemas/domaincommon.rng| 5 + > src/conf/domain_conf.c

Re: [libvirt] [PATCHv2 10/15] Add virtio-related options to filesystems

On Tue, Jun 06, 2017 at 01:36:24PM +0200, Ján Tomko wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1283251 > --- > docs/formatdomain.html.in | 5 + > docs/schemas/domaincommon.rng | 1 + > src/conf/domain_conf.c

Re: [libvirt] [PATCHv2 09/15] Add virtio-related options to controllers

On Tue, Jun 06, 2017 at 01:36:23PM +0200, Ján Tomko wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1283251 > --- > docs/formatdomain.html.in | 6 ++ > docs/schemas/domaincommon.rng | 1 + > src/conf/domain_conf.c

Re: [libvirt] [PATCHv2 06/15] Add virtio-related options to interfaces

On Tue, Jun 06, 2017 at 01:36:20PM +0200, Ján Tomko wrote: > > > > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1283251 > --- > docs/formatdomain.html.in | 19 +++ > docs/schemas/domaincommon.rng | 12 + > src/conf/domain_conf.

Re: [libvirt] [PATCHv2 06/15] Add virtio-related options to interfaces

On Wed, Jun 07, 2017 at 03:56:44PM +0200, Ján Tomko wrote: > On Wed, Jun 07, 2017 at 03:43:53PM +0200, Pavel Hrdina wrote: > >On Tue, Jun 06, 2017 at 01:36:20PM +0200, Ján Tomko wrote: > >> > >> > >> > >> > >> > >> > >> https://bugzilla.redhat.com/show_bug.cgi?id=1283251 > >> --- > >> d

Re: [libvirt] [PATCHv2 06/15] Add virtio-related options to interfaces

On Wed, Jun 07, 2017 at 03:43:53PM +0200, Pavel Hrdina wrote: On Tue, Jun 06, 2017 at 01:36:20PM +0200, Ján Tomko wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1283251 --- docs/formatdomain.html.in | 19 +++ docs/schemas/domaincommon.rng

Re: [libvirt] [PATCHv2 08/15] Add virtio-related options to disks

On Tue, Jun 06, 2017 at 01:36:22PM +0200, Ján Tomko wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1283251 > --- > docs/formatdomain.html.in | 5 + > docs/schemas/domaincommon.rng | 1 + > src/conf/domain_conf.c

Re: [libvirt] [PATCHv2 07/15] add virtio-related options to memballoon

On Tue, Jun 06, 2017 at 01:36:21PM +0200, Ján Tomko wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1283251 > --- > docs/formatdomain.html.in | 7 +++ > docs/schemas/domaincommon.rng | 5 + > src/conf/domain_conf.c

Re: [libvirt] [PATCHv2 06/15] Add virtio-related options to interfaces

On Tue, Jun 06, 2017 at 01:36:20PM +0200, Ján Tomko wrote: > > > > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1283251 > --- > docs/formatdomain.html.in | 19 +++ > docs/schemas/domaincommon.rng | 12 + > src/conf/domain_conf.

Re: [libvirt] [PATCHv2 05/15] qemuxml2xmltest: add virtio-options test

On Tue, Jun 06, 2017 at 01:36:19PM +0200, Ján Tomko wrote: > Add a test case with all the virtio devices we know to demonstrate > the addition of new options. > > https://bugzilla.redhat.com/show_bug.cgi?id=1283251 > --- > .../qemuxml2argv-virtio-options.xml| 92 > +++

Re: [libvirt] [PATCHv2 04/15] qemu: format device-iotlb on intel-iommu command line

On Tue, Jun 06, 2017 at 01:36:18PM +0200, Ján Tomko wrote: > Format the device-iotlb attribute. > > https://bugzilla.redhat.com/show_bug.cgi?id=1283251 > --- > src/qemu/qemu_capabilities.c | 3 +++ > src/qemu/qemu_capabilities.h | 3 +++ > src/q

Re: [libvirt] [PATCH] cpu_ppc64: Add support for host-model on POWER9

On Thu, 2017-05-18 at 14:40 +0200, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- >  src/cpu/cpu_ppc64.c|  8 >  .../qemuxml2argv-pseries-cpu-compat-power9.args| 24 >++ >  .../qemuxml2argv-pseries-cpu-compat-power9.xml

Re: [libvirt] [PATCHv2 03/15] conf: add device_iotlb attribute to iommu

On Tue, Jun 06, 2017 at 01:36:17PM +0200, Ján Tomko wrote: > Add a new device_iotlb attribute to the iommu device > to control the device IOTLB support for intel-iommu. > > https://bugzilla.redhat.com/show_bug.cgi?id=1283251 > --- > docs/formatdomain.html.in | 9 +++

Re: [libvirt] [PATCH v2] qemu: Fix serial stub console allocation

On Thu, Jun 01, 2017 at 14:57:59 +0200, Erik Skultety wrote: > When adding the aliased serial stub console, the structure wasn't > properly allocated (VIR_ALLOC instead of virDomainChrDefNew) which then > resulted in SIGSEGV in virDomainChrSourceIsEqual during a serial device > coldplug. > > https

Re: [libvirt] [PATCHv2 02/15] virDomainControllerDefFormat: do not mix attributes and subelements

On Tue, Jun 06, 2017 at 01:36:16PM +0200, Ján Tomko wrote: > Move out the PCI controller's subelements formatting out of the switch > handling attributes. This removes the need for a few bool variables. > --- > src/conf/domain_conf.c | 27 +-- > 1 file changed, 9 insertions

Re: [libvirt] [PATCHv2 01/15] conf: eliminate monster condition in virDomainControllerDefFormat

On Tue, Jun 06, 2017 at 01:36:15PM +0200, Ján Tomko wrote: > Move most of the subelement formatting out of the giant if. > --- > src/conf/domain_conf.c | 22 +- > 1 file changed, 9 insertions(+), 13 deletions(-) Reviewed-by: Pavel Hrdina signature.asc Description: Digital s

Re: [libvirt] [PATCH v2] qemu: Fix serial stub console allocation

On Thu, Jun 01, 2017 at 02:57:59PM +0200, Erik Skultety wrote: > When adding the aliased serial stub console, the structure wasn't > properly allocated (VIR_ALLOC instead of virDomainChrDefNew) which then > resulted in SIGSEGV in virDomainChrSourceIsEqual during a serial device > coldplug. > > http

Re: [libvirt] [PATCH v2 17/20] qemu: Always send persistent XML during migration

On Wed, Jun 07, 2017 at 12:56:52 +0200, Pavel Hrdina wrote: > On Wed, Jun 07, 2017 at 10:37:42AM +0200, Jiri Denemark wrote: > > When persistent migration of a transient domain is requested but no > > custom XML is passed to the migration API we would just let the > > destination daemon make a pers

Re: [libvirt] [PATCH v2 17/20] qemu: Always send persistent XML during migration

On Wed, Jun 07, 2017 at 10:37:42AM +0200, Jiri Denemark wrote: > When persistent migration of a transient domain is requested but no > custom XML is passed to the migration API we would just let the > destination daemon make a persistent definition from the live definition > itself. This is not a p

Re: [libvirt] [PATCH v2 14/20] qemu: Store save cookie in save images and snapshots

On Wed, Jun 07, 2017 at 10:37:39AM +0200, Jiri Denemark wrote: > The following patches will add an actual content in the cookie and use > the data when restoring a domain. > > Signed-off-by: Jiri Denemark > --- > > Notes: > Version 2: > - renamed virQEMUSaveHeader.cookie as cookieOffset

Re: [libvirt] [PATCH go-xml] 1,rename DomainInterfaceBoot to DomainDeviceBoot; 2,support disk boot order

On Tue, Jun 06, 2017 at 01:51:30PM +0800, zhenwei.pi wrote: > --- > domain.go | 5 +++-- > domain_test.go | 6 +- > 2 files changed, 8 insertions(+), 3 deletions(-) ACK and pushed with some changes to the commit message text. Regards, Daniel -- |: https://berrange.com -o-https

Re: [libvirt] [PATCH v2 10/20] qemu: Introduce virQEMUSaveData structure

On Wed, Jun 07, 2017 at 10:37:35AM +0200, Jiri Denemark wrote: > The new structure encapsulates save image header and associated data > (domain XML). > > Signed-off-by: Jiri Denemark > --- > > Notes: > Version 2: > - new patch (separated from the original 06/15) > > src/qemu/qemu_drive

Re: [libvirt] [PATCH v2 09/20] qemu: Refactor qemuDomainSaveHeader

On Wed, Jun 07, 2017 at 10:37:34AM +0200, Jiri Denemark wrote: > The function is now called virQEMUSaveDataWrite and it is now doing > everything it needs to save both the save image header and domain XML to > a file. Be it a new file or an existing file in which a user wants to > change the domain

Re: [libvirt] [PATCH v2 08/20] qemu: Introduce virQEMUSaveDataFinish

On Wed, Jun 07, 2017 at 10:37:33AM +0200, Jiri Denemark wrote: > The function is supposed to update the save image header after a > successful migration to the save image file. > > Signed-off-by: Jiri Denemark > --- > > Notes: > Version 2: > - new patch (separated from the original 06/15

Re: [libvirt] libvirt binding for Rust

On Wed, Jun 07, 2017 at 11:14:11AM +0200, Martin Kletzander wrote: > On Tue, Jun 06, 2017 at 12:19:21PM +0200, Sahid Orentino Ferdjaoui wrote: > > Hello, > > > > I started a work on a libvirt binding for Rust [0]. Not all of the API > > is implemeted but I think it's now in a usable state. > > >

Re: [libvirt] [PATCH v2 07/20] qemu: Introduce virQEMUSaveData{New, Free}

On Wed, Jun 07, 2017 at 10:37:32AM +0200, Jiri Denemark wrote: > This is a preparation for creating a new virQEMUSaveData structure which > will encapsulate all save image header data. > > Signed-off-by: Jiri Denemark > --- > > Notes: > Version 2: > - new patch (separated from the origin

Re: [libvirt] [PATCH v2 06/20] qemu: Fix memory leaks in qemuDomainSaveImageOpen

On Wed, Jun 07, 2017 at 10:37:31AM +0200, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > > Notes: > Version 2: > - new patch, separated from the original 06/15 > > src/qemu/qemu_driver.c | 14 -- > 1 file changed, 8 insertions(+), 6 deletions(-) Reviewed-by: Pa

Re: [libvirt] [PATCH v2 02/20] conf: Refactor virCPUDefParseXML

On Wed, Jun 07, 2017 at 10:37:27AM +0200, Jiri Denemark wrote: > Signed-off-by: Jiri Denemark > --- > > Notes: > Version 2: > - no need to distinguish 0 vs 1 return codes > - better documentation > > src/conf/cpu_conf.c| 109 > +++-- >

Re: [libvirt] [PATCH v2 01/20] conf: Make error reporting in virCPUDefIsEqual optional

On Wed, Jun 07, 2017 at 10:37:26AM +0200, Jiri Denemark wrote: > The function will be used in paths where mismatching CPU defs are not an > error. > > Signed-off-by: Jiri Denemark > --- > > Notes: > Version 2: > - move all the if (reportError) statements into a macro > > src/conf/cpu_c

Re: [libvirt] libvirt binding for Rust

On Tue, Jun 06, 2017 at 10:31:33PM +0100, Daniel P. Berrange wrote: > On Tue, Jun 06, 2017 at 12:19:21PM +0200, Sahid Orentino Ferdjaoui wrote: > > Hello, > > > > I started a work on a libvirt binding for Rust [0]. Not all of the API > > is implemeted but I think it's now in a usable state. > > >

Re: [libvirt] libvirt binding for Rust

On Tue, Jun 06, 2017 at 12:19:21PM +0200, Sahid Orentino Ferdjaoui wrote: Hello, I started a work on a libvirt binding for Rust [0]. Not all of the API is implemeted but I think it's now in a usable state. https://docs.rs/crate/virt https://github.com/sahid/libvirt-rs The code is licensed un

Re: [libvirt] Remotable Libvirt

On 07.06.2017 11:02, Daniel P. Berrange wrote: > On Wed, Jun 07, 2017 at 10:47:25AM +0200, Stef Walter wrote: >> On 07.06.2017 07:49, Martin Pitt wrote: >>> Hello Richard, >>> >>> Richard W.M. Jones [2017-05-31 18:00 +0100]: I agree with others that as things stand you will need a REST or DBus

Re: [libvirt] Remotable Libvirt

Stef Walter [2017-06-07 10:47 +0200]: > On 07.06.2017 07:49, Martin Pitt wrote: > > C/GI interfaces also don't map well to D-Bus, i. e. it's not practical to > > autogenerate a D-Bus interface for a given GI API. This still works for the > > most simple methods that only accept primitive data types

Re: [libvirt] Remotable Libvirt

Hello Richard, Richard W.M. Jones [2017-05-31 18:00 +0100]: > I agree with others that as things stand you will need a REST or DBus > or similar API added to libvirt. > > However have you considered using gobject-introspection to generate > new "Payload" types automatically? This doesn't fundame

Re: [libvirt] Remotable Libvirt

On Wed, Jun 07, 2017 at 10:47:25AM +0200, Stef Walter wrote: > On 07.06.2017 07:49, Martin Pitt wrote: > > Hello Richard, > > > > Richard W.M. Jones [2017-05-31 18:00 +0100]: > >> I agree with others that as things stand you will need a REST or DBus > >> or similar API added to libvirt. > >> > >>

Re: [libvirt] More CI options

On Wed, Jun 07, 2017 at 10:55:21AM +0200, Martin Kletzander wrote: > On Tue, Jun 06, 2017 at 10:30:16PM +0100, Daniel P. Berrange wrote: > > On Tue, Jun 06, 2017 at 10:09:00PM +0200, Martin Kletzander wrote: > > > Since the addition of Travis CI builds, there is some more progress > > > towards mor

Re: [libvirt] More CI options

On Tue, Jun 06, 2017 at 10:30:16PM +0100, Daniel P. Berrange wrote: On Tue, Jun 06, 2017 at 10:09:00PM +0200, Martin Kletzander wrote: Since the addition of Travis CI builds, there is some more progress towards more testing. I was just wondering if anyone was thinking about (or is already worki

[libvirt] [PATCH 1/3] rpc: first allocate the memory and then set the count

Signed-off-by: Marc Hartmayer Reviewed-by: Boris Fiuczynski Reviewed-by: Bjoern Walk --- src/rpc/virnetclientprogram.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/rpc/virnetclientprogram.c b/src/rpc/virnetclientprogram.c index e620dec..c9d57ec 100644 --- a/src/rp

[libvirt] [PATCH 2/3] qemu: add a comment for mon->watch

Add a comment for mon->watch to make clear what's the purpose of this value. Signed-off-by: Marc Hartmayer Reviewed-by: Bjoern Walk --- src/qemu/qemu_monitor.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index a2de1a6..5c29b37 1006

Re: [libvirt] [PATCH 2/2] virsh: Add support for VIR_DOMAIN_BLOCK_COPY_TRANSIENT_JOB

On Tue, Jun 06, 2017 at 16:46:15 +0200, Peter Krempa wrote: > Allow using the new flag with virsh. > --- > tools/virsh-domain.c | 10 +- > tools/virsh.pod | 4 > 2 files changed, 13 insertions(+), 1 deletion(-) ... > diff --git a/tools/virsh.pod b/tools/virsh.pod > index aee9646

Re: [libvirt] [PATCH 1/2] qemu: Conditionally allow block-copy for persistent domains

On Tue, Jun 06, 2017 at 16:46:14 +0200, Peter Krempa wrote: > Allow starting the block-copy job for a persistent domain if a user > declares by using a flag that the job will not be recovered if the VM is > switched off while the job is active. > > This allows to use the block-copy job with persis

Re: [libvirt] Remotable Libvirt

On Thu, May 25, 2017 at 10:26:47AM -0700, Peter wrote: > Hi Everyone, > > We are working towards building on the virtualization management > functionality in cockpit (http://cockpit-project.org/) and wanted to get > some feedback on the best way to integrate with libvirt. Another thing to consi

[libvirt] [PATCH 0/3] Small patches

Marc Hartmayer (3): rpc: first allocate the memory and then set the count qemu: add a comment for mon->watch Use ATTRIBUTE_FALLTHROUGH src/conf/domain_conf.c| 2 +- src/conf/nwfilter_conf.c | 14 +++--- src/cpu/cpu_ppc64.c | 2 +- src/libvirt-domain.c

[libvirt] [PATCH 3/3] Use ATTRIBUTE_FALLTHROUGH

Use ATTRIBUTE_FALLTHROUGH, introduced by commit 5d84f5961b8e28e802f600bb2d2c6903e219092e, instead of comments to indicate that the fall through is an intentional behavior. Signed-off-by: Marc Hartmayer Reviewed-by: Boris Fiuczynski Reviewed-by: Bjoern Walk --- src/conf/domain_conf.c | 2

Re: [libvirt] Remotable Libvirt

On 07.06.2017 07:49, Martin Pitt wrote: > Hello Richard, > > Richard W.M. Jones [2017-05-31 18:00 +0100]: >> I agree with others that as things stand you will need a REST or DBus >> or similar API added to libvirt. >> >> However have you considered using gobject-introspection to generate >> new "P

[libvirt] [PATCH v2 17/20] qemu: Always send persistent XML during migration

When persistent migration of a transient domain is requested but no custom XML is passed to the migration API we would just let the destination daemon make a persistent definition from the live definition itself. This is not a problem now, but once the destination daemon starts replacing the origin

[libvirt] [PATCH v2 09/20] qemu: Refactor qemuDomainSaveHeader

The function is now called virQEMUSaveDataWrite and it is now doing everything it needs to save both the save image header and domain XML to a file. Be it a new file or an existing file in which a user wants to change the domain XML. Signed-off-by: Jiri Denemark --- Notes: Version 2: - n

[libvirt] [PATCH v2 19/20] qemu: Store updated CPU in save cookie

Since the domain XML saved in a snapshot or saved image uses the original guest CPU definition but we still want to enforce ABI when restoring the domain if libvirt and QEMU are new enough, we save the live updated CPU definition in a save cookie. Signed-off-by: Jiri Denemark Reviewed-by: Pavel H

[libvirt] [PATCH v2 14/20] qemu: Store save cookie in save images and snapshots

The following patches will add an actual content in the cookie and use the data when restoring a domain. Signed-off-by: Jiri Denemark --- Notes: Version 2: - renamed virQEMUSaveHeader.cookie as cookieOffset - renamed virQEMUSaveDataNew's cookie parameter as cookieObj - store zero

[libvirt] [PATCH v2 20/20] qemu: Use updated CPU when starting QEMU if possible

If QEMU is new enough and we have the live updated CPU definition in either save or migration cookie, we can use it to enforce ABI. The original guest CPU from domain XML will be stored in private data. Signed-off-by: Jiri Denemark Reviewed-by: Pavel Hrdina --- Notes: Version 2: - no ch

[libvirt] [PATCH v2 04/20] conf: Pass xmlopt to virDomainSnapshotDefFormat

This will be used later when a save cookie will become part of the snapshot XML using new driver specific parser/formatter functions. Signed-off-by: Jiri Denemark Reviewed-by: Pavel Hrdina --- Notes: I know the line in vbox_common.c is too long, but I don't really want to touch that hor

[libvirt] [PATCH v2 08/20] qemu: Introduce virQEMUSaveDataFinish

The function is supposed to update the save image header after a successful migration to the save image file. Signed-off-by: Jiri Denemark --- Notes: Version 2: - new patch (separated from the original 06/15) src/qemu/qemu_driver.c | 34 +- 1 file change

[libvirt] [PATCH v2 12/20] conf: Add save cookie callbacks to xmlopt

virDomainXMLOption gains driver specific callbacks for parsing and formatting save cookies. Signed-off-by: Jiri Denemark Reviewed-by: Pavel Hrdina --- Notes: Version 2: - no change src/bhyve/bhyve_domain.c | 2 +- src/conf/domain_conf.c| 16 +++- src/conf/dom

[libvirt] [PATCH v2 16/20] qemu: Report the original CPU in migratable xml

The destination host may not be able to start a domain using the live updated CPU definition because either libvirt or QEMU may not be new enough. Thus we need to send the original guest CPU definition. Signed-off-by: Jiri Denemark Reviewed-by: Pavel Hrdina --- Notes: Version 2: - no ch

[libvirt] [PATCH v2 01/20] conf: Make error reporting in virCPUDefIsEqual optional

The function will be used in paths where mismatching CPU defs are not an error. Signed-off-by: Jiri Denemark --- Notes: Version 2: - move all the if (reportError) statements into a macro src/conf/cpu_conf.c| 83 +++--- src/conf/cpu_conf.h

[libvirt] [PATCH v2 02/20] conf: Refactor virCPUDefParseXML

Signed-off-by: Jiri Denemark --- Notes: Version 2: - no need to distinguish 0 vs 1 return codes - better documentation src/conf/cpu_conf.c| 109 +++-- src/conf/cpu_conf.h| 9 ++-- src/conf/domain_conf.c | 12 +- src/cpu/cpu.

[libvirt] [PATCH v2 00/20] Fix regression caused by recent CPU driver changes

https://bugzilla.redhat.com/show_bug.cgi?id=1441662 when I was enhancing libvirt's guest CPU configuration code to be able to really ensure stable guest CPU ABI, I added a new attribute //cpu/@check which is nicely backward compatible... an old libvirt will just ignore it. However, even if check='

[libvirt] [PATCH v2 13/20] qemu: Implement virSaveCookie object and callbacks

This patch implements a new save cookie object and callbacks for qemu driver. The actual useful content will be added in the object later. Signed-off-by: Jiri Denemark Reviewed-by: Pavel Hrdina --- Notes: Version 2: - no change src/qemu/qemu_conf.c | 2 +- src/qemu/qemu_domain.c |

[libvirt] [PATCH v2 15/20] qemu: Remember CPU def from domain start

When starting a domain we update the guest CPU definition to match what QEMU actually provided (since it is allowed to add or removed some features unless check='full' is specified). Let's store the original CPU in domain private data so that we can use it to provide a backward compatible domain XM

[libvirt] [PATCH v2 11/20] conf: Introduce virSaveCookie

The code will be used by snapshots and domain save/restore code to store additional data for a saved running domain. It is analogous to migration cookies, but simple and one way only. Signed-off-by: Jiri Denemark Reviewed-by: Pavel Hrdina --- Notes: Version 2: - no change po/POTFILES.

[libvirt] [PATCH v2 07/20] qemu: Introduce virQEMUSaveData{New, Free}

This is a preparation for creating a new virQEMUSaveData structure which will encapsulate all save image header data. Signed-off-by: Jiri Denemark --- Notes: Version 2: - new patch (separated from the original 06/15) src/qemu/qemu_driver.c | 128

[libvirt] [PATCH v2 03/20] conf: Make virDomainSnapshotDefFormat easier to read

Signed-off-by: Jiri Denemark Reviewed-by: Pavel Hrdina --- Notes: Version 2: - no change src/conf/snapshot_conf.c | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c index b6cba5ac3..7da

  1   2   >