On Mon, 2017-06-26 at 22:00 -0400, Laine Stump wrote:
> The subject line implies (to me) that this patch somehow automagically
> creates multiple PHBs for the domain. It looks like what it does is to
> add the proper commandline args to the qemu command when multiple PHBs
> have already been added
On Mon, 2017-06-26 at 14:01 -0400, Cole Robinson wrote:
> This reverts commit 70c9b44270f75bfb7a5701d81aa49380d139e8f0.
>
> This commit breaks existing aarch64 machvirt configs with:
>
>
>
>
>
>
>
>
> Which fails with:
>
> error: Failed to start domain fedora25
On 06/26/2017 09:24 PM, Eduardo Habkost wrote:
>> I've posted patches in the past (qemu 2.6 timeframe, if I recall) that
>> changed netdev_add into a fully-advertised interface, but we didn't take
>> it then because we weren't sure how to handle the fact that netdev_add
>> can currently accept both
On Mon, Jun 26, 2017 at 07:23:50AM -0600, Eric Blake wrote:
> On 06/17/2017 09:15 PM, Eduardo Habkost wrote:
> > (CCing qemu-devel and the QAPI maintainers. I have a question
> > about introspection below.)
> >
>
> >
> > Fortunately, netdev options are modelled in the QAPI schema as
> > union N
On 06/23/2017 11:03 AM, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> .../qemuxml2argv-pseries-phb-default-missing.args | 22 +++
> .../qemuxml2argv-pseries-phb-default-missing.xml | 16 +++
> .../qemuxml2argv-pseries-phb-simple.args | 22 +
The subject line implies (to me) that this patch somehow automagically
creates multiple PHBs for the domain. It looks like what it does is to
add the proper commandline args to the qemu command when multiple PHBs
have already been added to the config.
As for the functionality:
Reviewed-by: Laine
On 06/23/2017 11:03 AM, Andrea Bolognani wrote:
> Usually, a controller with alias 'x' will create a bus with the
> same name; however, the bus created by a PHBs with alias 'x' will
> be named 'x.0' instead, so we need to account for that.
>
> As an exception to the exception, the implicit PHB tha
On Mon, Jun 26, 2017 at 09:30:11PM -0300, Julio Faracco wrote:
> Hi Dan,
>
> Have you tested the --xml argument as VSH_OT_ARGV?
> {.name = "domain",
> - .type = VSH_OT_DATA,
> + .type = VSH_OT_STRING,
> .flags = VSH_OFLAG_REQ_OPT,
> .help = N_("domain name, id or uuid")
>
Hi Dan,
Have you tested the --xml argument as VSH_OT_ARGV?
{.name = "domain",
- .type = VSH_OT_DATA,
+ .type = VSH_OT_STRING,
.flags = VSH_OFLAG_REQ_OPT,
.help = N_("domain name, id or uuid")
},
{.name = "xml",
- .type = VSH_OT_DATA,
+ .type = VSH_OT_ARGV
On 06/26/2017 01:25 AM, Andrea Bolognani wrote:
> On Sun, 2017-06-25 at 09:55 -0400, Laine Stump wrote:
>>> Adding it to the virDomainControllerPCIModelName enumeration
>>> is enough for existing code to handle it, so parsing and
>>> formatting will work without further tweaking.
>>>
>>> Signed-o
On Sun, Jun 25, 2017 at 08:33:39AM -0400, John Ferlan wrote:
>
>
> On 06/24/2017 08:05 PM, Julio Faracco wrote:
> > My apologies. I didn't read the function logic.
> > The second error was introduced by my "fix".
> > The error with help parameter is happening.
> >
> > If --domain is required, I
On Sun, Jun 25, 2017 at 08:33:39AM -0400, John Ferlan wrote:
>
>
> On 06/24/2017 08:05 PM, Julio Faracco wrote:
> > My apologies. I didn't read the function logic.
> > The second error was introduced by my "fix".
> > The error with help parameter is happening.
> >
> > If --domain is required, I
Update the generator to generate basic property type information for
each CIM object representation. Right now, it generates arrays of
hypervCimType structs:
struct _hypervCimType {
const char *name;
const char *type;
bool isArray;
};
---
src/hyperv/hyperv_wmi_classes.h| 19 ++
This commit introduces functionality for creating and working with
invoke parameters. This commit does not include any code for serializing
and actually performing the method invocations; it merely defines the
functions and API for using invocation parameters in driver code.
HYPERV_DEFAULT_PARAM_C
On 06/26/2017 11:19 AM, Andrew Jones wrote:
> On Mon, Jun 26, 2017 at 10:10:55AM -0400, Cole Robinson wrote:
>> On 06/24/2017 10:07 PM, Andrea Bolognani wrote:
>>> On Sat, 2017-06-24 at 16:07 +0200, Christoffer Dall wrote:
At this point I'm a little confused about how to proceed here. Would
>
This commit adds support for invoking methods on remote objects
via hypervInvokeMethod.
---
src/hyperv/hyperv_wmi.c | 590
src/hyperv/hyperv_wmi.h | 8 +-
src/hyperv/openwsman.h | 4 +
3 files changed, 600 insertions(+), 2 deletions(-)
diff --
Introduces support for virDomainSetMemory. This also serves an an
example for how to use the new method invocation API with a more
complicated method, this time including an EPR and embedded param.
---
src/hyperv/hyperv_driver.c| 114 ++
src/hyperv/hyper
This commit adds support for virDomainSendKey. It also serves as an
example of how to use the new method invocation APIs with a single
"simple" type parameter.
---
src/hyperv/hyperv_driver.c| 123 ++
src/hyperv/hyperv_wmi.c | 7 ++
src/hy
Hey Laine,
Have some time to review this?
2017-06-23 1:44 GMT+01:00 :
> From: Alberto Ruiz
>
> Fixes #913446
>
> This patch addresses a few problems found by the initial reviews:
>
> * leaseTimeUnit RNG type renamed to timeUnit
> * virNetworkDHCPDefGetLeaseTime() renamed to virNetworkDHCPLeaseT
Changes from v5:
* Changes from review
* Fixed memory leak in hypervDomainSetMemory where params would leak in
failure case
Sri Ramanujam (5):
hyperv: Functions to work with invocation parameters.
hyperv: Generate object property type information.
hyperv: add hypervInvokeMethod
hyperv
This is only used in qemu_command.c, so move it, and clarify that
it's really about identifying if the serial config is a platform
device or not.
Signed-off-by: Cole Robinson
---
src/qemu/qemu_capabilities.c | 31 ---
src/qemu/qemu_capabilities.h | 4
src/qemu/q
Some qemu arch/machine types have built in platform devices that
are always implicitly available. For platform serial devices, the
current code assumes that only old style -serial config can be
used for these devices.
Apparently though since -chardev was introduced, we can use -chardev
in these ca
Several tests are intending to test some serial/console related
bits but aren't setting QEMU_CAPS_CHARDEV. This will soon be enabled
unconditionally so let's add it ahead of time.
* q35-virt-manager-basic: Intended to test a virt-manager q35 config,
which will include a serial/console device
*
On Sun, Jun 25, 2017 at 08:33:39AM -0400, John Ferlan wrote:
>
>
> On 06/24/2017 08:05 PM, Julio Faracco wrote:
> > My apologies. I didn't read the function logic.
> > The second error was introduced by my "fix".
> > The error with help parameter is happening.
> >
> > If --domain is required, I
Every qemu version we support has QEMU_CAPS_CHARDEV, so stop
explicitly tracking it and blacklist it like we've done for many
other feature flags.
Signed-off-by: Cole Robinson
---
src/qemu/qemu_capabilities.c | 17 +-
src/qemu/qemu_capabilities.h |
This demonstrates that the previous qemu caps changes will use
-chardev for pci-serial on aarch64 machvirt
Signed-off-by: Cole Robinson
---
.../qemuxml2argv-aarch64-pci-serial.args | 26 ++
.../qemuxml2argv-aarch64-pci-serial.xml| 17 ++
test
Rather than try to whitelist all device configs that can't use
-chardev, blacklist the only one that really can't, which is the
default serial/console target type=isa case.
ISA specifically isn't a valid config for arm/aarch64, but we've
always implicitly treated it to mean 'default platform devic
This reverts commit 70c9b44270f75bfb7a5701d81aa49380d139e8f0.
This commit breaks existing aarch64 machvirt configs with:
Which fails with:
error: Failed to start domain fedora25-aarch64
error: internal error: process exited while connecting to monitor:
2017-06-
These tests are exercising old style -serial command lines. That
code will soon be removed, so drop these tests.
Signed-off-by: Cole Robinson
---
.../qemuxml2argvdata/qemuxml2argv-serial-dev.args | 24
tests/qemuxml2argvdata/qemuxml2argv-serial-dev.xml | 38 ---
...
Several cases have incidental or XML which aren't
the features being tested for. Upcoming changes will cause some
churn here, so instead drop these bits now.
Signed-off-by: Cole Robinson
---
tests/qemuxml2argvdata/qemuxml2argv-bios-nvram-secure.args | 1 -
tests/qemuxml2argvdata/qemux
AFAIK there aren't any cases where we will/should hit the old code
path for our supported qemu versions, so drop the old code.
Massive test suite churn follows
Signed-off-by: Cole Robinson
---
src/qemu/qemu_command.c| 38 +++---
.../qemuxml2argv-aarch
AFAIK there aren't any cases where we should fail these checks with
supported qemu versions, so just drop them.
Signed-off-by: Cole Robinson
---
src/qemu/qemu_command.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_co
Drew pointed out that we can use -chardev with machvirt platform
serial devices like:
-chardev pty,id=foo
-serial chardev:foo
And indeed it looks like qemu has supported this for as long as -chardev
has been around. Wiring this up will enable all the modern -chardev
features for every machvir
AFAIK there aren't any qemu arch/machine types with platform parallel
devices that would require old style -parallel config, so we shouldn't
ever need this nowadays.
Remove a now redundant test
Signed-off-by: Cole Robinson
---
src/qemu/qemu_command.c| 33
Commit 54fa1b44afc8 added virDomainDeviceInfo::loadparm
and updated virDomainDeviceInfoClear() accordingly, but
omitted the necessary virDomainDeviceInfoCopy() changes.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_conf.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --
Introduced by commit 0832c58, with the intention to link with
the stack protector library.
Another instance introduced by commit 4cbc15d which separated
commandhelper_LDADD from LDADDS.
Not needed because per commit 71b54636, automake should pass
all the CFLAGS to the linker.
---
tests/Makefile.
On Fri, Jun 16, 2017 at 05:49:54PM +0200, Cedric Bosdonnat wrote:
> Quick note: next time you send a patch series, add a cover letter to it.
> You can get git to automatically ask you about one by running
>
> git config add format.coverletter auto
>
> Having reviewed them off-list first, ACK
On Mon, Jun 26, 2017 at 11:40:57AM +0200, Cédric Bosdonnat wrote:
> When running an application container, setting environment variables
> could be important.
>
> The newly introduced tag in domain configuration will allow
> setting environment variables to the init program.
> ---
> docs/formatd
On Fri, Jun 16, 2017 at 07:59:44PM +0530, Venkat Datta N H wrote:
> Docker Memory and VCPU configuration is converted to fit for LXC container
> XML configuration
> ---
> po/POTFILES.in | 1 +
> src/Makefile.am| 1 +
> sr
On Mon, Jun 26, 2017 at 10:10:55AM -0400, Cole Robinson wrote:
> On 06/24/2017 10:07 PM, Andrea Bolognani wrote:
> > On Sat, 2017-06-24 at 16:07 +0200, Christoffer Dall wrote:
> >> At this point I'm a little confused about how to proceed here. Would
> >> you like further evidence of an environment
On Mon, Jun 26, 2017 at 01:43:33PM +0200, Andrea Bolognani wrote:
> On Mon, 2017-06-26 at 13:19 +0200, Peter Krempa wrote:
[...]
> > > The rationale for tracking the generated file is to help out
> > > people who just cloned the git repository looking to contribue;
> > > however, README-hacking a
On 06/24/2017 10:07 PM, Andrea Bolognani wrote:
> On Sat, 2017-06-24 at 16:07 +0200, Christoffer Dall wrote:
>>> The way I see it, the bug is about libvirt being unable to
>>> launch guests which use the feature, and with
>>> that in mind your patch is correct but doesn't solve the
>>> issue, beca
On Mon, 2017-06-26 at 15:06 +0200, Andrew Jones wrote:
> > Cool, I'll have a look as well and will document my complete
> > environment, then hopefully we can diff with yours and see where this
> > ISA thing shows up.
>
> It's likely a pci-serial vs. isa-serial device getting created. Something
>
On 06/17/2017 09:15 PM, Eduardo Habkost wrote:
> (CCing qemu-devel and the QAPI maintainers. I have a question
> about introspection below.)
>
>
> Fortunately, netdev options are modelled in the QAPI schema as
> union Netdev. However, 'query-qmp-schema' doesn't seem to
> include union Netdev b
On Mon, Jun 26, 2017 at 01:12:03PM +0100, Daniel P. Berrange wrote:
> On Mon, Jun 26, 2017 at 01:47:04PM +0200, Erik Skultety wrote:
> > We do perform that magical check every time an event is received, but
> > unless we explicitly unref'd or disconnected the monitor, we should not
> > get a spurio
Hi, all:
i back port a patch which make qemu depends on util directory.
so i correct its dependency by applying a patch. but another error occur.
the patch is :
--- libvirt-2.0.0/src/Makefile.am 2016-06-27 22:12:20.523191076 +0800
+++ libvirt-2.0.0-ok/src/Makefile.am2017-06-22 12:25
On Sun, 2017-06-25 at 13:46 +0200, Christoffer Dall wrote:
>>On Sun, Jun 25, 2017 at 4:07 AM, Andrea Bolognani wrote:
>> On Sat, 2017-06-24 at 16:07 +0200, Christoffer Dall wrote:
>>> > The way I see it, the bug is about libvirt being unable to
>>> > launch guests which use the feature, and with
On Mon, 2017-06-26 at 13:23 +0200, Peter Krempa wrote:
> > The libvirt project welcomes contributions in many ways. For most
> >components
> > the best way to contribute is to send patches to the primary development
> > -mailing list, using the `git send-email` command. Further guidance on this
On Mon, Jun 26, 2017 at 01:47:04PM +0200, Erik Skultety wrote:
> We do perform that magical check every time an event is received, but
> unless we explicitly unref'd or disconnected the monitor, we should not
> get a spurious event from a different source.
>
> Signed-off-by: Erik Skultety
> ---
>
On Sun, 2017-06-25 at 16:00 -0400, Laine Stump wrote:
> Reviewed-by: Laine Stump
>
> (assuming name change from idx to targetIdx in all appropriate places)
I used 'targetIndex' instead, hopefully that doesn't
invalidate the R-b :)
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list
We do perform that magical check every time an event is received, but
unless we explicitly unref'd or disconnected the monitor, we should not
get a spurious event from a different source.
Signed-off-by: Erik Skultety
---
This is just a poke patch, since I also checked libudev's source and still f
On Mon, 2017-06-26 at 13:19 +0200, Peter Krempa wrote:
> > Despite being a generated file, HACKING has been tracked in
> > the git repository along with actual source files. As far as
> > I'm aware, it's the only generated file for which that happens.
> >
> > Times and times again, people[1] have
On Mon, Jun 26, 2017 at 12:24:45 +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> README.md | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
ACK
signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
htt
On Mon, Jun 26, 2017 at 12:24:44 +0200, Andrea Bolognani wrote:
> The use of 'git send-email' is described in detail in the
> contributor guidelines (docs/hacking.html), which are
> mentioned in docs/contribute.html, the non-local version
> of which is in turn mentioned in README.
>
> Signed-off-b
On Mon, Jun 26, 2017 at 12:24:43 +0200, Andrea Bolognani wrote:
> People looking to help out should really go through the
> contributor guidelines when getting started, so the more
> documents point to them the better.
>
> Signed-off-by: Andrea Bolognani
> ---
> docs/contribute.html.in | 4 +++-
On Mon, Jun 26, 2017 at 12:24:42 +0200, Andrea Bolognani wrote:
> Despite being a generated file, HACKING has been tracked in
> the git repository along with actual source files. As far as
> I'm aware, it's the only generated file for which that happens.
>
> Times and times again, people[1] have c
Allow user to define cachetune in domain xml.
V2 -> V1 changes:
* Redefine cachetune xml in domain xml.
* Create a struct for driver to talk with util/virresctrl.*
* Nit fixes
Eli Qiao (2):
Resctrl: Add new xml element to support cache tune
Resctrl: Do cache allocation while boot a qemu
Set cachetune if user define cachetune in domain xml when using qemu
driver.
This patch adds 3 major private interface.
virResctrlGetFreeCache: return free cache, default cache substract cache
allocated.
virResctrlSetCachetunes: set cache banks which defined in a domain.
v
This patch adds new xml element to support cache tune as:
...
...
cacheId: reference of the host's cache banks id, it's from capabilities
xml.
type:cache bank type, it could be both, code, data.
sizeKiB: must be multiple of granularity, must be greater than or equal
People looking to help out should really go through the
contributor guidelines when getting started, so the more
documents point to them the better.
Signed-off-by: Andrea Bolognani
---
docs/contribute.html.in | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/docs/contribute.
Despite being a generated file, HACKING has been tracked in
the git repository along with actual source files. As far as
I'm aware, it's the only generated file for which that happens.
Times and times again, people[1] have committed changes to
the source file without refreshing the generated copy
This has annoyed me for a very, very long time.
Andrea Bolognani (4):
HACKING: Drop from the git repository
docs: Point to hacking.html from contribute.html
README: Remove 'git send-email' mention
README: Various minor style tweaks
HACKING | 1112 -
Signed-off-by: Andrea Bolognani
---
README.md | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/README.md b/README.md
index 510646f..5fed0fd 100644
--- a/README.md
+++ b/README.md
@@ -20,7 +20,7 @@ mappings into object systems such as GObject, CIM and SNMP.
F
The use of 'git send-email' is described in detail in the
contributor guidelines (docs/hacking.html), which are
mentioned in docs/contribute.html, the non-local version
of which is in turn mentioned in README.
Signed-off-by: Andrea Bolognani
---
README.md | 3 +--
1 file changed, 1 insertion(+),
Some containers may want the application to run in a special directory.
Add element in the domain configuration to handle this case
and use it in the lxc driver.
---
docs/formatdomain.html.in| 5 +
docs/schemas/domaincommon.rng| 5 +
src/conf/domain_conf.c
Hi all,
Here is a series grouping several small patches I sent
independently to the mailing list.
Main change since v2:
* and have been changed to hold either a uid or
name as text child, rather than in an attribute.
* Moved the uid/gid setting to after the pivot_root to allow getting
virCommand is a version of virExec that doesn't fork, however it is
just calling execve and doesn't honors setting uid/gid and pwd.
This commit extrac those pieces from virExec() to a virExecCommon()
function that is called from both virExec() and virCommandExec().
---
src/util/vircommand.c | 69
Users may want to run the init command of a container as a special
user / group. This is achieved by adding and
elements. Note that the user can either provide a name or an ID to
specify the user / group to be used.
This commit also fixes a side effect of being able to run the command
as a non-r
When running an application container, setting environment variables
could be important.
The newly introduced tag in domain configuration will allow
setting environment variables to the init program.
---
docs/formatdomain.html.in| 5 +
docs/schemas/domaincommon.rng| 10 +
On Mon, Jun 26, 2017 at 09:08:03AM +0800, ZhenweiPi wrote:
> ---
>
> domain.go | 29 +
> domain_test.go | 4
> 2 files changed, 21 insertions(+), 12 deletions(-)
Thanks, applied to git.
Regards,
Daniel
--
|: https://berrange.com -o-https://www
On Mon, Jun 26, 2017 at 10:09:23AM +0800, zhenwei.pi wrote:
> ---
> domain.go | 5 +++--
> domain_test.go | 14 ++
> 2 files changed, 17 insertions(+), 2 deletions(-)
Thanks, applied to git
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/d
On Mon, 2017-06-26 at 14:19 +0530, Shivaprasad bhat wrote:
> >
> > +/**
> > + * qemuDomainAddressFindNewTargetIndex:
> > + * @def: domain definition
> > + *
> > + * Find a target index that can be used for a PCI controller.
> > + *
> > + * Returns: an unused target index, or -1 if all available ta
>
>
> +/**
> + * qemuDomainAddressFindNewTargetIndex:
> + * @def: domain definition
> + *
> + * Find a target index that can be used for a PCI controller.
> + *
> + * Returns: an unused target index, or -1 if all available target
> + * indexes are already taken.
> + */
> +static int
> +qem
On Sun, Jun 25, 2017 at 09:57:43 -0400, John Ferlan wrote:
>
>
> On 06/20/2017 12:48 PM, Jiri Denemark wrote:
> > While qemuProcessIncomingDefNew takes an fd argument and stores it in
> > qemuProcessIncomingDef structure, the caller is still responsible for
> > closing the file descriptor.
> >
>
Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
README.md | 1 -
1 file changed, 1 deletion(-)
diff --git a/README.md b/README.md
index 1035bcf..d0ce149 100644
--- a/README.md
+++ b/README.md
@@ -54,7 +54,6 @@ $ make
$ make install
```
-
The libvirt code relies on a large number of
On Fri, Jun 23, 2017 at 02:50:24PM +0200, Ján Tomko wrote:
On Fri, Jun 23, 2017 at 02:32:39PM +0200, Peter Krempa wrote:
From: Martin Kletzander
Signed-off-by: Martin Kletzander
---
src/util/virstring.c | 114 +--
1 file changed, 75 insertions(+)
76 matches
Mail list logo
