[libvirt] [PATCH RESEND RFC V2 1/2] Resctrl: Add new xml element to support cache tune

2017-07-04 Thread Eli Qiao
This patch adds new xml element to support cache tune as: ... ... cacheId: reference of the host's cache banks id, it's from capabilities xml. type:cache bank type, it could be both, code, data. sizeKiB: must be multiple of granularity, must be greater than or equal

[libvirt] [PATCH RESEND RFC V2 0/2] Implement l3 CAT

2017-07-04 Thread Eli Qiao
Allow user to define cachetune in domain xml. RESEND: * Fix stupid complile problem pointed out by Martin, check and syntax-check passed. V2 -> V1 changes: * Redefine cachetune xml in domain xml. * Create a struct for driver to talk with util/virresctrl.* * Nit fixes Eli Qiao (2):

[libvirt] [PATCH RESEND RFC V2 2/2] Resctrl: Do cache allocation while boot a qemu VM

2017-07-04 Thread Eli Qiao
Set cachetune if user define cachetune in domain xml when using qemu driver. This patch adds 3 major private interface. virResctrlGetFreeCache: return free cache, default cache substract cache allocated. virResctrlSetCachetunes: set cache banks which defined in a domain.

[libvirt] Release of libvirt-3.5.0

2017-07-04 Thread Daniel Veillard
As planned, it is out, I tagged it in git and pushed signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ I also made a release 3.5.0 of the python bindings with minimal changes compared to 3.4.0, it can be found at: ftp://libvirt.org/libvirt/python/ This is a

Re: [libvirt] Entering freeze for libvirt-3.5.0

2017-07-04 Thread Daniel P. Berrange
On Tue, Jul 04, 2017 at 06:26:22PM +0100, Daniel P. Berrange wrote: > On Tue, Jul 04, 2017 at 05:32:03PM +0100, Daniel P. Berrange wrote: > > On Tue, Jul 04, 2017 at 12:21:21PM +0100, Daniel P. Berrange wrote: > > So I did some debugging and this is wierder than I can imagine possible. > > > > I

Re: [libvirt] Entering freeze for libvirt-3.5.0

2017-07-04 Thread Daniel P. Berrange
On Tue, Jul 04, 2017 at 05:32:03PM +0100, Daniel P. Berrange wrote: > On Tue, Jul 04, 2017 at 12:21:21PM +0100, Daniel P. Berrange wrote: > > On Tue, Jul 04, 2017 at 01:03:52PM +0200, Andrea Bolognani wrote: > > > On Sat, 2017-07-01 at 14:18 +0400, Roman Bogorodskiy wrote: > > > > >

Re: [libvirt] Entering freeze for libvirt-3.5.0

2017-07-04 Thread Daniel P. Berrange
On Tue, Jul 04, 2017 at 12:21:21PM +0100, Daniel P. Berrange wrote: > On Tue, Jul 04, 2017 at 01:03:52PM +0200, Andrea Bolognani wrote: > > On Sat, 2017-07-01 at 14:18 +0400, Roman Bogorodskiy wrote: > > > > qemuxml2argvtest fails consistently in my FreeBSD guest. > > >  > > > I guess that's

Re: [libvirt] [PATCH v3 4/4] lxc: add possibility to define init uid/gid

2017-07-04 Thread Daniel P. Berrange
On Mon, Jun 26, 2017 at 11:41:00AM +0200, Cédric Bosdonnat wrote: > Users may want to run the init command of a container as a special > user / group. This is achieved by adding and > elements. Note that the user can either provide a name or an ID to > specify the user / group to be used. > >

Re: [libvirt] [PATCH v3 3/4] lxc: allow user to specify command working directory

2017-07-04 Thread Daniel P. Berrange
On Mon, Jun 26, 2017 at 11:40:59AM +0200, Cédric Bosdonnat wrote: > Some containers may want the application to run in a special directory. > Add element in the domain configuration to handle this case > and use it in the lxc driver. > --- > docs/formatdomain.html.in| 5 + >

[libvirt] [PATCH] autogen.sh: tell user the correct make command

2017-07-04 Thread Daniel P. Berrange
When autogen.sh finishes it helpfully prints "Now type 'make' to compile libvirt." which is fine if on a host with GNU make, but on *BSD running 'make' will end in tears. We should tell users to run 'gmake' on these platforms. If 'gmake' doesn't exist then we should report an error too "GNU

Re: [libvirt] libvirt binding for DBUS

2017-07-04 Thread Daniel P. Berrange
On Tue, Jul 04, 2017 at 04:34:08PM +0200, Pavel Hrdina wrote: > Hi, > > Last week (Jun 26 - Jun 30) there was a Cockpit Hackfest and the main > topic was integration virtualization support into Cockpit. For that > purpose Lars and me have started to work on a new libvirt dbus binding. > >

[libvirt] libvirt binding for DBUS

2017-07-04 Thread Pavel Hrdina
Hi, Last week (Jun 26 - Jun 30) there was a Cockpit Hackfest and the main topic was integration virtualization support into Cockpit. For that purpose Lars and me have started to work on a new libvirt dbus binding. Currently the binding is written manually and only few APIs are supported,

Re: [libvirt] [PATCH v3 19/26] tests: Add tests for pSeries guests with multiple PHBs

2017-07-04 Thread Andrea Bolognani
On Fri, 2017-06-23 at 23:03 +0800, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- >  .../qemuxml2argv-pseries-phb-default-missing.args  | 22 +++ >  .../qemuxml2argv-pseries-phb-default-missing.xml   | 16 +++ >  

[libvirt] [PATCH] tests: Add DO_TEST_PARSE_ERROR() to qemuxml2xml

2017-07-04 Thread Andrea Bolognani
qemuxml2argv already supports the ability to include test cases that are known not to make it past XML parsing, and since we want to keep qemuxml2xml in sync with it as much as possible, we need to implement this missing feature. Signed-off-by: Andrea Bolognani ---

Re: [libvirt] [PATCH v3 13/26] conf: Parse and format

2017-07-04 Thread Andrea Bolognani
On Fri, 2017-06-30 at 17:10 +0530, Shivaprasad bhat wrote: > > @@ -9348,6 +9351,23 @@ virDomainControllerDefParseXML(xmlNodePtr node, > >  goto error; > >  } > >  } > > +if (idx) { > > +if (virStrToLong_i(idx, NULL, 0, > > +   

Re: [libvirt] Entering freeze for libvirt-3.5.0

2017-07-04 Thread Daniel P. Berrange
On Tue, Jul 04, 2017 at 01:03:52PM +0200, Andrea Bolognani wrote: > On Sat, 2017-07-01 at 14:18 +0400, Roman Bogorodskiy wrote: > > > qemuxml2argvtest fails consistently in my FreeBSD guest. > >  > > I guess that's caused by clang inlining functions that are mocked > > (specifically, some numa

Re: [libvirt] Entering freeze for libvirt-3.5.0

2017-07-04 Thread Andrea Bolognani
On Sat, 2017-07-01 at 14:18 +0400, Roman Bogorodskiy wrote: > > qemuxml2argvtest fails consistently in my FreeBSD guest. >  > I guess that's caused by clang inlining functions that are mocked > (specifically, some numa related stuff); I think that was discussed > several times already. Anyway, it

[libvirt] [PATCH 5/5] tests: virjson: Test string escaping

2017-07-04 Thread Peter Krempa
Make sure that JSON strings can contain characters which need to be escaped (double quotes, backslashes, tabs, etc.) and that JSON objects formatted into strings can be nested into strings. --- tests/virjsontest.c | 67 + 1 file changed, 67

[libvirt] [PATCH 4/5] tests: virjson: Test formatting along with parsing of JSON objects

2017-07-04 Thread Peter Krempa
Format the parsed string back and compare it to the original (or modified) string for back and forth comparison. --- tests/virjsontest.c | 58 - 1 file changed, 44 insertions(+), 14 deletions(-) diff --git a/tests/virjsontest.c

[libvirt] [PATCH 2/5] tests: virjson: Modify logic in testJSONFromString

2017-07-04 Thread Peter Krempa
To allow better testing in case where the string was parsed, modify the logic so that the regular code path is not included in a conditional block. --- tests/virjsontest.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/tests/virjsontest.c

[libvirt] [PATCH 3/5] tests: virjson: Remove spaces from 'very-hard' parsing example

2017-07-04 Thread Peter Krempa
The example is rather long and upcomming patch will check whether the string can be formatted back. As the formatted string lacks spaces and adding the 'expect' string with spaces would be rather long, just drop spaces from this test case. There are other test cases which do contain spaces. ---

[libvirt] [PATCH 1/5] tests: Rename jsontest to virjsontest

2017-07-04 Thread Peter Krempa
--- tests/Makefile.am | 8 tests/{jsontest.c => virjsontest.c} | 0 2 files changed, 4 insertions(+), 4 deletions(-) rename tests/{jsontest.c => virjsontest.c} (100%) diff --git a/tests/Makefile.am b/tests/Makefile.am index 19986dc99..3596b5ff1 100644 ---

[libvirt] [PATCH 0/5] tests: json: Improve testing of parsing and formatting

2017-07-04 Thread Peter Krempa
For an experiment I was doing I needed to nest JSON string into an attribute of a different JSON string, so I wrote some tests for that. The experiment failed, but the tests may make sense to have in libvirt. Peter Krempa (5): tests: Rename jsontest to virjsontest tests: virjson: Modify

Re: [libvirt] Entering freeze for libvirt-3.5.0

2017-07-04 Thread Andrea Bolognani
On Mon, 2017-07-03 at 18:47 +0200, Guido Günther wrote: > > > Anyway, I'll try to find a way to debug what's going on with > > > virnetsockettest. > >  > > IIRC Debian disabled this test years ago. > >  > > Guido, have you ever discovered the cause? >  > No, sorry. I diabled it ages ago since it

Re: [libvirt] [PATCH 1/6] lib: Remove misplaced and redundant comments

2017-07-04 Thread Peter Krempa
On Sat, Jul 01, 2017 at 10:41:24 -0400, John Ferlan wrote: > > > On 06/23/2017 09:33 AM, Peter Krempa wrote: > > It's obvious that unsigned long long is 64 bit and also our web page > > generator would misplace the comment after the return value due to the > > way it's parsing them. > > --- > >

Re: [libvirt] [PATCH 00/12] qemu: support chardev for all machvirt config

2017-07-04 Thread Christoffer Dall
Hi Cole, On Mon, Jun 26, 2017 at 02:01:41PM -0400, Cole Robinson wrote: > Drew pointed out that we can use -chardev with machvirt platform > serial devices like: > > -chardev pty,id=foo > -serial chardev:foo > > And indeed it looks like qemu has supported this for as long as -chardev > has

[libvirt] [PATCH go-xml] Add support for device RNG

2017-07-04 Thread Thomas Hipp
Add support for device RNG (random number generator), and add test code. Signed-off-by: Thomas Hipp --- domain.go | 34 +++ domain_test.go | 85 ++ 2 files changed, 119 insertions(+) diff --git

Re: [libvirt] [PATCH] news: CPU add migration fix into Bug fixes

2017-07-04 Thread Andrea Bolognani
On Tue, 2017-07-04 at 09:14 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- >  docs/news.xml | 12 >  1 file changed, 12 insertions(+) >  > diff --git a/docs/news.xml b/docs/news.xml > index f38abeb91d..f590d9cdfc 100644 > --- a/docs/news.xml > +++

Re: [libvirt] [PATCH v3 25/26] qemu: Isolate hostdevs on pSeries guests

2017-07-04 Thread David Gibson
On Thu, 29 Jun 2017 17:37:30 +0200 Andrea Bolognani wrote: > On Wed, 2017-06-28 at 18:22 -0400, Laine Stump wrote: > [...] > [...] > > Right, I hadn't considered that case. I'll make sure it is > handled correctly. > > [...] > > Hm, that's quite a pickle. > >

[libvirt] [PATCH] news: CPU add migration fix into Bug fixes

2017-07-04 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- docs/news.xml | 12 1 file changed, 12 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index f38abeb91d..f590d9cdfc 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -197,6 +197,18 @@ QEMU releases older than