Re: [libvirt] [PATCH 06/17] nwfilter: Add configFile into virNWFilterObj

On 07/13/2017 10:41 AM, Michal Privoznik wrote: > On 06/02/2017 12:25 PM, John Ferlan wrote: >> When creating an object, save the configFile name in the object rather >> than needing to build it up each time for the SaveConfig. This involves >> adding a @configDir parameter to

Re: [libvirt] [PATCH 05/17] nwfilter: Move virNWFilterSaveConfig virnwfilterobj

On 07/13/2017 10:41 AM, Michal Privoznik wrote: > On 06/02/2017 12:25 PM, John Ferlan wrote: >> Move the function into nwfilterobj, rename it to virNWFilterObjSaveConfig, >> and alter the order of the arguments. >> >> Signed-off-by: John Ferlan >> --- >>

Re: [libvirt] [PATCH 03/17] nwfilter: Fix possible locking problem in LoadConfig error path

On 07/13/2017 10:41 AM, Michal Privoznik wrote: > On 06/02/2017 12:25 PM, John Ferlan wrote: >> After returning from virNWFilterObjListAssignDef the @obj is locked; >> however, if virNWFilterSaveConfig fails to save the generated UUID >> the code jumped to error and returns NULL meaning the

Re: [libvirt] [PATCH 02/17] nwfilter: Fix possible corruption on failure path during LoadConfig

On 07/13/2017 10:41 AM, Michal Privoznik wrote: > On 06/02/2017 12:25 PM, John Ferlan wrote: >> If the virNWFilterSaveConfig in virNWFilterObjListLoadConfig, then jumping > > s/,/ fails,/ > >> to the error label would free the @def owned by the object, but the object >> is still on the list.

Re: [libvirt] [PATCH v4 14/14] nodedev: Remove driver locks around object list mgmt code

On 07/11/2017 10:38 AM, Erik Skultety wrote: > On Mon, Jul 03, 2017 at 05:25:30PM -0400, John Ferlan wrote: >> Since virnodedeviceobj now has a self-lockable hash table, there's no >> need to lock the table from the driver for processing. Thus remove the >> locks from the driver for

Re: [libvirt] [PATCH v4 12/14] nodedev: Convert virNodeDeviceObj to use virObjectLockable

On 07/11/2017 10:38 AM, Erik Skultety wrote: > On Mon, Jul 03, 2017 at 05:25:28PM -0400, John Ferlan wrote: >> Now that we have a bit more control, let's convert our object into >> a lockable object and let that magic handle the create and lock/unlock. >> >> This also involves creating a

Re: [libvirt] [PATCH 11/19] storage: Introduce virStoragePoolObjNew

On 07/11/2017 11:17 AM, Pavel Hrdina wrote: > On Tue, May 09, 2017 at 11:30:18AM -0400, John Ferlan wrote: >> Create/use a helper to perform object allocation. >> >> Signed-off-by: John Ferlan >> --- >> src/conf/virstorageobj.c | 34 +++--- >> 1

Re: [libvirt] [PATCH 07/19] storage: Use consistent variable names in virstorageobj

On 07/12/2017 04:17 AM, Pavel Hrdina wrote: > On Tue, May 09, 2017 at 11:30:14AM -0400, John Ferlan wrote: >> A virStoragePoolObjPtr will be an 'obj'. >> >> A virStoragePoolPtr will be a 'pool'. > > There is no such change in this commit. > Simple enough to remove. >> >> NB: Also modify the

Re: [libvirt] [PATCH 04/19] test: Add helpers to fetch active/inactive storage pool by name

On 07/11/2017 07:30 AM, Pavel Hrdina wrote: > On Tue, May 09, 2017 at 11:30:11AM -0400, John Ferlan wrote: >> Rather than have repetitive code - create/use a couple of helpers: >> >> testStoragePoolObjFindActiveByName and testStoragePoolObjFindInactiveByName > > I would wrap this line, it's too

Re: [libvirt] [PATCH 1/2] qemu: Add AAVMF32 to the list of known UEFIs

On Mon, Jul 10, 2017 at 12:23 PM, John Ferlan wrote: > > > On 06/28/2017 12:02 PM, dann frazier wrote: >> Add a path for UEFI VMs for AArch32 VMs. This is the path Debian is >> currently using in experimental. libvirt is the de facto canonical > > "experimental"? Hi John!

Re: [libvirt] [PATCH 03/19] test: Cleanup exit/failure paths of some storage pool APIs

On 07/11/2017 04:33 AM, Pavel Hrdina wrote: > On Tue, May 09, 2017 at 11:30:10AM -0400, John Ferlan wrote: >> Rework some of the test driver API's to remove the need to return failure >> when testStoragePoolObjFindByName returns NULL rather than going to cleanup. >> This removes the need for

Re: [libvirt] [PATCH 02/19] test: Use consistent variable names for storage test driver APIs

On 07/11/2017 04:27 AM, Pavel Hrdina wrote: > On Tue, May 09, 2017 at 11:30:09AM -0400, John Ferlan wrote: >> A virStoragePoolObjPtr will be an 'obj'. >> >> A virStoragePoolPtr will be a 'pool'. >> >> Signed-off-by: John Ferlan >> --- >> src/test/test_driver.c | 443 >>

Re: [libvirt] [PATCH] leasetime support for

Sorry this keeps falling off the radar... When posting a v2/v3/vX, please use [PATCH v2] prefix, and make each new posting a top level patch On 06/22/2017 08:44 PM, ar...@gnome.org wrote: > From: Alberto Ruiz > > Fixes #913446 > Full bug link makes things slightly easier if

Re: [libvirt] [PATCH 8/8] secret: Handle object list removal and deletion properly

On 07/11/2017 11:52 AM, Michal Privoznik wrote: > On 06/03/2017 03:27 PM, John Ferlan wrote: >> Rather than rely on virSecretObjEndAPI to make the final virObjectUnref >> after the call virSecretObjListRemove, be more explicit by calling >> virObjectUnref and setting @obj to NULL for

[libvirt] Regarding docs for Adding new Hypervisor support

Hello all, I would start to work on adding z/vm hypervisor to libvirt. I am currently going through libvirt source code and found that I need to add a new driver implementation for z/VM hypervisor. Can you please let me know the best way to add a driver to libvirt. Basically looking for a head

Re: [libvirt] [PATCH 7/8] secret: Properly handle @def after virSecretObjAdd in driver

On 07/11/2017 11:52 AM, Michal Privoznik wrote: > On 06/03/2017 03:27 PM, John Ferlan wrote: >> Since the virSecretObjListAdd technically consumes @def on success, >> the secretDefineXML should fetch the @def from the object afterwards >> and manage as an @objdef and set @def = NULL immediately.

Re: [libvirt] [PATCH 6/8] secret: Have virSecretObjNew consume newdef

On 07/11/2017 11:52 AM, Michal Privoznik wrote: > On 06/03/2017 03:27 PM, John Ferlan wrote: >> Move the consumption of @newdef into virSecretObjNew and then handle that >> in the calling path. Because on error the calling code expects to free >> @newdef, unset obj->def for the creation failure

Re: [libvirt] [PATCH v2 0/4] Add setting CPU features (CPUID) with libxenlight driver.

On Tue, Jul 04, 2017 at 05:03:43AM +0200, Marek Marczykowski-Górecki wrote: > Tests (patches 3 and 4) depends on libxl_domain_config test suite: > https://www.redhat.com/archives/libvir-list/2017-February/msg01477.html > > But first two patches can be applied independently. Anything missing

Re: [libvirt] [PATCH 4/8] secret: Clean up virSecretObjListAdd processing

On 07/11/2017 11:52 AM, Michal Privoznik wrote: > On 06/03/2017 03:27 PM, John Ferlan wrote: >> Make use of an error: label to handle the failure and need to call >> virSecretObjEndAPI for the object to set it to NULL for return. >> >> Also rather than an if/else processing - have the initial

Re: [libvirt] [PATCH 0/3] libxl: Add a test suite for libxl_domain_config generator

On Sun, Jul 02, 2017 at 04:16:02AM +0200, Marek Marczykowski-Górecki wrote: > On Sun, Feb 26, 2017 at 07:02:24PM -0700, Jim Fehlig wrote: > > Long ago danpb posted some patches to test libvirt domXML to > > libxl_domain_config conversion > > > >

Re: [libvirt] [PATCH 01/17] nwfilter: Fix return value comparison for virNWFilterTriggerVMFilterRebuild

On 06/02/2017 12:25 PM, John Ferlan wrote: > Should compare < 0 to be correct. > > Signed-off-by: John Ferlan > --- > src/conf/virnwfilterobj.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) ACK. Trivial. Michal -- libvir-list mailing list

Re: [libvirt] [PATCH 08/17] nwfilter: Clean up a couple nwfilter_driver error paths

On 06/02/2017 12:25 PM, John Ferlan wrote: > No need to goto cleanup and check "if (obj)" if we know (obj) isn't there, > so just return immediately. > > Signed-off-by: John Ferlan > --- > src/nwfilter/nwfilter_driver.c | 15 ++- > 1 file changed, 6

Re: [libvirt] [PATCH 05/17] nwfilter: Move virNWFilterSaveConfig virnwfilterobj

On 06/02/2017 12:25 PM, John Ferlan wrote: > Move the function into nwfilterobj, rename it to virNWFilterObjSaveConfig, > and alter the order of the arguments. > > Signed-off-by: John Ferlan > --- > src/conf/nwfilter_conf.c | 27 --- >

Re: [libvirt] [PATCH 04/17] nwfilter: Remove need for virNWFilterSaveXML

On 06/02/2017 12:25 PM, John Ferlan wrote: > Merge code into virNWFilterSaveConfig > > Signed-off-by: John Ferlan > --- > src/conf/nwfilter_conf.c | 30 +++--- > src/conf/nwfilter_conf.h | 5 - > 2 files changed, 7 insertions(+), 28 deletions(-)

Re: [libvirt] [PATCH 12/17] nwfilter: Rename _virNWFilterInstantiateFilter

On 06/02/2017 12:25 PM, John Ferlan wrote: > New API will be virNWFilterInstantiateFilterInternal as it's called from > the virNWFilterInstantiateFilter and virNWFilterUpdateInstantiateFilter. > > Signed-off-by: John Ferlan > --- > src/nwfilter/nwfilter_gentech_driver.c | 28

Re: [libvirt] [PATCH 06/17] nwfilter: Add configFile into virNWFilterObj

On 06/02/2017 12:25 PM, John Ferlan wrote: > When creating an object, save the configFile name in the object rather > than needing to build it up each time for the SaveConfig. This involves > adding a @configDir parameter to virNWFilterObjListAssignDef and removing > the @configDir from

Re: [libvirt] [PATCH 09/17] nwfilter: Consistently name virNWFilterPtr in driver

On 06/02/2017 12:25 PM, John Ferlan wrote: > Use @nwfilter always for the name > > Signed-off-by: John Ferlan > --- > src/nwfilter/nwfilter_driver.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) Okay, not much value, but at least we are

Re: [libvirt] [PATCH 03/17] nwfilter: Fix possible locking problem in LoadConfig error path

On 06/02/2017 12:25 PM, John Ferlan wrote: > After returning from virNWFilterObjListAssignDef the @obj is locked; > however, if virNWFilterSaveConfig fails to save the generated UUID > the code jumped to error and returns NULL meaning the caller will > not call virNWFilterObjUnlock on the object

Re: [libvirt] [PATCH 16/17] nwfilter: Remove recursive locking for nwfilter instantiation

On 06/02/2017 12:25 PM, John Ferlan wrote: > The current algorithm required usage of recursive locks because there > was no other mechanism available to ensure that the object wasn't deleted > whilst the instantiation was taking place. > > Now that we have object references, lets use those to

Re: [libvirt] [PATCH 11/17] nwfilter: Rename __virNWFilterInstantiateFilter

On 06/02/2017 12:25 PM, John Ferlan wrote: > Rename to virNWFilterInstantiateFilterUpdate and alter the callers to not > have one parameter per line. > > Signed-off-by: John Ferlan > --- > src/nwfilter/nwfilter_gentech_driver.c | 62 > +- > 1

Re: [libvirt] [PATCH 07/17] nwfilter: Add @def into virNWFilterObjNew

On 06/02/2017 12:25 PM, John Ferlan wrote: > Modify the virNWFilterObjNew to take @def as a parameter and consume it. > > Signed-off-by: John Ferlan > --- > src/conf/virnwfilterobj.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) As I've stated in the

Re: [libvirt] [PATCH 14/17] nwfilter: Add @refs logic to __virNWFilterObj

On 06/02/2017 12:25 PM, John Ferlan wrote: > "Simple" conversion to the virObjectLockable object isn't quite possible > yet because the nwfilter lock requires usage of recursive locking due to > algorithms handing filter ""'s and ""'s. The list search > logic would also benefit from using hash

Re: [libvirt] [PATCH 10/17] nwfilter: Rename virNWFilterInstantiate

On 06/02/2017 12:25 PM, John Ferlan wrote: > Rename to virNWFilterDoInstantiate to better describe the action. > > Also fix the @vmuuid parameter to not have the ATTRIBUTE_UNUSED since it > is used in the call to virNWFilterDHCPSnoopReq. > > Signed-off-by: John Ferlan > ---

Re: [libvirt] [PATCH 13/17] nwfilter: Introduce virNWFilterObjListFindInstantiateFilter

On 06/02/2017 12:25 PM, John Ferlan wrote: > Create a common API to handle the instantiation path filter lookup. > > Signed-off-by: John Ferlan > --- > src/conf/virnwfilterobj.c | 23 +++ > src/conf/virnwfilterobj.h | 4 ++ >

Re: [libvirt] [PATCH 15/17] nwfilter: Convert _virNWFilterObjList to be a virObjectLockable

On 06/02/2017 12:25 PM, John Ferlan wrote: > Perhaps a bit out of order from the normal convert driver object to > virObjectLockable, then convert the driver object list. However, as > it turns out nwfilter objects have been using a recursive mutex for > which the common virObject code does not

Re: [libvirt] [PATCH 17/17] nwfilter: Convert virNWFilterObj to use virObjectLockable

On 06/02/2017 12:25 PM, John Ferlan wrote: > Now that we have a bit more control, let's convert our object into a > recursive lockable object and let that magic handle the create and > lock/unlock. > > Additionally, we introduce virNWFilterObjEndAPI. > > Signed-off-by: John Ferlan

Re: [libvirt] [PATCH v4 14/14] nodedev: Remove driver locks around object list mgmt code

> /* Populate with known devices */ > This commentary should stay with the function it describes (below), so the context doesn't get lost. Erik > +nodeDeviceUnlock(); > if (udevEnumerateDevices(udev) != 0) > goto cleanup; > > -ret = 0; > +return 0; > > cleanup:

Re: [libvirt] [PATCH] qemu: Default hwclock source for sPAPR to RTC

On 07/13/2017 09:52 AM, Madhu Pavan wrote: > > > On 07/13/2017 05:49 PM, Cole Robinson wrote: >> On 07/13/2017 04:36 AM, Kothapally Madhu Pavan wrote: >>> QEMU fails to launch a sPAPR guest with clock sources other that RTC. >>> Internally qemu only uses RTC timer for hwclock. This patch reports

Re: [libvirt] [PATCH] qemu: Default hwclock source for sPAPR to RTC

On 07/13/2017 05:49 PM, Cole Robinson wrote: On 07/13/2017 04:36 AM, Kothapally Madhu Pavan wrote: QEMU fails to launch a sPAPR guest with clock sources other that RTC. Internally qemu only uses RTC timer for hwclock. This patch reports the right error message instead of qemu erroring out

Re: [libvirt] [PATCH] Rewrite the way mockable functions are handled.

On Thu, Jul 13, 2017 at 02:33:57PM +0200, Martin Kletzander wrote: > On Thu, Jul 13, 2017 at 12:25:50PM +0100, Daniel P. Berrange wrote: > > On Thu, Jul 13, 2017 at 01:14:12PM +0200, Martin Kletzander wrote: > > > On Wed, Jul 12, 2017 at 05:06:22PM +0100, Daniel P. Berrange wrote: > > > >

Re: [libvirt] [PATCH] Rewrite the way mockable functions are handled.

On Thu, Jul 13, 2017 at 12:25:50PM +0100, Daniel P. Berrange wrote: On Thu, Jul 13, 2017 at 01:14:12PM +0200, Martin Kletzander wrote: On Wed, Jul 12, 2017 at 05:06:22PM +0100, Daniel P. Berrange wrote: > Currently any mockable functions are marked with attributes > noinline, noclone and weak.

Re: [libvirt] [PATCH] qemu: Default hwclock source for sPAPR to RTC

On 07/13/2017 04:36 AM, Kothapally Madhu Pavan wrote: > QEMU fails to launch a sPAPR guest with clock sources other that RTC. > Internally qemu only uses RTC timer for hwclock. This patch reports > the right error message instead of qemu erroring out when any other > timer other than RTC is used.

Re: [libvirt] [PATCH 2/2] Revert "Prevent more compiler optimization of mockable functions"

On Thu, Jul 13, 2017 at 07:52:56AM -0400, Marc-André Lureau wrote: > > > - Original Message - > > > > FYI, I intend to push these revert patches, so that virtlogd stops > > crashing to unblock other devs/users, while we focus on writing & > > reviewing the new approach we've discussed >

Re: [libvirt] [PATCH 2/2] Revert "Prevent more compiler optimization of mockable functions"

- Original Message - > On Wed, Jul 12, 2017 at 01:49:04PM +0200, Martin Kletzander wrote: > > On Wed, Jul 12, 2017 at 01:10:08PM +0200, Martin Kletzander wrote: > > > On Wed, Jul 12, 2017 at 11:14:16AM +0100, Daniel P. Berrange wrote: > > > > This reverts commit

Re: [libvirt] [PATCH 2/2] Revert "Prevent more compiler optimization of mockable functions"

On Thu, Jul 13, 2017 at 12:28:41PM +0100, Daniel P. Berrange wrote: On Wed, Jul 12, 2017 at 01:49:04PM +0200, Martin Kletzander wrote: On Wed, Jul 12, 2017 at 01:10:08PM +0200, Martin Kletzander wrote: > On Wed, Jul 12, 2017 at 11:14:16AM +0100, Daniel P. Berrange wrote: > > This reverts commit

Re: [libvirt] [PATCH 2/2] Revert "Prevent more compiler optimization of mockable functions"

On Wed, Jul 12, 2017 at 01:49:04PM +0200, Martin Kletzander wrote: > On Wed, Jul 12, 2017 at 01:10:08PM +0200, Martin Kletzander wrote: > > On Wed, Jul 12, 2017 at 11:14:16AM +0100, Daniel P. Berrange wrote: > > > This reverts commit e4b980c853d2114b25fa805a84ea288384416221. > > > > > > When a

Re: [libvirt] [PATCH] Rewrite the way mockable functions are handled.

On Thu, Jul 13, 2017 at 01:14:12PM +0200, Martin Kletzander wrote: > On Wed, Jul 12, 2017 at 05:06:22PM +0100, Daniel P. Berrange wrote: > > Currently any mockable functions are marked with attributes > > noinline, noclone and weak. This prevents the compiler from > > optimizing away the impl of

Re: [libvirt] [PATCH] Rewrite the way mockable functions are handled.

On Wed, Jul 12, 2017 at 05:06:22PM +0100, Daniel P. Berrange wrote: Currently any mockable functions are marked with attributes noinline, noclone and weak. This prevents the compiler from optimizing away the impl of these functions. It has an unfortunate side effect with the libtool convenience

[libvirt] [PATCH] tests: add virjsondata to EXTRA_DIST

Signed-off-by: Daniel P. Berrange --- Pushed as a build fix for RPM builds tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/Makefile.am b/tests/Makefile.am index 3596b5ff1..efc1a310d 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@

Re: [libvirt] [PATCH 0/2] Revert use of weak symbols

On Thu, Jul 13, 2017 at 10:13:25AM +0200, Michal Privoznik wrote: > On 07/12/2017 12:14 PM, Daniel P. Berrange wrote: > > This series reverts the use of the __weak__ attribute which we did > > to fix the test suite with CLang. It cause unintended problems > > elsewhere which are not practical to

[libvirt] [PATCH] qemu: Default hwclock source for sPAPR to RTC

QEMU fails to launch a sPAPR guest with clock sources other that RTC. Internally qemu only uses RTC timer for hwclock. This patch reports the right error message instead of qemu erroring out when any other timer other than RTC is used. Signed-off-by: Kothapally Madhu Pavan

Re: [libvirt] [PATCH] util: Don't leak linksrc in vircgroup

On 07/13/2017 10:04 AM, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > src/util/vircgroup.c | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) ACK Michal -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 0/2] Revert use of weak symbols

On 07/12/2017 12:14 PM, Daniel P. Berrange wrote: > This series reverts the use of the __weak__ attribute which we did > to fix the test suite with CLang. It cause unintended problems > elsewhere which are not practical to fix. See the second patch > for details. > > Daniel P. Berrange (2): >

[libvirt] [PATCH] util: Don't leak linksrc in vircgroup

Signed-off-by: Martin Kletzander --- src/util/vircgroup.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index a53908fc9246..2912fc9be539 100644 --- a/src/util/vircgroup.c +++

Re: [libvirt] [PATCH 2/2] Revert "Prevent more compiler optimization of mockable functions"

On Wed, Jul 12, 2017 at 05:07:56PM +0100, Daniel P. Berrange wrote: On Wed, Jul 12, 2017 at 01:56:47PM +0200, Martin Kletzander wrote: Also, having the weak alias we can drop all the mocks and the problems with them and just redefine the functions we would like to mock in the tests (see

Re: [libvirt] [PATCH 7/7] qemu: Update host-model CPUs on reconnect

On Wed, Jul 12, 2017 at 16:42:36 +0200, Pavel Hrdina wrote: > On Wed, Jul 12, 2017 at 02:56:53PM +0200, Jiri Denemark wrote: > > When libvirt starts a new QEMU domain, it replaces host-model CPUs with > > the appropriate custom CPU definition. However, when reconnecting to a > > domain started by

[libvirt] [PATCH] Add support for virtio-net.tx_queue_size

https://bugzilla.redhat.com/show_bug.cgi?id=1460323 Just like I've added support for setting rx_queue_size (in c56cdf259 and friends), qemu just gained support for setting tx ring size. Signed-off-by: Michal Privoznik --- docs/formatdomain.html.in

Re: [libvirt] [PATCH 4/7] qemu: Add qemuProcessUpdateLiveGuestCPU

On Wed, Jul 12, 2017 at 15:18:58 +0200, Pavel Hrdina wrote: > On Wed, Jul 12, 2017 at 02:56:50PM +0200, Jiri Denemark wrote: > > Separated from qemuProcessUpdateAndVerifyCPU to handle updating of an > > active guest CPU definition according to live data from QEMU. > > > > Signed-off-by: Jiri

Re: [libvirt] [PATCH 2/7] qemu: Add qemuProcessVerifyCPU

On Wed, Jul 12, 2017 at 15:14:20 +0200, Pavel Hrdina wrote: > On Wed, Jul 12, 2017 at 02:56:48PM +0200, Jiri Denemark wrote: > > Separated from qemuProcessUpdateLiveGuestCPU. The function makes sure > > a guest CPU provides all features required by a domain definition. > > > > Signed-off-by: Jiri

Re: [libvirt] [PATCH] cpu_x86: Properly disable unknown CPU features

On Mon, Jun 19, 2017 at 15:09:04 +0200, Jiri Denemark wrote: > CPU features unknown to a hypervisor will not be present in dataDisabled > even though the feature won't naturally be enabled because it is > unknown. Thus any features we asked for which are not in dataEnabled > should be considered

[libvirt] [PATCH] virpcimock: Fix memory leak in pci_driver_new

@driverpath, allocated by virAsprintfQuiet, was not freed and leaked. Signed-off-by: Zhipeng Lu --- tests/virpcimock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/virpcimock.c b/tests/virpcimock.c index e9408aa..dec9e01 100644 --- a/tests/virpcimock.c +++

Re: [libvirt] [PATCH] qemu: hotplug virtio_scsi over lsilogic when sicsi controller is not present

On Wed, Jul 12, 2017 at 23:13:58 -0400, Liang Yan wrote: > > > On 7/12/17 2:49 AM, Peter Krempa wrote: > > On Tue, Jul 11, 2017 at 21:33:49 -0600, Liang Yan wrote: > >> It may be better to check virtio-scsi controller first since it is > >> supported better in qemu level. > > This is not true