Re: [libvirt] [PATCH] hostdev: display leading zeros of USB vendor/product id's in error messages

At 2017-08-03 08:40:48, "John Ferlan" wrote: > > >On 07/28/2017 04:33 AM, Chen Hanxiao wrote: >> From: Chen Hanxiao >> >> Many vendor id's and product id's have leading zeros. >> Show them in error messages. >> >> Signed-off-by: Chen Hanxiao

Re: [libvirt] [PATCH] hyperv: Reduce usage of libxml API functions

2017-07-28 18:19 GMT+02:00 Sri Ramanujam : > Slight refactor of the WMI serialization code to minimize mixing > openwsman and libxml2 APIs. The only usage of libxml2 APIs now is in > creating CDATA blocks, because the openwsman API does not provide that > functionality. > ---

Re: [libvirt] [PATCH] hyperv: Correct number of milliseconds in five minutes

2017-07-28 18:23 GMT+02:00 Sri Ramanujam : > --- > src/hyperv/hyperv_wmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c > index 57125ae..33ad964 100644 > --- a/src/hyperv/hyperv_wmi.c > +++

[libvirt] [RESEND] pci: add support for VMD domains

VMD domains start at 0x1, so expand dev->name to fit at least this many characters. Signed-off-by: Jon Derrick --- src/util/virpci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virpci.c b/src/util/virpci.c index 2c1b758..b3afefe

Re: [libvirt] [PATCH] introduce virConfReadString

On 08/07/2017 05:42 PM, Ján Tomko wrote: > Rewrite virConfReadMem to take a null-terminated string. > All the callers were calling strlen on it anyway. > --- > daemon/libvirtd-config.c | 2 +- > src/libvirt_private.syms | 2 +- > src/libxl/libxl_driver.c | 4 ++-- > src/lxc/lxc_native.c |

Re: [libvirt] [PATCH] conf: check rombar against VIR_DOMAIN_TRISTATE_SWITCH_ABSENT

On 08/07/2017 05:30 PM, Pavel Hrdina wrote: > On Mon, Aug 07, 2017 at 05:06:49PM +0200, Michal Privoznik wrote: >> On 08/07/2017 04:56 PM, Ján Tomko wrote: >>> Make the comparison explicit. >>> --- >>> src/conf/domain_conf.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>>

[libvirt] [PATCH] introduce virConfReadString

Rewrite virConfReadMem to take a null-terminated string. All the callers were calling strlen on it anyway. --- daemon/libvirtd-config.c | 2 +- src/libvirt_private.syms | 2 +- src/libxl/libxl_driver.c | 4 ++-- src/lxc/lxc_native.c | 2 +- src/util/virconf.c | 16

Re: [libvirt] [PATCH] conf: check rombar against VIR_DOMAIN_TRISTATE_SWITCH_ABSENT

On Mon, Aug 07, 2017 at 05:06:49PM +0200, Michal Privoznik wrote: > On 08/07/2017 04:56 PM, Ján Tomko wrote: > > Make the comparison explicit. > > --- > > src/conf/domain_conf.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/src/conf/domain_conf.c

Re: [libvirt] [PATCH] conf: check rombar against VIR_DOMAIN_TRISTATE_SWITCH_ABSENT

On 08/07/2017 04:56 PM, Ján Tomko wrote: > Make the comparison explicit. > --- > src/conf/domain_conf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index 3cdb5e348..b5ce2ecd9 100644 > --- a/src/conf/domain_conf.c

Re: [libvirt] [PATCH] conf: check rombar against VIR_DOMAIN_TRISTATE_SWITCH_ABSENT

On Mon, Aug 07, 2017 at 04:56:07PM +0200, Ján Tomko wrote: > Make the comparison explicit. > --- > src/conf/domain_conf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Pavel Hrdina signature.asc Description: PGP signature -- libvir-list mailing

[libvirt] [PATCH] conf: check rombar against VIR_DOMAIN_TRISTATE_SWITCH_ABSENT

Make the comparison explicit. --- src/conf/domain_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 3cdb5e348..b5ce2ecd9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5359,10 +5359,10 @@

Re: [libvirt] [PATCH 0/3] Properly deal with multiple netdevs per PCI device when converting VF <-> PF

On 08/04/2017 05:36 AM, Laine Stump wrote: > The commit log of Patch 1 explains the majority of the reason for > these patches. In short, they disambiguate the multiple netdevs per > PCI device on the SRIOV PF and VFs of a Mellanox dual port NIC *when > converting from a VF netdev to a PF netdev

[libvirt] [PATCH 1/2] qemu: fix nwfilter deadlock while reverting to snapshot

Signed-off-by: Pavel Hrdina --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index b3f65f440d..0b549f20da 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -15325,7

[libvirt] [PATCH 2/2] qemu: fix nwfilter deadlock in qemuProcessReconnect

The correct lock order is: nwfilter driver lock (not used in this code path) nwfilter update lock virt driver lock (not used in this code path) domain object lock but the current code have this order: domain object lock nwfilter update lock Signed-off-by: Pavel Hrdina

[libvirt] [PATCH 0/2] fix some nwfilter deadlocks

Pavel Hrdina (2): qemu: fix nwfilter deadlock while reverting to snapshot qemu: fix nwfilter deadlock in qemuProcessReconnect src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_process.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) -- 2.13.4 -- libvir-list mailing list

Re: [libvirt] [PATCH] tests: add further XML namespace test

On 08/04/2017 05:52 PM, Daniel P. Berrange wrote: > Validate that we can pass QEMU command line options using a default > namespace, instead of a prefixed namespace > > Signed-off-by: Daniel P. Berrange > --- > .../qemuxml2argvdata/qemuxml2argv-qemu-ns-alt.args | 27

Re: [libvirt] [PATCH v2] docs: make website responsive for mobile devices

On 08/04/2017 05:19 PM, Daniel P. Berrange wrote: > The website does not look good in a mobile device as the text is > far too small and the layout assumes a wide screen. > > Make the style dynamically adapt based on viewport size, so a > mobile device gets a layout more suited to its dimensions,

[libvirt] [PATCH] Update to latest keycodemapdb content

Signed-off-by: Daniel P. Berrange --- src/Makefile.am | 2 +- src/keycodemapdb | 2 +- src/util/virkeycode.c | 5 ++--- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index b8e875482..45b58c0ad 100644 ---

Re: [libvirt] [PATCH] Remove bogus warning about vir$OBJECTGetConnect functions

On 08/04/2017 05:30 PM, Daniel P. Berrange wrote: > The API docs for the various vir$OBJECTGetConnect functions > contain a warning > > WARNING: When writing libvirt bindings in other languages, do > not use this function. Instead, store the connection and > the domain object together. >

[libvirt] [PATCH 2/2] qemuDomainUndefineFlags: unlink nvram file regardless of domain state

https://bugzilla.redhat.com/show_bug.cgi?id=1467245 Currently, there's a bug when undefining a domain with NVRAM store. Basically, the unlink() of the NVRAM store file happens during the undefine procedure iff domain is inactive. So, if domain is running and undefine is called the file is left

[libvirt] [PATCH 1/2] qemuDomainUndefineFlags: Grab QEMU_JOB_MODIFY

This API is definitely modifying state of @vm. Therefore it should grab a job. Signed-off-by: Michal Privoznik --- src/qemu/qemu_driver.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCH 0/2] qemuDomainUndefineFlags: Two fixes

*** BLURB HERE *** Michal Privoznik (2): qemuDomainUndefineFlags: Grab QEMU_JOB_MODIFY qemuDomainUndefineFlags: unlink nvram file regardless of domain state src/qemu/qemu_driver.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) -- 2.13.0 -- libvir-list

Re: [libvirt] [PATCH 5/8] virVMXParseConfig: Don't leak def->videos

On 08/04/2017 04:56 PM, Ján Tomko wrote: > On Fri, Aug 04, 2017 at 04:22:33PM +0200, Michal Privoznik wrote: >> This function calls virDomainDefAddImplicitDevices() which adds >> implicit video device to domain definition. However, later in the >> process the function just ignores this and

Re: [libvirt] [PATCH] docs: Add "PCI topology and hotplug" guidelines

On Tue, 2017-07-25 at 12:42 +0200, Andrea Bolognani wrote: > For all machine types except i440fx, making a guest hotplug > capable requires some sort of planning. Add some information > to help users make educated choices when defining the PCI > topology of guests. > > Signed-off-by: Andrea

Re: [libvirt] [RFC]Add new mdev interface for QoS

On 2017/8/4 5:11, Alex Williamson wrote: > On Thu, 3 Aug 2017 20:26:14 +0800 > "Gao, Ping A" wrote: > >> On 2017/8/3 0:58, Alex Williamson wrote: >>> On Wed, 2 Aug 2017 21:16:28 +0530 >>> Kirti Wankhede wrote: >>> On 8/2/2017 6:29 PM, Gao, Ping