Re: [libvirt] [PATCH] Revert "maint: Update to latest gnulib"

On 08/24/2017 12:20 PM, Erik Skultety wrote: > Revert @f8172388c which broke the build on Centos 6, because of old > autoconf (< 2.63b) not properly quoting arguments for shell. > --- > So, the last working commit is cbc700208, but I didn't want to revert to that > one directly, since I'd like to

Re: [libvirt] [PATCH v2] virt-host-validate: Fix warning for IOMMU detection on PPC

On 08/24/2017 02:52 AM, Nitesh Konkar wrote: > Hello John, > > In case of PPC, IOMMU in the host kernel either has it or not compiled in. > The /sys/kernel/iommu_groups check is good enough to verify if it was > compiled with the kernel or not. > > If not, then we can have a ppc specific

Re: [libvirt] New QEMU daemon for persistent reservations

On 22/08/2017 18:27, Paolo Bonzini wrote: > Hi all, > > I am adding a new daemon to QEMU, that QEMU can connect to in order to > issue persistent reservation commands. > > The daemon can only issue the commands on file descriptor that QEMU > already has. In addition normal users shouldn't have

[libvirt] [PATCH 2/2] storage: Use virStorageBackendRefreshVolTargetUpdate after wipeVol

https://bugzilla.redhat.com/show_bug.cgi?id=1437797 Rather than using refreshVol which essentially only updates the allocation, capacity, and permissions for the volume, but not the format which does get updated in a pool refresh - let's use the same helper that pool refresh uses in order to

[libvirt] [PATCH 1/2] storage: Introduce virStorageBackendRefreshVolTargetUpdate

Create a separate function to handle the volume target update via probe processing. Signed-off-by: John Ferlan --- src/storage/storage_util.c | 82 ++ src/storage/storage_util.h | 3 ++ 2 files changed, 57 insertions(+), 28

[libvirt] [PATCH 0/2] Alter refresh algorithm for volWipe

Alter wipeVol to do same refresh operation as pool refresh would do. John Ferlan (2): storage: Introduce virStorageBackendRefreshVolTargetUpdate storage: Use virStorageBackendRefreshVolTargetUpdate after wipeVol src/storage/storage_driver.c | 7 ++-- src/storage/storage_util.c | 82

[libvirt] [PATCH] maint: correct quoting for gl_WARN_ADD

3 out of 4 uses of gl_WARN_ADD() were incorrectly adding "" around the argument, which in turn resulted in the argument being used unquoted (configure had gl_positive=""-fstack-protector-all"", rather than the intended gl_positive="-fstack-protector-all"). Signed-off-by: Eric Blake

Re: [libvirt] [PATCH] Revert "maint: Update to latest gnulib"

[adding gnulib] On 08/24/2017 12:20 PM, Erik Skultety wrote: > Revert @f8172388c which broke the build on Centos 6, because of old > autoconf (< 2.63b) not properly quoting arguments for shell. > --- > So, the last working commit is cbc700208, but I didn't want to revert to that > one directly,

[libvirt] [PATCH] Revert "maint: Update to latest gnulib"

Revert @f8172388c which broke the build on Centos 6, because of old autoconf (< 2.63b) not properly quoting arguments for shell. --- So, the last working commit is cbc700208, but I didn't want to revert to that one directly, since I'd like to poke gnulib about the issue first and find a proper

Re: [libvirt] [PATCH] libxl: Avoid a variable named 'stat'

> On Aug 24, 2017, at 3:24 PM, Andrea Bolognani wrote: > > On Thu, 2017-08-24 at 12:34 +0100, George Dunlap wrote: >> @@ -5401,12 +5401,12 @@ libxlDomainBlockStatsVBD(virDomainObjPtr vm, >> # define LIBXL_SET_VBDSTAT(FIELD, VAR, MUL) \ >> if ((virAsprintf(,

Re: [libvirt] [PATCH] qemu: Report error on failure to set isolation group

On Thu, Aug 24, 2017 at 05:12:05PM +0200, Andrea Bolognani wrote: > This is more user-friendly because the error will be > displayed directly instead of being buried in the log. > > Signed-off-by: Andrea Bolognani > --- > src/qemu/qemu_domain_address.c | 17

[libvirt] [PATCH 3/3] conf: don't close the source element inside different function

While formatting disk or chardev element they both uses virDomainDiskSourceDefFormatSeclabel() function which also closes the source element. This is not extendable. Use the new virXMLFormatElement() to properly format the source element with possible child elements. As a side effect it fixes a

[libvirt] [PATCH 1/3] util: introduce virBufferSetChildIndent macro

Signed-off-by: Pavel Hrdina --- src/conf/capabilities.c | 3 +-- src/conf/cpu_conf.c | 3 +-- src/conf/domain_conf.c | 26 +++--- src/util/virbuffer.h| 9 + 4 files changed, 22 insertions(+), 19 deletions(-) diff --git

[libvirt] [PATCH 2/3] util: introduce virXMLFormatElement helper

This helper allows you to better structurize the code if some element may or may not contains attributes and/or child elements. Signed-off-by: Pavel Hrdina --- src/libvirt_private.syms | 1 + src/util/virxml.c| 47 +++

[libvirt] [PATCH 0/3] chardev and disk source format cleanup

Pavel Hrdina (3): util: introduce virBufferSetChildIndent macro util: introduce virXMLFormatElement helper conf: don't close the source element inside different function src/conf/capabilities.c| 3 +- src/conf/cpu_conf.c| 3 +-

[libvirt] [PATCH] qemu: Prevent isolation group-related guest disappearance

We can't retrieve the isolation group of a device that's not present in the system. However, it's very common for VFs to be created late in the boot, so they might not be present yet when libvirtd starts, which would cause the guests using them to disappear. If a PCI address has already been set

[libvirt] [PATCH] qemu: Report error on failure to set isolation group

This is more user-friendly because the error will be displayed directly instead of being buried in the log. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_domain_address.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git

Re: [libvirt] Question about "f16c", "rdrand" and "vme" in cpu_map.xml

On Thu, Aug 24, 2017 at 16:29:37 +0800, Jay Zhou wrote: > Hi all, > > "f16c", "rdrand" and "vme" are all standard features, the IvyBridge CPU model > has these three features in the file of src/cpu/cpu_map.xml, but the higher > model of Haswell-noTSX, Haswell, Broadwell-noTSX and Broadwell do

[libvirt] Question about "f16c", "rdrand" and "vme" in cpu_map.xml

Hi all, "f16c", "rdrand" and "vme" are all standard features, the IvyBridge CPU model has these three features in the file of src/cpu/cpu_map.xml, but the higher model of Haswell-noTSX, Haswell, Broadwell-noTSX and Broadwell do not, which makes it incompatible. BTW, I noticed that "f16c",

Re: [libvirt] [PATCH] libxl: Avoid a variable named 'stat'

On Thu, 2017-08-24 at 12:34 +0100, George Dunlap wrote: > @@ -5401,12 +5401,12 @@ libxlDomainBlockStatsVBD(virDomainObjPtr vm, > # define LIBXL_SET_VBDSTAT(FIELD, VAR, MUL) \ > if ((virAsprintf(, "%s/"FIELD, path) < 0) || \ > (virFileReadAll(name, 256, ) < 0) || \ > -

[libvirt] [PATCH v2 11/12] storage: Use virStoragePoolObj{Get|Incr}Decr}Asyncjobs

Use the new accessor APIs for storage_driver. Signed-off-by: John Ferlan --- src/storage/storage_driver.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index

[libvirt] [PATCH v2 05/12] storage: Introduce APIs to search/scan storage pool volumes list

Introduce virStoragePoolObjForEachVolume to scan each volume calling the passed callback function until all volumes have been processed in the storage pool volume list, unless the callback function returns an error. Introduce virStoragePoolObjSearchVolume to search each volume calling the passed

[libvirt] [PATCH v2 06/12] storage: Use virStoragePoolObj{Get|Set}ConfigFile

Use the new accessor APIs for storage_driver and test_driver. Signed-off-by: John Ferlan --- src/storage/storage_backend_scsi.c | 4 +++- src/storage/storage_driver.c | 14 +++--- src/test/test_driver.c | 20 3 files changed,

[libvirt] [PATCH v2 09/12] storage: Use virStoragePoolObj{Is|Set}Autostart

Use the new accessor APIs for storage_driver and test_driver. Signed-off-by: John Ferlan --- src/storage/storage_driver.c | 20 +--- src/test/test_driver.c | 4 ++-- 2 files changed, 11 insertions(+), 13 deletions(-) diff --git

[libvirt] [PATCH v2 08/12] storage: Use virStoragePoolObj{Is|Set}Active

Use the new accessor APIs for storage_driver, test_driver, and gluster backend. Signed-off-by: John Ferlan --- src/storage/storage_backend_gluster.c | 2 +- src/storage/storage_driver.c | 16 src/test/test_driver.c| 10 +- 3

[libvirt] [PATCH v2 01/12] storage: Create accessor API's for virStoragePoolObj

In preparation for making a private object, create accessor API's for consumer storage functions to use: virStoragePoolObjGetDef virStoragePoolObjSetDef virStoragePoolObjGetNewDef virStoragePoolObjDefUseNewDef virStoragePoolObjGetConfigFile virStoragePoolObjSetConfigFile

[libvirt] [PATCH v2 04/12] storage: Introduce storage volume add, delete, count APIs

Create/use virStoragePoolObjAddVol in order to add volumes onto list. Create/use virStoragePoolObjRemoveVol in order to remove volumes from list. Create/use virStoragePoolObjGetVolumesCount to get count of volumes on list. For the storage driver, the logic alters when the volumes.obj list grows

[libvirt] [PATCH v2 10/12] storage: Internally represent @autostart to bool

Since it's been used that way anyway, let's just convert it to a bool and only make the external representation be an int. Signed-off-by: John Ferlan --- src/conf/virstorageobj.c | 4 ++-- src/conf/virstorageobj.h | 4 ++-- src/storage/storage_driver.c | 2 +-

[libvirt] [PATCH v2 12/12] storage: Use virStoragePoolObjDefUseNewDef

Use the new accessor API for storage_driver. Signed-off-by: John Ferlan --- src/storage/storage_driver.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 83d9ce3..90d4bf3 100644 ---

[libvirt] [PATCH v2 07/12] storage: Use virStoragePoolObjGetAutostartLink

Use the new accessor API for storage_driver. Signed-off-by: John Ferlan --- src/storage/storage_driver.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index

[libvirt] [PATCH v2 00/12] Continue altering storage pool for privatization

Consider this round 1 of 2 The next series will be 18 patches, but the majority of those deal with change every {pool|obj}->def->X to use the accessor virStoragePoolObjGetDef. v1: https://www.redhat.com/archives/libvir-list/2017-May/msg00218.html Probably not even worth looking at the v1,

[libvirt] [PATCH v2 02/12] storage: Introduce virStoragePoolObjNew

Create/use a helper to perform object allocation. Adjust storagevolxml2argvtest.c in order to use the allocator and setting of the obj->def. Signed-off-by: John Ferlan --- src/conf/virstorageobj.c | 31 +-- src/conf/virstorageobj.h |

[libvirt] [PATCH v2 03/12] storage: Fill in storage pool @active properly

It's a bool not an int, so use true/false and not 1/0 Signed-off-by: John Ferlan --- src/conf/virstorageobj.c | 4 ++-- src/test/test_driver.c | 8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c

[libvirt] [PATCH] libxl: Avoid a variable named 'stat'

Using a variable named 'stat' clashes with the system function 'stat()' causing compiler warnings on some platforms: libxl/libxl_driver.c: In function 'libxlDomainBlockStatsVBD': libxl/libxl_driver.c:5387: error: declaration of 'stat' shadows a global declaration [-Wshadow]

Re: [libvirt] libvirt 3.5.0 locks

Another lock with libvirt 3.5.0 root@cn12:~# gdb -batch -p $(pgrep libvirtd) -ex 't a a bt' warning: Unable to find libthread_db matching inferior's thread library, thread debugging will not be available. 0x7f95b5d4bd3d in internal_fallocate (fd=-1177453080, offset=4294967295, len=121) at

[libvirt] [PATCH v3 2/6] udev: Split udevEventHandleCallback in two functions

This patch splits udevEventHandleCallback in two (introduces udevEventHandleThread) in order to be later able to refactor the latter to actually become a detached thread which will wait some time for the kernel to create the whole sysfs tree for a device as we cannot do that in the event loop

[libvirt] [PATCH v3 1/6] nodedev: Introduce udevCheckMonitorFD helper function

We need to perform some sanity checks on the udev monitor before every use so that we know nothing changed in the meantime. The reason for moving the code to a separate function is to be able to perform the same check from a worker thread that will replace the udevEventHandleCallback in terms of

[libvirt] [PATCH v3 4/6] nodedev: Disable/re-enable polling on the udev fd

The event loop may get scheduled earlier than the udev event handler thread which means that it would keep invoking the handler callback with "new" events, while in fact it's most likely still the same event which the handler thread hasn't managed to remove from the socket queue yet. This is due

[libvirt] [PATCH v3 0/6] Work around the kernel mdev uevent race in nodedev

v2 here: https://www.redhat.com/archives/libvir-list/2017-July/msg01268.html Since v2: - added patch 4/6 that fixes the issue with the handler thread spamming logs with "udev_monitor_receive_device returned NULL" -> the event loop callback now disables polling on the udev monitor's fd

[libvirt] [PATCH v3 6/6] nodedev: Work around the uevent race by hooking up virFileWaitForAccess

If we find ourselves in the situation that the 'add' uevent has been fired earlier than the sysfs tree for a device was created, we should use the best-effort approach and give kernel some predetermined amount of time, thus waiting for the attributes to be ready rather than discarding the device

[libvirt] [PATCH v3 3/6] udev: Convert udevEventHandleThread to an actual thread routine

Adjust udevEventHandleThread to be a proper thread routine running in an infinite loop handling devices. Also introduce udevEventThreadData private structure. Every time there's and incoming event from udev, udevEventHandleCallback only increments the number of events queuing on the monitor and

[libvirt] [PATCH v3 5/6] util: Introduce virFileWaitForAccess

Since we have a number of places where we workaround timing issues with devices, attributes (files in general) not being available at the time of processing them by calling usleep in a loop for a fixed number of tries, we could as well have a utility function that would do that. Therefore we won't

Re: [libvirt] [PATCH] maint: Update to latest gnulib

On Thu, Aug 24, 2017 at 11:14:57AM +0200, Peter Krempa wrote: > On Thu, Aug 24, 2017 at 10:50:29 +0200, Erik Skultety wrote: > > This pulls in, among other new things, vc-list-files fix to make > > syntax-check work with git worktrees. > > > > Signed-off-by: Erik Skultety > >

Re: [libvirt] [PATCH] maint: Update to latest gnulib

On Thu, Aug 24, 2017 at 10:50:29 +0200, Erik Skultety wrote: > This pulls in, among other new things, vc-list-files fix to make > syntax-check work with git worktrees. > > Signed-off-by: Erik Skultety > --- > .gnulib | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

[libvirt] [PATCH] maint: Update to latest gnulib

This pulls in, among other new things, vc-list-files fix to make syntax-check work with git worktrees. Signed-off-by: Erik Skultety --- .gnulib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gnulib b/.gnulib index ce4ee4cbb..47c634c05 16 ---

Re: [libvirt] [PATCH v5 14/15] network: Fix virNetworkObjBridgeInUse return type

On Wed, Aug 23, 2017 at 05:22:10PM -0400, John Ferlan wrote: > Rather than an int, it returns a bool - so let's define it that way > > Signed-off-by: John Ferlan > --- > src/conf/virnetworkobj.c | 2 +- > src/conf/virnetworkobj.h | 2 +- > 2 files changed, 2 insertions(+), 2

Re: [libvirt] [PATCH v5 10/15] Revert "interface: Consume @def in virInterfaceObjNew"

On Wed, Aug 23, 2017 at 05:22:06PM -0400, John Ferlan wrote: > This reverts commit 92840eb3a7e47cdf761e52afccc41d2a35327fbd. > > More recent reviews/changes don't have the vir*ObjNew APIs > consuming the @def, so remove from Interface as well. Changes > needed to also deal with conflicts from

Re: [libvirt] [PATCH] vz: build fix

On Thu, Aug 24, 2017 at 10:08:35AM +0300, Nikolay Shirokovskiy wrote: > 6e6faf6d changed vzDomObjAlloc signature in source but not in header file. > --- > src/vz/vz_utils.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/vz/vz_utils.h b/src/vz/vz_utils.h > index

[libvirt] [PATCH v3 REBASE 02/16] qemu: introduce qemu domain job status

This patch simply switches code from using VIR_DOMAIN_JOB_* to introduced QEMU_DOMAIN_JOB_STATUS_*. Later this gives us freedom to introduce states for postcopy and mirroring phases. --- src/qemu/qemu_domain.c | 27 -- src/qemu/qemu_domain.h | 10 +++-

[libvirt] [PATCH v3 REBASE 12/16] qemu: migrate: show disks stats on job info requests

This patch shows incorrect info when client request comes when migration routine is stopping mirror jobs or mirror jobs already stopped. This issue will be addressed in next patch. --- src/qemu/qemu_driver.c| 4 src/qemu/qemu_migration.c | 49

[libvirt] [PATCH v3 REBASE 01/16] qemu: drop code for VIR_DOMAIN_JOB_BOUNDED and timeRemaining

qemu driver does not have VIR_DOMAIN_JOB_BOUNDED jobs and timeRemaining is always 0. --- src/qemu/qemu_domain.c | 7 --- src/qemu/qemu_domain.h | 1 - src/qemu/qemu_migration_cookie.c | 5 - 3 files changed, 13 deletions(-) diff --git a/src/qemu/qemu_domain.c

[libvirt] [PATCH v3 REBASE 16/16] qemu: migration: don't expose incomplete job as complete

In case of real migration (not migrating to file on save, dump etc) migration info is not complete at time qemu finishes migration in normal (non postcopy) mode. We need to update disks stats, downtime info etc. Thus let's not expose this job status as completed. To archive this let's set status

[libvirt] [PATCH v3 REBASE 06/16] qemu: refactor fetching migration stats

qemuMigrationFetchJobStatus is rather inconvinient. Some of its callers don't need status to be updated, some don't need to update elapsed time right away. So let's update status or elapsed time in callers instead. In qemuMigrationConfirmPhase we should fetch stats with copy flag set as stats

[libvirt] [PATCH v3 REBASE 13/16] qemu: support getting disks stats during stopping block jobs

Let's store disks stats for completed mirror jobs in current job info. So on getting migration job stats thru API we take records for completed jobs from current job info and records for still active jobs by querying qemu process. As we need to keep disks stats for completed mirror jobs in

[libvirt] [PATCH v3 REBASE 14/16] qemu: migation: resolve race on getting job info and stopping block jobs

During stopping mirror block jobs vm lock is droped on awating block job events, thus next scenario is possible: 1. stop mirror block job is sent 2. migration routine awaits for block job event 3. mirror job stopped and event send 4. getting migration job info routine asks for block job info and

[libvirt] [PATCH v3 REBASE 03/16] qemu: introduce QEMU_DOMAIN_JOB_STATUS_POSTCOPY

Current code consults job.current->stats.status to check for postcopy state. First it is more correct to check for both job.current->status and job.current->stats.status.code because on some paths on failures we change only the former. Second if qemu supports migration events then stats can change

[libvirt] [PATCH v3 REBASE 11/16] qemu: always get job condition on getting job stats

Looks like it is more simple to drop this optimization as we are going to add getting disks stats during migration via quering qemu process and checking if we have to acquire job condition becomes more complicate. --- src/qemu/qemu_driver.c | 15 +-- 1 file changed, 5 insertions(+),

[libvirt] [PATCH v3 REBASE 10/16] qemu: introduce migrating job status

Instead of checking stat.status let's set status to migrating as soon as migrate command is send (waiting for completion is a good place too). --- src/qemu/qemu_domain.c| 1 + src/qemu/qemu_domain.h| 1 + src/qemu/qemu_driver.c| 4 +++- src/qemu/qemu_migration.c | 9 +++-- 4 files

[libvirt] [PATCH v3 REBASE 15/16] qemu: migrate: copy disks stats to completed job

--- src/qemu/qemu_migration.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 906f8fe..54cfdd0 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -3867,6 +3867,13 @@ qemuMigrationRun(virQEMUDriverPtr

[libvirt] [PATCH v3 REBASE 04/16] qemu: drop QEMU_MIGRATION_COMPLETED_UPDATE_STATS

This way we get stats only in one place. The former code waits for complete/postcopy status basically and don't need to mess with stats. The patch drops raising an error on stats updates failure. This does not make much sense anyway. --- src/qemu/qemu_migration.c | 24 +++- 1

[libvirt] [PATCH v3 REBASE 09/16] qemu: start all async job with job status active

Setting status to none has little value - getting job status will not return even elapsed time. After this patch getting job stats stays correct in a sence it will not fetch migration stats because it consults stats.status before doing the fetch. --- src/qemu/qemu_domain.c| 1 +

[libvirt] [PATCH v3 REBASE 07/16] qemu: simplify getting completed job stats

--- src/qemu/qemu_driver.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index c62d416..b8a4df7 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -12905,12 +12905,18 @@

[libvirt] [PATCH v3 REBASE 00/16] qemu: migration: show disks stats for nbd migration

diff from v2: 1. Fix style issues. 2. Rework patch for fetching job info (save logic to use temporary variable when drop vm lock) 3. Update disk stats when block jobs are canceled. 4. Adress a few more corner cases. This patch series add disks stats to domain job info(stats) as

[libvirt] [PATCH v3 REBASE 05/16] qemu: drop excessive zero-out in qemuMigrationFetchJobStatus

qemuMonitorGetMigrationStats will do it for us anyway. --- src/qemu/qemu_migration.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index b7ad65d..cc42f7a 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1387,7

[libvirt] [PATCH v3 REBASE 08/16] qemu: fail querying destination migration statistics always

Querying destination migration statistics may result in getting a failure or getting a elapsed time value depending on stats.status value which is odd. Instead let's always fail. Clients should be ready to handle this as currently getting failure period can be considerable. ---

Re: [libvirt] [PATCHv2] nodedev: add switchdev to NIC capabilities

Hi John, For some reason I don't see these errors in my environment, I would appreciate it if you could fix them before merging. Thank you!! -Original Message- From: John Ferlan [mailto:jfer...@redhat.com] Sent: Wednesday, August 23, 2017 8:44 PM To: Edan David ;

[libvirt] [PATCH] vz: build fix

6e6faf6d changed vzDomObjAlloc signature in source but not in header file. --- src/vz/vz_utils.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vz/vz_utils.h b/src/vz/vz_utils.h index ea2e2da..d213183 100644 --- a/src/vz/vz_utils.h +++ b/src/vz/vz_utils.h @@ -116,7 +116,7

Re: [libvirt] [PATCH v2] virt-host-validate: Fix warning for IOMMU detection on PPC

Hello John, In case of PPC, IOMMU in the host kernel either has it or not compiled in. The /sys/kernel/iommu_groups check is good enough to verify if it was compiled with the kernel or not. If not, then we can have a ppc specific message there: virHostMsgCheck(hvname, "%s", _("if IOMMU is