Re: [libvirt] [PATCH 3/3] doc: Document managedsave-dumpxml support

On 08/30/2017 04:12 PM, Peter Krempa wrote: On Wed, Aug 30, 2017 at 15:44:37 +0530, Kothapally Madhu Pavan wrote: Signed-off-by: Kothapally Madhu Pavan --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml

[libvirt] [PATCH v6 10/13] qemu: Introduce qemuDomainPrepareDiskSource

Introduce a function to setup any TLS needs for a disk source. If there's a configuration or other error setting up the disk source for TLS, then cause the domain startup to fail. For VxHS, if cfg->haveTLS is set, then TLS creds will be added automatically to every VxHS disk that didn't specify

[libvirt] [PATCH v6 13/13] tests: Add a test case for multiple VxHS disk configuration

From: Ashish Mittal This test verifies that multiple VxHS disks can be configured to multiple VxHS servers including being able disable TLS to one of those servers by specifying "tls='no'". Each VxHS disk will generate a unique alias as well. Signed-off-by: Ashish

Re: [libvirt] [PATCH v5 0/9] Add support for Veritas HyperScale (VxHS) block device protocol

On 08/29/2017 02:39 AM, Ashish Mittal wrote: > QEMU changes for VxHS (including TLS support) are already upstream. > This series of patches adds support for VxHS block devices in libvirt. > > Patch 1 adds the base functionality for supporting VxHS protocol. > Patches 2 and 3 add test cases for

[libvirt] [PATCH v6 12/13] tests: Add test for failure when vxhs_tls=0

From: Ashish Mittal Add a test case to verify setting vxhs_tls=0 in qemu.conf disables TLS for VxHS disks followed by running the same test after enabling for the success case. Signed-off-by: Ashish Mittal Signed-off-by: John Ferlan

[libvirt] [PATCH v6 11/13] qemu: Add TLS support for Veritas HyperScale (VxHS)

From: Ashish Mittal Alter qemu command line generation in order to possibly add TLS for a suitably configured domain. Sample TLS args generated by libvirt - -object tls-creds-x509,id=objvirtio-disk0_tls0,dir=/etc/pki/qemu,\ endpoint=client,verify-peer=yes \

[libvirt] [PATCH v6 09/13] util: Add virstoragetest to parse/format a tls='yes'

From: Ashish Mittal Add a test case to verify TLS arguments are parsed correctly for a VxHS disk Test case verifies that XML is generated correctly for a VxHS disk having TLS enabled. Signed-off-by: Ashish Mittal Signed-off-by: John Ferlan

[libvirt] [PATCH v6 08/13] util: Add haveTLS to virStorageSource

From: Ashish Mittal Add an optional virTristateBool haveTLS to virStorageSource to manage whether a storage source will be using TLS. Sample XML for a VxHS disk: Update the qemuxml2xmltest in order to add a test to show the proper parsing. Also

[libvirt] [PATCH v6 05/13] util: storage: Add JSON backing volume parse for VxHS

From: Ashish Mittal Add the backing parse and a test case to verify parsing of VxHS backing storage. Signed-off-by: Ashish Mittal Signed-off-by: John Ferlan --- This combines v5 patch3 and src/util/virstoragefile.c

[libvirt] [PATCH v6 00/13] Add support for Veritas HyperScale (VxHS) block device protocol

Here's the reworked v5 series I promised: https://www.redhat.com/archives/libvir-list/2017-August/thread.html Each of the patches lists changes that I recall making in the area. I may have missed a few... and I may have missed something from my own review - so hopefully Ashish you can keep me

[libvirt] [PATCH v6 04/13] docs: Add schema and docs for Veritas HyperScale (VxHS)

From: Ashish Mittal Alter the schema to allow a VxHS block device. Sample XML is: eb90327c-8302-4725-9e1b-4e85ed4dc251 Update the html docs to describe the capability for VxHS. Alter the qemuxml2xmltest to validate the

[libvirt] [PATCH v6 06/13] qemu: Add qemu command line generation for a VxHS block device

From: Ashish Mittal The VxHS block device will only use the newer formatting options and avoid the legacy URI syntax. An excerpt for a sample QEMU command line is: -drive file.driver=vxhs,file.vdisk-id=eb90327c-8302-4725-9e1b-4e85ed4dc251,\

[libvirt] [PATCH v6 03/13] storage: Introduce VIR_STORAGE_NET_PROTOCOL_VXHS

From: Ashish Mittal Add a new virStorageNetProtocol for Veritas HyperScale (VxHS) disks Signed-off-by: Ashish Mittal Signed-off-by: John Ferlan --- This was part of the former v5 patch 1 that I split in order to make

[libvirt] [PATCH v6 07/13] conf: Introduce TLS options for VxHS block device clients

From: Ashish Mittal Add a new TLS X.509 certificate type - "vxhs". This will handle the creation of a TLS certificate capability for properly configured VxHS network block device clients. The following describes the behavior of TLS for VxHS block device: (1) Two

[libvirt] [PATCH v6 02/13] qemu: Detect support for vxhs

Using the query-qmp-schema introspection - look for the 'vxhs' blockdevOptions type Signed-off-by: John Ferlan --- This is new from v5, this is the way I figured out in order to use the query-qmp-schema in order to determine if 'vxhs' was possible. It sets the libvirt

Re: [libvirt] [RFC v2] [OVS/NOVA] Vhost-user backends cross-version migration support

On Wed, Aug 30, 2017 at 11:19:08PM +0300, Michael S. Tsirkin wrote: > On Wed, Aug 30, 2017 at 04:25:10PM -0300, Eduardo Habkost wrote: > > On Wed, Aug 30, 2017 at 05:23:39PM +0300, Michael S. Tsirkin wrote: > > > On Wed, Aug 30, 2017 at 10:17:27AM -0300, Eduardo Habkost wrote: > > > > I'm CCing

Re: [libvirt] [RFC v2] [OVS/NOVA] Vhost-user backends cross-version migration support

On Wed, Aug 30, 2017 at 04:25:10PM -0300, Eduardo Habkost wrote: > On Wed, Aug 30, 2017 at 05:23:39PM +0300, Michael S. Tsirkin wrote: > > On Wed, Aug 30, 2017 at 10:17:27AM -0300, Eduardo Habkost wrote: > > > I'm CCing libvir-list and qemu-devel because I would like to get > > > feedback from

[libvirt] [PATCH] Implement LVM volume resize via lvresize

From: Alexander Polyakov Signed-off-by: Alexander Polyakov --- m4/virt-storage-lvm.m4| 4 src/storage/storage_backend_logical.c | 22 ++ 2 files changed, 26 insertions(+) diff --git a/m4/virt-storage-lvm.m4

[libvirt] [PATCH] qemu: Clean up qemuDomainSecretPrepare

No need to pass a @driver parameter since all that's done is deref the @cfg especially since the only caller can just pass an already referenced @cfg. Also, looks like commit id '0298531b' at one time had a different name for the API, so I took the liberty of fixing the comments too since I would

Re: [libvirt] [PATCH v2 1/5] qemu: whitelist valid video types

On Wed, Aug 30, 2017 at 03:14:40PM -0400, Cole Robinson wrote: > On 08/28/2017 03:56 AM, Pavel Hrdina wrote: > > On Sun, Aug 27, 2017 at 11:04:38AM -0400, Cole Robinson wrote: > >> Rather than require an explicit blacklist that needs to be extended > >> for every new VIDEO_TYPE > >> > >>

Re: [libvirt] [PATCH v2 1/5] qemu: whitelist valid video types

On Mon, Aug 28, 2017 at 10:44:43AM -0400, Cole Robinson wrote: > On 08/28/2017 03:56 AM, Pavel Hrdina wrote: > > On Sun, Aug 27, 2017 at 11:04:38AM -0400, Cole Robinson wrote: > >> Rather than require an explicit blacklist that needs to be extended > >> for every new VIDEO_TYPE > >> > >>

Re: [libvirt] [RFC v2] [OVS/NOVA] Vhost-user backends cross-version migration support

On Wed, Aug 30, 2017 at 05:23:39PM +0300, Michael S. Tsirkin wrote: > On Wed, Aug 30, 2017 at 10:17:27AM -0300, Eduardo Habkost wrote: > > I'm CCing libvir-list and qemu-devel because I would like to get > > feedback from libvirt and QEMU developers too. > > > > On Tue, Aug 08, 2017 at 10:49:21PM

Re: [libvirt] [PATCH v2 1/5] qemu: whitelist valid video types

On 08/28/2017 03:56 AM, Pavel Hrdina wrote: > On Sun, Aug 27, 2017 at 11:04:38AM -0400, Cole Robinson wrote: >> Rather than require an explicit blacklist that needs to be extended >> for every new VIDEO_TYPE >> >> Signed-off-by: Cole Robinson >> --- >> src/qemu/qemu_domain.c

Re: [libvirt] [PATCH v5 9/9] Add a test case to verify different TLS combinations for a VxHS disk

On Wed, Aug 30, 2017 at 8:22 AM, John Ferlan wrote: > > > On 08/29/2017 02:39 AM, Ashish Mittal wrote: >> Verifies TLS args are auto generated if enabled in qemu.conf >> Verifies TLS args are not generated if XML specifies tls='no' >> >> Signed-off-by: Ashish Mittal

Re: [libvirt] [PATCH v2] qemu: set bind mode for chardev while parsing XML

On 08/30/2017 05:53 PM, Pavel Hrdina wrote: > Currently while parsing domain XML we clear the UNIX path if it matches > one of the auto-generated paths by libvirt. After that when the guest > is started new path is generated but the mode is also changed to "bind". > > In the real-world use-case

[libvirt] [PATCH v2] qemu: set bind mode for chardev while parsing XML

Currently while parsing domain XML we clear the UNIX path if it matches one of the auto-generated paths by libvirt. After that when the guest is started new path is generated but the mode is also changed to "bind". In the real-world use-case the mode should not change, it only happens if a user

Re: [libvirt] [PATCH] qemu: set bind mode for chardev while parsing XML

On 08/30/2017 04:49 PM, Pavel Hrdina wrote: > Currently while parsing domain XML we clear the UNIX path if it matches > one of the auto-generated paths by libvirt. After that when the guest > is started new path is generated but the mode is also changed to "bind". > > In the real-world use-case

Re: [libvirt] [PATCH v5 9/9] Add a test case to verify different TLS combinations for a VxHS disk

On 08/29/2017 02:39 AM, Ashish Mittal wrote: > Verifies TLS args are auto generated if enabled in qemu.conf > Verifies TLS args are not generated if XML specifies tls='no' > > Signed-off-by: Ashish Mittal > --- > ...-disk-drive-network-tlsx509-multidisk-vxhs.args |

Re: [libvirt] [PATCH v5 8/9] Add a test case to verify setting vxhs_tls=0 disables TLS for VxHS disks

On 08/29/2017 02:39 AM, Ashish Mittal wrote: > Add a test case to verify that if vxhs_tls is disabled in qemu.conf > then adding "tls=yes" in the domain XML generates an error. > > Signed-off-by: Ashish Mittal > --- >

Re: [libvirt] [PATCH v5 7/9] Add a test case to verify TLS arguments are parsed correctly for a VxHS disk

On 08/29/2017 02:39 AM, Ashish Mittal wrote: > Test case verifies that XML is generated correctly for a VxHS disk > having TLS enabled. > > Signed-off-by: Ashish Mittal > --- > tests/virstoragetest.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff

Re: [libvirt] [PATCH v5 6/9] Add a test case to verify TLS arguments are added for VxHS disk

On 08/29/2017 02:39 AM, Ashish Mittal wrote: > Enable TLS for VxHS disks in qemu.conf and ensure that TLS > arguments are added automatically on the qemu command line. > > Signed-off-by: Ashish Mittal > --- > ...muxml2argv-disk-drive-network-tlsx509-vxhs.args | 30

[libvirt] [PATCH] qemu: set bind mode for chardev while parsing XML

Currently while parsing domain XML we clear the UNIX path if it matches one of the auto-generated paths by libvirt. After that when the guest is started new path is generated but the mode is also changed to "bind". In the real-world use-case the mode should not change, it only happens if a user

Re: [libvirt] [RFC v2] [OVS/NOVA] Vhost-user backends cross-version migration support

On Wed, Aug 30, 2017 at 10:17:27AM -0300, Eduardo Habkost wrote: > I'm CCing libvir-list and qemu-devel because I would like to get > feedback from libvirt and QEMU developers too. > > On Tue, Aug 08, 2017 at 10:49:21PM +0300, Michael S. Tsirkin wrote: > > On Tue, Jul 18, 2017 at 03:42:08PM

Re: [libvirt] [PATCH 3/5] tests: don't use unix socket path that matches auto-generated path

On Wed, Aug 30, 2017 at 03:38:12PM +0200, Michal Privoznik wrote: > On 08/30/2017 02:45 PM, Pavel Hrdina wrote: > > On Wed, Aug 30, 2017 at 02:33:00PM +0200, Michal Privoznik wrote: > >> On 08/30/2017 01:40 PM, Pavel Hrdina wrote: > >>> The test was introduced by 60135b22db6d. > >>> > >>> The

Re: [libvirt] [PATCH 4/5] conf: make sure that chardev reconnect is formatted only for connect mode

On Wed, Aug 30, 2017 at 03:38:13PM +0200, Michal Privoznik wrote: > On 08/30/2017 02:54 PM, Pavel Hrdina wrote: > > On Wed, Aug 30, 2017 at 02:32:50PM +0200, Michal Privoznik wrote: > >> On 08/30/2017 01:40 PM, Pavel Hrdina wrote: > >>> Signed-off-by: Pavel Hrdina > >>> --- >

Re: [libvirt] [PATCH 4/5] conf: make sure that chardev reconnect is formatted only for connect mode

On 08/30/2017 02:54 PM, Pavel Hrdina wrote: > On Wed, Aug 30, 2017 at 02:32:50PM +0200, Michal Privoznik wrote: >> On 08/30/2017 01:40 PM, Pavel Hrdina wrote: >>> Signed-off-by: Pavel Hrdina >>> --- >>> src/conf/domain_conf.c | 10 ++ >>> 1 file changed, 6

Re: [libvirt] [PATCH 3/5] tests: don't use unix socket path that matches auto-generated path

On 08/30/2017 02:45 PM, Pavel Hrdina wrote: > On Wed, Aug 30, 2017 at 02:33:00PM +0200, Michal Privoznik wrote: >> On 08/30/2017 01:40 PM, Pavel Hrdina wrote: >>> The test was introduced by 60135b22db6d. >>> >>> The auto-generated path is removed by post-parse callback which >>> also changes the

Re: [libvirt] [PATCH v3 REBASE 03/16] qemu: introduce QEMU_DOMAIN_JOB_STATUS_POSTCOPY

On 28.08.2017 17:55, Jiri Denemark wrote: > On Thu, Aug 24, 2017 at 09:56:40 +0300, Nikolay Shirokovskiy wrote: >> Current code consults job.current->stats.status to check for postcopy >> state. First it is more correct to check for both job.current->status >> and job.current->stats.status.code

Re: [libvirt] [RFC v2] [OVS/NOVA] Vhost-user backends cross-version migration support

I'm CCing libvir-list and qemu-devel because I would like to get feedback from libvirt and QEMU developers too. On Tue, Aug 08, 2017 at 10:49:21PM +0300, Michael S. Tsirkin wrote: > On Tue, Jul 18, 2017 at 03:42:08PM +0200, Maxime Coquelin wrote: > > This is an revival from a thread I initiated

Re: [libvirt] [PATCH 4/5] conf: make sure that chardev reconnect is formatted only for connect mode

On Wed, Aug 30, 2017 at 02:32:50PM +0200, Michal Privoznik wrote: > On 08/30/2017 01:40 PM, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > src/conf/domain_conf.c | 10 ++ > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git

Re: [libvirt] [PATCH 3/5] tests: don't use unix socket path that matches auto-generated path

On Wed, Aug 30, 2017 at 02:33:00PM +0200, Michal Privoznik wrote: > On 08/30/2017 01:40 PM, Pavel Hrdina wrote: > > The test was introduced by 60135b22db6d. > > > > The auto-generated path is removed by post-parse callback which > > also changes the mode from "connect" to "bind" since the

Re: [libvirt] [PATCH 1/5] tests: remove unused file

On 08/30/2017 01:40 PM, Pavel Hrdina wrote: > Introduced by 95fd63b1700d. > > Signed-off-by: Pavel Hrdina > --- > .../qemuxml2argv-channel-reconnect.args| 31 > -- > 1 file changed, 31 deletions(-) > delete mode 100644

Re: [libvirt] [PATCH 3/5] tests: don't use unix socket path that matches auto-generated path

On 08/30/2017 01:40 PM, Pavel Hrdina wrote: > The test was introduced by 60135b22db6d. > > The auto-generated path is removed by post-parse callback which > also changes the mode from "connect" to "bind" since the auto-generated > path makes sense only for "bind" mode. > > Signed-off-by: Pavel

Re: [libvirt] [PATCH 4/5] conf: make sure that chardev reconnect is formatted only for connect mode

On 08/30/2017 01:40 PM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/conf/domain_conf.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index f7574d77b6..7f443e5b4d 100644

Re: [libvirt] [PATCH 5/5] qemu: make sure that chardev reconnect is formatted only for connect mode

On 08/30/2017 01:40 PM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/qemu/qemu_command.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > ACK and safe for the freeze. Thank you for looking into this. Michal -- libvir-list mailing list

Re: [libvirt] [PATCH 2/5] conf: add reconnect to virDomainChrSourceDef(Copy|IsEqual)

On 08/30/2017 01:40 PM, Pavel Hrdina wrote: > Missed by 9aa72a6dd5b3. > > Signed-off-by: Pavel Hrdina > --- > src/conf/domain_conf.c | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) ACK and safe for the freeze. Michal -- libvir-list mailing list

[libvirt] [PATCH 5/5] qemu: make sure that chardev reconnect is formatted only for connect mode

Signed-off-by: Pavel Hrdina --- src/qemu/qemu_command.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 9a27987d4a..2bc6bea888 100644 --- a/src/qemu/qemu_command.c +++

[libvirt] [PATCH 3/5] tests: don't use unix socket path that matches auto-generated path

The test was introduced by 60135b22db6d. The auto-generated path is removed by post-parse callback which also changes the mode from "connect" to "bind" since the auto-generated path makes sense only for "bind" mode. Signed-off-by: Pavel Hrdina ---

[libvirt] [PATCH 1/5] tests: remove unused file

Introduced by 95fd63b1700d. Signed-off-by: Pavel Hrdina --- .../qemuxml2argv-channel-reconnect.args| 31 -- 1 file changed, 31 deletions(-) delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-channel-reconnect.args diff --git

[libvirt] [PATCH 4/5] conf: make sure that chardev reconnect is formatted only for connect mode

Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f7574d77b6..7f443e5b4d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[libvirt] [PATCH 0/5] chardev source reconnect cleanup and fixes

Pavel Hrdina (5): tests: remove unused file conf: add reconnect to virDomainChrSourceDef(Copy|IsEqual) tests: don't use unix socket path that matches auto-generated path conf: make sure that chardev reconnect is formatted only for connect mode qemu: make sure that chardev reconnect

[libvirt] [PATCH 2/5] conf: add reconnect to virDomainChrSourceDef(Copy|IsEqual)

Missed by 9aa72a6dd5b3. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d97aab4834..f7574d77b6 100644 --- a/src/conf/domain_conf.c

[libvirt] [PATCH] keycodes: fix for 'make dist'

'make dist' fails with error now: make[2]: Entering directory `/root/dev/libvirt/src' make[2]: *** No rule to make target `linux', needed by `distdir'. Stop It turns out that in am__libvirt_util_la_SOURCES_DIST variable KEYTABLES is not expanded correctly. Like 'linux' stays 'linux' instead of

Re: [libvirt] [PATCH 1/3] doc: Fix docs/news.xml template structure

On Wed, Aug 30, 2017 at 15:44:35 +0530, Kothapally Madhu Pavan wrote: > Signed-off-by: Kothapally Madhu Pavan > --- > docs/news.xml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This one is now pushed. signature.asc Description: PGP signature --

[libvirt] [PATCH v2 0/2] Fix docs/news.xml template structure and add new features

This patchset will fix docs/news.xml template structure which is broken by commit b7e779c1a51793 and add support for managedsave-define, managedsave-edit and managedsave-dumpxml commands. Kothapally Madhu Pavan (2): docs: Fix docs/news.xml template structure docs: Document managedsave-edit

[libvirt] [PATCH v2 2/2] docs: Document managedsave-edit commands support

This patch documents support for managedsave-dumpxml, managedsave-define and managedsave-edit commands. Signed-off-by: Kothapally Madhu Pavan --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index

[libvirt] [PATCH v2 1/2] docs: Fix docs/news.xml template structure

Signed-off-by: Kothapally Madhu Pavan --- docs/news.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index 05152b8..088966d 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -35,8 +35,8 @@ - -

Re: [libvirt] [PATCH 3/3] doc: Document managedsave-dumpxml support

On Wed, Aug 30, 2017 at 15:44:37 +0530, Kothapally Madhu Pavan wrote: > Signed-off-by: Kothapally Madhu Pavan > --- > docs/news.xml | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/docs/news.xml b/docs/news.xml > index 119c478..fd64094 100644 > ---

[libvirt] [PATCH 1/3] doc: Fix docs/news.xml template structure

Signed-off-by: Kothapally Madhu Pavan --- docs/news.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index 05152b8..088966d 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -35,8 +35,8 @@ - -

[libvirt] [PATCH 2/3] doc: Document managedsave-define and managedsave-edit support

Signed-off-by: Kothapally Madhu Pavan --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 088966d..119c478 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -37,6 +37,16 @@ +

[libvirt] [PATCH 3/3] doc: Document managedsave-dumpxml support

Signed-off-by: Kothapally Madhu Pavan --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 119c478..fd64094 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -37,6 +37,15 @@ +

[libvirt] [PATCH 0/3] Fix docs/news.xml template structure and add new features

This patchset will fix docs/news.xml template structure which is broken by commit b7e779c1a51793 and add support for managedsave-define, managedsave-edit and managedsave-dumpxml commands. Kothapally Madhu Pavan (3): doc: Fix docs/news.xml template structure doc: Document managedsave-define

Re: [libvirt] [PATCH] Add qcow2 cache configuration

On Wed, Aug 30, 2017 at 11:12:02AM +0200, Martin Kletzander wrote: > On Wed, Aug 30, 2017 at 04:07:16PM +0800, Liu Qing wrote: > >Random write IOPS will drop dramatically if qcow2 l2 cache could not > >cover the whole disk. This patch give libvirt user a chance to adjust > >the qcow2 cache

Re: [libvirt] [PATCH] Add qcow2 cache configuration

On Wed, Aug 30, 2017 at 04:07:16PM +0800, Liu Qing wrote: Random write IOPS will drop dramatically if qcow2 l2 cache could not cover the whole disk. This patch give libvirt user a chance to adjust the qcow2 cache configuration. Thanks for the patch, but it has no documentation, no capability

Re: [libvirt] [PATCH for 3.7.0] docs: Document yet another limitation of tx_queue_size

On 08/30/2017 10:23 AM, Peter Krempa wrote: > On Wed, Aug 30, 2017 at 10:18:17 +0200, Michal Privoznik wrote: >> On 08/30/2017 10:03 AM, Peter Krempa wrote: >>> On Tue, Aug 29, 2017 at 17:05:23 +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1484234 Turns

Re: [libvirt] [PATCH v3 REBASE 13/16] qemu: support getting disks stats during stopping block jobs

On 30.08.2017 11:07, Jiri Denemark wrote: > On Thu, Aug 24, 2017 at 09:56:50 +0300, Nikolay Shirokovskiy wrote: >> Let's store disks stats for completed mirror jobs in current >> job info. So on getting migration job stats thru API >> we take records for completed jobs from current job info >>

[libvirt] [PATCH] tests: Fix virnetsockettest after SSH command line changes

Commit e4cb8500810a changed the way ssh command line is created by adding '--' before the hostname in order to fix a potential security flaw. However it failed to modify the tests, so let's do that. Signed-off-by: Martin Kletzander --- Pushed under the build-breaker rule.

[libvirt] [PATCH] Add qcow2 cache configuration

Random write IOPS will drop dramatically if qcow2 l2 cache could not cover the whole disk. This patch give libvirt user a chance to adjust the qcow2 cache configuration. Signed-off-by: Liu Qing --- src/conf/domain_conf.c| 30 ++

Re: [libvirt] [PATCH v3 REBASE 12/16] qemu: migrate: show disks stats on job info requests

On 29.08.2017 18:20, Jiri Denemark wrote: > On Thu, Aug 24, 2017 at 09:56:49 +0300, Nikolay Shirokovskiy wrote: >> This patch shows incorrect info when client request comes >> when migration routine is stopping mirror jobs or mirror >> jobs already stopped. This issue will be addressed in next

Re: [libvirt] [PATCH for 3.7.0] docs: Document yet another limitation of tx_queue_size

On Wed, Aug 30, 2017 at 10:18:17 +0200, Michal Privoznik wrote: > On 08/30/2017 10:03 AM, Peter Krempa wrote: > > On Tue, Aug 29, 2017 at 17:05:23 +0200, Michal Privoznik wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=1484234 > >> > >> Turns out, only vhostuser type of interfaces are

Re: [libvirt] [PATCH] Fix TLS test suites with gnutls 3.6.0

On 08/29/2017 05:25 PM, Daniel P. Berrange wrote: > With gnutls 3.6.0, SHA1 is no longer accepted for certificate > signatures. We must usw SHA256 instead. > > Signed-off-by: Daniel P. Berrange > --- > tests/virnettlshelpers.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [libvirt] [PATCH for 3.7.0] docs: Document yet another limitation of tx_queue_size

On 08/30/2017 10:03 AM, Peter Krempa wrote: > On Tue, Aug 29, 2017 at 17:05:23 +0200, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1484234 >> >> Turns out, only vhostuser type of interfaces are supported >> currently. >> >> Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH] Fix TLS test suites with gnutls 3.6.0

On Tue, Aug 29, 2017 at 16:25:56 +0100, Daniel Berrange wrote: > With gnutls 3.6.0, SHA1 is no longer accepted for certificate > signatures. We must usw SHA256 instead. s/usw/use/ > > Signed-off-by: Daniel P. Berrange > --- > tests/virnettlshelpers.c | 2 +- > 1 file

Re: [libvirt] [PATCH v3 REBASE 16/16] qemu: migration: don't expose incomplete job as complete

On Thu, Aug 24, 2017 at 09:56:53 +0300, Nikolay Shirokovskiy wrote: > In case of real migration (not migrating to file on save, dump etc) > migration info is not complete at time qemu finishes migration > in normal (non postcopy) mode. We need to update disks stats, > downtime info etc. Thus let's

Re: [libvirt] [PATCH v3 REBASE 13/16] qemu: support getting disks stats during stopping block jobs

On Thu, Aug 24, 2017 at 09:56:50 +0300, Nikolay Shirokovskiy wrote: > Let's store disks stats for completed mirror jobs in current > job info. So on getting migration job stats thru API > we take records for completed jobs from current job info > and records for still active jobs by querying qemu

Re: [libvirt] [PATCH for 3.7.0] docs: Document yet another limitation of tx_queue_size

On Tue, Aug 29, 2017 at 17:05:23 +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1484234 > > Turns out, only vhostuser type of interfaces are supported > currently. > > Signed-off-by: Michal Privoznik > --- > > I'd like to get this one in since

Re: [libvirt] [PATCH v3 REBASE 06/16] qemu: refactor fetching migration stats

On 29.08.2017 16:45, Jiri Denemark wrote: > On Thu, Aug 24, 2017 at 09:56:43 +0300, Nikolay Shirokovskiy wrote: >> qemuMigrationFetchJobStatus is rather inconvinient. Some of its >> callers don't need status to be updated, some don't need to update >> elapsed time right away. So let's update

Re: [libvirt] [PATCH] lxcStateInitialize: Don't leak driver's caps

On Tue, 2017-08-29 at 18:16 +0200, Michal Privoznik wrote: > Funny thing. So when initializing LXC driver's capabilities, > firstly the virLXCDriverGetCapabilities() is called. This creates > new capabilities, stores them under driver->caps, ref() them and > return them. However, the return value