[libvirt] [PATCH v5 1/2] conf, docs: Add qcow2 cache configuration support

Random write IOPS will drop dramatically if qcow2 l2 cache could not cover the whole disk. This patch gives libvirt user a chance to adjust the qcow2 cache configuration. Three new qcow2 driver parameters (l2-cache-size, refcount-cache-size and cache-clean-interval) are added as attributes to a

[libvirt] [PATCH v5 2/2] qemu: add capability checking for qcow2 cache configuration

Add qemu capabilities QEMU_CAPS_L2_CACHE_SIZE, QEMU_CAPS_REFCOUNT_CACHE_SIZE, QEMU_CAPS_CACHE_CLEAN_INTERVAL. Add testing for the above qemu capabilities. Signed-off-by: Liu Qing --- src/qemu/qemu_capabilities.c | 11

[libvirt] [PATCH v5 0/2] Add support for qcow2 cache

Qcow2 small IO random write performance will drop dramatically if the l2 cache table could not cover the whole disk. This will be a lot of l2 cache table RW operations if cache miss happens frequently. This patch exports the qcow2 driver parameter l2-cache-size/refcount-cache-size, first added

Re: [libvirt] [PATCH v4 1/2] conf, docs: Add qcow2 cache configuration support

On Wed, Sep 13, 2017 at 01:20:03PM +0200, Peter Krempa wrote: > On Wed, Sep 13, 2017 at 17:21:23 +0800, Liu Qing wrote: > > Random write IOPS will drop dramatically if qcow2 l2 cache could not > > cover the whole disk. This patch gives libvirt user a chance to adjust > > the qcow2 cache

Re: [libvirt] [PATCH 1/2] conf, docs: Add qcow2 cache configuration support

On Tue, Sep 12, 2017 at 05:21:53PM -0400, John Ferlan wrote: > > > On 09/07/2017 02:09 AM, Liu Qing wrote: > > Random write IOPS will drop dramatically if qcow2 l2 cache could not > > cover the whole disk. This patch gives libvirt user a chance to adjust > > the qcow2 cache configuration. > > >

Re: [libvirt] [PATCH v4 0/2] Add support for qcow2 cache

On Wed, Sep 13, 2017 at 06:51:35AM -0400, John Ferlan wrote: > > > On 09/13/2017 05:21 AM, Liu Qing wrote: > > Qcow2 small IO random write performance will drop dramatically if the l2 > > cache table could not cover the whole disk. This will be a lot of l2 > > cache table RW operations if cache

Re: [libvirt] QEMU -M nvdimm=on and hotplug

On 09/13/17 17:28 +0200, Michal Privoznik wrote: > > BTW: I ran a migration from no nvdimm qemu to one that had -M nvdimm=on > and guest migrated happily. So looks like guest ABI is stable (or at > least stable enough not to crash). But since ACPI table is changed I > doubt that. One example

Re: [libvirt] [PATCH v7 06/11] qemu: Add qemu command line generation for a VxHS block device

On 09/12/2017 01:56 PM, ashish mittal wrote: > Hi, > > Updating the list with some test results of the base VxHS functionality > (without TLS), and some changes resulting therefrom - > > (A) Qemu did not work with the > changed file.server.0.host=127.0.0.1 syntax. Threw an error "Parameter >

Re: [libvirt] [PATCH v2 2/2] qemu: Implement usernet address

On 09/13/2017 06:47 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1075520 > > Apart from generic checks, we need to constrain netmask/prefix > lenght a bit. Thing is, with current implementation QEMU needs to s/lenght/length/ > be able to 'assign' some IP addresses to

Re: [libvirt] [PATCH v2 1/2] conf: Allow usernet to have an address

On 09/13/2017 06:47 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1075520 > > Currently, all that users can specify for an interface type of > 'user' is the common attributes: PCI address, NIC model (and > that's basically it). However, some need to configure other >

Re: [libvirt] [PATCH 5/5] qemu: Implement usernet address

On 09/13/2017 06:46 AM, Michal Privoznik wrote: > On 09/12/2017 09:16 PM, Laine Stump wrote: >> On 09/12/2017 05:32 AM, Michal Privoznik wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1075520 >>> >>> +/* QEMU needs some space to have >>> + * some other

Re: [libvirt] [PATCH go-xml 0/2] DomainAddress parsing fix

On Wed, Sep 13, 2017 at 01:57:44PM +0100, Dean Smith wrote: > *** BLURB HERE *** > I have taken Anton Kryukovs fix from #13 on github and am submitting > along with addition of 1.8 and 1.9 as travis go version targets > > Example of failing running on 1.9, which passes on 1.7 can be found > at >

Re: [libvirt] QEMU -M nvdimm=on and hotplug

On 09/13/2017 03:54 PM, Stefan Hajnoczi wrote: > Hi Michal, > You asked how NVDIMM hotplug should work if the domain was launched > without -M nvdimm=on. I'm not very familiar with ACPI so this may be > incorrect. > > Hotplug relies on the presence of ACPI tables (SSDT Device=NVDR >

Re: [libvirt] [PATCH 2/3] qemu: monitor: Remove support for "legacy" block jobs

On 09/13/2017 08:52 AM, Peter Krempa wrote: > Drop all the monitor code necessary to do the downstream block jobs. > --- > src/qemu/qemu_driver.c | 7 +++ > src/qemu/qemu_migration.c| 2 +- > src/qemu/qemu_monitor.c | 24 ++-- > src/qemu/qemu_monitor.h

Re: [libvirt] [PATCH 3/3] qemu: caps: Deprecate QEMU_CAPS_BLOCKJOB_SYNC

On 09/13/2017 08:52 AM, Peter Krempa wrote: > Interrestingly, none of the qemus we have caps for supported it ... s/Interrestingly/Interestingly/ > --- > src/qemu/qemu_capabilities.c | 1 - > src/qemu/qemu_capabilities.h | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) Reviewed-by:

Re: [libvirt] [PATCH 1/3] qemu: Remove support for legacy block jobs

On 09/13/2017 08:52 AM, Peter Krempa wrote: > Block job QMP commands with underscores rather than dashes were never > released in upstream qemu, (they were added, but modified in the same > release [1]), but a certain distro managed to backport the version in the > middle. I find it fine that you

[libvirt] [PATCH 1/3] qemu: Remove support for legacy block jobs

Block job QMP commands with underscores rather than dashes were never released in upstream qemu, (they were added, but modified in the same release [1]), but a certain distro managed to backport the version in the middle. The change also slightly modified semantics for the abort command, which

[libvirt] QEMU -M nvdimm=on and hotplug

Hi Michal, You asked how NVDIMM hotplug should work if the domain was launched without -M nvdimm=on. I'm not very familiar with ACPI so this may be incorrect. Hotplug relies on the presence of ACPI tables (SSDT Device=NVDR _HID=ACPI0012) added by -M nvdimm=on. The ACPI tables contain the

[libvirt] [PATCH 2/3] qemu: monitor: Remove support for "legacy" block jobs

Drop all the monitor code necessary to do the downstream block jobs. --- src/qemu/qemu_driver.c | 7 +++ src/qemu/qemu_migration.c| 2 +- src/qemu/qemu_monitor.c | 24 ++-- src/qemu/qemu_monitor.h | 9 +++-- src/qemu/qemu_monitor_json.c | 17

[libvirt] [PATCH 0/3] qemu: Remove support for downstream-only blockjob

See patch 1/3 Peter Krempa (3): qemu: Remove support for legacy block jobs qemu: monitor: Remove support for "legacy" block jobs qemu: caps: Deprecate QEMU_CAPS_BLOCKJOB_SYNC src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_domain.c | 13

Re: [libvirt] [PATCH 2/2] qemu: Use secret objects to pass iSCSI passwords

On Wed, Sep 13, 2017 at 03:24:42PM +0200, Peter Krempa wrote: > On Wed, Sep 13, 2017 at 09:05:43 -0400, John Ferlan wrote: > > > > I was thinking more about virstoragefile.c and virstoragetest.c. It's > > easy enough to fetch the user/password-secret in > > virStorageSourceParseBackingJSONiSCSI:

[libvirt] [PATCH go-xml 2/2] Adding go 1.8 and 1.9 to travis tests

--- .travis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index 5e6be77..dd13140 100644 --- a/.travis.yml +++ b/.travis.yml @@ -6,6 +6,8 @@ go: - 1.5 - 1.6 - 1.7 + - 1.8 + - 1.9 script: go test -timeout 1m -v -- 1.8.3.1 -- libvir-list

[libvirt] [PATCH 3/3] qemu: caps: Deprecate QEMU_CAPS_BLOCKJOB_SYNC

Interrestingly, none of the qemus we have caps for supported it ... --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index e7ea6f47c..c690cb349

[libvirt] [PATCH go-xml 0/2] DomainAddress parsing fix

*** BLURB HERE *** I have taken Anton Kryukovs fix from #13 on github and am submitting along with addition of 1.8 and 1.9 as travis go version targets Example of failing running on 1.9, which passes on 1.7 can be found at g...@github.com:deasmi/libvirt-go-xml.git branch parsefailtest Anton

[libvirt] [PATCH go-xml 1/2] Add support for hex values in DomainAddress struct

From: Anton Kryukov Add support for hex values in DomainAddress struct Tests fixed for HexUint >From PR#13 https://github.com/libvirt/libvirt-go-xml/pull/13 on github by Emreu @deasmi submitting via mail --- domain.go | 27 ++- domain_test.go |

Re: [libvirt] [PATCH 2/2] qemu: Use secret objects to pass iSCSI passwords

On Wed, Sep 13, 2017 at 09:05:43 -0400, John Ferlan wrote: > > > On 09/13/2017 03:08 AM, Peter Krempa wrote: > > On Tue, Sep 12, 2017 at 11:55:29 -0400, John Ferlan wrote: > >> > >> > >> On 09/12/2017 09:36 AM, Peter Krempa wrote: > >>> On Tue, Sep 05, 2017 at 15:09:35 -0400, John Ferlan wrote:

Re: [libvirt] [PATCH 2/2] qemu: Use secret objects to pass iSCSI passwords

On 09/13/2017 03:08 AM, Peter Krempa wrote: > On Tue, Sep 12, 2017 at 11:55:29 -0400, John Ferlan wrote: >> >> >> On 09/12/2017 09:36 AM, Peter Krempa wrote: >>> On Tue, Sep 05, 2017 at 15:09:35 -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1425757 The

Re: [libvirt] [PATCH] news: document spice rendernode DAC changes

On Tue, 2017-09-12 at 12:37 -0400, Cole Robinson wrote: > Signed-off-by: Cole Robinson > --- > docs/news.xml | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/docs/news.xml b/docs/news.xml > index 483f9d6d1..17f00a25e 100644 > --- a/docs/news.xml > +++

[libvirt] [PATCH 3/3] cpu: Add new Skylake-Server CPU model

Available since QEMU 2.10.0 (specifically commit v2.9.0-2233-g53f9a6f45f). Signed-off-by: Jiri Denemark --- src/cpu/cpu_map.xml| 75 ++ .../x86_64-cpuid-Xeon-Gold-6148-guest.xml | 9 +--

[libvirt] [PATCH 1/3] tests: Add CPUID data for Intel(R) Xeon(R) Gold 6148 CPU

Signed-off-by: Jiri Denemark --- tests/cputest.c| 1 + .../x86_64-cpuid-Xeon-Gold-6148-disabled.xml | 7 + .../x86_64-cpuid-Xeon-Gold-6148-enabled.xml| 9 + .../x86_64-cpuid-Xeon-Gold-6148-guest.xml | 35 +++

[libvirt] [PATCH 2/3] cpu: Add clwb/pcommit CPU features

The features were added to QEMU by commit v2.4.0-1690-gf7fda28094 as Skylake Server features. Signed-off-by: Jiri Denemark --- src/cpu/cpu_map.xml | 6 ++ tests/cputestdata/x86_64-cpuid-Xeon-Gold-6148-guest.xml | 1 +

[libvirt] [PATCH 0/3] cpu: Add new Skylake-Server CPU model

Jiri Denemark (3): tests: Add CPUID data for Intel(R) Xeon(R) Gold 6148 CPU cpu: Add clwb/pcommit CPU features cpu: Add new Skylake-Server CPU model src/cpu/cpu_map.xml| 81 +++ tests/cputest.c| 1 +

Re: [libvirt] [PATCH v4 1/2] conf, docs: Add qcow2 cache configuration support

On Wed, Sep 13, 2017 at 17:21:23 +0800, Liu Qing wrote: > Random write IOPS will drop dramatically if qcow2 l2 cache could not > cover the whole disk. This patch gives libvirt user a chance to adjust > the qcow2 cache configuration. > > Three new qcow2 driver parameters are added. They are

Re: [libvirt] [PATCH v4 0/2] Add support for qcow2 cache

On 09/13/2017 05:21 AM, Liu Qing wrote: > Qcow2 small IO random write performance will drop dramatically if the l2 > cache table could not cover the whole disk. This will be a lot of l2 > cache table RW operations if cache miss happens frequently. > > This patch exports the qcow2 driver

[libvirt] [PATCH v2 2/2] qemu: Implement usernet address

https://bugzilla.redhat.com/show_bug.cgi?id=1075520 Apart from generic checks, we need to constrain netmask/prefix lenght a bit. Thing is, with current implementation QEMU needs to be able to 'assign' some IP addresses to the virtual network. For instance, the default gateway is at x.x.x.2, dns

[libvirt] [PATCH v2 1/2] conf: Allow usernet to have an address

https://bugzilla.redhat.com/show_bug.cgi?id=1075520 Currently, all that users can specify for an interface type of 'user' is the common attributes: PCI address, NIC model (and that's basically it). However, some need to configure other address range than the default one. Signed-off-by: Michal

[libvirt] [PATCH v2 0/2] Allow usernet to have an address

diff to v1: - moved the directly under - enhanced the test - tuned some error messages Michal Privoznik (2): conf: Allow usernet to have an address qemu: Implement usernet address docs/formatdomain.html.in | 8 +++- src/qemu/qemu_command.c

Re: [libvirt] [PATCH 5/5] qemu: Implement usernet address

On 09/12/2017 09:16 PM, Laine Stump wrote: > On 09/12/2017 05:32 AM, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1075520 >> >> Apart from generic checks, we need to constrain netmask/prefix >> lenght a bit. Thing is, with current implementation QEMU needs to >> be able

[libvirt] [PATCH v4 2/2] qemu: add capability checking for qcow2 cache configuration

Add qemu capabilities QEMU_CAPS_L2_CACHE_SIZE, QEMU_CAPS_REFCOUNT_CACHE_SIZE, QEMU_CAPS_CACHE_CLEAN_INTERVAL. Add testing for the above qemu capabilities. Signed-off-by: Liu Qing --- src/qemu/qemu_capabilities.c | 9 + src/qemu/qemu_capabilities.h

[libvirt] [PATCH v4 0/2] Add support for qcow2 cache

Qcow2 small IO random write performance will drop dramatically if the l2 cache table could not cover the whole disk. This will be a lot of l2 cache table RW operations if cache miss happens frequently. This patch exports the qcow2 driver parameter l2-cache-size/refcount-cache-size, first added

Re: [libvirt] [PATCH] virsh.pod: Fix units for dommemstat and domstats

On 09/13/2017 09:52 AM, Peter Krempa wrote: > On Wed, Sep 13, 2017 at 09:30:45 +0200, Michal Privoznik wrote: >> The documentation mistakenly states that the unit for returned >> values is kB (multiple of 1000), while in fact we are returning >> KiB (multiple of 1024). >> >> Signed-off-by: Michal

[libvirt] [PATCH v4 1/2] conf, docs: Add qcow2 cache configuration support

Random write IOPS will drop dramatically if qcow2 l2 cache could not cover the whole disk. This patch gives libvirt user a chance to adjust the qcow2 cache configuration. Three new qcow2 driver parameters are added. They are l2-cache-size, refcount-cache-size and cache-clean-interval. The

Re: [libvirt] [PATCH 4/5] conf: Allow usernet to have an address

On 09/12/2017 07:35 PM, Laine Stump wrote: > On 09/12/2017 05:53 AM, Martin Kletzander wrote: >> On Tue, Sep 12, 2017 at 11:32:52AM +0200, Michal Privoznik wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1075520 >>> >>> Currently, all that users can specify for an interface type of >>>

Re: [libvirt] [PATCH] virsh.pod: Fix units for dommemstat and domstats

On Wed, Sep 13, 2017 at 09:30:45 +0200, Michal Privoznik wrote: > The documentation mistakenly states that the unit for returned > values is kB (multiple of 1000), while in fact we are returning > KiB (multiple of 1024). > > Signed-off-by: Michal Privoznik > --- > > Oops, I

Re: [libvirt] [PATCH] qemu: Clean up qemuDomainSecretPrepare

On Wed, Aug 30, 2017 at 15:48:37 -0400, John Ferlan wrote: > No need to pass a @driver parameter since all that's done is deref > the @cfg especially since the only caller can just pass an already > referenced @cfg. > > Also, looks like commit id '0298531b' at one time had a different > name for

Re: [libvirt] external snapshots bug

On Tue, Sep 12, 2017 at 20:49:12 +0300, Khasan Khafizov wrote: > Suppose we have a disk with several external snapshots of it. This disk is > attached to some domain. I found that after destroying and starting the > domain the xml of attached disk doesn't contain all backingStore that it > has to.

Re: [libvirt] [PATCH 4/5] conf: Allow usernet to have an address

On Tue, Sep 12, 2017 at 01:35:08PM -0400, Laine Stump wrote: On 09/12/2017 05:53 AM, Martin Kletzander wrote: On Tue, Sep 12, 2017 at 11:32:52AM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1075520 Currently, all that users can specify for an interface type of

[libvirt] [PATCH] virsh.pod: Fix units for dommemstat and domstats

The documentation mistakenly states that the unit for returned values is kB (multiple of 1000), while in fact we are returning KiB (multiple of 1024). Signed-off-by: Michal Privoznik --- Oops, I forgot to send this one, tools/virsh.pod | 30 +++---

Re: [libvirt] [PATCH 2/2] qemu: Use secret objects to pass iSCSI passwords

On Tue, Sep 12, 2017 at 11:55:29 -0400, John Ferlan wrote: > > > On 09/12/2017 09:36 AM, Peter Krempa wrote: > > On Tue, Sep 05, 2017 at 15:09:35 -0400, John Ferlan wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=1425757 > >> > >> The blockdev-add code provides a mechanism to sanely