Re: [libvirt] [PATCH 2/6] conf: Add invalid secrettype checks

On Thu, Sep 14, 2017 at 14:03:06 -0400, John Ferlan wrote: > Add a couple of tests to "validate" checks in domain_conf that either The quotes seem slightly inapropriate here. If this only "validates" the checks, then why to add it? Just validate them. > a missing secrettype (CONFIG_UNSUPPORTED)

Re: [libvirt] [PATCH 1/6] docs: Remove unnecessary example for iscsi disk type='volume'

On Thu, Sep 14, 2017 at 14:03:05 -0400, John Ferlan wrote: > Alter the example to remove the from: > > > > > > > > > > > and > > > > > > > > > > > The reality is, it's not even used. For a the authdef > from the

Re: [libvirt] [PATCH 6/6] conf: Use virXMLFormatElement to format disk source network

On Thu, Sep 14, 2017 at 14:03:10 -0400, John Ferlan wrote: > Commit id 'e02ff020cac' neglected to use the attrBuf and childBuf > in the virDomainDiskSourceFormatNetwork call. > > So make the necessary alterations to allow usage. > > Signed-off-by: John Ferlan > --- >

Re: [libvirt] [PATCH 4/6] conf: Add invalid domain disk encryption test

On Thu, Sep 14, 2017 at 14:03:08 -0400, John Ferlan wrote: > Add a test to prove checking for invalid luks disk formatting check According to the error message the element is not necessary when defining a disk for a domain: 419) QEMU XML-2-ARGV luks-disk-invalid

Re: [libvirt] [PATCH 5/6] conf: Move encryption validation

On Thu, Sep 14, 2017 at 14:03:09 -0400, John Ferlan wrote: > Rather than checking during XML processing, move the check for > valid into virDomainDiskDefParseValidate. > > Signed-off-by: John Ferlan > --- > src/conf/domain_conf.c | 29 + > 1 file

Re: [libvirt] [PATCH 3/6] conf: Move authdef validation

On Thu, Sep 14, 2017 at 14:03:07 -0400, John Ferlan wrote: > Rather than checking during XML processing, move the checks for correct > and valid auth into virDomainDiskDefParseValidate. This will introduce > virDomainDiskSourceDefParseAuthValidate to validate that the authdef > stored for the

Re: [libvirt] [PATCH] spec: Own %{_libdir}/libvirt{, /connection-driver} dirs, mark licenses as %license

On 08/28/2017 03:15 AM, Peter Krempa wrote: > On Sun, Aug 27, 2017 at 12:35:07 -0400, Cole Robinson wrote: >> From: Ville Skyttä >> >> https://bugzilla.redhat.com/show_bug.cgi?id=1483293 >> Signed-off-by: Cole Robinson >> --- > > Looks like two separate

[libvirt] [PATCH] spec: Use %license when available

This is required by the fedora packaging guidelines: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines This macro isn't available on stock RHEL6 so provide a backcompat definition https://bugzilla.redhat.com/show_bug.cgi?id=1483293 Reported-by: Ville Skyttä

[libvirt] [PATCH] spec: Own %{_libdir}/libvirt{, /connection-driver} dirs

From: Ville Skyttä Owning all created directories is a requirement of the Fedora packaging guidelines https://bugzilla.redhat.com/show_bug.cgi?id=1483293 Signed-off-by: Cole Robinson --- libvirt.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff

[libvirt] [PATCH 5/6] conf: Move encryption validation

Rather than checking during XML processing, move the check for valid into virDomainDiskDefParseValidate. Signed-off-by: John Ferlan --- src/conf/domain_conf.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git

[libvirt] [PATCH 2/6] conf: Add invalid secrettype checks

Add a couple of tests to "validate" checks in domain_conf that either a missing secrettype (CONFIG_UNSUPPORTED) or an mismatched secrettype of ceph for an iSCSI disk (INTERNAL_ERROR) will cause a parsing error. Signed-off-by: John Ferlan ---

[libvirt] [PATCH 0/6] Some disk auth/encryption cleanups

Perform some cleanups with the auth and encryption processing. This is a precursor to some other changes that will move/create disk level and elements since they are already in the _virStorageSource. I'm still working on the latter, but before there's too many patches. John Ferlan (6):

[libvirt] [PATCH 6/6] conf: Use virXMLFormatElement to format disk source network

Commit id 'e02ff020cac' neglected to use the attrBuf and childBuf in the virDomainDiskSourceFormatNetwork call. So make the necessary alterations to allow usage. Signed-off-by: John Ferlan --- src/conf/domain_conf.c | 34 ++ 1 file changed,

[libvirt] [PATCH 3/6] conf: Move authdef validation

Rather than checking during XML processing, move the checks for correct and valid auth into virDomainDiskDefParseValidate. This will introduce virDomainDiskSourceDefParseAuthValidate to validate that the authdef stored for the virStorageSource is valid. This can then be expanded to service

[libvirt] [PATCH 4/6] conf: Add invalid domain disk encryption test

Add a test to prove checking for invalid luks disk formatting check Signed-off-by: John Ferlan --- .../qemuxml2argv-luks-disk-invalid.xml | 37 ++ tests/qemuxml2argvtest.c | 1 + 2 files changed, 38 insertions(+)

[libvirt] [PATCH 1/6] docs: Remove unnecessary example for iscsi disk type='volume'

Alter the example to remove the from: and The reality is, it's not even used. For a the authdef from the storage source pool will supercede whatever is in the definition during virStorageTranslateDiskSourcePool

Re: [libvirt] QEMU -M nvdimm=on and hotplug

On Wed, Sep 13, 2017 at 05:28:56PM +0200, Michal Privoznik wrote: > On 09/13/2017 03:54 PM, Stefan Hajnoczi wrote: > > 2. Only allow NVDIMM hotplug if the domain was started with -M > >nvdimm=on. > > > > I think QEMU will not add -M nvdimm=on to the "pc" machine type by > > default since it

Re: [libvirt] [PATCH 8/8] travis: Shuffle sections around

On Thu, 2017-09-14 at 17:31 +0200, Martin Kletzander wrote: > On Thu, Sep 14, 2017 at 03:09:08PM +0200, Andrea Bolognani wrote: > > Order them more logically and make sure that stuff that doesn't > > need to be modified frequently if at all, such as the notification > > settings, are out of the

Re: [libvirt] [PATCH 8/8] travis: Shuffle sections around

On Thu, Sep 14, 2017 at 03:09:08PM +0200, Andrea Bolognani wrote: Order them more logically and make sure that stuff that doesn't need to be modified frequently if at all, such as the notification settings, are out of the way. Perform other minor tweaks as well. Signed-off-by: Andrea Bolognani

Re: [libvirt] [PATCH 4/8] travis: Split building command

On Thu, Sep 14, 2017 at 05:10:24PM +0200, Andrea Bolognani wrote: On Thu, 2017-09-14 at 16:49 +0200, Martin Kletzander wrote: > So I'm on the fence about this patch - I'd have a slight preference for > existing behaviour of failing fast to keep errors at the end of the log I, personally, would

Re: [libvirt] [PATCHv2] nodedev: add switchdev to NIC capabilities

(Almost all of my comments result in "ok, no action needed". There are just three items I would like to see changed (2 trivial, 1 also small but Edan or John may think it prudent to re-test with the change before pushing) - I marked those comments with [**]. On 08/21/2017 05:19 AM, Edan David

Re: [libvirt] [PATCH 4/8] travis: Split building command

On Thu, Sep 14, 2017 at 02:48:06PM +0100, Daniel P. Berrange wrote: On Thu, Sep 14, 2017 at 03:09:04PM +0200, Andrea Bolognani wrote: The build will fail if any of the commands fail, but this way we might catch more errors in a single run. Signed-off-by: Andrea Bolognani

Re: [libvirt] [PATCH 4/8] travis: Split building command

On Thu, 2017-09-14 at 16:49 +0200, Martin Kletzander wrote: > > So I'm on the fence about this patch - I'd have a slight preference for > > existing behaviour of failing fast to keep errors at the end of the log > > I, personally, would go with: > > script: > - make -j3 check > - make -j3

Re: [libvirt] [PATCH 7/8] travis: Install more build dependencies

On Thu, Sep 14, 2017 at 04:09:37PM +0200, Andrea Bolognani wrote: > On Thu, 2017-09-14 at 14:50 +0100, Daniel P. Berrange wrote: > > > @@ -5,37 +5,60 @@ addons: > > >apt: > > > # Please keep this list sorted alphabetically > > > packages: > [...] > > > + - zfs-fuse > > > > Did

Re: [libvirt] [PATCH 7/8] travis: Install more build dependencies

On Thu, 2017-09-14 at 14:50 +0100, Daniel P. Berrange wrote: > > @@ -5,37 +5,60 @@ addons: > >apt: > > # Please keep this list sorted alphabetically > > packages: [...] > > + - zfs-fuse > > Did you check if travis actually lets you install all these ? They have > to whitelist

Re: [libvirt] [PATCH 4/8] travis: Split building command

On Thu, 2017-09-14 at 14:48 +0100, Daniel P. Berrange wrote: > > script: > > - - make -j3 && make -j3 syntax-check && make -j3 check > > + - make -j3 > > + - make -j3 syntax-check > > + - make -j3 check > > > > # Environments here are run in addition to the main environment defined > >

Re: [libvirt] [PATCH 4/8] travis: Split building command

On Thu, Sep 14, 2017 at 04:45:30PM +0200, Andrea Bolognani wrote: > On Thu, 2017-09-14 at 14:48 +0100, Daniel P. Berrange wrote: > > > script: > > > - - make -j3 && make -j3 syntax-check && make -j3 check > > > + - make -j3 > > > + - make -j3 syntax-check > > > + - make -j3 check > > > > > >

[libvirt] [PATCH 3/4] cpu_s390: Implement virCPUValidateFeatures

Only feature policy is checked on s390, which was previously done in virCPUUpdate, but that's not the correct place for the check once we have virCPUValidateFeatures. Signed-off-by: Jiri Denemark --- src/cpu/cpu_s390.c | 29 + 1 file changed, 21

[libvirt] [PATCH 2/4] qemu: Validate guest CPU features before starting a domain

Signed-off-by: Jiri Denemark --- src/qemu/qemu_process.c | 4 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 7e9b406b6a..d3155e4e75 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -4659,6

[libvirt] [PATCH 4/4] cpu_x86: Implement virCPUValidateFeatures

The function checks whether all CPU features used in a CPU definition are specified in cpu_map.xml. https://bugzilla.redhat.com/show_bug.cgi?id=1460086 Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 23 +++ 1 file changed, 23 insertions(+) diff

[libvirt] [PATCH 0/4] qemu: Validate guest CPU features before starting a domain

CPU features are usually checked by libvirt, but not if libvirt decides it should not check the CPU at all, which happens with host-passthrough CPUs, for example. Let's check all used CPU features are valid for all CPU definitions. https://bugzilla.redhat.com/show_bug.cgi?id=1460086 Jiri

[libvirt] [PATCH 1/4] cpu: Introduce virCPUValidateFeatures

This new API may be used to check whether all features used in a CPU definition are valid (e.g., libvirt knows their name, their policy is supported, etc.). Leaving this API unimplemented in an arch subdriver means libvirt does not restrict CPU features usable on the associated architectures.

Re: [libvirt] [PATCH 5/8] travis: Don't have a separate script definition for macOS

On Thu, Sep 14, 2017 at 03:09:05PM +0200, Andrea Bolognani wrote: > Make single commands OS-dependent instead. > > Signed-off-by: Andrea Bolognani > --- > .travis.yml | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/.travis.yml

Re: [libvirt] [PATCH 6/8] travis: Improve test matrix

On Thu, Sep 14, 2017 at 03:09:06PM +0200, Andrea Bolognani wrote: > The default distribution is apparently ignored if an explicit test > matrix is provided, so we haven't actually been testing the precise > plus gcc combo. > > Signed-off-by: Andrea Bolognani > --- >

Re: [libvirt] [PATCH python] Skip sparseRecvAll / sparseSendAll in sanity test

On 09/14/2017 02:50 PM, Daniel P. Berrange wrote: The sanity test check aims to ensure that every function listed in the Python code maps to a corresponding C function. The Sparse send/recv methods are special though - we're never calling the corresponding C APIs, instead we have a pure python

Re: [libvirt] [PATCH 4/8] travis: Split building command

On Thu, Sep 14, 2017 at 03:09:04PM +0200, Andrea Bolognani wrote: > The build will fail if any of the commands fail, but this way we > might catch more errors in a single run. > > Signed-off-by: Andrea Bolognani > --- > .travis.yml | 4 +++- > 1 file changed, 3

Re: [libvirt] [PATCH 7/8] travis: Install more build dependencies

On Thu, Sep 14, 2017 at 03:09:07PM +0200, Andrea Bolognani wrote: > Since configure automatically picks up as many optional dependencies > as possible, installing more packages allows us to improve our test > coverage. > > Signed-off-by: Andrea Bolognani > --- > .travis.yml

Re: [libvirt] [PATCH 3/8] travis: Don't abort build due to -Wvariadic-macros

On Thu, Sep 14, 2017 at 03:09:03PM +0200, Andrea Bolognani wrote: > The openwsman header files are at fault here, but precise is entirely > unmaintained at this point so the issue will never be fixed. > > Better to ignore the error and have coverage over the Hyper-V driver > than disabling it: if

Re: [libvirt] [PATCH 2/8] travis: Move variables to 'env' section

On Thu, Sep 14, 2017 at 03:09:02PM +0200, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > .travis.yml | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 8831f742c..367baf861 100644 > ---

Re: [libvirt] [PATCH 1/8] travis: Limit git depth to 5 commits

On Thu, Sep 14, 2017 at 03:09:01PM +0200, Andrea Bolognani wrote: > We don't need 50 commits for our purposes, so might as well save some > bandwidth and possibly some time by making the clone more shallow. > > Signed-off-by: Andrea Bolognani > --- > .travis.yml | 1 + > 1

[libvirt] [PATCH 5/8] travis: Don't have a separate script definition for macOS

Make single commands OS-dependent instead. Signed-off-by: Andrea Bolognani --- .travis.yml | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.travis.yml b/.travis.yml index c2526bc6d..e93fc73b2 100644 --- a/.travis.yml +++ b/.travis.yml @@ -77,8

[libvirt] [PATCH 2/8] travis: Move variables to 'env' section

Signed-off-by: Andrea Bolognani --- .travis.yml | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index 8831f742c..367baf861 100644 --- a/.travis.yml +++ b/.travis.yml @@ -60,14 +60,20 @@ git: depth: 5

[libvirt] [PATCH 3/8] travis: Don't abort build due to -Wvariadic-macros

The openwsman header files are at fault here, but precise is entirely unmaintained at this point so the issue will never be fixed. Better to ignore the error and have coverage over the Hyper-V driver than disabling it: if code that would trigger the warning will be added to libvirt, the CentOS CI

[libvirt] [PATCH 4/8] travis: Split building command

The build will fail if any of the commands fail, but this way we might catch more errors in a single run. Signed-off-by: Andrea Bolognani --- .travis.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index

Re: [libvirt] [libvirt-python][PATCH] maint: Require libvirt-3.4.0 at least

On 09/14/2017 02:42 PM, Daniel P. Berrange wrote: > On Thu, Sep 14, 2017 at 01:41:08PM +0200, Michal Privoznik wrote: >> Currently, we require 0.9.11. However, some APIs are missing >> there and thus sanity check fails: >> >> DEBUG: /usr/bin/python sanitytest.py build/lib.linux-s390x-2.7 >>

[libvirt] [PATCH 7/8] travis: Install more build dependencies

Since configure automatically picks up as many optional dependencies as possible, installing more packages allows us to improve our test coverage. Signed-off-by: Andrea Bolognani --- .travis.yml | 37 ++--- 1 file changed, 30 insertions(+), 7

[libvirt] [PATCH 1/8] travis: Limit git depth to 5 commits

We don't need 50 commits for our purposes, so might as well save some bandwidth and possibly some time by making the clone more shallow. Signed-off-by: Andrea Bolognani --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index

Re: [libvirt] [libvirt-python][PATCH] maint: Require libvirt-3.4.0 at least

On Thu, Sep 14, 2017 at 03:05:15PM +0200, Michal Privoznik wrote: > On 09/14/2017 02:42 PM, Daniel P. Berrange wrote: > > On Thu, Sep 14, 2017 at 01:41:08PM +0200, Michal Privoznik wrote: > >> Currently, we require 0.9.11. However, some APIs are missing > >> there and thus sanity check fails: > >>

[libvirt] [PATCH 0/8] travis: Fix and improve configuration

This series fixes the precise+gcc combo not being actually tested and significantly improves test coverage by installing a bunch of additional optional dependencies on the workers. Andrea Bolognani (8): travis: Limit git depth to 5 commits travis: Move variables to 'env' section travis:

Re: [libvirt] [libvirt-python][PATCH] maint: Require libvirt-3.4.0 at least

On Thu, Sep 14, 2017 at 01:41:08PM +0200, Michal Privoznik wrote: Currently, we require 0.9.11. However, some APIs are missing there and thus sanity check fails: DEBUG: /usr/bin/python sanitytest.py build/lib.linux-s390x-2.7 /usr/share/libvirt/api/libvirt-api.xml DEBUG: FAIL

[libvirt] [PATCH 8/8] travis: Shuffle sections around

Order them more logically and make sure that stuff that doesn't need to be modified frequently if at all, such as the notification settings, are out of the way. Perform other minor tweaks as well. Signed-off-by: Andrea Bolognani --- .travis.yml | 62

[libvirt] [PATCH 6/8] travis: Improve test matrix

The default distribution is apparently ignored if an explicit test matrix is provided, so we haven't actually been testing the precise plus gcc combo. Signed-off-by: Andrea Bolognani --- .travis.yml | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff

[libvirt] [PATCH v8 05/11] qemu: Refactor qemuBlockStorageSourceBuildHostsJSONSocketAddress

From: Ashish Mittal Extract out the "guts" of building a server entry into it's own separately callable/usable function in order to allow building a server entry for a consumer with src->nhosts == 1. Signed-off-by: John Ferlan ---

[libvirt] [PATCH v8 03/11] docs: Add schema and docs for Veritas HyperScale (VxHS)

From: Ashish Mittal Alter the schema to allow a VxHS block device. Sample XML is: eb90327c-8302-4725-9e1b-4e85ed4dc251 Update the html docs to describe the capability for VxHS. Alter the qemuxml2xmltest to validate the

[libvirt] [PATCH v8 02/11] storage: Introduce VIR_STORAGE_NET_PROTOCOL_VXHS

From: Ashish Mittal Add a new virStorageNetProtocol for Veritas HyperScale (VxHS) disks Signed-off-by: Ashish Mittal Signed-off-by: John Ferlan --- src/libxl/libxl_conf.c| 1 + src/qemu/qemu_block.c | 1

[libvirt] [PATCH v8 01/11] qemu: Detect support for vxhs

Using the query-qmp-schema introspection - look for the 'vxhs' blockdevOptions type. NB: This is a "best effort" type situation as there is not a mechanism to determine whether the running QEMU has been built with '--enable-vxhs'. All we can do is check if the option to use vxhs for a

Re: [libvirt] [PATCH 0/3] qemu: hotplig: Improve error reporting

On Tue, Sep 12, 2017 at 12:09:43PM +0200, Peter Krempa wrote: Add helpers to remember existing errors when they might be overwritten and use it to fix "unknown error" reported when attaching disk with lock manager enabled. Peter Krempa (3): util: error: Add helpers for saving and restoring of

[libvirt] [PATCH v8 09/11] qemu: Introduce qemuDomainPrepareDiskSource

Introduce a function to setup any TLS needs for a disk source. If there's a configuration or other error setting up the disk source for TLS, then cause the domain startup to fail. For VxHS, follow the chardevTLS model where if the src->haveTLS hasn't been configured, then take the system/global

[libvirt] [PATCH v8 04/11] util: storage: Add JSON backing volume parse for VxHS

From: Ashish Mittal Add the backing parse and a test case to verify parsing of VxHS backing storage. Signed-off-by: Ashish Mittal Signed-off-by: John Ferlan --- src/util/virstoragefile.c | 37

Re: [libvirt] [Qemu-devel] QEMU -M nvdimm=on and hotplug

On Thu, 14 Sep 2017 13:51:45 +0200 Michal Privoznik wrote: > On 09/14/2017 02:33 AM, Haozhong Zhang wrote: > > On 09/13/17 17:28 +0200, Michal Privoznik wrote: > >> > >> BTW: I ran a migration from no nvdimm qemu to one that had -M nvdimm=on > >> and guest migrated

[libvirt] [PATCH v8 11/11] qemu: Add TLS support for Veritas HyperScale (VxHS)

From: Ashish Mittal Alter qemu command line generation in order to possibly add TLS for a suitably configured domain. Sample TLS args generated by libvirt - -object tls-creds-x509,id=objvirtio-disk0_tls0,dir=/etc/pki/qemu,\ endpoint=client,verify-peer=yes \

[libvirt] [PATCH v8 10/11] util: Add virstoragetest to parse/format a tls='yes'

From: Ashish Mittal Add a test case to verify TLS arguments are parsed correctly for a VxHS disk. This includes saving off a found tls-creds into the storage source @tlsAlias field since that's what's used to link the TLS object for the authentication credentials and

[libvirt] [PATCH v8 08/11] util: Add TLS attributes to virStorageSource

From: Ashish Mittal Add an optional virTristateBool haveTLS to virStorageSource to manage whether a storage source will be using TLS. Sample XML for a VxHS disk: Additionally add a tlsFromConfig boolean to control whether the TLS setting was due

[libvirt] [PATCH v8 07/11] conf: Introduce TLS options for VxHS block device clients

From: Ashish Mittal Add a new TLS X.509 certificate type - "vxhs". This will handle the creation of a TLS certificate capability for properly configured VxHS network block device clients. The following describes the behavior of TLS for VxHS block device: (1) Two

[libvirt] [PATCH v8 00/11] Add support for Veritas HyperScale (VxHS) block device protocol

v7: https://www.redhat.com/archives/libvir-list/2017-September/msg00035.html Patches 1-4 are already ACK'd, but are presented again for completeness Differences: * Former patch1 already pushed (QEMU 2.10 replies and xml changes) * Patch 5 is new - to split up the server args into a single

[libvirt] [PATCH v8 06/11] qemu: Add qemu command line generation for a VxHS block device

From: Ashish Mittal The VxHS block device will only use the newer formatting options and avoid the legacy URI syntax. An excerpt for a sample QEMU command line is: -drive file.driver=vxhs,file.vdisk-id=eb90327c-8302-4725-9e1b-4e85ed4dc251,\

[libvirt] [PATCH python] Skip sparseRecvAll / sparseSendAll in sanity test

The sanity test check aims to ensure that every function listed in the Python code maps to a corresponding C function. The Sparse send/recv methods are special though - we're never calling the corresponding C APIs, instead we have a pure python impl. Signed-off-by: Daniel P. Berrange

Re: [libvirt] [libvirt-python][PATCH] maint: Require libvirt-3.4.0 at least

On Thu, Sep 14, 2017 at 01:41:08PM +0200, Michal Privoznik wrote: > Currently, we require 0.9.11. However, some APIs are missing > there and thus sanity check fails: > > DEBUG: /usr/bin/python sanitytest.py build/lib.linux-s390x-2.7 > /usr/share/libvirt/api/libvirt-api.xml > DEBUG: FAIL

Re: [libvirt] QEMU -M nvdimm=on and hotplug

On 09/14/2017 02:33 AM, Haozhong Zhang wrote: > On 09/13/17 17:28 +0200, Michal Privoznik wrote: >> >> BTW: I ran a migration from no nvdimm qemu to one that had -M nvdimm=on >> and guest migrated happily. So looks like guest ABI is stable (or at >> least stable enough not to crash). But since

[libvirt] [libvirt-python][PATCH] maint: Require libvirt-3.4.0 at least

Currently, we require 0.9.11. However, some APIs are missing there and thus sanity check fails: DEBUG: /usr/bin/python sanitytest.py build/lib.linux-s390x-2.7 /usr/share/libvirt/api/libvirt-api.xml DEBUG: FAIL virStream.sparseRecvAll (Python API not mapped to C) DEBUG: FAIL

Re: [libvirt] Exposing mem-path in domain XML

On 09/06/2017 01:42 PM, Daniel P. Berrange wrote: > On Wed, Sep 06, 2017 at 01:35:45PM +0200, Michal Privoznik wrote: >> On 09/05/2017 04:07 PM, Daniel P. Berrange wrote: >>> On Tue, Sep 05, 2017 at 03:59:09PM +0200, Michal Privoznik wrote: On 07/28/2017 10:59 AM, Daniel P. Berrange wrote:

[libvirt] [PATCH libvirt-glib 0/3] Doc updates

Hi, here are some doc updates I found on a long unused branch but they still apply. Cheers, -- Guido Guido Günther (3): Add some missing docs streams: fix references gvir_stream_send: make it obvious that we send bytes libvirt-gobject/libvirt-gobject-connection.c | 15 ++-

[libvirt] [PATCH libvirt-glib 1/3] Add some missing docs

--- libvirt-gobject/libvirt-gobject-connection.c | 15 ++- libvirt-gobject/libvirt-gobject-domain.c | 2 +- libvirt-gobject/libvirt-gobject-stream.c | 10 ++ 3 files changed, 25 insertions(+), 2 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-connection.c

[libvirt] [PATCH libvirt-glib 3/3] gvir_stream_send: make it obvious that we send bytes

Fix doc and use a proper variable name --- libvirt-gobject/libvirt-gobject-stream.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-stream.c b/libvirt-gobject/libvirt-gobject-stream.c index 296c00e..93788b5 100644 ---

[libvirt] [PATCH libvirt-glib 2/3] streams: fix references

--- libvirt-gobject/libvirt-gobject-stream.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-stream.c b/libvirt-gobject/libvirt-gobject-stream.c index b6bf774..296c00e 100644 --- a/libvirt-gobject/libvirt-gobject-stream.c +++

Re: [libvirt] [PATCH v4 1/2] conf, docs: Add qcow2 cache configuration support

On Thu, Sep 14, 2017 at 12:56:30PM +0200, Peter Krempa wrote: > On Thu, Sep 14, 2017 at 16:37:03 +0800, Liu Qing wrote: > > On Thu, Sep 14, 2017 at 10:02:40AM +0200, Peter Krempa wrote: > > > On Thu, Sep 14, 2017 at 09:29:28 +0200, Peter Krempa wrote: > > [...] > > > > One more thing. The design

[libvirt] [PATCH 0/7] qemu: Filter CPU features returned by qemuConnectBaselineCPU

The host CPU definitions reported in the capabilities XML may contain CPU features unknown to QEMU, but the result of virConnectBaselineCPU is supposed to be directly usable as a guest CPU definition and thus it should only contain features QEMU knows about.

[libvirt] [PATCH 1/7] cpu_conf: Introduce virCPUDefList{Parse, Free}

For parsing a list of CPU XMLs into a NULL-terminated list of CPU defs. Signed-off-by: Jiri Denemark --- src/conf/cpu_conf.c | 78 src/conf/cpu_conf.h | 7 + src/libvirt_private.syms | 2 ++ 3 files changed,

[libvirt] [PATCH 2/7] cpu: Use virCPUDefListParse in cpuBaselineXML

Signed-off-by: Jiri Denemark --- src/cpu/cpu.c | 52 ++-- 1 file changed, 6 insertions(+), 46 deletions(-) diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index 96160901e1..bf3c6d53dd 100644 --- a/src/cpu/cpu.c +++ b/src/cpu/cpu.c

Re: [libvirt] [PATCH v7 06.5/11] merge with previous...

On 09/14/2017 04:13 AM, Peter Krempa wrote: > On Tue, Sep 12, 2017 at 14:39:58 -0400, John Ferlan wrote: >> This patch would be merged with the existing 06/11 patch for the >> following changes: >> >>1. Use qemuBlockStorageSourceBuildJSONSocketAddress to build a single >> server

Re: [libvirt] [PATCH v7 06.5/11] merge with previous...

On Thu, Sep 14, 2017 at 06:53:10 -0400, John Ferlan wrote: > On 09/14/2017 04:13 AM, Peter Krempa wrote: > > On Tue, Sep 12, 2017 at 14:39:58 -0400, John Ferlan wrote: [...] > > With all the squash-ins and .5 patches this got messy. Please repost. > > > > Sure, not problem. Any issue w/ me

[libvirt] [PATCH 5/7] qemu: Pass virArch * to virQEMUCapsCPUFilterFeatures

The filter only needs to know the CPU architecture. Passing virQEMUCapsPtr as opaque is a bit overkill. Signed-off-by: Jiri Denemark --- src/qemu/qemu_capabilities.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_capabilities.c

Re: [libvirt] [PATCH v4 1/2] conf, docs: Add qcow2 cache configuration support

On Thu, Sep 14, 2017 at 16:37:03 +0800, Liu Qing wrote: > On Thu, Sep 14, 2017 at 10:02:40AM +0200, Peter Krempa wrote: > > On Thu, Sep 14, 2017 at 09:29:28 +0200, Peter Krempa wrote: [...] > > One more thing. The design you've proposed is really not user friendly. > > The user has to read a

Re: [libvirt] [PATCH v7 01/11] qemu: Add QEMU 2.10 x86_64 the generated capabilities

On Fri, Sep 01, 2017 at 01:09:45PM -0400, John Ferlan wrote: > For reference, these were generated by updating a local qemu git > repository to the latest upstream, making sure the latest dependencies > were met via "dnf builddep qemu" from my sufficiently privileged root > account, checking out

[libvirt] [PATCH 7/7] qemu: Filter CPU features returned by qemuConnectBaselineCPU

The host CPU definitions reported in the capabilities XML may contain CPU features unknown to QEMU, but the result of virConnectBaselineCPU is supposed to be directly usable as a guest CPU definition and thus it should only contain features QEMU knows about.

[libvirt] [PATCH 4/7] cpu: Drop cpuBaselineXML

The implementation of virConnectBaselineCPU may be different for each hypervisor. Thus it shouldn't really be implmented in the cpu code. Signed-off-by: Jiri Denemark --- src/bhyve/bhyve_driver.c | 22 +++--- src/cpu/cpu.c| 58

[libvirt] [PATCH 6/7] qemu: Publish virQEMUCapsCPUFilterFeatures

Signed-off-by: Jiri Denemark --- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_capabilities.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 52d63f44ec..7bc88be0f5 100644 ---

[libvirt] [PATCH 3/7] cpu: Don't log CPU models in cpuBaselineXML

They are logged in cpuBaseline anyway. Signed-off-by: Jiri Denemark --- src/cpu/cpu.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index bf3c6d53dd..e75f406040 100644 --- a/src/cpu/cpu.c +++ b/src/cpu/cpu.c @@ -526,18 +526,12 @@

Re: [libvirt] [PATCH v4 1/2] conf, docs: Add qcow2 cache configuration support

On Thu, Sep 14, 2017 at 10:02:40AM +0200, Peter Krempa wrote: > On Thu, Sep 14, 2017 at 09:29:28 +0200, Peter Krempa wrote: > > On Thu, Sep 14, 2017 at 13:02:46 +0800, Liu Qing wrote: > > > On Wed, Sep 13, 2017 at 01:20:03PM +0200, Peter Krempa wrote: > > > > On Wed, Sep 13, 2017 at 17:21:23

Re: [libvirt] [PATCH v7 06.5/11] merge with previous...

On Tue, Sep 12, 2017 at 14:39:58 -0400, John Ferlan wrote: > This patch would be merged with the existing 06/11 patch for the > following changes: > >1. Use qemuBlockStorageSourceBuildJSONSocketAddress to build a single > server address >2. Alter the output file to remove the server

Re: [libvirt] [PATCH v4 1/2] conf, docs: Add qcow2 cache configuration support

On Thu, Sep 14, 2017 at 09:29:28AM +0200, Peter Krempa wrote: > On Thu, Sep 14, 2017 at 13:02:46 +0800, Liu Qing wrote: > > On Wed, Sep 13, 2017 at 01:20:03PM +0200, Peter Krempa wrote: > > > On Wed, Sep 13, 2017 at 17:21:23 +0800, Liu Qing wrote: > > [...] > > > > [1] There's discussion I can

Re: [libvirt] [PATCH v4 1/2] conf, docs: Add qcow2 cache configuration support

On Thu, Sep 14, 2017 at 09:29:28 +0200, Peter Krempa wrote: > On Thu, Sep 14, 2017 at 13:02:46 +0800, Liu Qing wrote: > > On Wed, Sep 13, 2017 at 01:20:03PM +0200, Peter Krempa wrote: > > > On Wed, Sep 13, 2017 at 17:21:23 +0800, Liu Qing wrote: > > [...] > > > > [1] There's discussion I can

Re: [libvirt] [PATCH 5/5] qemu: Implement usernet address

On 09/13/2017 06:02 PM, Laine Stump wrote: > On 09/13/2017 06:46 AM, Michal Privoznik wrote: >> On 09/12/2017 09:16 PM, Laine Stump wrote: >>> On 09/12/2017 05:32 AM, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1075520 +/* QEMU needs some

Re: [libvirt] [PATCH v4 1/2] conf, docs: Add qcow2 cache configuration support

On Thu, Sep 14, 2017 at 13:02:46 +0800, Liu Qing wrote: > On Wed, Sep 13, 2017 at 01:20:03PM +0200, Peter Krempa wrote: > > On Wed, Sep 13, 2017 at 17:21:23 +0800, Liu Qing wrote: [...] > > [1] There's discussion I can link to for other tuning parameters. The > > gist is that allowing users to