[libvirt] [PATCH v6 2/2] qemu: add capability checking for qcow2 cache configuration

Add qemu capabilities QEMU_CAPS_L2_CACHE_SIZE, QEMU_CAPS_REFCOUNT_CACHE_SIZE, QEMU_CAPS_CACHE_CLEAN_INTERVAL. Add testing for the above qemu capabilities. Signed-off-by: Liu Qing --- src/qemu/qemu_capabilities.c | 11

[libvirt] [PATCH v6 0/2] Add support for qcow2 cache

Qcow2 small IO random write performance will drop dramatically if the l2 cache table could not cover the whole disk. This will be a lot of l2 cache table RW operations if cache miss happens frequently. This patch exports the qcow2 driver parameter l2-cache-size/refcount-cache-size, first added

[libvirt] [PATCH v6 1/2] conf, docs: Add qcow2 cache configuration support

Random write IOPS will drop dramatically if qcow2 l2 cache could not cover the whole disk. This patch gives libvirt user a chance to adjust the qcow2 cache configuration. Three new qcow2 driver parameters (l2-cache-size, refcount-cache-size and cache-clean-interval) are added as attributes to a

Re: [libvirt] [PATCH v5 1/2] conf, docs: Add qcow2 cache configuration support

On Mon, Sep 18, 2017 at 09:49:36AM -0400, John Ferlan wrote: > > > On 09/14/2017 01:08 AM, Liu Qing wrote: > > Random write IOPS will drop dramatically if qcow2 l2 cache could not > > cover the whole disk. This patch gives libvirt user a chance to adjust > > the qcow2 cache configuration. > > >

[libvirt] Questions about function virPCIDeviceIsBehindSwitchLackingACS in virpci.c

Hi, In function virPCIDeviceIsBehindSwitchLackingACS, I noticed that(line 8): 1if (virPCIDeviceGetParent(dev, ) < 0) 2return -1; 3if (!parent) { 4/* if we have no parent, and this is the root bus, ACS doesn't come 5 * into play since devices on the root bus can't

Re: [libvirt] [PATCH 1/2] logical: implement volume resize

On 09/07/2017 08:56 AM, apolya...@beget.ru wrote: > From: Alexander Polyakov > > Add new virStorageBackendLogicalResizeVol function to > implement resize of logical volumes > > Sparse volumes are not supported > > Signed-off-by: Alexander Polyakov >

Re: [libvirt] [PATCH 2/2] news: Document lvm volume resize

On 09/07/2017 08:56 AM, apolya...@beget.ru wrote: > From: Alexander Polyakov > > Signed-off-by: Alexander Polyakov > --- > docs/news.xml | 8 > 1 file changed, 8 insertions(+) > > diff --git a/docs/news.xml b/docs/news.xml > index

Re: [libvirt] [PATCH] qemu: Introduce a wrapper over virFileWrapperFdClose

On 09/18/2017 05:08 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1448268 > > When migrating to a file (e.g. when doing 'virsh save file'), > couple of things are happening in the thread that is executing > the API: > > 1) the domain obj is locked > 2) iohelper is

Re: [libvirt] [PATCH v7 11/11] qemu: Add TLS support for Veritas HyperScale (VxHS)

Hi, I've done some TLS testing with this patch and results look good. The following test statically adds a VxHS disk to a guest in the TLS mode. Boots up the guest and makes sure that we can do read/writes to the VxHS disk from within the guest with TLS enabled. (1) Create a backing store file

[libvirt] [PATCH] apparmor: support finer-grained ptrace checks

Kernel 4.13 introduced finer-grained ptrace checks https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?h=v4.13.2=290f458a4f16f9cf6cb6562b249e69fe1c3c3a07 When Apparmor is enabled and libvirtd is confined, attempting to start a domain fails virsh start test error:

[libvirt] [PATCH] apparmor: delete profile on VM shutdown

instead of only unloading it. This makes sure old profiles don't pile up in /etc/apparmor.d/libvirt and we get updates to modified templates on VM restart. --- src/security/security_apparmor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/security_apparmor.c

Re: [libvirt] [PATCH 1/2] qemu: blockPeek: Fix filling of the return buffer

On 09/18/2017 09:11 AM, Peter Krempa wrote: > Commit 3956af495e broke the blockPeek API since virStorageFileRead > allocates a return buffer and fills it with the data, while the API > fills a user-provided buffer. This did not get caught by the compiler > since the API prototype uses a 'void *'.

Re: [libvirt] [PATCH] apparmor: cater for new AAVMF image location

Hi, On Mon, Sep 18, 2017 at 02:05:41PM +0200, Michal Privoznik wrote: > On 09/15/2017 06:10 PM, Guido Günther wrote: > > Things moved again, sigh. > > --- > > src/security/virt-aa-helper.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git

Re: [libvirt] [PATCH] apparmor: add attach_disconnected

Hi, On Mon, Sep 18, 2017 at 02:05:30PM +0200, Michal Privoznik wrote: > On 09/15/2017 05:17 PM, Guido Günther wrote: > > Otherwise we fail to reconnect to /dev/net/tun opened by libvirtd > > like > > > > [ 8144.507756] audit: type=1400 audit(1505488162.386:38069121): > > apparmor="DENIED"

[libvirt] [PATCH] util: Fix configure.ac check for DEVLINK_CMD_ESWITCH_GET

Rather than checking for whether the devlink.h on the system has multiple symbols, let's only check for whether the command we want is defined. Turns out the mechanism of providing multiple definitions to check via AC_CHECK_DECLS in order to determine whether HAVE_DECL_DEVLINK should be set

[libvirt] [PATCH] cpu_ppc64: Error out when model tag missing in virsh cpu-compare xml

libvirtd throws unhandled signal 11 on ppc while running virsh cpu-compare with missing model tag in the xml. This patch errors out in such situation. Signed-off-by: Nitesh Konkar --- src/cpu/cpu_ppc64.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[libvirt] [PATCH v4 2/7] nodedev: udev: Lock the driver in udevEventCheckMonitorFd

The udev monitor is not an immutable resource, so better protect every access to it. Signed-off-by: Erik Skultety --- src/node_device/node_device_udev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/node_device/node_device_udev.c

[libvirt] [PATCH v4 7/7] nodedev: Work around the uevent race by hooking up virFileWaitForAccess

If we find ourselves in the situation that the 'add' uevent has been fired earlier than the sysfs tree for a device was created, we should use the best-effort approach and give kernel some predetermined amount of time, thus waiting for the attributes to be ready rather than discarding the device

[libvirt] [PATCH v4 5/7] nodedev: Disable/re-enable polling on the udev fd

The event loop may get scheduled earlier than the udev event handler thread which means that it would keep invoking the handler callback with "new" events, while in fact it's most likely still the same event which the handler thread hasn't managed to remove from the socket queue yet. This is due

[libvirt] [PATCH v4 3/7] udev: Split udevEventHandleCallback in two functions

This patch splits udevEventHandleCallback in two (introduces udevEventHandleThread) in order to be later able to refactor the latter to actually become a detached thread which will wait some time for the kernel to create the whole sysfs tree for a device as we cannot do that in the event loop

[libvirt] [PATCH v4 1/7] nodedev: Introduce udevEventCheckMonitorFD helper function

We need to perform some sanity checks on the udev monitor before every use so that we know nothing changed in the meantime. The reason for moving the code to a separate function is to be able to perform the same check from a worker thread that will replace the udevEventHandleCallback in terms of

[libvirt] [PATCH v4 6/7] util: Introduce virFileWaitForExists

Since we have a number of places where we workaround timing issues with devices, attributes (files in general) not being available at the time of processing them by calling usleep in a loop for a fixed number of tries, we could as well have a utility function that would do that. Therefore we won't

[libvirt] [PATCH v4 4/7] udev: Convert udevEventHandleThread to an actual thread routine

Adjust udevEventHandleThread to be a proper thread routine running in an infinite loop handling devices. Also introduce udevEventThreadData private structure. Every time there's and incoming event from udev, udevEventHandleCallback only increments the number of events queuing on the monitor and

[libvirt] [PATCH v4 0/7] Work around the kernel mdev uevent race in nodedev

v3 here: https://www.redhat.com/archives/libvir-list/2017-August/msg00703.html since v3: - some minor cosmetic changes related to comments from the original patches 1-2 - everything else (provided it didn't cause merge conflicts) is unchanged Erik Skultety (7): nodedev: Introduce

Re: [libvirt] [PATCHv2] nodedev: add switchdev to NIC capabilities

On 09/18/2017 10:57 AM, Ján Tomko wrote: > On Thu, Sep 14, 2017 at 11:23:02AM -0400, Laine Stump wrote: >> (Almost all of my comments result in "ok, no action needed". There are >> just three items I would like to see changed (2 trivial, 1 also small >> but Edan or John may think it prudent to

Re: [libvirt] [PATCH] check-spacing: Don't hardcode Perl interpreter path

On Mon, Sep 18, 2017 at 02:39:39PM +0200, Andrea Bolognani wrote: This is particularly useful on operating systems that don't ship Perl as part of the base system (eg. FreeBSD) while still working just as well as it did before on Linux. Signed-off-by: Andrea Bolognani ---

Re: [libvirt] [PATCH v5 1/2] conf, docs: Add qcow2 cache configuration support

On Mon, Sep 18, 2017 at 09:49:36 -0400, John Ferlan wrote: > > > On 09/14/2017 01:08 AM, Liu Qing wrote: > > Random write IOPS will drop dramatically if qcow2 l2 cache could not > > cover the whole disk. This patch gives libvirt user a chance to adjust > > the qcow2 cache configuration. > > > >

Re: [libvirt] [PATCHv2] nodedev: add switchdev to NIC capabilities

On Thu, Sep 14, 2017 at 11:23:02AM -0400, Laine Stump wrote: (Almost all of my comments result in "ok, no action needed". There are just three items I would like to see changed (2 trivial, 1 also small but Edan or John may think it prudent to re-test with the change before pushing) - I marked

Re: [libvirt] [PATCH] qemu: Mark graphics ports used on reconnect

On 09/18/2017 04:10 PM, Cole Robinson wrote: > On 09/18/2017 09:47 AM, Michal Privoznik wrote: >> This is an issue that's bugging me for a long time. I don't know >> exactly when and who is to blame but on daemon reconnect we lose >> qemu's port allocator internal state. > > It's the kernel's

[libvirt] [PATCH 0/2] qemu: blockPeek: Fix invalid buffer usage and

See 1/2 for the bugfix. Peter Krempa (2): qemu: blockPeek: Fix filling of the return buffer qemu: blockPeek: Enforce buffer filling src/qemu/qemu_driver.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) -- 2.14.1 -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH v5 1/2] conf, docs: Add qcow2 cache configuration support

On 09/14/2017 01:08 AM, Liu Qing wrote: > Random write IOPS will drop dramatically if qcow2 l2 cache could not > cover the whole disk. This patch gives libvirt user a chance to adjust > the qcow2 cache configuration. > > Three new qcow2 driver parameters (l2-cache-size, refcount-cache-size >

Re: [libvirt] [PATCH v2 0/3] Be more selective when determining cdrom for taint messaging

On 09/18/2017 09:12 AM, Michal Privoznik wrote: > On 09/11/2017 04:32 PM, John Ferlan wrote: >> v1: https://www.redhat.com/archives/libvir-list/2017-September/msg00103.html >> >> Changes since v1: >> >> Split into 3 parts... The first patch would be the bare minimum using >> STRPREFIX instead

[libvirt] [PATCH 1/2] qemu: blockPeek: Fix filling of the return buffer

Commit 3956af495e broke the blockPeek API since virStorageFileRead allocates a return buffer and fills it with the data, while the API fills a user-provided buffer. This did not get caught by the compiler since the API prototype uses a 'void *'. Fix it by transferring the data from the allocated

[libvirt] [PATCH 2/2] qemu: blockPeek: Enforce buffer filling

Documentation states: "'offset' and 'size' represent an area which must lie entirely within the device or file." Enforce the that the buffer lies within fully. --- src/qemu/qemu_driver.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c

Re: [libvirt] [PATCH] qemu: Mark graphics ports used on reconnect

On 09/18/2017 09:47 AM, Michal Privoznik wrote: > This is an issue that's bugging me for a long time. I don't know > exactly when and who is to blame but on daemon reconnect we lose > qemu's port allocator internal state. It's the kernel's fault, broken in 4.11+, patches recently posted upstream

Re: [libvirt] [Qemu-devel] libvirt/QEMU/SEV interaction

On Mon, Sep 18, 2017 at 07:41:09AM -0500, Richard Relph wrote: > > > On 9/18/17 4:47 AM, Daniel P. Berrange wrote: > > On Mon, Sep 18, 2017 at 11:43:57AM +0200, Erik Skultety wrote: > > > [...] > > > > > > > > > c) what existing communicate interface can be used between > > > > > libvirt and

[libvirt] [PATCH 3/6] cpu_conf: Simplify formatting of guest CPU attributes

Signed-off-by: Jiri Denemark --- src/conf/cpu_conf.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index 6058d26fa5..02506c020b 100644 --- a/src/conf/cpu_conf.c +++ b/src/conf/cpu_conf.c

[libvirt] [PATCH 4/6] conf: Drop unused VIR_DOMAIN_DEF_FORMAT_UPDATE_CPU

The only real usage of this flag was removed by "cpu_conf: Drop updateCPU from virCPUDefFormat". Signed-off-by: Jiri Denemark --- src/conf/domain_conf.c | 3 --- src/conf/domain_conf.h | 1 - src/conf/snapshot_conf.c | 3 +-- 3 files changed, 1 insertion(+), 6

[libvirt] [PATCH 0/6] Fix guest CPU updates for inactive domains

This series originally started as a cleanup work, but it turned out two real bugs got fixed with this cleanup :-) Since commit v2.2.0-199-g7ce711a30e libvirt stores an updated guest CPU in domain's live definition and there's no need to update it every time we want to format the definition. Thus

[libvirt] [PATCH 2/6] cpu_conf: Drop updateCPU from virCPUDefFormat

In the past we updated host-model CPUs with host CPU data by adding a model and features, but keeping the host-model mode. And since the CPU model is not normally formatted for host-model CPU defs, we had to pass the updateCPU flag to the formatting code to be able to properly output updated

Re: [libvirt] [PATCH v3 0/6] Work around the kernel mdev uevent race in nodedev

On Mon, Sep 18, 2017 at 08:47:52AM -0400, John Ferlan wrote: > > > On 09/18/2017 01:53 AM, Erik Skultety wrote: > > On Thu, Aug 24, 2017 at 01:23:26PM +0200, Erik Skultety wrote: > >> v2 here: > >> https://www.redhat.com/archives/libvir-list/2017-July/msg01268.html > >> > >> Since v2: > >> -

[libvirt] [PATCH 5/6] qemu: Use correct host model for updating guest cpu

when a user requested a domain xml description with vir_domain_xml_update_cpu flag, libvirt would use the host cpu definition from host capabilities rather than the one which will actually be used once the domain is started. https://bugzilla.redhat.com/show_bug.cgi?id=1481309 Signed-off-by: Jiri

[libvirt] [PATCH] qemu: Mark graphics ports used on reconnect

This is an issue that's bugging me for a long time. I don't know exactly when and who is to blame but on daemon reconnect we lose qemu's port allocator internal state. That's okay as we should be able to rebuild it later. However, now I'm seeing port allocator biding successfully to ports that are

[libvirt] [PATCH 6/6] qemu: Don't update CPU when formatting live def

Since commit v2.2.0-199-g7ce711a30e libvirt stores an updated guest CPU in domain's live definition and there's no need to update it every time we want to format the definition. The commit itself tried to address this in qemuDomainFormatXML, but forgot to fix qemuDomainDefFormatLive. Not to

[libvirt] [PATCH 1/6] qemuxml2xmltest: Add tests for Power CPUs

Signed-off-by: Jiri Denemark --- .../qemuxml2xmlout-pseries-cpu-compat-power9.xml | 38 + .../qemuxml2xmlout-pseries-cpu-compat.xml | 38 + .../qemuxml2xmlout-pseries-cpu-exact.xml | 39 ++

Re: [libvirt] [PATCH 0/5] Reject parallel ports on s390, and pseries

On 09/07/2017 02:19 PM, Pino Toscano wrote: > Hi, > > this is a simple series to reject parallel ports on s390 architectures, > and pseries machines -- both simply do not support them. This fixes > https://bugzilla.redhat.com/show_bug.cgi?id=1487499 > > Pino Toscano (5): > tests:

Re: [libvirt] [PATCHv2] nodedev: add switchdev to NIC capabilities

On 09/17/2017 05:32 AM, Edan David wrote: > I removed the memset from virNetDevPutExtraHeader and tested on a card > supporting switchdev. > It looks fine to me :) > Great review guys, thanks! > Thanks for checking... This is now pushed. Congrats on your first libvirt patch, John > >

Re: [libvirt] [Qemu-devel] libvirt/QEMU/SEV interaction

On 9/18/17 4:47 AM, Daniel P. Berrange wrote: On Mon, Sep 18, 2017 at 11:43:57AM +0200, Erik Skultety wrote: [...] > c) what existing communicate interface can be used between libvirt and qemu > to get the measurement ? can we add a new qemu monitor command >

[libvirt] [PATCH] check-spacing: Don't hardcode Perl interpreter path

This is particularly useful on operating systems that don't ship Perl as part of the base system (eg. FreeBSD) while still working just as well as it did before on Linux. Signed-off-by: Andrea Bolognani --- build-aux/check-spacing.pl | 2 +- 1 file changed, 1 insertion(+),

Re: [libvirt] [PATCH v2 0/3] Be more selective when determining cdrom for taint messaging

On 09/11/2017 04:32 PM, John Ferlan wrote: > v1: https://www.redhat.com/archives/libvir-list/2017-September/msg00103.html > > Changes since v1: > > Split into 3 parts... The first patch would be the bare minimum using > STRPREFIX instead of STREQ type comparisons for the incoming path to > be

Re: [libvirt] [PATCH v3 0/6] Work around the kernel mdev uevent race in nodedev

On 09/18/2017 01:53 AM, Erik Skultety wrote: > On Thu, Aug 24, 2017 at 01:23:26PM +0200, Erik Skultety wrote: >> v2 here: https://www.redhat.com/archives/libvir-list/2017-July/msg01268.html >> >> Since v2: >> - added patch 4/6 that fixes the issue with the handler thread spamming logs >> with

Re: [libvirt] [PATCH] virsh: man: Describe the 'create' command a bit more

On 09/08/2017 02:52 PM, Erik Skultety wrote: > So we refer to the terms 'persistent' and 'transient' across the whole > man page, without describing it further, but more importantly, how the > create command affects it, i.e. explicitly stating that domain created > via the 'create' command are

[libvirt] Questions about function virPCIDeviceIsBehindSwitchLackingACS in virpci.c

In function virPCIDeviceIsBehindSwitchLackingACS, I noticed that(line 8): 1if (virPCIDeviceGetParent(dev, ) < 0) 2return -1; 3if (!parent) { 4/* if we have no parent, and this is the root bus, ACS doesn't come 5 * into play since devices on the root bus can't P2P

Re: [libvirt] [PATCH go-xml] Add support for domain hostdev and test code

On Fri, Sep 15, 2017 at 02:12:44PM +0800, zhenwei.pi wrote: > Signed-off-by: zhenwei.pi > --- > domain.go | 36 > domain_test.go | 44 > 2 files changed, 80 insertions(+) > > diff

Re: [libvirt] [PATCH] apparmor: add attach_disconnected

On 09/15/2017 05:17 PM, Guido Günther wrote: > Otherwise we fail to reconnect to /dev/net/tun opened by libvirtd > like > > [ 8144.507756] audit: type=1400 audit(1505488162.386:38069121): > apparmor="DENIED" operation="file_perm" info="Failed name lookup - > disconnected path" error=-13 >

Re: [libvirt] [PATCH] apparmor: cater for new AAVMF image location

On 09/15/2017 06:10 PM, Guido Günther wrote: > Things moved again, sigh. > --- > src/security/virt-aa-helper.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c > index 55a686a59c..0b43c8e391 100644 > ---

Re: [libvirt] [PATCH python] Skip sparseRecvAll / sparseSendAll in sanity test

On 09/18/2017 11:49 AM, Daniel P. Berrange wrote: > On Mon, Sep 18, 2017 at 11:47:24AM +0200, Michal Privoznik wrote: >> On 09/14/2017 02:50 PM, Daniel P. Berrange wrote: >>> The sanity test check aims to ensure that every function listed in >>> the Python code maps to a corresponding C function.

Re: [libvirt] [PATCH 0/3] cpu: Add new Skylake-Server CPU model

On Wed, Sep 13, 2017 at 02:00:43PM +0200, Jiri Denemark wrote: > Jiri Denemark (3): > tests: Add CPUID data for Intel(R) Xeon(R) Gold 6148 CPU > cpu: Add clwb/pcommit CPU features > cpu: Add new Skylake-Server CPU model Reviewed-by: Pavel Hrdina signature.asc

Re: [libvirt] [PATCH python] Skip sparseRecvAll / sparseSendAll in sanity test

On Mon, Sep 18, 2017 at 11:47:24AM +0200, Michal Privoznik wrote: > On 09/14/2017 02:50 PM, Daniel P. Berrange wrote: > > The sanity test check aims to ensure that every function listed in > > the Python code maps to a corresponding C function. The Sparse > > send/recv methods are special though -

Re: [libvirt] RFC: libvirt support for QEMU live patching

On Mon, Sep 18, 2017 at 10:03:34AM +0100, Daniel P. Berrange wrote: On Mon, Sep 18, 2017 at 09:37:14AM +0200, Martin Kletzander wrote: On Fri, Sep 15, 2017 at 09:18:18AM +0100, Daniel P. Berrange wrote: > On Fri, Sep 15, 2017 at 01:27:31PM +0530, Madhu Pavan wrote: > > Hi, > > QEMU live

Re: [libvirt] [PATCH python] Skip sparseRecvAll / sparseSendAll in sanity test

On 09/14/2017 02:50 PM, Daniel P. Berrange wrote: > The sanity test check aims to ensure that every function listed in > the Python code maps to a corresponding C function. The Sparse > send/recv methods are special though - we're never calling the > corresponding C APIs, instead we have a pure

Re: [libvirt] [Qemu-devel] libvirt/QEMU/SEV interaction

On Mon, Sep 18, 2017 at 11:43:57AM +0200, Erik Skultety wrote: > [...] > > > > > > > > c) what existing communicate interface can be used between libvirt > > > and qemu > > > > to get the measurement ? can we add a new qemu monitor command > > > > 'get_sev_measurement' to get the

Re: [libvirt] [Qemu-devel] libvirt/QEMU/SEV interaction

[...] > > > > > c) what existing communicate interface can be used between libvirt > > and qemu > > > to get the measurement ? can we add a new qemu monitor command > > > 'get_sev_measurement' to get the measurement ? (step 10) > > > > Yes, QMP commands seeem most likely. > > > >

Re: [libvirt] [PATCH] apparmor: add attach_disconnected

Hi, Jamie Strandboge: > On Fri, 2017-09-15 at 17:17 +0200, Guido Günther wrote: >> Otherwise we fail to reconnect to /dev/net/tun opened by libvirtd >> like I confirm I see the bug on current Debian sid and Guido's patch fixes it. Please commit :) Cheers, -- intrigeri -- libvir-list mailing

Re: [libvirt] [PATCH] apparmor: cater for new AAVMF image location

Jamie Strandboge: > On Fri, 2017-09-15 at 18:10 +0200, Guido Günther wrote: >> Things moved again, sigh. >> --- >> src/security/virt-aa-helper.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c >> index

Re: [libvirt] RFC: libvirt support for QEMU live patching

On Mon, Sep 18, 2017 at 09:37:14AM +0200, Martin Kletzander wrote: > On Fri, Sep 15, 2017 at 09:18:18AM +0100, Daniel P. Berrange wrote: > > On Fri, Sep 15, 2017 at 01:27:31PM +0530, Madhu Pavan wrote: > > > Hi, > > > QEMU live patching should be just a matter of updating the QEMU RPM > > >

[libvirt] [PATCH] qemu: Introduce a wrapper over virFileWrapperFdClose

https://bugzilla.redhat.com/show_bug.cgi?id=1448268 When migrating to a file (e.g. when doing 'virsh save file'), couple of things are happening in the thread that is executing the API: 1) the domain obj is locked 2) iohelper is spawned as a separate process to handle all I/O 3) the thread waits

Re: [libvirt] RFC: libvirt support for QEMU live patching

On Mon, Sep 18, 2017 at 10:26:40AM +0200, Peter Krempa wrote: On Mon, Sep 18, 2017 at 09:37:14 +0200, Martin Kletzander wrote: On Fri, Sep 15, 2017 at 09:18:18AM +0100, Daniel P. Berrange wrote: > On Fri, Sep 15, 2017 at 01:27:31PM +0530, Madhu Pavan wrote: [...] > It isn't possible to make

Re: [libvirt] [PATCH 1/7] cpu_conf: Introduce virCPUDefList{Parse, Free}

On Fri, Sep 15, 2017 at 14:04:42 +0200, Ján Tomko wrote: > On Thu, Sep 14, 2017 at 12:57:14PM +0200, Jiri Denemark wrote: > >For parsing a list of CPU XMLs into a NULL-terminated list of CPU defs. > > > >Signed-off-by: Jiri Denemark > >--- > > src/conf/cpu_conf.c | 78 >

Re: [libvirt] RFC: libvirt support for QEMU live patching

On Mon, Sep 18, 2017 at 09:37:14 +0200, Martin Kletzander wrote: > On Fri, Sep 15, 2017 at 09:18:18AM +0100, Daniel P. Berrange wrote: > > On Fri, Sep 15, 2017 at 01:27:31PM +0530, Madhu Pavan wrote: [...] > > It isn't possible to make it work correctly in the general case, because > > both QEMU

Re: [libvirt] RFC: libvirt support for QEMU live patching

On Fri, Sep 15, 2017 at 09:18:18AM +0100, Daniel P. Berrange wrote: On Fri, Sep 15, 2017 at 01:27:31PM +0530, Madhu Pavan wrote: Hi, QEMU live patching should be just a matter of updating the QEMU RPM package and then live migrating the VMs to another QEMU instance on the same host (which would

Re: [libvirt] [PATCH] virsh: Enhance documentation of --rdma-pin-all option

On Fri, Sep 08, 2017 at 09:33:13PM +0200, Jiri Denemark wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1373783 > > Signed-off-by: Jiri Denemark > --- > tools/virsh.pod | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) Reviewed-by: Pavel Hrdina

Re: [libvirt] [PATCH v3 0/6] Work around the kernel mdev uevent race in nodedev

On Thu, Aug 24, 2017 at 01:23:26PM +0200, Erik Skultety wrote: > v2 here: https://www.redhat.com/archives/libvir-list/2017-July/msg01268.html > > Since v2: > - added patch 4/6 that fixes the issue with the handler thread spamming logs > with "udev_monitor_receive_device returned NULL" > -> the