Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

That patch essentially negates the point of the test, which is that getopt should be visible from unistd.h. I'd rather fix the problem than nuke the test. Could you explain what the Gnulib problem is here? I can't really see it in your email. A self-contained example would help. For what

[libvirt] [PATCH python] Unify whitespace around *_ALLOW_THREADS macros

Most of the code treats libvirt API calls as separate block, keeping one blank line before the LIBVIRT_BEGIN_ALLOW_THREAD, and one blank line after LIBVIRT_END_ALLOW_THREADS. Unify the whitespace so all calls wrapped with these macros are treated as a separate block. --- libvirt-override.c | 115

[libvirt] [PATCH 0/2] Clean up the nwfilter mess I created

Silly me - touching the nwfilter code... Turns out the reverted patch in 1/2 doesn't cover it as virNWFilterVarValueCreateSimple actually steals @addr, so freeing it on successful return ends up being a very bad thing as I found out with the nwfilter avocado-vt tests. So revert that and just go

[libvirt] [PATCH 1/2] Revert "nwfilter: Fix possible segfault on sometimes consumed variable"

This reverts commit 6209bb32e5b6d8c15d55422bb4716b3b31c1c7b2. This turns out to be the wrong adjustment Signed-off-by: John Ferlan --- src/conf/nwfilter_ipaddrmap.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/conf/nwfilter_ipaddrmap.c

[libvirt] [PATCH 2/2] nwfilter: Only free inetaddr on virNWFilterIPAddrMapAddIPAddr failure

Flag when virNWFilterIPAddrMapAddIPAddr to allow deletion - keep @inetaddr around to message after virNWFilterInstantiateFilterLate Signed-off-by: John Ferlan --- src/nwfilter/nwfilter_learnipaddr.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [libvirt] Plans for next release

On 09/28/2017 01:01 PM, Daniel Veillard wrote: > On Thu, Sep 28, 2017 at 03:15:10PM +0200, Peter Krempa wrote: >> On Thu, Sep 28, 2017 at 12:17:41 +0200, Daniel Veillard wrote: >>> I'm a bit late, again ... >>> >>> I think we should enter freeze late today, then I can make an rc2 this week >>>

[libvirt] [PATCH] Fix vxhs test to have stable certificate dir

The test suite has hardcoded /etc/pki/qemu as the cert dir, but this only works if configure has --sysconfdir=/etc passed. We must set the vxhs cert dir to a stable path in the test suite. Signed-off-by: Daniel P. Berrange --- Pushed as a build fix

Re: [libvirt] Plans for next release

On Thu, Sep 28, 2017 at 03:15:10PM +0200, Peter Krempa wrote: > On Thu, Sep 28, 2017 at 12:17:41 +0200, Daniel Veillard wrote: > > I'm a bit late, again ... > > > > I think we should enter freeze late today, then I can make an rc2 this week > > end and shoot for a release on the 3rd > > > > I

Re: [libvirt] [PATCH v10 0/5] Add support for Veritas HyperScale (VxHS) block device protocol

> > The series is now pushed without any adjustment from the patch3 followup > (Peter and I hashed it out over the much faster internal IRC channel - > mail list delivery is still brutally slow/behind). > > Tks - > > John > > Thank you, John! Couldn't have done it without your help! And thanks to

Re: [libvirt] [PATCH] docs, rng: Allow a pool name to be line domain name

On Thu, Sep 28, 2017 at 10:03:55 -0400, John Ferlan wrote: > > > On 09/28/2017 09:47 AM, Peter Krempa wrote: > > On Wed, Sep 27, 2017 at 15:07:35 -0400, John Ferlan wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=1475250 > >> > >> It's possible to define and start a pool with a '.' in

Re: [libvirt] [PATCH v10 0/5] Add support for Veritas HyperScale (VxHS) block device protocol

On 09/27/2017 11:45 AM, John Ferlan wrote: > v9: https://www.redhat.com/archives/libvir-list/2017-September/msg00641.html > > Differences to v9: > > * Patch 1: > - Clean up the wording from code review > > * Patch 2: (NEW) > - Split out the formatting change for source/prototcol > > *

Re: [libvirt] [PATCH v10 5/5] qemu: Add TLS support for Veritas HyperScale (VxHS)

On Wed, Sep 27, 2017 at 11:45:55 -0400, John Ferlan wrote: > From: Ashish Mittal > > Alter qemu command line generation in order to possibly add TLS for > a suitably configured domain. > > Sample TLS args generated by libvirt - > > -object

Re: [libvirt] [PATCH] docs, rng: Allow a pool name to be line domain name

On 09/28/2017 09:47 AM, Peter Krempa wrote: > On Wed, Sep 27, 2017 at 15:07:35 -0400, John Ferlan wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1475250 >> >> It's possible to define and start a pool with a '.' in the >> name; however, when trying to add a volume to a domain using >> the

Re: [libvirt] [PATCH v10 3/5] util: Add TLS attributes to virStorageSource

On 09/28/2017 09:25 AM, Peter Krempa wrote: > On Wed, Sep 27, 2017 at 11:45:53 -0400, John Ferlan wrote: >> From: Ashish Mittal >> >> Add an optional virTristateBool haveTLS to virStorageSource to >> manage whether a storage source will be using TLS. >> >> Sample XML

Re: [libvirt] [PATCH v10 4/5] qemu: Introduce qemuDomainPrepareDiskSource

On Wed, Sep 27, 2017 at 11:45:54 -0400, John Ferlan wrote: > Introduce a function to setup any TLS needs for a disk source. > > If there's a configuration or other error setting up the disk source > for TLS, then cause the domain startup to fail. > > For VxHS, follow the chardevTLS model where

Re: [libvirt] [PATCH v10 2/5] docs: Clean up the description for network disk protocol options

On Wed, Sep 27, 2017 at 11:45:52 -0400, John Ferlan wrote: > Clean up the description a bit to make it more readable and not > appear as one long run-on paragraph. > > Signed-off-by: John Ferlan > --- > docs/formatdomain.html.in | 25 + > 1 file

Re: [libvirt] [PATCH] docs, rng: Allow a pool name to be line domain name

On Wed, Sep 27, 2017 at 15:07:35 -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1475250 > > It's possible to define and start a pool with a '.' in the > name; however, when trying to add a volume to a domain using > the storage pool source with a name with a '.' in the

Re: [libvirt] Plans for next release

On Thu, Sep 28, 2017 at 12:17:41 +0200, Daniel Veillard wrote: > I'm a bit late, again ... > > I think we should enter freeze late today, then I can make an rc2 this week > end and shoot for a release on the 3rd > > I hope there is no issue with this, Please wait until John pushes the

Re: [libvirt] [PATCH v10 1/5] conf: Introduce TLS options for VxHS block device clients

On Wed, Sep 27, 2017 at 11:45:51 -0400, John Ferlan wrote: > From: Ashish Mittal > > Add a new TLS X.509 certificate type - "vxhs". This will handle the > creation of a TLS certificate capability for properly configured > VxHS network block device clients. > > The

Re: [libvirt] [PATCH v10 3/5] util: Add TLS attributes to virStorageSource

On Wed, Sep 27, 2017 at 11:45:53 -0400, John Ferlan wrote: > From: Ashish Mittal > > Add an optional virTristateBool haveTLS to virStorageSource to > manage whether a storage source will be using TLS. > > Sample XML for a VxHS disk: > > > >tls='yes'> > >

Re: [libvirt] [Qemu-devel] [PATCH 1/2] vl: Eliminate defconfig variable

(CCing libvir-list) On Thu, Sep 28, 2017 at 12:42:02PM +0100, Daniel P. Berrange wrote: > On Wed, Sep 27, 2017 at 05:32:24PM -0300, Eduardo Habkost wrote: > > Both -nodefconfig and -no-user-config options do the same thing > > today, we only need one variable to keep track of them. > > What

Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

On Wed, Sep 27, 2017 at 11:36:20PM +0200, Christian Ehrhardt wrote: > Hi, > there seems to be an incompatibility to the last glibc due to [1]. > > Eventually this breaks gnulib unittests (and maybe more). [snip] We should have detected this a while ago sinc Fedora rawhide has 2.26, in fact it

Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

On Thu, Sep 28, 2017 at 2:05 PM, Christian Ehrhardt < christian.ehrha...@canonical.com> wrote: > > > On Thu, Sep 28, 2017 at 12:25 AM, Eric Blake wrote: > >> [adding gnulib] >> > > [...] > >> > then libvirt needs to pick up the >> updated gnulib. > > > I copied in current

Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

On Thu, Sep 28, 2017 at 12:25 AM, Eric Blake wrote: > [adding gnulib] > > On 09/27/2017 04:36 PM, Christian Ehrhardt wrote: > > Hi, > > there seems to be an incompatibility to the last glibc due to [1]. > > Gnulib needs to be updated to track the glibc changes (it looks like >

Re: [libvirt] [PATCH v4 7/7] nodedev: Work around the uevent race by hooking up virFileWaitForAccess

On Wed, Sep 20, 2017 at 10:33:14AM -0400, John Ferlan wrote: > > > On 09/18/2017 12:34 PM, Erik Skultety wrote: > > If we find ourselves in the situation that the 'add' uevent has been > > fired earlier than the sysfs tree for a device was created, we should > > use the best-effort approach and

[libvirt] Plans for next release

I'm a bit late, again ... I think we should enter freeze late today, then I can make an rc2 this week end and shoot for a release on the 3rd I hope there is no issue with this, thanks, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/

Re: [libvirt] [PATCH] nwfilter: Fix possible segfault on sometimes consumed variable

On Wed, Sep 27, 2017 at 10:22:17AM -0400, John Ferlan wrote: > The virNWFilterIPAddrMapAddIPAddr code can consume the @addr parameter > on success when the @ifname is found in the ipAddressMap->hashTable > hash table in the call to virNWFilterVarValueAddValue; however, if > not found in the hash

Re: [libvirt] [PATCH v4 5/7] nodedev: Disable/re-enable polling on the udev fd

[...] > > > > nodeDeviceLock(); > > +priv = driver->privateData; > > udev_monitor = DRV_STATE_UDEV_MONITOR(driver); > > > > if (!udevEventCheckMonitorFD(udev_monitor, > > privateData->monitor_fd)) { > > @@ -1725,6 +1727,9 @@ udevEventHandleThread(void *opaque)

Re: [libvirt] [PATCH v2] qemu: add the print of page size in cmd domjobinfo

On Thu, Sep 28, 2017 at 04:32:26PM +0800, Chao Fan wrote: >The command "info migrate" of qemu outputs the dirty-pages-rate during >migration, but page size is different in different architectures. So >page size should be output to calculate dirty pages in bytes. > >Page size is already implemented

[libvirt] [PATCH v2] qemu: add the print of page size in cmd domjobinfo

The command "info migrate" of qemu outputs the dirty-pages-rate during migration, but page size is different in different architectures. So page size should be output to calculate dirty pages in bytes. Page size is already implemented with commit 030ce1f8612215fcbe9d353dfeaeb2937f8e3f94 in qemu.

Re: [libvirt] [RFC] docs: Discourage usage of cache mode=passthrough

On Thu, Sep 21, 2017 at 01:14:04PM -0400, Laine Stump wrote: > On 09/19/2017 03:37 PM, Eduardo Habkost wrote: > > Cache mode=passthrough can result in a broken cache topology if > > the domain topology is not exactly the same as the host topology. > > Warn about that in the documentation. > > > >

[libvirt] [PATCH] iohelper: use saferead if later write with O_DIRECT

One of the usecases of iohelper is to read from pipe and write to file with O_DIRECT. As we read from pipe we can have partial read and then we fail to write this data because output file is open with O_DIRECT and buffer size is not aligned. --- src/util/iohelper.c | 16 ++-- 1 file

[libvirt] [PATCH] spec: don't package product dirs

Directories /var/{lib,cache}/libvirt/qemu/ are created by libvirtd on start and their owner:group is changed according to the config. Thus no need to include them in libvirt-daemon-driver-qemu package. Otherwise we see noisy "directory changed" on rpm -V for the package. --- libvirt.spec.in | 2