Re: [libvirt] [PATCH v4 0/8] Virtio-crypto device support

On 2017/10/25 23:14, Matthew Rosato wrote: > On 07/07/2017 04:07 AM, Longpeng(Mike) wrote: >> As virtio-crypto has been supported in QEMU 2.8 and the frontend >> driver has been merged in linux 4.10, so it's necessary to support >> virtio-crypto in libvirt. >> >> --- > > Hi Mike, > > Seems

Re: [libvirt] [[RFC] 0/8] Implement async QEMU event handling in libvirtd.

On Wed, Oct 25, 2017 at 4:12 PM, Jiri Denemark wrote: > On Tue, Oct 24, 2017 at 10:34:53 -0700, Prerna Saxena wrote: > > > > As noted in > > https://www.redhat.com/archives/libvir-list/2017-May/msg00016.html > > libvirt-QEMU driver handles all async events from the main

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/20/2017 04:54 PM, Christian Borntraeger wrote: > Starting a guest with > > hvm > > > > on an IBM z14 results in > > "qemu-system-s390x: Some features requested in the CPU model are not > available in the configuration: gs" > > This is because guarded storage is fenced for

Re: [libvirt] [PATCH v5 1/4] numa: describe siblings distances within cells

On 10/12/2017 01:31 PM, Wim Ten Have wrote: From: Wim ten Have Add support for describing NUMA distances in a domain's XML description. Below is an example of a 4 node setup:

Re: [libvirt] [PATCH v2 3/3] vbox: Read runtime RDP port and handle autoport

On Wed, 2017-10-25 at 17:35 -0400, John Ferlan wrote: > > On 10/24/2017 05:09 PM, Dawid Zamirski wrote: > > VirutalBox has a IVRDEServerInfo structure available that > > gives the effective runtime port that the VM is using when it's > > running. This is useful when the "TCP/Ports" VBox property

Re: [libvirt] [PATCH v2 1/3] vbox: Remove old unflexible macros

On 10/24/2017 05:09 PM, Dawid Zamirski wrote: > The VBOX_SESSION_OPEN/CLOSE macros are only called in > _vboxDomainSnapshotRestore and they are unflexible because: > > * assume the caller will have variable named "data" > * can only create Write lock type > > As per above, it's not that hard

Re: [libvirt] [PATCH v2 2/3] vbox: Make autoport set RDP port range.

On 10/24/2017 05:09 PM, Dawid Zamirski wrote: > From: Dawid Zamirski > > Originally autoport in vbox driver was setting the port to default value > (3389) which caused multiple VM instances use the same port. Since > libvirt XML does not allow to set port ranges, this patch

Re: [libvirt] [PATCH v2 3/3] vbox: Read runtime RDP port and handle autoport

On 10/24/2017 05:09 PM, Dawid Zamirski wrote: > VirutalBox has a IVRDEServerInfo structure available that > gives the effective runtime port that the VM is using when it's > running. This is useful when the "TCP/Ports" VBox property was set to > port range (e.g. via autoport = "yes" or via

[libvirt] [PATCH] qemu: logrotate: drop minsize directive

On a cloud host it is possible to create 100's of unique instances per day, each leaving behind a /var/log/libvirt/qemu/instance-name.log file that is < 100k. With the current 'minsize 100k' directive, these files are never rotated and hence never removed. Over months of time, tens of thousands of

Re: [libvirt] Libvirt xl to xml converter only picks up first occurrence of an option

On 10/20/2017 08:46 AM, Wei Liu wrote: Hi Jim Hi Wei, Sorry for the delay. Catching up on mail after some days off... I discovered that libvirt's native config file to xml converter for libxl only pick up the first occurrence of an option. For example in a xl cfg file: extra = "abc" ...

[libvirt] [PATCH go-xml] Add bootp option to NetworkDHCP

From: Michal Rostecki Support specyfing concrete file and TFTP server for PXE boot. Signed-off-by: Michal Rostecki --- network.go | 6 ++ network_test.go | 7 +++ 2 files changed, 13 insertions(+) diff --git a/network.go

Re: [libvirt] [PATCH 1/4] virt-aa-helper: fix paths for usb hostdevs

On Tue, 2017-10-17 at 09:04 +0200, Christian Ehrhardt wrote: > On Fri, Sep 29, 2017 at 4:58 PM, Michal Privoznik m> > wrote: > > > On 09/20/2017 04:59 PM, Christian Ehrhardt wrote: > > > If users only specified vendor (the common case) then > > > parsing > > > the xml via

Re: [libvirt] [PATCH 3/4] virt-aa-helper: allow spaces in vm names

On Wed, 2017-09-20 at 16:59 +0200, Christian Ehrhardt wrote: > libvirt allows spaces in vm names, there were issues in the past but > it > seems not removed so the assumption has to be that spaces are > continuing > to be allowed. > > Therefore virt-aa-helper should not reject spaces in vm names

Re: [libvirt] [PATCH 4/4] virt-aa-helper: put static rules in quotes

On Wed, 2017-09-20 at 16:59 +0200, Christian Ehrhardt wrote: > To avoid any issues later on if paths ever change (unlikely but > possible) and to match the style of other generated rules the paths > of the static rules have to be quoted as well. > > Signed-off-by: Christian Ehrhardt

Re: [libvirt] [PATCH 2/4] virt-aa-helper: fix libusb access to udev usb data

On Wed, 2017-09-20 at 16:59 +0200, Christian Ehrhardt wrote: > > + # libusb needs udev data about usb devices (~equal to content of > lsusb -v) > + /run/udev/data/c16[6,7]* r, > + /run/udev/data/c18[0,8,9]* r, > This read-only access looks fine to me. +1 -- Jamie Strandboge |

Re: [libvirt] [PATCH] virt-aa-helper: fix libusb access to udev usb descriptions

On Wed, 2017-10-25 at 14:42 +0200, Christian Ehrhardt wrote: > In bf3a4140 "virt-aa-helper: fix libusb access to udev usb data" the > libusb access to properly detect the device/bus ids was fixed. > > The path /run/udev/data/+usb* contains a subset of that information > we > already allow to be

Re: [libvirt] [PATCH] virt-aa-helper: grant locking permission on -f

On Tue, 2017-10-24 at 16:54 +0200, Christian Ehrhardt wrote: > Hot-adding disks does not parse the full XML to generate apparmor > rules. > Instead it uses -f to append a generic rule for that file > path. > > 580cdaa7: "virt-aa-helper: locking disk files for qemu 2.10" > implemented > the qemu

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/20/2017 10:54 AM, Christian Borntraeger wrote: Starting a guest with hvm on an IBM z14 results in "qemu-system-s390x: Some features requested in the CPU model are not available in the configuration: gs" This is because guarded storage is fenced for compat machines that

Re: [libvirt] [PATCH] AppArmor: add rules needed with additional mediation features brought by Linux 4.14.

intrigeri: > + network unix dgram, > + network unix stream, Hold on, these two rules are probably not needed (chances are that they were needed due to a bug in the AppArmor parser, that got fixed in 2.11.1). I'll double-check tomorrow. Sorry for the noise! -- libvir-list mailing list

Re: [libvirt] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On Wed, Oct 25, 2017 at 05:50 PM +0200, David Hildenbrand wrote: > On 25.10.2017 17:09, Boris Fiuczynski wrote: >> On 10/25/2017 12:23 PM, David Hildenbrand wrote: >>> On 25.10.2017 12:18, Christian Borntraeger wrote: Ping, I plan to submit belows patch for 2.11. We can

[libvirt] [PATCH] AppArmor: add rules needed with additional mediation features brought by Linux 4.14.

--- examples/apparmor/libvirt-qemu | 2 ++ examples/apparmor/usr.sbin.libvirtd | 9 + 2 files changed, 11 insertions(+) diff --git a/examples/apparmor/libvirt-qemu b/examples/apparmor/libvirt-qemu index b341e31f42..5994a35042 100644 --- a/examples/apparmor/libvirt-qemu +++

Re: [libvirt] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 25.10.2017 17:09, Boris Fiuczynski wrote: > On 10/25/2017 12:23 PM, David Hildenbrand wrote: >> On 25.10.2017 12:18, Christian Borntraeger wrote: >>> Ping, I plan to submit belows patch for 2.11. We can then still look into >>> a libvirt<->qemu interface for limiting host-model depending on

Re: [libvirt] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 25.10.2017 17:09, Boris Fiuczynski wrote: > On 10/25/2017 12:23 PM, David Hildenbrand wrote: >> On 25.10.2017 12:18, Christian Borntraeger wrote: >>> Ping, I plan to submit belows patch for 2.11. We can then still look into >>> a libvirt<->qemu interface for limiting host-model depending on

[libvirt] [PATCH go-xml] Add support for CPUTune in Domain

From: Michal Rostecki Signed-off-by: Victoria Efimova Signed-off-by: Ivan Shvedunov Signed-off-by: Miha Pleško Signed-off-by: Michal Rostecki --- domain.go

Re: [libvirt] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/25/2017 12:23 PM, David Hildenbrand wrote: On 25.10.2017 12:18, Christian Borntraeger wrote: Ping, I plan to submit belows patch for 2.11. We can then still look into a libvirt<->qemu interface for limiting host-model depending on machine versions (or not). I think this would be

Re: [libvirt] [PATCH v4 0/8] Virtio-crypto device support

On 07/07/2017 04:07 AM, Longpeng(Mike) wrote: > As virtio-crypto has been supported in QEMU 2.8 and the frontend > driver has been merged in linux 4.10, so it's necessary to support > virtio-crypto in libvirt. > > --- Hi Mike, Seems like this topic has gone quiet.. Is there a v5 in the works?

[libvirt] [PATCH] virt-aa-helper: fix libusb access to udev usb descriptions

In bf3a4140 "virt-aa-helper: fix libusb access to udev usb data" the libusb access to properly detect the device/bus ids was fixed. The path /run/udev/data/+usb* contains a subset of that information we already allow to be read and are currently not needed for the function qemu needs libusb for.

[libvirt] [PATCH 1/2] qemuDomainSetInterfaceParameters: Explicitly reject unsupported net types

For instance, NET_TYPE_MCAST doesn't support setting QoS. Instead of claiming success and doing nothing, we should be explicit about that and report an error. Signed-off-by: Michal Privoznik --- src/qemu/qemu_driver.c | 21 + 1 file changed, 21

[libvirt] [PATCH 2/2] virNetDevSupportBandwidth: Enable QoS for vhostuser

Since vhostuser type is really a tap that is just plugged into different type of bridge, supporting QoS is trivial. Signed-off-by: Michal Privoznik --- src/conf/netdev_bandwidth_conf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[libvirt] [PATCH 0/2] qemu: Fix QoS for vhostuser

Setting QoS on the fly does work for vhostuser. However, it doesn't when starting a domain. So when looking into this, I realized that we should be more explicit about types of interface that do support QoS. Michal Privoznik (2): qemuDomainSetInterfaceParameters: Explicitly reject unsupported

Re: [libvirt] [PATCH v2 02/22] conf: Add usability blockers to virDomainCapsCPUModel

On Wed, Oct 25, 2017 at 10:56 AM +0200, Marc Hartmayer wrote: > On Fri, Oct 13, 2017 at 08:14 PM +0200, Jiri Denemark > wrote: >> When a hypervisor marks a CPU model as unusable on the current host, it >> may also give us a list of features

Re: [libvirt] [[RFC] 0/8] Implement async QEMU event handling in libvirtd.

On Tue, Oct 24, 2017 at 10:34:53 -0700, Prerna Saxena wrote: > > As noted in > https://www.redhat.com/archives/libvir-list/2017-May/msg00016.html > libvirt-QEMU driver handles all async events from the main loop. > Each event handling needs the per-VM lock to make forward progress. In > the case

[libvirt] [PATCH go-xml] Add bootp option to NetworkDHCP

From: Michal Rostecki Support specyfing concrete file and TFTP server for PXE boot. Signed-off-by: Michal Rostecki --- network.go | 6 ++ network_test.go | 7 +++ 2 files changed, 13 insertions(+) diff --git a/network.go

Re: [libvirt] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 25.10.2017 12:18, Christian Borntraeger wrote: > Ping, I plan to submit belows patch for 2.11. We can then still look into > a libvirt<->qemu interface for limiting host-model depending on machine > versions > (or not). I think this would be sufficient for now. Having different host models,

Re: [libvirt] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

Ping, I plan to submit belows patch for 2.11. We can then still look into a libvirt<->qemu interface for limiting host-model depending on machine versions (or not). On 10/20/2017 04:54 PM, Christian Borntraeger wrote: > Starting a guest with > > hvm > > > > on an IBM z14 results in

Re: [libvirt] [PATCH v3 2/2] virtlogd: add missing netserver refcount increment on reload

On 10/25/2017 05:15 AM, Nikolay Shirokovskiy wrote: > > > On 25.10.2017 12:06, John Ferlan wrote: >> >> >> On 10/24/2017 06:47 AM, Nikolay Shirokovskiy wrote: >>> After virNetDaemonAddServerPostExec call in virtlogd we should have >>> netserver refcount set to 2. One goes to netdaemon servers

Re: [libvirt] [PATCH v3 2/2] virtlogd: add missing netserver refcount increment on reload

On 25.10.2017 12:06, John Ferlan wrote: > > > On 10/24/2017 06:47 AM, Nikolay Shirokovskiy wrote: >> After virNetDaemonAddServerPostExec call in virtlogd we should have >> netserver refcount set to 2. One goes to netdaemon servers hashtable >> and one goes to virtlogd own reference to

Re: [libvirt] [PATCH v3 2/2] virtlogd: add missing netserver refcount increment on reload

On 10/24/2017 06:47 AM, Nikolay Shirokovskiy wrote: > After virNetDaemonAddServerPostExec call in virtlogd we should have > netserver refcount set to 2. One goes to netdaemon servers hashtable > and one goes to virtlogd own reference to netserver. Let's add > missing increment in

[libvirt] [PATCH 4/4] qemu: monitor: check monitor not closed upon send

Close monitor sets monitor error if another thread is awating the response to propagate error condition to that thread. However if there is no such thread error will not be set. Now if API thread try to send a message it will hang. This can easily happen for example if API thread does not reach

[libvirt] [PATCH 1/4] libvirt: introduce hypervisor driver shutdown function

This function is called by daemon before shutting down netdaemon threads that serves client requests to make sure all these threads will be able to shutdown. --- daemon/libvirtd.c| 2 ++ src/driver-state.h | 4 src/libvirt.c| 18 ++

[libvirt] [PATCH 2/4] qemu: implement state driver shutdown function

Shutdown function should help API calls to finish when event loop is not running anymore. For this reason let's close agent and qemu monitors. These function will unblock API calls wating for response from qemu process or qemu agent. Closing agent monitor and setting priv->agent to NULL when

[libvirt] [PATCH 0/4] libvirtd: fix hang on termination in qemu driver

Libvirtd termination can hang. For example if some API call in qemu driver awaiting monitor response it will never finish because event loop does not functional during termination. As a result we hang in virNetDaemonClose call during termination as this call finishes RPC threads. Let's ask

[libvirt] [PATCH 3/4] qemu: agent: fix monitor close during first sync

Normally if first agent sync is failed we retry. First sync can also be failed due to agent was closed. In this case we should fail sync otherwise second attempt will hang. --- src/qemu/qemu_agent.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

Re: [libvirt] [PATCH v2 02/22] conf: Add usability blockers to virDomainCapsCPUModel

On Fri, Oct 13, 2017 at 08:14 PM +0200, Jiri Denemark wrote: > When a hypervisor marks a CPU model as unusable on the current host, it > may also give us a list of features which prevent the model from being > usable. Storing this list in virDomainCapsCPUModel will help the

Re: [libvirt] [PATCH v3 1/2] libvirtd: fix crash on termination

On 10/25/2017 04:24 AM, Nikolay Shirokovskiy wrote: > > > On 25.10.2017 11:07, John Ferlan wrote: >> >> >> On 10/24/2017 06:47 AM, Nikolay Shirokovskiy wrote: >>> The problem is incorrect order of qemu driver shutdown and shutdown >>> of netserver threads that serve client requests (thru qemu

Re: [libvirt] [PATCH v3 1/2] libvirtd: fix crash on termination

On 25.10.2017 11:07, John Ferlan wrote: > > > On 10/24/2017 06:47 AM, Nikolay Shirokovskiy wrote: >> The problem is incorrect order of qemu driver shutdown and shutdown >> of netserver threads that serve client requests (thru qemu driver >> particularly). >> >> Net server threads are

Re: [libvirt] [PATCH v3 1/2] libvirtd: fix crash on termination

On 10/24/2017 06:47 AM, Nikolay Shirokovskiy wrote: > The problem is incorrect order of qemu driver shutdown and shutdown > of netserver threads that serve client requests (thru qemu driver > particularly). > > Net server threads are shutdowned upon dispose which is triggered > by last daemon

Re: [libvirt] [PATCH v3 REBASE 0/2] qemu: report block job errors from qemu to the user

ping On 08.09.2017 10:59, Nikolay Shirokovskiy wrote: > So that you can see nice report on migration: > > "error: operation failed: migration of disk sda failed: No space left on > device" > > diff from v2: > > 1. split into 2 patches > 2. change formal documentation where it is